- 16 Aug, 2018 40 commits
-
-
Joshua Bell authored
Comment-only change. TBR=dcheng@chromium.org Change-Id: Iead1d046f07ac1f9ebce3b40d8e98bad672f3011 Reviewed-on: https://chromium-review.googlesource.com/1178305Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#583775}
-
sczs authored
Bug: 865888 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ib8b2a42cb29983fa309b4dd337d526b7a2d4fe05 Reviewed-on: https://chromium-review.googlesource.com/1176871 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#583774}
-
Gaofeng Huang authored
Bug: internal b/112687577 Test: x86 Change-Id: Id6bab442b6c56cef97f91e71a8ec34cfb0f8368e Reviewed-on: https://chromium-review.googlesource.com/1177887 Commit-Queue: Gaofeng Huang <gfhuang@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#583773}
-
Xianzhu Wang authored
- Use separate flags HasDelayedFullPaintInvalidation and SubtreeShouldDoFullPaintInvalidation in LayoutObject instead of using paint invalidation reasons kSubtree and kDelayedFull to simplify logic handling them. - Other cleanup and simplications Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I0946c042c80195dd6cf1d4a9e8c3554dbad1871d Reviewed-on: https://chromium-review.googlesource.com/1123018Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#583772}
-
Scott Violet authored
For the most part this converts IsAshInBrowserProcess() to IsUsingWindowService(). There are a couple of exceptions, mostly around startup. BUG=874489 TEST=covered by tests Change-Id: I55f99fd3c96e6605a672257304fe96a8cd2829cc Reviewed-on: https://chromium-review.googlesource.com/1176641Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#583771}
-
Xida Chen authored
TBR=wjmaclean@chromium.org NOTRY=true Bug: 875009 Change-Id: I23b70833a3a328c4a58e788f324d8f17296a50f7 Reviewed-on: https://chromium-review.googlesource.com/1178684Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#583770}
-
Pedro Amaral authored
Make the bottom toolbar take on the theme color. Also have the bottom toolbar buttons become light/dark depending on theme color. The main complexity of this patch arises from having to support two different ways for theming button icons. Some icons are tintable and in that case we can just set their tint to light or dark. Other icons aren't tintable and have 2 separate drawables and swap them out depending on the theme. There are a still an issue this patch doesn't address. If a site is themed and then we go to tab switcher mode the bottom toolbar will retain the original site's theming. To solve this we'll need a sane theme provider. Bug: 852140 Change-Id: I3ec960c1e5c7d83b663ee97101d6a11e528e4f95 Reviewed-on: https://chromium-review.googlesource.com/1166291 Commit-Queue: Pedro Amaral <amaralp@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#583769}
-
Maks Orlovich authored
URLFetcher will stop working in the browser process with advent of Network Service, and SimpleURLLoader is the replacement API for most clients. Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Icfbc714b2336360abd651ffd0ea4a8aeff1f21c5 Bug: 865018 Reviewed-on: https://chromium-review.googlesource.com/1148471 Commit-Queue: Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#583768}
-
Xida Chen authored
TBR=wjmaclean@chromium.org NOTRY=true Bug: 875006 Change-Id: I84a6dfaee155b0cd241d4bc218af797071839859 Reviewed-on: https://chromium-review.googlesource.com/1178638Reviewed-by:
-
Robert Ogden authored
Cleans up the APIs to show the previews UI by abstracting away the InfoBar and leaving the Previews Tab Helper as the single point of entry to show a Previews UI. Also renames and moves the on dismiss callback so that it no longer has "infobar" in its name. Bug: 874523 Change-Id: I49735c52882d198cd9f6fe95725168691a88681d Reviewed-on: https://chromium-review.googlesource.com/1176544Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#583766}
-
David Davidović authored
Add an STL-compatible iterator interface to EnumSet in order to enable range-based for loops and have a standard interface with which everybody is familiar. This includes defining comparison, increment, and deref operators in EnumSet::Iterator and providing EnumSet::begin and EnumSet::end which behave in the same way as these methods do on STL classes. Bug: 860435 Change-Id: If4312d5b2a1e282ac3510e22bcc29b3525cc43d9 Reviewed-on: https://chromium-review.googlesource.com/1167286 Commit-Queue: David Davidović <davidovic@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#583765}
-
Weilun Shi authored
The reason why the focus ring on gear icon is not square is because the default setting of the button tag. Now we change edit-bg-gear to be a div and add a role=button to make sure the a11y behaviour. Screenshot: https://screenshot.googleplex.com/TJpu8fFFpLW.png Bug: 867777 Change-Id: Ifb8938b1fed139b3ba821976388bf154a58e8d85 Reviewed-on: https://chromium-review.googlesource.com/1176600Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Weilun Shi <sweilun@chromium.org> Cr-Commit-Position: refs/heads/master@{#583764}
-
Ryan Hansberry authored
Create a concrete implementation of AuthTokenValidator, using QuickUnlockStorage as its underlying logic. It is retrieved via a AuthTokenValidatorFactory in order to make browser the owner of the AuthTokenValidatorImpl, not //chromeos. Bug: 870122 Change-Id: I880f6ca519fe2e7ccc6c857cc08927eaf9ac3e32 Reviewed-on: https://chromium-review.googlesource.com/1176436 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#583763}
-
Leonard Grey authored
Since these focus on hover, we pretty much never want to do this (..right?) Bug: 874913 Change-Id: I68c129184e0cf6e5895923696158b10cbefd3adc Reviewed-on: https://chromium-review.googlesource.com/1177914Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#583762}
-
John Z Wu authored
The client needs these errors to respond properly during runtime. Also converted to enum declaration to simplify it a little. Bug: 874320 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Idd4af4b966cb856644eaf927fe41c419a8e7eba2 Reviewed-on: https://chromium-review.googlesource.com/1176649Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#583761}
-
Reza.Zakerinasab authored
This change adds 16 bit decoding to PNGImageDecoder. This change is a part of the bigger change to support 16 bit PNGs in the new color managed canvas API (chromium-review.googlesource.com/c/chromium/src/+/1079788). BUG: 839034 Change-Id: I1bf92e1dd4fcbd79ffe7def33223fb5298649eab Reviewed-on: https://chromium-review.googlesource.com/1148787Reviewed-by:
Leon Scroggins <scroggo@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Cr-Commit-Position: refs/heads/master@{#583760}
-
Quan Nguyen authored
In order to enable webcam-based login (e.g. QR code signin), the OOBE web dialog now implements RequestMediaAccessPermission and CheckMediaAccessPermission. Bug: 868188 Change-Id: I4de25b3b194d2ecc207ca9ff1866809ad357b55c Reviewed-on: https://chromium-review.googlesource.com/1178111Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Quan Nguyen <qnnguyen@chromium.org> Cr-Commit-Position: refs/heads/master@{#583759}
-
Ryan Daum authored
Make it so any active magnification is turned off when the user turns on the screenreader. Because: - The triple tap gesture to enable/disable magnification does not work while screenreader is active. - The management of the two finger gestures inside the magnifier conflict with the touch exploration controller. Bug: internal b/112634029 Test: manual on device Change-Id: I26f39ad4bc82725f19dbd7e1caab97808eeb6de4 Reviewed-on: https://chromium-review.googlesource.com/1177636 Commit-Queue: Ryan Daum <rdaum@chromium.org> Reviewed-by:Alex Sakhartchouk <alexst@chromium.org> Cr-Commit-Position: refs/heads/master@{#583758}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/fa2b2d62d77d..74ed734d717a git log fa2b2d62d77d..74ed734d717a --date=short --no-merges --format='%ad %ae %s' 2018-08-16 saza@webrtc.org Add AEC proxies for simple deprecation of AEC configurability. 2018-08-16 kthelgason@webrtc.org Remove kVideoCodecUnknown from WebRTC. Created with: gclient setdep -r src/third_party/webrtc@74ed734d717a The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I6f2365936b91518b338fb39f735e531764a99e7e Reviewed-on: https://chromium-review.googlesource.com/1178244Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#583757}
-
Peter Wen authored
Fix perf bots. NOTRY=true # Fixing perf bots Bug: 874956 Change-Id: I7d8ec786b1e32359aef5a2f487180ba3614c5918 Reviewed-on: https://chromium-review.googlesource.com/1178466Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#583756}
-
Philip Rogers authored
This patch adds layer list logging. To use, start content shell with: --vmodule=layer_tree_host=3 Sample output: layer id 11 element_id: (0) bounds: 800x600 opacity: 1 position: 0.000000,0.000000 draws_content: 1 scrollable: 0 contents_opaque: 1 transform_tree_index: 2 clip_tree_index: 1 effect_tree_index: 1 scroll_tree_index: 1 layer id 14 ... There is currently no logging for cc::Layer so a selection of important properties has been dumped. Bug: 854200 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I938492167619c262976083291bd6db9b4a39fef5 Reviewed-on: https://chromium-review.googlesource.com/1175855 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:David Bokan <bokan@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#583755}
-
Jialiu Lin authored
1. Previously gaia::CanonicalizeEmail(..) didn't handle upper case gmail correctly. e.g.: CanonicalizeEmail("USER.NAME@GMAIL.COM") previously return "user.name@gmail.com". Instead it should return "username@gmail.com". 2. When input is not a valid email, instead of triggering NOTREACHED, it now returns the input in lower case. In this way, the downstream use of this method can be more flexible. Bug: 874050, 859622 Change-Id: I2aeeb30cb1cd69c65b96de0fdd3a8c00cb2f274e Reviewed-on: https://chromium-review.googlesource.com/1174909Reviewed-by:Roger Tawa <rogerta@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Commit-Queue: Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#583754}
-
Michael Spang authored
Creation of modeset buffer for UDL devices is broken as if this change. This reverts commit df7cd324. Bug: 874755 Test: Connect UDL display. TBR: dnicoara@chromium.org Change-Id: Ib8943f046eece90624f7a03fdc4fd9be23bdf344 Reviewed-on: https://chromium-review.googlesource.com/1178301 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#583753}
-
Lucas Furukawa Gadani authored
This CL adds an HTMLPortalElement to represent portals, and creates a mojo connection to the browser-exposed interface when the element is attached to the document. Bug: 865565 Change-Id: Ib4e8053969d3e7ec138db84aae211b9a97a19b3c Reviewed-on: https://chromium-review.googlesource.com/1167111 Commit-Queue: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#583752}
-
Reilly Grant authored
In order to determine how Chrome Apps are using the chrome.bluetoothSocket API this histogram collects the hashed UUIDs of the services created or connected to by an application using the API. A list of well known service UUIDs and their hashes has been added to enums.xml. This is a copy of the mechanism used to record service UUIDs requested through the Web Bluetooth API. Change-Id: Iad41d1fa1ee30ef16e27b47bdfc5b712f8b5d4d3 Reviewed-on: https://chromium-review.googlesource.com/1171741 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#583751}
-
Micah Morton authored
This feature flag gates the use of minijail to sandbox shill (the network manager) on CrOS. Defaults to true. We want a feature flag for this in case any unforseen sandboxing compications occur on the beta or stable channels and Finch is our only way of reverting. CQ-DEPEND=CL:1172729,CL:1177883 "sudo -u chronos dbus-send --system --type=method_call --print-reply \ --dest=org.chromium.ChromeFeaturesService \ /org/chromium/ChromeFeaturesService \ "org.chromium.ChromeFeaturesServiceInterface.IsShillSandboxingEnabled" Bug: 649417 Test: Following command returned true (flag is true by default): Change-Id: I359b28d463f8f0ce861739d7f165f5437690bae5 Reviewed-on: https://chromium-review.googlesource.com/1173260 Commit-Queue: Micah Morton <mortonm@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#583750}
-
Weidong Guo authored
Changes: 1. Press home button, the opened folder or search result page will be closed. Press home button again, app list will go back to first page. 2. Tapping background or outside app list view, opening an app in folder or opening a search result should only close the folder or search results page. It should not reset pagination. Bug: 869627 Test: AppListViewHomeLauncherTest.BackAction Change-Id: Ic8d4d5f76c7225ce7433750c2cb1ce8d2c3d7e59 Reviewed-on: https://chromium-review.googlesource.com/1176978Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#583749}
-
Xiaoqian Dai authored
After adding a printer, it's possible for the user to edit the added printer's info. Only allow saving the edited info if the provided info is valid. Bug: 861696 Change-Id: Id42ec655e3b50ba13a424489b9d57d77e0be4228 Reviewed-on: https://chromium-review.googlesource.com/1168031 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#583748}
-
Xida Chen authored
This reverts commit b786c57c. Reason for revert: <INSERT REASONING HERE> layout test failed: https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20ASAN/15210 Original change's description: > [css-properties-values-api] Support CSSStyleValues in StylePropertyMap.set. > > In StyleValueToCSSValue, when checking whether a certain CSSStyleValue > matches the property in question, we now ask the registration (via > CSSOMTypes) if the CSSStyleValue matches. If it doesn't match, we throw > a TypeError like for normal properties. If it does match, the CSSStyleValue > is stringified, tokenized, and set on the style rule as tokens. > > I have postponed support for <color> and <transform-function>, because > CSSUnsupportedStyleValue currently does not handle registered custom > properties at all. This is appropriate to fix in a separate CL. > > Note that, because the string version of StylePropertyMap.set also uses > StyleValueToCSSValue, it will no longer be possible to set registered > custom properties with a string--even if the syntax is matched. > A subsequent CL will fix this. > > R=futhark@chromium.org > > Bug: 641877 > Change-Id: Ie0cc2f87e39f8f59015824bfd1b81efaf402c326 > Reviewed-on: https://chromium-review.googlesource.com/1175822 > Commit-Queue: Anders Ruud <andruud@chromium.org> > Reviewed-by: Rune Lillesveen <futhark@chromium.org> > Cr-Commit-Position: refs/heads/master@{#583695} TBR=futhark@chromium.org,andruud@chromium.org Change-Id: I2486be60ce81497253bdf64903ea870832a0ef9e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 641877 Reviewed-on: https://chromium-review.googlesource.com/1178503Reviewed-by:
-
John Budorick authored
Bug: 861983 Change-Id: Iea3c93e295da205381b986edc31aaaba862efb47 Reviewed-on: https://chromium-review.googlesource.com/1177627Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#583746}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/fccde774f480..a82d0a22067f git log fccde774f480..a82d0a22067f --date=short --no-merges --format='%ad %ae %s' 2018-08-16 dhanyaganesh@chromium.org cbuildbot: Create a metric for failing stage Created with: gclient setdep -r src/third_party/chromite@a82d0a22067f The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ie53518584a67e6febdc35b08e6e351d39c56cfcf Reviewed-on: https://chromium-review.googlesource.com/1178242Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#583745}
-
Ted Choc authored
BUG=866639 Change-Id: If645b1f9f57f64d87b30f49e62a5063b12f1ce08 Reviewed-on: https://chromium-review.googlesource.com/1169766 Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#583744}
-
Koji Ishii authored
Following bot results are included. 8878 8880 8882 8886 8893 8900 8907 8915 8918 8923 8925 3 lines were removed and 2 lines were deflaked by consecutive results since 8877. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I8c73e2c8c785e87bb97f4f8b5260b7c838421488 Reviewed-on: https://chromium-review.googlesource.com/1175706 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#583743}
-
Pedro Amaral authored
This CL changes the accessibility string from "Search accelerator" to "Search button" Buganizer link: https://buganizer.corp.google.com/issues/112280251 Change-Id: I44653847eb20b52957b7b25c34e0a820a6cbfbe0 Reviewed-on: https://chromium-review.googlesource.com/1176583Reviewed-by:
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/922ba81b497b..ed63b1319414 git log 922ba81b497b..ed63b1319414 --date=short --no-merges --format='%ad %ae %s' 2018-08-16 nednguyen@google.com Add retry for ts_proxy commands upon raised exception 2018-08-16 perezju@chromium.org [Telemetry] Add story expectations for Pixel 2 bots 2018-08-16 etienneb@chromium.org Add windows performance counters processing. 2018-08-16 nednguyen@google.com Make ts_proxy error handleable by Telemetry story_runner Created with: gclient setdep -r src/third_party/catapult@ed63b1319414 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:873616,chromium:874391,chromium:872900,chromium:873616 TBR=sullivan@chromium.org Change-Id: Ia5d6e592153afef2fee1316ec25f3d09c44b0b90 Reviewed-on: https://chromium-review.googlesource.com/1178241Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#583741}
-
Lei Zhang authored
Split CreateUDPSocketOnUIThread() into a standalone function so less of PrivetTrafficDetector lives on the UI thread. Change-Id: Ide58478bb235d9c1da72fccd6b86da35cd3997af Reviewed-on: https://chromium-review.googlesource.com/1177443 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#583740}
-
Kyle Horimoto authored
This CL updates MultideviceHandler to provide the settings page with the state of all multi-device features. Note that this CL uses the MultiDevicePageContentData definition from https://chromium-review.googlesource.com/c/chromium/src/+/1173658 when passing its data, so these CLs should be landed at the ~same time. Bug: 824568 Change-Id: Ib343c454a88a28f1021e2b90cbc3f3d33e3f449b Reviewed-on: https://chromium-review.googlesource.com/1176658 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#583739}
-
Elly Fong-Jones authored
Bug: 832676 Change-Id: I1c5beaf588e62ee17220e605768c860692e92f53 Reviewed-on: https://chromium-review.googlesource.com/1177685Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#583738}
-
Lei Zhang authored
- Remove net::AddressFamily ctor parameter and |address_family_|. It's always IPv4. - Remove |callback_runner_| since it is always the UI thread. Add a DCHECK to make sure that is the case. - Use base::OnceClosure in more places. - Fix some nits and better explain how the class behaves. Change-Id: Idd15c40df11c39056b9e40aab6a7bee6c3805e2e Reviewed-on: https://chromium-review.googlesource.com/1176642 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
-
Zach Helfinstein authored
Take out print statements, improve comments, etc. Bug: None Change-Id: I0df82103e0cea7fa2d9b86356ea01f51425e144f Reviewed-on: https://chromium-review.googlesource.com/1176481 Commit-Queue: Zach Helfinstein <zhelfins@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#583736}
-
