GitLab

BUG=325029
TEST=none

Review URL: https://codereview.chromium.org/559843003

Cr-Commit-Position: refs/heads/master@{#294115}

BUG=410639
TEST=components_unittests
R=tengs@chromium.org, cbentzel@chromium.org

Review URL: https://codereview.chromium.org/538843002

Cr-Commit-Position: refs/heads/master@{#294114}

Before this CL:
Candidate processes info is saved in EmbeddedWorkerInstance, when a new
worker instance is created for a same scope, the info will be absent for
the new worker. E.g., periodic update will spawn a new process every time.

After this CL:
Candidate processes info will be saved in  ServiceWorkerProcessManager
key by registration scope. Then different versions with the same scope could
share this info.

BUG=399982
TEST=content_unittests --gtest_filter=ServiceWorker*

Review URL: https://codereview.chromium.org/443593002

Cr-Commit-Position: refs/heads/master@{#294113}

app_window_custom_bindings.js depends on currentWindowInternal.

BUG=387288

Review URL: https://codereview.chromium.org/540273002

Cr-Commit-Position: refs/heads/master@{#294112}

Used to take two text files in obscure ninja format, now
expects the targets to compare. e.g.

tools/gn/bin/gyp_flag_compare.py base

or

tools/gn/bin/gyp_flag_compare.py breakpad_processor_support processor_support

TBR=brettw@chromium.org
BUG=335824

Review URL: https://codereview.chromium.org/559853002

Cr-Commit-Position: refs/heads/master@{#294111}

https://chromium.googlesource.com/chromium/blink/+log/a8468bace78ab779460dd6bc1f5bdc63940bf014..adfaa7e06fafd9c57a4b019fbef0950b185c4d87
TBR=keishi@chromium.org,jianli@chromium.org

Review URL: https://codereview.chromium.org/558753004

Cr-Commit-Position: refs/heads/master@{#294110}

This operation will be serviced on the IO thread in the GPU process and is expected to be very quick.

These sync allocations should be infrequent and happen mostly during startup to enable rendering via EGLImage.

BUG=380861

Review URL: https://codereview.chromium.org/540443002

Cr-Commit-Position: refs/heads/master@{#294109}

Change the transforms of the windows in overview mode to better match the mocks.
Notable change in the code is that instead of computing the terminal transforms
at the start, and then computing the intermediate transforms from those, we
compute less amount of information at start, and compute the transform at each
state from those. This makes it easier to perform non-linear transforms during
the scrolls.

BUG=403849
R=oshima@chromium.org

Review URL: https://codereview.chromium.org/556043002

Cr-Commit-Position: refs/heads/master@{#294108}

Resources represented by a data URL will stay being considered to be
unique origin resource but are changed to allow cross origin access by
the Access-Control-Allow-Origin header.

We take this approach mainly because we want scripts in an iframe with
a data URL specified to its src attribute to be executed as a script on
a unique origin resource, not on the parent frame.

We can choose to treat "loading" of data URL specially as same origin
while execution as different origin. But such an approach complicates
security policy checking algorithm.

Grammar checking code is added to ensure we emit a valid content-type.

Blink side CL https://codereview.chromium.org/54173002/ will be landed
first to temporarily disable layout tests that will break, and then
this CL will be landed.

BUG=308768

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291007

Review URL: https://codereview.chromium.org/294193002

Cr-Commit-Position: refs/heads/master@{#294107}

[FAIL] org.chromium.content.browser.input.ImeTest#testKeyCodesWhileSwipingText:
junit.framework.AssertionFailedError
  at org.chromium.content.browser.input.ImeTest.assertUpdateStateCall(ImeTest.java:737)
  at org.chromium.content.browser.input.ImeTest.testKeyCodesWhileSwipingText(ImeTest.java:484)
  at java.lang.reflect.Method.invokeNative(Native Method)
  at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214)
  at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199)
  at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192)
  at org.chromium.content_shell_apk.ContentShellTestBase.runTest(ContentShellTestBase.java:227)
  at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
  at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
  at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:554)
  at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1701)

TBR= jianli, jdduke, aurimas
BUG=412632

Review URL: https://codereview.chromium.org/556123002

Cr-Commit-Position: refs/heads/master@{#294106}

Handlind back key event and clearing focus of url bar
and retaining focus to content view.

BUG=

Review URL: https://codereview.chromium.org/540853002

Cr-Commit-Position: refs/heads/master@{#294105}

When the system wakes up, it takes a few seconds for the correct
Bluetooth state to propogate to the app. A bad sync state allows
the lock screen to be unlocked even though the phone is not connected
in reality.

BUG=410082
TEST=manual

Review URL: https://codereview.chromium.org/528423002

Cr-Commit-Position: refs/heads/master@{#294104}

window list

As discussed - added the window/activity order management functions
to the WindowListProvider and changed the use cases (at least partially).
There are still more things to do, but we might want to do that either
 a. incrementally or
 b. as a separate issue since the associated BUG(388085) has nothing to
    do with this.
Note: This is more work - especially because the code in question is being
worked on actively by others.

BUG=407103
TEST=athena_unittest.SimpleChecks, athena_unittest.TestWindowOrderingFunctions

Review URL: https://codereview.chromium.org/480293003

Cr-Commit-Position: refs/heads/master@{#294103}

Most DemuxerStream implementation doesn't need this method. Provide an empty default implementation in the base class so that subclass doesn't need to override it.

TBR=gunsch@chromium.org

Review URL: https://codereview.chromium.org/560563002

Cr-Commit-Position: refs/heads/master@{#294102}

fileBrowserPrivate was a misnomer as the term "file manager"
is used everywhere else (ex. src/ui/file_manager).

Note that fileBrowserHandler is not renamed because it's a
public API.

TEST=git grep -E -i file.?browser.?private || echo ok
BUG=411762
R=achuith@chromium.org, asvitkine@chromium.org, benwells@chromium.org, mtomasz@chromium.org, thestig@chromium.org, yoshiki@chromium.org

Review URL: https://codereview.chromium.org/550863003

Cr-Commit-Position: refs/heads/master@{#294101}

This partially reverts commit 6af92606 (r293066).

(But we keep the ability to pass 0 to not have a button.)

BUG=406222

Review URL: https://codereview.chromium.org/554203002

Cr-Commit-Position: refs/heads/master@{#294100}

Now that Blink-side objects about MediaStream are moved to oilpan's heap, we need to call WebHeap::collectGarbage in MediaStream tests to test that a particular object is gone. This CL adds necessary WebHeap::collectGarbage calls to content_unittests about MediaStreams.

Review URL: https://codereview.chromium.org/549153002

Cr-Commit-Position: refs/heads/master@{#294099}

This matches gyp behaviour.

R=brettw@chromium.org,thakis@chromium.org
BUG=335824

Review URL: https://codereview.chromium.org/558853002

Cr-Commit-Position: refs/heads/master@{#294098}

BUG=393331
NOTRY=true

Review URL: https://codereview.chromium.org/559793002

Cr-Commit-Position: refs/heads/master@{#294097}

When F4 is selected and the submenu is showing then we should hide
submenu instead of showing the submenu item selection or opening submenu.
Condition added to check this situation.

BUG=344491

Review URL: https://codereview.chromium.org/484133002

Cr-Commit-Position: refs/heads/master@{#294096}

BUG=388558
TEST=Verified on linux_chromeos.

Review URL: https://codereview.chromium.org/553303002

Cr-Commit-Position: refs/heads/master@{#294095}

Resolve c++03 ambiguity introduced by CL 478153003 and 497553004, since
we haven't officially switched over to c++11 yet.

Review URL: https://codereview.chromium.org/561463002

Cr-Commit-Position: refs/heads/master@{#294094}

Framework does not clamp onDraw to only the visible area. However must
still request functor in this case to support rt-side animation, and to
obtain the correct draw matrix. This means HardwareRenderer must be able
to handle not having a parent frame available.

BUG=412623

Review URL: https://codereview.chromium.org/551023002

Cr-Commit-Position: refs/heads/master@{#294093}

BUG=411143

Review URL: https://codereview.chromium.org/544403002

Cr-Commit-Position: refs/heads/master@{#294092}

The eventually rect was returning as smaller than the visible rect, which
caused tiles to be dropped.  Returning a delta larger or equal to zero
fixes it.

BUG=407776

Review URL: https://codereview.chromium.org/555643002

Cr-Commit-Position: refs/heads/master@{#294091}

Suppression (error hash=#E226F7559AD360E7#):
For more info on using suppressions see http://dev.chromium.org/developers/tree-sheriffs/sheriff-details-chromium/memory-sheriff#TOC-Suppressing-memory-reports
{
<insert_a_suppression_name_here>
Memcheck:Leak
fun:_Znw*
fun:_ZN4base8internal20PostTaskAndReplyImpl16PostTaskAndReplyERKN15tracked_objects8LocationERKNS_8CallbackIFvvEEESA_
fun:_ZN4base10TaskRunner16PostTaskAndReplyERKN15tracked_objects8LocationERKNS_8CallbackIFvvEEES9_
fun:_ZN10disk_cache15SimpleEntryImpl13CloseInternalEv
fun:_ZN10disk_cache15SimpleEntryImpl24RunNextOperationIfNeededEv
fun:_ZN10disk_cache15SimpleEntryImpl21DoomOperationCompleteERKN4base8CallbackIFviEEENS0_5StateEi
}
Original CL: https://codereview.chromium.org/477973002/
Reland: https://codereview.chromium.org/528233003/

The SimpleCache backend wasn't given a chance to finish up a close operation before the IO messageloop closed at the end of functions.  The tests now run the loop in TearDown.

The original patch is PatchSet1 and the fix is PatchSet3.

BUG=392621

Review URL: https://codereview.chromium.org/543093003

Cr-Commit-Position: refs/heads/master@{#294090}

Review URL: https://codereview.chromium.org/502653002

Cr-Commit-Position: refs/heads/master@{#294089}

On the swarming bots we are seeing flakes in the plugin tests. Setting the atom fails because the atom table fills up. I tracked this down to the fact that sometimes the atom destruction path doesn't get hit depending on how the plugin shuts down. Rather than fix it, I removed this code and used a simpler mechanism to get the title & version in the browser process.

BUG=412042

Review URL: https://codereview.chromium.org/557893003

Cr-Commit-Position: refs/heads/master@{#294088}

BUG=412367

Review URL: https://codereview.chromium.org/558603002

Cr-Commit-Position: refs/heads/master@{#294087}

https://skia.googlesource.com/skia/+log/ef53f158de34ffaebd6537f1afd4adf38717987d..d954498c01ccf0417feacf89e45d0c62a06a813b

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=fmalita@google.com

Review URL: https://codereview.chromium.org/561563002

Cr-Commit-Position: refs/heads/master@{#294086}

Currently, blink's FrameLoader.cpp contains a complex, hacky function to
determine when to inform the rest of chromium that loading is complete. This
complexity is only necessary to support layout tests. This puts the requisite
logic in the layout test harness. This logic is behind a temporary flag, in
order to permit both blink and chromium to flip to the new definition of load
completion simultaneously.

BUG=

Review URL: https://codereview.chromium.org/550343002

Cr-Commit-Position: refs/heads/master@{#294085}

New! With:
- Disable for platforms that report no data.
- Extra logging to help diagnose why it's disabled.
- Fixes asserts (assert _var is not None instead of just _var).

BUG=336558
TEST=python tools/telemetry/run_tests msr
R=tonyg

Review URL: https://codereview.chromium.org/553163004

Cr-Commit-Position: refs/heads/master@{#294084}

* keep alive has to be incremented at startup.
* exclude more code that depends on ash.
* create a screen for shutdown

Minor cleanup
* remove all containers when ScreenManager is deleted.

BUG=397167, 401044
TEST=AthenaShutdownTest.Shutdown

Review URL: https://codereview.chromium.org/558823002

Cr-Commit-Position: refs/heads/master@{#294083}

Previously, the selection was cleared and the handles dismissed if
Chrome was backgrounded (via home or task switcher buttons) or the
screen was locked. This breaks any kind of multitasking with an
active selection. Instead, in such cases preserve the selection,
hiding the action bar and restoring as necessary when the view is
reattached or is reshown.

Also expose a programmatic way for preserving the selection when the
view loses focus, which is typically undesirable (tapping omnibox or
switching tabs), but not always.

BUG=406925

Review URL: https://codereview.chromium.org/516523003

Cr-Commit-Position: refs/heads/master@{#294082}

Now RendererImpl only takes DemuxerStreamProvider (minimal interface it needs)
instead of the full Demuxer. Also, this makes other Renderer implementations
easier since they don't necessarily have access to a full Demuxer.

BUG=392236
TEST=No functionality change and all existing tests pass.

Review URL: https://codereview.chromium.org/523283002

Cr-Commit-Position: refs/heads/master@{#294081}

https://chromium.googlesource.com/chromium/blink/+log/02fbb58eafa10f9ccc920c3f2683808342f83b5e..a8468bace78ab779460dd6bc1f5bdc63940bf014
TBR=keishi@chromium.org,jianli@chromium.org

Review URL: https://codereview.chromium.org/551223003

Cr-Commit-Position: refs/heads/master@{#294080}

BUG=352293

Review URL: https://codereview.chromium.org/552283003

Cr-Commit-Position: refs/heads/master@{#294079}

DuplicateHandle closes the handle even if there's an error.

BUG=412200
R=cpu@chromium.org

Review URL: https://codereview.chromium.org/554163002

Cr-Commit-Position: refs/heads/master@{#294078}

Disable ImeTest#testFinishComposingText and ImeTest#testEnterKeyEventWhileComposingText since they are flaking.

BUG=411756,315548
TBR=aurimas@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/562513002

Cr-Commit-Position: refs/heads/master@{#294077}

This test was disabled temporarily while changing how the fake
UserGestureIndicator is set for tests.

Depends on blink patch:
https://codereview.chromium.org/518633002/

BUG=408426, 406336
NOTRY=true
TBR=jochen@chromium.org

Review URL: https://codereview.chromium.org/557153002

Cr-Commit-Position: refs/heads/master@{#294076}