GitLab

The associated bug seems to imply a crash on this line
ClassifyPage(controller_->GetWebContents()->GetURL())
in OmniboxEditModel::OpenMatch().

This change corrects the part of the test that may fail
(if there's no active tab for some reason).
I think controller_ is always valid (the rest of the edit
model code use it without testing it for non-NULL).
But I see at least two places in OmniboxEditModel that
test for the non-NULLness of controller_->GetWebContents().
Hence, I think it might be able to be NULL, so this
change adds a test for it here too.

TEST=new code compiles
BUG=142931


Review URL: https://chromiumcodereview.appspot.com/12250014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182244 0039d316-1c4b-4281-b951-d872f2087c98

Bug=174123
Test=Manual

Repro steps:
1) Run chrome with --ash-enable-workspace-scrubbing
2) Go to chrome://gesture
3) Modify the value of "Duration of the animations to start cycling"
4) Ensure that you have several maximized workspaces
5) Move fingers vertically on track pad. Notice difference in the duration of the animations to start cycling through workspaces
Repeat 3 - 5 as many times as you see fit

Review URL: https://chromiumcodereview.appspot.com/12212040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182243 0039d316-1c4b-4281-b951-d872f2087c98

All the changes are in comment. No semantics are changed.

BUG=175657
TEST=none
TBR=mtomasz@chromium.org

Review URL: https://codereview.chromium.org/12254009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182242 0039d316-1c4b-4281-b951-d872f2087c98

BUG=174873, 170629

Review URL: https://codereview.chromium.org/12220089

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182241 0039d316-1c4b-4281-b951-d872f2087c98

The port forwarder command line tool was broken as
https://chromiumcodereview.appspot.com/12211070 made Forwarder require a
valid valgrind tool instance to be passed in. Fix the problem by
giving Forwarder a default tool.

NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/12262011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182239 0039d316-1c4b-4281-b951-d872f2087c98

BUG=155525


Review URL: https://chromiumcodereview.appspot.com/12255007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182238 0039d316-1c4b-4281-b951-d872f2087c98

All the changes are in comment. No semantics are changed.

BUG=175657
TEST=none
TBR=mtomasz@chromium.org

Review URL: https://codereview.chromium.org/12207152

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182237 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182236 0039d316-1c4b-4281-b951-d872f2087c98

BUG=175657
TEST=mock Files.app works.
TBR=mtomasz@chromium.org

Review URL: https://codereview.chromium.org/12230013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182235 0039d316-1c4b-4281-b951-d872f2087c98

TBR=enne


Review URL: https://chromiumcodereview.appspot.com/12230006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182234 0039d316-1c4b-4281-b951-d872f2087c98

The policy is currently disabled (by saying that it is supported on no platforms), pending a UI treatment that allows users to know when deleting browsing history is prohibited.

TBR=rlp@chromium.org

BUG=175419

Review URL: https://chromiumcodereview.appspot.com/12209091

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182233 0039d316-1c4b-4281-b951-d872f2087c98

BUG=175657
TBR=mtomasz@chromium.org, haruki@chromium.org

Review URL: https://codereview.chromium.org/12207150

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182232 0039d316-1c4b-4281-b951-d872f2087c98

WifiPHYLayerProtocol characterizes the physical layer (PHY) protocol
of the current association with an 802.11 access point. It uses
the common nomenclature of referring to the IEEE 802.11 standard
amendment which introduced the protocol, i.e. a/b/g/n.

TBR=sky
BUG=174414

Review URL: https://codereview.chromium.org/12082090

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182231 0039d316-1c4b-4281-b951-d872f2087c98

> Fix issue 174250, crash when reloading packaged app.
> 
> When a shell window was closed, it wasn't removed from the registry immediately
> (it was removed in a callback from OnNativeClose, which happens a bit later.)
> This meant that when the app was loaded again, the window was still in the
> registry with a stale pointer to the old extension. ExtensionSettingsHandler
> was tickling this by iterating shell windows on extension load.
> 
> BUG=174250
> 
> 
> Review URL: https://chromiumcodereview.appspot.com/12210107

TBR=jeremya@chromium.org
Review URL: https://codereview.chromium.org/12207155

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182230 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182229 0039d316-1c4b-4281-b951-d872f2087c98

Re-land of https://codereview.chromium.org/12220063/.

This will hold on to a reference to the buffer while the buffer is being used by WebRTC. I also tried to fix the places where synchronization was missing (mostly for the params_ instance).

BUG=173987
TBR=tommi@chromium.org


Review URL: https://chromiumcodereview.appspot.com/12261003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182227 0039d316-1c4b-4281-b951-d872f2087c98

TBR=zhaoqin
BUG=175985


Review URL: https://chromiumcodereview.appspot.com/12262009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182226 0039d316-1c4b-4281-b951-d872f2087c98

Just c4267 build suppressions. 

BUG=166496
BUG=167187
TBR=gman@chromium.org
R=gman@chromium.org
Review URL: https://codereview.chromium.org/12261007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182225 0039d316-1c4b-4281-b951-d872f2087c98

Just c4267 build suppressions. 

BUG=166496
BUG=167187
TBR=jam@chromium.org
R=jam@chromium.org
Review URL: https://codereview.chromium.org/12254004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182224 0039d316-1c4b-4281-b951-d872f2087c98

Just c4267 build suppressions. 

BUG=166496
BUG=167187
TBR=yzshen@chromium.org
R=yzshen@chromium.org
Review URL: https://codereview.chromium.org/12258010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182223 0039d316-1c4b-4281-b951-d872f2087c98

In class method (not instance methods), we shouldn't use this because 'this' indicates not "instance" but "class" itself.

BUG=175657
TEST=Files.app launches. 
TBR=mtomasz@chromium.org, haruki@chromium.org

Review URL: https://chromiumcodereview.appspot.com/12257002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182222 0039d316-1c4b-4281-b951-d872f2087c98

BUG=175657
TEST=none
TBR=mtomasz@chromium.org, haruki@chromium.org

Review URL: https://codereview.chromium.org/12257008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182221 0039d316-1c4b-4281-b951-d872f2087c98

Add const to some the  retrieve methods.


BUG=149349


Review URL: https://chromiumcodereview.appspot.com/12221147

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182220 0039d316-1c4b-4281-b951-d872f2087c98

This will help track down any problems with the installation process.

BUG=None


Review URL: https://chromiumcodereview.appspot.com/12220146

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182219 0039d316-1c4b-4281-b951-d872f2087c98

This prevents us from updating textures currently in use by active
tree before tree activation.

BUG=173886


Review URL: https://chromiumcodereview.appspot.com/12185008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182218 0039d316-1c4b-4281-b951-d872f2087c98

Closure linter checks if descriptions end with valid punctuation such as a period. This patch adds periods.

BUG=175657
TEST=none
TBR=mtomasz@chromium.org, haruki@chromium.org

Review URL: https://codereview.chromium.org/12262003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182217 0039d316-1c4b-4281-b951-d872f2087c98

There are a variety of benchmarks that want to measure the cost of
raster for now bin only, and similarly, only for low res tiles. This
patch provides very primitive infrastructure for this.

R=reveman
CC=egraether,skyostil

BUG=175976

Review URL: https://chromiumcodereview.appspot.com/12258004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182216 0039d316-1c4b-4281-b951-d872f2087c98

These methods will be used to implement InitiateUpload{New,Existing}Operation
on Drive API v2.

BUG=148632
TEST=Ran unit_tests


Review URL: https://chromiumcodereview.appspot.com/12225101

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182215 0039d316-1c4b-4281-b951-d872f2087c98

This CL converts the SessionLengthLimiter from a RepeatingTimer that
fires once per second to a OneShotTimer that fires when the session
time is up and the user should be logged out.

BUG=175797
TEST=Manual, unittests


Review URL: https://chromiumcodereview.appspot.com/12218123

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182214 0039d316-1c4b-4281-b951-d872f2087c98

The test wasn't testing what it was supposed to; it didn't destroy the storage
systems of a Profile and recreate them. We can't test crash recovery like this.

BUG=172770
R=jochen


Review URL: https://chromiumcodereview.appspot.com/12208131

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182213 0039d316-1c4b-4281-b951-d872f2087c98

control: https://codereview.chromium.org/12221154/
Review URL: https://codereview.chromium.org/12225148

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182212 0039d316-1c4b-4281-b951-d872f2087c98

BUG=129187

Review URL: https://codereview.chromium.org/12213074

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182211 0039d316-1c4b-4281-b951-d872f2087c98

TBR=mal, cpu

BUG=175842

Review URL: https://codereview.chromium.org/12230010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182210 0039d316-1c4b-4281-b951-d872f2087c98

The resulting JSON is equivalent, but now everything is smashed into one line.

This shaves 30% off the size of the NetLog dumps.

BUG=132160


Review URL: https://chromiumcodereview.appspot.com/12226132

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182207 0039d316-1c4b-4281-b951-d872f2087c98

Wait 30 secs before activating PowerSaveBlocker to dismiss small uploads.

BUG=173119


Review URL: https://chromiumcodereview.appspot.com/12226005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182206 0039d316-1c4b-4281-b951-d872f2087c98

Currently we are just coalescing scrollUpdates and we end up not utilizing
this when we have interleaved scrollUpdate and pinchUpdates. This change makes
that possible and makes sure the gesture_event_queue doesnt get flooded with
interleaved scroll and pinch updates.

BUG=174189


Review URL: https://chromiumcodereview.appspot.com/12225056

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182205 0039d316-1c4b-4281-b951-d872f2087c98

For current impl, Resource ID of a file is not updated for this sequence:
 (1) Add a file with resource_id_1
-- wait for synced --
 (2) Delete the file
 (3) Add a file with resource_id_2, and same content with the first file.

If the (2) and (3) come together, (2) is squashed into (3). And then (3) becomes nop since the content is not modified.

As the result, the metadata of the file has wrong Resource ID and all other change is ignored.

(notry, since most of try jobs are passed, and failed try looks not related to the patch)

BUG=175667
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/12223088

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182204 0039d316-1c4b-4281-b951-d872f2087c98

This patch changes "add language" overlay page in chrome://settings/language
from listed links to drop-down menu.

This patch only affects Chrome OS settings page.

BUG=133346
TEST=try bots

Review URL: https://chromiumcodereview.appspot.com/12087105

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182203 0039d316-1c4b-4281-b951-d872f2087c98

BUG=http://code.google.com/p/chromium/issues/detail?id=172102


Review URL: https://chromiumcodereview.appspot.com/12036096

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182202 0039d316-1c4b-4281-b951-d872f2087c98

Make sure on_asan_mac_host() always returns 1 on non-Darwin systems.

BUG=170629, 174873
TBR=thakis
Review URL: https://codereview.chromium.org/12256005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182201 0039d316-1c4b-4281-b951-d872f2087c98