- 05 Aug, 2020 40 commits
-
-
sczs authored
This new commands shows a Snackbar by creating the MDCSnackBarCommand in the Coordinator, thus saving the caller to import Material components. Bug: 1085419 Change-Id: Iee3d6c93f40b50558503d997d13c540d9e84c86d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333069 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#795003}
-
Terrence Reilly authored
`ImageDecoder::StartWithOptionsImpl`, binds to the image decode success and error callback with `BindOnce`. This means that the `ClipboardImageDataDecoder` methods `OnImageDecoded` and `OnImageFailed` will also only by called once, and so the `ClipboardExtensionHelper` can therefore store the callbacks as `OnceCallback`s. All other changes are purely mechanical. For example, the method `CountryComboboxModel::SetCountries` accepts a `RepeatingCallback`. Previously the callback passed in `GenerateCountryList` was implicitly converted to a `RepeatingCallback` from a `Callback`. This makes it explicit. Bug: 1007786 Change-Id: I5b09978da57ea1df2ff1e672a5db735ab677e965 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321541Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Terrence Reilly <treilly@google.com> Cr-Commit-Position: refs/heads/master@{#795002}
-
Alex Rudenko authored
This CL address a TODO and adds a basic test to cover the logic changed. Change-Id: I14a23de8860c2379e88eb5d2e442197f2443e978 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339074Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#795001}
-
Aya ElAttar authored
Disabled the following tests because they are failing on Mac-10.10, Mac-10.11, Mac-10.12: 1. GetImageBufferColorSpace_BT2020_PQ 2. DISABLED_GetImageBufferColorSpace_BT2020_HLG TBR: dalecurtis@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1113153 Change-Id: I9e2c19ed2ef7bae4fea9406d1922a46fbe673bf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339454Reviewed-by:
Aya Elsayed <ayaelattar@chromium.org> Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Cr-Commit-Position: refs/heads/master@{#795000}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f68444a445f7..9a43f48ed4cd 2020-08-05 lalitm@google.com Merge "tp: bump tp and traceconv versions" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I3b527eddb638f89643071d83888bc775c16a126e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339195Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#794999}
-
Eric Seckler authored
Adds functions that facilitate setting the CPU affinity of a given thread or process to all little cores on the system. We intend to use this API to run a power experiment. Bug: 1111789 Change-Id: I6c3d32c2338e9f00464e8b6a8c96af93658a3ae2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335176 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#794998}
-
Xi Han authored
The ContentChangedListener::onAddFinished is not guaranteed to come before the onOverviewShownAtLaunch(). To fix it, we cache the event of onOverviewShownAtLaunch() if the feed content is still loading. The UMA will be recorded when onAddFinished() is called if it is missed on startup. Bug: 1107000 Change-Id: I23336149addb7ee4ee986083ce09212e982b1d6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316667 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#794997}
-
Wolfgang Beyer authored
We want to show information about browser windows opened via 'window.open()' in DevTools. One such piece of information is whether the opened browser windows have access to the opener's DOM via 'window.opener'. Links using 'rel=noopener' or creating a new browsing context group via Cross-Origin Opener Policy prevents this direct DOM access. 'canAccessOpener' returns whether calling 'window.opener' in the opened window returns a non-null value. This is information we want to surface in the DevTools Application panel's frame tree. Bug: chromium:1107766 Change-Id: Ife869e248b2932cd4fdfb4090da093cddf3bca34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309698Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Wolfgang Beyer <wolfi@chromium.org> Cr-Commit-Position: refs/heads/master@{#794996}
-
Carlos Caballero authored
This will make sure that the state is in sync before the page enters the back-forward cache and that we do not loose state if the page is later evicted. Moreover it prevents us from sending those updates while the page is in the back-forward cache (which depending on policy might trigger a renderer kill) Bug: 1111720 Change-Id: Ied898eb4b15fd18b7c3ad98955e5bbe5b148056e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332595Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#794995}
-
Vladimir Levin authored
This patch ensures that we don't propagate the dirty bits that happen within a locked subtree past the locked boundary. This ensures that we don't repaint content only because a locked-subtree element has changed (since such repaints will not change the painted output). Note that in non-CompositeAfterPaint path, the graphics layer hierarchy navigation still would happen. This patch only prevents paint layer dirty bit propagation. I think this is sufficient since it is an improvement for a lot of cases, and with CompositeAfterPaint, this will become an improvement for all cases. R=pdr@chromium.org, chrishtr@chromium.org Fixed: 1107413 Change-Id: Ic9e999a8377f9d57fbde7fffbc9096eada808b11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337415Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#794994}
-
Alex Turner authored
Bug: 1102934 Change-Id: I8386dcf1887311e763441113ccf361282f7ac386 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336299 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#794993}
-
sczs authored
Enables the InfobarUIReboot flag. Fixes some eg_tests so they work with the new UI. Makes some changes to credi_card and autofill tests since the credit card manager behaves differently when InfobarUIReboot is enabled. Bug=952345 Change-Id: I9cc8a4cb01d7139251b43348fe41037de00d9743 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096029 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#794992}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e794555edb6f..c5986015e174 2020-08-05 jacktfranklin@chromium.org Fix extra typedef braces for union types 2020-08-05 kimanh@chromium.org Update CDP If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1105765 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iccf0f3db59f2b4fec967af4fa57287061fd3f28e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2338917Reviewed-by:
-
Aya ElAttar authored
Changed downsample-quality.html test expectations because of Step "blink_web_tests" failing on builder "Linux Tests (dbg)(1)" TBR: junov@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1113127 Change-Id: I45d5547ec7800e51126ee73487952aedada10a00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336091Reviewed-by:
-
Guido Urdaneta authored
Use exact constraints and explicit values in order to reduce the probability of flakes. Bug: 1055012 Change-Id: I5b232694710c90682c9e143895af9979a400d858 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336076Reviewed-by:
Marina Ciocea <marinaciocea@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#794989}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: I0589d816fc051da790f2f8ad7daf8546b5a33b2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2338914Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#794988}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1596610622-a993b1ede4201f1709aeb65ee161df429dedf1b5.profdata to chrome-win32-master-1596617615-8a09722b4aec1f84e705885fa08b652aad83fd7b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I7277635d68e55bb26bcb3e3af8d065fea8323521 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2338916Reviewed-by:
-
Robbie Gibson authored
This avoids actually checking the clipboard contents until the user requests it, preventing the iOS 14 clipboard access notification from showing unnecessarily. We request the clipboard state when the corresponding view appears and whenever the clipboard changes again. This has the small issue that the edit menu may be incorrect if it is presented before the asynchronous call finishes, but my testing shows that the asnychronous call happens pretty quickly. Also, because the omnibox view controller is always a child view controller of the location bar view controller, the location bar view controller is in the responder chain, so it can handle the pasting from both classes. Bug: 1110848 Change-Id: I1b20f8099abc20408321c602976f9adb6434ba04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325733 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#794986}
-
Olesia Marukhno authored
Moved logic out of the OmniboxSuggestionButtonRowView to the button class. Button row class had some duplicated code to handle each button (creating focus ring, updating icon on theme change). It makes more sense to encapsulate logic related to button visual representation in the button class. Bug: 1104264 Change-Id: Ie55b9488a7300cfd36bb7a52ef89f8f659b01613 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2326170 Commit-Queue: Olesia Marukhno <olesiamarukhno@google.com> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#794985}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/23c5b63d1c68..f68444a445f7 2020-08-05 primiano@google.com Roll clang + fix warnings If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I40c1ebeb142173c63ff027e69e3226c1dc497c62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2338855Reviewed-by:
-
Reda Tawfik authored
This CL adds an entry point in keyboard accessory for "Filling Passwords From Any Origin" feature. 1) Add button title "Use other password" as a string resource. 2) Add new USE_OTHER_PASSWORD to AccessoryAction. 2) Push a new footer command to keyboard accessory sheet. Bug: 1104132 Change-Id: I2e4a867862a275dc2867c3b2bbd67e20b28d4d5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292516Reviewed-by:
Matthias Körber <koerber@google.com> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Reda Tawfik <redatawfik@noogler.google.com> Cr-Commit-Position: refs/heads/master@{#794983}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/171aaf4db08f..94fc43a9ebbf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC ayaelattar@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1033067 Tbr: ayaelattar@google.com Change-Id: Ie3e06b28d5734da3e1e031b0e8705214a57e3fea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2338814Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#794982}
-
Andreea Costinas authored
This CL replaces the call to |ShutDown| with |ShutDownProcess|. The D-Bus method ShutDownProcess allows, depending on the argument, to shut down the daemon or just one of the worker processes. Since System-proxy will have a worker which tunnels only ARC traffic, we need a shut down method that can kill the ARC worker when ARC is disabled by policy. Bug:1042639,1109144 TEST=unittests pass Change-Id: I73c5898095f5a6ee9d454c4a83b824667d2825d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317958 Commit-Queue: Andreea-Elena Costinas <acostinas@google.com> Reviewed-by:
Omar Morsi <omorsi@google.com> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#794981}
-
Viviane Yang authored
This CL implements BrowserContext::FirePushSubscriptionChangeEvent, which can be called in the future e.g. by PushMessagingServiceImpl, in case a permission is revoked, the Push Service is restarted or a subscription needs to get refreshed. A new feature features::kPushSubscriptionChangeEvent is added and checked to prevent firing a `pushsubscriptionchange` event by default or mistake. A SW event type is added to log the time for firing the event in UMA. Bug: 646721 Change-Id: Ibf55f15b4ec42131fdc92cdc0c78d3ff1eabb3b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332708 Commit-Queue: Viviane Yang <viviy@google.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#794980}
-
Mohamed Amir Yosef authored
This CL resets skip_zero_click in the account store before credentials are passed to the javascript API in CredentialManagementAPI Bug: 1093286 Change-Id: Ic62341369446c90b9f0986eb30cea3924bc28864 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307335 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#794979}
-
Viktor Semeniuk authored
Since Password Details uses not only TableViewTextEditCell ObjCCastStrict should be called every time. Bug: 1112354 Change-Id: I3afcf962842ab9db711f7c5bcb1b14ca00d3a795 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320172 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#794978}
-
Marc Treib authored
It was disabled for flakiness ~6 months ago; let's see if that is still accurate. (Likely it is, but at least the flakes don't repro locally.) Bug: 1043899 Change-Id: Iaad54efee9a2548cca72c33adb6c5160b8b2d19d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2338734 Commit-Queue: Victor Vianna <victorvianna@google.com> Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#794977}
-
Richard Knoll authored
This implements the share target selection on the DiscoveryPage. Replaces the manual dom-repeat template with an iron-list to get the default keyboard focus behavior. Screenshot: http://screenshot/BhrLp4uqdi1 Bug: 1103190 Change-Id: I74c8ca3fc90ab0d2ced77fa717356846e793eb12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336087Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#794976}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I9f20ba8ee35b04c441db3fe8ef239e9198c0a2c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2338854Reviewed-by:
-
Sami Kyostila authored
When the execution context is unpaused, schedule any pending idle callback timeout tasks as asynchronous tasks instead of running them directly. This is because it's not allowed to execute script directly from lifecycle callbacks. Bug: 1110503 Change-Id: I37dc6a6a41bf1f1bf7953073f7824222409cdffa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335446Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#794974}
-
Cherie Cheung authored
During the processing of ARCVM SharePath() request, it was retrieving the seneschal port via some Crostini functions. This was incorrect and would trigger a Crostini restart. This change will properly fix this by retrieving the correct seneschal port from ArcSessionManagerVmObserver. BUG=b:147618164 TEST=tast run <DUT> arc.Drivefs.vm Change-Id: I4f20ffb3101a17b51044e71c7d164bde78ec634d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320908 Commit-Queue: Cherie Cheung <cherieccy@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#794973}
-
arthursonzogni authored
This is a reland of 9c96261a The fix was this synchronization: ``` with request.server.stash.lock: ``` The server is doing a read and a write to a shared state. Those operations must not unterleave with other request handlers. Original change's description: > [COOP] Access reporting. Fix the python server. > > A python server is used has a communication channel in between documents > from different browsing context group and potentially cross-origin. > > There are two methods: > - one for writing a message. > - one for reading the message. > > I initially supposed we won't need to store more than one message in the > stash. It turns out there are tests doing two write in a row without any > read in the middle. It was throwing an exception when this > happened. > > This patch makes the server to maintain a queue of messages instead. It > doesn't throw errors anymore. > > Bug: chromium:1109194 > Change-Id: I25f8dc2c2a032781a4527a0994e94e46f85e12c9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317865 > Reviewed-by: Pâris Meuleman <pmeuleman@chromium.org> > Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#791901} Bug: chromium:1109194 Change-Id: I0abbbd9d0ec3b2d3c7c25b0a182c064523c18bd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2322886Reviewed-by:
Pâris Meuleman <pmeuleman@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#794972}
-
Sami Kyostila authored
The cricbuzz:2019 story is failing on all Android bots. NOTRY=true TBR=mythria@chromium.org Bug: 1112337 Change-Id: Iacee79aaf0bf1db62cc6b88d4bd1fac16cde0f4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339076Reviewed-by:
-
My Nguyen authored
We are working on improvements to autocorrect mechanism in ChromeOS. We need to get the information of the current position of autocorrect markers in blink. For future extensibility, add getting ime text spans at cursor position function, but only allows adding autocorrect marker for now to minimize IPC call. Design doc: http://go/cros-get-autocorrect-range Bug: 1109074 Change-Id: I6c99c15d271c558158f0adc66f35bd06e1a35aec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2326556Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#794970}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/25b0de6bd00f..38ddebf9a771 2020-08-05 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 92a71657fcba to 8bc27a1cfbc1 (3 revisions) 2020-08-05 timvp@google.com Roll chromium_revision fb6cbaf6..ed7912a2 (790363:794870) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: geofflang@google.com Change-Id: I87ed52cea1268c12802ae07839751e1e4db4effe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2338258Reviewed-by:
-
Mikel Astiz authored
Analogous to crrev.com/c/2332703 for iOS: the recently-introduced API in base/test/test_file_util.h allows temp dirs to be created without explicit lifetime control. Tests can assume the directory will be around during the execution of the test, and it will get automatically deleted afterwards. Bug: 546640 Change-Id: I9c8dc59b8ae3963f0be692bfe302cdc8d01d9a83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335194Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#794968}
-
Carlos Caballero authored
Bug: 1111720 Change-Id: I6325fbfef9bc9f18495dbd3c4842571e56a356a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332656 Commit-Queue: Carlos Caballero <carlscab@google.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/807ce12a0c4f..e794555edb6f 2020-08-05 leese@chromium.org Deduplicate source mapped breakpoint 2020-08-05 patrick.brosset@microsoft.com Grid: Don't assume grid lines are straight when drawing extension lines 2020-08-05 wolfi@chromium.org Style issue bar to mimic regular console message If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1068116,chromium:1096481,chromium:1105764,chromium:1112363 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I552bd39250f3109b7fd9c9ab3f739513bdb70240 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2338675Reviewed-by:
-
Thomas Tellier authored
This reverts commit 59d5a5a3. Reason for revert: Reland the CL by fixing the bug Original change's description: > Revert "Change hiding timer logic for password textfield on login/lock screen" > > This reverts commit 4af05312. > > Reason for revert: Breaking ash_unittests and browser_tests > on chrome os builders, see > https://bugs.chromium.org/p/chromium/issues/detail?id=1112924 > > Original change's description: > > Change hiding timer logic for password textfield on login/lock screen > > > > 5-second instead of 3-second timer for password/PIN going back to masked format. > > 5-second timer will reset upon character being entered to keep the password/PIN visible during revision. > > > > Bug: 1101326 > > Change-Id: I962139aef26bd9fb68e5110d5169d0f486a5bce4 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314176 > > Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org> > > Commit-Queue: Thomas Tellier <tellier@google.com> > > Cr-Commit-Position: refs/heads/master@{#794602} > > TBR=rsorokin@chromium.org,tellier@google.com > > Change-Id: I2cb94561e291ccadf623af2bd4529cd4c9bd23de > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1101326 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337388 > Reviewed-by: Rebekah Potter <rbpotter@chromium.org> > Commit-Queue: Rebekah Potter <rbpotter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#794721} TBR=rsorokin@chromium.org,rbpotter@chromium.org,tellier@google.com # Not skipping CQ checks because this is a reland. Bug: 1101326 Change-Id: Ib1aca0d5dfc9f8912b39c7d27de4053b80d0126e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337474Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Thomas Tellier <tellier@google.com> Commit-Queue: Thomas Tellier <tellier@google.com> Cr-Commit-Position: refs/heads/master@{#794965}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1596596349-2982a3aa1ac388b8b69893b6dd544749d7f1a2d0.profdata to chrome-win32-master-1596610622-a993b1ede4201f1709aeb65ee161df429dedf1b5.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I9a576532f0f6e05a6b5c2eb4161438d1aa7e9657 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2338594Reviewed-by:
-
