GitLab

Failure seen on the buildbots.  It would help to know why.

Review URL: http://codereview.chromium.org/3067013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54016 0039d316-1c4b-4281-b951-d872f2087c98

BUG=50107
TEST=none

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54015 0039d316-1c4b-4281-b951-d872f2087c98

This fixes an assertion failure when trying to use this class on the Mac due to SkBitmap destruction happening during process exit handling.

BUG=None
TEST=Custom startup page list should still show default favicons.

Review URL: http://codereview.chromium.org/3028030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54014 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jorlow
TEST=none
BUG=none


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54013 0039d316-1c4b-4281-b951-d872f2087c98

The python sync server does not support recursive deletion, as a result of which test cases that remove a directory of sync entries end up failing.

This checkin updates the sync server to support recursive deletion of sync entries and all their childen.

BUG=50306
TEST=sync_integration_tests

Review URL: http://codereview.chromium.org/3051019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54012 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/3050018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54011 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54010 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/2873061

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54009 0039d316-1c4b-4281-b951-d872f2087c98

Enhance plugin logging a bit. This adds logging in a few more places, especially for Windows. This also changes the log level to ERROR so that when you opt in to plugin logging, you don't also have to set the log level to be INFO and put up with a low of log spew.

TEST=none
BUG=none
Review URL: http://codereview.chromium.org/3013039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54008 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=compiles

Review URL: http://codereview.chromium.org/2908011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54007 0039d316-1c4b-4281-b951-d872f2087c98

http://src.chromium.org/viewvc/chrome?view=rev&revision=53913 accidentally landed a cleaned up version of the change reviewed in http://codereview.chromium.org/2847080/show

This change introduces a style nit fix, but is also so that someone can review the ExpectCanceledFetcher (which replaces and simplifies TimedMockFetcher) in google_authenticator_unittest.cc

BUG=None
TEST=unit tests

Review URL: http://codereview.chromium.org/3077006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54006 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=you can still drag the chrome window by the titlebar, and when you double click it maximizes (this did not change; it was true before this patch as well)

Review URL: http://codereview.chromium.org/3061023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54005 0039d316-1c4b-4281-b951-d872f2087c98

BUG=http://crbug.com/50081
TEST=as in bug

Review URL: http://codereview.chromium.org/2868076

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54004 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=TopSitesTest

Review URL: http://codereview.chromium.org/2832091

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54003 0039d316-1c4b-4281-b951-d872f2087c98

- Add "Add" button. Doesn't work.
- Add "Remove" button. Does work.
- Update the view when the model changes.

(Still only works for the images content type.)

BUG=48862
TEST=manual; unit tests

Review URL: http://codereview.chromium.org/3068005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54002 0039d316-1c4b-4281-b951-d872f2087c98

The code that rendered this line was doing weird things (adding/removing kClientEdgeThickness from the edges?!) so I removed this and used toolbar_bounds.right() instead of toolbar_bounds.width() which is correct given that toolbar_bounds.x() > 0.

I also got rid of the use of MirroredLeftPointForRect since the flipped version of a horizontal line is... the same horizontal line.

I have also updated the glass frame not to subtract a pixel from the right edge which looks glitchy as well.

http://crbug.com/48134
TEST=see bug

Review URL: http://codereview.chromium.org/3056022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53998 0039d316-1c4b-4281-b951-d872f2087c98

BUG=49571
TEST=Covered by unit_tests.

Review URL: http://codereview.chromium.org/3072005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53997 0039d316-1c4b-4281-b951-d872f2087c98

In renderer_webkit_client_impl, several impl classes got moved to the
implementation file.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3032027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53996 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jorlow
TEST=none
BUG=none


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53995 0039d316-1c4b-4281-b951-d872f2087c98

1. Fix EntryKernel leak if sync database load fails.
2. DirectoryBackingStore: always close the load handle.
3. DirectoryBackingStore unittests: free when .clear()ing test index
4. Fix real bad leak in Directory::PurgeEntriesWithTypeIn.

BUG=50334,50335,50336,50347,50348,50349
TEST=sync_unit_tests

Review URL: http://codereview.chromium.org/3026029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53994 0039d316-1c4b-4281-b951-d872f2087c98

Modified resources for M6 theme.  This doesn't actually modify layout yet, just images and identifier names.

BUG=50107
TEST=none
Review URL: http://codereview.chromium.org/3035034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53993 0039d316-1c4b-4281-b951-d872f2087c98

An earlier check-in (r51786, Issue 2769008) caused a memory leak on the build bots when PulseAudio was initialized on a separate worker thread.  This change calls PulseAudioMixer::InitSync() so the init happens on the calling thread.  For some reason, the init finishes cleanly on one thread, but not the other.

BUG=48553 (and http://code.google.com/p/chromium-os/issues/detail?id=5141)
TEST=Valgrind should not have PulseAudio related memory leaks, suppression 48553, or assertion failures.

Review URL: http://codereview.chromium.org/3026028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53992 0039d316-1c4b-4281-b951-d872f2087c98

The try servers seem to not support testing these types of resource/image additions, hence all builds fail in try. However I have verified that this builds fine on my windows,mac and linux machines.

Please advise if any of the changes in the GRD or webkitclient_impl.cc
need to be inside #if ENABLE_INPUT_SPEECH. I did not add the ifdef since
I didn't see any for other such features in both these files.

BUG=none
TEST=none yet as the feature is still being implemented and not enabled

Review URL: http://codereview.chromium.org/3058019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53991 0039d316-1c4b-4281-b951-d872f2087c98

- Omit Network and SSL sections for ChromeOS.

BUG=49038
TEST=Exercise proxy settings dialog in dom-ui options window (--enable-tabbed-options).
Review URL: http://codereview.chromium.org/2847061

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53990 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:5028
TEST=Verify the user options page matches mock per chromium-os:5028. Note the underlying libcros is still missing and UI shows up mock data only.

Review URL: http://codereview.chromium.org/2868067

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53989 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53988 0039d316-1c4b-4281-b951-d872f2087c98

BUG=46662
TBR=apatrick@chromium.org
Review URL: http://codereview.chromium.org/3072006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53986 0039d316-1c4b-4281-b951-d872f2087c98

Use setUpO3DParam_ instead of createParam so that the "o3d." names can be used by serialization.js;
simpleviewer calls Pack.destroy which can fail.
Implement o3d.Matrix4Composition.
Typos in curve loading.
Review URL: http://codereview.chromium.org/3020030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53985 0039d316-1c4b-4281-b951-d872f2087c98

Moving DataSource destruction to the UI thread appears to just leak
memory at shutdown. Finding another way...

BUG=34115
TEST=none

Review URL: http://codereview.chromium.org/3060024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53979 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53978 0039d316-1c4b-4281-b951-d872f2087c98

BUG=49702
TEST=Integrated PDF plugin should work on Linux Chrome, and --register-pepper-plugins works on Linux even with sandbox enabled.

Review URL: http://codereview.chromium.org/3031011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53977 0039d316-1c4b-4281-b951-d872f2087c98

BUG=46662
TEST=Manually test ui_tests.PepperTester.Pepper3D and npapi_pepper_test_plugin.
Review URL: http://codereview.chromium.org/3067007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53976 0039d316-1c4b-4281-b951-d872f2087c98

Fixing execute permissions issue.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53975 0039d316-1c4b-4281-b951-d872f2087c98

BUG=50266
TEST=None

Review URL: http://codereview.chromium.org/3017036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53974 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/3052019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53972 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3068004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53969 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

http://codereview.chromium.org/3053017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53967 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53965 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/3030022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53963 0039d316-1c4b-4281-b951-d872f2087c98

1) Make it actually work again.
2) Change the model so that it doesn't get into an infinite recursion cycle
   trying to update the model, notify observers, and then re-update.

BUG=49320
TEST=Chromium-->Preferences. Add custom home pages. Close Preferences and reopen. They are still there.
TEST=Open 3 web pages in tabs. Chromium-->Preferences. Use Current homepages. Close Preferences and reopen. They are still there.
TEST=With custom homepages set, go to Chromium-->Preferences-->UtH-->Reset to Defaults. Go back to Basics. No more custom homepages.

Review URL: http://codereview.chromium.org/3023023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53961 0039d316-1c4b-4281-b951-d872f2087c98