GitLab

Check if the connected socket id already exists for P2PSocketDispatcherHost::OnAcceptIncomingTcpConnection

BUG=469152

Review URL: https://codereview.chromium.org/1020293002

Cr-Commit-Position: refs/heads/master@{#321609}

Removed access to the native XHR object used by the API.

This is a larger change than one might expect for two reasons: First,
because the native XHR object only allows the response content to be
retrieved while the onreadystatechange handler is executing, and
second, because the unit test for dns_blackhole_checker.js relied on
synchronous semantics which cannot be duplicated with promises because
when a promise is resolved, its "then" handlers are not called until
the next event cycle.

Review URL: https://codereview.chromium.org/1003433002

Cr-Commit-Position: refs/heads/master@{#321608}

Making toolkit-views available for non-browser UI means that this guard
in print_preview.js needs updating to ensure ESC still closes the dialog
on Mac. The webui container is still Cocoa.

Everything is toolkit-views now (except mobile/cast), so just check for
mac.

BUG=469045

Review URL: https://codereview.chromium.org/1025613002

Cr-Commit-Position: refs/heads/master@{#321607}

In preparation of componentization of FaviconTabHelper, introduce a
new target //components/favicon/content (as favicon is a layered
component) and move the function to convert from content::FaviconURL
to favicon::FaviconURL there.

BUG=374281

Review URL: https://codereview.chromium.org/1020213002

Cr-Commit-Position: refs/heads/master@{#321606}

Compiler tool definitions use {{source}} and {{output}} to specify the
source and output files, not $in and $out.

Also fix some typos and spurious commas.

Review URL: https://codereview.chromium.org/1020073002

Cr-Commit-Position: refs/heads/master@{#321605}

R=byungchul@chromium.org,lcwu@chromium.org
BUG=internal b/19854960

Review URL: https://codereview.chromium.org/1028723002

Cr-Commit-Position: refs/heads/master@{#321604}

Since |SSLErrorHandler| was a |WebContentsUserData| tied to the lifetime of a
|WebContents|, it wasn't properly deleted when the |WebContents| was reloaded
or navigated to another page. This CL removes the error handler explicitly and
adds browser tests to assert reload/navigate behavior.

BUG=453875

Review URL: https://codereview.chromium.org/1004283004

Cr-Commit-Position: refs/heads/master@{#321603}

The MacViews browser were missing infobar and background tab assets.
mac_views_browser grit define is added so that we can include infobar assets.
Don't remap theme image ids so that Mac's background tab assets can be
found.
Map IDR_THEME_TAB_BACKGROUND_INCOGNITO to the same asset as
IDR_THEME_TAB_BACKGROUND.

BUG=425229

Review URL: https://codereview.chromium.org/983823004

Cr-Commit-Position: refs/heads/master@{#321602}

TBR=yurys,smckay,gunsch
NOTRY=true

Review URL: https://codereview.chromium.org/1025753003

Cr-Commit-Position: refs/heads/master@{#321601}

Currently ToWebURLResponse() is not setting the expected content length. The
default value from Blink is 0. In Chromium, -1 means "Not available". This CL
sets this value to -1 to be consistent with the Chromium net/ code. See
content/public/common/resource_response_info.h.

BUG=468489
TEST=html_viewer works with streaming servers.

Review URL: https://codereview.chromium.org/1013413003

Cr-Commit-Position: refs/heads/master@{#321600}

Review URL: https://codereview.chromium.org/1027853002

Cr-Commit-Position: refs/heads/master@{#321599}

Many different places in the Chrome codebase handle unexpected IPC data
by killing the renderer. This can result in hard-to-debug sad tab pages.
Some, but not all, of these locations log an error; others record UMA
user actions. This CL fixes most sites to both log and record metrics.
It also switches the metrics to be histograms instead of user actions
because we don't need the extra timestamp data from user actions and
most of these sorts of metrics live in histograms.

BUG=462687
TEST=unit_tests

Review URL: https://codereview.chromium.org/1009583004

Cr-Commit-Position: refs/heads/master@{#321598}

BUG=379378

Review URL: https://codereview.chromium.org/1023063005

Cr-Commit-Position: refs/heads/master@{#321597}

Revert of Suppress MSI/MSM validation when building remoting MSI. (patchset #1 id:1 of https://codereview.chromium.org/1020823003/)

Reason for revert:
This did the trick. Reverting this change and putting something durable in the signing infrastructure. Thanks.

Original issue's description:
> Suppress MSI/MSM validation when building remoting MSI.
>
> I believe this will unblock a required migration in our signing
> infrastructure.
>
> BUG=none
> R=garykac@chromium.org
>
> Committed: https://crrev.com/819da16a0d1246383bb8fe3c483fe7ace98a60b7
> Cr-Commit-Position: refs/heads/master@{#321438}

TBR=garykac@chromium.org,jamiewalch@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=none

Review URL: https://codereview.chromium.org/1028733002

Cr-Commit-Position: refs/heads/master@{#321596}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/adf9990..b502ee3

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=egdaniel@google.com

Review URL: https://codereview.chromium.org/1027803002

Cr-Commit-Position: refs/heads/master@{#321595}

BUG=466136

Review URL: https://codereview.chromium.org/1028503003

Cr-Commit-Position: refs/heads/master@{#321594}

BUG=452215, 403800

Review URL: https://codereview.chromium.org/879403002

Cr-Commit-Position: refs/heads/master@{#321593}

This roll picks changes which fixes the frameviewer mode breakage
caused by CL https://crrev.com/1007113002. Also fixes an importer
error due to a spelling mistake in the newly added audit calls.

BUG=None
R=nduca, dsinclair

Review URL: https://codereview.chromium.org/1021153002

Cr-Commit-Position: refs/heads/master@{#321592}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/166e7b4..0be08ff

TBR=dglazkov@chromium.org,mnissler@chromium.org

Review URL: https://codereview.chromium.org/1027573003

Cr-Commit-Position: refs/heads/master@{#321591}

The GetStringSize has had some unfound errors that are now being found by an improvement to the unit test.  There is another bug (465583) that is intended to look into these standing issues.  For the short term, this CL will remove Chrome OS from the failing unit test (which is no worst than the situation prior to the unit test being improved).

BUG=468903

Review URL: https://codereview.chromium.org/1003273004

Cr-Commit-Position: refs/heads/master@{#321590}

Change interface of GetForProfile() to return an history::HistoryClient*
instead of a ChromeHistoryClient* since no-one depends on the more typed
return value.

Remove unused GetForProfileWithoutCreating() method which is no longer
used (and the corresponding comment).

BUG=None

Review URL: https://codereview.chromium.org/1020913002

Cr-Commit-Position: refs/heads/master@{#321589}

Adds a missing EndArray() to the TaskQueue::AsValueInto introduced in r321183

Review URL: https://codereview.chromium.org/1027843002

Cr-Commit-Position: refs/heads/master@{#321588}

Arraysize was being used for destination array sizes in memcpy and
memcmp, which returns the number of elements rather than the number of
bytes, as these functions expect. The result is that the entire arrays
were not getting copied.

BUG=469151

Review URL: https://codereview.chromium.org/1028673002

Cr-Commit-Position: refs/heads/master@{#321587}

This is a step toward having color text for things like an increase in stock price (positive) and a decrease in stock value (negative).  An example would be the text shown in Answers in Suggest.

This CL is groundwork for (and separated out from) CL 795933009.

BUG=455418

Review URL: https://codereview.chromium.org/1020623002

Cr-Commit-Position: refs/heads/master@{#321586}

Makes chrome.dll on Windows not use incremental linking since the ilk files get too large.

This refactors the incremental linking configuration to make it easier to change the default.

BUG=

Review URL: https://codereview.chromium.org/1019353004

Cr-Commit-Position: refs/heads/master@{#321585}

TBR=yurys,smckay
NOTRY=true

Review URL: https://codereview.chromium.org/1022153002

Cr-Commit-Position: refs/heads/master@{#321584}

Upstreams the ios/testing directory, which contains a helper utility
for validating non-ObjC parameters in tests using OCMock.

BUG=None

Review URL: https://codereview.chromium.org/1024443002

Cr-Commit-Position: refs/heads/master@{#321583}

There is no reason to differentiate between sync/async
case. Additionally we may get rid of loading entirely, in which case
the async case would have to change.

TEST=covered by tests
BUG=468458

Review URL: https://codereview.chromium.org/1022583003

Cr-Commit-Position: refs/heads/master@{#321582}

BUG=467796

Review URL: https://codereview.chromium.org/1027463003

Cr-Commit-Position: refs/heads/master@{#321581}

BUG=469160,469166

Review URL: https://codereview.chromium.org/1024753004

Cr-Commit-Position: refs/heads/master@{#321580}

Addresses minor comments from upstreaming ios/web utility code in
a previous CL (<https://codereview.chromium.org/988383002/>)

BUG=None

Review URL: https://codereview.chromium.org/1023013002

Cr-Commit-Position: refs/heads/master@{#321579}

Review URL: https://codereview.chromium.org/1022813002

Cr-Commit-Position: refs/heads/master@{#321578}

BUG=469146

Review URL: https://codereview.chromium.org/1024913002

Cr-Commit-Position: refs/heads/master@{#321577}

Update roll-script to DEPS in the package instead of checking it
in. The new package folder lives at a new place to ensure there
are no issues when rolling back or forward from this CL. The new
location is:
//third_party/dom_distiller_js/dist.

After running `ant package`, the roll-script now takes the content
from out/package and pushes it to an external repository on
GitHub (chromium/dom-distiller-dist) and updates DEPS for
that repo to refer to the newly pushed version.

BUG=467787

Review URL: https://codereview.chromium.org/987793002

Cr-Commit-Position: refs/heads/master@{#321576}

This CL is part of new UMA upload logic. The change is for getting more usage data for Chrome users who exclusively use wireless networks. For that, a new binary on/off-switch is added instead of previous three-option model. However, the upload logic is changed on Android to reduce the data usage.

The new binary switch is also connected to a different pref then previous switch. For the beginning the new settings UI would be enabled for users assigned to experimental group.

BUG=455847

Review URL: https://codereview.chromium.org/978623002

Cr-Commit-Position: refs/heads/master@{#321575}

R=rdsmith
BUG=none

Review URL: https://codereview.chromium.org/1017743002

Cr-Commit-Position: refs/heads/master@{#321574}

This color changed recently for the toolkit-views app list, but the
Cocoa app list isn't ready for it yet.

The Cocoa-specific kHighlightedColor was only used in
apps_search_results_controller.mm, so move it there. kSelectedColor is
used there but also in apps_grid_view_item.mm. However, the latter users
a composited draw, so it's fine with the transparent background views
uses.

BUG=469051

Review URL: https://codereview.chromium.org/1023983002

Cr-Commit-Position: refs/heads/master@{#321573}

It's flaky on Win, Mac, Linux.

BUG=chromium:468660
TBR=lazyboy@chromium.org

Review URL: https://codereview.chromium.org/1025653003

Cr-Commit-Position: refs/heads/master@{#321572}

BUG=468723
R=torne@chromium.org

Review URL: https://codereview.chromium.org/1026803002

Cr-Commit-Position: refs/heads/master@{#321571}

This CL reworks the trace generation format for the memory maps
dumper according to latest discussion in the design doc
"Memory Dumping: Mmap and Smap data dumping details"
(http://goo.gl/e6WRnQ).
Furthermore this CL changes the output format of the total dumper to
dump a hex string rather than a float, in order to be consistent with
the mmaps dumper.

See http://pastebin.com/EHdNDMXN for an example of the generated JSON.

BUG=460884

Review URL: https://codereview.chromium.org/947103003

Cr-Commit-Position: refs/heads/master@{#321570}