- 21 Oct, 2020 36 commits
-
-
Koji Ishii authored
|ShapingLineBreaker::Hyphenate| should look for hyphenation points at the line edge or after, but it did not include the character at the line edge. This patch fixes this. This occurs often when `fit-content` inline size is used. Also changes the test to use Ahem because Win uses U+2010 HYPHEN instead of U+002D HYPHEN-MINUS, but other platforms use U+002D. Bug: 1140738 Change-Id: I5e1157de07b58edddb92c6c80ff8df460fc064b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485352Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#819201}
-
Clark DuVall authored
All known issues have been fixed so enabling this in canary to see if there are any major problems. Bug: 1126301 Change-Id: I0c3bc7443fcca8b81f7c2652d90b982872f7ea08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478144 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#819200}
-
Yi Zhang authored
//chrome/browser/devtools/ This CL is the 1st part of converting base::Bind to Once/Repeating in //chrome/browser/devtools/ Bug: 1007635 Change-Id: I8a58f155c3ae402f860492af77df21c133c5f453 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486573Reviewed-by:
Leon Han <leon.han@intel.com> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Leon Han <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#819199}
-
Thomas Lukaszewicz authored
This CL updates the read later bubble to use the WebBubbleDialogView. This change results in the bubble Widget being shown async. A follow up is required to ensure the Read Later button handles the async interaction correctly. Bug: 1099917 Change-Id: I61ca01d8774f8eacaaad360ab0e653f39c0d5cf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462250 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Caroline Rising <corising@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#819198}
-
David Bienvenu authored
Also some lint fixes, and c++ modernization; no functional changes. Bug: 1010217 AX-Relnotes: n/a. Change-Id: I3347ea195ecf3707727730e8f1ee9e9b0de2abff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476724 Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#819197}
-
Eliot Courtney authored
This also fixes a bug where sometimes fds are not received and lacros can't start. Bug: 1139796 Test: Can run lacros on chromeos via this script Change-Id: I33f5fae07b377fb7848dc444be7fcb4f8d4a3f46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483749Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Cr-Commit-Position: refs/heads/master@{#819196}
-
Charles Zhao authored
Currently CreateBrowserWithTestWindowForParams takes a pointer as input, changes its value, and then use the value to CreateBrowser, and both the CreateBrowserWithTestWindowForParams and the caller do not need the pointer any more. It makes more sense to let CreateBrowserWithTestWindowForParams take a value as input. Bug: 1139754 Change-Id: I229a198e7f998cacd80ea8e092c94ad7a56d19d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484028Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Charles . <charleszhao@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Charles . <charleszhao@chromium.org> Cr-Commit-Position: refs/heads/master@{#819195}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/ee18f390eead..85d9d5d4bbc6 2020-10-20 amaiorano@google.com Subzero: workaround bad codegen for Windows x86 at Om1 optimization level If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Iad880e3af0d472db8bccf29aa1c54deb77446f57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487918Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819194}
-
Rakesh Soma authored
if individual resolution url parsing fails. Bug: 1140575 Change-Id: Iebe612418486a2650632f0861c2622a426b65e9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487825 Commit-Queue: Rakesh Soma <rakeshsoma@google.com> Reviewed-by:
Yusuf Sengul <yusufsn@google.com> Cr-Commit-Position: refs/heads/master@{#819193}
-
Gavin Williams authored
Have ChromeVox refer to the right-arrow icons as "Subpage button" to clarify the button's action to the user. Bug: 1012105 Change-Id: Ia1159047aabf6e55bf2d5b989ab4ff40f919a684 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481683Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#819192}
-
Dave Tapuska authored
I suspect something odd is going on with RenderDocument not marking the Frame as detached. Marking the frame as detached Closes the WebFrameWidgetBase via RenderWidget::CloseForFrame. Turn this into a strong assert (there already is a DCHECK in RenderWidget) that asserts the same thing. BUG=1139104 Change-Id: If164f299a2fa9964747556dee38216f7ff78a799 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487705 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#819191}
-
Yury Khmel authored
This enables ARC power control in Chrome with tracing support. Changing ARC power modes is available in developer mode only. DD: go/arc_power_control BUG=b:170982650 TEST=Locally Change-Id: I9be38e04417075578f4bd01c9952a68de4841653 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481906 Commit-Queue: Yury Khmel <khmel@google.com> Auto-Submit: Yury Khmel <khmel@google.com> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#819190}
-
chromium-autoroll authored
https://dawn.googlesource.com/tint.git/+log/7156d3e3140b..4f79c8405028 2020-10-20 dsinclair@chromium.org [spirv-writer] Deduplicate sampler and comparision_sampler. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/tint-chromium-autoroll Please CC dsinclair@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: dsinclair@google.com Change-Id: I0c34a524b9a2fc20525a051d174f3fa39ed47016 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488587Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/1227ffd79585..bd66f2d95186 2020-10-20 jalyn@microsoft.com Shortcut editor: Centralize button creation If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:174309 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia17127f3ed024d31bb083977355506eb67783633 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487919Reviewed-by:
-
Daniel Rubery authored
This feature collects certain features of the current navigation and includes it in CSD pings. But the data is not being used for training or protection, so remove it. Bug: 1138986 Change-Id: Id77a757569ee0bab40235ec2eb4145e75bb672c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487699 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#819187}
-
Renjie Tang authored
Bug: b/171063562 Change-Id: Ib17016732a59cb434855af3098288ec4147fb939 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488700 Commit-Queue: Renjie Tang <renjietang@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#819186}
-
Tarun Bansal authored
Change-Id: I9e7db8e9775b9e6cd0813ffeaad68405bcc96607 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487946Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#819185}
-
Moe Ahmadi authored
"chrome-ntp" will be used for Google Suggest requests from non-searchbox (neither realbox nor omnibox) NTP surfaces including Repeatable Queries in the Most Visited tiles. Bug: 1110082 Change-Id: I64fd89fb1c624e1b7be77db04153cc255834a4b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473443 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Mike Pinkerton <pinkerton@chromium.org> Cr-Commit-Position: refs/heads/master@{#819184}
-
Dave Tapuska authored
Since we no longer create a fullscreen widget we can remove its knowledge from WebContents and its delegate. BUG=1134674 Change-Id: Id12cf67c5ec76dcaddb564301bf032eac4b3370d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487148Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
-
Yuki Shiino authored
In order to support IDL namespaces, refactors WrapperTypeInfo and related code. - WrapperTypeInfo::GetV8ClassTemplate replaces old DomTemplate member function. - WrapperTypeInfo::idl_definition_kind distinguishes IDL interface from IDL namespace. - Installer functions take v8::Template and v8::Object because an IDL namespace is not a JS function. - bindings::SetupIDLInterfaceTemplate in generated_code_helper.h replaces old V8DOMConfiguration::InitializeDOMInterfaceTemplate. (V8DOMConfiguration is no longer used in the code base.) Since we no longer use adapter functions for WTI::DomTemplate, the APK size will be reduced by 10 KB. Bug: 839389 Change-Id: I0adb59372adbfa6f4611009324b399c5249ba249 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464515 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#819182}
-
Nidhi Jaju authored
According to https://github.com/whatwg/streams/pull/1035, all methods and accessors are now enumerable, per Web IDL defaults, instead of non-enumerable, per ECMAScript defaults. Hence, 'NotEnumerable' can be removed from the Streams WebIDL files. This CL specifically removes them from writable streams. Bug: 1093862 Change-Id: I935a9f8726b3cb1dc4efb5b4d6db71384c8efe37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485664Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Nidhi Jaju <nidhijaju@google.com> Cr-Commit-Position: refs/heads/master@{#819181}
-
Nidhi Jaju authored
According to https://github.com/whatwg/streams/pull/1035, all methods and accessors are now enumerable, per Web IDL defaults, instead of non-enumerable, per ECMAScript defaults. Hence, 'NotEnumerable' can be removed from the Streams WebIDL files. This CL specifically removes them from readable streams. Bug: 1093862 Change-Id: I2cab1814a7d34beeca16b15fd6c64339d296952f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485986Reviewed-by:
-
Kevin Marshall authored
Defines a Fuchsia package, "web_engine_with_webui", which is a variation on the WebEngine package with WebUI static resources included. Adds web_engine_with_webui to CIPD recipe. Modifies web_engine_shell to support running packages other than "web_engine", so that "web_engine_with_webui" can be used. Prepares GPU integration test runner to use "web_engine_with_webui" (pending integration with Catapult). "web_engine" will have its resources removed in a followup CL. Bug: 1092729 Change-Id: I321c95b8f41902180e9edbe5e7404438956e1e91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424514 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Auto-Submit: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#819179}
-
Benjamin Beaudry authored
It looks like the bug behind the disabled unit test NGOutOfFlowLayoutPartTest.PositionedFragmentationWithBottomProperty got fixed without us noticing it. Probably got fixed in CL:2422705. Re-enabling the unit test. Bug: 1115584 Change-Id: I55dcb0f08dce33a50f262b5ae74ade9da28e8359 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487914Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Alison Maher <almaher@microsoft.com> Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com> Cr-Commit-Position: refs/heads/master@{#819178}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0ce89c83f8ea..fbc6250f7a85 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC reillyg@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1117577,chromium:1139953 Tbr: reillyg@google.com Change-Id: I59583bfcfe08678ba1ef5a4abf657c6436da7d18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488589Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819177}
-
Dominic Farolino authored
This CL removes the content.mojom.RouteProvider and blink.mojom.AssociatedInterfaceProvider implementations from RenderThreadImpl and RenderProcessHostImpl. As a result, we make AgentSchedulingGroup and AgentSchedulingGroupHost fully-fledged RouteProviders and AssociatedInterfaceProviders. Consequently, we: (1) Remove the RenderThread public API addition done in crrev.com/c/2433793, since AgentSchedulingGroup is now wholly responsible for providing a remote mojom::RouteProvider*, and no longer delegates to RenderThreadImpl. (2) Introduce MockAgentSchedulingGroup alongside AgentSchedulingGroupHost to be used in unit tests. This provides a mock for GetRemoteRouteProvider() so we don't have to have a test-only path when RenderThreadImpl::current() == false alongside production code (3) Introduce temporary {RenderProcessHostImpl,ChildThreadimpl}::GetListener() methods for AgentSchedulingGroup and its host to use, to get IPC::Listeners from the routing ID map. This is important for the implementation of AssociatedInterfaceProvider, however it is temporary, and these methods will be removed when the legacy IPC functionality is fully transferred to ASG(H), and these objects have their own IPC::Listener* map. One subtle change that this CL makes is the way that the RouteProvider interface is bound between the RenderProcessHostImpl: Before this CL, the Renderer => Browser RouteProvider was bound lazily, whenever RenderThreadImpl::GetRemoteRouteProvider() was called for the first time. After this CL, the Renderer => Browser RouteProvider is bound at the exact same time as the Renderer => Browser interface. This is done in AgentSchedulingGroupHost::SetUpMojoIfNeeded(), where we call mojom::AgentSchedulingGroup::BindAssociatedRouteProvider(). We pass both a remote pointing to AgentSchedulingGroupHost, and a receiver that AgentSchedulingGroup will bind. Once bound, bi-directional communication is immediately available. One upside to this is that the bind lifetimes of the browser-side remote and receiver pair are 100% consistent. ---- This change is fully described in: https://docs.google.com/document/d/12jyv-8aBwMlSS_Y5roEl_ykZT0_eQszGiiNs7Hxktmk/edit#heading=h.3dn0j414iw3j R=haraken@chromium.org, kinuko@chromium.org, kouhei@chromium.org, talp@chromium.org Bug: 1132901 Change-Id: I819289c4d8d254229d5ad639ec8eb5fbe96d7381 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438232 Commit-Queue: Dominic Farolino <dom@chromium.org> Reviewed-by:Alexander Timin <altimin@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Tal Pressman <talp@chromium.org> Cr-Commit-Position: refs/heads/master@{#819176}
-
Joel Hockey authored
We currently use the suffix for filesapp open-with, but we also want to have it for the app name displayed in the external protocol dialog, and in any other place where the app name is displayed. Bug: 1140284 Change-Id: Id2df3924c2e7cb7c870e42ec7e4c3ee3892e64cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486521 Commit-Queue: Timothy Loh <timloh@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#819175}
-
Nate Chapin authored
Change-Id: I212fd68b99ac07343dafc2ae65ca2a6e24b6ccac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487697 Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
-
Melissa Zhang authored
Bug: 1136338 Change-Id: I08eba6ee8137088f9a06f02f95ead0c28ce82314 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485372Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Melissa Zhang <melzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#819173}
-
Darren Shen authored
Add Mojo and protobuf messages for Chrome to send key events to the IME service. Key event handling is a bit special because it requires a callback (whether the key event was consumed by the IME or not). Before, messages were sent from DecoderEngine and received in ClientDelegate, so sending & receiving were independent of each other. However, for key events, we need to track key events and their callbacks, so sending & receiving must go through the same code at some point. Therefore, make ClientDelegate forward messages to DecoderEngine so that DecoderEngine can track pending key events and call the right callback when needed. Change-Id: Ia3a2d976cc79f24a96d6ec390732dc64833afaff Bug: b/161490915 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422925 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Auto-Submit: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#819172}
-
Peter Kasting authored
This ends up fixing classes in chromeos/ui/frame/caption_buttons/ as a necessary piece of this work. Bug: 772945 Change-Id: Ifaea958076c28ec956edd207160242cf5e49cdc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488766Reviewed-by:
-
Scott Violet authored
This does the following: If overflow-clip-margin changes, then need to repaint OverflowClipRect() and VisualOverflowRect() adjust for overflow-clip-margin (overflow-clip-margin is only set if overflow:clip is set along both axis). BUG=1087667 TEST=wpt/css/css-overflow/overflow-clip-margin-invalidation wpt/css/css-overflow/overflow-clip-margin-001.html Change-Id: I9875c724c153600bf8eafe633bc138d99de3099a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468794Reviewed-by:Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#819170}
-
Matt Menke authored
Pass in NIK to RemoveClient() call from ReportingHeaderParser::ParseHeader() Bug: 993805 Change-Id: Ic58d9ecbba5c5d3dbba9180f13882e23aac40818 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485391Reviewed-by:
Lily Chen <chlily@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#819169}
-
Alex Turner authored
Many users of FrameMatchingPredicate pass in a predicate constructed with base::Bind. That method is deprecated and should be replaced with the more explicit base::BindRepeating. This resolves all remaining users of base::Bind/base::Callback in chrome/browser/subresource_filter/, so it is removed from the legacy exception list. Bug: 1140547 Change-Id: I3e028360992a853b2b2a5ef7b4d08aeb9809dfbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487620Reviewed-by:
-
Thomas Lukaszewicz authored
This flag enables tab search on all Chrome desktop platforms. It also removes the deprecated kTabSearchFixedEntrypoint flag. Bug: 1099917 Change-Id: I9b695d399fdf7db8e3ae6c6f2c53be001b4f6248 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486991Reviewed-by:
-
Chong Gu authored
Some devices take up to 2 minutes for netstack to come up, use BOOT_DISCOVERY_TIMEOUT_SECS to determine timeout time for device-finder. Add -timeout flag for finding devices via resolve as well Bug: 1080853 Change-Id: Ieb56c6ef909721e746b83cd4c915ddc5a723c309 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487832Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Chong Gu <chonggu@google.com> Auto-Submit: Chong Gu <chonggu@google.com> Cr-Commit-Position: refs/heads/master@{#819166}
-
- 20 Oct, 2020 4 commits
-
-
Mila Green authored
Bug: 1140270 Change-Id: I4baacdb26df224630ace30810510a9eb312e8d9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487693 Commit-Queue: Mila Green <milagreen@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#819165}
-
Clark DuVall authored
There were three separate issues which were preventing the VR native code from working correctly: - Isolated split class loaders can't load native libraries (b/171269960) - Shared libs for modules were not being added to the module descriptor - The GVR native methods need to be manually registered now that GVR code is not in the base module. Bug: 1126301 Change-Id: I184ea61fe4ef97a598ecf47b6e3cd81f4425ec1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486571 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
-
Wenyu Fu authored
Change FirstFragmentInflated with V2 suffix; record the time between FreIntentCreated and first fragment inflated, align with other MobileFre.FromLaunch*. Bug: 1138660 Change-Id: Ie02b0f7681b50b81f50efeb71d8349719f8b4cfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472711 Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Auto-Submit: Wenyu Fu <wenyufu@chromium.org> Cr-Commit-Position: refs/heads/master@{#819163}
-
Erik Språng authored
Bug: webrtc:11551, b/163310303 Change-Id: I5eb5f59f9c68315305c1bdb380bb7d3d192a02c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487340 Auto-Submit: Erik Språng <sprang@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Reviewed-by:
-
