- 17 Apr, 2018 40 commits
-
-
Jay Civelli authored
Makes services/service_manager/sandbox/switches.h the only place for sandbox related switches, removing the dupped ones in content and changing all call sites. Tbr: bradnelson@chromium.org Bug: 831846 Change-Id: I08928c664e0e2340ac5168d6fd94a07bbeb81266 Reviewed-on: https://chromium-review.googlesource.com/1012986 Commit-Queue: Jay Civelli <jcivelli@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#551448}
-
Veranika Liaukevich authored
Change-Id: Ie559fbf3eff5e7010b8ff0728a89a49aaa200731 Reviewed-on: https://chromium-review.googlesource.com/1015282 Commit-Queue: Joe Mason <joenotcharles@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#551447}
-
David Reveman authored
This is only a problem if the keymap changes while the client is running. Bug: 833986 Test: weston-eventdemo Change-Id: I239870812a9c971132c331b5f3c3f257cda72547 Reviewed-on: https://chromium-review.googlesource.com/1015507Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#551446}
-
dpapad authored
This is a reland of cdf4606b. Retrying to land this now that crbug.com/833656 is fixed. Original change's description: > Roll closure compiler > > Latest compiler version does not include Chrome's externs by default. They > need to be explicitly included. > > Change log: > https://github.com/google/closure-compiler/compare/8fc82299c45b0a33f19834222acda4850fd77bc0...5cae9b78a16a2655627733b66d1c686d5f547925 > chrome.js: 7ef3422e1e87480d560247d75fee181b4cac24d9 > chrome_extensions.js: 3a0b0052782af3f0bd3a5fe10bb568cdd769db4e -> 03c824e85e7b77bde4e7449ed3727608b05b2acc > polymer-1.0.js: 55e962227e676cd30f81439573771326933aae54 -> 8f3b8c9354813ae0e2f186bf2f504cf3f3182a66 > > BUG=831004 > > Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation > Change-Id: I0db559ee9a198dadd3b23e57b835cc6b985540a9 > Reviewed-on: https://chromium-review.googlesource.com/1006182 > Reviewed-by: calamity <calamity@chromium.org> > Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> > Cr-Commit-Position: refs/heads/master@{#551058} TBR=calamity Bug: 831004 Change-Id: I0966b1a07da3b6318fb22a6bc6393eb499446743 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/1015180Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#551445}
-
Robert Liao authored
This reverts commit 902d73ba. Reason for revert: This causes the ExtensionPopup to dismiss if it brings up a child dialog. See http://crbug.com/832623 Fixing this will require adding support to check for descendant NativeWidget activation, which is too big to merge. Original change's description: > Adjust ExtensionPopup Dismissal Behavior > > Before, dismissing the ExtensionPopup when the anchor window received > focus was an arbitrary decision (http://crbug.com/179786) that allowed > the ExtensionPopup to dismiss at most of the right times. However, if > the some other top-level window received activation, the ExtensionPopup > would not dismiss, unlike a typical menu. > > This change adjusts the ExtensionPopup to always dismiss when it loses > activation as long as devtools is not attached. > > When devtools is detached, activation is placed back on the > ExtensionPopup so that the normal dismissal behavior can continue to > work. Failure to receive activation means the ExtensionPopup will not > dismiss until it receives activation at least once. > > BUG=825867 > > Change-Id: I802af281616c66013c370e892953ad2805533728 > Reviewed-on: https://chromium-review.googlesource.com/984404 > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Commit-Queue: Robert Liao <robliao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#547391} TBR=ellyjones@chromium.org,sky@chromium.org,robliao@chromium.org,rdevlin.cronin@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 825867, 832623 Change-Id: I69678b789fdbc56501e67b62dd41467e5f2f8cc9 Reviewed-on: https://chromium-review.googlesource.com/1015181 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#551444}
-
Morten Stenshorne authored
The test was incorrect, which is why it failed in legacy layout. It passed in LayoutNG because of a bug there. Add an (invisible) top border on the outer DIV to prevent clearance on the child. Otherwise the outer DIV and the child with 'clear' would have adjacent margins, which in turn would enable the child with 'clear' to pull the float along with itself, which in turn would guarantee clearance, which is precisely what this test wanted to avoid. Still passes in LayoutNG. Change-Id: I6b36d8196b93720453d6e398509705d2cf32f8e4 Reviewed-on: https://chromium-review.googlesource.com/1014975Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#551443}
-
Xiaocheng Hu authored
This patch revises the cold mode idle time spellchecker that, it only checks the editable element that is currently focused, instead of checking the full document, so that the checker is less aggressive and less resource consuming. Bug: 824030, 716642 Change-Id: I1361b53b4dd3513252ef50d0356497c0a4054ecd Reviewed-on: https://chromium-review.googlesource.com/1014472 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#551442}
-
Takumi Fujimoto authored
This is a reland of d37f3a32 This fixes the issue of attributes in UIMediaSink not being initialized at instantiation, which was breaking MSAN builds. TBR=estade@chromium.org,bsep@chromium.org Original change's description: > Implement sink list button for Harmony Cast dialog > > - Add CastDialogSinkButton, which will be used for sink list items in > the Harmony Cast dialog. It's a subclass of HoverButton that shows a > device icon and an optional status indicator (checkmark or throbber). > - Add UIMediaSink, a struct containing data used to populate the button > - Add Skia icons used by the button: Cast for EDU, input, speaker, > speaker group, and TV > > Screenshot of the button (two of them) in a WIP dialog: > https://drive.google.com/file/d/1M1R9jO-VHEO18aA3pTpoQBI4FHMU5MEf/view?usp=sharing > > Dimensions and colors are subject to change in later CLs. > > Bug: 826089, 826393 > Change-Id: I0eef58e1c0b9bf2cff3b3d146e911d3a18c7d23c > Reviewed-on: https://chromium-review.googlesource.com/996458 > Commit-Queue: Takumi Fujimoto <takumif@chromium.org> > Reviewed-by: mark a. foltz <mfoltz@chromium.org> > Reviewed-by: Bret Sepulveda <bsep@chromium.org> > Reviewed-by: Evan Stade <estade@chromium.org> > Reviewed-by: Adam Parker <amp@chromium.org> > Cr-Commit-Position: refs/heads/master@{#550722} Bug: 826089, 826393 Change-Id: Ib9343fc56a96f128c3b3d2bfa5e82542e94a4441 Reviewed-on: https://chromium-review.googlesource.com/1014540Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
Adam Parker <amp@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#551441}
-
https://webrtc.googlesource.com/src.git/+log/6dfc8d6ef3b2..4478d9b7733d $ git log 6dfc8d6ef..4478d9b77 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=chromium:None,chromium:None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I0c840e576be99c817a3a422bace6b58d7eb6d749 Reviewed-on: https://chromium-review.googlesource.com/1014952Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#551440}
-
Tommy Steimel authored
Bug: 809021 Change-Id: Ia8adffa5011fa6e2ae1d1aeef727f407eb9ccb2d Reviewed-on: https://chromium-review.googlesource.com/1014721Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#551439}
-
Wez authored
Bug: 823529 Change-Id: I5620f741d815619bc91bdf60ad09fa2dd24ef79c Reviewed-on: https://chromium-review.googlesource.com/1013391Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#551438}
-
Tibor Goldschwendt authored
Change-Id: I7884167434cb9796aa5a7c9d9ac22180219466cb Reviewed-on: https://chromium-review.googlesource.com/998409Reviewed-by:
Becky Zhou <huayinz@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#551437}
-
Rohit Rao authored
BUG=None Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ied5177a665451fc1a50f1b79a0c5f2bc27f1eba6 Reviewed-on: https://chromium-review.googlesource.com/1015542Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#551436}
-
Xianzhu Wang authored
For now partial raster invalidation of SPv175+ is buggy. Disable it first to fix regressions. Pinpoint job for smoothness.tough_canvas_cases benchmark doesn't show performance regressions of this CL: https://pinpoint-dot-chromeperf.appspot.com/job/14b05086c40000 Bug: 833338, 833598 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I52545c5cc757f045afa3df1c98221a28f25d5689 Reviewed-on: https://chromium-review.googlesource.com/1013298Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#551435}
-
Yang Guo authored
V8 introduced a new API that no longer requires the source string. Change-Id: If09c25a2892633a4aedadb62e963c50ffa291cbe Reviewed-on: https://chromium-review.googlesource.com/1013519 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#551434}
-
Vaclav Brozek authored
password_form_conversion_utils.cc used the constructor of std::unique_ptr explicitly. This is to be avoided in Chromium's code (//PRESUBMIT.py has a check against introducing new instances) and nullptr and std::make_unique are preferred. form_autofill_util.cc used a raw owning pointer and base::WrapUnique to convert it to std::unique_ptr. Instead, the owned object should be wrapped in unique_ptr since construction, to avoid the risk of introducing a leak later. This CL fixes both issues mentioned above. Bug: 833838 Change-Id: Id62f146e69a659bd594678989310f2d212151572 Reviewed-on: https://chromium-review.googlesource.com/1013716 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#551433}
-
rbpotter authored
Bug: 773928 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I01397a7c4b94a2a3d3f71ef80d0fb38abd7f29dd Reviewed-on: https://chromium-review.googlesource.com/1011324Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#551432}
-
Vaclav Brozek authored
SyntheticForm's data member fieldsets is only set and used once, in the same function. Therefore this CL reduces the size of SyntheticForm and extracts the fieldsets data member as a local variable in said function. Bug: 833838 Change-Id: Ie5970adf3b0a2c52c783e599b658d1d0f27473eb Reviewed-on: https://chromium-review.googlesource.com/1014043 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#551431}
-
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/130fd7666d42..30a2b933e3a0 $ git log 130fd7666..30a2b933e --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src-internal The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Icb5791b7c4cee1c7997ee59134506e426c08e836 Reviewed-on: https://chromium-review.googlesource.com/1015082 Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#551430}
-
Xiaocheng Hu authored
This patch deduplicates code in the function to improve code health, and also as a preparation for implementing NG version of bidi adjustment. Bug: 822575 Change-Id: Ia975338ff11d2e53d73f084e4b55419b03c2938c Reviewed-on: https://chromium-review.googlesource.com/997134 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#551429}
-
Jennifer Apacible authored
BUG: 726619 Change-Id: I17314a2e1989cf2f2b760d9f931fd53272730440 Reviewed-on: https://chromium-review.googlesource.com/1013683Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: apacible <apacible@chromium.org> Cr-Commit-Position: refs/heads/master@{#551428}
-
Daniel Erat authored
Enable mode-specific power button behavior by default. In short, tapping the power button turns the display off on devices that are in tablet mode but is ignored on devices that are in laptop mode. Bug: 819276, 783164 Change-Id: Ic658e034366a32066940c647a73b8c61ecec2840 Reviewed-on: https://chromium-review.googlesource.com/1014486 Commit-Queue: Dan Erat <derat@chromium.org> Reviewed-by:
Min Chen <minch@chromium.org> Reviewed-by:
Qiang Xu <warx@google.com> Cr-Commit-Position: refs/heads/master@{#551427}
-
Steven Bennetts authored
Using a separate name div breaks dragging when the name is dragged and isn't necessary. Bug: 833036 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ia9bcc8556018e9dd6d76e0dac6221ecbf85997c7 Reviewed-on: https://chromium-review.googlesource.com/1014624 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#551426}
-
Vaclav Brozek authored
A SyntheticForm is an object created specifically for the GetPasswordForm function to consume. Yet, the function only takes a const reference of a SyntheticForm. This prevents the function from sparing some copies in moving data from a SyntheticForm to a PasswordForm. This CL changes the const reference to a plain value, moves the SyntheticForm via std::move on the callsites, and ensures that SyntheticForm has a move constructor. Bug: 833838 Change-Id: Iaee54b092c7f12b91b2afd35f4882b9d451ce668 Reviewed-on: https://chromium-review.googlesource.com/1013983 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#551425}
-
https://chromium.googlesource.com/catapult.git/+log/69a36a622381..055c0339565a $ git log 69a36a622..055c03395 --date=short --no-merges --format='%ad %ae %s' 2018-04-13 ulan Use top-level scheduler tasks in EQT metric. Created with: roll-dep src/third_party/catapult BUG=chromium:832651 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I47174a35e3658f1e5d17302f9cb3be9292bba63e Reviewed-on: https://chromium-review.googlesource.com/1014705Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#551424}
-
Vaclav Brozek authored
SyntheticForm is an abstraction of a collection of form input elements for the purpose of creating PasswordForm objects based on DOM tree. It currently stores a reference to the web document, only to derive the form's origin from it later. This CL drops the reference to the web document and replaces it with the computed origin. This way, SyntheticForm does not keep an unnecessary amount of data alive. It does introduce one GURL copy, but that will be addressed in a separate CL by making GetPasswordForm consume a SyntheticForm instead of looking at its const reference. Bug: 833838 Change-Id: I33011146289b60bb50898f70f8001af6668a4203 Reviewed-on: https://chromium-review.googlesource.com/1014130 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#551423}
-
Christopher Grant authored
Stale size is a risky element accessor that we no longer use (it's last remaining case was unused SnackBar code, which if reintroduced, should be reworked to use proper layout methods). BUG= R=tiborg Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ida852a9c7cfba668020d09824fa0a79ef12ddb63 Reviewed-on: https://chromium-review.googlesource.com/1007631 Commit-Queue: Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#551422}
-
bsheedy authored
Reduces the flakiness of testControllerClicksRegisteredOnDaydream in two ways: 1. Adds code to handle GVR briefly disconnecting then reconnecting the controller, which caused us to receive multiple gamepadconnected events. 2. Ensures any input that was sent to register the gamepad is drained before actually starting the test, as slow intents could be received later and cause the test to end earlier than expected. Bug: 831589 Change-Id: I8041030ef6ec177ad47216eb1c1ea9e0f875e7c4 Reviewed-on: https://chromium-review.googlesource.com/1012439Reviewed-by:Yash Malik <ymalik@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#551421}
-
Benjamin Pastene authored
This thing has a pretty big effect on our cros bots. TBR=jbudorick@chromium.org Change-Id: Ic63ae04d448b0cf6e9328226d518779f102a5686 Reviewed-on: https://chromium-review.googlesource.com/1015627Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#551420}
-
Jiaquan He authored
This commit skips some logic when the AppListClient pointer is not set in AppListControllerImpl. This makes clusterfuzz happy at this point, and avoids potential crashes in the future. Bug: 824104 Bug: 733662 Change-Id: I82612d59ae23e843e47192a4254080f4a8fa67fd Reviewed-on: https://chromium-review.googlesource.com/1015220 Commit-Queue: Jiaquan He <hejq@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#551419}
-
Erik Chen authored
This CL has no intended behavior change. This CL cleans up test structure and updates some comments. Change-Id: I3b5ed07813ec416dd67098d9f93b702a115cee09 Bug: 827545 Reviewed-on: https://chromium-review.googlesource.com/1014371 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#551418}
-
Dave Tapuska authored
Mojo Input messages for all platforms except Android Webview shipped in Chrome 64. Mojo Input messages for Android Webview shipped in Chrome 66. BUG=722928 Change-Id: I3e085b401beb2ef394e4a6ce257ed1566b12fe8a Reviewed-on: https://chromium-review.googlesource.com/998803Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#551417}
-
Nektarios Paisios authored
Browsers don't use only the HTML lang attribute to compute document language. We rely on the layout engine to compute language if a layout object is available, , otherwise we use our own logic. We also use our own logic if the layout engine cannot figure out the language. Our own logic first looks at the lang attribute on the current object, or any of its ancestors, followed by the "content-language" meta tag, the accept language header and the browsers default UI language. The latter two steps provide a mere guess, but are better than simply returning en-US, which is our current implementation for IAccessible2. This certainly is an improvement over the current situation, though not perfect by all means. R=dmazzoni@chromium.org Bug: 831186 Tested: Manually using foreign language sites without lang attributes and Chrome's the "--lang" command line flag, automatically using layout tests Change-Id: Ia80c31cc6dabdcea2aeec177aeda6b29d695019e Reviewed-on: https://chromium-review.googlesource.com/1011332 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#551416}
-
Garret Kelly authored
In the near future zx_port_{wait,queue} will not accept a count of zero. Change all callers to call these functions with a count of one. Change-Id: I1a3fbcbb051c1da674fd6080685abd8c26067170 Reviewed-on: https://chromium-review.googlesource.com/1015481 Commit-Queue: Garret Kelly <gdk@chromium.org> Reviewed-by:Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#551415}
-
Joe Mason authored
R=csharp Bug: 830892 Change-Id: I8ebbeabc201571e754b8905aff9ba1b88598b48c Reviewed-on: https://chromium-review.googlesource.com/1003061Reviewed-by:
Chris Sharp <csharp@chromium.org> Commit-Queue: Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#551414}
-
Henrik Boström authored
WebRtcMediaStreamTrackAdapterMapStressTest added due to https://crbug.com/813574. This continuously creates and destroys local and remote track adapters concurrently in an attempt to cause a deadlock if possible (hopefully not). This also removes some invalid thread checks at the destructor of ~WebRtcMediaStreamTrackAdapter and ~WebRtcMediaStreamAdapterMap. The first of which made the stress test flaky (https://crbug.com/826365). The adapter's DCHECK was invalid because the remote audio track's Dispose (which properly DCHECKs that it is invoked on the main thread) can jump to the signaling thread and back with a reference to the adapter. It is possible for the signaling thread's task to be the last reference to the adapter. Similarly, WebRtcMediaStreamAdapterMap is reference counted and tasks referencing on different threads could make which thread references it last racy. We don't care which thread was the last reference as long as it is empty (which it is if and only if all adapters have been destroyed on the appropriate threads). Bug: 827450 Change-Id: I5f819948fc2148e810f343e027fa8011b03d2335 Reviewed-on: https://chromium-review.googlesource.com/983553Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#551413}
-
Elly Fong-Jones authored
HungRendererController autoreleases itself, which doesn't work well when it doesn't actually hold a reference to the containing window (which it doesn't in MacViews builds). This fixes the HungRendererController interactive UI test. Bug: 823517 Change-Id: I5fc14faa8eeaba7b20f5e922a43d4817ca2c810a Reviewed-on: https://chromium-review.googlesource.com/1015261Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#551412}
-
Qiang Xu authored
changes: To serve decoding icon for app shortcut plumbed from android, this class shouldn't be scoped to app_list namespace. Bug: 803291 Test: compiles & covered by tests Change-Id: Ia7c8e69a69a610769ae3e049921205200d2c577e Reviewed-on: https://chromium-review.googlesource.com/1014567Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Qiang Xu <warx@google.com> Cr-Commit-Position: refs/heads/master@{#551411}
-
Elly Fong-Jones authored
Accept() can be called more than once on the same MenuController, via context menus; in this situation, it's important to clear the animation so that input events get handled after the animation completes. Bug: 833048 Change-Id: Id3ac92ce91e78b57f2120d4527e35e597ea03067 Reviewed-on: https://chromium-review.googlesource.com/1012876Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#551410}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 0cd1c432. With Chromium commits locally applied on WPT: 303956b6 "Enable WPT tests for the Generic Sensor classes" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/15712 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: I2f718a4bdc8986b13086c22436ff18a6f374fa15 Reviewed-on: https://chromium-review.googlesource.com/1015320 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#551409}
-