GitLab

On Android, Telemetry sets the chrome command line file before running any pages.
If the file doesn't already exist, it tries to write it as a normal user, rather
than root, which fails. This patch explicitly checks if the file exists. If it
doesn't exist it writes the file as root.

BUG=284468

Review URL: https://chromiumcodereview.appspot.com/23726018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221426 0039d316-1c4b-4281-b951-d872f2087c98

When clearing the contents of a framebuffer, also invalidate/discard it
if the GL implementation supports this functionality. This improves
performance especially on tiling architecture GPUs since the graphics
driver does not need to restore the previous contents of the framebuffer
before proceeding with rendering.

Note that normally we don't clear the contents of framebuffers whose
contents we know we will completely re-render. This patch will still
invalidate such framebuffers to let the driver know that the previous
contents are not relevant.

BUG=274334

Review URL: https://chromiumcodereview.appspot.com/23601013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221425 0039d316-1c4b-4281-b951-d872f2087c98

Save password functionality added to the save password bubble behind flag. The buttons now let the user save and blacklist passwords.

BUG=261628

Review URL: https://chromiumcodereview.appspot.com/22975006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221424 0039d316-1c4b-4281-b951-d872f2087c98

Broke Android Tests:
http://build.chromium.org/p/chromium.linux/buildstatus?builder=Android%20Tests%20%28dbg%29&number=14173

> Fix threading issues in aw form database
> 
> BUG=285584
> 
> Review URL: https://chromiumcodereview.appspot.com/23803005

TBR=sgurun@chromium.org

Review URL: https://codereview.chromium.org/23679005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221423 0039d316-1c4b-4281-b951-d872f2087c98

This collects timing data as well as error codes for initial policy
fetches on Chrome OS. These block Profile creation, so we'd like to
get some insight on how much delay this encurs in the field.

BUG=271321
TEST=Log in to an enrolled device, check chrome://histograms

Review URL: https://chromiumcodereview.appspot.com/23271009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221422 0039d316-1c4b-4281-b951-d872f2087c98

We weren't recording errors for SyncParent and it turns out to be the
2nd most common source of I/O errors on CrOS when opening a database.

Review URL: https://chromiumcodereview.appspot.com/23681009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221420 0039d316-1c4b-4281-b951-d872f2087c98

This is the first part of the code to allow faster stats/future
compression stuff to register for a notification when a block of data
has been fully ACKed by the peer.

The idea is as follows:

Someone who wants to be notified when their data is ACKed calls
SendStreamDataAndNotifyWhenAcked instead of SendStreamData, and provides
a Closure.

The QuicConnection stores the Closure in a QuicAckNotifier, and
maintains a vector of these.

On every ACK frame received, the OnAck(acked_seqnums) method of each
QuicAckNotifier is called. The QuicAckNotifier keeps track of the
sequence numbers it is waiting to see, and after being notified of all
of them it calls the Closure's Run() method.

Merge internal change: 51476134

Changed SourceAddressToken's code not to include port number while
performing crypto handshake (found in EndToEnd unit tests).

Use IPAddressToPackedString for source address token comparison.


Add CryptoServerConfig::set_strike_register_no_startup_period() to allow
a QuicServer to start accepting 0-RTT handshakes without waiting
a startup period.

Add an end-to-end test for a successful 0-RTT handshake.

Merge internal change: 51419595

Copying the overly-lenient SPDY workarounds to handling priority blocked
streams for idle timeout logic.

Merge internal change: 51406984

For this CL, the only chromium side change is to add
QuicConnectionPeer::SetPeerAddress.

Log packet retransmissions to DLOG(INFO). Use the standard format for
the log messages for crypto handshake messages on the client side.

Merge internal change: 51336227

New frame ID scheme to eliminate conflict between STREAM and PADDING
frames. PADDING frames are now stream type 0. Description of the new
scheme is in quic_framer.cc.

Merge internal change: 51271708

Fixing a bug in implicitly created streams which results in early packet
loss causing all streams to hang.

Merge internal change: 51248632

R=rch@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23464033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221419 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jam (new file in chrome.gyp) 
BUG=278002

Review URL: https://chromiumcodereview.appspot.com/22972007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221418 0039d316-1c4b-4281-b951-d872f2087c98

The facebook.com page sometimes wouldn't scroll, because the scroll height
would be equal to the window height. The page seems to dynamically load
elements and scroll height only gets updated after that. To avoid this
problem, this CL makes telemetry wait until the value for scroll height
has been updated.

BUG=238864
R=tonyg@chromium.org

Review URL: https://codereview.chromium.org/23957002

Patch from Dominik Grewe <dominikg@google.com>.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221416 0039d316-1c4b-4281-b951-d872f2087c98

Expose the incognito state of URLs to the activity log API.  Any
recorded URLs which were from an incognito window are prefixed with
"<incognito>", as is done in the database storage.

Re-enable the incognito subtests in the end-to-end activity log test.

BUG=272920

Review URL: https://chromiumcodereview.appspot.com/23618010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221415 0039d316-1c4b-4281-b951-d872f2087c98

Save password bubble pops up automatically when the save password icon is triggered upon logging in to a page.

BUG=261628

Review URL: https://chromiumcodereview.appspot.com/23557004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221414 0039d316-1c4b-4281-b951-d872f2087c98

From mac's fsync man page:

For applications that require tighter guarantees about the integrity of their
data, Mac OS X provides the F_FULLFSYNC fcntl.  The F_FULLFSYNC fcntl asks the
drive to flush all buffered data to permanent storage.  Applications, such as
databases, that require a strict ordering of writes should use F_FULLFSYNC to
ensure that their data is written in the order they expect.

Also, specifically check for a return value of -1 from fdatasync. mac's fcntl
only guarantees to return -1 on error and something other than -1 on success.
All other platforms agree to return -1 on error for fsync/fdatasync/_commit.

Review URL: https://chromiumcodereview.appspot.com/23549017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221413 0039d316-1c4b-4281-b951-d872f2087c98

BUG=285179

Review URL: https://chromiumcodereview.appspot.com/23532040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221412 0039d316-1c4b-4281-b951-d872f2087c98

Broke Linux ChromiumOS Tests (1):
http://build.chromium.org/p/chromium.chromiumos/buildstatus?builder=Linux%20ChromiumOS%20Tests%20%281%29&number=32217

> Add ManagedUserSettingsService and a SupervisedUserPrefStore using it.
> 
> BUG=280674
> 
> Review URL: https://chromiumcodereview.appspot.com/23466004

TBR=bauerb@chromium.org

Review URL: https://codereview.chromium.org/23477040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221411 0039d316-1c4b-4281-b951-d872f2087c98

BUG=280674

Review URL: https://chromiumcodereview.appspot.com/23466004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221410 0039d316-1c4b-4281-b951-d872f2087c98

BUG=285584

Review URL: https://chromiumcodereview.appspot.com/23803005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221409 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
R=chrisgao@chromium.org

Review URL: https://codereview.chromium.org/23531035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221408 0039d316-1c4b-4281-b951-d872f2087c98

This CL extracts non-notification-related logics from EventRouter and move it
to the VolumeManager.
Now, EventRouter::OnDiskAdded, OnDiskRemoved, OnFormatStarted and
OnFormatCompleted focus on event routing, and VolumeManager has responsibility
of other stuff.

BUG=279276
TEST=Ran unit_tests and tested manually.

Review URL: https://chromiumcodereview.appspot.com/23890002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221407 0039d316-1c4b-4281-b951-d872f2087c98

The Activity Log will only send a max of 300 rows per lookup. This should be completely satisfactory for the Watchdog app -- we can't display more than 300 rows of data in any meaninful way anyway. This is also below the IPC memory boundary.

BUG=241672

Review URL: https://chromiumcodereview.appspot.com/23874008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221406 0039d316-1c4b-4281-b951-d872f2087c98

Disable VP9 capability for Android devices as Android devices out
there in the market does not support VP9 yet.

BUG=285016
R=acolwell@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23731006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221405 0039d316-1c4b-4281-b951-d872f2087c98

A race condition can occur when a polling thread tries to obtain a pointer to the shared memory via a std::map, while that map is modified by the main thread.
This patch implements a fix such that the polling thread does not have direct access to the std::map where the shared memory pointers are stored. Instead the pointer is passed as an argument of the Start() method.

This patch fixes the DataFetcherSharedMemoryBaseTest.DoesPollMotionAndOrientation test on linux tsan.

BUG=284959

Review URL: https://chromiumcodereview.appspot.com/23441047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221404 0039d316-1c4b-4281-b951-d872f2087c98

Broke compilation on Win Aura:
http://build.chromium.org/p/chromium.win/buildstatus?builder=Win%20Aura%20Builder&number=11770


> [SystemInfo API] Implement DisplayInfoProvider::UpdateDisplayUnitInfoForPlatform method for Linux GTK.
> 
> Also rename display_info_provider_x11 to display_info_provider_linux for
> better understand.
> 
> BUG=None
> 
> Review URL: https://chromiumcodereview.appspot.com/22891026

TBR=Hokein.Wu@gmail.com

Review URL: https://codereview.chromium.org/23706007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221403 0039d316-1c4b-4281-b951-d872f2087c98

a. Expand/shrink <webview> element when 'sizechange' event fires, to
match with the new view size (in shim).
b. For SW mode, fix a bug where damage buffer would remain smaller than
the view size and would result in crash. Added test for this case.

BUG=173238, 282116
Test=WebViewTest.AutoSize.*, <webview>.autosize=true now should autosize
webview container within the constraints
(minwidth/maxwidth/minheight/maxheight).

Review URL: https://chromiumcodereview.appspot.com/23691039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221402 0039d316-1c4b-4281-b951-d872f2087c98

TEST=net_unittests

Review URL: https://chromiumcodereview.appspot.com/23685005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221401 0039d316-1c4b-4281-b951-d872f2087c98

This moves the views parts out of cross-platform omnibox_view_browsertest.cc into a views specific file (c/b/ui/views/omnibox_view_views_browsertest.cc).

BUG=125846
TEST=interactive_ui_tests --gtest_filter=OmniboxViewViewsTest.SelectAllOnClick
R=pkasting@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23494016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221400 0039d316-1c4b-4281-b951-d872f2087c98

requestAutocomplete displays a splash screen as well as an
interstitial while communicating with wallet using the overlay shield.

The current dialog is hidden behind the shield for the duration, and
the shield can contain images as well as text messages.

R=sail@chromium.org
BUG=157274, 260951

Review URL: https://chromiumcodereview.appspot.com/23674004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221399 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221398 0039d316-1c4b-4281-b951-d872f2087c98

R=rmistry@google.com

Review URL: https://codereview.chromium.org/23526018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221397 0039d316-1c4b-4281-b951-d872f2087c98

Right now the <select> dialogs use directly
R.layout.select_dialog_(multi|single)choice defined in the Android
framework. Adding an extra level of indirection to them through attrs
since other builds need to override these two layouts.

BUG=285270
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/23523025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221396 0039d316-1c4b-4281-b951-d872f2087c98

    
Webrtc unfortunately likes to sleep in BaseChannel::Send on the renderer's
ChildThread while directly or indirectly calling into HW encoder and we end 
up in a number of deadlocks of varying complexity in one way or another,
while trying to also use the ChildThread to allocate shared memory to service 
those calls.
The only way to avoid this is to not get onto the ChildThread while servicing
webrtc requests, so we use the static ChildThread::AllocateSharedMemory()
to send the request directly from the current thread.
    
Also add VEA::RequireBitstreamBuffers() to the initialization sequence, so that
RTCVideoEncoder::InitEncode() will only return after we've allocated requested
buffers. VEA::RequireBitstreamBuffers() is effectively a part of initialization
sequence anyway, because we can't really call VEA::Encode() without knowing the
VEA impl's coded size requirements. This could also potentially reduce
the latency of the first Encode() call.

And separately, zero out header structures sent to the client.

TEST=apprtc.appspot.com with HW encoding
BUG=260210

Review URL: https://chromiumcodereview.appspot.com/23440015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221395 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None, just working fine.

Review URL: https://chromiumcodereview.appspot.com/22909048

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221394 0039d316-1c4b-4281-b951-d872f2087c98

Switch from text insertion to key press and release events on the virtual keyboard. First step in integration the virtual keyboard with IMEs.
BUG=257093, 257098

Review URL: https://chromiumcodereview.appspot.com/20145004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221393 0039d316-1c4b-4281-b951-d872f2087c98

Broke
http://build.chromium.org/p/chromium.chromiumos/buildstatus?builder=ChromiumOS%20%28daisy%29&number=12452

and maybe
http://build.chromium.org/p/chromium/buildstatus?builder=Linux%20x64&number=55236
http://build.chromium.org/p/chromium.win/buildstatus?builder=Win%20x64%20Builder&number=9603

> Use Finch to compare the performances of CLD1 and CLD2
> 
> Add a compile time constant CLD_VERSION, which indicates the version of CLD. If this is not define, Finch test to compare CLD1 and CLD2 is supposed to be used.
> 
> By this CL, each platform will have the below status:
> 
> Linux:    Use both CLD1 and CLD2 (and use Finch).
> Mac OS X: Use both CLD1 and CLD2 (and use Finch).
> Windows:  Use only CLD1 once because now CLD2 can't be compiled on Windows. After we can have CLD2 compiled on Windows, we will use CLD2 and Finch asap.
> iOS:      Still use only CLD1. (It's because it is hard to use both CLD1 and CLD2 on mobile platform because of the binary size impact.)
> Android:  Still use only CLD1. (The same reason as iOS)
> 
> So some platforms will have two CLD binaries, but this is temporal in the sense that we intend to use Finch only for Dev and Beta channel. Before releasing the stable Chromium version, we decide which version of CLD is adopted, make another CL to use only one CLD, and send a merge request. (Of course, we hope we will be able to adopt CLD2.)
> 
> BUG=240647
> 
> Review URL: https://chromiumcodereview.appspot.com/22867032

TBR=hajimehoshi@chromium.org

Review URL: https://codereview.chromium.org/23766011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221391 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221390 0039d316-1c4b-4281-b951-d872f2087c98

> Blink roll 157169:157224
> 
> http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=157170:157224&mode=html
> TBR=
> BUG=
> 
> Review URL: https://chromiumcodereview.appspot.com/23960002

Blink commit r157177 broke builds for ChromeOS, because of a missing include:
third_party/WebKit/Source/core/platform/audio/DenormalDisabler.h:114:27: error: 'FLT_MIN' was not declared in this scope

See also http://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20%28daisy%29/builds/12414/steps/cbuildbot/logs/stdio

TBR=eseidel@chromium.org

Review URL: https://codereview.chromium.org/23458024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221389 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221388 0039d316-1c4b-4281-b951-d872f2087c98

> Blink roll 157224:157244
> 
> http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=157225:157244&mode=html
> TBR=
> BUG=
> 
> Review URL: https://chromiumcodereview.appspot.com/23681008

TBR=eseidel@chromium.org

Review URL: https://codereview.chromium.org/23530037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221387 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221386 0039d316-1c4b-4281-b951-d872f2087c98

> Blink roll 157250:157284
> 
> http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=157251:157284&mode=html
> TBR=
> BUG=
> 
> Review URL: https://codereview.chromium.org/23536027

Blink commit r157177 broke builds for ChromeOS, because of a missing include:
third_party/WebKit/Source/core/platform/audio/DenormalDisabler.h:114:27: error: 'FLT_MIN' was not declared in this scope

See also http://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20%28daisy%29/builds/12414/steps/cbuildbot/logs/stdio

TBR=eustas@chromium.org

Review URL: https://codereview.chromium.org/23749005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221385 0039d316-1c4b-4281-b951-d872f2087c98

- Re-post callbacks only if they are called synchronously
- Always return a valid operation ID (even if it's finished immediately)
- Fix cancel callbacks ordering

BUG=279288
TEST=existing tests
TBR=hidehiko@chromium.org, tzik@chromium.org

Review URL: https://codereview.chromium.org/23898002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221384 0039d316-1c4b-4281-b951-d872f2087c98