- 15 Jan, 2021 40 commits
-
-
Toby Huang authored
This CL removes dead code related to legacy supervised users and renames TODO(crbug/866790) to TODO(crbug/1155729), which is the main bug for tracking legacy supervised user code removal. Bug: 866790 Change-Id: I7ece1ef3e9f4dd548d8f3387d98082f490030d12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626194Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Dan S <danan@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Dan S <danan@chromium.org> Auto-Submit: Toby Huang <tobyhuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#844181}
-
Yuke Liao authored
This reverts commit e2f3b551. Reason for revert: Breaks local user flow when entering chrome_sdk ERROR at //build/config/chromeos/rules.gni:180:11: Undefined identifier. _symlink_targets[2], ^----------------- See //chromeos/BUILD.gn:239:3: whence it was called. generate_runner_script("cros_test_wrapper") { ^-------------------------------------------- See //BUILD.gn:442:7: which caused the file to be included. "//chromeos:chromeos_unittests", Original change's description: > Lacros: create lacros tast test targets > > This CL creates gn targets for lacros tast tests, and the main > motivation is to run lacros tast tests on Chromium CI. > > Bug: 1158590 > Change-Id: I783779c3386a39743b8227367189b0b87832b9dc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606188 > Commit-Queue: Yuke Liao <liaoyuke@chromium.org> > Reviewed-by: Ben Pastene <bpastene@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@google.com> > Cr-Commit-Position: refs/heads/master@{#844127} TBR=dpranke@google.com,liaoyuke@chromium.org,bpastene@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I1e51bf2e6aa97bfc40beba7d2693b68361cab2bc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1158590 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633782Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#844180}
-
Yue Zhang authored
Instead of using one boolean value in profile pref to record dismiss/restore state of cart module, this CL introduces two boolean values to record whether the module is temporarily hidden or permanently removed. Bug: 1157892 Change-Id: I01d95a62fca6466ab893c7be8afbc20b5065ddf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625816Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#844179}
-
Victor Costan authored
Moving features to the Storage Service requires the ability to talk to the Quota system via mojo. storage::QuotaClient is one of the interfaces that needs to be mojofied. Migrating all QuotaClient usage to mojo in one CL is risky, because this CL would introduce timing changes to 7 storage systems (AppCache, Cache Storage, File System, IndexedDB, NativeIO, Service Workers, WebSQL). Therefore, QuotaClient will be migrated piece by piece. This CL introduces the storage::mojom::QuotaClient interface, and integrates it with QuotaManager. To facilitate a gradual migration, QuotaManager will support both mojofied and non-mojofied QuotaClients. QuotaManager tests will cover both types of clients, to ensure correct operation throughout the migration. Other tests that integrate with QuotaManager will use mojofied clients, because this reduces future churn. To maximize test coverage, QuotaManager's support for mojofied QuotaClients is written on top of the support for non-mojofied QuotaClients. This CL also adds TODOs documenting the cleanup that will be required once all QuotaClients are mojofied. Bug: 1016065 Change-Id: I6df5a97763447e41eb3b523e180a6c13dfa3199c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610633 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#844178}
-
Dave Tapuska authored
Move GetPluginInfo to be a method on the PepperHost mojom object. This code path is used for content layer (content shell is one example) to load plugins. (chrome embedders use a ContentClient override). Remove the now useless RenderFrameMessageFilter. BUG=1157519 Change-Id: I0c1e4c74b86351169637b72c4224c9000ca70945 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630545 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#844177}
-
Etienne Bergeron authored
These histograms are no longer used. The timing and count information is already available into RenderText for every platforms. There is no need to have a windows specific histograms. R=robliao@chromium.org Bug: 1151976 Change-Id: I0c90c44ace8f6607a55112a117a75cdd5b4eb20f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611585Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#844176}
-
Moe Ahmadi authored
This is a useful metric to monitor the adoption of the promo browser commands. Fixed: 1165094 Change-Id: I2df2e242cc072eb5ee74716a029eae111373584b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632065Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#844175}
-
Mike Dougherty authored
Bug: 1164846 Change-Id: I975c02ac34bb4e37a06ae7759eaffb7984f95065 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628024Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Chris Thompson <cthomp@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#844174}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-linux-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: Icc88c13289498fcfcc2c39167d5c81552bb2c8db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633171Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844173}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/3100aca993ac..1502a9ec072f 2021-01-15 vidorteg@microsoft.com [Loc] Migrate event_listener pane to Localization V2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1136655 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id2a9e3e8dfd61dd665a51c036a2f1ed4dae1f602 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633134Reviewed-by:
-
Andy Paicu authored
Bug: 1138595 Change-Id: I7b5ab3739842122e5b71f208b4e0bb237636ee3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624608 Commit-Queue: Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#844171}
-
Ross McIlroy authored
BUG=v8:9684 Change-Id: I724817e74370ecb3ef2f931fc16dc2324bd73629 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632612 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Auto-Submit: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#844170}
-
Ella Ge authored
Bug: 1155353 Change-Id: I1057fa0184ac79b6b28f1f0a863d6d630dc3f816 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630068Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#844169}
-
Fabrice de Gans-Riberi authored
The test is flaky. TBR=atwilson@chromium.org Bug: 1167239 Change-Id: I44c744fb99848edb28f63821e899b93e2993e41d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633093Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#844168}
-
Brian Ho authored
A page flip can result in a SWAP_NAK_RECREATE_BUFFERS signal, indicating that the backing buffers must be recreated. Since the buffers are entirely uninitialized, we should damage the entire screen for the next draw [1]. Unfortunately, this doesn't work in SkiaRenderer because the GPU thread performs the actual reallocation [2] and then posts a task to the Viz thread to update the damage. The task taces with the next invocation of DirectRenderer::DrawFrame, so there's no guarantee that the new damage will be picked up in time for the next frame. If it isn't, we will present a buffer with uninitialized data. This CL fixes this issue by pausing SwapBuffer invocations after reallocating buffers until we receive a frame with full screen damage (e.g. the Viz thread catches up with the GPU thread). [1] https://source.chromium.org/chromium/chromium/src/+/master:components/viz/service/display_embedder/gl_output_surface_buffer_queue.cc;l=263;drc=3c0194e7917daed5debe0d0772393e5784367e01 [2] https://source.chromium.org/chromium/chromium/src/+/master:components/viz/service/display_embedder/skia_output_device_buffer_queue.cc;l=458;drc=7ccffaf0933ccc647c744bf66971bcf5f33a676a Bug: 1156182 Change-Id: Ibf0bf3d6903c4c4f2dadcfc71dfda36a03b513d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630227Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Brian Ho <hob@chromium.org> Cr-Commit-Position: refs/heads/master@{#844167}
-
Collin Baker authored
Ensures subscribers know when a thumbnail is cleared, and avoids sending them stale thumbnails from previous requests. Fixed: 1163121 Change-Id: I31d881808fb2a6bb14ae20b7d5b2d67545b585c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628031Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#844166}
-
Garrett Beaty authored
Bug: 1167232 Change-Id: I04177bb8c4cc7f0c31f8fe2a549f0ce837529b81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633094Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#844165}
-
Michael Crouse authored
This fixes some path and test data issues that cause tests to fail when enabling TFLite in the build. This also creates a TFLite resolver for Chrome with the set of ops to be supported initially. Bug: 1165517 Change-Id: Ib0acdcb380578e94f4b7172b5ebe27ab6faafc25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631186Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Commit-Queue: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#844164}
-
Rakib M. Hasan authored
Adding this command line argument fixes an issue with tests running on Android M x86 emulator builders. The issue is that the emulator fails to reboot after disabling boot verification. Bug: 1114563, 1165307 Change-Id: Iab36b6c2c2ec3766e259fc1cfaa4c25fdc4fbb7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631159Reviewed-by:
-
Fabrice de Gans-Riberi authored
The test is flaky. TBR=achuith@chromium.org Bug: 1167243 Change-Id: I40dae90f9e18013b673c4a5188500bacf2d79c3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633095 Auto-Submit: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/5a6fda1a6fcc..54449966dd2e 2021-01-15 senorblanco@chromium.org Workaround ANGLE hang with a glFlush(). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC dsinclair@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: dsinclair@google.com Change-Id: Ic7ea8a8acc69373179e51e8b41a5b8b8a6204b93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633661Reviewed-by:
-
Caitlin Fischer authored
The server-side config shows that this on only old versions of Chrome. Plus, as of [1] the feature is enabled on TOT for desktop. [1] crrev.com/c/2063530 Bug: 1126640 Change-Id: I17afe09c1da894411f66ef7791a1c1edc441d00a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632126 Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#844160}
-
philipel authored
Bug: webrtc:12271 Change-Id: I343ab2a1a6ff4d7740e0074d008382b4d45b9580 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631266Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Philip Eliasson <philipel@chromium.org> Cr-Commit-Position: refs/heads/master@{#844159}
-
Fabrice de Gans-Riberi authored
The test is failing flakily TBR=mlamouri@chromium.org Bug: 1167236 Change-Id: I9091e1fa70540e2967c71c8cdd22a2aec343c8f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632806Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Auto-Submit: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#844158}
-
Matthew Mourgos authored
This change updates the position of the clipboard nudge when the shelf is set to auto-hide. Also updates position for the case when side shelf is set to left or right. Bug: 1165974 Change-Id: Ib44089b2a8df58e12c4dd54c23aa21b17a374d3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628737 Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#844157}
-
Joe DeBlasio authored
This CL expands the list of common words ignored by target embedding to the full list from //components/url_formatter/spoof_checks/common_words. It also removes words that are on that list from the existing list of common words (which is maintained as a supplemental list). This CL also adds a little bit of logic to disable common word detection on domains that are in the special list of domains that are allowed to be embedded, but only at the end (domains that are higher-value that use common word). This is necessary since, e.g., "office" is a common word on the full common word list, but not in the old list. A side effect of this change is that the common word list is included in Android. This list causes a big bump in binary size. A future edit may reduce the size of the word list used for Android, but that'll be a substantial engineering effort, and this list is an important mitigation in a security feature. The list is efficiently stored as a DAFSA, so I know of no obvious way to shrink it down. Binary-Size: Size increase is unavoidable (see above). Bug: 1154726 Change-Id: I417d92761377f6b6e11772b8f06c9b36b5083676 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630738 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#844156}
-
Angus L. M. McLean IV authored
Bug: 760279 Change-Id: I122f307af8047932ee593e8f4baccd5591d74ad4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622767Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Angus McLean <angusmclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#844155}
-
arthursonzogni authored
The culprit has been reverted: https://chromium-review.googlesource.com/c/chromium/src/+/2625867 and we verified the crashed were gone. R=danakj@chromium.org Bug: 1153966,1153961 Change-Id: Ic99bbed56808188c92a34b8761e43b5621cf9e0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632988Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#844154}
-
Shuran Huang authored
Use the existing origin, site_for_cookies and top_frame_origin values to create an IsolationInfo object to pass into RestrictedCookieManager, which is more aligned with the original behavior (before https://crrev.com/c/2582608) where those three fields were passed into RestrictedCookieManager directly. Bug: 1166328 Change-Id: Id44edf91f15fc8fde93c483d3b4ed2fb25c02548 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630370Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Shuran Huang <shuuran@chromium.org> Cr-Commit-Position: refs/heads/master@{#844153}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-win-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I259374770df774db4c684a089fa41bcc0bbe4f9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633443Reviewed-by:
-
Fabrice de Gans-Riberi authored
http/tests/websocket/multiple-connections-throttled.html is flaky on every platform. See bug for details. Bug: 1167222 Change-Id: Ia3b28cbc716da45b098877c2677a4c319fad9e64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633089 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1610711423-bdaee35d021c9a50df10abe9e0067f035c4386a3.profdata to chrome-win64-master-1610722723-f9a37ccb3c40c7cf55cb95edac87150ac0997011.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I9e59897fec8592c79bd5b55098efc94d5ed8c9f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633169Reviewed-by:
-
Cherie Cheung authored
In the existing code, for Drive FS path, ConvertPathToArcUrl() will call guest_os::GuestOsSharePath::SharePath(), which in turns will call Seneschal's SharePath(). As Seneschal's SharePath() is an asynchronous call, it may result in a race condition. To solve this: 1. ConvertPathToArcUrl() will return a flag to indicate if the path needs to be shared. 2. ConvertToContentUrls() will return a list of paths to be shared. 3. A new wrapper function ConvertToContentUrlsAndShare() will handle the path sharing after path conversion is completed. Bug: b:161427985 Test: 1. With FilesApp's OpenWith function (in ARC++/ARCVM), android app can open a Drive FS file. 2. Intent URI can launch an android app. 3. Chrome OS FilesApp as Android file picker works. 4. Drag-and-drop Drive FS file to an android app can open the file. 5. Drive FS thumbnails are showing properly. 6. Chrome camera app can open/save file normally. 7. Note taking android app can annotate images. Change-Id: Idfb0069b7ad2b407cf599748b766b4bf4899b7bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601007Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Cherie Cheung <cherieccy@google.com> Cr-Commit-Position: refs/heads/master@{#844149}
-
W. James MacLean authored
This CL ensures that when a local mainframe is converted to a remote one that the VisualViewport for the new mainframe is reset. This is important since non-unit PageScaleFactor should only be stored for local mainframes, otherwise the scale will be innappropriately removed from event coordinates in out-of-process iframes. Bug: 1150977 Change-Id: I4dc8cc4ea0c4521a2f999c97607671ff62d4d159 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629491 Commit-Queue: James MacLean <wjmaclean@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#844148}
-
Dan Harrington authored
And send the HEART capability when it's set. Bug: 1158468 Change-Id: Ib7b64ecd4dff4aa23701de0eeceac0b8d1635ee1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594121 Commit-Queue: Dan H <harringtond@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#844147}
-
Fabrice de Gans-Riberi authored
The test is flaky on Linux, ChromeOS and Android. TBR=dominickn@chromium.org Bug: 1167226 Change-Id: I98fb83da5c47fd0aed1e05045fbd2ecbf2886b3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633090 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Auto-Submit: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
-
Robert Sesek authored
Not all devices report this information, so do not test for it. Bug: 1167123, 1164549 Change-Id: Ia2e0262e7a6692cccdc114bbf2decea76c4655ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633668Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#844145}
-
Colin Blundell authored
This CL changes the subresource filter to handle the action of the user initiating a reload of a page with blocked ads entirely within the component, rather than delegating to the embedder. This change concretely means that WebLayer now obtains this behavior for free. To test proper integration in WebLayer, this CL also adds browsertests of the expected behavior in //weblayer. We disable these browsertests on Windows due to https://crbug.com/1152429. Bug: 1116095 Change-Id: I270aff6251d0a498af77b9748bf129036e4d3541 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606345 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#844144}
-
Bin Du authored
Lock screen and lock screen app profiles are not regular user profiles. They disable sync and should be skipped when reading sync settings. Bug: b:175067939 Change-Id: I6634ce77efbb39a493df0161a16796650cac73c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628052Reviewed-by:
Gabriel Marin <gmx@chromium.org> Commit-Queue: Bin Du <dubin@google.com> Cr-Commit-Position: refs/heads/master@{#844143}
-
Michael Ershov authored
* Extract creation of policy_request into a standalone function Bug: 1150887 Test: CloudPolicyClientTest* Change-Id: Ie5f67e1272ef9b2692b71ae0c7effade3016999b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550565 Commit-Queue: Michael Ershov <miersh@google.com> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#844142}
-
