- 05 Jan, 2021 39 commits
-
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/4110684aa07a..c120b02dbe14 2021-01-05 hao.x.li@intel.com Remove internal resolve buffer from Timestamp compute shader 2021-01-05 hao.x.li@intel.com Get timestamp period from device If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC enga@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: enga@google.com Change-Id: I1cfe252415c181bb6f226b08e4247539be19be5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610607Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840090}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/fc1733482433..84cad4eea312 2021-01-05 rsavitski@google.com Merge "Move using declaration into anon namespace." 2021-01-05 rsavitski@google.com Merge "Update stale link." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ie3f61a6e0ff2be7e2018d17a8a338ae8e7831381 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610610Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1609804351-3203bece27fc3ccf79be3681f60781e79b3a670b.profdata to chrome-mac-master-1609821402-1a521f5068c0d6782637fa5e747428dbb99c8286.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I5962672e6964fb04494a173f8ad9d1918740597a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610609Reviewed-by:
-
Victor Costan authored
Change-Id: Ie8b1bf20fe9994693d4fefd75aed5d68b9a889cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610050Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#840087}
-
Mitsuru Oshima authored
Bug: None AX-Relnotes: n/a Change-Id: I92b3aa0070dcdf9b229315046c0b9a0c99a5519c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588835Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Kuo-Hsin Yang <vovoy@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#840086}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1609804351-8e613a6255234d0544dc8b2f463c1386e923a27d.profdata to chrome-linux-master-1609821402-4ffa353dbb439d0e8adf0e53cbe86a4c4b758321.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I383b44089afb35a18908c94f8cb996c6801ae022 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610605Reviewed-by:
-
chrome://internals/web-appAlan Cutter authored
Change-Id: I19946e78dd3cdc03d4f5991e9aba24f9c6e8167f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610406 Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#840084}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/9d7f897b22c2..d00a5cd12448 2021-01-05 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I3e4b9e01bcb151415457ac9c58ebcb0f9046ff6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610338Reviewed-by:
-
Darren Shen authored
TextInputClients now support moving the cursor after committing some text. This patch adds support for input engines to call the new API. There is a slight complication with multiple CommitText calls during key event handling. Previously, when handling a key event, any calls to CommitText will be coalesced together and executed once the key event is handled. However, this coalescing logic doesn't handle cursor movement. Add logic to handle cursor movement when coalescing commits by observing that any sequence of CommitTexts with cursor movement can be implemented with two separate CommitTexts. Note that this is a no-op change if the IME never uses the new cursor movement parameter. Bug: 1155331 Change-Id: I6c89ec1cde5624eca7bf0d5c803085f7d7803c71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576067Reviewed-by:
Keith Lee <keithlee@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#840082}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1497e56c0f3e..2949c359547c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC ricea@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: ricea@google.com Change-Id: Id06b24034548cd30a60bda49c57c1edf098fc3e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610487Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840081}
-
Nazerke authored
Using |useIncognitoFallback| from the previous change to modify the background image for incognito for iOS12 and less. On iOS 13 there is no need to pick custom incognito assets because |overrideUserInterfaceStyle| is set to dark mode when in incognito. Bug: 1128249 Change-Id: I81e5b6e593766f01037ac6afda8e21986318ef81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596258Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Cr-Commit-Position: refs/heads/master@{#840080}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c8ac69d2..76bebd29 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I716ac4fd5478f40445e8267111035e4ebf02f775 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610336Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840079}
-
Nancy Wang authored
BUG=1146900 Change-Id: I31a1b5961cb91c3c5316c69cc75db1f4e51847d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596485 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#840078}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: Iebadf4314a5b2df15e5c1e14d96423a7e883bbcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610337Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840077}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/04ccda6c28c4..2207edd88cfe 2021-01-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 86980018b3f2 to cdbd295cc6c4 (4 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC johnstiles@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: johnstiles@google.com Change-Id: I1f07b6d58bde3ef83f9f41fab8e4915bb63ffe0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610467Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8f424e015364..1497e56c0f3e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC ricea@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: ricea@google.com Change-Id: I784e2eddf590adbd264923143ef8ad9776ec29ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610148Reviewed-by:
-
Eric Willigers authored
Attempting to launch an app that has been uninstalled results in nullptr WebContents being returned, with no check failures. Change-Id: I911904a068f9b03d92d5453cbbbdd243fbab2419 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2608102 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#840074}
-
Stefan Zager authored
This removes all responsibility for setting contents_opaque on foreign layers from GraphicsLayer. Bug: 1069546 Change-Id: Ic0e71392e354b919867e120515dd6235e0c382ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607665 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#840073}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/eae5c1619083..04ccda6c28c4 2021-01-05 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC johnstiles@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: johnstiles@google.com Change-Id: I10a1eef4a9840e54d5fdc88aa362bce083632270 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607703Reviewed-by:
-
Stefan Zager authored
contents_opaque on the canvas cc::Layer shouldn't depend on its host GraphicsLayer; and the host GraphicsLayer shouldn't use any special logic to determine contents_opaque. This also fixes a CAP-specific bug where the paint code would emit a background DisplayItem for a canvas even when the canvas has responsibility for its own background. As a side effect, this appears to fix a Mac-specific webgl bug that was hidden due to bad test expectations files added by: https://chromium-review.googlesource.com/c/chromium/src/+/1005017/ Bug: 1069546 Change-Id: I2a347a6d4a04d2d8b4e299dd0cb10a3c57acbfb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607423Reviewed-by:
-
Glen Robertson authored
Apps should always declare at least one Purpose::ANY icon (or no purpose declared) to be handled properly on all platforms. Even when a maskable icon is preferred as the primary icon (eg. on Android) an 'any' purpose icon is still needed for other contexts. Companion CL to update DevTools error messages: crrev.com/c/2557277 Bug: 1151835 Change-Id: I1995b1677d1392a5e852e544f34435826cce4e7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599733Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=bindusuvarna@chromium.org Change-Id: Ia40c893634935ebd430d666c7708e6bf2459ab55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606137Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840069}
-
Eric Willigers authored
This reverts commit 813f4fa3. Reason for revert: Findit suspects test caused failures. Original change's description: > System web apps: Do not launch apps during shutdown > > If the browser process is shutting down, LaunchSystemWebApp now > exits early instead of attempting to launch a system web app. > > Bug: 1121894 > Change-Id: I4ed8baf23e2e58d79cc097566e2b566fdef78619 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607978 > Reviewed-by: calamity <calamity@chromium.org> > Commit-Queue: Eric Willigers <ericwilligers@chromium.org> > Cr-Commit-Position: refs/heads/master@{#840053} TBR=calamity@chromium.org,ericwilligers@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I885b3f75016ac816c4c4ee715b024e395e9ebf75 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1121894 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610403Reviewed-by:
-
Nico Weber authored
Ran `./tools/clang/scripts/upload_revision.py 5c951623bc8965fa1e89660f2f5f4a2944e4981a`. Bug: 1154382 Change-Id: Iff83fc56e3f0e0172ee4dfdea95cc1144d1d819b Binary-Size: See analysis in crbug.com/1159421 Cq-Include-Trybots: chromium/try:chromeos-amd64-generic-cfi-thin-lto-rel Cq-Include-Trybots: chromium/try:dawn-win10-x86-deps-rel Cq-Include-Trybots: chromium/try:linux-chromeos-dbg Cq-Include-Trybots: chromium/try:linux_angle_deqp_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_cfi_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_chromeos_msan_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_compile_dbg_32_ng Cq-Include-Trybots: chromium/try:linux_chromium_msan_rel_ng Cq-Include-Trybots: chromium/try:mac-arm64-rel,mac_chromium_asan_rel_ng Cq-Include-Trybots: chromium/try:win-angle-deqp-rel-64 Cq-Include-Trybots: chromium/try:win-asan,win7-rel,win-angle-deqp-rel-32 Cq-Include-Trybots: chrome/try:iphone-device,ipad-device Cq-Include-Trybots: chrome/try:linux-chromeos-chrome Cq-Include-Trybots: chrome/try:win-chrome,win64-chrome,mac-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605479 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#840067}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/da2d927bb127..4110684aa07a 2021-01-05 jiawei.shao@intel.com Vulkan: Fix a bug in the impl of T2T copy with 2D array textures If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC enga@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: chromium:1161355 Tbr: enga@google.com Change-Id: I16564dab5da0bc077645f2c60c507ba92994599d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610334Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I1041b44508289e65fad6696c32c42e5cc5861a08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2609868Reviewed-by:
-
Song Fangzhen authored
Below documents are from Eric Willigers <ericwilligers@chromium.org>. Explainer: https://github.com/WICG/raw-sockets/blob/master/docs/explainer.md Design doc: https://docs.google.com/document/d/1Xa5nFkIWxkL3hZHvDYWPhT8sZvNeFpCUKNuqIwZHxnE/edit?usp=sharing Bug: 905818 Change-Id: I3d956d6310e865b603a25122d937d70d6dcf2383 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2608092Reviewed-by:
Glen Robertson <glenrob@chromium.org> Reviewed-by:
-
Eric Willigers authored
If the browser process is shutting down, WebAppLaunchManager::OpenApplication now exits early instead of attempting to launch a web app. Bug: 1121894 Change-Id: Ic67f4c89a02082d13d867a8484b3b2c368c96900 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2608095Reviewed-by:
-
Jing Wang authored
Implemented a first version of grammar check client, which just throw the entire requested text to grammar service and if it returns with any suggestion other than the original text, we will mark the whole sentence and show the suggestion in context menu. Design doc of the feature: go/cros-grammar Screenshot of the feature: https://screenshot.googleplex.com/BqkRhx6BYC2LPiF This feature is ChromeOS only and is hidden behind a by-default disabled flag. When the flag is enabled, and when enhanced spell check is enabled, we will call grammar check when enhanced spell checker detects no spell errors and display grammar error if we find any. It is not ideal to always check the entire input and mark the whole sentence. The feature is to be improved in the follow-up CLs, but I think this is good enough as a first version. Bug: 1132699 Test: tested on DUT Change-Id: Ie2a8ca99e2f6910e9eef6bb3c7eb5da980a4db92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585245 Commit-Queue: Jing Wang <jiwan@chromium.org> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#840062}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1609782840-839bd136deb880fc20cbdc9d089b73d42309602b.profdata to chrome-mac-master-1609804351-3203bece27fc3ccf79be3681f60781e79b3a670b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I61fbb4918526715c137c3dd543e16f554b0f0806 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610332Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/364205c70ed1..81098e59adfc 2021-01-05 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I52a1abf0f473c896503230eb12fbef597c4e7866 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610329Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1609782840-2863408690cf666d03abe5466bfc61c0dcf0aee3.profdata to chrome-linux-master-1609804351-8e613a6255234d0544dc8b2f463c1386e923a27d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I486eb928d661f1afbaa0be668b16d42d67b5c612 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610328Reviewed-by:
-
Angela Gyi authored
This CL adds a single example of a ShareAction for testing the content previews feature on Chrome OS devices. Bug: 1159279 Change-Id: Ia8e0e5dfbc00ab664468667363ece01f4b71ad1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592276Reviewed-by:
Melissa Zhang <melzhang@chromium.org> Commit-Queue: Angela Gyi <angelagyi@google.com> Cr-Commit-Position: refs/heads/master@{#840058}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c6dd30db1029..8f424e015364 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I82e826e53cf8f47ecc5ee35fb04c6fd2b8bb84a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2609846Reviewed-by:
-
Daniil Lunev authored
The actual usage of the field is removed as of https://chromium-review.googlesource.com/c/chromium/src/+/2513592 And after this CL the field is deprecated in https://chromium-review.googlesource.com/c/chromiumos/platform2/+/2594928 Bug: none Test: none Change-Id: If86b0b65c9dd28b25d68778d640380dd55b46b21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596276Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Daniil Lunev <dlunev@chromium.org> Cr-Commit-Position: refs/heads/master@{#840056}
-
Weblayer Skew Tests Version Updates authored
This CL will add skew tests for version 87.0.4280.139. R=rmhasan@google.com, tikuta@chromium.org Bug: 1041619 Change-Id: I4425be5bb5d32f7c80659af6654c3474da000044 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2609784 Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#840055}
-
Weblayer Skew Tests Version Updates authored
This CL will add skew tests for version 88.0.4324.74. R=rmhasan@google.com, thakis@chromium.org Bug: 1041619 Change-Id: I26c3061f6b12bcba5f5a33165bad501c3e0b4ebf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2609785 Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
-
Eric Willigers authored
If the browser process is shutting down, LaunchSystemWebApp now exits early instead of attempting to launch a system web app. Bug: 1121894 Change-Id: I4ed8baf23e2e58d79cc097566e2b566fdef78619 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607978Reviewed-by:
-
Jinsuk Kim authored
This CL moves some of c.b.toolbar/ classes in the core build target to a new modularized one under chrome/browser/toolbar. The rest still stay in the core target due to direct or indirect references to dependencies such as omnibox. Bug: 1127732 Change-Id: I160deef07817b05dfd8e22adbd65225456de29ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592277 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#840052}
-
- 04 Jan, 2021 1 commit
-
-
Chloe Pelling authored
Now it's fully general, so can be used by Borealis. The unit tests do still depend on Crostini, for now. Bug: b:173546714 Change-Id: Id88527e2bc631f60b8885a56c88cd619d4172250 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578421 Commit-Queue: Chloe Pelling <cpelling@google.com> Reviewed-by:
Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#840051}
-
