GitLab

BUG=120762
TEST=None

Review URL: https://chromiumcodereview.appspot.com/9885001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129494 0039d316-1c4b-4281-b951-d872f2087c98

R=estade@chromium.org
BUG=None
TEST=None
NOTRY=true

Review URL: http://codereview.chromium.org/9773045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129493 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129492 0039d316-1c4b-4281-b951-d872f2087c98

Copied from dschuff's patch.

BUG= none
TEST= nacl sdk trybots

Review URL: https://chromiumcodereview.appspot.com/9837115

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129491 0039d316-1c4b-4281-b951-d872f2087c98

BUG=120594
TEST=manual, see bug.

Review URL: http://codereview.chromium.org/9784012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129490 0039d316-1c4b-4281-b951-d872f2087c98

The threaded compositor bypasses RenderWidget::DoDeferredUpdate(). Added two calls in RenderWidget::willBeginCompositorFrame() that are normally called in DoDeferredUpdate to support IME.

BUG=120361
TEST=manual

Review URL: https://chromiumcodereview.appspot.com/9873029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129489 0039d316-1c4b-4281-b951-d872f2087c98

See https://bugs.webkit.org/show_bug.cgi?id=81861 for the other side of this.

BUG=119417
TEST=existing tests get less flaky

Review URL: http://codereview.chromium.org/9764018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129488 0039d316-1c4b-4281-b951-d872f2087c98

There are cases where we'll process a GestureFlingStart event on the
compositor thread, initiate a wheel fling, and then later determine that
we can't process the rest of the animation on the compositor thread. One
example of where this could happen is if the page registers a mousewheel
JS event listener while the fling is in progress.  In this case, we need
to transfer the animation to the WebView to process so it can generate
the correct events.

This implements the transfer as a call out via the
WebCompositorInputHandlerClient. I think this is a reasonable place to
put the interface, since it's intimately related with the input
processing stream.

BUG=don't have handy, but there is one
TEST=wheel fling on CrOS should work with --enable-threaded-compositing


Review URL: http://codereview.chromium.org/9802006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129487 0039d316-1c4b-4281-b951-d872f2087c98

This is a follow-up to codereview.chromium.org/9773033 .

Review URL: https://chromiumcodereview.appspot.com/9875031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129486 0039d316-1c4b-4281-b951-d872f2087c98

BUG=120484
TEST=None

Review URL: https://chromiumcodereview.appspot.com/9873038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129485 0039d316-1c4b-4281-b951-d872f2087c98

As I noted in the bug, these unit tests had gotten broken by some recent changes because they weren't being run automatically.

BUG=120308
TEST=(this is adding a presubmit test)

Review URL: https://chromiumcodereview.appspot.com/9865009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129484 0039d316-1c4b-4281-b951-d872f2087c98

BUG=120140
TEST=none

Review URL: https://chromiumcodereview.appspot.com/9873020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129483 0039d316-1c4b-4281-b951-d872f2087c98

These are necessary after the changes that went in with

crrev.com/129042 (http://codereview.chromium.org/9836078)

Update: also fix some fallout from crrev.com/129251

BUG=120481
TEST=(this is a test)

Review URL: https://chromiumcodereview.appspot.com/9866050

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129482 0039d316-1c4b-4281-b951-d872f2087c98

This is particularly bad as File API implementation uses FILE thread,
thus can make File API calls unresponsive.

BUG=chromium-os:28597
TEST=unit_tests and confirm the file browser works as before.

Review URL: https://chromiumcodereview.appspot.com/9877006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129481 0039d316-1c4b-4281-b951-d872f2087c98

need to. The reason we should only invoke LayoutShelf is that it'll
cancel any animations. Here's the two problematic scenarios I noticed:
. ImageView::SetImage invoked PreferredSizeChanged even if it
  didn't. PreferredSizeChanged eventually makes it way to LayoutShelf,
  so we should only invoke this if the preferred size actually
  changed.
. StatusAreaLayoutManager::SetChildBounds need not do anything if the
  size matches.

BUG=120679
TEST=none
R=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/9877009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129480 0039d316-1c4b-4281-b951-d872f2087c98

C++ code generated by generate_bindings.py was assigning a variable withing in if() statement (Visual Studio 2010 warning C4706).
I moved the assignment of the variable to the line before the if() statement so that the assignment of the variable happens outside of the if() statement.

Additionally, I added myself to the AUTHORS file. I filled out the Contributor License Agreement a while back, but didn't add myself to AUTHORS at that point.

BUG=chromium:81439

Review URL: http://codereview.chromium.org/9836106

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129479 0039d316-1c4b-4281-b951-d872f2087c98

CID=103659
BUG=NONE
TEST=NONE

Review URL: http://codereview.chromium.org/9836122

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129478 0039d316-1c4b-4281-b951-d872f2087c98

CID=102833, 102995
BUG=None
TEST=None


Review URL: http://codereview.chromium.org/9860044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129477 0039d316-1c4b-4281-b951-d872f2087c98

This primarily addresses issues with code using the OS-provided htonX() & ntohX() functions from within the Chrome sandbox.  Under Windows these functions are provided by ws2_32.dll, which is no longer available within Chrome's sandbox.

The new base::HostToNetXX() and NetToHostXX() functions are safe for use by sandboxed code on Windows, and provide a single place where future fixes for other platforms can be made.

BUG=117252

Review URL: http://codereview.chromium.org/9716020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129476 0039d316-1c4b-4281-b951-d872f2087c98

TBR=mukai@chromium.org
BUG=120601
TEST=none

Review URL: https://chromiumcodereview.appspot.com/9874030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129475 0039d316-1c4b-4281-b951-d872f2087c98

Revert 129448 - Automated tests for full screen & mouse lock M16 features

Tests added to browsertest to improve coverage for fullscreen and mouse lock transitions.

Several helper functions added to BrowserTest. Removes need to friend many tests and simplifies tests to increases readability.

IsFullscreenForTab() removed globally leaving only IsFullscreenForTabOrPending.

IsFullscreenForBrowser() added to fullscreen controller to enable testing.

typedef BrowserWithTestWindowTest BrowserTest; removed due to name conflict.

BUG=100678
TEST=


Review URL: http://codereview.chromium.org/9702055

TBR=scheib@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9875028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129474 0039d316-1c4b-4281-b951-d872f2087c98

100.

BUG=120686
TEST=none
R=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/9877010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129473 0039d316-1c4b-4281-b951-d872f2087c98

BUG=120726
TEST=none

Review URL: https://chromiumcodereview.appspot.com/9802044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129472 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129471 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129470 0039d316-1c4b-4281-b951-d872f2087c98

client cancels while auditing the redirect.
BUG=none
TEST=webkit_unit_tests --gtest_filter= AssociatedURLLoaderTests.*
Review URL: https://chromiumcodereview.appspot.com/9874008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129467 0039d316-1c4b-4281-b951-d872f2087c98

BUG=119647
TEST=NONE
Review URL: https://chromiumcodereview.appspot.com/9791077

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129466 0039d316-1c4b-4281-b951-d872f2087c98

Tests that use SendKeyPress should not be in browser_tests.

BUG=120578

Review URL: https://chromiumcodereview.appspot.com/9873013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129465 0039d316-1c4b-4281-b951-d872f2087c98

Currently the accessors are named as selected_item() and SetSelectedItem().
But we don't return any "item" at all, nor we set any "item". They aren't
objects. They are indexes.

So a more accurate name would be selected_index() and SetSelectedIndex().

This match with other ComboBox implementations (Java and .Net).

BUG=119289
R=sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/9875001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129464 0039d316-1c4b-4281-b951-d872f2087c98

This was breaking the 'chrome-linux-redux' bot, which compiles Chrome
for Linux with the same flags we're using for the Android port.

BUG=None
TEST=Compiles


Review URL: http://codereview.chromium.org/9867002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129463 0039d316-1c4b-4281-b951-d872f2087c98

BUG=117456
TEST=


Review URL: http://codereview.chromium.org/9836093

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129462 0039d316-1c4b-4281-b951-d872f2087c98

BUG=83828
TEST=None
TBR=sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/9875024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129460 0039d316-1c4b-4281-b951-d872f2087c98

BUG=120634
Review URL: https://chromiumcodereview.appspot.com/9844018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129458 0039d316-1c4b-4281-b951-d872f2087c98

BUG=120705
TEST=None

Review URL: https://chromiumcodereview.appspot.com/9844030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129457 0039d316-1c4b-4281-b951-d872f2087c98

TEST=unit test
BUG=120297


Review URL: http://codereview.chromium.org/9836126

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129456 0039d316-1c4b-4281-b951-d872f2087c98

Only keep functions needed on the slave in tree_creator.py. Move the rest to
isolate.py.

R=rogerta@chromium.org
BUG=98834
TEST=Run from the ouput directory:
    GYP_DEFINES="$GYP_DEFINES tests_run=hashtable" ../../build/gyp_chromium; \
    ninja base_unittests_run; \
    ../../tools/isolate/tree_creator.py -m base_unittests.results --remote .

Review URL: https://chromiumcodereview.appspot.com/9834090

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129455 0039d316-1c4b-4281-b951-d872f2087c98

CID=103653,103654,103655
BUG=NONE
TEST=NONE

Review URL: http://codereview.chromium.org/9863050

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129454 0039d316-1c4b-4281-b951-d872f2087c98

CID=103620
BUG=NONE
TEST=NONE


Review URL: http://codereview.chromium.org/9866043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129453 0039d316-1c4b-4281-b951-d872f2087c98

This makes it easy to see what size is being used
to center/align the text, for example.

BUG=none
TEST=Open views_examples text styles example.
Review URL: https://chromiumcodereview.appspot.com/9864048

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129451 0039d316-1c4b-4281-b951-d872f2087c98

Only export dependent settings when necessary.

Forward-declare crypto classes to avoid including crypto headers in
sync headers (and thus neccessitating exporting crypto settings to
dependents).

BUG=117585
TEST=


Review URL: http://codereview.chromium.org/9701094

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129449 0039d316-1c4b-4281-b951-d872f2087c98