- 24 Jul, 2018 40 commits
-
-
Leszek Swirski authored
Add a new feature flag, ScheduledScriptStreaming, which makes the script streamer use the task scheduler for streaming tasks, rather than using a dedicated ScriptStreamerThread. Bug: chromium:865098 Bug: chromium:866868 Change-Id: I05ca411d8d5187c4b5180011ebce2a603e3944fe Reviewed-on: https://chromium-review.googlesource.com/1145386 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#577543}
-
Michael Spang authored
Bug: none Test: compile ozone_demo with is_component_build=true Change-Id: Icf24cfcb5c3737d9f51136da73a9bc593937f813 Reviewed-on: https://chromium-review.googlesource.com/1146981 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#577542}
-
Torne (Richard Coles) authored
Use IMMEDIATE_CRASH on official builds instead of BreakDebugger in LOG(CRASH), to try to increase the likelihood that stack unwinding will work correctly. BreakDebugger isn't guaranteed to have a stack frame and thus can thwart CFI unwinding. This matches the behaviour of CHECK() so should be pretty safe. Bug: 851851 Change-Id: I7bcf8669ee90aa3fe42769e4e4cc841bf1df1b57 Reviewed-on: https://chromium-review.googlesource.com/1147474Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#577541}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/18dc0c00..4ac42e42 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I78797ba6840fe9c144ea3d3fb2ac21cac12f1fcd Reviewed-on: https://chromium-review.googlesource.com/1148230Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577540}
-
Kurt Horimoto authored
Previously, |-continueTrackingWithTouch:withEvent:| returned NO when UIControl.touchInside became NO to short-circuit the tracking event. However, if the touches continued after this, |-endTrackingWithTouch: withEvent:| was not called, and the page control can be stuck in an intermediary state. This CL updates to continue tracking the pan after the touch leaves the page control's bounds so that the cleanup tracking callbacks can be properly received. Bug: 853634 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I0bfdedabceab824dd6ec4c687e3773fb0f4bcf63 Reviewed-on: https://chromium-review.googlesource.com/1147862 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#577539}
-
Yannic Bonenberger authored
Bug: 805496 Change-Id: Idb1cc63960409eeb8117d74267f5df33f401eb08 Reviewed-on: https://chromium-review.googlesource.com/932101 Commit-Queue: Yannic Bonenberger <contact@yannic-bonenberger.com> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#577538}
-
Matthew Cary authored
This performs the per-process phased offset processing used for the orderfile. Bug: 758566 Change-Id: I5cbdb69c4834d95a52f2e43ad3f72e4845413883 Reviewed-on: https://chromium-review.googlesource.com/1144935 Commit-Queue: Matthew Cary <mattcary@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#577537}
-
Reza.Zakerinasab authored
NOTRY=TRUE TBR=fserb@chromium.org Bug: 866850 Change-Id: I78fd73f7dafadac914938b14338d482cc4ab97ca Reviewed-on: https://chromium-review.googlesource.com/1148542Reviewed-by:
Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Cr-Commit-Position: refs/heads/master@{#577536}
-
Mirko Bonadei authored
Gn check can enforce dependencies only if the header is included with an absolute path (from the root of the project) or if "include_dirs" is used. It ignores -isystem and -imsvc since they are part of cflags (and similar variants). Since //third_party/abseil-cpp/absl:absl_include_config was using -isystem and -imsvc only to sidestep compiler warnings in absl code, it is good to try to switch back to include_dirs instead of adding -isystem/-imsvc support to "gn check". Bug: 862521 Change-Id: I9c2d01abad75023918a88f852e3080486dcafead Reviewed-on: https://chromium-review.googlesource.com/1124478 Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
-
Danyao Wang authored
Native content is typically presented after its placeholder navigation to ensure correct ordering of WebStateObserver callbacks. However, for UI smoothness when opening a new tab, native content is presented before its placeholder navigation as well (http://crbug.com/819606). This CL removes the duplicate presentation of native content after its placeholder navigation, by storing a flag in NavigationContextImpl that the native content is already presented. Bug: 865422 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I71dc25f6a3284c34cf946800dee9bb4581506370 Reviewed-on: https://chromium-review.googlesource.com/1146777 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#577534}
-
Charlie Andrews authored
Based on a try job in the linked bug, it looks like these stories are no longer failing. TBR=sullivan@chromium.org Bug: 798536 Change-Id: I44a6d819fa0fea6dc71b76d0189933b9009d3c78 Reviewed-on: https://chromium-review.googlesource.com/1143450Reviewed-by:
Charlie Andrews <charliea@chromium.org> Commit-Queue: Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#577533}
-
Andreas Haas authored
That prevents the linker from dead-stripping the function, as it is not called directly, it is resolved in the runtime via dlsym(). I copied the change from https://crrev.com/c/833995 R=mmoroz@chromium.org Bug: 837098 Change-Id: I998517ebab623e67d275fe656643a8ee5fd1e951 Reviewed-on: https://chromium-review.googlesource.com/1148391Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#577532}
-
Helen Li authored
gcm::SocketOutputStream is not keeping track of partial writes correctly. It will always try to write |next_pos_| bytes. This CL adds a regression test. Bug: 866635 Change-Id: Iccfc4c88a9247ff151073d3691e20ba052f082b0 Reviewed-on: https://chromium-review.googlesource.com/1147475 Commit-Queue: Helen Li <xunjieli@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#577531}
-
Oriol Brufau authored
[css-logical] Replace uses of webkit-prefixed logical properties with standard ones in /third_party/WebKit/LayoutTests Bug 850000 added standard logical properties and aliased prefixed ones to them. The prefixed properties are still used in various places, but the standard ones should be used instead. This patch replaces all the uses in /third_party/WebKit/LayoutTests, except that the original fast/css/logical-property-resolution.html is preserved in a new test logical-property-resolution-webkit-prefix.html to ensure that prefixed properties continue working. Spec: https://drafts.csswg.org/css-logical/#box BUG=862141 Change-Id: I3090713fc6fbe507a19724cca4f6ca69bcaf5eb9 Reviewed-on: https://chromium-review.googlesource.com/1147523 Commit-Queue: Oriol Brufau <obrufau@igalia.com> Reviewed-by:
Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#577530}
-
Calder Kitagawa authored
These flags are potentially preventing Chrome from being optimized on O+ devices. Having spoke with agrieve@ there is no easy way to ensure that these flags are the culprit with monochrome. However, if we move away from monochrome this will at least ensure that WebAPKs aren't the blocker of optimization. I've tested this on L, N and O devices and confirmed there don't appear to be any negative effects or crashes resulting from their removal. Notifications were tested using: https://tests.peter.sh/notification-generator/ as well as the bound and unbound WebAPK targets. Change-Id: I4e93db09aec3271493b29bfd310d1df8f27cb4d7 Reviewed-on: https://chromium-review.googlesource.com/1127150Reviewed-by:
Xi Han <hanxi@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#577529}
-
Elad Alon authored
|network_connection_tracker_| might never be set (if no profile is loaded). In that case, it should not be dereferenced. Bug: 866865 Change-Id: I490be08795f41908d7ac49fdcd5d8588fbea83b7 Reviewed-on: https://chromium-review.googlesource.com/1148335 Commit-Queue: Elad Alon <eladalon@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#577528}
-
Aldo Culquicondor authored
We now use exit prompts. The only remaining case was the unhandled code point when rendering URLs, but we should ever reach it. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I1e7e715b146d0052b893dcac0abb762e9cfb00d2 Reviewed-on: https://chromium-review.googlesource.com/1147433Reviewed-by:
Ian Vollick <vollick@chromium.org> Reviewed-by:
Amirhossein Simjour <asimjour@chromium.org> Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Cr-Commit-Position: refs/heads/master@{#577527}
-
Alexei Svitkine authored
With gmock, if any of the expectations fail, we will see a diff of the contents - in particular, we'll see the extra histogram name if there is one. Bug: 863262 Change-Id: Iff375adf1ebbc0a14d64005f48dd574efb45b8dc Reviewed-on: https://chromium-review.googlesource.com/1146907Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#577526}
-
Reilly Grant authored
This reverts commit daa348fa. Reason for revert: https://crbug.com/866782 Original change's description: > Attach UsbContext to libusb_device(_handle) pointers > > This change modifies ScopedLibusbDeviceRef and adds a new class > ScopedLibusbDeviceHandle. This now explicitly own a reference to the > UsbContext object (which reference counts a libusb_context) in addition > to the libusb_device or libusb_device_handle they are wrapping. > > This resolves potential use-after-frees possible when posting tasks > with a ScopedLibusbDeviceRef since the UsbService the task is being > posted to could be destroyed before the task is executed. The > libusb_device would then be released after its libusb_context has been > destroyed. > > This is based on https://crrev.com/c/1131949 after I realized there > where additional issues that needed to be addressed. > > Bug: 838947 > Change-Id: Idee02828bf615bd477033e585fffe03cf4d20595 > Reviewed-on: https://chromium-review.googlesource.com/1145910 > Reviewed-by: Ken Rockot <rockot@chromium.org> > Commit-Queue: Reilly Grant <reillyg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#577329} TBR=rockot@chromium.org,reillyg@chromium.org Change-Id: I4146987c84b34e1d3625e7e91cfc672afe98054c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 838947 Reviewed-on: https://chromium-review.googlesource.com/1147950Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#577525}
-
Rayan Kanso authored
updateUI accepts a dictionary now, where the developer can change the title and/or the icon. TBR=haraken@chromium.org Bug: 865063 Change-Id: I779c05ee6bdeee83ce94793eddb4409af95395c6 Reviewed-on: https://chromium-review.googlesource.com/1142152 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#577524}
-
Vadym Doroshenko authored
As part as implementation of saving in NewPasswordFormManager some parts of PasswordFormManager will be copied to NewPasswordFormManager. Let's make clean-up of the old code first. Bug: 831123 Change-Id: Idb6acf4e0308d6193e3dbf4da07f73ee63859e99 Reviewed-on: https://chromium-review.googlesource.com/1073231Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#577523}
-
Leonard Grey authored
Bug: 866748 Change-Id: If48fa3bf307e8dc7876360840acced8e83f7572a Reviewed-on: https://chromium-review.googlesource.com/1148015Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#577522}
-
Jochen Eisinger authored
Also change identity::ClearPrimaryAccount to work on a SigninManager, so I can use it in tests that have a production SigninManager. BUG=801971 R=blundell@chromium.org Change-Id: I49176bd7e50a0e7c208403e276371bf93822fde6 Reviewed-on: https://chromium-review.googlesource.com/1143268 Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#577521}
-
Adithya Srinivasan authored
Bug: 865571 Change-Id: I722a58f53bbeee0236e6fb64b8f7eb9956526c3c Reviewed-on: https://chromium-review.googlesource.com/1147485Reviewed-by:
-
Elly Fong-Jones authored
Resetting the text to the default color is incorrect - OmniboxTextView::SetText contains logic to apply special colors depending on the type of result. This change adds a method to OmniboxTextView called ReapplyStyling() which causes OmniboxTextView to recompute and reapply this text styling. This is necessary in high contrast modes because these use different text styling for the selected or hovered result. Bug: 865918 Change-Id: Ia2c68e6cb3329b1d58d86dc9f6999420810a9d6d Reviewed-on: https://chromium-review.googlesource.com/1145136Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#577519}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/903fb041a2f8..8afa86c63713 git log 903fb041a2f8..8afa86c63713 --date=short --no-merges --format='%ad %ae %s' 2018-07-24 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 522095f7d7fe..06235df9ff91 (1 commits) Created with: gclient setdep -r src/third_party/skia@8afa86c63713 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@chromium.org Change-Id: I102922a859e155713908ddcb8c285cd14e853752 Reviewed-on: https://chromium-review.googlesource.com/1147946Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577518}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/e507b0ce8e87..903bd4145f5a git log e507b0ce8e87..903bd4145f5a --date=short --no-merges --format='%ad %ae %s' 2018-07-24 sakal@webrtc.org Move VideoCapturer to video_api and cleanup. 2018-07-24 nisse@webrtc.org New api function CreateVideoStreamEncoder. Created with: gclient setdep -r src/third_party/webrtc@903bd4145f5a The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ie203022d04db5224ddff0dcf0be6b3324f626995 Reviewed-on: https://chromium-review.googlesource.com/1147904Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577517}
-
Jérôme Lebel authored
To validate the signin consent, the consent scroll view has to be scrolled down to the bottom. Unfortunately, when a scroll view doesn't bounce, grey_scrollToContentEdge() scrolls without stopping. To workaround the problem and keep -UIScrollView.alwaysBounceVertical set to NO, a matcher is used to test if content is smaller than the scroll view. If the content is smaller, than the consent is validated directly. Otherwise, the view is scrolled down to the bottom, before validating the consent. Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I5a982cefd38c755be3993cd27b619b8f400efdb6 Reviewed-on: https://chromium-review.googlesource.com/1147520 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#577516}
-
Dominik Inführ authored
Code failed when snapshot was not taken from the running application but loaded from file. heapProfilerModel() returns null if snapshot was loaded from file. Bug: chromium:854097 Change-Id: I3c269a78f7f8ec59a15f510dda6ab55a72f53616 Reviewed-on: https://chromium-review.googlesource.com/1146921 Commit-Queue: Dominik Inführ <dinfuehr@google.com> Reviewed-by:
Alexei Filippov <alph@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#577515}
-
Elly Fong-Jones authored
This piece of Cocoa secondary UI has been obsolete for several releases now and its tests are broken in MacViews mode. Bug: 832676 Change-Id: I2cf1fa087f29a288005913424396fc399eabf210 Reviewed-on: https://chromium-review.googlesource.com/1148012Reviewed-by:
-
Gauthier Ambard authored
This CL creates the architecture of the ConsentBump for the new sign in. Bug: 866506 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I02fd7b3f2612f9c9510f111199100ca3e88b85fb Reviewed-on: https://chromium-review.googlesource.com/1148320Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#577513}
-
Mike Frysinger authored
Newer pylint warns when files have trailing blank lines. Trim them. Bug: 866772 Change-Id: Iacfd1dcb0eb16d33aa5cf382aecb5b1dd4e7efa7 Reviewed-on: https://chromium-review.googlesource.com/1147717 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Moe Ahmadi authored
UKM EG tests were failing on iOS because the signed in account was staying around after signing out causing EG selector to fail to tap on the appropriate account in subsequent sign in attempts. This CL fixes that by removing the signed in account when signing out. Bug: 853992 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I77ec271bbb694766b6487be52ec4e3a18f7839d4 Reviewed-on: https://chromium-review.googlesource.com/1146986Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#577511}
-
David 'Digit' Turner authored
This CL contains fixes required to ensure that the presubmit upload script does not fail after the Pylint update to 1.5. More specifically: - The pylintrc is modified to add wrong-order-position to the list of disabled warnings, since many of the scripts under build/android require sophisticated import logic due to the use of third_party/catapult/devil/ - Otherwise, scripts are locally updated by either changing the source code, or adding local pylint comments to disable a specific warning. Without this CL, no Android-specific CL can pass the presubmit test on Gerrit :-/ BUG=NONE R=jbudorick@chromium.org, agrieve@chromium.org, vapier@chromium.org Change-Id: I4812c76bf1b86918d56c230574c741c3c1328c5d Reviewed-on: https://chromium-review.googlesource.com/1148339Reviewed-by:
-
Alexander Timin authored
Add PostOnBackgrondThreadWithTraits to the blink's wrapper around TaskScheduler and add relevant traits to the presubmit whitelist. We want to allow Blink code to post background tasks with correct traits but we still need a wrapper to ensure that CrossThreadBind is used instead of base::Bind. R=haraken@chromium.org CC=leszeks@chromium.org Change-Id: If5297e1214bb175dee1247754158511811963b55 Reviewed-on: https://chromium-review.googlesource.com/1146658Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#577509}
-
Vadym Doroshenko authored
On CL https://chromium-review.googlesource.com/c/chromium/src/+/1016648 it was added flag for new Password Form parsing in general. But since now it's used for launching in M-69 filling with the new parsing, another flag for saving is required for development (and launching it later). This CL adds it. Bug: 831123 Change-Id: Ic475da832d041d464f870ff96bd3b3bc76f838c1 Reviewed-on: https://chromium-review.googlesource.com/1148202 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ee5a26d974be..3bf99f3a4746 git log ee5a26d974be..3bf99f3a4746 --date=short --no-merges --format='%ad %ae %s' 2018-07-24 primiano@google.com trace_processor: extract Table and Table::Cursor classes and cleanup Created with: gclient setdep -r src/third_party/perfetto@3bf99f3a4746 The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:80416541 TBR=perfetto-bugs@google.com Change-Id: I66bc914d3ccd0ae8b2c71f9b511bef8ec9d79eb0 Reviewed-on: https://chromium-review.googlesource.com/1147947 Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577507}
-
Derek Cheng authored
Add utility class that handles messages between a Cast SDK client and the Cast MRP ("internal messages"). The types of internal messages are: - new session (mrp -> client) - receiver action (mrp -> client) - client connect (client -> mrp) - app message (client <-> mrp) In particular, client connect should be going away soon (with the use of PresentationConnection in MRP). app message is bi-directional between the client and the receiver device, where MRP acts as a pass through. Also added a utility method to generate a stop session cast channel message for a given receiver device and session id. Bug: 809249 Change-Id: I62169dd5b163060464cc6d389c8d93fc4bb2425f Reviewed-on: https://chromium-review.googlesource.com/1085768Reviewed-by:Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Brandon Tolsch <btolsch@chromium.org> Commit-Queue: Derek Cheng <imcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#577506}
-
Douglas Creager authored
WPT provides a "nonexistent" subdomain that it guarantees will never resolve to any IP address [1]. Our test harness doesn't rely on /etc/hosts to resolve these test domains, and uses rewrite rules internally instead. Those rewrite rules were blindly resolving all *.test domains to 127.0.0.1; this patch adds an additional rule that handles the nonexistent subdomain correctly. [1] https://web-platform-tests.org/writing-tests/server-features.html#tests-involving-multiple-origins Bug: 866003 Change-Id: I4e331490d56872b8dfc4db25973291ea6e099565 Reviewed-on: https://chromium-review.googlesource.com/1145487 Commit-Queue: Douglas Creager <dcreager@chromium.org> Reviewed-by:
-
Stefan Teodorescu authored
Add Chrome desktop style RelaunchNotification to ChromeOS version of Chrome, including the RelaunchNotificationController written for Chrome desktop. This shows the bubble for the recommended relaunch and the dialog for the required relaunch. Bug: 846425 Change-Id: I4aea7907d2f7a591e4e845597a7ece3d943722ca Reviewed-on: https://chromium-review.googlesource.com/1146654Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Marton Hunyady <hunyadym@chromium.org> Commit-Queue: Stefan Teodorescu <fane@google.com> Cr-Commit-Position: refs/heads/master@{#577504}
-
