- 17 Oct, 2018 40 commits
-
-
Tarun Bansal authored
In Network Quality Estimator (NQE), remove the logic to compute BDP (bandwidth delay product) since this is not being used anymore. Change-Id: Ic61c0491d85eadd9a922ecdbfaa016e1e20ace9f Bug: 895878 Reviewed-on: https://chromium-review.googlesource.com/c/1279436Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#600523}
-
agrieve authored
Change-Id: Icafce9c1651fc590cb21020b41e0d59f8ea0eba3 Reviewed-on: https://chromium-review.googlesource.com/c/1203392 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#600522}
-
Marina Ciocea authored
Sandbox is supported in InProcessBrowserTests since https://crrev.com/87bf974e05e6d0f9dcc28f3c51cf46fd4b9a3145. Change-Id: I7775488ec4d9a529455eed20de9e3a2ec4f667c3 Reviewed-on: https://chromium-review.googlesource.com/c/1286662Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#600521}
-
Dave Tapuska authored
BUG=242216 Change-Id: Iea525e5c1091aa85193b23edbedead8bf997ab05 Reviewed-on: https://chromium-review.googlesource.com/c/1286907Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#600520}
-
Emircan Uysaler authored
Update to the spec suggests that we now enable certain constraints in getDisplayMedia() call. This CL will allow them from higher level and update wpt tests. Note that actual application of constraints will follow in the next CLs. Bug: 326740 Change-Id: I1f0b3c9b7a2feab7b17ee79c8c2420d9ced7fda8 Reviewed-on: https://chromium-review.googlesource.com/c/1284733Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#600519}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/2eee64982a09..451dc721b571 git log 2eee64982a09..451dc721b571 --date=short --no-merges --format='%ad %ae %s' 2018-10-17 lannm@chromium.org chromeos_config: Disable Tast VM tests on paladins. Created with: gclient setdep -r src/third_party/chromite@451dc721b571 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ib2ad94ceffb5c01617b69769b9b6abce6bffef61 Reviewed-on: https://chromium-review.googlesource.com/c/1286115Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#600518}
-
Becca Hughes authored
Add the flag for media session media key handling in ash to chrome://flags. BUG=894255 Change-Id: I7bdeea6312629d284e7d7ec6441a1d6948063ccf Reviewed-on: https://chromium-review.googlesource.com/c/1286972Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#600517}
-
Stephen Chenney authored
This reverts commit b942c118. Reason for revert: The patch caused all of our ratio metrics to disappear on the UMA dashboard. The metrics are being sent, but I suspect the sample count is too low for reporting. Also, it didn't fix the perf regression. Original change's description: > Record MainFrame ratio UMA only every 30 seconds > > Mobile performance regressed when UMA and UKM metrics for the > Rendering Core team were added to BeginMainFrame. We hypothesize > that the primary cost is recording UMA on every frame for the > new metrics, so this patch switches to recording UMA only every 30 > seconds, or on frame destruction, when the UKM metrics are recorded. > > The plan is to monitor performance graphs to determine if this has the > desired effect. > > For the ForcedLayout metric we may need to send the primary UMA metric > only once per frame, not once per forced layout as is done now. That is > a follow on patch. > > R=vmpstr@chromium.org > BUG=890871,891003,891341 > > Change-Id: I2f4ec8bb9301cece98aef52463d671e4bebcd91e > Reviewed-on: https://chromium-review.googlesource.com/c/1260443 > Reviewed-by: Steven Holte <holte@chromium.org> > Reviewed-by: vmpstr <vmpstr@chromium.org> > Commit-Queue: Stephen Chenney <schenney@chromium.org> > Cr-Commit-Position: refs/heads/master@{#597113} TBR=vmpstr@chromium.org,rkaplow@chromium.org,holte@chromium.org,schenney@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 890871, 891003, 891341 Change-Id: I4668b91a1cc7080d65ba722a2168652cd5b89416 Reviewed-on: https://chromium-review.googlesource.com/c/1286735 Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#600516}
-
Joe Mason authored
R=proberge Change-Id: I0c5b4ba69c8a39f3336989fee5bddc700da48aa0 Reviewed-on: https://chromium-review.googlesource.com/c/1286282Reviewed-by:
proberge <proberge@chromium.org> Commit-Queue: Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#600515}
-
Henrik Grunell authored
Bug: 889494 Change-Id: I4e2a36f2ca7e93db9b5bacb6a32a64abf9ae812c Reviewed-on: https://chromium-review.googlesource.com/c/1282929Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#600514}
-
Paul Jensen authored
r600401 moved use of the FeatureList to an earlier point that was after Cronet was initilizing the FeatureList which caused a CHECK failure. Move the FeatureList initialization earlier so it happens first. Bug: 896315 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester Change-Id: I7a10d09e71382995d79af2ee001e77ac9614b8b4 Reviewed-on: https://chromium-review.googlesource.com/c/1286742Reviewed-by:
Misha Efimov <mef@chromium.org> Commit-Queue: Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#600513}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/fab9129e9427..09beff2cfd84 git log fab9129e9427..09beff2cfd84 --date=short --no-merges --format='%ad %ae %s' 2018-10-17 Peter) Slatala Add UseMediaTransport RTCConfiguration support in Java class 2018-10-17 srte@webrtc.org Removes undefined declarations in channel.h. 2018-10-17 kwiberg@webrtc.org rtc::Buffer: Handle move self-assignment 2018-10-17 nisse@webrtc.org Delete more rtc_base/stringutils.* Created with: gclient setdep -r src/third_party/webrtc@09beff2cfd84 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I8d1e0dc475b3a17a9ed9e7e07877d6b10eaddc97 Reviewed-on: https://chromium-review.googlesource.com/c/1286630Reviewed-by:
-
Dmitry Gozman authored
Geometry seems like a good home for Length, LengthPoint, LengthSize and LengthBox. This brings more sanity to the structure of blink/renderer/platform. Bug: none Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: If74d1efb789d8d47c3b5b7c4afa25ec989e0e53d Reviewed-on: https://chromium-review.googlesource.com/c/1285115Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
-
Nicolas Capens authored
BUG=chromium:881334 Change-Id: I1d6273ee84f263b738d229562eaf7cfd98ca203a Reviewed-on: https://chromium-review.googlesource.com/c/1286909Reviewed-by:
Alexis Hétu <sugoi@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Nicolas Capens <capn@chromium.org> Cr-Commit-Position: refs/heads/master@{#600510}
-
Sahel Sharify authored
The tests were initially landed in the following cl: https://chromium-review.googlesource.com/c/chromium/src/+/1278963 The logic of the cl is re-landed in a separate cl(r599781) to give it more time to bake. This cl re-lands the browser tests after applying the following changes: 1- Addressed renaming nit. 2- Used MainThreadFrameObserver to make sure that compositor is synced after scrolling on main thread. Bug: 894703 Change-Id: I25d6dbf7f216bbedecb6673d6c2819dcd1d82d55 Reviewed-on: https://chromium-review.googlesource.com/c/1286875Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Kevin McNee <mcnee@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#600509}
-
Kristi Park authored
Classes with only static functions are not allowed as per the style guide (https://google.github.io/styleguide/cppguide.html#Nonmember,_Static_Member,_and_Global_Functions). Instead, InstantService will own the single UrlValidityChecker instance. Bug: 874194 Change-Id: Ia4fa35abfdfde3e0d64b268c11c9b7a82fedc126 Reviewed-on: https://chromium-review.googlesource.com/c/1283947 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#600508}
-
Tommy Nyquist authored
This reverts commit 5423fd8a. Reason for revert: Breaks Chrome Custom Tabs. Original change's description: > Update UI for unsupported Android OS and make Jelly Bean unsupported. > > This CL updates the UI to show a badge icon in the app menu icon > whenever the user is running Chrome on a currently unsupported Android > version. This badge in the app menu is only displayed once, until the > user taps the app menu icon. If the user does in fact get a new version, > the badge state is reset, and will be shown again. The current behavior > for out of date users stays the same as before (once per cold start). > > In addition, a new menu item is displayed at the top of the menu that > explains that Chrome is unable to update. Nothing happens when you tap > the menu item in the case of an unsupported OS version. > > The new menu item and the new warning message in About Chrome will > always be displayed when the user is in this state, regardless of > whether the app menu has already been tapped (which removes the badge). > > This CL also updates the UI in Settings - About Chrome to show a new > message and a warning icon when the user is running Chrome on an > unsupported version of the Android OS. > > By default, Jelly Bean is considered unsupported after this CL, but this > can be overridden from the variations framework. > > It is possible to use command line flags or chrome://flags for > testing the different states, though that does not impact the > About Chrome screen. > > Binary-Size: This CL adds new assets and the minimal code required. > Bug: 847940 > Change-Id: If128e1692b66c5804928183718000aaf1e2ffaa6 > Reviewed-on: https://chromium-review.googlesource.com/c/1243167 > Commit-Queue: Tommy Nyquist <nyquist@chromium.org> > Reviewed-by: Theresa <twellington@chromium.org> > Cr-Commit-Position: refs/heads/master@{#599369} TBR=nyquist@chromium.org,dtrainor@chromium.org,twellington@chromium.org,mdjones@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 847940 Change-Id: Ifde69d6fe007bf0ace6f1f2517db9c1b07526798 Reviewed-on: https://chromium-review.googlesource.com/c/1286973 Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#600507}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/a358d622339d..785a26dc649a git log a358d622339d..785a26dc649a --date=short --no-merges --format='%ad %ae %s' 2018-10-17 tikuta@google.com Do not do null pointer arithmetic 2018-10-17 thestig@chromium.org Fix typo in coverage_report.py. 2018-10-17 thestig@chromium.org Fix the static initialization order problem for PartitionAlloc. Created with: gclient setdep -r src/third_party/pdfium@785a26dc649a The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:766891,chromium:896117 TBR=dsinclair@chromium.org Change-Id: Idbbb57b832cfcdef43607893a607abbce9f23ee6 Reviewed-on: https://chromium-review.googlesource.com/c/1286750Reviewed-by:
-
John Budorick authored
This reverts commit afe32c4a. Reason for revert: possible recipe issue in the required CL. Original change's description: > Build chrome_apk on the chromium.perf android builders. > > Requires crrev.com/c/1283629 > > Bug: 817842 > Change-Id: I9bda31e2b98d58cb514e1ba79c0d4a5457a566a2 > Reviewed-on: https://chromium-review.googlesource.com/c/1284752 > Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org> > Reviewed-by: Ned Nguyen <nednguyen@google.com> > Commit-Queue: John Budorick <jbudorick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#600499} TBR=perezju@chromium.org,nednguyen@google.com,jbudorick@chromium.org Change-Id: Icc7f3e46f51c7446690dfcf6940c8bf6a12d2083 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 817842 Reviewed-on: https://chromium-review.googlesource.com/c/1287038Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#600505}
-
Patrick Noland authored
Bug: 891419 Change-Id: I14bff26807974fe6367ef4873d82563f2ffe3dc4 Reviewed-on: https://chromium-review.googlesource.com/c/1274902 Commit-Queue: Patrick Noland <pnoland@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#600504}
-
Vaclav Brozek authored
The fuzzer was able to exercise the codepath causing the crash from the associated bug report (causing an out-of-range error in std::basic_string due to length computed incorrectly because of an error in Unicode handling). Bug: 895578 Change-Id: Icbef8120c18c89227ba7a94c410ec58948d13ae6 Reviewed-on: https://chromium-review.googlesource.com/c/1286453 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#600503}
-
Saman Sami authored
Make EvictSurfaces take the primary surface instead of the last active surface. Any surface that activates in Viz that is older than the primary will get evicted. Bug: 893731 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Ibfaed7f4ddfaf73f502c79e4cdf753ec237ea588 Reviewed-on: https://chromium-review.googlesource.com/c/1277826 Commit-Queue: Saman Sami <samans@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
-
Jochen Eisinger authored
This reverts commit 44256192. Reason for revert: still need to handle the case where an existing profile is locked BUG=896136 Original change's description: > Add a CHECK to non-DICE signin that it's only used for force-signin > > All other use cases are meanwhile migrated or disabled > > R=msarda@chromium.org > > Change-Id: Ieff03c3a46a9ef8fec5c9de8a1aa041a97d9afbf > Reviewed-on: https://chromium-review.googlesource.com/1148211 > Reviewed-by: Mihai Sardarescu <msarda@chromium.org> > Commit-Queue: Jochen Eisinger <jochen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#577827} TBR=msarda@chromium.org,jochen@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I3b7c538682784f57f5142c43ff4bd6c78c14685b Reviewed-on: https://chromium-review.googlesource.com/c/1286278 Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#600501}
-
Toni Barzic authored
These are not used anymore (the verification is separately implemented in Chrome). BUG=846971 Change-Id: Id96f59850f2e56aeb766c34433b5c8a86a72cf4a Reviewed-on: https://chromium-review.googlesource.com/c/1283484Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#600500}
-
John Budorick authored
Requires crrev.com/c/1283629 Bug: 817842 Change-Id: I9bda31e2b98d58cb514e1ba79c0d4a5457a566a2 Reviewed-on: https://chromium-review.googlesource.com/c/1284752Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#600499}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f20c3493eb57..e92aae6b3612 git log f20c3493eb57..e92aae6b3612 --date=short --no-merges --format='%ad %ae %s' 2018-10-17 reed@google.com make legacy shadercontext optional 2018-10-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 1d8a783c9db2..c20ead32ad6d (2 commits) 2018-10-17 khushalsagar@chromium.org fonts: Cache serialized typeface wire data for remote fonts. 2018-10-17 herb@google.com Fix logic error for GrTextBlob mustRegen 2018-10-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms fa2161cf791f..c851ac96663d (4 commits) 2018-10-17 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset Created with: gclient setdep -r src/third_party/skia@e92aae6b3612 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel BUG=chromium:894200 TBR=egdaniel@chromium.org Change-Id: I03baf792befb769de37ac16efc3537325c358819 Reviewed-on: https://chromium-review.googlesource.com/c/1286112Reviewed-by:
-
Scott Graham authored
Now supporting defining and passing structs from JS -> C++. Bug: 883496 Change-Id: Ib1baf5d435f9e936393e31871f12e71f6ed79f33 Reviewed-on: https://chromium-review.googlesource.com/c/1244891 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#600497}
-
Katie Dillon authored
Added perf tests for worker that measures encoding data with TextEncoder and sending it to a worker as a transferable. Change-Id: I8cf825fda79d596dee0a3a1ce6bdc692b4529552 Reviewed-on: https://chromium-review.googlesource.com/c/1282106Reviewed-by:
Shubhie Panicker <panicker@chromium.org> Reviewed-by:
-
Fady Samuel authored
This metric wasn't really providing a useful signal for anything. Bug: 672962 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Ia4c5086f1d9705277455c149e1c8138b3a3085b3 Reviewed-on: https://chromium-review.googlesource.com/c/1286899Reviewed-by:
Saman Sami <samans@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#600495}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/383ad4fa29d6..51b2312390d4 git log 383ad4fa29d6..51b2312390d4 --date=short --no-merges --format='%ad %ae %s' 2018-10-17 lalitm@google.com Merge "trace_processor: fix failing diff test and start running on travis" 2018-10-17 hjd@google.com Merge "perfetto-ui: Fix adding tracks" 2018-10-17 fmayer@google.com Merge "profiling: Do not crash client for server problems." Created with: gclient setdep -r src/third_party/perfetto@51b2312390d4 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Id34e070448b8d6fa3b9d1f3fbbbb60406f5a185d Reviewed-on: https://chromium-review.googlesource.com/c/1286111Reviewed-by:
-
Tarun Bansal authored
Resource Scheduler: Add UMA to record request queuing time broken down by request loading priority Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I120b9f0b549c76d1f36920c051014afe71462db2 Bug: 895486 Reviewed-on: https://chromium-review.googlesource.com/c/1280145Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#600493}
-
Daniel Bratell authored
In February a number of obsolete header files were deleted but some of them were still listed in sources lists. That might have caused isolate step errors in trybots. Bug: 778580 Change-Id: Ica026a5d157c64f07465f520a15ed2ffab92c234 Reviewed-on: https://chromium-review.googlesource.com/c/1286428Reviewed-by:
-
Ken Rockot authored
The CL https://chromium-review.googlesource.com/c/chromium/src/+/1145692 changes Mojo dispatch behavior and ends up breaking this test. The test is making invalid assumptions about when an InterfacePtr can expect encountered_error() to return true. This CL fixes the test be ensuring that it explicitly waits for an error to be raised on the clipboard interface before continuing. Bug: 895693 Change-Id: I17ea7f994ea9c7d672d0f200aeeaa2c404e04f3f Reviewed-on: https://chromium-review.googlesource.com/c/1286203Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#600491}
-
Jared Saul authored
(When a card accrues 3 strikes, future offers to save for that card should show the omnibox save icon, but NOT pop up the bubble. On Android, no offer to save is shown at all.) Bug: 884817 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I0d6ad27a4e03d0128970af6e22d2a40a62d0601b Reviewed-on: https://chromium-review.googlesource.com/c/1269524 Commit-Queue: Jared Saul <jsaul@google.com> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#600490}
-
Jamie Madill authored
GpuCrash_GPUProcessCrashesExactlyOncePerVisitToAboutGpuCrash This test was so flaky it was failing on the ANGLE CQ. Also affects Intel and possibly AMD. Tbr: kbr@chromium.org Bug: 878258 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I74685596e4162d1d8244ac48f60fcbd12319159d Reviewed-on: https://chromium-review.googlesource.com/c/1286892Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#600489}
-
Becca Hughes authored
If the "MediaSessionAccelerators" feature is enabled then media keys should behave as system keys. This means they will be handled in ash unless a Chrome app is overridding the behaviour. BUG=894255 Change-Id: I00d8c5a0d8e2c9f73531408f30ddeb56424ad03e Reviewed-on: https://chromium-review.googlesource.com/c/1274885 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#600488}
-
David Trainor authored
In order to properly test download home V2 from a Coordinator standpoint, we need to support building/passing in the following parameters: - Whether or not to use the legacy download path (which queries DownloadManagerService/native code that we don't want). - Whether or not to use the legacy download thumbnail path (which queries disk/native code that we don't want). - Letting tests mock out the OfflineContentProvider for a Profile. Getting rid of the legacy code path for these tests is okay because production code will soon do the same once the old code path is fully deprecated. Change-Id: I59784bc53c76b22a81fe6c4f7d43ec43ff7da298 Reviewed-on: https://chromium-review.googlesource.com/c/1277915Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#600487}
-
Philip Rogers authored
This patch makes the renderer's compositor use blink runtime feature flags to initialize the layer list setting. With this change we no longer need to separately plumb both a blink feature (i.e., BGPT or SPV2) and a layer list setting. This prevents the confusion situation of having the blink feature flags not match the compositor's layer list setting. This also simplifies the release of Blink Generated Property Trees because we can use the existing processes for transitioning a blink feature from test to experimental to stable. The primary code change is to remove the --enable-layer-lists flag and instead have render_widget.cc initialize the use_layer_lists setting from blink feature flags. This patch also cleans up some plumbing for the --enable-slimming-paint-v2 flag and adds TODOs to remove both --enable-slimming-paint-v2 and --enable-blink-gen-property-trees. Bug: 836884 Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Iffdefc896abb00e6692a0d77b4fde5f628cb8ff5 Reviewed-on: https://chromium-review.googlesource.com/c/1278988Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#600486}
-
Clark DuVall authored
This is in preparation for running Network Service out of process. The Network Service process will initially run as a privileged process, so we need to make sure there are enough services to handle the extra process. Bug: 872343 Change-Id: I208c9385a9d48471b2b4ae0b0b23764c18388abc Merge-With: eureka-internal/210477 Reviewed-on: https://chromium-review.googlesource.com/c/1282122Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Simeon Anfinrud <sanfin@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#600485}
-
Hans Wennborg authored
And update references to FileIOClient::Status, because it's now an enum class. Bug: 895475 Change-Id: I1e0e9646416a969e87a9d34dd24b31dc0017889e Reviewed-on: https://chromium-review.googlesource.com/c/1283370Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#600484}
-
