- 28 Feb, 2018 40 commits
-
-
Chromium WPT Sync authored
Using wpt-import in Chromium e7d579a8. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/13005 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kojii@chromium.org: external/wpt/css/css-text/line-break TBR=kereliuk No-Export: true Change-Id: I04ebc58e38a8649bf783f3fc6e7f90fde3b51508 Reviewed-on: https://chromium-review.googlesource.com/940486 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#539788}
-
tzik authored
Tbr: jennyz@chromium.org Change-Id: Iac44f0b08ffef83322e9811fe4bc65cab11ce1c1 Reviewed-on: https://chromium-review.googlesource.com/940706 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#539787}
-
Michael Lippautz authored
Instead just forward to the Trace method of this visitor which will call ListHashSetNode::Trace after marking the node. Bug: chromium:802273 Change-Id: Ic13090edead2e26c94ce0f0157e3d3f6d1effcb3 Reviewed-on: https://chromium-review.googlesource.com/939823 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#539786}
-
Risan authored
This change add a method to request Chrome to send all existing mount points. This method is called everytime vold is reseting. Bug: 64500663 Change-Id: If10577a3d40ebd240a2ad242f703a28ecd3c363e Reviewed-on: https://chromium-review.googlesource.com/938683 Commit-Queue: Risan <risan@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Cr-Commit-Position: refs/heads/master@{#539785}
-
Colin Blundell authored
There are no obvious recent changes to have turned this test flaky. The best hypothesis that I have is that something in the changes in https://codereview.chromium.org/2939943004 was problematic, although in that case it's unclear why it would only start turning up now. TBR=asvitkine@chromium.org Bug: 817172 Change-Id: Ic0665e7d8d606b5ecb01d11f641bcfe2ec82a1ab Reviewed-on: https://chromium-review.googlesource.com/941121Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#539784}
-
Darren Shen authored
ComputedStylePropertyMap should return computed values. For 'transform', that's "as specified, but relative lengths converted to absolute" [1]. This means we need to return the individual transform components like 'translate3d'. Currently there's no code to do this, so we have to roll our own. [1] https://drafts.csswg.org/css-transforms-1/#propdef-transform Bug: 816803 Change-Id: I64305512fa0d0ce32ba86ea2b14595b551ff1c8d Reviewed-on: https://chromium-review.googlesource.com/938885Reviewed-by:
-
Vaclav Brozek authored
So far, SavePasswordsPreferences always assumed that onResume is only called after Chrome is killed. However, it can also be called when it is just paused. In that case, and if the export warning is shown, onResume should not cause another export warning dialog to pop up. Also, if Chrome is resumed after a long time, the reauthentication for exporting should not be conisdered valid any more. Therefore, this CL adds a member variable keeping a reference to the export warning dialog inside SavePasswordsPreferences. During onResume, it uses the variable to dismiss the dialog if the reauthentication is no longer valid. The CL also makes SavePasswordsPreferences skip creating the warning dialog in case it already exists and is functional. (Note: if Chrome is resumed after being killed, the warning dialog will be re-created by Android, but not functional. In that case it dismisses itself and SavePasswordsPreferences need to re-create it properly. This is not changed in this CL.) Bug: 815156 Change-Id: I5e6372cbde1e7e5d1e333fd06206f99618907eb6 Reviewed-on: https://chromium-review.googlesource.com/939471 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#539782}
-
Ivan Afanasyev authored
This is a reland of ccaa8bf9. Original change's description: > Fix wrong password saving when loging to facebook. > > Facebook.com may perform |SameDocumentNavigation| on login form submit. > User password will be saved even if it is wrong. > > The changeset disables trigger on action changes. > > Change-Id: I4103661fb9649280862229248f329da23dcc8912 > Bug: 808917 > Reviewed-on: https://chromium-review.googlesource.com/897638 > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > Reviewed-by: Dominic Battré <battre@chromium.org> > Commit-Queue: Иван Афанасьев <ivafanas@yandex-team.ru> > Cr-Commit-Position: refs/heads/master@{#539110} Bug: 808917 Change-Id: I098cde3361288d60d083649f25ceec8265140f7a Reviewed-on: https://chromium-review.googlesource.com/940122Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Иван Афанасьев <ivafanas@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#539781}
-
Manuel Rego Casasnovas authored
"ahem" is causing flakiness on Windows, so this patch just replaces "ahem" by "Ahem" on WPT tests. BUG=724392,794136 Change-Id: I55ce2ee7ed36b2708da571f52256716e97a072cb Reviewed-on: https://chromium-review.googlesource.com/940921Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#539780}
-
Christos Froussios authored
The export progress UI offers a cancellation action. Cancelling should stop writing to the disk and undo any content which was already written. This CL introduces the chrome.passwordsPrivate function cancelExportPasswords() which forwards the user's request to cancel to the browser. The API proposal for the export functions of passwordsPrivate is https://docs.google.com/document/d/1WtsbdTnWpZUMlL6q9mqdO_bY8QZi-JSrJV9RkZysNpQ/edit# I have updated it with the cancel function. Bug: 811779 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I095af1029bdda7dc45e8623b77acad4464e80310 Reviewed-on: https://chromium-review.googlesource.com/924058 Commit-Queue: Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#539779}
-
Chandan Padhi authored
This CL ensures that MediaStreamTrack.getCapabilities() does not have range properties if they don't have a valid range. Bug: 293292 Change-Id: I6f85086fb4af7e17faca069f76299a0256f1872d Reviewed-on: https://chromium-review.googlesource.com/938983 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#539778}
-
Ioana Pandele authored
This CL adds the following metrics: - PasswordManager.ExportPasswordsToCSVResult - PasswordManager.TimeReadingExportedPasswords Metrics still to be added in following CLs: - PasswordManager.ExportedPasswordsPerUserInCSV Bug: 789122 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I5e92c93f07888e0e3fc7c7468de5543755e6834d Reviewed-on: https://chromium-review.googlesource.com/912131 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Kent Tamura authored
HTMLFormControlElement::UpdateAncestorDisabledState() checked if the highest <legend> is the first <legend> child of the highest disabled <fieldset>. It should check <lengend> child of every disabled fieldset ancestors. Bug: 817181 Change-Id: I8f7dedd8089757d9eae726de359b0efe47cf9f44 Reviewed-on: https://chromium-review.googlesource.com/940644Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#539776}
-
Fredrik Söderquist authored
Cleanup some (now) unnecessary explicit 'this' dereferences as well. Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I49238bf7b32760e5a05f6b6ce41557d34423ea45 Reviewed-on: https://chromium-review.googlesource.com/931508Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#539775}
-
Naoki Fukino authored
Android apps are closed by BrowserBack key on Chrome OS. To make the built-in app's behavior consistent and keep the app alive, we minimize the app window on BrowserBack. Bug: 807521 Test: Manually tested Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ib4883b75791721baf1b2ff814d4e5047a0dfe726 Reviewed-on: https://chromium-review.googlesource.com/940743Reviewed-by:
Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Commit-Queue: Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#539774}
-
chrome://newtab/#open_tabsMarc Treib authored
The NTP hasn't had an "open tabs" page in years. Time to get rid of this. TBRing trivial test-only changes in app_menu_controller_unittest.mm and recent_tabs_sub_menu_model_unittest.cc. TBR=ellyjones@chromium.org Bug: none Change-Id: Ib4d901ef6cfe67ab546016cc09dfcc2d9673572c Reviewed-on: https://chromium-review.googlesource.com/939395 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#539773}
-
tzik authored
base::Bind used to fail if a raw pointer to a non-ref-counted object is passed as a receiver. Though that is an expected failure, its error was hard to read. This CL adds a static_assert for the failing case for better error message. Change-Id: I7057fbfaa0c24530f3b9e28b4362f4b8637cd1be Reviewed-on: https://chromium-review.googlesource.com/923661 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#539772}
-
David Tseng authored
- any node with the editable boolean property should automatically be considered a text field - ChromeVox expects to see |url| on a root automation node - clarify what gets used as an accessible name - give each ax tree source an id Change-Id: I073808c797da55f9b54c3732cc8bb7a22da6a7c6 Reviewed-on: https://chromium-review.googlesource.com/936429Reviewed-by:
Yuki Awano <yawano@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#539771}
-
Colin Blundell authored
After recent refactorings, //components/autofill no longer uses //components/signin. This CL rips out dead includes, APIs, and dependencies. TBR=jam@chromium.org Bug: 809435, 809927 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: If5289bd88003f9e58f1ce404870fd47b0fffa2e3 Reviewed-on: https://chromium-review.googlesource.com/916197 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#539770}
-
Harald Alvestrand authored
This makes the "dtmf" attribute of RTCRtpSender link directly to the sender-based DTMF sender in the WebRTC layer, without going through the track. Bug: 814214 Change-Id: I5b04a64a7e9105ef4a8ed5e826eb812ea43ea8ac Reviewed-on: https://chromium-review.googlesource.com/936765Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#539769}
-
https://chromium.googlesource.com/angle/angle.git/+log/640fa5dc3f95..2f3a0dc5cbc2 $ git log 640fa5dc3..2f3a0dc5c --date=short --no-merges --format='%ad %ae %s' 2018-02-27 yunchao.he Report INVALID_VALUE if width/height of invalidateSubFramebuffer is negative. 2018-01-28 fjhenigman Vulkan: use correct vertex stride. Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: Ic0ff3ef53cc68f84b7700721927da6c1826edc5b Reviewed-on: https://chromium-review.googlesource.com/940817Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#539768}
-
Takashi Toyoshima authored
Today, the Service Worker spec explicitly defines that requests from all plugins should not be handled by Service Workers, and actually Blink and Pepper set |skip_service_worker| to true, that means |skip_service_worker| is always true for |kRequestContextPlugin|. So, now we can simply remove |skip_service_worker| argument from IsNoCORSAllowedContext, and return always true for |kRequestContextPlugin|. Bug: 803766 Change-Id: I1a421895190bd981439ad0eb02fdc776c9a77c10 Reviewed-on: https://chromium-review.googlesource.com/930611Reviewed-by:
Takeshi Yoshino <tyoshino@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#539767}
-
Takashi Toyoshima authored
This patch modifies PreflightCache to provide two separate methods to count cached origins and entries for better testing. This change allows me to remove many comments that are not necessary for readable code. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I04dc60034f705847e93d27d63ad1cb9fc3a70e97 Reviewed-on: https://chromium-review.googlesource.com/936824 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
-
Zhuoyu Qian authored
Move FirstRectForRange() to VisibleUnits, make |Editor| class simpler for improving code health. BUG=672405 Signed-off-by:
Zhuoyu Qian <zhuoyu.qian@samsung.com> Change-Id: Iaca3148ba5a6f186a7870ede3ef59e0ddf4078bd Reviewed-on: https://chromium-review.googlesource.com/938888Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#539765}
-
Gauthier Ambard authored
This CL updates the bottom padding of the WebView to reflect the toolbar presence at the bottom of the screen. It allows the WebView to resize such as its frame is only the visible portion of the page. Its frame is updated to follow the updates of the toolbar during fullscreen, in the same way as it is done for the top toolbar. Bug: 812232 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ib52f47664399d23857115a4b1c01961803d038af Reviewed-on: https://chromium-review.googlesource.com/931466 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#539764}
-
Victor Costan authored
https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/7a2563a51456..7d15497f7538 This is a reland of https://crrev.com/c/900544 which was reverted because it broke net_unittests on Windows Debug builds https://crbug.com/810347. The reland bumps Google Test past https://github.com/google/googletest/pull/1450 which contains a fix for the net_unittest breakage. $ git log 7a2563a51..7d15497f7 --date=short --no-merges --format='%ad %ae %s' 2018-02-23 pwnall Switch default death test style back to "fast". 2018-02-26 misterg merging unittests - 5 2018-02-23 misterg merging unitests - check 4 2018-02-23 misterg merging unitests, check 2018-02-23 misterg merging unittests - 2 2018-02-23 misterg merging unitests 2018-02-23 anders.sundman Removed trailing comma in enum 2018-02-23 cirnotoss TEST() arguments are invalid in an example 2018-02-22 misterg merges 2018-02-19 costan Fix unused function warning on Mac OS. 2018-02-13 misterg cleanup, merges 2018-02-13 misterg cleanup/merges 2018-02-13 misterg merging, cleaning up 2018-02-13 misterg merges 2018-02-13 misterg cxxx11 2018-02-13 misterg clang warnings 2018-02-13 misterg clang warnings 2018-02-13 misterg https://travis-ci.org/google/googletest/jobs/340995238 2018-02-13 misterg clang warning 'https://travis-ci.org/google/googletest/jobs/340987201' 2018-02-13 misterg clang warning https://travis-ci.org/google/googletest/jobs/340978022 2018-02-13 misterg merges 2018-02-12 misterg moving JoinAsTuple to internal 2018-02-09 costan Fix std::iscntrl use in gtest-printers.cc 2018-02-12 misterg Merging, coniniue 2018-02-09 misterg merging 2018-02-09 misterg merges 2018-02-09 misterg merges 2018-02-07 troy.holsapple Fixed typos 2018-02-03 sokolov Add ability to throw from ASSERT 2018-02-06 gennadiycivil Include MSVC14 on PRs as well 2018-01-31 misterg Merges and also adding new bazel build mode 2018-01-30 misterg Code merges 2018-01-30 misterg Ability to optionally depend on Abseil plus upstream of 183716547 2018-01-26 misterg Adding tests to googlemock bazel 2018-01-26 misterg Code merges 2018-01-26 lidaobing Update Documentation.md 2018-01-25 stefano.soffia.it Fix test build issue with GCC7.2. 2018-01-25 gennadiycivil Update README.md 2018-01-25 gennadiycivil Remove Visual Studio 10,11,12 from build matrix 2018-01-24 misterg placating gcc and its overzeauls size comparison warnings 2018-01-24 misterg upstream cl 182543808 Created with: roll-dep src/third_party/googletest/src Bug: 813219 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.win:win_chrome_official Change-Id: Ie27a86d27a865bbf076a5aa1a4931b85bc5fceb2 Reviewed-on: https://chromium-review.googlesource.com/923205 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#539763}
-
Vaclav Brozek authored
The ExportWarningDialogFragment should be able to be safely dismissed even if it was not fully initialized. The fragment can be shown on re-creation of Chrome by Android, in which case it does not get initialized, and dismisses itself for that very reason. However, the current onDismiss procedure tries to call back to a handler obtained during initialization. This CL makes that calling back optional, only for cases when the handler is already set. Bug: 816377 Change-Id: Ib9e1b498e7dbb14afc31634a48829782cb4b020b Reviewed-on: https://chromium-review.googlesource.com/939461Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
-
Boris Yusupov authored
It expects platform_util::IsWindowActive() before subcribe to renderer events and it isn't necessary so for example at local execution or simulatesly running several tests. Thus it should set window active and it is interactive ui test. Change-Id: Ia2bfd487fc1fe33aee1c35e0bbee342b72ef6fe2 Reviewed-on: https://chromium-review.googlesource.com/936541Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Boris Yusupov <boriay@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#539761}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 468d0c82. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/13004 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: domenic@chromium.org, ricea@chromium.org, tyoshino@chromium.org: external/wpt/streams rouslan@chromium.org, mathp@chromium.org: external/wpt/payment-request worker-dev@chromium.org: external/wpt/workers TBR=kereliuk No-Export: true Change-Id: I229ea142767665c14eb3c9fb1123a40f9f4f0676 Reviewed-on: https://chromium-review.googlesource.com/940881 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
-
Risan authored
As noticed by hashimoto@ and lhchavez@ in ag/938683, we actually need to perform this in UI Thread instead of blocking pools. We are still posting the task to a thread to keep the non-blocking I/O behaviour. Bug: chromium:816816 Change-Id: I607f515e335bb48e074caa60a67835074d179558 Reviewed-on: https://chromium-review.googlesource.com/939065 Commit-Queue: Risan <risan@chromium.org> Reviewed-by:
-
Yuki Shiino authored
Following https://crrev.com/c/928783 , refactors V8PersistentCallbackFunction<T>. Major improvements: - V8PersistentCallbackFunction<T> is no longer a subclass of T. There will be no unintentional conversion between wrapper-tracing version and v8::Persistent version. - WrapPersistent(T*) = delete; where T is wrapper-tracing versions of callback functions. There will be no misuse of WrapPersistent for wrapper- tracing versions. Bug: 779036, 810701 Change-Id: I7b83caa2b064b70e338892c873b1eb258d2a9c99 Reviewed-on: https://chromium-review.googlesource.com/931561 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
-
Dominic Mazzoni authored
The reverse relation maps are maps from each attribute, to a map from destination id to a set of source ids, like this: map<attr, map<int, set<int>>> AXEventGenerator::FireRelationSourceEvents used const auto in two places where it should have used const auto&, resulting in making two temporary copies of every entry in the map for each node in the tree. Tested manually using chrome://tracing. Without FireRelationSourceEvents at all, loading one Wikipedia page took ~100 ms. With FireRelationSourceEvents, it took 28,000 ms. With this fix it took ~115 ms, so FireRelationSourceEvents is now adding just a small, acceptable amount of overhead. We could optimize it further if needed. Bug: 817133 Change-Id: Ib02968593ed5c9533fb72adae4eba32faea3e61f Reviewed-on: https://chromium-review.googlesource.com/940815Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#539757}
-
Wez authored
The most recent SDK roll has broken an IPC file-descriptor passing test, which appears to be due to a mismatch between the semantics of fdio_transfer_fd() and fdio_create_fd(). TBR: scottmg Bug: 817241 Change-Id: I020425fa1a948c67f8cd8cdb2b0b64cd052c7479 Reviewed-on: https://chromium-review.googlesource.com/940164Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#539756}
-
Yuki Awano authored
Bug: 817264 Test: ArcAccessibilityHelperBridgeTest.NotificationEventArriveFirst Change-Id: Id9c90466a335680355ac83fc6d8b70a387c53b99 Reviewed-on: https://chromium-review.googlesource.com/940902Reviewed-by:
-
Trent Apted authored
Fix a bug in Mash where a root window would be given two shadows: one each process. The one in the browser process would be clipped to the root window bounds, so is only visible when the window has rounded corners. The corner radius is currently only used for window server shadows. (E.g. it's not used in aura::Window::HitTest()). Bug: 811859, 801583 Change-Id: I260b0ff71e01181952d0ef4dfbfebd8ae95133b5 Reviewed-on: https://chromium-review.googlesource.com/925943 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#539754}
-
Ramin Halavati authored
Network traffic annotation tag is added to: QuicChromiumPacketWriter::WritePacketToSocketImpl() Bug: 656607 Change-Id: I97a40e772f70a23fc2503fe5a9dc3e62cc14d963 Reviewed-on: https://chromium-review.googlesource.com/934129 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#539753}
-
Sami Kalliomäki authored
Completes migration introduced here: https://chromium-review.googlesource.com/c/chromium/src/+/839867 Bug: webrtc:8662 Change-Id: I6eac81b115192809f07fb4bff40d4a4567b02002 Reviewed-on: https://chromium-review.googlesource.com/939383Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Sami Kalliomäki <sakal@chromium.org> Cr-Commit-Position: refs/heads/master@{#539752}
-
https://webrtc.googlesource.com/src.git/+log/8cb344acfdb1..12c8110e8c71 $ git log 8cb344acf..12c8110e8 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I27d9d05b16496742be11cf178c0ca2721415ed9d Reviewed-on: https://chromium-review.googlesource.com/939766Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#539751}
-
Colin Blundell authored
CreditCardSaveManager uses IdentityProvider to get the "active username." In practice it is always a ProfileIdentityProvider instance that is passed in (cf. crbug.com/809435), and the active username in that context is the email address of the primary (authenticated) account. As we are looking to eliminate ProfileIdentityProvider, this CL relpaces CreditCardSaveManager's usage with equivalent usage of IdentityManager. Bug: 809435, 809927 Change-Id: I12fe0523c7297495b362d4360d056b7208b0077f Reviewed-on: https://chromium-review.googlesource.com/915945 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
-
Blake O'Hare authored
Previously, this would anchor the keyboard to the closest edge of the screen in both the X and Y directions. When the screen orientation or screen size changes, it would maintain the same pixel distance from each of those sides. When the keyboard is intentionally anchored in a corner, this works out great, but when the keyboard is centered along an edge of the screen, this creates unexpected results since the distribution of padding on either side of the keyboard has changed significantly. This simplifies the logic to simply maintain the ratio of padding on either side of the keyboard in each direction (referred to in the code as `[left_|top_]padding_allotment_ratio`. This records the percent of the available padding that appears to the left or above the keyboard. This ratio is maintained across screen size changes. Updated unit test, which lacked non-corner test cases. Bug: 817226 Change-Id: I13e424f436aaa62cf8aa77626fa27985cbdf24a2 Reviewed-on: https://chromium-review.googlesource.com/940745Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Blake O'Hare <blakeo@chromium.org> Cr-Commit-Position: refs/heads/master@{#539749}
-
