- 03 Sep, 2020 40 commits
-
-
Danil Chapovalov authored
Bug: None Change-Id: Ife9ebd44511859992b39e11ef13d3cba660317f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391063Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Danil Chapovalov <danilchap@chromium.org> Cr-Commit-Position: refs/heads/master@{#804225}
-
Stephen Nusko authored
This reverts commit e8bb886c. Reason for revert: Still breaks perf bots: crbug/1124326 Original change's description: > Reland "Remove BlockThirdPartyCookies preference" > > This is a reland of 1180542b > > BLOCK_THIRD_PARTY_COOKIES usage in clank is fixed: > https://crrev.com/i/3250184 > > Original change's description: > > Remove BlockThirdPartyCookies preference > > > > The boolean BlockThirdPartyCookies preference was replaced by > > CookieControlsMode enum. Existing settings were migrated since M83. > > Since all usage of the preference has been removed, the preference > > can be removed and existing settings cleared. > > > > Bug: 1104836 > > Change-Id: Ie6e38b0a424981395c627459d684030ea84a58b7 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387805 > > Reviewed-by: Balazs Engedy <engedy@chromium.org> > > Reviewed-by: Gabriel Charette <gab@chromium.org> > > Commit-Queue: Christian Dullweber <dullweber@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#803844} > > Tbr: gab@chromium.org > Bug: 1104836 > Change-Id: If89041daa0a46da604171acf734b9733d9a24e07 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390655 > Commit-Queue: Christian Dullweber <dullweber@chromium.org> > Reviewed-by: Balazs Engedy <engedy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#804217} TBR=gab@chromium.org,engedy@chromium.org,dullweber@chromium.org Change-Id: I2a6799c01373c1b5b265fa2518406a2305e1dbd7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1104836,1124326 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390912Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Commit-Queue: Stephen Nusko <nuskos@chromium.org> Auto-Submit: Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#804224}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1599089820-30c557886a4f99c250ad2970e2bac8f9c1182d9f.profdata to chrome-win64-master-1599112620-a8868b59128a8bce1a265b8451e03eb5caa355ad.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com Change-Id: Ia3e059bacc63b309fc83de5f24ab799e38fc41f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392556Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804223}
-
Maksim Ivanov authored
Fix double-callback-call crashes in //content/shell/browser/web_test/web_test_storage_access_manager.cc Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I9fddd7f0c65c877270a86d871044e7b636f75c56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384469 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#804222}
-
Nicolas Ouellet-Payeur authored
This reverts commit 5cdaf457. Reason for revert: crbug.com/1124740 Original change's description: > Make NGInlineNode::ShapeText() not to reuse ShapeResult for letter-spacing > > This patch changes |NGInlineNode::ShapeText()| not to reuse > |ShapeResult| for text with CSS property "letter-spacing" because we > modify |ShapeResult| directly to apply letter spacing. Thus, letter- > spacing is applied more than once on reused portion of |ShapeResult|. > > Note: This patch also changes number of bits of > |SharepResult::num_glyphs_| from 30 to 29 to hold bit flags in > |unsigned| (32-bit) for re-landing[1]. > > [1] http://crrev.com/c/2390615 Revert "Make NGInlineNode::ShapeText() > not to reuse ShapeResult for letter-spacing" > > Bug: 1124446 > Change-Id: I120cc379a191e1499ac1548a569474ed03d0f6a5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391890 > Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> > Commit-Queue: Koji Ishii <kojii@chromium.org> > Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> > Reviewed-by: Koji Ishii <kojii@chromium.org> > Cr-Commit-Position: refs/heads/master@{#804185} TBR=yosin@chromium.org,tkent@chromium.org,kojii@chromium.org,ikilpatrick@chromium.org Change-Id: Ifc310dd7c34b1243d10f64f62cd2144b54bbfa88 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1124446 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392577Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#804221}
-
Patrick Brosset authored
There is a frontend part to this change: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2379098/ The goal is to track how many grids people highlight in web pages using either the adorner in the Elements tree, or the checkboxes in the Layout panel. The histogram is done in a way where we track when users highlight 0, 1, 2, 3, 4 grids, and then between 5 and 9, 10 and 19, 20 and 49, and more than 50. We have more granularity at the bottom end of the spectrum as the expectation is that users will mostly highlight few grids at a time. Bug: 1047356 Change-Id: I6ff3a0f870b9a6054dcd66af57d90ed3cbe53a89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379254Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Vidal Diazleal <vidorteg@microsoft.com> Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Patrick Brosset <patrick.brosset@microsoft.com> Cr-Commit-Position: refs/heads/master@{#804220}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c4bfa82e48ed..fb45a94639ca 2020-09-03 taylori@google.com perfetto-ui: Make sharing/downloading trace consistent If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Id89ed49d4178fea6660b8aa70272b060c452473d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392656Reviewed-by:
-
Garrett Beaty authored
These compile targets are currently specified in recipe configuration. Bug: 1091004 Change-Id: Id74efa2c63ec802b5b216e5e4238091f02dc2d1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391613 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#804218}
-
Christian Dullweber authored
This is a reland of 1180542b BLOCK_THIRD_PARTY_COOKIES usage in clank is fixed: https://crrev.com/i/3250184 Original change's description: > Remove BlockThirdPartyCookies preference > > The boolean BlockThirdPartyCookies preference was replaced by > CookieControlsMode enum. Existing settings were migrated since M83. > Since all usage of the preference has been removed, the preference > can be removed and existing settings cleared. > > Bug: 1104836 > Change-Id: Ie6e38b0a424981395c627459d684030ea84a58b7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387805 > Reviewed-by: Balazs Engedy <engedy@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Commit-Queue: Christian Dullweber <dullweber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#803844} Tbr: gab@chromium.org Bug: 1104836 Change-Id: If89041daa0a46da604171acf734b9733d9a24e07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390655 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#804217}
-
Collin Baker authored
Fixed: 1123994 Change-Id: I0f099ad8196ba2a967327bca569b535b0585e9f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388761 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#804216}
-
Garrett Beaty authored
These targets are currently specified in recipe configuration. Bug: 1091004 Change-Id: I41f31ac70d92750d4e5d441d8f8fb992c206395c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391513 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
-
Olesia Marukhno authored
The first time when match changes its height, pedal button is misplaced and overlaps with another match. This was caused by setting wrong bounds for button row. Previous cl was reverted because wrong bounds were set and that caused button mouse events not working. This is fixed in this patch. Bug: 1121934 Change-Id: I7c1dbbd0b1ec7e59c602a2608f0a7501a26a2490 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390905Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Olesia Marukhno <olesiamarukhno@google.com> Cr-Commit-Position: refs/heads/master@{#804214}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a66a9c31a318..be72801f29f9 2020-09-03 kjlubick@google.com Reland "[canvaskit] Replace RRect objects with TypedArrays." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: michaelludwig@google.com Change-Id: Ic12a71d2cbcf40d992ea1808d5d030ece5c96c15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392348Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/fc059c13722f..598906885691 2020-09-03 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Loader from d846ea5a2427 to 399ebf707295 (3 revisions) 2020-09-03 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from b0337a548273 to 6f1037eec97a (2 revisions) 2020-09-03 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 09df13c2 to 5881c1ad (369 revisions) 2020-09-03 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from e1051cbaad46 to 75690ce7ef4a (4 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cwallez@google.com Change-Id: Iaf501e976db782716de9b1f4a7223915b3fab9d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392346Reviewed-by:
-
Antonio Gomes authored
This corresponds to section 2.1.1 in the design document [1]. [1] https://docs.google.com/document/d/19Zk6Fv1E-6QTQ2c33rpBjDNEkzlsSKvjb3hWkvZAE80/ In summary, it moves the following files from //content/renderer/media/audio to blink: 1/ public/web/modules/media/audio/ - audio_input_ipc_factory.h (to be renamed with 'web' prefix) 2/ renderer/modules/media/audio/ - audio_input_ipc_factory.cc (to be renamed with 'web' prefix) - mojo_audio_input_ipc.h - mojo_audio_input_ipc.cc - mojo_audio_input_ipc_unittest.cc (renamed) Second, it also (temporarily) adds two blink::Platform methods, that will be replaced by a Supplement approach in a follow up. Also, also adapts the code to use the respective blink mojo variants where needed. Last, some trailing includes were removed. BUG=787252 R=guidou@chromium.org, haraken@chromium.org Change-Id: Ib972627b621344d30f9f35e4b262bf4846f2573b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388721Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Antonio Gomes (GMT-4) <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#804211}
-
Yifan Luo authored
Bug: 1116418 Change-Id: Ifb2315d41799d02bfbe330719ca69eee502c0235 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390649 Commit-Queue: Yifan Luo <lyf@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#804210}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f09ac23c..8badb56a Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If1203bef545115d865595e5088c66f69c3e10295 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391623Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804209}
-
Matthew Mourgos authored
Bug: 1109938 Change-Id: I5d3f97af4fcd1582ad323a813f93cd3c576901c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389040Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#804208}
-
Antonio Sartori authored
The Content-Security-Policy source intersection algorithm implemented in https://crrev.com/c/2315687 had a small bug when intersecting port undefined with *. The bug would have been caught by the unit tests, but I had a small typo there which made half of the unit tests not run. Bug: 1094909 Change-Id: Iaa8122b6a9d5b5533362675a35c784780860f0c8 Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392455Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Cr-Commit-Position: refs/heads/master@{#804207}
-
Alan Cutter authored
The default web app migration process guards its uninstall_and_replace logic on whether the web app has been installed before. Instead it should check whether the app to migrate exists or not. Without this CL the default web app would not perform the migration if it had previously been installed then reverted. Bug: 1104696 Change-Id: Iedc8752a9824e85080d227c818307dbbfdd5248b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389740 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#804206}
-
Clovis PJ authored
Change-Id: I8890216b416a3c035054c81336dc53334698fb78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362759 Commit-Queue: Clovis PJ <clovispj@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#804205}
-
Chris Blume authored
Some TileManager comments were a tad unclear. This CL just cleans them up. Change-Id: I1317f58469053f6265ae713e2cde1bef84900e50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392475 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
-
Sam Zackrisson authored
Bug: chromium:1124622, chromium:1016708 Change-Id: I7ab05e2a5df02bd81790d59d5e6672d66d58dd6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391141Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Sam Zackrisson <saza@chromium.org> Cr-Commit-Position: refs/heads/master@{#804203}
-
Nohemi Fernandez authored
Ensures that the iOS Authentication Service consistently uses SSOAuth internal services to check the signed-in status of the primary account. The use of two backends has caused an issue in the past (crbug/1033901) where we had to expose both primary account checking methods to avoid a crash. Fixed: 1044270 Change-Id: I9c805ebafc9ae23487d588457ce7722930d285d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385438 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#804202}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/96dcbc6eb372..1d46a533aa37 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I477bcf79c0204e2ee8fd9b5031a10a372b648977 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392615Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/96dcbc6eb372..1d46a533aa37 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I97bf4e526fb149b4118d0b0e1a03e85f6a1a5647 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392616Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e3c171740b34..1164044d4c20 2020-09-03 tvanderlippe@chromium.org Migrate test_runner to devtools_entrypoint 2020-09-03 patrick.brosset@microsoft.com Layout: Give each grid overlay a different color in order to differentiate them 2020-09-03 tvanderlippe@chromium.org Migrate heap_snapshot_worker to devtools_entrypoint 2020-09-03 tvanderlippe@chromium.org Migrate wasmparser_worker to devtools_entrypoint 2020-09-03 tvanderlippe@chromium.org Migrate developer_resources to devtools_entrypoint 2020-09-03 tvanderlippe@chromium.org Migrate webauthn to devtools_entrypoint If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1101738,chromium:1123052 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ic93d16a2175630e21752b8cad26c9228cb0c8f08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391524Reviewed-by:
-
Mohamed Adel authored
I added |oldest_notification_time| to the method "CountVisibleNotifications" which holds the time of the oldest notification. R=knollr@chromium.org, peter@chromium.org Bug: 1122039 Change-Id: I455eeeb89f25c68565bc48c2385cc6b36de919ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377737Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
-
Alice Wang authored
This CL removes the method AccountPickerDelegate#goIncognitoMode() as the incognito related actions will be handled in a separate MVC package. Bug: 1120350 Change-Id: I09ad7b3465974ff4c7c41bedd155bf71d1164de6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391067Reviewed-by:
Rohit Agarwal <roagarwal@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#804197}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/1d46a533aa37..c4bfa82e48ed 2020-09-03 primiano@google.com Merge "UI: improve error reporting for Wasm errors" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ib1dbf10a5a1e4587b12480ac172342ab4ebe620b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391416Reviewed-by:
-
Ramin Halavati authored
The default values for OffTheRecord profile functions are removed and all remaining use cases are replaced with [Get/Has]PrimaryOTRProfile. The cases that need further update later are marked with TODO. This CL does NOT change any behavior. Bug: 1033903 Change-Id: Ic44b0cf64ed7717cb0a46e573970ff55ba94609f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387058 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#804195}
-
Nohemi Fernandez authored
In Accessibility label sizes buttons are shown in vertical stack view. Button titles will overflow instead of ellipsized if too large for the label. Before: https://drive.google.com/file/d/1bEClgvRNnxqnC3GVybBrVh4WRTHzfrAD/view?usp=sharing After: https://drive.google.com/file/d/1OMh3XiRUwV5YcPZBii0Dh6NmhIZ-O0mE/view?usp=sharing Bug: 1110243 Change-Id: Id8c99a16c8fca790c73c090028db6e4f3509e68b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391080Reviewed-by:
-
Christoph Schwering authored
This presubmit script checks for name mismatches among base::Feature definitions. Change-Id: Ie89848f8037a507aff7cb1b55b5df12339759d1a Bug: 1124555 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390631 Auto-Submit: Christoph Schwering <schwering@google.com> Reviewed-by:
Matthias Körber <koerber@google.com> Commit-Queue: Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#804193}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: If63e908641ccf616d9f1d31c0ec39298fe32302e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385277 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Miao-chen Chou <mcchou@chromium.org> Cr-Commit-Position: refs/heads/master@{#804192}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: Ieaf4d614b0f0f91da91ebe35783afa66ef38151f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387577Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#804191}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0463f138..f09ac23c Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6acc3b77a3546df3ea6212934e883355a6d39ec3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392575Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c60774bed06c..ea8f739bce40 2020-09-03 mbonadei@webrtc.org Make AudioProcessing::SetExtraOptions non pure-virtual. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I51959633bd728846fc51b5512aec4a1bce648a5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392268Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/c35e2ba3798e..9e261b46a4f7 2020-09-03 cwallez@chromium.org Fix compilation with dawn_enable_wgsl=false If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I47d8616aadc6e353f964d5b6a3178d83db8c027c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392271Reviewed-by:
-
Maksim Ivanov authored
Add temporary verbose logging into implementation of StatisticsProvider and related files, in order to be able to track down issues on non-dev-mode Chrome OS devices. Example log snippet after this CL: [WARNING:name_value_pairs_parser.cc(128)] Statistics wpsw_cur mentioned in /usr/bin/crossystem: 777073775F637572202020202020202020202020202020203D203120202020202020202020202020202020202020202020202020202020202023205B524F2F696E745D204669726D776172652077726974652070726F74656374206861726477617265207377697463682063757272656E7420706F736974696F6E [WARNING:statistics_provider.cc(321)] Finished loading statistics. [WARNING:device_status_collector.cc(2071)] Statistics wpsw_cur: 1 [INFO:status_uploader.cc(216)] Starting status upload: has_device_status = 1 write_protect_switch = 1 This CL will need to be reverted once the root cause of the associated bug (b/158252688) is found. Bug: 1123153 Change-Id: If718299a8aa8fa7b991168f8a46cccf0bd24f45d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382751 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Igor <igorcov@chromium.org> Cr-Commit-Position: refs/heads/master@{#804187}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/cba9bbbed68f..fc059c13722f 2020-09-03 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from c278dada96d9 to 2c60d16a646b (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cwallez@google.com Change-Id: I4158c41ad3ac2e882c735964a9ded3b60ba80f2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392361Reviewed-by:
-
