GitLab

There was custom generated code specifically for handling arguments with
[Clamp], which is quite unnecessary since the toUInt*() have an integer
conversion configuration parameter that among other things can be used to
request clamping.

Related: Fix the somewhat broken handling the |Clamp| integer conversion
configuration in the toUInt*() helpers. An optimization code path for the
case that the V8 value is an int32 forgot to do clamping, there was no
clamping at all in toUInt64(), and +/- Infinity was converted to zero
instead of being clamped.

Clamping support is not added to toInt64(), since the clampTo<> helper in
Source/wtf/MathExtras.h explicitly doesn't support |long long int|, which
is int64_t on some platforms.

BUG=413257

Review URL: https://codereview.chromium.org/563793002

git-svn-id: svn://svn.chromium.org/blink/trunk@181882 bbb929c8-8fbe-4397-9dbb-9b2b20218538

To remove generic Dictionary from MutationObserver.
Added Vector<String> -> HashSet<AtomicString> conversion
because attributeFilter member in MutationObserverInit
is sequence<DOMString>.

Tests under fast/dom/MutationObserver cover this change.

Spec: http://www.w3.org/TR/dom/#interface-mutationobserver

BUG=403150

Review URL: https://codereview.chromium.org/560003002

git-svn-id: svn://svn.chromium.org/blink/trunk@181881 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=412088

Review URL: https://codereview.chromium.org/559733005

git-svn-id: svn://svn.chromium.org/blink/trunk@181880 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Use IDL dictionary (NotificationOptions) instead of generic
Dictionary. Tests under fast/notifications are passed.

BUG=403150

Review URL: https://codereview.chromium.org/556193002

git-svn-id: svn://svn.chromium.org/blink/trunk@181879 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Revert of Service Worker: Add tests for same-scope new script registration (patchset #1 id:1 of https://codereview.chromium.org/512703002/)

Reason for revert:
This crash will be fixed by https://codereview.chromium.org/556003006.

Original issue's description:
> Revert of Service Worker: Add tests for same-scope new script registration (patchset #6 of https://codereview.chromium.org/480943002/)
> 
> Reason for revert:
> This is crashing on Mac.
> 
> Original issue's description:
> > Service Worker: Add tests for same-scope, new script registration
> > 
> > Tests for Chromium patch:
> > https://codereview.chromium.org/506043002/
> > 
> > BUG=398355
> > 
> > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180948
> 
> TBR=michaeln@chromium.org,nhiroki@chromium.org,falken@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=398355
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180956

TBR=michaeln@chromium.org,nhiroki@chromium.org,falken@chromium.org,mlamouri@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=398355

Review URL: https://codereview.chromium.org/547743003

git-svn-id: svn://svn.chromium.org/blink/trunk@181878 bbb929c8-8fbe-4397-9dbb-9b2b20218538

To remove generic Dictionary from a DOMPoint constructor.
No changes in behavior; fast/dom/geometry-interfaces-dom-point.html
should cover this change.

Spec: http://dev.w3.org/fxtf/geometry/#DOMPoint

BUG=403150

Review URL: https://codereview.chromium.org/558163002

git-svn-id: svn://svn.chromium.org/blink/trunk@181877 bbb929c8-8fbe-4397-9dbb-9b2b20218538

public/web/WebSettings.h does:
and uses some types from ICU in its definition. Thus, anything that
depends on the blink public API and includes this header must have the
icu include dirs on their include path. This forwards icu_config from
the blink_headers target so dependents do not have to do this themselves
(unless they are linking against ICU directly)

R=brettw@chromium.org

Review URL: https://codereview.chromium.org/563963003

git-svn-id: svn://svn.chromium.org/blink/trunk@181876 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Before applying this patch, run-bindings-tests uses 'tests' as component_dir.
So tests results had '#include "bindings/tests/.../V8Test....h".

However, for testing binding modularization, need to emluate 'Source/core' and 'Source/modules'.
So Source/bindings/tests/idls/core should be treated as 'core' (i.e. the tests should be treated as if they are placed under Source/core).
Souce/bindings/tests/idsl/modules should be treated as 'modules'.

BUG=358074

Review URL: https://codereview.chromium.org/563453002

git-svn-id: svn://svn.chromium.org/blink/trunk@181875 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The test suites are moving from being pulled in via src/DEPS to
LayoutTests/w3c to being checked in directly to LayoutTests/imported.

This import uses update-w3c-deps run manually and
imported csswg-test@6ed3bb6642b0d382ce8c3f7912172f2420eb7756 and
imported web-platform-tests@6ed3bb6642b0d382ce8c3f7912172f2420eb7756

In addition, we modify run-webkit-tests to manually skip the old
LayoutTests/w3c directory if it exists, and to start printing warnings
that the repos are stale and should be deleted.

This is patchset 3 of the 4 needed to complete the cutover.

TBR=eseidel@chromium.org
BUG=413454

Review URL: https://codereview.chromium.org/560893005

git-svn-id: svn://svn.chromium.org/blink/trunk@181874 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The compositor expects that the whole composited scrolling layer to be
invalidated in time and won't update the tiles that are newly visible
when scrolled if the tiles are up-to-date from the compositor side.

If we clip invalidations, the compositor will think the layer areas
outside of the clip are all valid and won't repaint them.

BUG=412516
TEST=compositing/repaint/should-not-clip-composited-viewport-scrolling-layer.html
TEST=compositing/repaint/should-not-clip-composited-overflow-scrolling-layer.html

Review URL: https://codereview.chromium.org/566433002

git-svn-id: svn://svn.chromium.org/blink/trunk@181873 bbb929c8-8fbe-4397-9dbb-9b2b20218538

scriptState->executionContext() returns NULL in the following situation.

[Main thread]
- WorkerThread::stop()
 - m_workerGlobalScope->script()->scheduleExecutionTermination();
  - v8::V8::TerminateExecution(m_isolate);

[Worker thread]
- FetchBodyStream::readAsync()
 - ScriptPromiseResolver::create()
  ---> v8::Promise::Resolver::New()
     - v8::internal::Execution::Call
      - v8::internal::Invoke
       - JS
        - v8::internal::__RT_impl_Runtime_StackGuard
         - v8::internal::Isolate::TerminateExecution()
            Sets TerminationException.
 - scriptState->executionContext()
  - toExecutionContext()
   - V8WorkerGlobalScope::findInstanceInPrototypeChain()
    - V8PerIsolateData::findInstanceInPrototypeChain()
     - V8PerIsolateData::findInstanceInPrototypeChain()
      - v8::Object::FindInstanceInPrototypeChain()
       - ON_BAILOUT(isolate,
                    "v8::Object::FindInstanceInPrototypeChain()",
                    return Local<v8::Object>());
        - IsExecutionTerminatingCheck()
          Returns true.

BUG=409755
TEST=run_webkit_tests http/tests/serviceworker/request.html

Review URL: https://codereview.chromium.org/535193002

git-svn-id: svn://svn.chromium.org/blink/trunk@181872 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It will be less error-prone to pass references instead of pointers.
Customers don't need to add ASSERT().

This is a follow-up CL of https://codereview.chromium.org/547383004/,
and no changes in behavior.

BUG=321462

Review URL: https://codereview.chromium.org/558283004

git-svn-id: svn://svn.chromium.org/blink/trunk@181871 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=oilpan-reviews,adamk@chromium.org
BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/570453003

git-svn-id: svn://svn.chromium.org/blink/trunk@181870 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Just some styling and import boogs, but they meant buttons
didn't render at all.

NOTRY=true
TBR=leviw@chromium.org

Review URL: https://codereview.chromium.org/564023002

git-svn-id: svn://svn.chromium.org/blink/trunk@181869 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Instead of going through string(), use
the AtomicString API directly.

Review URL: https://codereview.chromium.org/560273004

git-svn-id: svn://svn.chromium.org/blink/trunk@181868 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL caused use-after-free in :LocalDOMWindow::willDetachDocumentFromFrame.
https://code.google.com/p/chromium/issues/detail?id=413316

> Simplify DOMWindowProperty and its unregistration.
> 
> As LocalDOMWindow controls the registration lifetime of its
> DOMWindowProperties, there's no need to offer a separate unregistration
> mechanism. Remove it, simplify notification code + retire now unused
> LocalDOMWindow back reference on DOMWindowProperty.
> 
> R=haraken,ager
> BUG=
> 
> Review URL: https://codereview.chromium.org/558213002

TBR=sigbjornf@opera.com

Review URL: https://codereview.chromium.org/564013002

git-svn-id: svn://svn.chromium.org/blink/trunk@181867 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We have basic support for IDL dictionary so we can use it for
MIDIOptions. Renamed m_sysexEnabled and setSysexEnabled()
because their role have changed.

MIDIOptions is the first IDL dictionary in modules/ so this CL
also contains GYP/GN changes.

Existing tests (LayoutTests/webmidi) should cover this change.

BUG=403150

Review URL: https://codereview.chromium.org/547383004

git-svn-id: svn://svn.chromium.org/blink/trunk@181866 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch adds trace events for setNeedsLayout calls so that we can
do end-to-end tracking of what causes repaints to occur. The devtools
side isn't yet hooked up so this patch simply adds the trace event.

As a cleanup, "core/inspector/InspectorTraceEvents.h" has been moved
up into RenderObject and unneeded includes have been removed.

R=kouhei
BUG=410701

Review URL: https://codereview.chromium.org/561413002

git-svn-id: svn://svn.chromium.org/blink/trunk@181865 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Directly embed the failure cards into the failure stream, and abstract
the button UI out into ct-failure-card-buttons.

NOTRY=true
R=ojan@chromium.org

Review URL: https://codereview.chromium.org/565523002

git-svn-id: svn://svn.chromium.org/blink/trunk@181864 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Instead of passing a String url and having ResourceRequest
create a KURL out of it, pass in the readily available
KURL object.

Review URL: https://codereview.chromium.org/561383002

git-svn-id: svn://svn.chromium.org/blink/trunk@181862 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This change is the first in a three-sided set of changes, and introduces
WebSourceBufferClient for handling media engine notifications
of newly received initialization segments.
It adds logic to make the addition of a SourceBuffer into
MediaSource.activeSourceBuffers more compliant once all three sides
land: addition will be done per the MSE spec's first initialization
flag logic rather than other non-compliant approaches like at
addSourceBuffer() time or on transition to HAVE_METADATA. Insertion
logic is included to preserve correct ordering of
activeSourceBuffers.
Updated and new layout tests are included.

R=acolwell@chromium.org,philipj@opera.com,tkent@chromium.org
TEST=No mediasource layout test regression
BUG=249428,397243

Review URL: https://codereview.chromium.org/552943002

git-svn-id: svn://svn.chromium.org/blink/trunk@181861 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is patchset 1 of 4 in making that happen.

This patch changes update-w3c-deps to do the import. Tests will now be imported into the "LayoutTests/imported" directory, to avoid any conflicts with the old git repos.

This patch significantly reworks update-w3c-deps, and patches webkitpy.test_importer to remove the import logs, make logging work better during the import, and handle skipping subdirs properly when not importing in place.

This patch also adds an exit() method to the SystemHost class to remove one more reason for importing sys.

TBR=eseidel@chromium.org
BUG=413454
BUG=

Review URL: https://codereview.chromium.org/565673006

git-svn-id: svn://svn.chromium.org/blink/trunk@181860 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The existing implementation instead couldn't decide if it wanted to
calculate the nearest time or how close a given time was to a range.

The new implementation follows the HTML spec for TimeRanges where
nearest() returns a time within the range closest to the desired
time. Equidistant matches are resolved by distance from the current
time.

BUG=412562
TEST=new unittest.

Review URL: https://codereview.chromium.org/559993004

git-svn-id: svn://svn.chromium.org/blink/trunk@181859 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=ojan@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/567673003

git-svn-id: svn://svn.chromium.org/blink/trunk@181858 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- Drop worker support from DatabaseClient.
- Remove WorkerGlobalScope support of DatabaseContext::allowDatabaseAccess.

BUG=397429
TEST=none; No behavior changes.

Review URL: https://codereview.chromium.org/564713002

git-svn-id: svn://svn.chromium.org/blink/trunk@181857 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Also add a similar test to make sure the API exists/rejects in service workers.

BUG=383125

Review URL: https://codereview.chromium.org/543203003

git-svn-id: svn://svn.chromium.org/blink/trunk@181855 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/544823003

git-svn-id: svn://svn.chromium.org/blink/trunk@181853 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=oilpan-reviews
BUG=413341
NOTRY=true

Review URL: https://codereview.chromium.org/563923003

git-svn-id: svn://svn.chromium.org/blink/trunk@181852 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It turns out that selection of all elements in console (aka Ctrl-A)
works properly only if the last element in viewport DOM is a block
element with some text.

BUG=410899
R=vsevik

Review URL: https://codereview.chromium.org/564893002

git-svn-id: svn://svn.chromium.org/blink/trunk@181850 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Revert of Split out CSSParser public API (patchset #1 id:1 of https://codereview.chromium.org/566703002/)

Reason for revert:
Bring it back since the OilPan builder is not a tree closer.

Original issue's description:
> Revert of Split out CSSParser public API (patchset #3 id:40001 of https://codereview.chromium.org/566483002/)
> 
> Reason for revert:
> Caused compiling errors.
> 
> Original issue's description:
> > Split out CSSParser public API
> > 
> > This patch separates the public API of BisonCSSParser from the hundreds
> > of public methods it exposes. The plan is to build a new parser based on
> > the css-syntax specification, which will eventually complete replace the
> > bison-based parser. The functions in this class will do the run-time
> > switching between the bison parser and the new (unwritten) parser.
> > 
> > For the functions here which are only ever used with a newly instantiated
> > BisonCSSParser, I've moved instantiation to inside the CSSParser so that
> > the functions can be static.
> > 
> > This is an updated version of a patch by eseidel from 8 months ago:
> > https://codereview.chromium.org/112933010/
> > 
> > BUG=330389
> > 
> > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181825
> 
> TBR=eseidel@chromium.org,esprehn@chromium.org,alancutter@chromium.org,timloh@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=330389
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181837

TBR=eseidel@chromium.org,esprehn@chromium.org,alancutter@chromium.org,timloh@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=330389

Review URL: https://codereview.chromium.org/563893002

git-svn-id: svn://svn.chromium.org/blink/trunk@181849 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This fixes crbug.com/411933 where overlay scrollbars in ChromeOS would show
up on the new tab page even though they weren't needed. This was occurring
because the page scale factor limits, though set in RenderViewImpl::Initialize,
were ineffective until a layout occured since Blink's PageScaleConstraintsSet
wouldn't have computed the final constraints. Thus, the limits used were Blink's
default limits, set to hardcoded values in PageScaleConstraintsSet. This caused
the scrollbar in the compositor to think the page was zoomed in and displayed
the scrollbars.

This patch replaces the uncomputed final constraints with "all 1" values for
minimum, maximum and initial scale, rather than using the (Android-specific)
defaults.

BUG=411933

Review URL: https://codereview.chromium.org/567663002

git-svn-id: svn://svn.chromium.org/blink/trunk@181848 bbb929c8-8fbe-4397-9dbb-9b2b20218538

A Skia change caused this to start failing, and the bug in Skia has since been fixed.
Remove the suppression since these tests have been passing.

TBR=senorblanco,hclam
NOTRY=true
BUG=408858

Review URL: https://codereview.chromium.org/568543002

git-svn-id: svn://svn.chromium.org/blink/trunk@181847 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The handling of the PromiseDataWrapper in r181662 wasn't complete, as it
failed to keep an Oilpan-reachable persistent to the GCed wrapper object,
risking premature finalization. For Oilpan also, this wrapper object should 
only keep its references weakly alive.

To make the tracing of these relationships work out, PromiseTracker is
no longer a part object, but heap allocated.

R=haraken
BUG=340522

Review URL: https://codereview.chromium.org/561753002

git-svn-id: svn://svn.chromium.org/blink/trunk@181845 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=412251
R=pdr@chromium.org
TEST=./Tools/Scripts/run-webkit-tests fast/events/click-*

Review URL: https://codereview.chromium.org/562653002

git-svn-id: svn://svn.chromium.org/blink/trunk@181844 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=ager@chromium.org,haraken@chromium.org
BUG=

Review URL: https://codereview.chromium.org/559383002

git-svn-id: svn://svn.chromium.org/blink/trunk@181843 bbb929c8-8fbe-4397-9dbb-9b2b20218538

All scripts currently load at a medium priority and compete with each
other for resources. Async scripts do not block the parser and should be
loaded at a lower priority than those that do.

This patch lowers the priority of scripts with async or defer attributes
and scripts that were injected dynamically to load at a "low" priority
which is below blocking scripts but above (non-visible) images.

Visible images are loaded at the same priority but with a higher
intra-priority based on the screen area they cover so visible images
can preempt async scripts once layout is done (a good thing).

We want to keep scripts at a higher priority than (non-visible) images
for a couple of reasons:

1 - Scripts may cause other resource loads while images do not
(generally). There is potential to push out the onload time of the page
if a script with lots of follow-on content is loaded at the end after
images.

2 - By the time the code executes to inject the script the preload
parser may have already discovered the bulk of the images on the page.

Test results: https://docs.google.com/spreadsheet/ccc?key=0As3TLupYw2RedC1RUHlMRHhFY3RoVHEtc2FhbXQ1aWc&usp=sharing

Slight improvements (~1%) to onload, render and DOM Content Loaded.
1-2% improvement on Speed Index.

BUG=408229

Review URL: https://codereview.chromium.org/514893002

git-svn-id: svn://svn.chromium.org/blink/trunk@181842 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Some compile failures on Sheriff-O-Matic link to the wrong page today, causing
"No results to display" to be shown under the information for a host, instead
of stdio for that compile failure.

This change checks if the step is "compile" and always displays stdio in that
case.

I haven't added a test case for this; I'd like to clean up the routines in this
class to make it easier to test. I tested this manually while waiting for a
compile failure to happen that didn't display well.

NOTRY=true
BUG=404927

Review URL: https://codereview.chromium.org/549313005

git-svn-id: svn://svn.chromium.org/blink/trunk@181841 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Since we are supposed to end up with an AtomicString, don't rely on implicit conversion, but provide it as static local variable while using ConstructFromLiteral to avoid using strlen.

Review URL: https://codereview.chromium.org/567653002

git-svn-id: svn://svn.chromium.org/blink/trunk@181840 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Revert of CSP: Convert CSPSource constructor bools into a enum. (patchset #1 id:1 of https://codereview.chromium.org/565723002/)

Reason for revert:
Not a culprit.

Original issue's description:
> Revert of CSP: Convert CSPSource constructor bools into a enum. (patchset #1 id:1 of https://codereview.chromium.org/568433002/)
> 
> Reason for revert:
> Your patch broke quite a number of webkit tests:
> http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.8%20%28retina%29/builds/19050
> http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.7/builds/31462
> 
> Original issue's description:
> > CSP: Convert CSPSource constructor bools into a enum.
> > 
> > Rather than passing the wildcard disposition of CSPSource's hosts and ports
> > as booleans, we should have an enum that allows us to figure out hat we
> > mean at the callsite. This patch adds CSPSource::WildcardDisposition in
> > order to make this clear.
> > 
> > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181821
> 
> TBR=jochen@chromium.org,mkwst@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181833

TBR=jochen@chromium.org,mkwst@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/563863002

git-svn-id: svn://svn.chromium.org/blink/trunk@181838 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Split out CSSParser public API (patchset #3 id:40001 of https://codereview.chromium.org/566483002/)

Reason for revert:
Caused compiling errors.

Original issue's description:
> Split out CSSParser public API
> 
> This patch separates the public API of BisonCSSParser from the hundreds
> of public methods it exposes. The plan is to build a new parser based on
> the css-syntax specification, which will eventually complete replace the
> bison-based parser. The functions in this class will do the run-time
> switching between the bison parser and the new (unwritten) parser.
> 
> For the functions here which are only ever used with a newly instantiated
> BisonCSSParser, I've moved instantiation to inside the CSSParser so that
> the functions can be static.
> 
> This is an updated version of a patch by eseidel from 8 months ago:
> https://codereview.chromium.org/112933010/
> 
> BUG=330389
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181825

TBR=eseidel@chromium.org,esprehn@chromium.org,alancutter@chromium.org,timloh@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=330389

Review URL: https://codereview.chromium.org/566703002

git-svn-id: svn://svn.chromium.org/blink/trunk@181837 bbb929c8-8fbe-4397-9dbb-9b2b20218538