- 27 Jan, 2016 40 commits
-
-
skia-deps-roller authored
https://chromium.googlesource.com/skia.git/+log/ccfdaa5f2aee..2bbc343c1482 $ git log ccfdaa5f2..2bbc343c1 --date=short --no-merges --format='%ad %ae %s' 2016-01-27 ethannicholas switched to SkJSONCPP for JSON output GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1639333002 2016-01-27 yujieqin Fix Windows build 2016-01-27 scroggo Stop testing SkImageDecoder in DM/nanobench 2016-01-27 yujieqin Enable RAW codec for Windows 2016-01-27 ebrauer It derives the dng_host and overrides PerformAreaTask() to split the task into several sub-tasks which get added to SkTaskGroup. 2016-01-27 yujieqin Fix complier issue [-Werror, -Wvla] CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=msarett@google.com Review URL: https://codereview.chromium.org/1640353002 Cr-Commit-Position: refs/heads/master@{#371861}
-
fs authored
In some cases this could save a copy of the outer object (rareNonInheritedData in all cases.) This also saves almost 3.5k of binary footprint. BUG=581413 Review URL: https://codereview.chromium.org/1638213004 Cr-Commit-Position: refs/heads/master@{#371860}
-
zhaoqin authored
- update ProgramPath to obtain program path on Windows R=aizatsky@chromium.org BUG= Review URL: https://codereview.chromium.org/1635793002 Cr-Commit-Position: refs/heads/master@{#371859}
-
sergeyu authored
Daemon and desktop processes didn't have attachment brokers, and so the desktop process was failing when trying to pass shared buffer to the network process. BUG=581174 Review URL: https://codereview.chromium.org/1634933007 Cr-Commit-Position: refs/heads/master@{#371858}
-
creis authored
The previous theories haven't held up, so these crash keys will help reveal how the proxy is being created. They cover all the ways of reaching the RenderFrameProxy constructor (i.e., RVI::Initialize, RFI::OnSwapOut, and RTI::OnCreateNewFrameProxy). BUG=575245 TEST=New crash keys present in crash reports. Review URL: https://codereview.chromium.org/1643673002 Cr-Commit-Position: refs/heads/master@{#371857}
-
lushnikov authored
Revert of Introduce SelectionAdjuster to adjust selections between DOM tree version and composed tree version (patchset #2 id:20001 of https://codereview.chromium.org/1630903005/ ) Reason for revert: This patch breaks text selection in DevTools console. Please see http://crbug.com/581800 for details Original issue's description: > Introduce SelectionAdjuster to adjust selections between DOM tree version and composed tree version > > This patch introduces |SelectionAdjuster| class to consolidate functions > adjusting DOM tree version and composed tree version of selections in > |VisibleSelection| class and |SelectionEditor| in one place to avoid having > six parameters constructor, and rude name function |createWithoutValidation()| > to simplify source code for improving readability. > > Note: For ease of reviewing to compare changes, this patch doesn't leave > functions in original place. Following patch moves them to > "SelectionAdjust.{cpp,h}". > > This patch is a preparation of introducing |m_hasTrailingWhitespace| into > |VisibleSelection| class, which makes six parameters constructor to seven > parameters constructor without this patch. > > BUG=n/a > TEST=n/a; no behavior changes > > Committed: https://crrev.com/647b2143c21fade656c085f5a83426e96acbd38a > Cr-Commit-Position: refs/heads/master@{#371697} TBR=yoichio@chromium.org,hajimehoshi@chromium.org,tkent@chromium.org,xiaochengh@chromium.org,yosin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=n/a Review URL: https://codereview.chromium.org/1642723002 Cr-Commit-Position: refs/heads/master@{#371856}
-
wfh authored
static_cast should be used when casting within a class hierarchy. BUG=None Review URL: https://codereview.chromium.org/1639393002 Cr-Commit-Position: refs/heads/master@{#371855}
-
lushnikov authored
Revert of Move SelectionAdjust to its own file (patchset #2 id:20001 of https://codereview.chromium.org/1640623002/ ) Reason for revert: This refactoring breaks text selection in DevTools console. Please see http://crbug.com/581800 for details Original issue's description: > Move SelectionAdjuster to its own file > > This patch moves implementations of |SelectionAdjuster| into its own file. > > This is a follow-up patch of http://crrev.com/1630903005, which introduces > |SelectionAdjuster| into "SelectionEditor.cpp" and "VisibleSelection.cpp". > > BUG=n/a > TEST=n/a; no behavior changes > > Committed: https://crrev.com/da8f47a0153b025331e2c8ed62c4f6510c63c703 > Cr-Commit-Position: refs/heads/master@{#371751} TBR=tkent@chromium.org,yosin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=n/a Review URL: https://codereview.chromium.org/1640913002 Cr-Commit-Position: refs/heads/master@{#371854}
-
yusufo authored
This removes the cached activity copies from InterceptNavigationHandler and ExternalNavigationHandler. - Uses application context when it doesn't make any difference(For package manager related calls.) - Tries to get the activity through the tab and if not fail gracefully either by early return or using application context for launching new activity. BUG=546736 Review URL: https://codereview.chromium.org/1636573004 Cr-Commit-Position: refs/heads/master@{#371853}
-
jlebel authored
BUG= Review URL: https://codereview.chromium.org/1645653003 Cr-Commit-Position: refs/heads/master@{#371852}
-
mpearson authored
That's a heavy function to call. I removed the call. The only thing it was being used for apparently was to get the port. Frankly, I don't see much importance in checking the port of search engines, but I added port_ and a cached internal variable to maintain this support and entirely removed the heavy call. For reference, the port line was part of a large change https://chromium.googlesource.com/chromium/src/+/5b30787532fe44ff67e29fbbedfb1781663a4f06%5E%21/#F8 for which there was no motivating discussion about the need to check ports. I guess there's no harm in it though. BUG= Review URL: https://codereview.chromium.org/1595103007 Cr-Commit-Position: refs/heads/master@{#371851}
-
fs authored
Instead of creating the Path object up front - when the StylePath is created - create it on first access/use (usually on paint/layout.) Review URL: https://codereview.chromium.org/1640313002 Cr-Commit-Position: refs/heads/master@{#371850}
-
fs authored
Adds reporting of errors for the errors detected: * Missing starting moveto * Missing command verb * Unexpected input type (number, arc flag) The parsing helper parseArcFlag() is adjusted to not consume any character on error. BUG=231612 Review URL: https://codereview.chromium.org/1642463004 Cr-Commit-Position: refs/heads/master@{#371849}
-
jshin authored
Use Noto Color Emoji instead of Noto Sans Emoji. In an upcoming update, Noto Sans Emoji is also renamed Noto Emoji. https://chromium-review.googlesource.com/320493 will be landed after this. BUG=574585 Review URL: https://codereview.chromium.org/1562623002 Cr-Commit-Position: refs/heads/master@{#371848}
-
jdufault authored
This also deactivates the keyboard before shutting down the shelf, which fixes a crash introduced by the above change. BUG=577413 Review URL: https://codereview.chromium.org/1614233002 Cr-Commit-Position: refs/heads/master@{#371847}
-
rockot authored
BUG=581702 R=thakis@chromium.org Review URL: https://codereview.chromium.org/1640783002 Cr-Commit-Position: refs/heads/master@{#371846}
-
erg authored
One common pattern that's coming up multiple times is that we want to read or write the full contents of a file. The first attempt at an interface to that had was put on the File object. However, file seeking behaviour differs between platforms. Performing a seek on an empty file is safe on posix and errors on Windows. And when dealing with arbitrary File objects, we want to seek to the beginning just in case there was any previous usage on the File object. It was also cumbersome. The user was still responsible for opening the file and closing it once they were done with it. Putting these operations on Directory not only removes a bug, but also simplifies the interface. BUG=557405 Review URL: https://codereview.chromium.org/1634293002 Cr-Commit-Position: refs/heads/master@{#371845}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/aa81c816..fefcc888 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org Review URL: https://codereview.chromium.org/1645613002 Cr-Commit-Position: refs/heads/master@{#371844}
-
tdresser authored
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1640373002 Cr-Commit-Position: refs/heads/master@{#371843}
-
clm authored
BUG=580632 Review URL: https://codereview.chromium.org/1619923004 Cr-Commit-Position: refs/heads/master@{#371842}
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/537c7c6cb877..4c5aff546a57 $ git log 537c7c6cb..4c5aff546 --date=short --no-merges --format='%ad %ae %s' CQ_INCLUDE_TRYBOTS= TBR=catapult-sheriff@chromium.org Review URL: https://codereview.chromium.org/1640773002 Cr-Commit-Position: refs/heads/master@{#371841}
-
jrummell authored
Currently the mojo implementation doesn't fully support EME nor clockless playback, so those tests are disabled for mojo. BUG=501417 TEST=new tests pass Review URL: https://codereview.chromium.org/1591103002 Cr-Commit-Position: refs/heads/master@{#371840}
-
harkness authored
The specification now allows a PushMessage to have valid non-empty data, valid empty data, and null data. To support that, the content layer now uses a PushEventPayload which can be null. This also adds and updates relevant unit tests for each of the layers. BUG=578036 Review URL: https://codereview.chromium.org/1636483002 Cr-Commit-Position: refs/heads/master@{#371839}
-
mattreynolds authored
When ListUrlsActivity is refreshed we take the current list of known nearby URLs and send it to our URL resolution/metadata service. Previous to this change, if new URLs were discovered after the initial list was sent, they would not be sent to the resolution service or displayed in the activity. This caused buggy behavior where nearby URLs would sometimes not be shown if they were discovered too late. With this change, URLs discovered after the initial resolution step will be appended at the end of the list. BUG=579099 Review URL: https://codereview.chromium.org/1634213002 Cr-Commit-Position: refs/heads/master@{#371838}
-
Robert Sesek authored
BUG=581517 R=thakis@chromium.org Review URL: https://codereview.chromium.org/1642663003 . Cr-Commit-Position: refs/heads/master@{#371837}
-
Walter Korman authored
https://chromium.googlesource.com/chromium/src/+/a538760e6 TBR=fs@opera.com Review URL: https://codereview.chromium.org/1642713002 . Cr-Commit-Position: refs/heads/master@{#371836}
-
nednguyen authored
BUG=537676, 581465 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect Review URL: https://codereview.chromium.org/1640323002 Cr-Commit-Position: refs/heads/master@{#371835}
-
pkotwicz authored
We set enable_remoting=true in the command line on the official builders. Set enable_remoting=true as the default on Chromium as well. BUG=544298 R=lambroslambrou TBR=dpranke Review URL: https://codereview.chromium.org/1635373002 Cr-Commit-Position: refs/heads/master@{#371834}
-
ben authored
R=sky@chromium.org BUG= Review URL: https://codereview.chromium.org/1578473002 Cr-Commit-Position: refs/heads/master@{#371833}
-
jinho.bang authored
Current implementation ignores the clipping region when calling addHitRegion(). In the past, we had no way to get the current clip path from canvas state stack in Blink side but it's been possible since display list 2d canvas feature. BUG=387057 Review URL: https://codereview.chromium.org/1630683002 Cr-Commit-Position: refs/heads/master@{#371832}
-
ccameron authored
The logic to maintain a CALayer tree for partial swap support is complicated and should be removed, but that would compromise battery usage. Once the CoreAniamtion renderer is handling ~99% of the frames, we can remove it. In the mean time, isolate it. Create a CALayerPartialDamageTree to track the layer tree of partially swapped backbuffers. Do this in-place to minimize diffs, so that this patch can be reasonably reviewed. A follow-on patch will move it to a separate file. Slightly reorganize the logic so that CALayerPartialDamageTree matches the general structure of CALayerTree, where this a pending (not swapped) tree, a tree for each pending swap, and a tree for what is currently being displayed. BUG=533681 Review URL: https://codereview.chromium.org/1640093002 Cr-Commit-Position: refs/heads/master@{#371831}
-
prasadv authored
BUG=568661 Review URL: https://codereview.chromium.org/1641713003 Cr-Commit-Position: refs/heads/master@{#371830}
-
mbarbella authored
R=inferno@chromium.org BUG= Review URL: https://codereview.chromium.org/1640363002 Cr-Commit-Position: refs/heads/master@{#371829}
-
mvanouwerkerk authored
This size is as recommended in the addAction docs: http://goo.gl/ajjlE0 BUG=581336 Review URL: https://codereview.chromium.org/1643493002 Cr-Commit-Position: refs/heads/master@{#371828}
-
yfriedman authored
Adds a new gn flag exclude_unwind_tables that can be set via gn args. BUG=580374 Review URL: https://codereview.chromium.org/1638343003 Cr-Commit-Position: refs/heads/master@{#371827}
-
ben authored
Lock state is controlled by mash_shell, which will connect to the screenlock application to show a view. TBD: broadcasting lock state changes via a listener. TBD: a better mechanism for quitting an application. R=sky@chromium.org http://crbug.com/557398 Review URL: https://codereview.chromium.org/1637113003 Cr-Commit-Position: refs/heads/master@{#371826}
-
pfeldman authored
BUG=580337 Review URL: https://codereview.chromium.org/1636223002 Cr-Commit-Position: refs/heads/master@{#371825}
-
rdevlin.cronin authored
When we override a URL like chrome://bookmarks by an extension, it maps it to the chrome-extension:// url, but should still display the chrome://bookmarks url in the omnibox. crrev.com/5fafa5aa changed the way prefs were read, so it broke this. Fix the breakage, and add a unittest so that it doesn't happen again. BUG=579389 Review URL: https://codereview.chromium.org/1635663002 Cr-Commit-Position: refs/heads/master@{#371824}
-
mseaborn authored
Use the timer interface from base/ instead. This removes a dependency on nacl_time.h from native_client/, which is #included indirectly in utility.h. I tested this manually by adding some logging to print the times, and I checked that they're roughly the same before and after the change when running NaClBrowserTestPnacl.PPAPICore (which tests PNaCl translation). BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=2832 TEST=see above Review URL: https://codereview.chromium.org/1636303002 Cr-Commit-Position: refs/heads/master@{#371823}
-
wfh authored
BUG=514250 TEST=Make sure Flash still works and you can enable/disable it. Review URL: https://codereview.chromium.org/1633363002 Cr-Commit-Position: refs/heads/master@{#371822}
-