- 29 Sep, 2017 40 commits
-
-
Justin Novosad authored
When resource type is an AcceleratedStaticBitmapImage, the WaitSyncTokenCHROMIUM call in the release callback is skipped because the context_provider_wrapper_ is null. This change fixes the problem by setting the context_provider_wrapper_ field of the frame resource to the same context that own the image resource. BUG=769161 Change-Id: Ib05a0fa5a6a0d4dab676fcc27820d1171260a25d Reviewed-on: https://chromium-review.googlesource.com/685380Reviewed-by:
Olivia Lai <xlai@chromium.org> Commit-Queue: Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/heads/master@{#505388}
-
Andrew Grieve authored
NOTRY=true # Doesn't affect bots Change-Id: Ic3058e571cf4409a0af851e183eebbb22a62fea9 Reviewed-on: https://chromium-review.googlesource.com/692178Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#505387}
-
Aaron Leventhal authored
Bug: 770188 Change-Id: Iffe6636f58b8ad55b0c44ce90f9e93596e98e635 Reviewed-on: https://chromium-review.googlesource.com/692414 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#505386}
-
Sky Malice authored
Bug: Change-Id: Id0b90f07d3be8355a29063519a95c1f6ca5e710a Reviewed-on: https://chromium-review.googlesource.com/691152Reviewed-by:
Patrick Noland <pnoland@google.com> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#505385}
-
spqchan authored
Bug: 741138 Change-Id: I62e5475e3e4ec45797c4491e42d90ef0187491bf Reviewed-on: https://chromium-review.googlesource.com/691057Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Sarah Chan <spqchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#505384}
-
Lukasz Anforowicz authored
WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=lcwu@chromium.org Bug: 666525 Change-Id: I74bb2e240ca4a54ac280c8b8d770f88a34dd1f4f Reviewed-on: https://chromium-review.googlesource.com/689102Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#505383}
-
Eugene But authored
Bug: 585700 Change-Id: Ie237264dd235db8c499608fd0b53fb79d50c8859 Reviewed-on: https://chromium-review.googlesource.com/691100Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#505382}
-
Xiyuan Xia authored
- Make AuthSyncObserver observe SigninErrorController in addition to sync service so that auth errors caused by other services are caught as well. - Fix an edge case that OAuth2LoginManager marks valid oauth2 token when it thinks /MergeSession succeeds regardless of whether there is any auth error; Additional changes of reland: - Update FakeGaia to mint tokens for any scopes when there is an AccessTokenInfo with no |scopes| defined; - Update the failed tests to use that so that all auth requests succeed and AuthSyncObserver does not set invalid token status unexpectedly; Bug: 760610, 768949 Test: OAuth2Test.SetInvalidTokenStatus Change-Id: I8173ceec02ba036820439b7a66f09cac40f27d3d Reviewed-on: https://chromium-review.googlesource.com/685795Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#505381}
-
Alexis Hetu authored
A few transitions tests are flaky on Linux (dbg), so marking them as such. TBR=kbr@chromium.org Bug: 769879 Change-Id: Ia7231db555aa53e2627149d97b7f31c80039b13f Reviewed-on: https://chromium-review.googlesource.com/692614Reviewed-by:
Alexis Hétu <sugoi@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Alexis Hétu <sugoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#505380}
-
Lukasz Anforowicz authored
WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=tommycli@chromium.org Bug: 666525 Change-Id: Ia641a614a5129624424e1c81b0a945befddd8cd5 Reviewed-on: https://chromium-review.googlesource.com/688773 Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#505379}
-
David Roger authored
Bug: 767004 Change-Id: I23298bfcc294f2aeca35bba572246d0bdbf97b70 Reviewed-on: https://chromium-review.googlesource.com/684895Reviewed-by:
-
Brian White authored
This reverts commit c0cb3888. Reason for revert: The bug that this was intended to help find... has been fixed! Original change's description: > Do more validation around Renderer exit. > > This is an extension of cl/655922 that (temporarily) adds > instrumentation to Android builds to try to determine the source > of a core trampler. > > Bug: 744734 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation > Change-Id: I745eb4dcc40d59dfbcdf0e492e9bbd4aa31cab40 > Reviewed-on: https://chromium-review.googlesource.com/657804 > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Reviewed-by: Nick Carter <nick@chromium.org> > Commit-Queue: Brian White <bcwhite@chromium.org> > Cr-Commit-Position: refs/heads/master@{#501504} TBR=nick@chromium.org,asvitkine@chromium.org,bcwhite@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 744734 Change-Id: I742cad308f440ef4cb655dd6ae44545df9fd91a3 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Reviewed-on: https://chromium-review.googlesource.com/692314Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#505377}
-
Samuel Huang authored
Bug: 769737 Change-Id: Ib659c0ddc33d1ea5150d8dfe38d44a2f5f57f10c Reviewed-on: https://chromium-review.googlesource.com/689960 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#505376}
-
Matt Menke authored
This means that it only lives on on thread: The network thread, instead of jumping between the UI thread and the IO thread, since the network pref store lives on the IO thread, just like the network stack. A similar change was made to chrome/, as part of network servicification (Though in Chrome it's created by the NetworkService now). In a followup CL, I'll simplify HttpServerPropertiesManager to only support the case where the prefs thread is the network thread. Bug: 768884 Change-Id: I92c97e8e5fb3f5cab46f1c998b92eaec48a3db5f Reviewed-on: https://chromium-review.googlesource.com/687803 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#505375}
-
Chris Pickel authored
Split LogoService into LogoService interface and LogoServiceImpl to make it easier to provide fake data to the test. Bug: 768419 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I84639189d2db1b24a2e139936c99369352bab587 Reviewed-on: https://chromium-review.googlesource.com/690198Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Chris Pickel <sfiera@chromium.org> Cr-Commit-Position: refs/heads/master@{#505374}
-
Brian White authored
This reverts commit 4b9e9b62. Reason for revert: The bug that this was intended to help find... has been fixed! Original change's description: > Do histogram validation when processing Renderer death. > > There are hints that the corruption being observed happens around > the death of a renderer. Add (temporary) instrumentation inside the > processing of this event to see if this can be narrowed down further. > > Bug: 744734 > Change-Id: I63b2bfeaa96d2e8f8f299cd2c48cca130e72a8ec > Reviewed-on: https://chromium-review.googlesource.com/655922 > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Commit-Queue: Brian White <bcwhite@chromium.org> > Cr-Commit-Position: refs/heads/master@{#500443} TBR=asvitkine@chromium.org,bcwhite@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 744734 Change-Id: I44a5f0ffbcfffdd7eebf7409108ca42646a62761 Reviewed-on: https://chromium-review.googlesource.com/692354Reviewed-by:
-
Alexander Timin authored
Record a number of WebFrameSchedulers per RendererScheduler once per navigation. R=rkaplow@chromium.org,skyostil@chromium.org Change-Id: I0608ebf3c5808516c3888febda32a90c9f756b7b Reviewed-on: https://chromium-review.googlesource.com/680797Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#505372}
-
Brian White authored
The root cause of the Android "core trampler" has been found. This reverts the tracker used to record what objects were previously allocated in the memory block used by the object being overwritten. While the general "freed_object_tracker" module is generic and could be re-used should similar tramplers appear, it is best not to leave code in the build that is not actually being used. Feel free to ressurect this code in the future if there is a need for it. TBR=asvitkine (on vacation) Bug: 744734 Change-Id: I4f8224253365ac6c5e08f12401104593bf090588 Reviewed-on: https://chromium-review.googlesource.com/688043 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#505371}
-
Mike West authored
This reverts commit 05a16884. Reason for revert: renderer_side_navigation_browser_tests broke after this patch, starting in https://build.chromium.org/p/chromium.mac/builders/Mac10.11%20Tests/builds/18672. Original change's description: > Prerender: Add test confirming cookie behavior. > > The behavior of NoStatePrefetch and cookies can be confusing. This adds > NoStatePrefetchBrowserTest.PrefetchCookie which documents and validates > that cookies are set on all prefetches. > > Change-Id: I9c707989a07102286ae2d3e5cd19f2cbf7e29520 > Reviewed-on: https://chromium-review.googlesource.com/691663 > Commit-Queue: Matthew Cary <mattcary@chromium.org> > Reviewed-by: Alexandr Ilin <alexilin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#505359} TBR=mattcary@chromium.org,alexilin@chromium.org Change-Id: Ic5c9c203d0e1508d262ff420a2e27e2d73f831c8 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/691997Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#505370}
-
Bernhard Bauer authored
Screenshots: https://folio.googleplex.com/zine/chrome_home_promo Bug: 769003 Change-Id: I37e452762f6696f53bd7c21ee09a8af5edcf1f03 Reviewed-on: https://chromium-review.googlesource.com/690715Reviewed-by:
Nicolas Dossou-Gbété <dgn@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#505369}
-
Sigurður Ásgeirsson authored
This reverts commit a99f67ed. Reason for revert: https://crbug.com/770193 - IO assert on main thread in browser startup. Original change's description: > Move ComBase functions and HSTRING helpers to base/win. > > Bug: 734095 > Change-Id: Ib984cd7094cf4e075863d692acb59722114e3990 > Reviewed-on: https://chromium-review.googlesource.com/649528 > Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> > Reviewed-by: Greg Thompson <grt@chromium.org> > Reviewed-by: Peter Beverloo <peter@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Robert Liao <robliao@chromium.org> > Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> > Cr-Commit-Position: refs/heads/master@{#505163} TBR=dcheng@chromium.org,peter@chromium.org,toyoshim@chromium.org,finnur@chromium.org,robliao@chromium.org,grt@chromium.org Change-Id: I150e7825b141b21b37e14ee7ff7089150aa50abb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 734095 Reviewed-on: https://chromium-review.googlesource.com/692615Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#505368}
-
Pavel Kalinnikov authored
Bug: 763303 Change-Id: I0d9734c91fd1de5b16d2ae738b4a414acc55646d Reviewed-on: https://chromium-review.googlesource.com/657425Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Pavel Kalinnikov <pkalinnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#505367}
-
Fady Samuel authored
This reverts commit 05a16884. Reason for revert: These tests are failing on Mac NoStatePrefetchBrowserTest/NoStatePrefetchBrowserTest.PrefetchCookie/1 NoStatePrefetchBrowserTest/NoStatePrefetchBrowserTest.PrefetchCookie/0 https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.10%20Tests/builds/24380 Original change's description: > Prerender: Add test confirming cookie behavior. > > The behavior of NoStatePrefetch and cookies can be confusing. This adds > NoStatePrefetchBrowserTest.PrefetchCookie which documents and validates > that cookies are set on all prefetches. > > Change-Id: I9c707989a07102286ae2d3e5cd19f2cbf7e29520 > Reviewed-on: https://chromium-review.googlesource.com/691663 > Commit-Queue: Matthew Cary <mattcary@chromium.org> > Reviewed-by: Alexandr Ilin <alexilin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#505359} TBR=mattcary@chromium.org,alexilin@chromium.org Change-Id: Ie724b0f98cead53722bfba66c29759568fa0564a No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/692594Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#505366}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/11d773db..776de290 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: Icba06885aa4f6c93d7b093e6f5fc3c50d16355ea Reviewed-on: https://chromium-review.googlesource.com/691326Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#505365}
-
Daniel Bratell authored
Several test classes in scheduler have implemented AppendToVectorTestTask and this patch gives those unique namespaces to prevent them from clashing in jumbo builds. Bug: 745732 Change-Id: I265c5507cbcc0f934f5904cc62033443442163f9 Reviewed-on: https://chromium-review.googlesource.com/692018Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
-
Tibor Goldschwendt authored
Renders the UI of Chrome's VR browser to an offscreen context. The rendered image is then copied to an SkBitmap. This serves as the basis for pixel and performance tests. To execute the test and view the screenshot on Linux run: <Configure Linux target in out-linux/Release> ninja -C out-linux/Release -j2000 -l50 vr_common_unittests out-linux/Release/vr_common_unittests \ --gtest_filter=UiPixelTest.DrawVrBrowsingMode \ --num-retries 0 To execute the test on Android and view the screenshot run: <configure Android target in out/Release> ninja -C out/Release -j2000 -l50 vr_common_unittests <Make sure your phone is unlocked> out/Release/bin/run_vr_common_unittests \ --gtest_filter=UiPixelTest.DrawVrBrowsingMode \ --num-retries 0 Change-Id: Ib04c03ba36d63c9f50cd734b699130cc18cc8df6 Reviewed-on: https://chromium-review.googlesource.com/677556 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#505363}
-
kapishnikov authored
BUG=768883 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Idc4989dacd7390d1c5b58d3877cbfbc3a9818802 Reviewed-on: https://chromium-review.googlesource.com/690347Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Commit-Queue: Andrei Kapishnikov <kapishnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#505362}
-
proberge authored
This reverts commit f3bd7c65. Reason for revert: <INSERT REASONING HERE> Original change's description: > Extension content verification: unify "is from store" logic > > Bug: 766806 > Change-Id: I1a210ded77cc9ffdc0039fca097c6fdba7ff0131 > Reviewed-on: https://chromium-review.googlesource.com/677403 > Commit-Queue: proberge <proberge@chromium.org> > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#505092} TBR=lazyboy@chromium.org,rdevlin.cronin@chromium.org,proberge@chromium.org Change-Id: Id440f7f630d62b2a70ebee1774607219141d575c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 766806 Reviewed-on: https://chromium-review.googlesource.com/692075Reviewed-by:
proberge <proberge@chromium.org> Commit-Queue: proberge <proberge@chromium.org> Cr-Commit-Position: refs/heads/master@{#505361}
-
Eugene But authored
WebState::IsVisible replaces WebStateObserver's WasShown and WasHidden callbacks. Bug: None Change-Id: I9c608377a9d68de53527b27917a45b075d8e0a62 Reviewed-on: https://chromium-review.googlesource.com/685311 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Matthew Cary authored
The behavior of NoStatePrefetch and cookies can be confusing. This adds NoStatePrefetchBrowserTest.PrefetchCookie which documents and validates that cookies are set on all prefetches. Change-Id: I9c707989a07102286ae2d3e5cd19f2cbf7e29520 Reviewed-on: https://chromium-review.googlesource.com/691663 Commit-Queue: Matthew Cary <mattcary@chromium.org> Reviewed-by:
Alexandr Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#505359}
-
Tomasz Garbus authored
navigator.credentials.get() may be called from inactive tab. As of change 665119, showing the snackbar would be just suppressed. This CL stores PasswordForm, for which notification should be shown and, once tab is active again, shows the delayed notification. Also included an Earl Grey test case for this behavior. Here is a short screen recording from manual testing: https://drive.google.com/open?id=0B3hBvGfYBfe2Qml1X0pQRkJJQkE Bug: 435048 Change-Id: I1ff3cf6f3858126d32f17d09ec9117b8c5d1a96e Reviewed-on: https://chromium-review.googlesource.com/681376 Commit-Queue: Tomasz Garbus <tgarbus@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Tatiana Gornak <melandory@chromium.org> Reviewed-by:
Mike Baxley <baxley@chromium.org> Cr-Commit-Position: refs/heads/master@{#505358}
-
Eugene But authored
CRWWebController is private class from //ios/web and should not be used in //ios/chrome. Bug: 620465 Change-Id: I18a9ea2b225e48186b556bc5076f91442c6add8d Reviewed-on: https://chromium-review.googlesource.com/691038 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Tomasz Garbus authored
In this CL I added an image view on auto sign-in snackbar, displaying user's avatar. Until avatar is fetched, a placeholder image is shown. For network traffic annotation tag, I used this sample: https://cs.chromium.org/chromium/src/tools/traffic_annotation/sample_traffic_annotation.cc?l=120 Image view size is 24x24pt, fetched image is scaled accordingly. Screenshot with fetched icon: https://screenshot.googleplex.com/ruQRUXGOLN9.png Screenshot with placeholder: https://screenshot.googleplex.com/bYUnFR0pFru.png Screenshot with big (1024x1024) icon: https://screenshot.googleplex.com/4OwJuwCdj3J.png Bug: 435048 Change-Id: Ib74ef74716d81ab661ee2aa4b7246e27ebab3276 Reviewed-on: https://chromium-review.googlesource.com/681254 Commit-Queue: Tomasz Garbus <tgarbus@chromium.org> Reviewed-by:
-
Zentaro Kavanagh authored
- All files generated by libfuzzer. - Contains no code. BUG=chromium:22532 Change-Id: I4710f81f670b2a0287280ae04bb055c0fdc60093 Reviewed-on: https://chromium-review.googlesource.com/632876 Commit-Queue: Zentaro Kavanagh <zentaro@google.com> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#505355}
-
Tomasz Garbus authored
This CL introduces a notification view appearing on the bottom of the screen when user is automatically logged in. It also includes an EG test for this behavior. Here is a screenshot with the notification: https://screenshot.googleplex.com/267O2QU93YA.png iPhone X screenshots: vertical: https://screenshot.googleplex.com/0bitXQFqbR2.png horizontal: https://screenshot.googleplex.com/v0i7GbVwdBL.png Bug: 435048 Change-Id: Ic871148a970c36e8ce89922319720637a54cabbc Reviewed-on: https://chromium-review.googlesource.com/665119 Commit-Queue: Tomasz Garbus <tgarbus@chromium.org> Reviewed-by:
Rohit Rao (ping after 24h) <rohitrao@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#505354}
-
Guido Urdaneta authored
BUG=761622 Change-Id: I9428919041a0c5a0779bec18b911b253c82fece3 Reviewed-on: https://chromium-review.googlesource.com/690377 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#505353}
-
Maxim Kolosovskiy authored
Prompt should have labels: "Username" and "Password" Username and password will be on separate lines. See screenshots in the bug. Since both owners are OOO, but the CL should be landed before feature freeze, the CL will be landed only with TBR. TBR=vasilii@chromium.org Bug: 769666 Change-Id: I9f43163ff4286e6f7c3ef526572f3ca4ae971fab Reviewed-on: https://chromium-review.googlesource.com/690344 Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#505352}
-
Elly Fong-Jones authored
TabbedPane's focus indicator line should have been mirrored in RTL so it was under the focused tab, but it was not. Bug: 733115 Change-Id: I25e663300e75aee849aa3804a8e1a5d13f97acf8 Reviewed-on: https://chromium-review.googlesource.com/690796Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#505351}
-
Alexander Timin authored
R=skyostil@chromium.org Change-Id: Ia45c1c39077bbdd451af091d2589e1b11e77c617 Reviewed-on: https://chromium-review.googlesource.com/680796Reviewed-by:
-
Gauthier Ambard authored
The NTP view cannot use the safeAreaInsets property directly as it is snapshotted before being inserted in the view hierarchy, and the safe area is only available for views in the view hierarchy. This CL introduces a property mirroring the safe area once the view is in the view hierarchy. But it is also set up with the value used in the first frame, allowing the snapshot to be done as if the view was in the view hierarchy. Reland of https://chromium-review.googlesource.com/c/chromium/src/+/681942 It was reverted because the NTP wasn't working correctly when opening the recent tabs from the tool menu. Bug: 767869 Change-Id: Ibf57b84dd6aa4447101c0d0828e5f9af3d76670d Reviewed-on: https://chromium-review.googlesource.com/691727 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
-
