GitLab

The return line being outside the synchronized block allowed the cached
state to be reset to null before it was calculated.

BUG=470966

Review URL: https://codereview.chromium.org/1031413005

Cr-Commit-Position: refs/heads/master@{#322479}

$ gn gen out-gn
$ gn check out-gn //components/nacl/renderer/plugin/*

BUG=367595,376000
TEST=see above
R=bradnelson@google.com,brettw@chromium.org
TBR=bradnelson@chromium.org

Review URL: https://codereview.chromium.org/1034193003

Cr-Commit-Position: refs/heads/master@{#322478}

Expose <webview>.contextMenus.onShow
chrome EventTarget like object so one can "addListener" that can
preventDefault() to cancel bringing up <webview> context menu.

BUG=465733
Test=Open a chrome app with <webview>. E.g.
Load a <webview> in a chrome app, e.g.
the browser sample app:
https://github.com/GoogleChrome/chrome-app-samples/tree/master/samples/webview-samples/browser

Right click on the <webview>, context menu is expected to be shown.

Now open the app's inspector: from chrome://inspect, switch to "Apps" then select to inspect "Browser sample".

Register a listener to disable context menu:

document.querySelector('webview').contextMenus.onShow.addListener(function(e) {
  e.preventDefault();
});

Right click on the <webview> again, context menu should not show up.

Review URL: https://codereview.chromium.org/1026383003

Cr-Commit-Position: refs/heads/master@{#322477}

This CL added read_mtu into the signature of
BluetoothAudioSink::Observer::BluetoothAudioSinkDataAvailable and
modified corresponding tests.

BUG=441581
TEST=device_unittests --gtest_filter=*AudioSink*

Review URL: https://codereview.chromium.org/1034893002

Cr-Commit-Position: refs/heads/master@{#322476}

BUG=470231

Review URL: https://codereview.chromium.org/1031413004

Cr-Commit-Position: refs/heads/master@{#322475}

This adds histogram values for extension permission messages that
are missing.

BUG=None
TEST=None

Review URL: https://codereview.chromium.org/1037053003

Cr-Commit-Position: refs/heads/master@{#322474}

The latter is just a backwards-compatibility redirect to the former,
and I'm hoping to get rid of it.

Review URL: https://codereview.chromium.org/1036653004

Cr-Commit-Position: refs/heads/master@{#322473}

BUG=449116

Review URL: https://codereview.chromium.org/1034933002

Cr-Commit-Position: refs/heads/master@{#322472}

Also update from github in the process. Leaves externs currently pending
review as parts of Chrome already rely on them.

R=tbreisacher@chromium.org,hirono@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/1034873002

Cr-Commit-Position: refs/heads/master@{#322471}

With this CL, we ignore font files with .fon/.pfm/.pfb extensions while building our custom font collection.
MSDN Ref: http://goo.gl/TfCOA

BUG=439571
R=cpu@chromium.org,scottmg@chromium.org

Review URL: https://codereview.chromium.org/1034813003

Cr-Commit-Position: refs/heads/master@{#322470}

TimedWait(TimeDelta::Max()) should do the same as Wait() (although should not
be used, given that there is a dedicated method to do that).

More generally, TimedWait should accept random, unreasonable large timeouts.

BUG=465948
TESTS=base_unittests

Review URL: https://codereview.chromium.org/999753005

Cr-Commit-Position: refs/heads/master@{#322469}

This was found by looking at the output of gyp_flag_compare step in
http://build.chromium.org/p/chromium.linux/builders/Linux%20GN/builds/25653/steps/gyp_flag_compare/logs/stdio

BUG=461019
TEST=gn gen out-gn
R=isherman@chromium.org

Review URL: https://codereview.chromium.org/1032273005

Cr-Commit-Position: refs/heads/master@{#322468}

Remove HpackHuffmanAggregator header, implementation, test, and build rules.
Obsolete Net.SpdyHpackEncoddeCharacterFrequency histogram.  As the HTTP/2
standard is finalized, there is no longer a need to gather character
distribution statistics.

BUG=414758

Review URL: https://codereview.chromium.org/1017853004

Cr-Commit-Position: refs/heads/master@{#322467}

BUG=468902
TEST=trybots
R=dpranke@chromium.org

Review URL: https://codereview.chromium.org/1032543003

Cr-Commit-Position: refs/heads/master@{#322466}

BUG=470661

Review URL: https://codereview.chromium.org/1033003004

Cr-Commit-Position: refs/heads/master@{#322465}

BUG=463472

Review URL: https://codereview.chromium.org/972203002

Cr-Commit-Position: refs/heads/master@{#322464}

BUG=466848

Review URL: https://codereview.chromium.org/1036723003

Cr-Commit-Position: refs/heads/master@{#322463}

Previously, we collected PPS UMAs across all users. We created a throttler and used it in a 'simulated' mode.

Now that real PPS users exist, collect UMAs only on actual PPS users. This is accomplished by only creating a throttler when PPS is enabled.

BUG=470731

Review URL: https://codereview.chromium.org/1024493004

Cr-Commit-Position: refs/heads/master@{#322462}

MediaController.java is used by the android cast code which upstreamed from the private Chrome for Android repository.
It derives from open source Android source code,
specifically from one of the Android supportv4 samples, and has been
in the downstream repository for some time.

See the README.chromium file for more details.

BUG=315088

Review URL: https://codereview.chromium.org/1008603003

Cr-Commit-Position: refs/heads/master@{#322461}

R=cpu@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1033483003

Cr-Commit-Position: refs/heads/master@{#322460}

Mostly a mechanical change, though it involves extending the estimation
abilities of our TimeSource clients to provide estimates for times
outside of the current media time range.

BUG=110814, 439548
TEST=media_unittests still pass.

Review URL: https://codereview.chromium.org/1027553002

Cr-Commit-Position: refs/heads/master@{#322459}

BUG=NONE

Review URL: https://codereview.chromium.org/1018793003

Cr-Commit-Position: refs/heads/master@{#322458}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/b880d7f..e0b19d4

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=hcm@google.com

Review URL: https://codereview.chromium.org/1031303003

Cr-Commit-Position: refs/heads/master@{#322457}

[Icons NTP] Use GetVariationParamValue instead of experiment prefix to determine when large icons are enabled.

This is the standard pattern for adding a forcing flags in about://flags.

This also matches a google3 change that just landed which declares that parameter.

BUG=467712

Review URL: https://codereview.chromium.org/1032073003

Cr-Commit-Position: refs/heads/master@{#322456}

A non-broken but recently broken QUIC alternative service does not race for 0RTT
(because it is recently broken) but is still used (because it is not broken).
Upon successful connection, the service should be confirmed (marked as not
recently broken so that it can be used next time for 0RTT).

This CL adds this functionality and a test for it.  I locally verified that the
test fails without the rest of the change.

BUG=392575

Review URL: https://codereview.chromium.org/1035713003

Cr-Commit-Position: refs/heads/master@{#322455}

R=sergeyberezin@chromium.org
BUG=468335

Review URL: https://codereview.chromium.org/999933010

Cr-Commit-Position: refs/heads/master@{#322454}

BUG=468726

Review URL: https://codereview.chromium.org/1028933002

Cr-Commit-Position: refs/heads/master@{#322453}

This means that .localhost is always redirected to localhost in DNS
lookups, and |net::IsLocalhost| returns true for .localhost hostnames.

BUG=455825

Review URL: https://codereview.chromium.org/938093003

Cr-Commit-Position: refs/heads/master@{#322452}

This avoids a possibly janky delayed UI task for users that don't use
the app launcher.

After this, a user enabling the app list for the first time won't have a
warmed-up UI but that shouldn't matter because the education page
doesn't try to show it, and ShowForAppInstall() will warm it up.

BUG=431326, 292969

Review URL: https://codereview.chromium.org/1031223002

Cr-Commit-Position: refs/heads/master@{#322451}

Initialize the QuicDispatcher with a PacketWriter instead of an int fd.
QuicDispatcher::Initialize() used to take an fd which chromium does not make
use of. Instead, it should simply take a PacketWriter* which the caller
should be responsible for creating. Renamed Initialize() to
InitializeWithWriter() to reflect this. Removed the CreateWriter() method
from the QuicDispatcher and moved it to QuicServer.
Merge internal change: 89495510

Review URL: https://codereview.chromium.org/1031243002

Cr-Commit-Position: refs/heads/master@{#322450}

Show error message and disable Verify button if expiration date is in
the past. Logic is a direct port from CardUnmaskPromptViews.

BUG=448572

Review URL: https://codereview.chromium.org/1032193003

Cr-Commit-Position: refs/heads/master@{#322449}

Revert of Allow users to perform queries in the omnibox which begin with a search shortcut. (patchset #4 id:60001 of https://codereview.chromium.org/477873002/)

Reason for revert:
Caused a few OmniboxViewTest interactive_ui_tests failures (tests need updating too).

build:
http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/22466

test output:
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/501/steps/interactive_ui_tests/logs/OmniboxViewTest.AcceptKeywordBySpace

Looks like try jobs weren't run, only commit queue earlier. Unsure why commit queue didn't include this test - but it's recommended to run 'git cl try' on patches and review.

Original issue's description:
> Allow users to perform queries in the omnibox which begin with a search
> shortcut.
>
> Previously, if a user had (for example) configured a search shortcut of 'cs' which
> went to cs.chromium.org, they would be unable to (easily) start a query in the
> omnibox starting with 'cs'. Now, backspacing the keyword leaves the space after
> the keyword, allowing the user to continue typing without reenabling keyword
> mode.
>
> BUG=393371
> NOTRY=true
> R=pkasting@chromium.org
> TEST=type 'google.com ' into the omnibar and it should enter keyword mode.
> Press backspace and 'google.com ' will be left in the omnibar, rather than
> 'google.com'.
>
> Committed: https://crrev.com/709649607f13acb04e3850d5fd7fc1903c1becae
> Cr-Commit-Position: refs/heads/master@{#322429}

TBR=pkasting@chromium.org,sky@chromium.org,lenny.khazan@gmail.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=393371

Review URL: https://codereview.chromium.org/1030413002

Cr-Commit-Position: refs/heads/master@{#322448}

This CL removes:
* Unused support for logging in environment.py. The two current diagnostics messages will be replaced later if needed, after the code gets rearranged. The command-line support for log levels was not used (and not working last time I tried).
* Some unused code was removed, including WebsiteTest's SendEnterTo action.
* It simplified the way to obtain all tests names -- no longer needed to instantiate Environment.
* It removes adding ../../../../third_party/webdriver/pylib/ to sys.path -- this has not worked in most cases and was not needed (webdriver path has been added, from various sources, outside of the scripts in the framework we used).

It also removes some part of the unused ability to run all tests, which has recently been simulated by running all tests one by one outside of Python. That was to make the tests run in parallel. This is just a transitional state, and is described in the TODOs.

BUG=369521

Review URL: https://codereview.chromium.org/1022703004

Cr-Commit-Position: refs/heads/master@{#322447}

Improve PhoneFieldTest to test this.

Review URL: https://codereview.chromium.org/1031923003

Cr-Commit-Position: refs/heads/master@{#322446}

BUG=None
TEST=./build/gyp_chromium still works
R=sievers@chromium.org

Review URL: https://codereview.chromium.org/1038743003

Cr-Commit-Position: refs/heads/master@{#322445}

BUG=none

Review URL: https://codereview.chromium.org/1038003002

Cr-Commit-Position: refs/heads/master@{#322444}

Second step of a a three sided patch to move IdleTask to WebThread.
This is needed because we plan to introduce a scheduler for worker
threads, and they will use the WebTherad interface for posting idle
tasks.

Other patches https://codereview.chromium.org/1031843002/
and https://codereview.chromium.org/1029803002

BUG=463143

Review URL: https://codereview.chromium.org/1029343002

Cr-Commit-Position: refs/heads/master@{#322443}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/9737cee..1bb46ea

TBR=loislo@chromium.org,pkasting@chromium.org

Review URL: https://codereview.chromium.org/1037683003

Cr-Commit-Position: refs/heads/master@{#322442}

Adds red permanent error message banner between title and instructions.
Error messages passed to
CardUnmaskPromptViewBridge::GotVerificationResult() with
allow_retry == false are displayed. The banner is hidden until an error
message is passed to GotVerificationResult().

Note that the red banner does not extend to the full width of the dialog
(see screenshot attached to bug). Extending to the full dialog width
requires significant refactoring of the layout code, so I'm doing it in
two parts. This CL adds the banner functionality, and a separate CL will
fix the layout.

Dialog will re-layout to fit entire message if a multiline message is
set.

Also adds an ASCII art diagram of the dialog layout.

Screenshot attached to bug: https://code.google.com/p/chromium/issues/detail?id=448572#c15

BUG=448572

Review URL: https://codereview.chromium.org/1038503003

Cr-Commit-Position: refs/heads/master@{#322441}

BUG=470230

Review URL: https://codereview.chromium.org/997153004

Cr-Commit-Position: refs/heads/master@{#322440}