- 28 Apr, 2015 40 commits
-
-
thakis authored
Also fix initialization of weak_ptr_ which I had unintentionally broken in https://codereview.chromium.org/1103713003 BUG=303818, 467287 Review URL: https://codereview.chromium.org/1111903002 Cr-Commit-Position: refs/heads/master@{#327366}
-
groby authored
PermissionBubbleCocoa::CanAcceptRequestUpdate controls request coalescing. This change allows requests to be added to an existing permission bubble unless the user has moused over the bubble. BUG=452931 Review URL: https://codereview.chromium.org/895363007 Cr-Commit-Position: refs/heads/master@{#327365}
-
bruening authored
BUG=481231 TBR=earthdok@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/1110243003 Cr-Commit-Position: refs/heads/master@{#327364}
-
pranay.kumar authored
MessageLoopProxy is deprecated. This basically does a search and replace: MessageLoopProxy::current() -> ThreadTaskRunnerHandle::Get(). BUG=391045 Review URL: https://codereview.chromium.org/1103343003 Cr-Commit-Position: refs/heads/master@{#327363}
-
dtseng authored
With the 'enter' rule, we can simplify the output of list-like roles. Namely, ChromeVox can generalize its treatment of saying, x role with y items for a variety of roles. BUG=481583 TEST=chromevox_tests --gtest_filter=OutputE2ETest.* Review URL: https://codereview.chromium.org/1109983003 Cr-Commit-Position: refs/heads/master@{#327362}
-
msw authored
Exclude the mandoline target on android for now (no main). Rename the test targets to avoid naming conflicts... (android GN targets doesn't seem to respect output_name) Update the namespace for mojo::util::FilePathToFileURL call. See initial breakage at http://build.chromium.org/p/chromium.mojo/builders/Chromium%20Mojo%20Android/builds/384 The relevant CLs are: https://codereview.chromium.org/1109993002 https://codereview.chromium.org/1091513005 BUG=466129 TEST=Building mojo and mandoline for android passes. R=sky@chromium.org,ben@chromium.org Review URL: https://codereview.chromium.org/1115463002 Cr-Commit-Position: refs/heads/master@{#327361}
-
jeremyim authored
With the removal using the DataReductionProxyService class to perform the secure proxy check, there is no longer a need to post tasks to the UI thread. This effectively makes DataReductionProxyConfig an IO thread only class, and does not need to have pointers to task runners. BUG=472290 Review URL: https://codereview.chromium.org/1052583005 Cr-Commit-Position: refs/heads/master@{#327360}
-
skia-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/skia/+log/50cb76b..3862020 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=humper@google.com Review URL: https://codereview.chromium.org/1110153003 Cr-Commit-Position: refs/heads/master@{#327359}
-
agrieve authored
Timing for creating chrome_apk/classes.dex: No flag: real 0m10.767s user 0m16.480s sys 0m0.444s --num-threads=4 real 0m7.450s user 0m11.837s sys 0m0.606s --num-threads=10 (or 20, or 80) real 0m5.399s user 0m9.266s sys 0m0.420s Timings performed on a z620 workstation. BUG= Review URL: https://codereview.chromium.org/1109193002 Cr-Commit-Position: refs/heads/master@{#327358}
-
sclittle authored
Previously, the proxy pref would not be cleared during migration if the proxy pref was set to a Data Reduction Proxy that didn't match a currently configured DRP, e.g. if the pref was for "proxy.googlezip.net", but the configured DRP is "proxy-dev.googlezip.net". This change causes Chrome to clear the proxy pref if it contains any proxy with a host ending with ".googlezip.net". BUG=476610 Review URL: https://codereview.chromium.org/1104413003 Cr-Commit-Position: refs/heads/master@{#327357}
-
dalecurtis authored
Too many crashes and out of ideas for how to resolve this for right now; this at least provides the chance that these users might unhang themselves some time after the 2 minute hang timer. BUG=422522, 468074, 478932 TEST=start w/ and w/o hang monitor according to channel, flags. Review URL: https://codereview.chromium.org/1105083004 Cr-Commit-Position: refs/heads/master@{#327356}
-
dmazzoni authored
Published to the web store now to get updated translations. No other changes. BUG=none NOTRY=true TBR=dtseng@chromium.org Review URL: https://codereview.chromium.org/1109203003 Cr-Commit-Position: refs/heads/master@{#327355}
-
rtenneti authored
temporarily to measure its impact on battery. Will be measuring its impact in the following dashboard. https://chromeperf.appspot.com/report?masters=ChromiumPerf&bots=chromium-rel-mac9&tests=power.top_25%2Fidle_wakeups_total&checked=idle_wakeups_total%2Cref R=asvitkine@chromium.org BUG=426203 Review URL: https://codereview.chromium.org/1102333004 Cr-Commit-Position: refs/heads/master@{#327354}
-
tobiasjs authored
BUG=481955 Review URL: https://codereview.chromium.org/1114503003 Cr-Commit-Position: refs/heads/master@{#327353}
-
jochen authored
BUG=477690 R=skyostil@chromium.org,sky@chromium.org Review URL: https://codereview.chromium.org/1112573003 Cr-Commit-Position: refs/heads/master@{#327352}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/e68c882..b9db944 TBR=pdr@chromium.org,caseq@chromium.org Review URL: https://codereview.chromium.org/1108823005 Cr-Commit-Position: refs/heads/master@{#327351}
-
vadimt authored
BUG=456354 Review URL: https://codereview.chromium.org/1113463003 Cr-Commit-Position: refs/heads/master@{#327350}
-
jlklein authored
BUG=480762 Review URL: https://codereview.chromium.org/1105743003 Cr-Commit-Position: refs/heads/master@{#327349}
-
shrikant authored
We seem to have gathered enough data to find out debug further cause/reason for calling CloseHandle on already closed/invalid handle. There are couple of theories which need to be investigated further like policy ownership of TargetProcess and thread watching for JOB_OBJECT_MSG_ACTIVE_PROCESS_ZERO. CHECK seem to have introduced with CL https://codereview.chromium.org/1045513004 BUG=480639 R=cpu@chromium.org,grt@chromium.org Review URL: https://codereview.chromium.org/1108953003 Cr-Commit-Position: refs/heads/master@{#327348}
-
https://codereview.chromium.org/1115443002skyostil authored
TBR=sky@chromium.org Review URL: https://codereview.chromium.org/1112603003 Cr-Commit-Position: refs/heads/master@{#327347}
-
pranay.kumar authored
MessageLoopProxy is deprecated. This basically does a search and replace: MessageLoopProxy::current() -> ThreadTaskRunnerHandle::Get(). BUG=391045 Review URL: https://codereview.chromium.org/1111673003 Cr-Commit-Position: refs/heads/master@{#327346}
-
tbarzic authored
This would make the widget container code independent of the chrome APIs available/used by the extension embedding the widget. TEST=Verified installing file handlers and file system providers works BUG=477106 Review URL: https://codereview.chromium.org/1091943002 Cr-Commit-Position: refs/heads/master@{#327345}
-
tfarina authored
ERROR Dependency cycle: //gpu/command_buffer/service:service_sources -> //gpu/config:config_sources -> //gpu/command_buffer/service:service_sources The problem was that gpu/command_buffer/service already include from gpu/config, but gpu/config were also including from gpu/command_buffer/service for gpu_switches.h, creating the above dependency cycle. By moving the required switch down to gpu/config, we broke this dependency cycle. With that 'gn check' passes for gpu/config with the following command lines: $ gn gen out-gn/Debug $ gn check out-gn/Debug //gpu/config/* gpu/command_buffer/service needs more work to pass 'gn check' though. BUG=367595,376000 TEST=see above R=sievers@chromium.org Review URL: https://codereview.chromium.org/1103403002 Cr-Commit-Position: refs/heads/master@{#327344}
-
vitalybuka authored
GCD App needs to query devices for basic information. BUG=brillo:839 Review URL: https://codereview.chromium.org/1106183006 Cr-Commit-Position: refs/heads/master@{#327343}
-
ellyjones authored
This histogram tracks the time-weighted memory use incurred by SDCH dictionaries. This histogram is measured in units of byte-seconds per second. BUG=465873 Review URL: https://codereview.chromium.org/1051353003 Cr-Commit-Position: refs/heads/master@{#327342}
-
kcwu authored
Now ScopedPtrHashMap expect the 2nd parameter is scoped_ptr<T>. For example, old usage ScopedPtrHashMap<int, Value> new usage ScopedPtrHashMap<int, scoped_ptr<Value>> With this change, ScopedPtrHashMap support scoped_ptr's custom deleter. R=danakj@chromium.org, tzik@chromium.org BUG=none Review URL: https://codereview.chromium.org/1099383002 Cr-Commit-Position: refs/heads/master@{#327341}
-
nednguyen authored
patch from issue 1051323006 at patchset 40001 (http://crrev.com/1051323006#ps40001) BUG=475714 Review URL: https://codereview.chromium.org/1103553002 Cr-Commit-Position: refs/heads/master@{#327340}
-
pkotwicz authored
This CL prevents FaviconHandler from stopping iteration over a page's icon URLs if a download for one of the icon URLs previously returned a 404. In particular, this CL makes FaviconHandler::ScheduleDownload() call the download callback when FaviconDriver::StartDownload() does not start a download. This is important because the download callback is responsible for initiating the fetch for the data for the next favicon candidate. Sample scenario: Page HTML snippet: <link rel="icon" href="www.google.com/nothingtoseehere.png" /> <link rel="icon" href="www.google.com/favicon.ico" /> A previous download for "www.google.com/nothingtoseehere.png" returned a 404 (e.g. the user previously visited a different page which also makes use of www.google.com/nothingtoseehere.png) This CL makes FaviconHandler fetch data for "www.google.com/favicon.ico" despite the download for the first favicon candidate ("www.google.com/nothingtoseehere.png") having previously failed. BUG=474429 TEST=FaviconHandlerTest.MultipleFavicons404, FaviconHandlerTest.MultipleFaviconsAll404 Review URL: https://codereview.chromium.org/1079523005 Cr-Commit-Position: refs/heads/master@{#327339}
-
anandc authored
BUG=b/19609728 Review URL: https://codereview.chromium.org/1066003007 Cr-Commit-Position: refs/heads/master@{#327338}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/2d6802a..e68c882 TBR=pdr@chromium.org,caseq@chromium.org Review URL: https://codereview.chromium.org/1113623002 Cr-Commit-Position: refs/heads/master@{#327337}
-
timav authored
We discovered an audio playing site that often triggers the starvation condition during the playback. This introduces a race between Pause , starvation detecton and the MediaDecoderCallback. If starvation detection happens between Pause and the callback, we will do Prefetch and then stop the flow of packets, and won't update the audible status properly. This fix sets the audible status to false in OnPrefetchDone() if we realize that the flow will stop. BUG=474761 Review URL: https://codereview.chromium.org/1067153002 Cr-Commit-Position: refs/heads/master@{#327336}
-
rtenneti authored
properties are accessed. R=rch@chromium.org, asvitkine@chromium.org BUG=481618 Review URL: https://codereview.chromium.org/1096783005 Cr-Commit-Position: refs/heads/master@{#327335}
-
pauljensen authored
Previously onSucceeded() had to synchronize and turn around and request total bytes received. By passing it we avoid the synchronization. Review URL: https://codereview.chromium.org/1100923002 Cr-Commit-Position: refs/heads/master@{#327334}
-
oshima authored
in the same way as AshWTHX11/Ozone Fixed minor error introduced when cleaning up CL BUG=365662 TEST=UnifiedDesktopBasic will pass with real offscreen output surface Review URL: https://codereview.chromium.org/1113493002 Cr-Commit-Position: refs/heads/master@{#327333}
-
apacible authored
This custom polymer element shows some information from media that is currently cast to a device. It is styled after the current cast extension's route details view. BUG=464222 Review URL: https://codereview.chromium.org/1027253004 Cr-Commit-Position: refs/heads/master@{#327332}
-
lfg authored
This is needed because the RenderThread in the renderer process owns a reference to the RenderWidget, and that reference is only released when the RenderWidgetHost sends ViewMsg_Close, which happens on RenderWidgetHost::Shutdown. BUG=464764 Review URL: https://codereview.chromium.org/1052223008 Cr-Commit-Position: refs/heads/master@{#327331}
-
rdevlin.cronin authored
Instead of using the wrench menu as an anchor for an overflowed action's popup, slide the action out onto the main toolbar for the duration of the popup, and then slide it back in when the popup closes. On Mac, do the same for context menus (since we can't open a menu-in-menu on mac). Known issue: - On Mac, if you right click on an action that has slid out to show its popup, it will slide back in (but the context menu still appears). This is fixable, but requires a bit of a refactor. BUG=479387 Review URL: https://codereview.chromium.org/1105713002 Cr-Commit-Position: refs/heads/master@{#327330}
-
Stuart Morgan authored
This will be used by the next portion of ios/web/ code being upstreamed; separating into another CL since it contains a binary file. BUG=464810 R=eugenebut@chromium.org Review URL: https://codereview.chromium.org/1108373003 Cr-Commit-Position: refs/heads/master@{#327329}
-
clamy authored
This CL gives appropriate permissions to the RenderFrameHost on NavigationCommit. This allows to run browser tests backed by javascript files on disk with PlzNavigate enabled. BUG=475027 Review URL: https://codereview.chromium.org/1103253003 Cr-Commit-Position: refs/heads/master@{#327328}
-
dschuff authored
This pulls in the following Native Client changes: 4699f0e: (sbc@chromium.org) Always honor NACL_TMPFS_PREFIX in the environement 0178d59: (sbc@chromium.org) Add runtime test for availability of PROT_EXEC with shm_open 772dc1f: (dschuff@chromium.org) PNaCl: Update compiler-rt revision in pnacl/COMPONENT_REVISIONS 7408e00: (petarj@mips.com) PNaCl: Update binutils revision in pnacl/COMPONENT_REVISIONS 6937d61: (dschuff@chromium.org) Update revision for PNaCl Changes: https://chromium.googlesource.com/native_client/src/native_client/+log/87d5dd90911a0657c27574f78e86b7dfc4ad8b29..6937d61627c025d697f70b5a09d02f192a71e157 BUG= https://code.google.com/p/nativeclient/issues/detail?id=4155 TEST=browser_tests and nacl_integration CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_dbg_32_ng,linux_arm_compile,linux_nacl_sdk_build Review URL: https://codereview.chromium.org/1109153003 Cr-Commit-Position: refs/heads/master@{#327327}
-