- 01 Aug, 2018 16 commits
-
-
Ross McIlroy authored
BUG=866721 Change-Id: I90a280e0d59fbc9d258e3c42a7227348b06f1ef2 Reviewed-on: https://chromium-review.googlesource.com/1150527Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#579643}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/15016c7f..3895ea2a Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8fbeb5565f253119179b2988c0d53a21a4e520df Reviewed-on: https://chromium-review.googlesource.com/1156919Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#579642}
-
Peter Collingbourne authored
It's possible for SkTextBlob::Deserialize to return nullptr if we hit this line: https://cs.chromium.org/chromium/src/third_party/skia/src/core/SkTextBlob.cpp?l=742 This happens in a particular test case found by clusterfuzz and leads to a segfault during serialization. There appears to be code in skia that handles the possibility of an SkTextBlob being null, e.g. https://cs.chromium.org/chromium/src/third_party/skia/src/core/SkCanvas.cpp?l=25 However, there already seems to be an assumption within cc that a DrawTextBlob's SkTextBlob is non-null, e.g. https://cs.chromium.org/chromium/src/cc/paint/paint_op_buffer.cc?l=1952 https://cs.chromium.org/chromium/src/cc/paint/paint_op_buffer.cc?l=1722 So this patch causes the deserializer to reject null SkTextBlobs within DrawTextBlobs. Bug: 868968 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Iec29d2fc111f6c23f388e36b841fee27b37b06a9 Reviewed-on: https://chromium-review.googlesource.com/1157424Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#579641}
-
Robert Liao authored
BUG=459827 Change-Id: I93efa9cf7bf850326046c857121c978d8441e6c1 Reviewed-on: https://chromium-review.googlesource.com/1157486Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#579640}
-
Luciano Pacheco authored
Add "Add new services" menu item to Files app "gear menu" and change the behavior to: 1. Go directly to Webstore in case there isn't any provider/FSP installed. 2. Open "providers menu" when there is at least one provider/FSP installed, which is the old behaviour. Add a new command "new-service" to display the providers menu to be able open it from the gear menu. Change the gear menu item label to be "Add new service". Fix My files tests because "Add new services" isn't displayed on directory tree anymore. Bug: 682356, 869240 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ie9bf211c42a18b3717a72f40e57ceaade5958281 Reviewed-on: https://chromium-review.googlesource.com/1139944Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#579639}
-
Pete Williamson authored
OfflinePages are now saved to a public directory "/sdcard/Download/". However, the saving sometimes fails when the directory doesn't exist. This change checks for the existence of the directory, and creates it before the publish step. Bug: 869182 Change-Id: I3e0105c5ddb2df7a5fa9b57a5bf3ba7478af3b09 Reviewed-on: https://chromium-review.googlesource.com/1150406Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Dmitry Titov <dimich@chromium.org> Reviewed-by:
Yafei Duan <romax@chromium.org> Commit-Queue: Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/master@{#579638}
-
Gabriel Marin authored
The file was generated by autoconf from vendor/gperftools/tcmalloc.h.in, formatted with 'git cl format', and directly committed to the repository. BUG=724399,b:70905156 Change-Id: Id94ed5297bb73148b1715b0a77c5da3c2e04b136 Reviewed-on: https://chromium-review.googlesource.com/1130674Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Gabriel Marin <gmx@chromium.org> Cr-Commit-Position: refs/heads/master@{#579637}
-
Nicholas Verne authored
Returns true if any version still exists, even if incompatible with the current Chrome version. Bug: 862199 Change-Id: I604e16c92a06aca57aeaa8d05215819fce2daa13 Reviewed-on: https://chromium-review.googlesource.com/1144591 Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#579636}
-
Scott Violet authored
SystemTray isn't used, but Shelf is. BUG=none TEST=none Change-Id: I5f848fecf8f9882131d773c86973df15f7d8a3b6 Reviewed-on: https://chromium-review.googlesource.com/1157559Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#579635}
-
Xu Xing authored
SetChildNeedsSyncTokens always follows CreateChild in non unittest code. So merge it into create CreateChild. Bug: None Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I332182306e30c58ec3e7adcb7275a1e25898d330 Reviewed-on: https://chromium-review.googlesource.com/1154638Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Xing Xu <xing.xu@intel.com> Cr-Commit-Position: refs/heads/master@{#579634}
-
kristipark authored
Screenshot: https://screenshot.googleplex.com/53hB2LzA1Mj.png Bug: 867587 Change-Id: I7589715970a4a2f3c3a53805dadfe3026a21bb7a Reviewed-on: https://chromium-review.googlesource.com/1156001Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#579633}
-
dpapad authored
In this CL updating: - chrome://bluetooth-pairing - chrome://internet-config-dialog - chrome://internet-detail-dialog This adds some additional size to the binary, since both Polymer 1 and 2 HTML bundles are included. This is temporary and the Polymer 1 version will be removed once the migration is completed Bug: 862472 Change-Id: I39b28ab6ede92c37092184b5480bafb239844628 Reviewed-on: https://chromium-review.googlesource.com/1155481Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#579632}
-
Orin Jaworski authored
The larger cache prevents entity images from flickering while typing. The new size is expected to consume ~288 kilobytes, and is not changed for Android. Bug: 866580 Change-Id: Ifa53ffa82598335461c286547085620c122a44a1 Reviewed-on: https://chromium-review.googlesource.com/1150415Reviewed-by:
Peter Williamson <petewil@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Rachel Blum <groby@chromium.org> Commit-Queue: Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#579631}
-
Orin Jaworski authored
The location bar was getting a hover effect when the mouse was anywhere within (in omnibox, in bookmarks star, etc.) but having child view hover effects on top of the location bar hover effect was interfering with contrast. Now only the OmniboxViewViews will trigger the location bar hover effect, and mousing into other children will turn it off. This ensures contrast and is consistent with the interaction logic - specifically, the mouse cursor changing to a text insertion bar and the omnibox becoming clickable for edit. Bug: 866190 Change-Id: I7e04131a4a0d0533aeb13842fb6889ecee990750 Reviewed-on: https://chromium-review.googlesource.com/1153976 Commit-Queue: Orin Jaworski <orinj@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#579630}
-
Xiangjun Zhang authored
Some cast remoting sender tests rely on how mojo dispatches the method calls. This CL removed such dependency. Bug: 869547 Change-Id: I544b4d560f228e587b7cfe95ae658c5dee73b62e Reviewed-on: https://chromium-review.googlesource.com/1157521Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: Xiangjun Zhang <xjz@chromium.org> Cr-Commit-Position: refs/heads/master@{#579629}
-
Michael Spang authored
Move the giant buffer usage conversion switch/case out of line. Move all of the possible ways modifiers will not be used into one condition. Rather than using a loop for retrying allocation without GBM_BO_USE_SCANOUT, move the inner part into a function and call it again. Bug: 869206 Change-Id: I8d5b36a56bab8667077391c573e1d0b82f91d25f Reviewed-on: https://chromium-review.googlesource.com/1155917 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#579628}
-
- 31 Jul, 2018 24 commits
-
-
Johannes Henkel authored
The enabled bit is represented directly, the settings are actually thresholds, so they're a map from names to doubles. It would be possible to make each threshold a field, but I figure that's a bit less convenient to update when more thresdholds get added later. Change-Id: I15324b6b7bac0e72ad501965ca9477a265db38b3 Reviewed-on: https://chromium-review.googlesource.com/1157277Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#579627}
-
Ella Ge authored
This cl recovers pixel_expectations.py so that the tests are not expected to fail after rebaseline. Bug: 737777 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I3a26737dc7bb545a3009da19de3c528ea6e00b72 Reviewed-on: https://chromium-review.googlesource.com/1131634Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#579626}
-
kylechar authored
1. In GpuProcessHost::OnProcessCrashed() record the process crash first. This means the GPU mode fallback will happen before a new GPU process is started. 2. Don't call FallBackToNextGpuMode() if GPU process initialization fails for an unsandboxed GPU process. The unsandboxed GPU is only used for collect information and it's failure doesn't indicate a need to change GPU modes. Bug: 869419 Change-Id: I8bd0a03268f0ea8809f3df8458d4e6a92db9391f Reviewed-on: https://chromium-review.googlesource.com/1157164Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#579625}
-
Weidong Guo authored
Font size is larger than specs, so fix it by setting the correct font list. Bug: 869349 Change-Id: Ib3671c1236a87cadc94f1cd34fd9ada945754fd7 Reviewed-on: https://chromium-review.googlesource.com/1157112Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#579624}
-
Thomas Guilbert authored
Change-Id: Ibfe9c9a2bd4eb459717a28c6bf2837ecb53cbc7d Reviewed-on: https://chromium-review.googlesource.com/1145820 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Zhiqiang Zhang <zqzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#579623}
-
Dirk Pranke authored
The recent switch from running the webkit_layout_tests on 10.12 by default to 10.13 has revealed a few tests that were almost timing out before and are now timing out on 10.13 due to the slightly slower configurations. This CL marks the four tests as Slow to avoid this. virtual/outofblink-cors-ns/http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-simple.html virtual/outofblink-cors-ns/http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-synconworker.html virtual/outofblink-cors/http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-aborted.html virtual/threaded/fast/scrolling/overflow-scrollability.html TBR=fdegans NOTRY=true Bug: 869662 Change-Id: Ib22bc7c2aaca91ee8b699e99cbd22a8d419e9fe8 Reviewed-on: https://chromium-review.googlesource.com/1157536 Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#579622}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/45a4c41eda90..68be5dab98f6 git log 45a4c41eda90..68be5dab98f6 --date=short --no-merges --format='%ad %ae %s' 2018-07-31 buildbot@webrtc.org Roll chromium_revision 36ff521e..19a9e3bb (579363:579465) Created with: gclient setdep -r src/third_party/webrtc@68be5dab98f6 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ic44cf55c34e727ffa625a51a134db98814f02b8c Reviewed-on: https://chromium-review.googlesource.com/1156916Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#579621}
-
Yafei Duan authored
This reverts commit ef042f5e. Reason for revert: We don't want to skip pinning google.com as tile, per discussion with nickrad@. Original change's description: > [NTP tiles] Don't enable homepage tile if home page url is google.com. > > Homepage tile should not be added to Most Visited tiles if the homepage > url is google.com. > > Bug: 862786 > Change-Id: Icb42ce4fb5f0c26bece80b7a7dd82bfd8526bcb2 > Reviewed-on: https://chromium-review.googlesource.com/1152298 > Reviewed-by: Theresa <twellington@chromium.org> > Commit-Queue: Yafei Duan <romax@chromium.org> > Cr-Commit-Position: refs/heads/master@{#578788} TBR=twellington@chromium.org,romax@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 862786 Change-Id: Ifca7d377d5b3ff527cddbecafc63b3909c41cd53 Reviewed-on: https://chromium-review.googlesource.com/1157385Reviewed-by:
Yafei Duan <romax@chromium.org> Commit-Queue: Yafei Duan <romax@chromium.org> Cr-Commit-Position: refs/heads/master@{#579620}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/100f0ee2ceb7..44d40fafd233 git log 100f0ee2ceb7..44d40fafd233 --date=short --no-merges --format='%ad %ae %s' 2018-07-31 nednguyen@google.com Improve error message of unhandleable error 2018-07-31 sadrul@chromium.org Reland "rendering: Add pipeline metrics." 2018-07-31 dtu@chromium.org [pinpoint] Don't wrap quest name in status box header. Created with: gclient setdep -r src/third_party/catapult@44d40fafd233 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:869548,chromium:855328,chromium:868648 TBR=sullivan@chromium.org Change-Id: If13c6ea7fc05a6ae309af1c0de781fc9e558af60 Reviewed-on: https://chromium-review.googlesource.com/1156917Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#579619}
-
Chris Lu authored
- Moves GridViewCntroller inset adjustments in -viewDidAppear and -willTransitionToSize to -viewDidlayoutSubviews. The tradeoffs is that -viewDidLayoutSubviews is called many more times than the other two, hence the original choice to stay away from it. However, the current approach gives a glitchy-like UI experience when rotating. - Updates Remote Tabs insets with horizontal safe area of scroll view if not on the screen. Doesn't update insets if visible since it will then have the right safe area already. This is still a hack, but a more comprehensive coverage so that it never ends up encroaching the safe area. Video: https://drive.google.com/open?id=1jzP0ClCOn0uQTZC9hJ2g0FUWsF-nSuqV Bug: 868270, 868285, 868658 Change-Id: Ia50146e1be9dfdde74bbf3e7d6b6042168b2ce8a Reviewed-on: https://chromium-review.googlesource.com/1153391 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#579618}
-
Fabrice de Gans-Riberi authored
These tests have been flaky on CQ for a while. TBR=rogerta@chromium.org, dpranke@chromium.org Bug: 869364 Change-Id: Ib31a26fb7ff59f6202648739e745daab5e9b06f0 Reviewed-on: https://chromium-review.googlesource.com/1157261Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#579617}
-
Henrique Nakashima authored
This fixes a presubmit error: ** Presubmit ERRORS ** Unversioned PPB interface references found in PPAPI C++ wrappers: *************** ppapi/cpp/module.cc *************** Change-Id: Ic9ff58e2ce8ea591a507c75498b0be8bccb3a8aa Reviewed-on: https://chromium-review.googlesource.com/1157170Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#579616}
-
Xiaohan Wang authored
The original problem has been fixed in the latest Widevine CDM. Bug: 851027 Change-Id: I9aced3ea2152e33fcc8a5bcddc8a587c45dee6cc Reviewed-on: https://chromium-review.googlesource.com/1154087Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#579615}
-
Vlad Tsyrklevich authored
Bug: 866290 Change-Id: Ic5d175b3b854665f50781650406d599d09ee9849 Reviewed-on: https://chromium-review.googlesource.com/1157136Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Cr-Commit-Position: refs/heads/master@{#579614}
-
Nico Weber authored
lld is on by default on linux and windows now, so these were no-ops. Bug: none Change-Id: I391846d8ac7776aa45d47e394e76067fd7575051 Reviewed-on: https://chromium-review.googlesource.com/1156859Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#579613}
-
Johannes Henkel authored
Earlier, I presented an alternative to this, which I prefer, by storing the values in separate fields. It's in thic PR: https://chromium-review.googlesource.com/c/chromium/src/+/1157185 Change-Id: I52740475b18dfed26fb4753ba11aff7523bedc0c Reviewed-on: https://chromium-review.googlesource.com/1157248 Commit-Queue: Johannes Henkel <johannes@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#579612}
-
Yutaka Hirano authored
blink::ResourceRequest, blink::ResourceResponse and blink::ResourceLoaderOptions have CrossThreadCopier specializations in order to support main-thread proxied load in workers. Now it's gone, so this CL removes them. This CL also removes ThreadableLoaderTest for workers. Actually the mock system, WebURLLoaderMockFactoryImpl, is not capable of serving requests on a non-main thread, and these tests are working now just accidentally. ResourceResponse::was_fetched_via_proxy_ is removed as no one uses it. Bug: None Change-Id: I39c1e242abd56f16aa2fd3595aff2f5a5e174653 Reviewed-on: https://chromium-review.googlesource.com/1152632 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Dominic Farolino <domfarolino@gmail.com> Cr-Commit-Position: refs/heads/master@{#579611}
-
Matt Falkenhagen authored
This experiment is ready for testing on the Beta channel. Bug: 846235 Change-Id: Ibcaafcab93fced86a2831b6c7cb53b02bbc869db Reviewed-on: https://chromium-review.googlesource.com/1147891Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#579610}
-
Nicolas Pena authored
This CL changes the name of a PerformanceEntry to become a name. It should be noted that in general performance entries can be accessed from main or worker threads, so some care is needed. An exception to this is paint and longtask entries, and appropriate DCHECKs were added for those cases. Assessment of this change: Speed: AtomicString comparisons are faster but this CL increased the number of conversions between string types. So overall unclear, but likely insignificant speed changes. Memory: PerformanceEntry names are now shared so the memory usage should be improved by this change. Code complexity: increased (AtomicStrings are IMO harder to reason about than slightly simpler Strings). Bug: 852050 Change-Id: Iaee67c6bcd6123851a0f6657d12fb6b2c61cb5fc Reviewed-on: https://chromium-review.googlesource.com/1153608Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#579609}
-
Krishna Govind authored
R=cmasso@chromium.org Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I8deec54fb837351422b8543080bd9f26beb62bd6 Reviewed-on: https://chromium-review.googlesource.com/1157507Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#579608}
-
Scott Haseley authored
Change supported platforms to kOkAll for kStopNonTimersInBackground so we can experiment on desktop. Bug: 869565 Change-Id: I491eba6b0a8e11c2255b8ed58a0ea0f3e32454e1 Reviewed-on: https://chromium-review.googlesource.com/1157253Reviewed-by:
Shubhie Panicker <panicker@chromium.org> Commit-Queue: Scott Haseley <shaseley@google.com> Cr-Commit-Position: refs/heads/master@{#579607}
-
Daniel Rubery authored
Begin reporting password re-use on URLs which were traditionally not valid for reputation computation, in an attempt to catch phishing on these URLs. Bug: 865625 Change-Id: Ib7492b9b9988dd1aa084973994dcda25c258bf93 Reviewed-on: https://chromium-review.googlesource.com/1155709 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#579606}
-
Michael Spang authored
Change DrmFramebuffer from a virtual interface to a concrete wrapper for a DRM framebuffer. This is what used to be ScanoutBuffer and is all that is needed for modesetting. In particular, we don't need access to gbm_bo, skia surfaces backed by dumb buffer mmaps, or other bits from {Gbm,Drm}Buffer in the modesetting internals. DrmFramebuffer is composed into GbmBuffer and DrmBuffer so that we can still access framebuffers for those types when presenting a buffer. GbmBuffer and DrmBuffer are no longer refcounted after this change. Bug: 868010 Change-Id: I6d31b000b35bc4a6caa6280bee4156ca9b271bb9 Reviewed-on: https://chromium-review.googlesource.com/1155916 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#579605}
-
Vasilii Sukhanov authored
Currently ellipsis is added to the value but it should be just truncated. Bug: 869394 Change-Id: I68cee8a70a45564ace59512356489c195327ca1c Reviewed-on: https://chromium-review.googlesource.com/1156696Reviewed-by:
Tommy Martino <tmartino@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#579604}
-