- 24 Nov, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/784170929fae..185795f02ceb 2020-11-24 miu@chromium.org Fix supported_address_families DCHECK in ServiceInstance ctor. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I0754f5efae8b25c3be06437c9ca0047565fe7ec0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557907Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#830579}
-
Ehimare Okoyomon authored
Make strikethrough thickness relative to icon size and introduce a bias to shift the line to only one side of the transparent line, in order to match mocks. Screenshot: crbug.com/1077766#c106 Bug: 1077766 Change-Id: I0a4730d8aba05b6f266da1b0ba53dba254cc4000 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552861 Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#830578}
-
Yi Gu authored
The test http/tests/inspector-protocol/service-worker/network-extrainfo-main-request.js has been flaky for a while: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=blink_web_tests%20(with%20patch)&tests=http/tests/inspector-protocol/service-worker/network-extrainfo-main-request.js TBR=shimazu@chromium.org NOTRY=True Bug: 1087242 Change-Id: I6e2ee8020f2e67f0ca4f271929bad68776d5672f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558160Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#830577}
-
Alice Wang authored
This CL renames accountId to accountEmail to have consistent name for account email variable. Bug: 1131344 Change-Id: Id58ad100883473d136a9c6ccb3530cce138d0eab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554600Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#830576}
-
Nektarios Paisios authored
Clarifies the meaning of a document object and the names of methods that navigate to the boundaries of the whole content In the accessibility codebase, the word "document" has a confusing meaning. For a start, our definition of a "document" erroneously included an object with an ARIA role="document" even though what we really meant by the definition was the root of a web area. Our definition is not even compatible with what HTML considers to be the document object. Secondly, the method names in AXPosition that are used to navigate to the start / end of the whole content, such as the start / end of the whole webpage or PDF, were confusingly using the same "document" nomenclature. AX-Relnotes: n/a. R=dmazzoni@chromium.org, aleventhal@chromium.org Bug: 1049261 Change-Id: I06a5383bd6cfbfa9a51f96547d02b83a3ac210a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538175 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#830575}
-
Yi Gu authored
This test has been very flaky: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=chrome_public_test_apk%20(with%20patch)&tests=org.chromium.chrome.browser.omnibox.suggestions.mostvisited.MostVisitedTilesTest#keyboardNavigation_highlightingNextTileUpdatesUrlBarText TBR=ender@google.com Bug: 1152246 Change-Id: I2a7fc32342a8394fad75db05368e4a5b62382308 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557904Reviewed-by:
-
Yi Gu authored
The test has been flaky on CrOS. See linked bugs for details. TBR=josiahk@google.com Bug: 1150753 Change-Id: I6941f47c7951a4a93e94529675e370edcaa2a9ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557914Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/47a03e8743c9..3f77eb468fc4 2020-11-24 dmorilha@twilio.com fixing build for when HAVE_WEBRTC_VIDEO is not defined 2020-11-24 landrey@webrtc.org Fix authentication error while polling for upload results If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: If71039cb3a5bf20b4f9aa84f1d10d716e4e3fb12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557902Reviewed-by:
-
Renato Silva authored
Use the HTMLImports polyfill in OOBE to remove the dependence on HTML imports until everything can be fully migrated to JS modules/Polymer3. Bug: 1111387 Change-Id: I3c760bdc5d41f57e44927363d47a5a193edd7c34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522072 Commit-Queue: Renato Silva <rrsilva@google.com> Auto-Submit: Renato Silva <rrsilva@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#830571}
-
Ewann authored
This CL refactors EG2 tests related to the open in toolbar. The toolbar and the display of the activity view is now tested on a PDF file and a PNG image. It also Tests that the open in bar is correctly displayed when a compatible URL is loaded and tapping on the web view makes it appear or disappear. Bug: 1124310, 1146303, 1135805 Change-Id: I57f962a31a7e34a02ae37fb72bf649abb6fb74fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532004 Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#830570}
-
Thomas Tellier authored
There is no GAIA instance in the secondary login screen, leading to crashes each time a GAIA dialog is asked. This CL disables these requests. Bug: 1150357 Change-Id: If04f61fd07e461afc28e44ce77ecaa798afeed27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552395 Commit-Queue: Thomas Tellier <tellier@google.com> Reviewed-by:
-
Tina Wang authored
IncognitoModeAvailability enterprise policy specifies whether the user may open pages in Incognito mode in Google Chrome. When the policy is unset or set to 0(available), pages may be opened in Incognito mode. When the policy is set to 1(disabled), pages may not be opened in Incognito mode. When the policy is set to 2(forced), pages may be opened ONLY in Incognito mode. Bug: 1148825 Change-Id: Ia3c4b619289c537b05d565d8c3302c8790df87db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553149Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Tina Wang <tinazwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#830568}
-
Nicolás Peña Moreno authored
The current link is a go link, which only works on @google account whereas most perf sheriffs will be working from @chromium accounts, so using a direct link is better. Change-Id: I3a277a67733b6af06aa19c42e61a22e502cce936 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422188Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#830567}
-
Jan Wilken Dörrie authored
This change fixes the vertical alignment of the weak password explainer in the Weak Password Check on Desktop. Screenshots are in the linked bug: https://crbug.com/1151866#c2 Bug: 1151866 Change-Id: I0272c1e1f96a2a31ffdf7db0b9da8817913c197a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556683Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#830566}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1606165050-a3d889677a06d0e206b82027c298bfd0cf0af279.profdata to chrome-win64-master-1606196878-8e98c60eb2828a7469f5671822f6024fb48eb0e5.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I98e30e55b08beb711e41ba57b1e638c64796ec9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557777Reviewed-by:
-
Mikhail Khokhlov authored
Monitors the radio state every second while Chrome is in foreground to count the number of times the radio woke up from dormant state. This metric will be used to estimate the approximate power cost of waking the radio up depending on the signal strength. Running a check every second can potentially be expensive, so adding this under a feature flag. Bug: b/167544787 Change-Id: Ia523f1894f4debb53cbb6dcbd436d6c7e555d1a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484800 Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#830564}
-
Yi Gu authored
The two tests have been flaky according to FindIt. Please see linked bug for details. TBR=andypaicu@chromium.org Bug: 1150676 Change-Id: I5812ca6afa0e04449396a3caa1bd1138aadd421c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557908Reviewed-by:
-
Andrey Zaytsev authored
Bug: 1070620, 1078782 Change-Id: Id0dcd9491446ea8acdd5c752409dff4394c2ad5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557080 Auto-Submit: Andrey Zaytsev <andzaytsev@google.com> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Sean Harrison <harrisonsean@chromium.org> Commit-Queue: Martin Šrámek <msramek@chromium.org> Commit-Queue: Andrey Zaytsev <andzaytsev@google.com> Cr-Commit-Position: refs/heads/master@{#830562}
-
Guido Urdaneta authored
SubresourceFilterBrowserTest.DisallowedSubframeURLBlockedOnActivatedURL has been flaking repeatedly on Windows bots. Bug: 1152429 Change-Id: Ie1f1d5ccd2570d8d804869c8a15fdf2bed7ed42d TBR: blundell@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557081Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#830561}
-
Camille Lamy authored
Change-Id: Ic9f9e2aee6f6546b410eb654b1b5dfaaab4724e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556684Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#830560}
-
Swapnil authored
Many force installed extensions fail to install inside SandboxedUnpacker with error UNPACKER_CLIENT_FAILED error. We report a string that gives details about this error. We want to report this error detail through event based reporting. This CL is a pre work that reports detailed error to InstallStageTracker. Bug: b/173099675 Change-Id: I541ed65b209073bb9434db75567e94e955b4c64c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532082Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Saurabh Nijhara <snijhara@google.com> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Cr-Commit-Position: refs/heads/master@{#830559}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1606196878-31a6a989939947bbb9b6b52f3528a70f37f5b2e2.profdata to chrome-mac-master-1606218923-39c9d0a9fc77b1c3938c028a8199ea0790d9dbca.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I906d01766cb3c56d189d3cc672880ac07a976294 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557903Reviewed-by:
-
Greg Thompson authored
On Windows, ImportantFileWriter boosts its thread's priority for the moment it calls ::ReplaceFileW in the hopes that this will improve its chances of beating other processes (e.g., A/V scanners) that will try to open the files it needs. This change preserves the last error code coming out of a failure of ::ReplaceFileW for use in logging and metrics reporting. BUG=1145235 R=jdoerrie@chromium.org Change-Id: I1e275698c5c39fa7cfa97d6b3bf48e2023a8763f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556841 Commit-Queue: Greg Thompson <grt@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#830557}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1606196878-64b7b1e8929e5613baadbfb35b6857cd242016c0.profdata to chrome-linux-master-1606218923-9c6085eb8d1087e580649b9899e3b8b35853f279.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ie8b2bc246b50f10855c7758b022d9d11bdd2cece Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557901Reviewed-by:
-
Tanmoy Mollik authored
Change the button text from |No thanks| to |Skip|. Screenshot: https://crbug.com/1150422#c1 Bug: 1150422 Change-Id: Ice908f706abc9aeecaa2461b6705f0324ae7c35a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549943 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Alice Wang <aliceywang@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#830555}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/b5ac6d34a14c..784170929fae 2020-11-24 miu@chromium.org Bring openscreen::cast::ServiceInfo parsing/validation up-to-spec. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: Ieacac698430a05c4016a6b2b7e276a5738c13be7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557900Reviewed-by:
-
Alex Ilin authored
Bug: none Change-Id: I26b90e691dbe061977ccece3ad3235cad1b38716 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557078 Auto-Submit: Alex Ilin <alexilin@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#830553}
-
Egor Pasko authored
The mWaitForSharedRelros is not used. Deeper code inspection with lizeb@ reveals that it does not cause immediate problems to ignore the state of this member. For future improvements we should consider sending an empty bundle with an empty LibInfo and consuming it as usual, instead of guessing whether to expect this bundle. Bug: 979638 Change-Id: I1c3369e7bbb818c88da4b64239c918da3c1cda1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555120 Auto-Submit: Egor Pasko <pasko@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#830552}
-
Denis Kuznetsov authored
Bug: None Change-Id: I5c9bec776b6850d76f92b4bfd46215bd93f068cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554918 Auto-Submit: Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
-
Curt Clemens authored
The file preview icon on the discovery page and confirmation page needs to be grey whenever those pages are in an error state. This CL adds a |disabled| property to nearby-preview that when true applies a css class that makes the icon grey. Bug: b/163036847 Change-Id: I4a0f24a1ed9f013d499eb2dff9bf24064f0898e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554901Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Curt Clemens <cclem@google.com> Cr-Commit-Position: refs/heads/master@{#830550}
-
Nicolás Peña Moreno authored
Currently, AddLongTaskTiming()'s last 3 parameters are String instead of AtomicString. However, the values are ultimately stored as AtomicString and the parameters passed are already AtomicString. Looking at the impl of AtomicString, it is not a String, which means that we have to convert the AtomicString to String and then back to AtomicString. This CL fixes this. Bug: 1141632 Change-Id: I72db0b0bc2ca96f2b831e8faf195c22acb4be0f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555562Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#830549}
-
Harald Alvestrand authored
Bug: chromium:1151946 Change-Id: Ia11d3abdc9d11842995f74cfd5db6bb34fbac6e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555011Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#830548}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/35df41dad885..084b862ba31b 2020-11-24 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from a41860e8 to 013c962f (389 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jmadill@google.com Change-Id: I4c7945e26e09225625e8d0959e5fad2fd9e82d95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557535Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/d840c8fb5dc4..47a03e8743c9 2020-11-24 jakobi@webrtc.org Default enable sending transport sequence numbers on audio packets. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ic05cb403db2ed4428007b608de5753dd09f6e844 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557531Reviewed-by:
-
Egor Pasko authored
This reverts commit 37b4a2bf. Reason for revert: http://crbug.com/1152413 (new failures on the bfcache bot) Original change's description: > Reland Introduce BaseActivityTestRule to handle Activity starting/finishing > > Introduces a BaseActivityTestRule that allows tests to control whether > or not the Activity is finished after the test runs. > Also fixes some issues with Android's ActivityTestRule, like it not > handling LauncherActivities, and unnecessarily inheriting > UiThreadTestRule. > > Bug: 1146574 > Bug: 1151237 > Bug: 1151190 > Bug: 1151160 > Change-Id: I420939b0050c5abeb08bc554ee3d7e5976a32fda > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552249 > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Commit-Queue: Michael Thiessen <mthiesse@chromium.org> > Cr-Commit-Position: refs/heads/master@{#830388} TBR=yfriedman@chromium.org,mthiesse@chromium.org Change-Id: I17892fbff84811a93584dda385cbaee0faf1ee25 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1146574 Bug: 1151237 Bug: 1151190 Bug: 1151160 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556844Reviewed-by:
Egor Pasko <pasko@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#830545}
-
Irem Uğuz authored
This cl adds name field to CertProfile and updates the tests and serializer accordingly. Certificate name field will be necessary to show it on the UI for the associated bug. Bug: 1137523 Change-Id: Iefbe3f167a1e65ada7cfda7af858355a1e27c134 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543146 Commit-Queue: Irem Uğuz <iremuguz@google.com> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#830544}
-
Jianhui Dai authored
The constrain is not needed, as the method to detect supported hardware encoder profiles is implemented. Bug: 1119636 Change-Id: Ic3fe4f1ea319f9adc1391d6e0a2203c09264bbf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551624Reviewed-by:
Eugene Zemtsov <eugene@chromium.org> Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Cr-Commit-Position: refs/heads/master@{#830543}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8fb8d59ba581..c983c977f266 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC orphis@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: orphis@google.com Change-Id: Ibddbdee515a240bbb563ef89e312e9ef13fc0cb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557532Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#830542}
-
Glen Robertson authored
Bug: 1149277 Change-Id: I1611c7f01d885d54c7e9722311c9f9a44994c209 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554578 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Auto-Submit: Glen Robertson <glenrob@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#830541}
-
Philip Pfaffe authored
A DevTools change changes exported events causing the test to time out. R=szuend@chromium.org Bug: chromium:1152362 Change-Id: I6cb3f17519ad32615893639b93983c82c1a33947 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556862Reviewed-by:
Simon Zünd <szuend@chromium.org> Commit-Queue: Philip Pfaffe <pfaffe@chromium.org> Cr-Commit-Position: refs/heads/master@{#830540}
-
