GitLab

BUG=282725

Review URL: https://chromiumcodereview.appspot.com/23765003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221617 0039d316-1c4b-4281-b951-d872f2087c98

Once https://codereview.chromium.org/23848006/ has landed, we can remove the
webkit category, and leave only webkit.console.

R=nduca@chromium.org, tonyg@chromium.org
BUG=264308

Review URL: https://chromiumcodereview.appspot.com/23777006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221616 0039d316-1c4b-4281-b951-d872f2087c98

kPasteboardTypeFilePromiseContent simply does not work, and it's getting to be a pain working around its issues.

This reverts r219601 and r207414, and works around the original bug in a new way.

BUG=249271, 278515, 282916
TEST=fixes bug 282916, does not regress either bug 278515 or bug 249271

Review URL: https://chromiumcodereview.appspot.com/23775005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221615 0039d316-1c4b-4281-b951-d872f2087c98

The prefs are integrated into the PlatformVerificationFlow class.

BUG=chromium:270316
TEST=unit

Review URL: https://chromiumcodereview.appspot.com/23765004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221614 0039d316-1c4b-4281-b951-d872f2087c98

> Files.app: Let the PreviewPanel class control the visibility of the preview panel.
> 
> Originally, PreviewPanel is not used from any code.
> This CL lets the FileManager class and the FileSelectorHandler class use the PreviewPanel class to control the visibility of preview panel.
> 
> BUG=284215
> TEST=manually
> R=yoshiki@chromium.org
> 
> Review URL: https://codereview.chromium.org/23464030

TBR=hirono@chromium.org

Review URL: https://codereview.chromium.org/23903018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221613 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221612 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
R=toyoshim@chromium.org
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/23606017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221611 0039d316-1c4b-4281-b951-d872f2087c98

BUG=256576

Review URL: https://chromiumcodereview.appspot.com/23601004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221610 0039d316-1c4b-4281-b951-d872f2087c98

the client private key is a 1024-bit RSA or DSA key.

Older Estonian ID cards with 1024-bit RSA keys cannot sign SHA-256
hashes.

1024-bit DSA keys were formerly specified to be used with SHA-1 only.

R=agl@chromium.org,rsleevi@chromium.org
BUG=278370
TEST=manual testing by someone who has an older Estonian ID card

Review URL: https://chromiumcodereview.appspot.com/23596013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221609 0039d316-1c4b-4281-b951-d872f2087c98

When in DWM, the DefWindowProc handling of WM_NCPAINT was clearing (to
white) in the area that was not yet drawn. When the wndclass's
background is set to COLOR_WINDOW this is avoided and the frame
appears to stay more "solid".

This only affects the white flash in the NC area in the linked bug,
not the grey in the content area. We should also consider reverting
the compositor.cc change from here http://crrev.com/192657 as it seems
to make resize a bit laggier.

R=sky@chromium.org
BUG=177115

Review URL: https://chromiumcodereview.appspot.com/23596011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221608 0039d316-1c4b-4281-b951-d872f2087c98

shader code is one example where abs() without std:: is acceptable.
But we still would like to generally keep the PRESUBMIT check that
enforces all uses of abs() and related functions must be prefixed
with "std::"

So in order to prevent PRESUBMIT annoyances when we modify shader
code or other similar situations, the regular expression for the
presubmit is modified to recognize a "// NOLINT" comment. In that
case, it ignores any un-prefixed abs() usage.

BUG=261900

Review URL: https://chromiumcodereview.appspot.com/23591027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221607 0039d316-1c4b-4281-b951-d872f2087c98

CTRL+C will make IEDriverServer exits and leaves IE running.
During cleanup, kill the IE processes when needed.

BUG=282480

Review URL: https://chromiumcodereview.appspot.com/23572025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221606 0039d316-1c4b-4281-b951-d872f2087c98

Remove unnecessary includes, forward decls

BUG=272460

Review URL: https://chromiumcodereview.appspot.com/24020002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221605 0039d316-1c4b-4281-b951-d872f2087c98

BUG=178559

Review URL: https://chromiumcodereview.appspot.com/23569010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221604 0039d316-1c4b-4281-b951-d872f2087c98

BUG=269131
TEST=manual

Review URL: https://chromiumcodereview.appspot.com/23536019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221603 0039d316-1c4b-4281-b951-d872f2087c98

It returned the fullscreen window (if any) in the active workspace,
and a workspace could contain only one fullscreen window at most.
However, now there's only one desktop workspace which can contain
multiple fullscreen windows.

To follow the past state, it would be better to return the active
fullscreen window first.

TEST=covered by ash_unittests
R=oshima@chromium.org, sky@chromium.org
BUG=None

Review URL: https://chromiumcodereview.appspot.com/23534049

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221602 0039d316-1c4b-4281-b951-d872f2087c98

Bubble may not be dismissed for the first 3 seconds (except by clicking on the Learn More link). The length of the grace period is subject to future tweaking.

BUG=282671

Review URL: https://chromiumcodereview.appspot.com/23533030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221601 0039d316-1c4b-4281-b951-d872f2087c98

extracted common functionality from CloudPrintAccountManager and
PrivetApiCallFlow into a common class CloudPrintBaseApiFlow.

BUG=286157

Review URL: https://chromiumcodereview.appspot.com/23530007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221600 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://chromiumcodereview.appspot.com/23757025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221599 0039d316-1c4b-4281-b951-d872f2087c98

A malicious site could create content that could pop up the rAc dialog and get
the user to accidentally click submit. This CL disables the submit for a brief
time (1s), so such clicks wouldn't trigger the submit.

BUG=241897

Review URL: https://chromiumcodereview.appspot.com/23717029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221598 0039d316-1c4b-4281-b951-d872f2087c98

Fixing various problems with the new shelf layout in conjunction with the blue tray background on bubble activation

There was a mismatch between the hover animation & the activation state. I cleaned up the activation code, removed the old override functions, and added comments on various places which had none yet.

BUG=274105
TEST=visual

Review URL: https://chromiumcodereview.appspot.com/23531033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221597 0039d316-1c4b-4281-b951-d872f2087c98

Re-enabled TouchEditableImplAuraTest.TouchCursorInTextfieldTest with two
fixes:
 - Changed focus_textfield() in touch_seleciton.html to collapse
   selection after focus, since nothing should be selected after
   focusing the textfield.
 - Added a wait between dragging the handle and getting the cursor
   position in the test to be sure that the cursor position is updated
   completely.
Also, added some logs in the test so that if it failed again, more data
is available for investigation.

BUG=235991

Review URL: https://chromiumcodereview.appspot.com/23823004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221596 0039d316-1c4b-4281-b951-d872f2087c98

BUG=229009
TEST=none
TBR=sky@chromium.org (chrome/browser changes OWNER check), samarth@chromium.org

Original CL: crrev.com/22403003
Reverted CL: crrev.com/23475011

Review URL: https://chromiumcodereview.appspot.com/23789005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221594 0039d316-1c4b-4281-b951-d872f2087c98

Using the new skia utility makes the canvas stack export much simpler

BUG=

Review URL: https://chromiumcodereview.appspot.com/23789003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221593 0039d316-1c4b-4281-b951-d872f2087c98

BUG=280320

Review URL: https://chromiumcodereview.appspot.com/23461013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221592 0039d316-1c4b-4281-b951-d872f2087c98

If available, this CL changes RenderingStatsInstrumentation to use
ThreadNow() instead of HighResNow(). ThreadNow should provide a more accurate
benchmark as it will exclude time when the thread is descheduled.

BUG=280638

Review URL: https://chromiumcodereview.appspot.com/23523026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221591 0039d316-1c4b-4281-b951-d872f2087c98

Use AppendExtraBrowserArgs everywhere.

BUG=269131
TEST=trybot
TBR=kbr@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23512005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221590 0039d316-1c4b-4281-b951-d872f2087c98

The WebRequest API on webviews moved to a new location.

BUG=

Review URL: https://chromiumcodereview.appspot.com/23493021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221589 0039d316-1c4b-4281-b951-d872f2087c98

BUG=244688
TEST=Windows7 with MS-IME and GoogleJapaneseInput. Windows8 desktop using onscreen keyboard with MS-IME and GoogleJapaneseInput. The known issue about onscreenkeyboard and MS-IME still happens. https://src.chromium.org/viewvc/chrome?revision=220221&view=revision

Review URL: https://chromiumcodereview.appspot.com/23445020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221588 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/23478023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221587 0039d316-1c4b-4281-b951-d872f2087c98

Changes to enable annotating known leaks in blink so that leak sanitizer doesn't raise alarm.
Removing addition of StringImpl::createStatic from tools/lsan/suppressions.txt
This patch currently just handles Leak Sanitizer only. The changes for Heap Checker would be done in a follow up patch.

BUG=268258
TEST=Running content_unittests with Leak Sanitizer enabled.
Output of Leak Sanitizer before the fix: http://pastebin.com/niDgRNAQ
Output of Leak Sanitizer after the fix: http://pastebin.com/v6hF43Lj

Review URL: https://chromiumcodereview.appspot.com/23460014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221586 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/23456019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221585 0039d316-1c4b-4281-b951-d872f2087c98

This cuts down total AutofillDialogViews layout time by about half (!).

BUG=285996, 272402

Review URL: https://chromiumcodereview.appspot.com/23526021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221584 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://chromiumcodereview.appspot.com/23453036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221583 0039d316-1c4b-4281-b951-d872f2087c98

Previously NetworkMonitor required that a callback is passed to the 
Create() method. It was hard to use and inconsistent with other APIs. 
Added new UpdateNetworkList() method which accepts a 
CompletionCallback to be called when network list changes.

BUG=281781

Review URL: https://chromiumcodereview.appspot.com/23453025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221582 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://chromiumcodereview.appspot.com/23452019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221581 0039d316-1c4b-4281-b951-d872f2087c98

This prevents a crash when Chrome shuts down immediately and 
AppShimHostManager is destructed before InitOnFileThread is run.
Note this means AppShimHostManager can stay around longer than
BrowserProcessPlatformPart during initialization.

BUG=242941

Review URL: https://chromiumcodereview.appspot.com/20065004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221580 0039d316-1c4b-4281-b951-d872f2087c98

Originally, PreviewPanel is not used from any code.
This CL lets the FileManager class and the FileSelectorHandler class use the PreviewPanel class to control the visibility of preview panel.

BUG=284215
TEST=manually
R=yoshiki@chromium.org

Review URL: https://codereview.chromium.org/23464030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221579 0039d316-1c4b-4281-b951-d872f2087c98

As of version 2.7 Jinja2 depends on the MarkupSafe module.
http://jinja.pocoo.org/docs/intro/#markupsafe-dependency

We are already using Jinja2 v2.6 as a template engine for code generation
in Blink, and we'd like to upgrade it to v2.7.1, for various improvements.
MarkupSafe used to be part of Jinja2, but as of v2.7 has been factored into
a separate module, thus we need to add it separately.

For reference, MarkupSafe (and Jinja2) are also included as third-party libraries in Google App Engine.
https://developers.google.com/appengine/docs/python/tools/libraries27

Blocking:
Issue 23506004: Update Jinja2 (Python template library) to 2.7.1 + add OWNERS
https://codereview.chromium.org/23506004/

Source:
https://pypi.python.org/packages/source/M/MarkupSafe/MarkupSafe-0.18.tar.gz
MD5: f8d252fd05371e51dec2fe9a36890687
SHA-512:
0438ddf0fdab465c40d9afba8c14ad346be0868df654c11130d05e329992d456
a9bc278551970cbd09244a29c77213885d0c363c951b0cfd4d9aa95b248ecff5

Review URL: https://chromiumcodereview.appspot.com/23445019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221578 0039d316-1c4b-4281-b951-d872f2087c98

When logging an Action which refers to an incognito URL to the database
using the normal (non-testing) policy, clear the URL fields entirely.
Do not even leave an indication that an incognito URL had been present,
as was done previously.

This change was requested as part of the privacy review for the
extension watchdog.

BUG=244841

Review URL: https://chromiumcodereview.appspot.com/23432006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221577 0039d316-1c4b-4281-b951-d872f2087c98