- 31 Jul, 2020 40 commits
-
-
Jonathan Ross authored
This reverts commit 5c8c9a69. Reason for revert: Two Vulkan angle_perftests have begun crashing consistently with this change in the blame range. Reverting to confirm if this is the cause. Otherwise there is also an Angle roll in the range. crbug.com/1111764 Original change's description: > vulkan: reuse gl semaphores > > For passthrough, with extension EGL_ANGLE_display_semaphore_share_group, > semaphores are shared globally. > For GLES2Decoder, all GL contexts are in the same shared group, so > semaphores are also shared globally. > So we can reused GL semaphores cross GL contexts. > > Bug: 1004772 > Change-Id: I1d23cdc991b2e99d6fe70fdd0560c97dafe73e7c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319368 > Commit-Queue: Peng Huang <penghuang@chromium.org> > Reviewed-by: Jonathan Backer <backer@chromium.org> > Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#793398} TBR=penghuang@chromium.org,backer@chromium.org,vasilyt@chromium.org Change-Id: I63953b02f7f06a6e77a3266e3fc4eadee2f882f3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1004772 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332677Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#793591}
-
Irina Fedorova authored
Bug: 377410 Change-Id: Id6bb117f757c37d153637301be89f01560513a32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316203 Commit-Queue: Irina Fedorova <irfedorova@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#793590}
-
Dylan Cutler authored
identifability study. We prefer using this pattern over casting the string to a sequence of bytes, and we can also delete the private method I added for the casting. Bug: 973801 Change-Id: Ida8b71addf1b473b4b9d5b33b0df9c89fa36a5c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329912Reviewed-by:
Caleb Raitto <caraitto@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Dylan Cutler <dylancutler@google.com> Cr-Commit-Position: refs/heads/master@{#793589}
-
Dan Elphick authored
Renderer Scheduler trace events now use the location of the TraceableState/TraceableCounter to generate the local ID instead of all using the address of the MainThreadSchedulerImpl. This is done by removing the object_ field from TraceableState/TraceableCounter and just using "this" to generate the ID. Change-Id: I33f126b23e1f4f149d939e08c09843b695a2073a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324121Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#793588}
-
Robbie Gibson authored
This CL migrates to use the new asynchronous clipboard APIs when determining which search menu items to show. To handle asynchronous updates to the popup has a few steps. First, the popup menu table view controller now updates its preferred content size when its items are reloaded. This allows the containing popup menu view controller to listen to this change through UIKit container methods. The popup view controller can then inform the popup menu presenter that the preferred content size of the content has changed. The presenter then updates the constraints for the menu itself. Bug: 1110849 Change-Id: I1c30ce46ab811b4e29379eddaf3babc489b1ed6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324383 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#793587}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ba362087..01ef15ed Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ifa2e43876b5bdb99547365e42ec243df8a038348 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331859Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793586}
-
Clemens Arbesser authored
This CL removes the direct dependency of service_impl on |client|. All relevant code has been moved into the new client_context. Allowing to inject the client_context in the constructor of service_impl allows the construction of services with empty client contexts. Most importantly, since service_impl no longer holds a reference to the client, it is enforced that it can't pull in any sensitive information. Bug: b/160859107 Change-Id: Ifba193bbe78f3f26feaa17e60e699f117586437d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2326671 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Marian Fechete <marianfe@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#793585}
-
Nohemi Fernandez authored
Current sign-in test class names are inconsistent with existing code across Chrome iOS. Update these before proposing new APIs. Bug: 1103274 Change-Id: I5d8940d44f21ec047d6399087af44466231903c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330010 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#793584}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/cbd5bee81dc6..07ef703f1646 2020-07-31 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from c6e6597c4f51 to 2aaa8653da4f (5 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: tobine@google.com Change-Id: Ia2e0a7c47e7d846f4f60a687982b243ffe3a2559 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332537Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793583}
-
Himanshu Jaju authored
This is a reland of 5528fce5 Original change's description: > Read attachments from introduction > > Reads text and file attachments from introduction frame and appends > them to the share target. > > Bug: 1085068 > Change-Id: I0198a9edcfa5d8c7691514072c50577ff3d72428 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320599 > Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> > Reviewed-by: Alex Chau <alexchau@chromium.org> > Cr-Commit-Position: refs/heads/master@{#793136} Bug: 1085068 Change-Id: If5e4ae5c631e14c4a074937156278f97c82bc477 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329635 Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#793582}
-
Rakina Zata Amni authored
With crrev.com/c/2121522, some main-frame same-site navigations will result in a new BrowsingInstance, SiteInstance, RenderFrameHost, RenderView, etc. This CL updates expectations of navigation-related content_browsertests under contents/ that didn't expect a change of RenderFrameHosts etc. on same-site main frame navigations. This CL does not include: - Updates for content/ unittests and non-navigation-specific tests, which are handled in crrev.com/c/22100358 and crrev.com/c/2210174 - Updates for tests under chrome/, components/ and layout tests (fixed in other CLs) - Fix to ensure order of unload handlers on same-site cross-RFH navigations (will be fixed on a future CL) - Fix to ensure WebPreferences are carried over for cross-RFH same-site navigations (will be fixed on a future CL) For more details, see doc: https://docs.google.com/document/d/1lHdkKLUe8H6ZP6ALwj-dsus7oYcuc93HkSCHCcerItg/edit?usp=sharing Bug: 977562 Change-Id: I1ae0545526ba1399fcab32f10322b572223ac4ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2195872 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#793581}
-
Henrik Boström authored
This will likely stop flaking when https://chromium-review.googlesource.com/c/chromium/src/+/2323359 lands. But let's wait for the follow-up CL https://chromium-review.googlesource.com/c/chromium/src/+/2330014 to land when we pass Perfect Negotiation WPTs before we enable the test again just to be sure... TBR=hta@chromium.org Bug: chromium:1060083 Change-Id: Ic52f2e06f637d005e0f1fd83fcfdab82d2731296 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332577Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#793580}
-
Alex Ilin authored
The CL adds ProfileThemeUpdateServiceBrowserTest. The tests check that the cached values in ProfileAttributesStorage are actually updated when the browser theme changes. Bug: 1102384 Change-Id: I50fff36d21d641cd808a0d05d6f4fb0456ecadef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330054 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#793579}
-
Vasiliy Telezhnikov authored
For WebView the render target is provided by hwui (except when we use intermediate FBO to support stenil) and we don't know whether it supports alpha or not. So we assume always RGBA format Change-Id: Icbc3464961147a172e767d1ebdc8f7b9944479ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329918Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#793578}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ibaccc59ec49ff64fa97b861ffe2d9d294cda3608 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332539Reviewed-by:
-
Saurabh Nijhara authored
As per current behaviour, unmanaged users are neither logged out of the session nor shown any update required notifications. But some admins might want to enable these for unmanaged users too. Hence, the new requirement is to add a boolean flag to enable the admins to control this behaviour for unmanaged users on their enterprise enrolled devices. This device policy is only applicable to ChromeOS. This CL adds this support to the policy. If the flag is unset or set to false, there is no change in the behaviour. If it is set to true, unmanaged sessions receive update required notifications and force log out, whenever applicable as per policy. Bug: 1109543 Change-Id: I90f75dfb9bb425b0d598104b807ce6ba65768b01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319606Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Saurabh Nijhara <snijhara@google.com> Cr-Commit-Position: refs/heads/master@{#793576}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1596167865-32b4d770ba98a451b62d0d6d996f9d383e4ffbb8.profdata to chrome-win32-master-1596171509-d368534e2598d7e86852dfa3435d6200fa4b1623.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I63ef9f8aedca0e06481151fafe91bcd1fc072742 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332393Reviewed-by:
-
Mikhail Khokhlov authored
This reverts commit 9b369b62. Reason for revert: The underlying issue has been fixed, the flakiness should disappear now. Original change's description: > [Sheriff]: Disable flaky TracingControllerTest.ProcessesPresentInTrace. > > BUG=1107612 > TBR=primiano@chromium.org > > Change-Id: Iea8a925f79b364bb7d603061c4e4e50fc0f62fed > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308913 > Reviewed-by: Karan Bhatia <karandeepb@chromium.org> > Commit-Queue: Karan Bhatia <karandeepb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#790205} TBR=primiano@chromium.org,karandeepb@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1107612 Change-Id: I2738878a6f61443a42be0e07e746c2916f720d8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317798Reviewed-by:
Mikhail Khokhlov <khokhlov@google.com> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Cr-Commit-Position: refs/heads/master@{#793574}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/eca19c68df38..06f2818574c9 2020-07-31 aerotwist@chromium.org Use event to trigger Network Panel reveal & filter If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Icb7e50aae6ea54b3685bfd07402eba9a275cf41d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332536Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ee8c246be71e..7d627545cbb4 2020-07-31 deadbeef@webrtc.org Revert "Pass NetworkMonitorFactory through PeerConnectionFactory." 2020-07-31 philipp.hancke@googlemail.com frame encryptor: remove note about not being production ready If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I40d86db2af89abf6946b784b708a609d9177abc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332540Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f8ef67b87b41..08057456d373 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC koerber@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1103833 Tbr: koerber@google.com Change-Id: Ic63bc661fec9b5b0bf08750c53c1592578d48ed7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332394Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793571}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c3794dd52778..2ebb6ba9000e 2020-07-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from fd60950e59a3 to cbd5bee81dc6 (14 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: borenet@google.com Test: Test: Test: Compile NBA2K20 MEC with MSVCTest: Test: angle_perftests --gtest_filter="TracePerfTest.Run/*nba*" Change-Id: Ic1dced6e0090b6ca388b0cedc16f51d127a2c88a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332538Reviewed-by:
-
Titouan Rigoudy authored
As discussed over email, this will make it easier to thread through HttpCacheTransaction. It also makes it easier to mock out the endpoint for testing in crrev.com/c/2260423. Bug: chromium:986744 Change-Id: I749d795afc0b6e50b7095391dac27becf968cd77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299234 Commit-Queue: Titouan Rigoudy <titouan@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#793569}
-
Himanshu Jaju authored
- Move Type to a new mojo file to avoid cyclic dependendency - Add dependency from ShareTarget to mojom and vice versa Bug: 1085068 Change-Id: I0e358270afda02758c303967ee6b6f5b4fbce8c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330025 Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#793568}
-
Peng Huang authored
This is a reland of 0b825660 Original change's description: > ExternalVkImageBacking: reuse more VkSemaphores. > > This CL change SharedImageRepresentationSkia::BeginScoped*Access()'s > definition to not pass semaphores's ownership to caller. So the caller > will not release any semaphores, so shared image backings can reuse or > release them. > > Bug: 1004772 > Change-Id: Idfbcf61571a56be6acc8c80ee838ff0e119ba8bf > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323562 > Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> > Commit-Queue: Peng Huang <penghuang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#793261} Bug: 1004772 Change-Id: I2e3d41a29f2f3f45daf0d37cd09df2884a1b9189 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331293 Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#793567}
-
rbpotter authored
Adding a skeleton sidebar element with bookmarks/thumbnails icon buttons and placeholder divs for the two views. Bug: 1110756 Change-Id: I34b452bcc21a331c2eec88c15e794922b3124344 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324558Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#793566}
-
My Nguyen authored
Need to make this method const for its use in another const method in RenderWidgetHostViewAura in https://crrev.com/c/2326556 Bug: 1109074 Change-Id: Ic5c6b49bd75b402233fb1ff1d98cca044cd6b5c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332081Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#793565}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c07c0c93..ba362087 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib60707b6e6dba4279f601a5ca6c0e314e5734b1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332496Reviewed-by:
-
Monica Basta authored
This CL adds depth to the history.state. Depth is used to determine whether to navigate back or to navigate to the main route 'ProfilePickerMainView'. Bug: 1063856 Change-Id: Iacf322426f842377833cf3245f761d35662698b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2312836Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#793563}
-
Richard Knoll authored
When a settings or snooze button handler of the MessageView deletes |this| synchronously, we can't access any local fields anymore. This CL fixes that by getting a weak ptr to check if |this| is still valid after calling the MessageView. Bug: None Change-Id: I8153a4c56fe5b5c91eafd5f9d1cdbcbc3f58857a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328858Reviewed-by:
Tim Song <tengs@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#793562}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1596153340-6d725ede4117dca447ca41731e1643697c638085.profdata to chrome-win64-master-1596174933-c71437d8a30297882573ea069b38258c9e90f721.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com Change-Id: I405bc141cd9527d87fd24d24ffadb4a5269fc0bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332392Reviewed-by:
-
Miyoung Shin authored
This is a reland of f7d812d9. Reason for revert: org.chromium.android_webview.test.VisualStateTest#testVisualStateCallbackWhenContainerViewDetached__multiprocess_mode was flaky Fix : Fire the swap callback in QueueReportTimeSwapPromise::DidActivate if synchronous compositing is enabled on Android WebView. Original change's description: > Convert FrameMsg_VisualStateRequest to mojo > > This CL converts FrameMsg_VisualStateRequest to FrameWidget Mojo message > and FrameHostMsg_VisualStateResponse to the return callback of > FrameWidget mojo message. > > The legacy IPC message sent a single IPC with the multiple sub IPC > messages in reply, but this CL invokes each mojo message's callback > queued in the queue when the frame swap has occurred. > > This CL also includes to > - add WidgetCompositorHost interface bound on the compositor thread. > - move the implementation of |visual_state_callbacks_| from > RenderFrameHost to RenderWidgetHost. > - introduce WidgetSwapQueue queuing |id| having the same source > frame number to invoke the callbacks. > > Bug: 1071588 > Change-Id: If8c4db40be397921d19ca6a9a9287760879f3ff1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2178480 > Commit-Queue: Miyoung Shin <myid.shin@igalia.com> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Dave Tapuska <dtapuska@chromium.org> > Cr-Commit-Position: refs/heads/master@{#789884} Bug: 1071588 Change-Id: If7bfaa21277da199632e5c6ec748b54cea7eef58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309317Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
-
Rouslan Solomakhin authored
Before this patch, Chrome would attempt to download a payment method manifest from https://play.google.com/billing, which is a reserved URL for pointing to the invoking Trusted Web Activity and should not be dereferenced. This patch prevents downloads of any manifests for an Android payment app whose default payment method identifier is an app store payment method identifier. After this patch, Chrome does not attempt to download a payment method manifest from https://play.google.com/billing. Bug: 1099683 Change-Id: I3799d0486a7404ea0095b0c59a3d2467efd5b09f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329404 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#793559}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/747a820a7d69..c3794dd52778 2020-07-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 08a3cc4cfbaa to aa5bd7657e6c (3 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: borenet@google.com Change-Id: Icf2ee536d0a3960c123dc37a38b5c48a95762806 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332384Reviewed-by:
-
chrome://tracingSami Kyostila authored
Use scoped_refptr instead of shared_ptr. Bug: b/158460807 Change-Id: I99a98247bb74b7a1e1743a9f0609185ab2929663 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329538 Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#793557}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 0579e73f. With Chromium commits locally applied on WPT: 6d63b58a "Split iceGatheringState tests into separate files & update expectations" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: eae@chromium.org, szager@chromium.org: external/wpt/intersection-observer NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Change-Id: I3da788724b11df2b60f249d611d1084451b65f53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331858Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793556}
-
Sami Kyostila authored
Fix a crash when running multiple Perfetto integration tests in the same process. We need to avoid hanging on to task runners from previous task environments between test runs. Bug: 1110847 Change-Id: I26b0274c5cddb37a88292cfa6ad474f17148a402 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329893 Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Stephen Nusko <nuskos@chromium.org> Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#793555}
-
Lingqi Chi authored
Non-test code outside "services/network" should not depend on this directory directly. This CL cleans up all such disallowed dependencies from DEPS files in chrome/browser/extensions. But since there is no workaround to replace some private implementations with public ones, this CL also special cases them by adding them to specific_include_rules lists. Tbr: karandeepb@chromium.org Bug: 1049894 Change-Id: I6d47f656ef75c6bf3e907bc4dadc64932d6c2c77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2322427 Commit-Queue: Lingqi Chi <lingqi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#793554}
-
Alan Cutter authored
Change-Id: If0429ea349a174d4520c59ccf9dc5091707fd6f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895016 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#793553}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1596160292-be7478816f9ea1c3a3e60ecafceb33fda007c691.profdata to chrome-win32-master-1596167865-32b4d770ba98a451b62d0d6d996f9d383e4ffbb8.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com Change-Id: I21aa4c1a68477eec5d46ee29ff437024919d0972 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332380Reviewed-by:
-
