- 29 Aug, 2018 40 commits
 - 
- 
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/7dfd811ec106..8972cd776e13 git log 7dfd811ec106..8972cd776e13 --date=short --no-merges --format='%ad %ae %s' 2018-08-29 dtu@chromium.org [pinpoint] Add temporary mapping from Buildbot to LUCI builders. 2018-08-29 simonhatch@chromium.org Pinpoint - Escape names when creating test path 2018-08-29 simonhatch@chromium.org Reland "Pinpoint - Include doc link in bug comment." 2018-08-29 pasko@chromium.org dashboard: replace assert_called_once() 2018-08-29 zmo@chromium.org Remove node_runner from telemetry isolate 2018-08-29 dtu@chromium.org [pinpoint] d3-based heatmap and histogram. Created with: gclient setdep -r src/third_party/catapult@8972cd776e13 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:790075,chromium:863861,chromium:878777,chromium:872521 TBR=sullivan@chromium.org Change-Id: I17642df1db4953b723db72b7b52caaf3a97d8538 Reviewed-on: https://chromium-review.googlesource.com/1195862Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#587303}
 - 
Christian Fremerey authored
Bug: 877690 Change-Id: Ideeb349eed59c8b2106894b6d4f9971f3ea702f8 Reviewed-on: https://chromium-review.googlesource.com/1194872Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Commit-Queue: Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#587302}
 - 
David Black authored
Per change in product requirement, toggling Assistant should have different behavior depending on state. Previously: - When visible, toggling would close Assistant. - When invisible, toggling would show Assistant. Now: - When invisible, toggling will show Assistant. - When minimized, toggling will expand Assistant. - Otherwise, toggling will close Assistant. Bug: b:113279161 Change-Id: Id2e39f495711d6b12e938c3c76576603d2f2df3b Reviewed-on: https://chromium-review.googlesource.com/1195817Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#587301}
 - 
Eric Karl authored
VR Scrolling tests want to know about all page offset changes, whether or not these impact browser UI. To allow for this in tests, we now call WebContentsUtils.reportAllFrameSubmissions. Change-Id: If3dd017b0709b1f0719e81129af7e2b94aa1d11a Reviewed-on: https://chromium-review.googlesource.com/1194332Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#587300}
 - 
Scott Violet authored
tooltip_controller_unittest and window_reorder_unittest mostly just work with mus. There are a couple of things that need to be disabled, but for the most part they just work. Also adds comment as to why some tests are not in views_mus_unittests. BUG=NONE TEST=this is a test only change Change-Id: I198894fe7b8b7ca08d826ba2db2af1bde0e0a274 Reviewed-on: https://chromium-review.googlesource.com/1195815Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#587299}
 - 
Bailey Berro authored
Prevents an issue once enabling SMB by default where the SmbService ctor runs before the DBusThreadManager is properly initialized. This only happens during tests. Bug: chromium:757625 Change-Id: Id25265a7a9b763c5ea1ab59106df366dda4fd309 Reviewed-on: https://chromium-review.googlesource.com/1195644Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#587298}
 - 
Morten Stenshorne authored
TBR=cbiesinger@chromium.org, kojii@chromium.org Bug: 591099, 635619, 797591, 864156 Change-Id: Ibb3e27415a4b1e32055c9f2d156d3f36ca676085 Reviewed-on: https://chromium-review.googlesource.com/1194368Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#587297}
 - 
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/df4880942b7d..7d15aafdbdf8 git log df4880942b7d..7d15aafdbdf8 --date=short --no-merges --format='%ad %ae %s' 2018-08-29 xixuan@chromium.org cbuildbot: Set suite_scheduling=False for tryjob. 2018-08-29 saklein@chromium.org update_manifest_remotes: remove obsolete script. 2018-08-29 saklein@chromium.org generate_delta_sysroot: Remove obsolete script. Created with: gclient setdep -r src/third_party/chromite@7d15aafdbdf8 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I3e8ab4d7db2bc2dd645a671f5e766767e0911ac4 Reviewed-on: https://chromium-review.googlesource.com/1195061Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#587296}
 - 
Alex Moshchuk authored
This is a reland of https://crrev.com/c/959346 with an additional fix for cross-site navigations between sites covered by the same hosted app. The fix modifies site URLs for effective URLs to also include the non-translated site in the hash. This ensures that when multiple sites translate to the same effective app URL, they still have distinct site URLs. This ensures proper process swaps when navigating among these sites. Original description: Previously, hosted apps were exempt from LockToOrigin() even in --site-per-process mode. That meant that hosted apps were not subject to enforcements such as not allowing access to cookies, passwords, or local storage of other sites. Worse, it meant that hosted apps could arbitrarily share a process (e.g., when over process limit), even if they covered different web sites with --site-per-process. This CL starts locking hosted apps to their underlying web origin. If a frame commits a navigation to URL http://foo.com, which is part of a hosted app X's web extent, the process for that frame will be locked to http://foo.com. Note that the SiteInstance for this frame will still use a site URL based on the effective URL (i.e., chrome-extension://<ext_id_for_X>/), but the origin lock will not be based on effective URLs. This requires plumbing to compute the origin lock as a site URL that does not use an effective URL, and to plumb it into various places that make process model decisions, such as RPHI::IsSuitableHost(). Bug: 811939, 794315, 791796 Change-Id: I32cc54f3ee12ed5762272e5cfe43bd5eca94e2eb Reviewed-on: https://chromium-review.googlesource.com/959346 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#583895} Reviewed-on: https://chromium-review.googlesource.com/1194724 Cr-Commit-Position: refs/heads/master@{#587295}
 - 
Cole Winstanley authored
Fixed usage example; had the wrong command line args for the second command. Bug: chromedriver:2501 Change-Id: I9e851ed96faf35c448dab7a5d16a3bb8b05d4326 Reviewed-on: https://chromium-review.googlesource.com/1195853Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Cole Winstanley <cwinstanley@google.com> Cr-Commit-Position: refs/heads/master@{#587294}
 - 
Dan Sanders authored
VdaVideoDecoder requests VDA capabilities at each construction. While it would be possible to plumb GPUInfo to VdaVideoDecoder, the expectation is that this information will not be computed at startup in the future. This CL caches the results in GpuVideoDecodeAcceleratorFactory using a static variable. Bug: 877803 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I639febd1230763077824006ee6427ba43c5fa529 Reviewed-on: https://chromium-review.googlesource.com/1192138Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#587293}
 - 
Sarah Hu authored
Bug: 875540 Change-Id: I9825bb9cefb642ed8e3e4bd3587e065f026eb923 Reviewed-on: https://chromium-review.googlesource.com/1194980Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org> Cr-Commit-Position: refs/heads/master@{#587292}
 - 
manuk authored
Bug: 865611 Change-Id: I8f527872ea1916ea326c1e44e3d6fd1361eab3f6 Reviewed-on: https://chromium-review.googlesource.com/1195810Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#587291}
 - 
Etienne Pierre-doray authored
This CL uses ScopedBlockingCall to mark blocking calls in /chrome/browser/spellchecker. This CL was created by replacing calls to AssertBlockingAllowed() with instantiations of ScopedBlockingCall(MAY_BLOCK). I kindly ask the reviewer to make sure of the following: - ScopedBlockingCall is instantiated in a scope with minimal CPU usage. If this is not the case, ScopedBlockingCall should be instantiated closer to the blocking call. See scoped_blocking_call.h for more info. Please let me know when/where the blocking call happens if this needs to be changed. - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See BlockingType for more info. While I assumed MAY_BLOCK by default, that might not be the best fit if we know that this callsite is guaranteed to block. - The ScopedBlockingCall's scope covers the entirety of the blocking operation previously asserted against by the AssertBlockingAllowed(). This CL was uploaded by git cl split. R=rouslan@chromium.org Bug: 874080 Change-Id: I82ae2e1ea937cce2e4bc815ac66f236081b82960 Reviewed-on: https://chromium-review.googlesource.com/1191531Reviewed-by:Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#587290}
 - 
Christopher Grant authored
Ideally, the UI feature module would use these libraries as they would base and others. However, both of them use (or would need to use) a newer method of exporting symbols for the component build. It's not clear yet what the best way to adapt that export system is. In the meantime, just sever the dependency since it's easy to do. BUG= Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I447a508e8d1e487cd77bf66956201361b60ed0cd Reviewed-on: https://chromium-review.googlesource.com/1195806Reviewed-by:
Aldo Culquicondor <acondor@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#587289}
 - 
Jun Choi authored
Observe Bluetooth adapter for power change and notify embedder when BluetoothAdapter is powered on/off and when BluetoothAdapter::SetPower() invokes success callback. Bug: 877344 Change-Id: Id437050028929d76a72a9412d26213dc38a1b6ef Reviewed-on: https://chromium-review.googlesource.com/1192420 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#587288}
 - 
Morten Stenshorne authored
Bug: 878309 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ie048813575b614d9692ac999932a22e42f405eef Reviewed-on: https://chromium-review.googlesource.com/1193857Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#587287}
 - 
Xiaoqian Dai authored
The new selector item's size should match the dragged window's size. Bug: 878172 Change-Id: Ie1f8e28dc2e400e935e0db9f3b6666564adfe31f Reviewed-on: https://chromium-review.googlesource.com/1195752 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#587286}
 - 
David Bertoni authored
The CL adds additional data when incrementing and decrementing the keepalive count, to allow for easier debugging of the counts. Bug: 695711 Change-Id: Ibd078259c34cc11f786b3f895dc63c6452025604 Reviewed-on: https://chromium-review.googlesource.com/1168139 Commit-Queue: David Bertoni <dbertoni@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#587285}
 - 
Weidong Guo authored
Changes: Since OnActiveUserPrefServiceChanged must be called after OnSessionStateChanged, so we only need to keep the former one. This also fixed the crash caused by app list view being null. Bug: 878803 Change-Id: I3744e21bbdb30a1065027999c81b2477d391667b Reviewed-on: https://chromium-review.googlesource.com/1195742Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#587284}
 - 
Mustafa Emre Acer authored
Also rename any related classes. In the future we might show suggestions for non-IDN navigations as well, this is to prepare for that. Bug: 843361,847662 Change-Id: Id614decdc1b108923d6934c66b99274a2477e0a3 Reviewed-on: https://chromium-review.googlesource.com/1187227 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#587283}
 - 
Katie D authored
With --enable-experimental-accessiblity-features, too many a11y tools are included in the OOBE screen and it flows behind the button. This makes the accessibility tools list scroll. Bug: 833047 Change-Id: If5ca4ee1dea324b883e97195a6debad5f0804ed7 Reviewed-on: https://chromium-review.googlesource.com/1194982Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#587282}
 - 
Leon Scroggins III authored
https://chromium.googlesource.com/chromium/deps/libjpeg_turbo.git/+log/9977619490e1..61a2bbaa9aec $ git log 997761949..61a2bbaa9 --date=short --no-merges --format='%ad %ae %s' 2018-08-29 scroggo Remove msarett from OWNERS Created with: roll-dep src/third_party/libjpeg_turbo Change-Id: I09fa8531564d689fd550bb950cdc943060b0ccec Reviewed-on: https://chromium-review.googlesource.com/1195548Reviewed-by:
Chris Blume <cblume@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Leon Scroggins <scroggo@chromium.org> Cr-Commit-Position: refs/heads/master@{#587281}
 - 
Tommy C. Li authored
Previously, we were not setting the color of content setting icons. In the pre-Material world, this just worked well enough that no one noticed apparently. After this CL, the content setting icons will have the same color set as the other page action icons. Bug: 876458 Change-Id: Ifec3601478ceb3e65ac999806558416dfe076401 Reviewed-on: https://chromium-review.googlesource.com/1195721Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#587280}
 - 
Dominic Mazzoni authored
A stack trace showed a lot of cpu time spent in FindNodeWithChildTreeId, which is called from GetParentNodeFromParentTree. The context in which this is supposed to be triggered is when calling GetParent() on the root of a child frame the first time. Previously the strategy was to search the whole parent frame for the node that has the child frame as its child tree ID, and then cache that node for the next call. If the node wasn't found, FindNodeWithChildTreeId would have been called every single time. Instead, have AXTree keep track of a map between each unique child tree ID and nodes that reference that child tree ID. Then BrowserAccessibilityManager can just query it directly with no tree search required, whether it's found or not. Bug: 876315 Change-Id: Iad432f1f43e1e65d1123c231d85f9cd42b1da52f Reviewed-on: https://chromium-review.googlesource.com/1186191 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#587279}
 - 
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I0da632224fb6ab6f7ae3887efa33f55762110def Reviewed-on: https://chromium-review.googlesource.com/1195551Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#587278}
 - 
Livvie Lin authored
This cl changes the button text displayed in the omnibox for local files. "File" text is added to the chip and clicking on the button will display the text "You're viewing a file". A follow-up cl will elide file:// from the omnibox display. Screenshot: https://drive.google.com/file/d/1eiFK6FfonGqihqYCheFZmDtI-Qv8UPPZ/view?usp=sharing Bug: 818528 Change-Id: Ideb4c8aaefbe50afd2cdfd3236d1c72809d04fe3 Reviewed-on: https://chromium-review.googlesource.com/1187132 Commit-Queue: Livvie Lin <livvielin@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#587277}
 - 
Donn Denman authored
The ContextualSearchObserver code sometimes sends a Show without any Hide. This is because we're sending the Show notification when the selection changes, instead of when the panel is shown. This means that features that suppress showing the panel, like Smart Selection, may interfere with this notification. This CL just clarifies when the messages are sent and notes a problem with test coverage (linking to this bug). BUG=878006 Change-Id: I7f9b618b84f1633620490fd15f385796f947dfba Reviewed-on: https://chromium-review.googlesource.com/1192324Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#587276}
 - 
Manas Verma authored
Previously, if the user was signed-in but opted out of syncing (so no promo would be shown), after saving a card locally, the icon would highlight after the animation ended even if no bubble was showing. This change fixes that. Bug: 855186 Change-Id: I8aca67c572dafb91f37bcf752a813d3bbcfe14e4 Reviewed-on: https://chromium-review.googlesource.com/1192584Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Manas Verma <manasverma@google.com> Cr-Commit-Position: refs/heads/master@{#587275}
 - 
Avi Drissman authored
All public users intend to set "ignore events" on an entire page, but the API was on widget and so it was only ever set on the top-level widget. Move it to WebContents to allow it to have the desired effect. BUG=863582, 725830 Change-Id: I435b9f93160d0d77ad1aa0919757a4acd933768e Reviewed-on: https://chromium-review.googlesource.com/1194484Reviewed-by:
Mike Wittman <wittman@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#587274}
 - 
Cole Winstanley authored
Added a readme to the chromedriver/log_replay/ directory with usage and maintenance info for the log replay system. Bug: chromedriver:2501 Change-Id: I0bef83149cd6be6dd0978d81f2f79600f96cde77 Reviewed-on: https://chromium-review.googlesource.com/1194573 Commit-Queue: Cole Winstanley <cwinstanley@google.com> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#587273}
 - 
Fredrik Söderquist authored
Because of how filters interact with layout and paint (bounds dependency and filter caching et.c), we need to trigger layout (for bounds) and paint (for caching) when 'filter' changes. (A 'none' <=> <something> transition will trigger layout in general, but not a change from one filter to another.) Bug: 878591 Change-Id: I8bfad033f962bdfcb5000052ee07db7771428e3d Reviewed-on: https://chromium-review.googlesource.com/1195485Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#587272}
 - 
Fady Samuel authored
Not having an available surface to show in SurfaceAggregator is no longer really an error state because the start of a SurfaceRange is optional. This CL removes the displaying of a magenta solid color in that case. Bug: 672962 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Iadb58ac9a0791071df59702afbfe3dd373d9ef62 Reviewed-on: https://chromium-review.googlesource.com/1194959Reviewed-by:
Saman Sami <samans@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#587271}
 - 
Tommy Steimel authored
This CL changes the loading panel mask backgrounds to have their images defined in the main UA CSS instead of the inserted stylesheet. This fixes an issue where the loading spinner was broken by content security policy. Bug: 878415 Change-Id: Iaa78fbe810fe900d3abe39d03302250b7b9fade7 Reviewed-on: https://chromium-review.googlesource.com/1195719Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#587270}
 - 
Mathias Carlen authored
R=gogerald@chromium.org Bug: 806868 Change-Id: Ifaf32d8f82d4c15d1cfd3a6464afcae37827320a Reviewed-on: https://chromium-review.googlesource.com/1193443Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#587269}
 - 
Ella Ge authored
1. With use-zoom-for-dsf enabled, root_scroll_offset from metadata is in physical pixel, it needs to be convert to dip. 2. In blink, the hit test is expecting document point, but x and y from the devtool front end is in CSS scale. We need to apply the PageZoomFactor before doing the hit test. Bug: 876403 Change-Id: I6cd2f7ecd4d908a6aa986c4d1dfdab7e332355cb Reviewed-on: https://chromium-review.googlesource.com/1183968Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#587268}
 - 
David Black authored
Conversation starters are now guarded by a feature flag, and each chip is individually guarded by a feature param. To test via commandline override on gLinux, use: https://paste.googleplex.com/4937132372131840 Bug: b:113278721 Change-Id: I2aa9c8bfbd639caaceeb1f7af102d0c1eb054b5f Reviewed-on: https://chromium-review.googlesource.com/1192220 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#587267}
 - 
Xida Chen authored
Right now this function either returns the actual allowed touch action when it has value, or return Auto when it has no value. It is written this way to temporary fix a crash. Now that the crash is properly fixed, we can return the actual allowed touch action. TBR=dtapuska@chromium.org Bug: 851644 Change-Id: I6ae91f5f26c327377fbb0d0cbbfede925ac59680 Reviewed-on: https://chromium-review.googlesource.com/1189136 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#587266}
 - 
Eric Seckler authored
Also adds the generated output file directory as include directory to nocompile build targets. Bug: 878356, 867421 Change-Id: I51a8433a1e5295949f67aaea188444f81c394100 Reviewed-on: https://chromium-review.googlesource.com/1194224Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#587265}
 - 
Zhenyao Mo authored
It seems some drivers fail to handle that gracefully, so let's always clamp to be on the safe side. BUG=877874 TEST=test case in the bug, gpu_unittests R=kbr@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I6d93cb9389ea70525df4604112223604577582a2 Reviewed-on: https://chromium-review.googlesource.com/1194994Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#587264}
 
 -