- 08 Jul, 2016 40 commits
-
-
kenrb authored
Mousewheel-based scroll bubbling from OOPIFs to parent frames was broken in a couple of ways, due to it improperly accounting for the mechanics of synthetic gesture scroll events from the InputRouter class. This refactors bubbling to do the following: - remove bubbling of unused scroll delta from WheelEvent acks, which was wrong, - pass acks from GestureScrollUpdate and GestureScrollEnd events to the CrossProcessFrameConnector and then have RWHInputEventRouter do most of the reasoning about where to target unused scroll, - track the current scroll bubbling target, which can change due to nested OOPIFs, and manage GestureScrollBegin and GestureScrollEnds to each renderer (the previous approach of wrapping each GestureScrollUpdate led to bubbled scrolls feeling really slow). BUG=621624 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2123843002 Cr-Commit-Position: refs/heads/master@{#404500}
-
luoe authored
BUG=607682 Review-Url: https://codereview.chromium.org/2120613002 Cr-Commit-Position: refs/heads/master@{#404499}
-
fsamuel authored
This CL times deserialization of the CompositorFrame generated by cc_serialization_perftest using StructTraits versus ParamTraits. This CL also makes some mojo changes to ensure we don't need to move the mojo::Array we are deserializing from. BUG=624459 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review-Url: https://codereview.chromium.org/2136593002 Cr-Commit-Position: refs/heads/master@{#404498}
-
tbansal authored
In the next CL, GetECT API which computes Effective Connection Type (ECT) based on transport RTT and downlink throughput will be exposed to Cronet. BUG=625305 Review-Url: https://codereview.chromium.org/2113363002 Cr-Commit-Position: refs/heads/master@{#404497}
-
erikchen authored
BUG=602484 Review-Url: https://codereview.chromium.org/2102273002 Cr-Commit-Position: refs/heads/master@{#404496}
-
piman authored
At this point, VirtualGLApi only hooks the extension string query, and for not a very good reason, since it ends up serving the extension string of the underlying context. OTOH it adds a bunch of complexity to require the switch between RealGLApi and the VirtualGLApi, so instead fold the logic into GLContext. BUG=None CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2132913002 Cr-Commit-Position: refs/heads/master@{#404495}
-
dpranke authored
Now that these builders are using ninja, there isn't a compelling reason not to also be using goma. R=smut@chromium.org NOTRY=true BUG=626005 Review-Url: https://codereview.chromium.org/2127963003 Cr-Commit-Position: refs/heads/master@{#404494}
-
bmcquade authored
Until now, we've used base::TimeDelta.is_zero() as a signal that a given timing is unset. This is technically incorrect, as a TimeDelta can be set to the zero value. This mostly presented issues that made writing tests more complex, but also addresses real issues where a metric reports a zero time delta that would have previously been ignored but will now be included in our metrics. BUG=623556 Review-Url: https://codereview.chromium.org/2111073003 Cr-Commit-Position: refs/heads/master@{#404493}
-
khushalsagar authored
Remove public methods from Layer and LayerTreeHost that are just a pass through to the AnimationHost. These are used by the PropertyTreeBuilder, have it query the AnimationHost directly. BUG=625384 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review-Url: https://codereview.chromium.org/2130053002 Cr-Commit-Position: refs/heads/master@{#404492}
-
xlai authored
Currently the image pattern shader created is only padded with 1 black transparent pixel right and bottom. We should pad it on the left and top as well so that when pattern is transformed, the color on its left and top will not bleed. BUG=602509 Review-Url: https://codereview.chromium.org/2130063002 Cr-Commit-Position: refs/heads/master@{#404491}
-
jbudorick authored
Revert of Add support for installing ARM64 sysroot (patchset #1 id:1 of https://codereview.chromium.org/2078293002/ ) Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=626784 Original issue's description: > Add support for installing ARM64 sysroot > > This change modifies install-sysroot.py to add support for > installing ARM64 sysroot. Also update the jessie arm64 package list. > > BUG=613452 > > Committed: https://crrev.com/ad891a49ee7aeff1a42559c0a059cb51f053e1fb > Cr-Commit-Position: refs/heads/master@{#404323} TBR=thestig@chromium.org,mmoss@chromium.org,thakis@chromium.org,apatole@nvidia.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=613452 Review-Url: https://codereview.chromium.org/2132153002 Cr-Commit-Position: refs/heads/master@{#404490}
-
dbeam authored
Also shuffle around some JSDoc @tag-related code R=dpapad@chromium.org BUG=567770 NOTRY=true Review-Url: https://codereview.chromium.org/2131373002 Cr-Commit-Position: refs/heads/master@{#404489}
-
jbudorick authored
All suites now use isolate files that are either generated from gn data / data_deps or checked in to chromium. BUG= Review-Url: https://codereview.chromium.org/2131083003 Cr-Commit-Position: refs/heads/master@{#404488}
-
kbr authored
This will be used to periodically gather per-test run times for various test suites, to improve the sharding distribution. Check in the data for a recent run of webgl2_conformance_tests. Reference this from the Swarming invocations. BUG=352807 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel NOTRY=true Review-Url: https://codereview.chromium.org/2116593004 Cr-Commit-Position: refs/heads/master@{#404487}
-
slan authored
Add OnStatisticsUpdate and OnWaitingForDecryptionKey to mojom::RendererClient, and call these callbacks from MojoRendererService. These are needed for Cast Apps like Netflix that depend on decoding statistics from the media pipeline. BUG=585287 BUG= internal b/29390639 Review-Url: https://codereview.chromium.org/2101043003 Cr-Commit-Position: refs/heads/master@{#404486}
-
sky authored
The resize lock completely throws off tests that generate events. These tests aren't meant to exercise the resize lock, so disabling seems reasonable. This is just the plumbing for the disable, will start enabling tests separately. BUG=331924 TEST=none R=piman@chromium.org Review-Url: https://codereview.chromium.org/2135743002 Cr-Commit-Position: refs/heads/master@{#404485}
-
cwallez authored
TBR=zmo@chromium.org BUG=626524 BUG=626742 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2134643004 Cr-Commit-Position: refs/heads/master@{#404484}
-
pdr authored
This patch fixes a crash on https://codepen.io where the paint offset in PaintPropertyTreeBuilder::updateSvgLocalToBorderBoxTransform would not be reset if transformToPixelSnappedBorderBox was identity. The new testcase, SvgPixelSnappingShouldResetPaintOffset, both ensures the DCHECK in PaintPropertyTreeBuilder::updateTransform is not hit, and verifies the transform property tree is correct in this case. BUG=600618 Review-Url: https://codereview.chromium.org/2131803002 Cr-Commit-Position: refs/heads/master@{#404483}
-
sammiequon authored
Bug was caused by having transitions for the image and sign in indicator for the user pod, while the image pane stays 100%. So when we are in the public account user pod the image will be centered. BUG=626157 Review-Url: https://codereview.chromium.org/2130143002 Cr-Commit-Position: refs/heads/master@{#404482}
-
yinjie authored
* Introduce lazy allocation of Storage. This in particular allows moved-from SpdyHeaderBlock instances to be valid without having to allocate Storage for them. * Use swap in move constructor and move assignment operator to make sure moved-from instance is valid. * Add SpdyHeaderBlockTest.MovedFromIsValid test. * s/block1/block/ in SpdyHeaderBlockTest.AddHeaders. This CL lands server change 125821596 by bnc. BUG=488484 Review-Url: https://codereview.chromium.org/2125403003 Cr-Commit-Position: refs/heads/master@{#404481}
-
thestig authored
TBR=brettw@chromium.org Review-Url: https://codereview.chromium.org/2133083002 Cr-Commit-Position: refs/heads/master@{#404480}
-
majidvp authored
BUG=624651 Review-Url: https://codereview.chromium.org/2124143004 Cr-Commit-Position: refs/heads/master@{#404479}
-
nektar authored
The children of non-editable combo boxes, search boxes and text fields specified via e.g. aria-owns should not be hidden from platform trees. Children of combo boxes, search boxes and text fields might not always be part of the shadow DOM, especially when no <input> or contentEditable . tags have been usedThey might be a list of combo box items specified via aria-owns. data:text/html,<div role="combobox" aria-owns="list" onKeyDown="this.setAttribute('aria-activedescendant', 'item');">content</div><ul id="list"><li id="item">item</li></ul> BUG=620432 R=dmazzoni@chromium.org TESTED=manually with Jaws NVDA and Voiceover Review-Url: https://codereview.chromium.org/2120523002 Cr-Commit-Position: refs/heads/master@{#404478}
-
lushnikov authored
BUG=616044 R=kozyatinskiy Review-Url: https://codereview.chromium.org/2135703003 Cr-Commit-Position: refs/heads/master@{#404477}
-
smaier authored
BUG=625704 Review-Url: https://codereview.chromium.org/2126353002 Cr-Commit-Position: refs/heads/master@{#404476}
-
hush authored
BUG= CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review-Url: https://codereview.chromium.org/2124063002 Cr-Commit-Position: refs/heads/master@{#404475}
-
rajendrant authored
When any user initiated traffic is seen during the precache fetches, precache should be cancelled. BUG=619221 Review-Url: https://codereview.chromium.org/2061303003 Cr-Commit-Position: refs/heads/master@{#404474}
-
erg authored
BUG=622900,622575 Review-Url: https://codereview.chromium.org/2099513003 Cr-Commit-Position: refs/heads/master@{#404473}
-
ortuno authored
Moving BluetoothAdapterFactoryWrapper avoids the need to access a member from RenderProcessHostImpl, which avoids casting from RenderProcessHost to RenderProcessHostImpl. The scan duration is a web bluetooth concept and therefore should not be part of the FactoryWrapper in device. To that extent we expose a static function in BluetoothDeviceChooserController that allows tests to set a scan duration of 0. BUG=621528 Review-Url: https://codereview.chromium.org/2059543002 Cr-Commit-Position: refs/heads/master@{#404472}
-
mark authored
For each new major OS version, we need to poke at the internals of CFAllocator to enable the out-of-memory killer for the default CFAllocator implementations. This update is for macOS 10.12 ("Sierra"), whose CFAllocator internals are unchanged from 10.11 (and from 10.9, and in fact from 10.7). It also updates the base::mac::IsOS*() family of functions for this new OS version. BUG=626536,45650 TEST=base_unittests OutOfMemoryDeathTest.CFAllocator*,MacUtilTest.IsOSEllipsis Review-Url: https://codereview.chromium.org/2129273002 Cr-Commit-Position: refs/heads/master@{#404471}
-
mathp authored
A follow-up change will split the slightly long promo over 2-lines for Views, Mac, Android. Also, Android and iOS will need bridges into Java and ObjC, so this is deferred to another change. BUG=626442 Review-Url: https://codereview.chromium.org/2124343002 Cr-Commit-Position: refs/heads/master@{#404470}
-
ccameron authored
Trying to fix this has been a source of hung frames. This makes the DelegatedFrameHostClient's IsVisible callback return the variable that tracks whether or not the DelegatedFrameHost's owner has set it to be visible. BUG=623716 Review-Url: https://codereview.chromium.org/2125143004 Cr-Commit-Position: refs/heads/master@{#404469}
-
ortuno authored
Before we updated the map two times: 1. When constructing the device object *iff* the services had been resolved. 2. When a new service was added. This meant that if there was a cached service before services resolved, the service would never be added to the map. There are a couple of changes: 1. No longer add BluetoothDeviceBluez as an observer of BluetoothDeviceClient. This follows the previous pattern of exposing a function that BluetoothAdapterClient will use to update the device. 2. When services are resolved we add all previously unknown services. 3. Modified 2 tests and added two extra ones to test all the following cases: 1. Cached services exist and discovery hasn't completed. 2. Cached services exist and discovery has completed. 3. New service is exposed with no previous cached services. 4. New service is exposed with previous cached service. Case 1 should cover this bug. BUG=624400 Review-Url: https://codereview.chromium.org/2105423003 Cr-Commit-Position: refs/heads/master@{#404468}
-
mathp authored
Supports 2-digit years, and various combinations of mm/yyyy and single digit month combinations (e.g. m/yy). BUG=626537 TEST=CreditCardTest,PersonalDataManagerTest Review-Url: https://codereview.chromium.org/2136453003 Cr-Commit-Position: refs/heads/master@{#404467}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a5d8806e..252926e7 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2131203003 Cr-Commit-Position: refs/heads/master@{#404466}
-
halliwell authored
Now that we have fixed physical display resolution, we can set the initial display size correctly, and there is no need for the resize logic. BUG=internal b/29391986 Review-Url: https://codereview.chromium.org/2119583002 Cr-Commit-Position: refs/heads/master@{#404465}
-
malaykeshav authored
- Checks the age of device by comparing the Oobe flag file creation date. Design Doc=go/cros-hats-eng BUG=611781 COMPONENT=Chrome OS, HaTS Review-Url: https://codereview.chromium.org/2103293003 Cr-Commit-Position: refs/heads/master@{#404464}
-
jbauman authored
This will help us track down the causes of video decoding errors in about:gpu and on the GPU bots. Logging only the line number should help prevent code bloat due to logging strings (and code) in release builds, and should make it easy to identify exactly what code failed. BUG=626524 Review-Url: https://codereview.chromium.org/2133553002 Cr-Commit-Position: refs/heads/master@{#404463}
-
mcasas authored
* No new code introduced whatsoever * Like it says in the title: s/MockClient/MockVideoCaptureClient/ and s/client_/video_capture_client_/ because there's a new client coming in https://crrev.com/2129733004, (namely MockImageCaptureClient), now we have to specify. TEST=capture_unittests passing merrily as before. TBR=emircan@chromium.org (since this CL is trivial) Review-Url: https://codereview.chromium.org/2133233003 Cr-Commit-Position: refs/heads/master@{#404462}
-
sunnyps authored
Resources which do not belong to a particular ResourceProvider should not require a WaitSyncToken. This is a speculative fix for the increased idle wakeups seen on Mac non-overlay. R=piman@chromium.org BUG=621198 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review-Url: https://codereview.chromium.org/2130213002 Cr-Commit-Position: refs/heads/master@{#404461}
-