- 19 Sep, 2019 4 commits
-
-
Joel Hockey authored
Check policy before starting an export or import. Bug: 1003944 Change-Id: I2f87ab7f1995fbb47ed4e4da13e0cff7c5852041 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809123 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#697837}
-
Taylor Bergquist authored
This allows tabstrip animations to be disabled during tests and with various operating system settings. Bug: 8944 Change-Id: I56d7edb7fd3c05f98e2ada0b3e14efaef5cf9ae4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1812131Reviewed-by:
Charlene Yan <cyan@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#697836}
-
Kenneth Russell authored
https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/abaae12..f4ddbaf Bug: 691951, 891861 Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64 Change-Id: Ice20033bf05e05376bcd33210bdae2fb2009e0c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810002 Commit-Queue: Kenneth Russell <kbr@chromium.org> Auto-Submit: Kenneth Russell <kbr@chromium.org> Reviewed-by:
James Darpinian <jdarpinian@chromium.org> Cr-Commit-Position: refs/heads/master@{#697835}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/17a3a0bda946..e2a903e18b59 git log 17a3a0bda946..e2a903e18b59 --date=short --no-merges --format='%ad %ae %s' 2019-09-18 csmartdalton@google.com Reland "Reorder msaa and mipmap resolves to happen all at once" 2019-09-18 bsalomon@google.com Handle F16Norm clamping in SkPaint->GrPaint conversion. 2019-09-18 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-09-18 mtklein@google.com move skvm debug tools back to core 2019-09-18 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-09-18 herb@google.com Reland "SkZip - synchronized indexing of several pointers" 2019-09-18 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@e2a903e18b59 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=brianosman@google.com Bug: None Change-Id: I70e3704c9eedcda905998e98d267ab01b398ff72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811977Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697834}
-
- 18 Sep, 2019 36 commits
-
-
Kent Tamura authored
This CL reduce the estimated pre-processed size of web_url_response.h from 2.42MB to 0.91MB. Bug: 242216 Change-Id: Ia95b04b7ef33e9a961a69522fb566c0649a4b7a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810119Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#697833}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/017dfff534a5..e9b6f28fdd71 git log 017dfff534a5..e9b6f28fdd71 --date=short --no-merges --format='%ad %ae %s' 2019-09-18 jmadill@chromium.org GN: Build libVulkan to root_out_dir. Created with: gclient setdep -r src/third_party/swiftshader@e9b6f28fdd71 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:1000668 Change-Id: I67c94b1425f1576fcb46b33ab7e47ff64e5e39e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811982Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697832}
-
Sadrul Habib Chowdhury authored
We have not been using FrameMetrics or SkippedFrameTracker to report any metrics so far. So stop using them from cc. Follow up CLs will remove the code and associated tests. BUG=1005377 Change-Id: Idb779df9210b1b075bb2d76fd499ec43b3822898 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811201Reviewed-by:
Mohsen Izadi <mohsen@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#697831}
-
Robbie McElrath authored
This makes the class names used in android_webview constants so they can be used without android_webview having to depend on services. This also includes a test to validate that the class constants are correct. Test: ninja -C out/aw android_webview/test:webview_instrumentation_test_apk Bug: 934152 Change-Id: Ifa2ee5da43748c41d1e0ff2d8320ceb45e5a4e4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1794262 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#697830}
-
Moe Ahmadi authored
Bug: 996516 Change-Id: Ib536df9fc6c9f645f6932cdc399259fc2be01de2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809966 Auto-Submit: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#697829}
-
Stefan Zager authored
This already gets called from PerformPostLayoutTasks. That's a better place for it, because it means the call happens before we recurse into child frames and run layout in them, since the geometry update call invalidate layout in the child frames. Change-Id: I145f054b7516e95545d68402fae38519c6706557 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800922Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#697828}
-
Toni Barzic authored
For new spec, the search results top margin is different between half and fullscreen state. This cl makes the app list ContentsView gradually update the top margin for search results app list page during dragging. This updates AppListView::GetAppListTransitionProgress to support getting progress for search results page (where baseline position is different from peeking), so it can be used to update the search box position while dragging in search results state. Also updates ContentsView::GetSearchBoxBounds to consider app list transition progress while in drag. Without this, ContentsView layout during app list drag does not correctly position search box, and consequently app list pages' content (it uses the search box padding associated with the current app list view state, instead of padding proportional to the current app list transition progress). Has small cleanup: * Passes progress and "should_restore_opacity" flag from ContentsView to children's UpdateYPositionAndOpacity(). * In AppListView, removes calls to ContentsView::SetActiveState that follow AppListView::SetState - these are not needed, as the contents view active state is set during AppListView::SetState (in SetChildViewsForStateTransition()). BUG=999273 Change-Id: I17db7701bd7c3dfa39824c95b0eea94ddc9269c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808389 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#697827}
-
Ahmed Fakhry authored
This CL fixes a bug in which a forced-visible window that is a descendant of a hidden window used to be considered occluded along with its descendants. This causes problems with virtual desks, since a browser window may be forced visible (while projecting), but the desk it resides on is switched, hence its container is hidden. In this case, the browser window, as well as its descendants should be considered visible from an occlusion stand point. BUG=998214 TEST=Added a new test Change-Id: I7031f16f4fbfd6e86228670f5d58ef1ac135eab1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810104Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#697826}
-
Eric Stevenson authored
This CL was generated by //base/android/jni_generator/jni_refactorer.py. Bug: 929661 Change-Id: Ia3a1f45ce0255362c44b51dded3abd640ad1d966 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809335Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#697825}
-
Aaron Gable authored
This reverts commit ec810bac. Reason for revert: causing eslint failures on Linux Tests: /b/s/w/ir/third_party/blink/renderer/devtools/front_end/dom_extension/DOMExtension.js 817:10 error 'onInvokeElement' is defined but never used no-unused-vars https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests/81950 Original change's description: > Reland "Convert ui/ARIAUtils.js to an ES module" > > This is a reland of b3373919 > > Original change's description: > > Convert ui/ARIAUtils.js to an ES module > > > > ES modules allow files to explicitly import and export symbols [1]. > > This patch migrates ARIAUtils.js to an ES module, while maintaining > > backwards compatibility with existing usages of `window.UI.ARIAUtils`. > > > > The build system is updated to copy these modules verbatim, as it no > > longer require pre-processing to be loaded. The `module.json` no longer > > includes this file as a script, to make sure it is not double-bundled > > into `shell.js`. Instead, it is added to the new field `modules`, which > > contains all modules. By doing so, it becomes clear which files are > > converted to modules already and which require the legacy references > > to the global scope. > > > > This module and future modules will be imported from `root.js`, which is > > added to all existing HTML application files. > > > > Design Doc: https://docs.google.com/document/d/1h9dOy3nNPNfZ2AtZXzB-DwJqG4Oo37WWvKLCuzCcPzo/edit?usp=sharing > > > > [1]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/import > > > > TBR=jochen@chromium.org > > > > Change-Id: Ie79c8f2fce3aff96fa28af0b575eae39bfe8e1a5 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1748949 > > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > > Reviewed-by: Yang Guo <yangguo@chromium.org> > > Commit-Queue: Tim van der Lippe <tvanderlippe@google.com> > > Cr-Commit-Position: refs/heads/master@{#697238} > > Change-Id: I7544cbf4364d0b1a3c2f137a4d17a1afdb1d4aed > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810534 > Reviewed-by: Yang Guo <yangguo@chromium.org> > Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org> > Cr-Commit-Position: refs/heads/master@{#697626} TBR=yangguo@chromium.org,aerotwist@chromium.org,tvanderlippe@chromium.org Change-Id: I445fd35f135450cd9e8ed4c69bf913662f461ce6 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811989Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#697824}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1070231232ce..8b95eac85df9 Created with: gclient setdep -r src-internal@8b95eac85df9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:1004563,chromium:None Change-Id: Ibdf37cc28faf28323dbe43520702c7016938d080 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811980Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697823}
-
Tommy Li authored
This experiment is over. Bug: 956102 Change-Id: Ib571044bc10cced1d3853fd5b7623e072e40bedd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804034Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#697822}
-
Min Qin authored
DownloadManagerImpl creation will load all history downloads, and that will cost a lot of memory space. This CL allows DownloadManager creation to be deferred once UseInProgressDownloadManagerForDownloadService feature is enabled. New UMAs are added to capture the duration of the delay and the approximate memory usage of history downloads. BUG=1003904 Change-Id: I55d3079685b8169cb1090230829bfca2d4ac2605 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804076 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#697821}
-
James Cook authored
By default, clicking on the People > Profile row will open the Chrome OS account manager in a new window. Change the row to use the "link out" arrow icon. Screenshot: http://screen/UBHW5acnie0 If ChromeOSAccountManager is disabled, it does nothing on click, like before. If SplitSettings is disabled, it opens the profile picture picker, like before. Bug: 1004446 Test: added to browser_tests Change-Id: Ia537bdc4fa841ec1995496b87c4650e0b1e761a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811862Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#697820}
-
Charlene Yan authored
Bug: 1003765 Change-Id: If6e35db7a420a77ee2f532e3545ab1c1626cf54e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807575 Commit-Queue: Charlene Yan <cyan@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#697819}
-
Giovanni Ortuño Urquidi authored
Enums were initialized before the interface's namespace which caused an error when trying to add the enum to the namespace. This CL fixes the issue by moving enum initialization after the interface's namespace is initialized. Bug: 1004822 Change-Id: I6e8328ebc7cccee744388bb32939dfe1bdfcbd42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810170Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#697818}
-
Rakib M. Hasan authored
TBR=crouleau@chromium.org Bug: chromium:999335 Change-Id: I2030d0d319ef1c091b29a725198c4f99cc4b66c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811997Reviewed-by:
Rakib Hasan <rmhasan@google.com> Commit-Queue: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#697817}
-
Xianzhu Wang authored
After crrev.com/c/1799701, non-backdrop-filter mask layers become normal layers with DstIn blend mode, thus they can be tiled normally to avoid the problems caused by single tile before (e.g. too much memory usage for huge masks, no benefits of tile management). Bug: 1003414 Change-Id: Ic0c5d318bc3e657de861f6c7246c417399900209 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805468Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#697816}
-
Andrew Xu authored
ShelfWidget's bounds are offset to leave space for the navigation widget even when the login shelf shows. It leads to the wrong layout of the login shelf. This CL fixes such an issue. Bug: 994424 Change-Id: I2f422e2a53e7d40f76ebbbb53204e1619ccc95e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811642Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#697815}
-
Henrique Ferreiro authored
Convert the implementation and all users of the mojom::InterventionsInternalsPageHandler and InterventionsInternalsPage interfaces. Bug: 955171 Change-Id: I7a11210d5c392bc8b11ae2ef283f66222d1c17cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808860Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ben Greenstein <bengr@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#697814}
-
Jack Lynch authored
This CL sets the alt attribute of images shown within the Performance panel Event Log based on their source URLs. Screenshot of details panel showing image: https://gyazo.com/ec6d3643fc657c635da5fd37b3c630bc Bug: 963183 Change-Id: I1071611f824dd00ccadaadcbf364d66dbcf01028 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721187 Commit-Queue: Jack Lynch <jalyn@microsoft.com> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#697813}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8baaec47e3bd..c6be56ecedf9 git log 8baaec47e3bd..c6be56ecedf9 --date=short --no-merges --format='%ad %ae %s' 2019-09-18 ehmaldonado@chromium.org Revert "Set core.trustctime=false during git checkout operations." Created with: gclient setdep -r src/third_party/depot_tools@c6be56ecedf9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:330461,chromium:642711,chromium:746763,chromium:740301. Change-Id: Ibb66873a15733dce75176b95b005efefeb4edc49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811978Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697812}
-
danakj authored
This is a reland of 55474752 Original change's description: > Revert "Move page zoom level responsibility into RenderViewImpl." > > This reverts commit 6876fb4f. > > Reason for revert: Breaks layout tests even though they passed in the CQ??? > > Linux: > animations/animationworklet/worklet-animation-responsive-to-zoom.html > svg/as-image/img-zoom-svg-stylesheet.html > fast/media/mq-width-pagezoom.html > > Windows: > animations/responsive/zoom-responsive-translate-animation.html > fast/media/mq-resolution-pagezoom.html > fast/backgrounds/tiny-tile-zoomed.html > > animations/animationworklet/worklet-animation-responsive-to-zoom.html > svg/as-image/img-zoom-svg-stylesheet.html > fast/media/mq-resolution-pagezoom.html > > > Original change's description: > > Move page zoom level responsibility into RenderViewImpl. > > > > Page zoom level is a page/view concept, but the code to manage it is > > currently in RenderFrameImpl, though only run when it is the root frame. > > > > This doesn't dramatically change ownership of responsibility but moves > > the code up into RenderViewImpl. RenderWidget still goes through > > RenderFrameImpl (though more explicitly) to set the zoom level on the > > RenderView. And RenderWidget takes responsibility for closing the page > > popup instead of having multiple "set page zoom" methods on > > RenderViewImpl. > > > > This uncovered some spooky action-at-a-distance and makes it more > > explicit and documented, though no less unfortunate. A local root > > LocalFrame does not initialize with the correct page zoom value because > > it has no parent to read it from. We (accidentally?) worked around that > > by setting the RenderView's page zoom to its current value when > > navigating a (new) LocalFrame, which would call into blink's WebView > > and walk through the entire frame tree setting the value on everything, > > eventually also on the new LocalFrame. > > > > Now on navigation, for a local root, we call RenderWidget's > > UpdateWebViewWithDeviceScaleFactor() which does the same thing by > > re-setting the WebView's page zoom factor. This was done when making > > a new main frame in multiple places (RenderView and RenderFrame both > > called it in the same CreateFrame() callstack). Now it is consolidated > > to a single place on navigation for the main frame and child frames > > giving them more consistent behaviour, and going explicitly through > > this method that should go away if things were well designed, rather > > than re-setting the RenderView to its own value. > > > > Remove calls to UpdateWebViewWithDeviceScaleFactor() scattered > > throughout RenderViewImpl and RenderFrameImpl. What we need is for > > 1) The Page to be updated with PreferCompositingToLCDText when the > > device scale factor changes. > > 2) The WebView to be updated when the device scale factor changes. > > 3) The LocalFrame of a local root needs its page zoom set by poking > > the WebViewImpl to walk through all frames and set it. > > > > R=erikchen@chromium.org > > > > Bug: 419087 > > Change-Id: I97c0e287be8f96a4ac632d63b981c190169dc1a9 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799386 > > Reviewed-by: Avi Drissman <avi@chromium.org> > > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > > Reviewed-by: Erik Chen <erikchen@chromium.org> > > Commit-Queue: danakj <danakj@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#697687} > > R=avi@chromium.org, dcheng@chromium.org, erikchen@chromium.org > TBR=danakj@chromium.org > > Change-Id: I3177d7f7a601b6692fd931623ca749bacce051c9 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 419087 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811937 > Reviewed-by: danakj <danakj@chromium.org> > Commit-Queue: danakj <danakj@chromium.org> > Cr-Commit-Position: refs/heads/master@{#697766} TBR= Bug: 419087 Change-Id: Ida285bb065092d369f3cf263986343e200a8ed41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811864 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#697811}
-
Patrick Monette authored
Also changes NotifiesOnlyOnChangesWithPreviousValue to pass the previous value by const-ref. Bug: 999594 Change-Id: I63ce2cdb1d085ac68a7abb2a7b8211be0a353c56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787727 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#697810}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/46e424ec..f1aa36df Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I16ae6795658d51264ae80cafe1b32fb1bbed1cf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811181Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697809}
-
Xianzhu Wang authored
We ignored position of mask layers before crrev.com/697315 by always setting the mask layer's offset_to_transform_parent and property tree state to the same as the masked layer. As we removed the special handling code for mask layers from PropertyTreeBuilder, now we ignore position of mask layers in Layer::SetPosition() to keep the original behavior. Bug: 100532 Change-Id: I2c9def5e139ea6a3c798593f8f0c2a219d2bdc8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810844Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#697808}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7c1b59b7b8a9..edf199a0b96c git log 7c1b59b7b8a9..edf199a0b96c --date=short --no-merges --format='%ad %ae %s' 2019-09-18 treehugger-gerrit@google.com Merge "Re-enable heapprofd CTS on x86." 2019-09-18 treehugger-gerrit@google.com Merge "Implement command queue in adb socket controller" Created with: gclient setdep -r src/third_party/perfetto@edf199a0b96c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I2a03b597593e2029af7579b0906431b59b177d5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811979Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697807}
-
Dale Curtis authored
The pulseaudio source code checks pa_context and pa_stream state while waiting for operation completion. Lets do the same thing on the off chance that's the source of our hangs. See CHECK_DEAD_GOTO macro upstream: https://github.com/pulseaudio/pulseaudio/blob/master/src/pulse/simple.c#L68 This change modifies the WaitForOperationCompletion() method to take an optional pa_stream and/or pa_context and checks their state while waiting. In cases where failure could be signaled as an error upstream, a bool status code is used to do so. BUG=986021 R=tguilbert Change-Id: I7075293d1f74ad12f6c596bce39bbf0bba2c9a73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811698 Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#697806}
-
Connie Wan authored
The underline is composed of two parts: 1) A straight underline, painted by TabStrip, extending from the group header to the last time (minus some inset). 2) A stroke above the active tab, painted by TabStyleViews, which (along with the active tab background) is layered over the straight underline. The underline is still missing the following polish: - Half-rounded edges. - Potential redesign of the stroke above the active tab. Screenshots are in the attached bug. Bug: 905491 Change-Id: I4a99a67f9637b8a879bba7589feb848edb30deee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809546 Commit-Queue: Connie Wan <connily@chromium.org> Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#697805}
-
Ana Salazar Maldonado authored
Users should be able to rename a folder by tapping on the folder name or in any area near it. Bug: 997364 Change-Id: Id2fd2e04fdce99e8323a8cdbd55d18e120e38e24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791630Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Ana Salazar <anasalazar@chromium.org> Cr-Commit-Position: refs/heads/master@{#697804}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/9d3a62e82627..3681d5f8b5d7 git log 9d3a62e82627..3681d5f8b5d7 --date=short --no-merges --format='%ad %ae %s' 2019-09-18 thestig@chromium.org Add CPDF_Array::GetBooleanAt(). 2019-09-18 thestig@chromium.org Add yet another pixel test for invalid glyph ID. 2019-09-18 thestig@chromium.org Consistently declare operator=. 2019-09-18 thestig@chromium.org Sync third_party/freetype/OWNERS with Chromium's. Created with: gclient setdep -r src/third_party/pdfium@3681d5f8b5d7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=pdfium-deps-rolls@chromium.org Bug: None Change-Id: I6ed43661a048368120eb0d47def1cd02d0f9f29d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811857Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697803}
-
Tom Anderson authored
https://chromium.googlesource.com/external/fontconfig.git/+log/ba206df9b9a7..65087ac7ce4c $ git log ba206df9b..65087ac7c --date=short --no-merges --format='%ad %ae %s' 2019-08-29 jtojnar conf: Add JoyPixels emoji font 2019-08-28 akira Do not return FcFalse from FcConfigParseAndLoad*() if complain is set to false 2019-08-21 Szunti Add missing return type for FcFontSet* functions 2019-08-09 akira Affect FC_FONT_HAS_HINT property to score on matcher 2019-08-07 akira Improve the performance a bit 2019-07-31 akira Fix the fails of make check when SOURCE_DATE_EPOCH is set 2019-07-29 akira Fix failing the check of prep table in some fonts 2019-07-29 akira Add FC_FONT_HAS_HINT property to see if font has hinting or not. 2019-07-26 akira Add 35-lang-normalize.conf 2019-07-26 akira Fix a memory leak in FcFreeTypeQuery*() 2019-07-23 akira Fix memory leaks 2019-07-23 akira Fix the fail on fc-cache 2019-07-23 akira Add docs for missing properties 2019-07-23 akira Clean up temporary directory for tests 2019-07-22 akira FcConfigParseAndLoad*() should returns false on config errors 2019-07-09 akira Add English name first into a cache 2019-07-09 akira Fix a typo 2019-07-08 akira Improve the performance a bit 2019-07-02 akira Fix a crash when running with FC_DEBUG=256 2019-06-24 akira Fix obtaining real path from pre-defined names for Win32 2019-06-21 akira Don't clean up pre-built docs if no docbook installed. 2019-06-19 egmont Fix the linear interpolation during weight mapping 2019-06-18 akira Fix a typo on masking face id 2019-06-10 akira Bump version to 2.13.91 2019-06-10 akira Fix endianness on generating MD5 cache name 2019-06-06 akira Fix a typo in the description of FcWeightFromOpenTypeDouble 2019-06-03 akira Correct the comment for FC_LANG in fontconfig.h 2019-05-09 akira fc-validate: returns an error code when missing some glyphs 2019-05-08 akira Update CaseFolding.txt to Unicode 12.1 2019-04-15 jon.turney Only use test wrapper-script if host is MinGW 2019-04-15 akira Distribute archive in xz instead of bz2 2019-04-04 akira Update the test case that is looking for uuid based on host 2019-04-04 akira No need to remap for uuid based 2019-04-04 akira Fallback uuid-based name to read a cache if no MD5-based cache available 2019-04-04 akira Fix unexpected cache name by double-slash in path 2019-04-04 akira Don't show salt in debugging message if salt is null 2019-04-03 akira Allow overriding salt with new one coming later 2019-04-02 akira fc-cache: Show font directories to generate cache with -v 2019-04-02 akira Oops, Terminate string 2019-04-02 akira Add some debugging output 2019-04-02 akira Don't warn if path can't be converted with prefix 2019-03-26 akira Don't share fonts and cache dir for testing 2019-03-25 akira Add more data to artifacts for debugging purpose 2019-03-25 akira Fix make check fail on MinGW again 2019-03-25 akira Use alternative function for realpath on Win32 2019-03-25 akira Fix build issues on MinGW 2019-03-25 akira Add back if !OS_WIN32 line 2019-02-01 akira trivial testcase update 2019-02-01 akira Update doc for salt 2019-01-31 akira Add salt attribute to dir and remap-dir elements (...) 2019-01-28 akira Fix make check fail on run-test-conf.sh 2019-01-28 akira Drop a line to include uuid.h 2019-01-28 akira Add FcDirCacheCreateUUID doc back to pass make check 2018-10-29 keithp Replace UUID file mechanism with per-directory 'map' attribute [v2] 2018-10-29 keithp Remove UUID-related tests 2018-10-29 keithp Add delays to test-bz106632, check UptoDate separately 2018-10-29 keithp Remove '-u' option from run-test-conf.sh 2018-10-29 keithp Fetch FONTCONFIG_SYSROOT in FcConfigCreate 2019-04-03 akira Reset errno to do error handling properly 2019-03-23 akira Don't test bind-mount thing for MinGW 2019-03-23 akira Install wine for CI on MinGW 2019-03-23 akira Correct configure option to cross-compile 2019-03-23 akira Update requirement for gettext 2019-03-23 akira Fix make distcheck error 2019-03-22 akira Add build test for MinGW 2019-03-22 akira Fix make check on cross-compiled env 2019-03-22 akira Ifdef'ed unnecessary code for Win32 2019-03-22 akira autogen.sh: Make AUTORECONF_FLAGS overwritable 2019-03-19 akira Fix build issue on Win32. 2019-03-15 akira Fix misleading summary in docs for FcStrStrIgnoreCase 2018-09-25 akira Add system-ui generic family 2019-02-19 bungeman Better document sysroot. 2019-01-25 liezhi.yang src/fccache.c: Fix define for HAVE_POSIX_FADVISE 2019-01-23 akira Fix a crash with invalid matrix element 2018-11-30 akira Fix a dereference of a null pointer 2018-11-30 akira covscan: fix compiler warnings 2018-11-30 akira Don't call unlink_dirs if basedir is null 2018-11-12 akira covscan fix: get rid of unnecessary condition check 2018-11-30 akira Warn when constant name is used for unexpected object 2018-11-27 akira Add a test case for FcFontList 2018-11-27 akira Fix FcFontList doesn't return a font with FC_COLOR=true 2018-11-26 cjmcdonald Lowered temporary rooted_dir variable inside loop 2018-11-19 cjmcdonald Respect sysroot option for file path passed to stat 2018-11-15 akira Add doc for description element and update fonts.dtd 2018-11-13 akira Use Rachana instead of Meera for Malayalam 2018-11-06 akira Use FC_PATH_MAX instead of PATH_MAX 2018-11-06 akira Enable bubblewrap test case 2018-10-29 akira Drop Mitra Mono from 65-nonlatin.conf 2018-10-24 behdad Fix name-table language code mapping for Mongolian 2018-10-25 akira Do not run a test case for .uuid deletion 2018-10-17 keithp Do not remove UUID file when a scanned directory is empty 2018-10-01 akira Do not try updating mtime when unlink was failed 2018-09-28 akira Do not update mtime when removing .uuid file 2018-10-04 akira CI: Add more logs 2018-10-04 akira Fix test case 2018-10-04 akira add missing the case of prefix="default" as documented 2018-10-04 akira Update docs for 1aa8b700 2018-10-04 akira Update fonts.dtd for last commit 2018-10-02 akira Add more prefix support in <dir> element 2018-09-28 akira Fix CI Created with: roll-dep src/third_party/fontconfig/src BUG=843886,1004254 R=spang,dnicoara Change-Id: If6853404f1e87de4f95a24f6231282543814bd63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809892Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Etienne Bergeron <etienneb@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#697802}
-
Maksym Onufriienko authored
Bug: 1001667 Change-Id: Iff50ac71a25d3dd33b81f08f8e38d6d2d9df6f67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1802023Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org> Cr-Commit-Position: refs/heads/master@{#697801}
-
Chromium WPT Sync authored
Using wpt-import in Chromium d5e9cf22. With Chromium commits locally applied on WPT: 13765318 "[WPT/common/security-features] Introduce iframe-blank source context" bda4c129 "Revert "Re-land: Fix `Referer` for descendant module scripts and worklets"" 55a477b6 "Implement word boundary matching" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: dgrogan@chromium.org: external/wpt/css/css-tables drott@chromium.org, kojii@chromium.org: external/wpt/css/css-fonts ericwilligers@chromium.org: external/wpt/css/motion foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools kojii@chromium.org: external/wpt/css/css-writing-modes mkwst@chromium.org, andypaicu@chromium.org: external/wpt/content-security-policy rego@igalia.com: external/wpt/css/css-grid skobes@chromium.org: external/wpt/css/css-scroll-anchoring NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: I0baf91bfb20c2e9932e72356cb41079da94f26c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811180Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697800}
-
Matt Wolenetz authored
Reports (up to once per page) if any SourceBuffer's coded frame processing encountered a problematic scenario where the group end timestamp decreases within a media segment. The spec doesn't expect this to occur, nor does media element duration update at the last step of the coded frame processing algorithm allow for this situation (the resulting duration could be less than what was actually buffered, for example). In Chrome, the buffered ranges calculation algorithm has subsequent problems. Current discussion on this in the MSE spec (https://github.com/w3c/media-source/issues/203) could benefit from understanding if this is indeed a common or uncommon scenario to scope clarification work to improve interoperability and reduce spec ambiguity for this scenario. BUG=920853 TEST=FrameProcessorTest.GroupEndTimestampDecreaseWithinMediaSegmentShouldWarn Change-Id: Id8bf00adee32bc9d3e3d3bb18e9176b0b789fb24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810330Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#697799}
-
Henrique Nakashima authored
These methods were added for crbug.com/358708 but the usage was Reverted shortly after and they were not cleaned up. This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/1808082 which was reverted because IDS_UPDATE_FROM_MARKET because an unused resource in builds with arcore disabled. The fix is to move the resource into a section of the strings protected by '<if expr="enable_arcore">', see https://chromium-review.googlesource.com/c/chromium/src/+/1810847/2..3 TBR=dmazzoni@chromium.org,twellington@chromium.org Bug: 995916, 1005188 Change-Id: Ida0ec91096293735e0112d4a5fcc74a406befc99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810847Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#697798}
-