- 18 Feb, 2020 40 commits
-
-
Friedrich Horschig authored
The address filling study was removed in favor of directly setting the respective parameters in a multi-arm experiment. This change should therefore not have any effect at all. Bug: None Change-Id: I9536bae8441032285f6103749b6c62ff0603b702 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056803 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Auto-Submit: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#742287}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d247eaa8..f3d47a2e Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9717a2733db2d51b0d9201c678bf1e552ddc2348 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063068Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#742286}
-
Peter Beverloo authored
Bug: 1052988, 1052989, 1053113 Change-Id: I95827164f73158e7cd3cff3ac2ef338a58a4d2fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062330 Auto-Submit: Peter Beverloo <peter@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
-
Meilin Wang authored
This CL adds a new flag in chrome://flags to enable/disable the Ambient Mode feature. Bug: b/149244227 Test: manually. Change-Id: I7f07020db81fc61962bbe923c62ce1837634d94c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053037 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#742284}
-
Sam Bowen authored
This is a reland of 38b34519 There are no changes in this reland. The fix is in: https://crrev.com/i/2566200/3 This is part of a 2-sided patch which will be submitted just before the above change. Original change's description: > Move entity and property mojo types to //components. > > We will use these types from both blink and //content and from code > inside //components. > > This patch affects Clank downstream and will be submitted together with > a patch in that repo to avoid breakage. Clank CL: > https://crrev.com/i/2545991 > > See discussion in design doc: > https://docs.google.com/document/d/1ZA-1EMq4d40K5qfsZoeMIhJmZA6-AXaSibD3SsqZjfU/edit# > > Bug: 1044252 > Change-Id: Id658caa422bedbcb6d2275a8ccdd76f73bf955c8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051363 > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Becca Hughes <beccahughes@chromium.org> > Commit-Queue: Sam Bowen <sgbowen@google.com> > Cr-Commit-Position: refs/heads/master@{#741227} TBR=beccahughes@google.com,haraken@chromium.org Bug: 1044252 Change-Id: Ib37ff0cfa3913fa1c7c4dc7a956c8efff04b0b17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057740 Commit-Queue: Sam Bowen <sgbowen@google.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#742283}
-
Rouslan Solomakhin authored
Before this patch, payment app class name was called "instrument". This patch renames PaymentInstrument.java into PaymentApp.java in accordance with https://bit.ly/cross-platform-pay-app-factory. The old PaymentAppFactory.java is no longer used anywhere and is removed. The PaymentInstrument.java file is an empty subclass of PaymentApp.java for temporary backward compatibility. The Java integration tests have been updated to install mock payment apps via PaymentAppService.java instead of PaymentAppFactory.java. The mock payment app factory now takes care of filtering mock apps by payment method name and calculating the answer to canMakePayment(). To avoid confusion, test app constants such as HAVE_INSTRUMENTS and DELAYED RESPONSE have been renamed and converted into Android style enums, which helps avoid mistakes by checking parameter types at compile time. After this patch, payment app class name is called "app". Bug: 1022512, 769851 Change-Id: I3f35693fb4f77eee205f3c8ca08b8f6ffe23248d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050784 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#742282}
-
Maggie Chen authored
The crash reports show that the third party software (the Vulkan loader and the Vulkan driver) crashes during vkDestroyInstance() or UnloadNativeLibrary(vulkan_library). To work around it, don't explicitly unload the DLL. Instead, GPU process shutdown will unload all loaded DLLs. Bug: 1047440,1048373 Change-Id: I58483fd373396cdec7344bb82e38056ca51340be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056890 Commit-Queue: Maggie Chen <magchen@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#742281}
-
John Abd-El-Malek authored
Change-Id: Icd7b96a48049116d9738fd826892c589ce467f4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053088 Auto-Submit: John Abd-El-Malek <jam@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#742280}
-
Alex Cooper authored
Updates goldens for several VR tests which seem to have changed from displaying the full URL to just the origin recently. TBR=bsheedy@chromium.org Change-Id: I705e222e4fc3ec579785eed3f5329d6c9103b27e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062753Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#742279}
-
danakj authored
R=avi@chromium.org Change-Id: I38f495d81f028a4a4afefd2cc7f8b718a3bbd68b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062795Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#742278}
-
Demetrios Papadopoulos authored
Bug: 1026426 Change-Id: I9ec2b7e60d2aa1f86907e5535e3ace1d82431932 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056566 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#742277}
-
Miguel Casas authored
Add a note that assert(is_linux) includes is_chromeos and also remove an if(is_linux) since it's implied. The other mod is due to presubmit. No new functionality intended, just cosmetic changes. Bug: 1006266 Change-Id: Ib18350bf595678a28372f120b9f27e6c79943233 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062873 Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Auto-Submit: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#742276}
-
Dave Tapuska authored
Address post review comments from danakj after https://chromium-review.googlesource.com/c/chromium/src/+/2044764 was submitted. BUG=1046424 Change-Id: I8331fceb29ff12d2ec9eda28df9f8b147811de27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062758Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3c4a9d347da1..2e941d00c837 git log 3c4a9d347da1..2e941d00c837 --date=short --first-parent --format='%ad %ae %s' 2020-02-18 fmalita@chromium.org [skottie] Store scalar keyframe values inline Created with: gclient setdep -r src/third_party/skia@2e941d00c837 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: lovisolo@google.com Change-Id: I88bc5a162db5a1aa53f23499dd2caaf602e88b31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062768Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#742274}
-
Michael Sun authored
Stop displaying the dialog window when user initiated connection failed. If the device status changing from "Not Connect" to "Connecting" and then to "Not Connected", it is very clear to the user that previously initiated connection was not succeeded. Displaying a pop-up dialog showing connection failed is disturbing and unnecessary since a failure notification is shown. BUG=b/147671276 Change-Id: I2a27ea6c14225dd8cd0249559dda3228d1ec0f00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031600 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Auto-Submit: Michael Sun <michaelfsun@google.com> Cr-Commit-Position: refs/heads/master@{#742273}
-
Michael Sun authored
Chrome OS Bluetooth stack generated KEY_PLAYCD for media control versus keyboards use KEY_PLAY. Modify Bluetooth specific key into existing keyboard's one. BUG=b/147366099 Change-Id: I9cb060a1942a71ab16d40095a4e7fe7a542149df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031999Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Kevin Schoedel <kpschoedel@chromium.org> Commit-Queue: Michael Sun <michaelfsun@google.com> Cr-Commit-Position: refs/heads/master@{#742272}
-
Mia Glaese authored
Change-Id: Id8a6ff85d690d406feb46310d0e3a1925564e965 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036361Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Commit-Queue: Mia Glaese <glamia@chromium.org> Cr-Commit-Position: refs/heads/master@{#742271}
-
Xing Liu authored
When resuming a download, the suggested path can be content URI. This will hit a DCHECK in CreateReservation. Bug: 1045642 Change-Id: I61c452afafbbc9606f747c84ff18e6b9dc9a0fb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062759Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#742270}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8ef17447d64b..01663f71bc87 Created with: gclient setdep -r src-internal@01663f71bc87 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1052560 Tbr: jbudorick@google.com Change-Id: I6ca06f08d187d7f6adb49de1011e3a794a5efdf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062730Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#742269}
-
Gil Dekel authored
This CL sets the cursor to remain visible during and after the privacy screen is toggled via the keyboard key. Bug: b:147451643 Change-Id: Idb9bf7332d3fea48d015e4acee1d6652f54df754 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063108Reviewed-by:
Jun Mukai <mukai@chromium.org> Commit-Queue: Gil Dekel <gildekel@chromium.org> Cr-Commit-Position: refs/heads/master@{#742268}
-
Michael Sun authored
- Provide DOM |code| mapping for MediaPause, now that it has a distinct evdev code from Pause. - Map DOM |code| MediaPause to DOM |key| MediaPause in the US English layout data. - Map DOM |key| MediaPlay and MediaPause to custom VKEY values in POSIX builds, so that Chrome can handle them as accelerators. BUG=b/148560217 Change-Id: Ifad05827d91df74b5f0ef8e60ff8eb125716f0b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029291 Auto-Submit: Michael Sun <michaelfsun@google.com> Commit-Queue: Michael Sun <michaelfsun@google.com> Reviewed-by:
-
Sebastien Marchand authored
Bug: 1030399 Change-Id: Iae8a083d00e95c4214e360303f30bd2d7dea45e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056107 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#742266}
-
Mikel Astiz authored
Modern clients only deal with lowercase GUIDs because base::GenerateGUID() currently only produces GUIDs in such form. However, in M51 and below, and prior to https://codereview.chromium.org/1906723003, the GUIDs used to be uppercase, and they got synced across devices via proto field |originator_client_item_id|. When introducing GUIDs for bookmarks, and exposing this field via sync in BookmarkSpecifics, things get simplified subtantially if the protocol enforces the invariant that all GUIDs are canonicalized. This patches achieves so by lowercasing when GUIDs are inferred from the problematic originator client item ID, and similarly canonicalizing when GUIDs are loaded from the bookmarks' JSON. TBR=sky@chromium.org Change-Id: I973a2f9058f7e4450f4934fcdc20aedab9c5d0d4 Bug: 1053511,1052789 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062328 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#742265}
-
Tomasz Wiszkowski authored
This flag will allow us to work and experiment with onboarding suggestions for new users. Related CL: http://cl/285006555 Bug: 1050831 Change-Id: Ie6de46f043c50857098a7ee66097b08a2eb6dbc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048765 Commit-Queue: Ender <ender@google.com> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
-
Garrett Beaty authored
The ci buckets set module-level defaults so that if the triggered_by field isn't set it will be triggered by the appropriate git poller, so it is unnecessary to explicitly set it for builders that are only scheduled by the poller. Change-Id: I6f8e345ea60d84b821e7273a02f31a97589a687e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062011 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#742263}
-
Shimi Zhang authored
We removed the usage of HostForURL() in this function, IPAddress::AssignedFromIPLiteral() is tolerated to '\0', so there is no need for this check anymore. Bug: 1030092 Change-Id: I1f37ff138ad1f06eab2bf82223bf7d567dc73e6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057542Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#742262}
-
Tom McKee authored
Bug: 1045064 Change-Id: Iea209c164e7bb4fdd6ca6aff6f692749fbd74659 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050017 Commit-Queue: Tom McKee <tommckee@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#742261}
-
liberato@chromium.org authored
During re-init, we sometimes don't have a codec. This causes a dcheck if we also decide to re-init the codec to increase the input buffer size. If there really is no codec when we re-init (e.g., if we're already in the middle of a reallocation from a previous re-init), then we'll just re-re-init the codec and continue. So, just omit the DCHECK. Bug: 1048341 Change-Id: I199c4ccdce1c169be069ab96593188de76250648 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036277Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#742260}
-
Daniele Castagna authored
.*DrawQuad::OverlayResources::size_in pixels used to be a vector of 4. Looking at the code, we always index the first one and we never use the rest of the array. This reduces the size of TextureDrawQuad that is the biggest DrawQuad. Since QuadList uses the size of the biggest DrawQuad to allocate any quad, this CL will reduce the memory used by QuadList, even if TextureDrawQuads are not used. Change-Id: I554cb1b313519094a893cba6342ad47c15882827 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058834Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Auto-Submit: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#742259}
-
Christos Froussios authored
The save payment icon currently talks with the SaveCardBubbleController. With this CL, it gets its own controller interface. The implementing class stays the same. Bug: 986289 Change-Id: Ic7370ca998fdd9ee8baf453fc2c9919d074cce08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060960 Commit-Queue: Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#742258}
-
Michael Thiessen authored
Going through each of the usages will take some care, so I want to essentially fix the API in a no-op pass and properly migrate each of the callsites independently (or in batches). I'm still working on migrating users of WebContents#getVisibleUrl, but some to the APIs those usages call into are shared by users of Tab#getUrl, so exposing a GURL Tab#getUrl early makes this less painful and requires less duplication and converting. This will be a 3-sided patch: 1. Add the getUrlString() method and migrate upstream usage. 2. Migrate downstream usage to getUrlString(). 3. Change getUrl() to return a GURL (this CL). Bug: 783819 Change-Id: If841d509bff8ea9d2da048021da6ba8635a8cd1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044379 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#742257}
-
Sadrul Habib Chowdhury authored
The sequence numbers in BeginFrameArgs are expected to be incremented based on vsync intervals. Refactor the code for this from DelayBasedBeginFrameSource and ExternalBeginFrameSourceAndroid into a BeginFrameArgsGenerator. This is a simple refactor of the code, and does not change behaviour. BUG=none Change-Id: Idb51e1306dc6e6c64acbe2027cc28df0ba440055 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058032Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#742256}
-
Chong Gu authored
Excluding tests that will crash before we enable cc unittests that use Vulkan renderer. Bug: 1047032 Change-Id: I75d52b9499808d10ce64ab61dfa3a4098f63b590 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053448Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Chong Gu <chonggu@google.com> Cr-Commit-Position: refs/heads/master@{#742255}
-
chrome://omniboxmanukh authored
The debug page compares response and request inputTexts to prevent async responses for old requests from being shown. Responses' inputTexts are trimmed of leading whitespace. The previous CL crrev.com/c/2019927 began trimming both leading and trailing whitespace from the requests' inputTexts. This fixed the case where inputs had leading whitespace, but broke the case where inputs had trailing whitespace. This CL trims only the leading whitespace of requests' inputTexts to match the responses' inputTexts behavior. Bug: 1045343 Change-Id: I93b6158255a99951a8643998e219c9913474e1a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062669Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#742254}
-
Dominic Farolino authored
This CL adds a URLLoaderFactory mojo disconnect handler for OriginPolicyManager to recover its URLLoaderFactory, after factories are reset. This CL also adds a browser test that exercises the disconnect handler, demonstrating that it plays a critical role when e.g., an extension with the declarative web request permission is loaded in the browser, and the NetworkContext's URLLoaderFactories are reset. Co-authored-by:
Domenic Denicola <domenic@chromium.org> Bug: 1047275 Change-Id: Iaa978348d069dfd61bc157ddbe159b1766a0e7ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053228Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/master@{#742253}
-
Avi Drissman authored
BUG=1023913 Change-Id: I11d24c83ca1f8f99fc64c612c383fd3979e00551 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036406Reviewed-by:
-
John Rummell authored
Due to problems on some bots failing to start PulseAudio and causing Chrome startup to hang, avoid trying to initialize PulseAudio if audio output has been disabled. Bug: 986021,1023029,1026849,1035472,1049467 Test: media content_browsertests pass Change-Id: Ib75e44843df6e9e54d85ee4bd164b091ab2ade70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062694 Commit-Queue: John Rummell <jrummell@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
-
Tom McKee authored
TBR=pkasting@chromium.org Change-Id: I906a7918779e5dc17d4cc35406470bca43e1deb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062912Reviewed-by:
Tom McKee <tommckee@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Tom McKee <tommckee@chromium.org> Cr-Commit-Position: refs/heads/master@{#742250}
-
James Cook authored
It was accidentally being registered twice. This didn't cause any user-visible issues, but made the code confusing. Bug: none Test: wallpaper picker still opens from OS settings Change-Id: Ica83d04267ae16d79e4f379e03ea7b6e47110fdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062796 Commit-Queue: James Cook <jamescook@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#742249}
-
Joey Arhar authored
As explained in crbug.com/958524 this post data was only used when using the xhr replay feature on the OPTIONS request of a CORS preflight. Now that OOR-CORS has launched crbug.com/905971 CORS preflights won't show up in DevTools anymore so we don't need to store this extra copy of post data. Bug: 958524, 780935 Change-Id: Ifecb37042c5845dc1bfbd594deb6cb635a3d7c72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051443Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#742248}
-
