- 16 Jul, 2018 40 commits
-
-
Scott Chen authored
Bug: 855205 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Id7c7ea9aa79c704c6971fe477a386f755261e822 Reviewed-on: https://chromium-review.googlesource.com/1135842 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#575439}
-
Peng Huang authored
This CL will create Vulkan instance and Vulkan GrContext when --enable-vulkan is specified. And SkiaOutputSurfaceImpl and SkiaOutputSurfaceImplOnGpu will use the Vulkan GrContext to renderer to replay the SkDDL. Known issues: * RasterDecoder still produces GL textures, it should use the GrContext from GpuServiceImpl. * Media still produce GL textures. * WebGL still produce GL textures. * Browser UI doesn't use RasterDecoder. Bug: 838899 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I1026c70e0916d25a9878767336b106299b9dbce7 Reviewed-on: https://chromium-review.googlesource.com/1126166Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#575438}
-
rbpotter authored
Due to a bug in createCloudJobTicket(), portrait printing to cloud, extension, and privet printers was not working correctly. While auditing new vs old UI in cloud print tickets, also discovered that the old UI sent copies as an integer, not string, and changed new UI to match. Also added tests for createPrintTicket() and createCloudJobTicket(). Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I064a8e323b40cf411d2e12a72d4ffd1d501cd4a0 Reviewed-on: https://chromium-review.googlesource.com/1137475Reviewed-by:
-
Fady Samuel authored
When surface synchronization is off, we lock the UI compositor on Android during the first frame and resize in order to avoid producing a CompositorFrame until the renderer has an appropriate frame ready. Prior to this CL, with surface sync on, we used the default deadline for synchronization. With this CL, we use the same deadlines that were used prior to surface sync on versions of Android O or newer. On versions older than O, we set the deadline for resize to 0. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Idb8f2b3891a9ae1bd43be4d81dbec3ccdb5ff436 Bug: 672962, 857542 Reviewed-on: https://chromium-review.googlesource.com/1132324 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#575436}
-
Xiaocheng Hu authored
Bug: 833380 Change-Id: Ibbe5e66786930313ea10bcba1988df93e91f05e3 Tbr: kenrb@chromium.org NoTry: True Reviewed-on: https://chromium-review.googlesource.com/1138993 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#575435}
-
Mustafa Emre Acer authored
Change-Id: I0d891c28e8e1adb48ab1bd19dbb1aff35970bb5a Reviewed-on: https://chromium-review.googlesource.com/1136977Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#575434}
-
Jacob Dufault authored
LoginDisplayHost owns WizardController, this makes it more obvious. Bug: 851012 Change-Id: Ideb743276be051024b237cd04e68838a02a85ef7 Reviewed-on: https://chromium-review.googlesource.com/1124944 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#575433}
-
Rohit Rao authored
BUG=805213 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I347e8d51e721b776de1a3e484de21b48a8a27a15 Reviewed-on: https://chromium-review.googlesource.com/1138337Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#575432}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/70331946770e..ee72342a5342 git log 70331946770e..ee72342a5342 --date=short --no-merges --format='%ad %ae %s' 2018-07-16 dgarrett@chromium.org Revert "InitSDKStage: Remove chroot_replace argument." Created with: gclient setdep -r src/third_party/chromite@ee72342a5342 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ib0a81249ccd43c255400430c58918e00dfabaeb6 Reviewed-on: https://chromium-review.googlesource.com/1138416Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575431}
-
Ken Rockot authored
The term "View" is too overloaded and has been deemed confusing as the root of so many names central to the Content Service. It also tends to imply visual representation, and the central concept of a navigable-thing encapsulated by the Content Service client library does not in fact require any associated visual representation. Better to rename now than later, sooo... This renames View to NavigableContents, a name which accurately embodies the purpose of the thing without colliding other names or implying more meaning than it should. Also updates some documentation and adds a few missing class comments. No real functional changes. TBR=rsesek@chromium.org Bug: None Change-Id: I8576b62f622116be5effaf4963fc0ea746183931 Reviewed-on: https://chromium-review.googlesource.com/1135915 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#575430}
-
Erik Chen authored
ui::Accelerator had a member platform_accelerator() which was only used on macOS, and provided redundant information. This CL removes the member. Change-Id: Ib3954a2c8ff7197606c946e207dd5d3bd75af66d Bug: 846893, 702823 Reviewed-on: https://chromium-review.googlesource.com/1135644 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#575429}
-
Amy Qiu authored
Update all top real world desktop pages to current websites. In some cases, this required modifying html selectors or removing unnecessary logins. Certain websites were replaced due to no longer existing (yahoo games with twitch.tv) or unusable results (weather.com with accuweather). Expectations related to fixed recordings were deleted, since the tests appear now to be passing. Fixed expectations are tracked here: https://docs.google.com/spreadsheets/d/1GBXuDNh1tZmZWcPZFLtm5UB8MyVPavfdVmi712XP6og/edit?usp=sharing The associate bugs can be resolved if the pages appear to pass consistently later. Bug: 852530 Change-Id: I760f0933d24cf067a4d8148f44c4995d32e1e768 Reviewed-on: https://chromium-review.googlesource.com/1125211Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Amy Qiu <amyqiu@google.com> Cr-Commit-Position: refs/heads/master@{#575428}
-
Lambros Lambrou authored
This applies a rate-limit on sending data over a relayed connection, to avoid lots of packet loss because the b/w estimator does not work well with the relay server implementation. The cap level was determined based on internal discussions with the TURN server team. We may decide to change it in future. For example, the max-bitrate of the connection could be expressed by the TURN service in the ICE config response. Bug: 857287 Change-Id: I5de96749ebd8f647d211738f01bd039edbc94241 Reviewed-on: https://chromium-review.googlesource.com/1125411 Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#575427}
-
Ethan Kuefner authored
Let's see how much time making the HistogramSet (which includes the call to add_reserved_diagnostics) takes. TBR=eyaich Bug: 857283 Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi Change-Id: I0f153df2653612fabe627e70e88fcee1c88f9f20 Reviewed-on: https://chromium-review.googlesource.com/1138730 Commit-Queue: Ethan Kuefner <eakuefner@chromium.org> Reviewed-by:
Simon Hatch <simonhatch@chromium.org> Reviewed-by:
Ethan Kuefner <eakuefner@chromium.org> Cr-Commit-Position: refs/heads/master@{#575426}
-
Ian Kilpatrick authored
This fixes floats-do-not-fit-on-line.html which was two bugs combined. 1) List-markers shouldn't be positioned next to empty line boxes (unless point 2 occurs). This occurs in particular with floats, the list marker should follow the text down (which was the primary bug here). 2) List-markers should only be positioned next to empty line boxes if we are at the "last" line. I believe this includes forced \n breaks. We should produce a line box in these circumstances. This patch also cleans up the "is empty line" logic inside: NGInlineLayoutAlgorithm. Which was previously inconsistent :). Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I9bdc76a5cc40bf8c15651916594c44fd2383097c Bug: 636993 Reviewed-on: https://chromium-review.googlesource.com/1136799Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#575425}
-
Pete Williamson authored
Bug: 758690 Change-Id: I1776317786a6e11e1c966b15cc1921f03360ffe9 Reviewed-on: https://chromium-review.googlesource.com/1121241Reviewed-by:
Jian Li <jianli@chromium.org> Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Commit-Queue: Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/master@{#575424}
-
Anna Offenwanger authored
The VRMagicWindowProvider in WebVR was handed out on device creation. For XR, we want to delay the creation of magic window until the developer indicates that they want a session that requires it. Therefore we are making it so that the VRMagicWindowProvider is only created and returned in RequestSession. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I152b2287a05a0524b32c5017bb0a0b6feb0bda6b Reviewed-on: https://chromium-review.googlesource.com/1108925 Commit-Queue: Anna Offenwanger <offenwanger@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#575423}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b965fcb47296..c45a5c559365 git log b965fcb47296..c45a5c559365 --date=short --no-merges --format='%ad %ae %s' 2018-07-16 fmalita@chromium.org [skottie] Treat color properties as optional (default black) 2018-07-16 senorblanco@chromium.org GrTessellator: collinear edges during sanitize. 2018-07-16 herb@google.com Device interface uses glyph run list Created with: gclient setdep -r src/third_party/skia@c45a5c559365 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:860655 TBR=bungeman@chromium.org Change-Id: I491d21ea6bdd24a7af0debf9ce017d957ebd164e Reviewed-on: https://chromium-review.googlesource.com/1138695Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575422}
-
Max Moroz authored
Was disabled for non ChromeOS platform in https://chromium-review.googlesource.com/1006742 TBR=inferno@chromium.org Bug: 789981 Change-Id: Iab8985e3dd5210bd4ce177cf8f3b60ff63a268d0 Reviewed-on: https://chromium-review.googlesource.com/1138868 Commit-Queue: Max Moroz <mmoroz@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#575421}
-
Peter Kasting authored
This fixes inconsistent separator positioning in non-integral scale factors. Bug: none Change-Id: I4fe92a4b8206db13478d7a0d3176d77e29435db7 Reviewed-on: https://chromium-review.googlesource.com/1137704Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#575420}
-
Xiaocheng Hu authored
Flakes seen in https://goo.gl/WQMoLM Change-Id: I359c43949c7756e71dffbaade185bd7cb6865e6c Tbr: twellington@chromium.org NoTry: True Bug: 813589 Reviewed-on: https://chromium-review.googlesource.com/1138520Reviewed-by:
-
Peter Mayo authored
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=block%2Ffloat%2F003.html show that this test has been consistently passing for a while now. This looks like it was fixed here https://chromium-review.googlesource.com/1124071 but the Expectations were not fixed in the main expectations too. Bug: 810335 Change-Id: Id01dcb0032e57cd191da746275b4ca4d9438c1e6 Reviewed-on: https://chromium-review.googlesource.com/1138733Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Peter Mayo <petermayo@chromium.org> Cr-Commit-Position: refs/heads/master@{#575418}
-
Marcin Wiacek authored
@IntDef/@StringDef annotation are preferred way for declaring set of String/int values: 1. they need less space in APK than enum, see https://developer.android.com/topic/performance/reduce-apk-size#remove-enums 2. they give more control over allowed values than "static final" values Main goal of patch is writing "static final" values, enum and some classes in one common @IntDef/@StringDef form: 1. with @IntDef/@StringDef first, @Retention second and related @interface third 2. with values inside @interface 3. with NUM_ENTRIES declaring number of entries if necessary 4. with comment about numbering from 0 without gaps when necessary 5. with @Retention(RetentionPolicy.SOURCE) 6. without "static final" in the @interface Additionally there are done some other trivial cleanups. Change-Id: I175756ba23f535eb4987b3385c72ab3744ea6ad7 Reviewed-on: https://chromium-review.googlesource.com/1133382Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Cr-Commit-Position: refs/heads/master@{#575417}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/419acc8f4f3b..242c4fe86801 git log 419acc8f4f3b..242c4fe86801 --date=short --no-merges --format='%ad %ae %s' 2018-07-16 jmadill@chromium.org Vulkan: Store ProgramVk shaders in ShaderInfo. 2018-07-16 jmadill@chromium.org Context: Fix missing "setErrorSet". 2018-07-16 jmadill@chromium.org Vulkan: Implement "default" vertex attributes. Created with: gclient setdep -r src/third_party/angle@242c4fe86801 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: Ibc7281ca1edc71a7c748e9abc91b4bc3b333ea6e Reviewed-on: https://chromium-review.googlesource.com/1138414Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575416}
-
Daniel Nicoara authored
Committing properties now updates the property values such that tests can query for the values and validate state. BUG=839487 TEST=Ran unittests Change-Id: I71fd77937d09fdcf36d4ccd10345c5997c6022e4 Reviewed-on: https://chromium-review.googlesource.com/1120691 Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#575415}
-
Robert Sesek authored
- Invoke the SeatbeltExecServer in content::LaunchTests, which is the entrypoint for test child processes when not using bundled binaries. This is how the V2 sandbox is engaged in test environments. - Use the base::mac::BaseBundleID() for the seatbelt parameter, rather than the OuterBundle()'s CFBundleIdentifier. The MachPortBroker uses the former ID. Bug: 689306 Change-Id: I075fa97df87b29b27556dd6edadb717d5742ee60 Reviewed-on: https://chromium-review.googlesource.com/1136525Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#575414}
-
Marcin Wiacek authored
@IntDef/@StringDef annotation are preferred way for declaring set of String/int values: 1. they need less space in APK than enum, see https://developer.android.com/topic/performance/reduce-apk-size#remove-enums 2. they give more control over allowed values than "static final" values Main goal of patch is writing "static final" values, enum and some classes in one common @IntDef/@StringDef form: 1. with @IntDef/@StringDef first, @Retention second and related @interface third 2. with values inside @interface 3. with NUM_ENTRIES declaring number of entries if necessary 4. with comment about numbering from 0 without gaps when necessary 5. with @Retention(RetentionPolicy.SOURCE) 6. without "static final" in the @interface Additionally there are done some other trivial cleanups. Change-Id: I06079828b3941d88bde1cc21985462b464098d57 Reviewed-on: https://chromium-review.googlesource.com/1135531 Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Reviewed-by:
Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#575413}
-
Chris Sharp authored
Bug: 830892 Change-Id: I0621b9b69cd84e539231e535562f7c34b75fa1ca Reviewed-on: https://chromium-review.googlesource.com/1136941 Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#575412}
-
Chris Sharp authored
Change-Id: I79a90c7476221c0481e81abad16f4612682d0e26 Reviewed-on: https://chromium-review.googlesource.com/1136865Reviewed-by:
-
Jian Li authored
Bug: 859849 Change-Id: I88b4dc690cef0d482bb9f4a49a9aa7b688e8ae45 Reviewed-on: https://chromium-review.googlesource.com/1136470Reviewed-by:
Peter Williamson <petewil@chromium.org> Commit-Queue: Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#575410}
-
Lei Zhang authored
Add test cases for GetPDFDocInfo() and GetPDFPageSizeByIndex(). Since these tests exercise PDFium with V8 enabled, there needs to be additional calls to code in gin/v8_initializer.h. Change-Id: I24e2ed21b850a7e1fb65ebb0c0c8948447641710 Reviewed-on: https://chromium-review.googlesource.com/1136015 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#575409}
-
Caleb Rouleau authored
Chromium Embedded Framework sometimes uses an in-memory user-data-dir, so the DevToolsActivePort file is not a viable option for them. We think it is likely that other Chromium variants, present or future, may have trouble with the DevToolsActivePort file, so this should make things easier for them. Also, fix testConnectToRemoteBrowser to 1. Have retries so it passes in the case of a race condition for port allocation. 2. Prevent a race with Chrome during teardown. -- Note that this race was causing the user-data-dir to not be deleted at the end. Bug: 863247 Change-Id: I506be26fc2e282b7194afd88afd02efcec65e880 Reviewed-on: https://chromium-review.googlesource.com/1137440 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#575408}
-
Kurt Horimoto authored
Bug: 862307 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I19f4051c152b0933d3142f734e9a253bea2b577d Reviewed-on: https://chromium-review.googlesource.com/1137257Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#575407}
-
Kenneth Russell authored
GpuCrash_GPUProcessCrashesExactlyOncePerVisitToAboutGpuCrash is failing intermittently on macOS in general, not just on the ASAN bot. Bug: 861956 Tbr: bsalomon@chromium.org Tbr: ethannicholas@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ib1c2e4f165c8f658e354559e62eea1b34d825ab4 Reviewed-on: https://chromium-review.googlesource.com/1138742 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#575406}
-
Fady Samuel authored
Right now, with surface sync off on Android, we will defer commits any time there's a size change, even if we've evicted the current surface. Change-Id: I7e1ae394e20eef2a46bca5ae9a8fc8a4cdf35e0b Bug: 848292, 672962 Reviewed-on: https://chromium-review.googlesource.com/1121098Reviewed-by:
Saman Sami <samans@chromium.org> Reviewed-by:
-
Michael Thiessen authored
Experiments here didn't really pan out - we would need APIs from the platform that aren't going to implemented any time soon - if ever. So we can remove this code. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I58e9d29bf6589cf5900667828f32af3bc98012d8 Reviewed-on: https://chromium-review.googlesource.com/1128254Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#575404}
-
Stephen McGruer authored
This reverts commit 73716e90. Reason for revert: Causes assertions in CTS tests because data can be null - see http://crbug.com/864152 Bug: 864152 Original change's description: > Add histogram to measure usage of '#' in WebView loadData APIs > > The goal is to compare how often this histogram is logged with the > existing kDataUriHasOctothorpe UseCounter for WebView, in order to > determine what API path we might want to modify when doing a compat > fix. The belief is that the histogram and UseCounter should be > roughly comparable because the histogram will only be recorded at most > once per site load (because the loadData APIs cause a site load). > > Bug: 823666 > Change-Id: I0ce63b8c86bc3bcd02d3b10ab7a38112fb520439 > Reviewed-on: https://chromium-review.googlesource.com/1112045 > Commit-Queue: Stephen McGruer <smcgruer@chromium.org> > Reviewed-by: Bo <boliu@chromium.org> > Reviewed-by: Timothy Dresser <tdresser@chromium.org> > Reviewed-by: Robert Kaplow (slow) <rkaplow@chromium.org> > Cr-Commit-Position: refs/heads/master@{#575268} TBR=boliu@chromium.org,rkaplow@chromium.org,torne@chromium.org,tdresser@chromium.org,smcgruer@chromium.org Change-Id: Ic09f8689505c5e5bafdb052970f993428bac5e78 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 823666 Reviewed-on: https://chromium-review.googlesource.com/1138519Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#575403}
-
Malay Keshav authored
Right now we clip(GL_SCISSOR) the display buffer based on the physical pixel size of the display. The pixel size we send to the ui compositor is the size we receive from the platform window(the display in Chrome OS). However, this may not be what we want if the platform has some fractional scale applied. UI elements have their sizes set in DIP. If some UI element (ui::Layer) has its size set to the DIP size of the display, their scaled size (the pixel size after applying device scale factor) after rounding may not match the physical pixel size of the display. This difference may lead to 1px lines left unclipped. This happens in the case of the shelf whose width is set to the width of the display. For a device like eve where the internal display has a physical resolution width of 2400px, if a device scale of 1.8 is applied, the DIP width of the display becomes 1333. We set the bounds of the shelf to this. Now when we do the actual paint, we scale the shelf to its physical pixel size which is ROUND(1333*1.8) = 2399. At the same time the compositor will clip things at width 2400. This difference is what gives the shelf a 1px gap. A proper way to fix this is to scale ui::Layer bounds such that it snaps to the parent's or displays edge similar to what pixel canvas does in views::View. However, that is a large change. In the meantime this patch sets the correct physical pixel size for the compositor so that correct clipping happens. Bug: 843354 Change-Id: Ic9e055c0ba39d85a7297809baf946398bf09f40a Component: UI compositor, pixel canvas, scaling, HiDPI Reviewed-on: https://chromium-review.googlesource.com/1130495Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
-
Lindsay Pasricha authored
since it's included in screen_size_dependent_tests. Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ida1867fd77e401909ea21e3bdce491158759ff05 Reviewed-on: https://chromium-review.googlesource.com/1133898 Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#575401}
-
manuk authored
When the user activates the omnibox popup, the popup suggestions have favicons and bookmark stars when appropriate. Selecting one (either because one is selected by default or by using the arrow or tab keys), displays the suggested match in the omnibox textfield. Previously, when the selected suggestion had a favicon or bookmark star icon, the omnibox would display the url or search icons. There is still a discpreency between omnibox and omnibox popup suggestion icons; with material refresh active, search suggestion icons will display the default search icon (magnifying glass) whereas the omnibox will display the default search provider's icon if available (`G` for Google). Bug: 856755 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I5874d72d0bde711fb3870a1ab0fd1f6e5c699eb8 Reviewed-on: https://chromium-review.googlesource.com/1124671 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#575400}
-
