GitLab

To track permission usages even for constant permissions, call
PermissionUmaUtil::PermissionRequested() for such permission types from
PermissionManager::RequestPermissions().

BUG=n/a

Review-Url: https://codereview.chromium.org/2026663002
Cr-Commit-Position: refs/heads/master@{#397075}

IPC messages including WebSocket messages are dispatched on the default
task runner. We found WebSocket message handlers might call V8
functions. We plan to implement purge + suspend background tabs and need
to suspend all V8 function calls when purge + suspend happens, but the
default task runner can't be suspended since it'd be dangerous. Thus,
this CL delegates WebSocket message handlers from the default task
runner to the loading task runner.

BUG=607077
TEST=n/a

Review-Url: https://codereview.chromium.org/2000113002
Cr-Commit-Position: refs/heads/master@{#397074}

For the switch kEnableTransparentVisuals to be effective it requires
a compositing manager to run. Indeed ui::ChooseVisualForWindow checks
for the presence of the Atom _NET_WM_CM_S0 before looking for a 32
bit depth compatible visual.

BUG=589509

R=dpranke@chromium.org, piman@chromium.org, sky@chromium.org, danakj@chromium.org

Review-Url: https://codereview.chromium.org/2008833002
Cr-Commit-Position: refs/heads/master@{#397073}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/c10547f3..5199aa0a

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2027073003
Cr-Commit-Position: refs/heads/master@{#397072}

I had different arguments in the code that the ones with which the histogram was constructed resulting in an error:
F/chromium(15305): [FATAL:record_histogram.cc(59)] Check failed: histogram->HasConstructionArguments(expected_min, expected_max, expected_bucket_count). NewTabPage.Snippets.CardClickedAge/0/4320/50 vs. NewTabPage.Snippets.CardClickedAge/1/4320/50

BUG=615379

Review-Url: https://codereview.chromium.org/2017013004
Cr-Commit-Position: refs/heads/master@{#397071}

BUG=591500
TBR=wangxianzhu@chromium.org

Review URL: https://codereview.chromium.org/2027903002 .

Cr-Commit-Position: refs/heads/master@{#397070}

This patch introduces |m_scriptState| member variable to
|ScriptCustomeElementDefinition| class to hold |ScriptState| pointer, to
return |ScriptValue| for JavaScript's constructor, prototype, callbacks,
etc, on the context where JavaScript values created.

This patch is a preparation of crrev.com/1994093002, introduce
|CustomElementRegistry#get()| method.

BUG=594918
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2030443003
Cr-Commit-Position: refs/heads/master@{#397069}

BUG=576867
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2026163002
Cr-Commit-Position: refs/heads/master@{#397068}

This CL implements StructTraits for the following types:

1. gpu::Mailbox
2. gpu::MailboxHolder
3. gpu::SyncToken
4. cc::ReturnedResource

This CL also implements unit tests in both gpu/ipc/common
and cc/ipc that test these traits.

BUG=611802
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2019833002
Cr-Commit-Position: refs/heads/master@{#397067}

The existing check for web accessible resources is inadequate and allows
navigations to non-whitelisted pages to succeed. This patch ensures that
the document is listed explicitly in the manifest when a navigation is
performed to it.

BUG=576867

Review-Url: https://codereview.chromium.org/2007133004
Cr-Commit-Position: refs/heads/master@{#397066}

The difference between Node::containingTreeScope() and Node::treeScope() is that
Node::containingTreeScope() asserts that the node is in a treeScope.
Node::treeScope() does not.

Replace some of the current usage of Node::treeScope() with
Node::containingTreeScope() if containingTreeScope() is better to express their
intention.

This CL also introduces Element::adjustedFocusedElementInTreeScope() to optimize
some code path where we can early exit if the element is not in a tree scope.

BUG=602556

Review-Url: https://codereview.chromium.org/1883083002
Cr-Commit-Position: refs/heads/master@{#397065}

BUG=613971

Review-Url: https://codereview.chromium.org/2011283002
Cr-Commit-Position: refs/heads/master@{#397064}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/6177191d52ce..e288c0d9a188

$ git log 6177191d5..e288c0d9a --date=short --no-merges --format='%ad %ae %s'

BUG=604791

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2024863003
Cr-Commit-Position: refs/heads/master@{#397063}

fast/text/international/inline-block-with-mixed-direction-words.html
is changed by adding a   to tolerate the anti-aliased text stroke
overflow.

BUG=521730
TBR=wangxianzhu@chromium.org

Review-Url: https://codereview.chromium.org/2027053003
Cr-Commit-Position: refs/heads/master@{#397062}

Move the hotspot logic out of CSSCursorImageValue to keep it as a
constant object (except for the image cache). This is prework to make
all StyleBuilderFunctions take a const CSSValue&.

This also fixes a bug where the hotspot of an SVG cursor element was
being overridden by the element's specified hotspot even when the
hotspot was specified in CSS. Now the hotspot is only overridden if it
is not specified in the CSS, but is specified in the SVG.

Note: When getting the computed style for SVG cursors, Firefox always
returns the URL to the SVG element, and doesn't support intrinsic
hotspot definition.

Relevant Spec: https://drafts.csswg.org/css-ui/#cursor

BUG=526586

Review-Url: https://codereview.chromium.org/2018923002
Cr-Commit-Position: refs/heads/master@{#397061}

This patch separates ServiceWorker.PageLoad for serviceworker into the two: w/
and w/o fetch handler in order to measure the impact of the no-fetch handler
optimization.

BUG=605844

Review-Url: https://codereview.chromium.org/2025813002
Cr-Commit-Position: refs/heads/master@{#397060}

Fixed getComputedStyle() for CSSPropertyCursor to include the hotSpot,
if it's defined.

Review-Url: https://codereview.chromium.org/2028493002
Cr-Commit-Position: refs/heads/master@{#397059}

BUG=616265
TEST=none
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2024313002
Cr-Commit-Position: refs/heads/master@{#397058}

The DCHECKs in SyncPointClientState::ReleaseFenceSync and
GpuCommandBufferStub::OnCreateImage test client behavior,
which is untrusted. DLOG_IF instead.

BUG=None
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2025223002
Cr-Commit-Position: refs/heads/master@{#397057}

BUG=None
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2028943002
Cr-Commit-Position: refs/heads/master@{#397056}

Minor clean-up change, not urgent.

Review-Url: https://codereview.chromium.org/2011053002
Cr-Commit-Position: refs/heads/master@{#397055}

These files have no particular need to be executable or to have a shebang line;
they're imported and used by test_importer, which is used by import-w3c-tests.

Review-Url: https://codereview.chromium.org/2006273004
Cr-Commit-Position: refs/heads/master@{#397054}

Review-Url: https://codereview.chromium.org/2014883002
Cr-Commit-Position: refs/heads/master@{#397053}

Review-Url: https://codereview.chromium.org/2012963002
Cr-Commit-Position: refs/heads/master@{#397052}

https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/3b5957b..2211435

BUG=
TEST=bots
TBR=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.linux:linux_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2026173002
Cr-Commit-Position: refs/heads/master@{#397051}

It's allowed by the spec (and by the implementation), so we shouldn't DCHECK.

BUG=None
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2030483002
Cr-Commit-Position: refs/heads/master@{#397050}

In wide mode, ensure the input field gets focus rather than the search
icon when tabbing. The toolbar will only expand when the user starts
typing.

BUG=615318
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2025583002
Cr-Commit-Position: refs/heads/master@{#397049}

BUG=615178

Review-Url: https://codereview.chromium.org/2024103005
Cr-Commit-Position: refs/heads/master@{#397048}

The extension adds a function DescheduleUntilFinishedCHROMIUM that allows
clients to throttle themselves. From the perspective of the client, the command
performs the equivalent of a service side glFinish.

BUG=581777
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2021603002
Cr-Commit-Position: refs/heads/master@{#397047}

BUG=612653

Review-Url: https://codereview.chromium.org/2006023002
Cr-Commit-Position: refs/heads/master@{#397046}

This change makes FontResourceClient a GarbageCollectedMixin
subclass.

Registering a prefinalizer in a class T is not possible when
 - T has multiple GarbageCollectedMixin base classes, and
 - T doesn't have USING_GARBAGE_COLLECTED_MIXIN statement.

Hence this CL modifies ResourceOwner<R, C> definition so that it
inherits GarbageCollectedMixin only when C is not derived from
GarbageCollectedMixin.

BUG=587663

Review-Url: https://codereview.chromium.org/2014533002
Cr-Commit-Position: refs/heads/master@{#397045}

Many executables are missing embedded manifest files when built with gn.
This causes OS compatibility information to be omitted which can lead
to strange behavior. This adds a manifest to bro.exe.

BUG=602505

Review-Url: https://codereview.chromium.org/2028743002
Cr-Commit-Position: refs/heads/master@{#397044}

BUG=608824

Review-Url: https://codereview.chromium.org/2029493002
Cr-Commit-Position: refs/heads/master@{#397043}

Many executables are missing embedded manifest files when built with gn.
This causes OS compatibility information to be omitted which can lead
to strange behavior. This adds a manifest to app_list_demo.exe.

BUG=602505

Review-Url: https://codereview.chromium.org/2027753002
Cr-Commit-Position: refs/heads/master@{#397042}

A table section's normal box-shadow is painted before backgrounds of
colgroup, col and section are painted behind cells, then inset box-shadow.

A table row's normal box-shadow is painted before its background is
painted behind cells, then inset box-shadow.

BUG=94871

Review-Url: https://codereview.chromium.org/1963313002
Cr-Commit-Position: refs/heads/master@{#397041}

Another issue similar to 605884.

BUG=614992
R=benwells@chromium.org

Review-Url: https://codereview.chromium.org/2012273002
Cr-Commit-Position: refs/heads/master@{#397040}

This patch removes a stale comment in typedcssom/cssKeywordValue.html,
the bug was fixed previously by codereview.chromium.org/1778743003.

BUG=584999

Review-Url: https://codereview.chromium.org/2024773002
Cr-Commit-Position: refs/heads/master@{#397039}

Cr-Commit-Position: refs/heads/master@{#397038}

The prerequisite for doing this TODO has been done long ago.

BUG=531296

Review-Url: https://codereview.chromium.org/2026953003
Cr-Commit-Position: refs/heads/master@{#397037}

omnibox search.

BUG=616191
TEST=looking glass should be the same size when tab to search is activated
as when the omnibox is being used for a default search engine search

Review-Url: https://codereview.chromium.org/2023013003
Cr-Commit-Position: refs/heads/master@{#397036}