- 06 Feb, 2018 40 commits
-
-
Mitsuru Oshima authored
BUG=803442 TEST=Covered by unittest. Also tested manually. Change-Id: I1b77c6d589596f66ed1bc9135d6be26318df872a Reviewed-on: https://chromium-review.googlesource.com/882301 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#534627}
-
Pavel Feldman authored
Change-Id: I01e1be7fd273dd54f75968f32b2d27889b017dd8 Reviewed-on: https://chromium-review.googlesource.com/902901 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#534626}
-
https://chromium.googlesource.com/catapult.git/+log/6d0f862d8710..a1303e46889b $ git log 6d0f862d8..a1303e468 --date=short --no-merges --format='%ad %ae %s' 2018-02-05 dtu [pinpoint] Use Gerrit patch info for bug emails. 2018-02-05 eakuefner [Telemetry] Add PageTestResults.AddSharedDiagnostic Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I537c233bd5840539011e23b230047acfb289673c Reviewed-on: https://chromium-review.googlesource.com/902896Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#534625}
-
https://skia.googlesource.com/skia.git/+log/f7b659ab3ce2..92f93799e8ae $ git log f7b659ab3..92f93799e --date=short --no-merges --format='%ad %ae %s' 2018-02-06 angle-skia-autoroll Roll skia/third_party/externals/angle2/ a8fe18fc5..44dcb911c (2 commits) 2018-02-05 angle-skia-autoroll Roll skia/third_party/externals/angle2/ b54206643..a8fe18fc5 (1 commit) Created with: roll-dep src/third_party/skia BUG=805233 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=bsalomon@chromium.org Change-Id: Ie810534681a1651192ee9526fa0810f0a47de01b Reviewed-on: https://chromium-review.googlesource.com/903368 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#534624}
-
Darren Shen authored
Currently, we don't have any test coverage over properties. In our existing tests, we only use 'canonical' test properties like 'width'. This means that it's possible that other properties (e.g. 'height') might not work and we still pass the tests. We add a bunch of new files, each representing a property. Think of these as metadata for the properties. For example, each file contains the values that are valid for that property. We then have a test suite that uses this metadata to generate appropriate tests. More properties will be coming. There is a test failure involving setting margin-top to unitless zero. Bug: 774887 Change-Id: I8f8463c8f608454ef177e81ace21fe1eeb66f897 Reviewed-on: https://chromium-review.googlesource.com/882901 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
nainar <nainar@chromium.org> Cr-Commit-Position: refs/heads/master@{#534623}
-
rbpotter authored
Bug: 773928 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I7089a22f7e9ed0da2a1df1320f0a3d1e511a5c67 Reviewed-on: https://chromium-review.googlesource.com/902793Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#534622}
-
Kent Tamura authored
custom-elements: Fix a bug that HTML parser didn't set custom element state correctly for unknown "is" attribute value. In HTML parser, if custom element definition is not found and the element local name is invalid for custom element name, custom element state of the element was set to "Uncustomized", which won't be upgraded. It should be "Undefined" if "is" attribute exists. Also, CustomElementRegistry::AddCandidate() didn't pick up a correct name for customized built-in candidates. A Blink layout test for :defined is upstreamed to WPT. Bug: 736967 Change-Id: I583073eabc4ac276c6990161516c7b289905909b Reviewed-on: https://chromium-review.googlesource.com/903423Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#534621}
-
Sergey Ulanov authored
Bug: 796979, 485650 Change-Id: Ifc0d7076c685f12207dc36c550eb36cf97d4faea Reviewed-on: https://chromium-review.googlesource.com/902795Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#534620}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=anantha@chromium.org Change-Id: I6287213f174a328ab919ec19c2aada80af38177a Reviewed-on: https://chromium-review.googlesource.com/902846Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#534619}
-
Helen Li authored
This CL adds Multicast options and setters to udp_socket.mojom. Bug: 721401 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I3d6fd2a1c491caea7ed004a47a2b254e84d2f2c5 Reviewed-on: https://chromium-review.googlesource.com/891447Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Randy Smith <rdsmith@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#534618}
-
Paul Irish authored
Change-Id: I0a63a4ad9360a952a35bf4bbc360a7dd1f6b3be3 Reviewed-on: https://chromium-review.googlesource.com/902883Reviewed-by:
Patrick Hulce <phulce@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Paul Irish <paulirish@chromium.org> Cr-Commit-Position: refs/heads/master@{#534617}
-
Stefan Zager authored
Prior to this patch, the clipping box offset erroneously appeared in both the child containment layer position and the main graphics layer position. BUG=711468 R=skobes@chromium.org,chrishtr@chromium.org Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I7931b0b7ea94fce121232d2ab52a55375994224d Reviewed-on: https://chromium-review.googlesource.com/903263Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#534616}
-
Ehsan Chiniforooshan authored
Looks like there are some crashes caused by trace_config_ being null while generating the metadata: https://crash.corp.google.com/browse?q=expanded_custom_data.ChromeCrashProto.magic_signature_1.name%3D%27base%3A%3Atrace_event%3A%3ATraceConfig%3A%3AToDict%27 I'm not 100% sure what the cause of those crashes is, but this CL fixes one possible scenario. Bug: 806627 Change-Id: Id52a9b1a8f06400efe58c0f1a1ccf2adb92a1629 Reviewed-on: https://chromium-review.googlesource.com/900466 Commit-Queue: Ehsan Chiniforooshan <chiniforooshan@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#534615}
-
Maajid authored
Bug: 807876 Test: Confirmed locally that this would have caught the regression. Change-Id: I13880896420471a8e0d5325d2453306b11f37fe8 Reviewed-on: https://chromium-review.googlesource.com/897289Reviewed-by:
Kazuhiro Inaba <kinaba@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Maajid <maajid@chromium.org> Cr-Commit-Position: refs/heads/master@{#534614}
-
Bill Orr authored
The issue here is that we weren't recycling color buffers, and creation of new buffers can be slow (in the order of 20ms) depending on color format. BUG=798112 Change-Id: Ibecc5815f5386d13bc776cb85e2aee20756964d6 Reviewed-on: https://chromium-review.googlesource.com/899957 Commit-Queue: Bill Orr <billorr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#534613}
-
Blake O'Hare authored
Currently it is being invoked immediately. This will invoke it at a more appropriate time (upon showing the new keyboard layout animation when the keyboard content window still virtually no opacity). Bug: 806189 Change-Id: I19464b1bdc9eb688888d96e98f890d12d67a4a3d Reviewed-on: https://chromium-review.googlesource.com/895226Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Blake O'Hare <blakeo@chromium.org> Cr-Commit-Position: refs/heads/master@{#534612}
-
Peter Collingbourne authored
This fixes a gn failure (svn info in //third_party/llvm) when building with a self-built clang and llvm_force_head_revision=true. Change-Id: If56bea54b58482cb3a4f864ee2bf4a8b66f0beef Reviewed-on: https://chromium-review.googlesource.com/903081 Commit-Queue: Peter Collingbourne <pcc@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#534611}
-
Victor Costan authored
https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/0062e4869f07..ea31cb15f0c2 This CL also removes the GTEST_UNSUPPORTED_DEATH_TEST definition from //base/test/gtest_util.h. Google Test moved the definition from an internal header to the public API, so we don't need to carry a copy anymore. $ git log 0062e4869..ea31cb15f --date=short --no-merges --format='%ad %ae %s' 2018-01-31 misterg Merges and also adding new bazel build mode 2018-01-30 misterg Code merges 2018-01-30 misterg Ability to optionally depend on Abseil plus upstream of 183716547 2018-01-26 misterg Adding tests to googlemock bazel 2018-01-26 misterg Code merges 2018-01-26 lidaobing Update Documentation.md 2018-01-25 stefano.soffia.it Fix test build issue with GCC7.2. 2018-01-25 gennadiycivil Update README.md 2018-01-25 gennadiycivil Remove Visual Studio 10,11,12 from build matrix 2018-01-24 misterg placating gcc and its overzeauls size comparison warnings 2018-01-24 misterg upstream cl 182543808 2018-01-24 misterg revert, lets get this compiled 2018-01-23 misterg Many code merge/upstream changes 2018-01-23 misterg Merging, upstream http://cl/182836545 2018-01-22 misterg more code merge 2018-01-22 misterg merges, cl/155419551 and other 2018-01-22 misterg more merging 2018-01-22 misterg merging 2018-01-22 misterg code merge 2018-01-18 misterg Adding python tests to Bazel build file. 2018-01-18 ftrushkin Use fully qualified in examples 2018-01-18 ftrushkin Document ScopedTrace utility 2018-01-11 pcc Check whether _MSC_VER is defined when detecting presence of cxxabi.h under libc++. 2018-01-17 ftrushkin Expose ScopedTrace utility in public interface 2018-01-15 misterg Reverting some changes, need to make the merge compile 2018-01-15 misterg Reverting some changes, need to make the merge compile 2018-01-15 misterg Reverting some changes, need to make the merge compile 2018-01-15 misterg Reverting some changes, need to make the merge compile 2018-01-15 misterg Test files for corresponding changes 2018-01-15 misterg Test files for corresponding changes 2018-01-15 misterg Test files for corresponding changes 2018-01-15 misterg Test files for corresponding changes 2018-01-15 misterg More code merges 2018-01-15 misterg Code merging 2017-08-14 gaspard.petit Added support for WINAPI_PARTITION_TV_TITLE which is defined on XboxOne 2017-08-14 gaspard.petit Added support for WINAPI_PARTITION_TV_TITLE which is defined on XboxOne 2018-01-11 misterg continue upstream/merge, etc 2018-01-11 gennadiycivil Update .travis.yml 2018-01-11 gennadiycivil Update .travis.yml 2018-01-11 gennadiycivil Update .travis.yml 2018-01-11 gennadiycivil Update .travis.yml 2018-01-11 misterg Trying to fix travis 2018-01-11 misterg Upstream cl 103120214 2018-01-10 misterg More merge, cleanup 2018-01-10 misterg More merge, cleanup 2018-01-10 misterg Code merge, upstreaming accumulated changes, cleanup 2018-01-10 misterg revert 2018-01-10 misterg code merges, cleanup 2018-01-10 misterg revert googletest/test/gtest-param-test_test.cc 2018-01-10 gennadiycivil Update .travis.yml 2018-01-09 misterg code merge, cleanups 2018-01-09 misterg Upstream of cl 129104714 2018-01-09 misterg Revert one file 2018-01-09 misterg wip, cleanups/merge 2018-01-09 misterg cleanup, merge 2018-01-07 loorongjie [Bazel] Detect Windows with cpu value x64_windows and x64_windows_msvc 2018-01-08 misterg Small cleanups, merge 2018-01-05 coryan Use correct name for build event types. 2018-01-05 misterg Revert one file for now 2018-01-05 coryan Fixed test for pull request. 2018-01-05 coryan Fixed output and test for 'enabled_on_pr' 2018-01-04 misterg code cleanup in preparation for merges, cl 180857299 2018-01-04 coryan Optimize build matrix (#1) 2018-01-03 gennadiycivil upstreaming cl 124976692 2018-01-03 davidben Also define GTEST_ATTRIBUTE_PRINTF_ in clang-cl. 2017-02-10 davidben Pass the -Wmissing-declarations warning. 2018-01-02 misterg OSS Sync, cl 163329677 2018-01-02 davidben Fix testing::Combine on MSVC 2017. 2017-05-06 davidben Avoid warning C4619 in MSVC 2017. 2017-12-24 coryan Build both googletest and googlemock. 2017-12-24 coryan Create a autotools-based build for Travis. 2016-05-18 gregory.pakosz Re-enable MSVC++ C4389 warning in CmdHelperEq() 2017-12-03 coryan Run autoconf from top-level directory. 2017-12-02 romain.geissler Fix double free when building Gtest/GMock in shared libraries and linking a test executable with both. 2017-08-14 gaspard.petit Added support for WINAPI_PARTITION_TV_TITLE which is defined on XboxOne 2017-01-20 davidben Pass MSVC's C4826 warning. Created with: roll-dep src/third_party/googletest/src Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Icd43abc02683c2398f9e1033509382b9f3000022 Reviewed-on: https://chromium-review.googlesource.com/900544Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#534610}
-
Klaus Weidner authored
Change 7332d074 "[vr] Add controller tooltips" changed the OnVSync controller handling to overwrite render_info_primary_.head_pose, and if this happened in between DrawFrame and DrawIntoAcquiredFrame it would submit with a wrong pose, leading to jerky head tracking. The fix is to always use the saved WebVR pose and ignore the render_info_primary_.head_pose member. BUG=808147 Change-Id: I1c9b3e9c9e7dad6c9dff2837ae00d46a6fecb915 Reviewed-on: https://chromium-review.googlesource.com/903542Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#534609}
-
Daniel Murphy authored
Bug: 782356 Change-Id: I571b3780b314517097585af1dd488f360511ef80 Reviewed-on: https://chromium-review.googlesource.com/757168 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#534608}
-
https://chromium.googlesource.com/angle/angle.git/+log/338abb469bba..44dcb911c00e $ git log 338abb469..44dcb911c --date=short --no-merges --format='%ad %ae %s' 2018-02-02 geofflang Decode R11 and RG11 EAC formats into 16-bit textures. 2018-02-05 geofflang StateManagerGL: Rework query tracking (again) 2018-02-05 geofflang GL: Fix usage of glGetInternalFormativ. 2018-02-02 lucferron Add end2end test for GL_TRIANGLE_FAN in SimpleOperationTest 2018-02-05 jmadill Add a dotfile_settings GN config file. 2018-02-02 lucferron Add end2end tests for GL_LINES and GL_LINE_STRIP Created with: roll-dep src/third_party/angle BUG=805233 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: Ic9233e0a947c1cdddc98f256d6b3ec4809b7d1af Reviewed-on: https://chromium-review.googlesource.com/902895Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#534607}
-
Bill Budge authored
- Refactors tests into simpler subtests. - Replaces flaky collision testing with proper randomness tests, copied from V8's PRNG tests. Bug: chromium:788948 Change-Id: I39597dcdde591e5102dbac6e5a706681615073d0 Reviewed-on: https://chromium-review.googlesource.com/894268 Commit-Queue: Bill Budge <bbudge@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#534606}
-
Victor Costan authored
This always returns true, and the comments around it are misleading. Bug: 807093 Change-Id: Ifb5c7e7e079a09e397123e82dc0659814f4c8a42 Reviewed-on: https://chromium-review.googlesource.com/898464Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Chris Mumford <cmumford@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#534605}
-
Steven Bennetts authored
Note: This section and icon is CrOS only. Bug: 800931 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I0a56d90f5db67fa564bad083469310cf5d87bb90 Reviewed-on: https://chromium-review.googlesource.com/903186Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#534604}
-
Pavel Feldman authored
Change-Id: Ib2da06ea4aa899a30773fce8696ec2200c033895 Reviewed-on: https://chromium-review.googlesource.com/900526 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#534603}
-
Andrew Grieve authored
NOTRY=true Change-Id: I4d28a4734a5aec2fe5d2c0ad5db39e9810c90722 Reviewed-on: https://chromium-review.googlesource.com/900423Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#534602}
-
Mitsuru Oshima authored
Views client is supposed to use Widget::SetCursor so that it can tell the correct cursor when asked via GetCursor on Widget. Exo pointer should follow the same pattern and Arc notification should simply use the cursor on the widget. TBR=yoshiki@chromium.org BUG=798056 TEST=manual. Cursor does not flicker on ARC notifications Change-Id: I09e93526181c9707786ff1a9b0eb4cb682e6026b Reviewed-on: https://chromium-review.googlesource.com/903223Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#534601}
-
Zhenyao Mo authored
https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/d458ada..98a3d3b Tbr: zmo@chromium.org Cq-Include-Trybots: master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.angle:linux_angle_rel_ng;master.tryserver.chromium.angle:win_angle_rel_ng Change-Id: I1dd250dd5372afeebc5b7b00443474eea9bb7f73 Reviewed-on: https://chromium-review.googlesource.com/899865 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#534600}
-
Ke He authored
The geolocation will be moved into //services as its internal part. The interfaces like SetRequestContextProducer and SetApiKey shouldn't be called outside the Device Service. BUG=800659 Change-Id: I8641e0b51f45d52aa14f28622508ce9571df6d76 Reviewed-on: https://chromium-review.googlesource.com/882666Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Ke He <ke.he@intel.com> Cr-Commit-Position: refs/heads/master@{#534599}
-
Sunny Sachanandani authored
Some pages were disabled by commenting out code. This makes refactoring annoying so migrate these to expectations. BUG=760553 Change-Id: I85f109d8c0093403693e39290e4d7c41cbe9662d Reviewed-on: https://chromium-review.googlesource.com/891817 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#534598}
-
Stefan Zager authored
Speculative fix for crasher: if the accessibility notification callback modifies the DOM tree, it may cause unspecified behavior. Note that the crash only happens when using WebFrameTestClient, so it doesn't affect users. BUG=808767 R=skobes@chromium.org Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I53183a9642b875d27468ddb10027b0efb6feb689 Reviewed-on: https://chromium-review.googlesource.com/902775Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#534597}
-
Eugene But authored
Model code was moved from DownloadManagerCoordinator to DownloadManagerMediator. This removes the need for downloadManagerTabHelper:didUpdateDownload: callback, because mediator can observe download task updates. Bug: 791806 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I29928c864429be63ef44f1894ac9a368cf87f296 Reviewed-on: https://chromium-review.googlesource.com/894637Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#534596}
-
Jinsuk Kim authored
Moves a mock class for WebContents/RenderFrameHost to content.test.mock so that they can be shared by various tests. Change-Id: I54e47182a35b4ddb5ef98fd4af9f1fb4ca4b53ab Reviewed-on: https://chromium-review.googlesource.com/895425 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#534595}
-
Eugene But authored
Creating a pending entry is cruft code from UIWebView world. This pending invalid new entry is later updated by NavigationManager::UpdatePendingItemUrl, which is also cruft code from UIWebView world. The problem is that NavigationManager::UpdatePendingItemUrl does not always work correctly and causes (crbug.com/805900). It is necessary to stop creating an invalid pending entry before removing NavigationManager::UpdatePendingItemUrl. Bug: 805900 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: If478c574f11e5e586fac7407085f57ec05079814 Reviewed-on: https://chromium-review.googlesource.com/899700Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#534594}
-
chrome://histogramsFrançois Degros authored
The HTML page generated for chrome://histograms used to be invalid. It used to contain an open <table> tag that was never closed, and that didn't seem to serve any purpose. Fixed it. Also simplified the message at the top. Change-Id: Ia08e734352761b9c1a84d69f47a1d80d592387b9 Reviewed-on: https://chromium-review.googlesource.com/896768Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: François Degros <fdegros@chromium.org> Cr-Commit-Position: refs/heads/master@{#534593}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/3929e9ee94af..e117e46a6894 $ git log 3929e9ee9..e117e46a6 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/depot_tools The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I086bdb4caa595a1e1b2212cb7b1d2470760dc293 Reviewed-on: https://chromium-review.googlesource.com/903231Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#534592}
-
Victor Costan authored
Chrome currently only supports iOS10 and above. iOS 10 ships with SQLite 3.14.0+, so we can remove some special case handling (and cognitive burden) needed to support older iOS versions. Bug: 807093 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-device Change-Id: I5d19af5eeaffdf587fb43216fc9cf97e9297d15b Reviewed-on: https://chromium-review.googlesource.com/898564 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Chris Mumford <cmumford@chromium.org> Cr-Commit-Position: refs/heads/master@{#534591}
-
Kevin Marshall authored
Also redirects program stderr to the stdout stream. Bug: 798851 Change-Id: I317ef1ab53d6b11b4611f36e4445859bea43a4fa Reviewed-on: https://chromium-review.googlesource.com/903259 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#534590}
-
CrystalFaith authored
Sample extension used "tabs" permission. Updated it to "activeTab". Bug: 808592 Change-Id: Id868dc8b5507a36a2efe5770f391718a53ae8478 Reviewed-on: https://chromium-review.googlesource.com/900129Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Crystal Lambert <crystallambert@chromium.org> Cr-Commit-Position: refs/heads/master@{#534589}
-
Gustav Sennton authored
The WebView support library glue needs a way to fetch the WebViewChromiumFactoryProvider, this CL adds a mechanism for keeping track of our only instance of WebViewChromiumFactoryProvider. Bug: 808417 Change-Id: I37c76d82b01004753d962ade6874184b28eaa54b Reviewed-on: https://chromium-review.googlesource.com/901624 Commit-Queue: Gustav Sennton <gsennton@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#534588}
-