- 16 Nov, 2020 40 commits
-
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/e4c1a25cc679..8dceaddf8503 2020-11-16 capn@google.com Enable Reactor Print() in Debug/RelWithDebInfo builds If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I4049f187e65280bcbe69f288078f0aa4b1ec8b40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540240Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827821}
-
Lily Chen authored
This adds UKM metrics recording the source and target of each postMessage event. For cross-process postMessages, this is recorded from the browser side as the source ID of the source page (navigation). For same-process postMessages, this is recorded from the renderer side as the source ID of the source frame (which may be a subframe), which can then be correlated with the source page (navigation) via the DocumentCreated event. Change-Id: I1ba8fcb5d493f97d80e2de4c5c3f031025488310 Bug: 1112491 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530774Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#827820}
-
Chris Sharp authored
Bug: 1018157 Change-Id: I8d87afcfb665c514a4cb76ce63904d4245dc1cc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533034 Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#827819}
-
kylechar authored
This function binds a callback to a task runner. The functionality already existed in media::BindToLoop() so it's intended to replace it and is built on the same BindPostTaskTrampoline logic. BindToLoop() and BindToCurrentLoop() will be replaced in a follow up CL since they are used rather widely already. There are some changes to the existing BindToLoop implementation: 1. Get the FROM_HERE location from the caller automatically rather than using the BindPostTask() location. 2. If BindPostTaskTrampoline has a OnceClosure, don't rebind the closure before posting a task. 3. Add static_assert to provide a readable error message explaining the input callback must have a void return type. 4. Don't support RepeatingCallback. This is more problematic since we will always PostTask() to destroy the callback. This is easier to add later than it would be to remove support. Bug: 1140582 Change-Id: Ibb224b44c0b0c01dd88d29e94c7e9449d3353ef5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495055 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#827818}
-
Rohit Rao authored
On the bots, these tests appear to fail because they can't find the Restore infobar after a crash. This CL changes the test to wait for the infobar to become visible, rather than doing a single check, in case the test runs so quickly that the infobar hasn't yet had a chance to appear. BUG=1149370 Change-Id: I8b65c1796408e8151582398d4b2c3c12534c209b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540426Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#827817}
-
Liquan (Max) Gu authored
Currently, mIsUrlPaymentMethodIdentifiersSupported is computed whether it's used or not. This CL is to turn the computation into a method, and compute it only when it's needed. This change will also help moving JourneyLogger.setRequestedPaymentMethodTypes into PRService. Bug: 1131059 Change-Id: I405631119a6bf6d6dce467335ea1c53dcb37ba1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537138 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#827816}
-
Clark DuVall authored
This is a reland of c7a74ee0 Fix for manifest issue is in http://crrev.com/c/2538369, will reland after that change is submitted. Original change's description: > Enable isolated splits in canary and dev > > All major crashes have been fixed and numbers look good. M88 branch was > just cut, so should be safe to enable now. > > Bug: 1126301 > Change-Id: I351d565e68f14af2411c71fa80f34852bab5455a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529729 > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#827387} Bug: 1126301 Change-Id: I6aa825bde70b184cdc412d37d5e5e8850f00bac0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539667Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#827815}
-
Aaron Tagliaboschi authored
This reverts commit ce09536e. Reason for revert: Changing how the field trial for GREASEing works and simplifying change for possible merge Original change's description: > [UA-CH] Put GREASEing behind feature flag and refactor > > Leaving the possibility of turning off for compat issues. > > Bug: 1070922, 1091285 > Change-Id: Ic11ce489705c1c1b4388f24cdbf0ebdd2dca966f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532595 > Commit-Queue: Aaron Tagliaboschi <aarontag@chromium.org> > Reviewed-by: Maksim Orlovich <morlovich@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#827310} TBR=avi@chromium.org,morlovich@chromium.org,aarontag@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1070922 Bug: 1091285 Change-Id: I764fc28dc36f932538ea43febb09a5acaa387445 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536780Reviewed-by:
Aaron Tagliaboschi <aarontag@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Aaron Tagliaboschi <aarontag@chromium.org> Cr-Commit-Position: refs/heads/master@{#827814}
-
Mihai Sardarescu authored
The header X-Chrome-Connected header was sent to Gaia and Drive even when Mirror is disabled. However it seems that this header is ignored server-side, so it is better from privacy perspective to stop sending it. Bug: 1149163 Change-Id: I361754ed4d74b10a4347975d614efbd29be41d1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537838Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Auto-Submit: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#827813}
-
Clark DuVall authored
DFMs should keep manifest declarations even if resources are pulled into the base module, otherwise Android won't load the components from the correct split. Bug: 1149022 Change-Id: I21e0675004011b2b57c1b58efda0f9c85eda420e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538369Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/575729e8dd25..dd6b36e8801e 2020-11-16 rsesek@chromium.org Use the correct GN variable for the Mac deployment target. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC kainino@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: chromium:1148931 Tbr: kainino@google.com Change-Id: I2e0ab89571e84323ad200edc599c49d1651bd39c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540239Reviewed-by:
-
Sigurdur Asgeirsson authored
ScopedObserver is being deprecated in favor of two new classes: - base::ScopedObservation for observers that only ever observe a single source. - base::ScopedMultiSourceObservation for observers that do or may observe more than a single source. This CL was uploaded by git cl split. R=mathp@chromium.org Bug: 1145565 Change-Id: Ia01c31b800dbb549e6b7daf7636b055c7f559111 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532958 Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#827810}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/c56f1f99c003..a44dddc97acb 2020-11-16 shaochuan@chromium.org ArtifactsService: add endpoint for creating GCE tarball from test image 2020-11-16 chrome-bot@chromium.org Update config settings by config-updater. 2020-11-16 chrome-bot@chromium.org Update config settings by config-updater. 2020-11-14 ahassani@chromium.org xbuddy: Fix inclusion language 2020-11-14 chrome-bot@chromium.org Update config settings by config-updater. 2020-11-13 lamontjones@chromium.org Drop R85 builders. 2020-11-13 engeg@google.com payload: trivial, set to '' for proto 2020-11-13 lamontjones@chromium.org Instantiate the R88 Builders 2020-11-13 chrome-bot@chromium.org Update config settings by config-updater. 2020-11-13 chrome-bot@chromium.org Update config settings by config-updater. 2020-11-13 engeg@google.com api.payload: Have GeneratePayload return paths 2020-11-13 chrome-bot@chromium.org Update config settings by config-updater. 2020-11-12 chrome-bot@chromium.org Update config settings by config-updater. 2020-11-12 chrome-bot@chromium.org Update config settings by config-updater. 2020-11-12 chrome-bot@chromium.org Update config settings by config-updater. 2020-11-12 mmortensen@google.com When reading parallel task output, read using binary encoding. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I23aba60154a0c2a2aea857557df58a95cc763964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540626Reviewed-by:
-
Justin Donnelly authored
Bug: 1034648 Change-Id: I1a94492d59ac2a6e7718481538211c2e41be58ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537586Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#827808}
-
Tanmoy Mollik authored
Refactor BookmarkPersonalizedSigninPromoTest to use AccountManagerTestRule and ChromeActivityTestRule instead of SyncTestRule so that it can be batched easily. Bug: 1145843 Change-Id: I257fde4a0d726825f4cf0de199ce917ab1a6e765 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529119Reviewed-by:
-
edchin authored
Design doc: go/bling-phishguard This CL continues work to compile code in iOS that was previously disabled behind PASSWORD_REUSE_DETECTION_ENABLED. Runtime changes are put behind a feature flag. Bug: 1147962 Change-Id: I442c85fd17528bc05be8505f0e3a482823daeae0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538196Reviewed-by:
Ali Juma <ajuma@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#827806}
-
Evan Stade authored
Bug: 775390 Change-Id: I10ed76b52ca4b3c544a69ce5aa99ed7be1e262d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538362 Auto-Submit: Evan Stade <estade@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#827805}
-
David Tseng authored
- fix the regex that was matching against .*(...|)\.(cc|h) (aka all *.cc, *.h). - add a rule for dependees of tts_controller.h with commentary. Bug: 1148093, b/173144152 Change-Id: I0e1ca36fdeec5e838fa845f6f9520d130f11a68d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538141Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
-
Adithya Srinivasan authored
Orphaned portals [1] don't have a RWHV (but did at some point), and can have AXTree updates sent from its renderer process which would be subsequently ignored in the browser process (due to there being no RWHV). Once an orphaned portal is inserted into the DOM tree, we create a RWHV for it, and at this point any new AXTree updates received will be invalid as the browser's tree state is different from the renderer's. To fix this, this CL makes BrowserAccessibilityManager creation independent of a view being present. The view is only used on android to pass it a pointer to WCAXAndroid, and we now do this through a BrowserAccessibilityDelegate method. [1] See "orphaned" here: https://wicg.github.io/portals/#concepts Bug: 1139784 Change-Id: Ifdebe1f05e37a6f704b937101ea44bb824cf045b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499861 Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Reviewed-by:
Kevin McNee <mcnee@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#827803}
-
edchin authored
Design doc: go/bling-phishguard This CL continues work to compile code in iOS that was previously disabled behind PASSWORD_REUSE_DETECTION_ENABLED. Runtime changes are put behind a feature flag. Bug: 1147962 Change-Id: I4cd821e3bf80dbd6a68d393dfb16510d11e78940 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537916Reviewed-by:
-
Garrett Beaty authored
(cherry picked from commit f649e5f626f798740d1bba2c07a2560e69351666) Change-Id: I669ac3891d52285f6162635ab35ae1f1802d245d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538496 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Cr-Original-Commit-Position: refs/branch-heads/4240@{#1459} Cr-Original-Branched-From: f2976777-refs/heads/master@{#800218} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540576 Commit-Queue: Erik Staab <estaab@chromium.org> Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#827801}
-
Steve Kobes authored
The test now waits for an IntersectionObserver notification to ensure that the subframe receives the SetViewportIntersection IPC before the first image paint occurs. Bug: 1115529,1135527,1149053 Change-Id: Idb3999b8adbee004c9d88fb7a8bc06e470bf1c87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538316Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Commit-Queue: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#827800}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202011160600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/uHyo1y211uBoRAYnFrxKwssxhVztzRHATK4g98mNbS0C If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/173070498 Tbr: media-app@grotations.appspotmail.com Change-Id: I453995590fad6590324ccf0899720a0eed89d041 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540237Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827799}
-
Yutaka Hirano authored
We tried to match a blink::Response with the corresponding blink::RawResource to get the ScriptCachedMetadataHandler stored in the RawResource, but we failed to do that, and the failure led to a security issue. Stop storing the ScriptCachedMetadataHandler in RawResource. As RawResource has only one client, we can dispatch the given cached metadata without compromising ownership. Have BodyStreamBuffer store the ScriptCachedMetadataHandler so that the WASM implementation can get the handler easily. Bug: 1146673 Change-Id: I7001d64d24e3085dceb8e165a80fa4043418263b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534570 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#827798}
-
Peter Kotwicz authored
This CL rolls: - androidx.annotation - androidx.arch.core - androidx.core - androidx.interpolator BUG=1064277 Change-Id: Ic9db1418ba7a95719c6056aa169155f4db6fcbb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537932Reviewed-by:
-
Liquan (Max) Gu authored
Changes: * Removed CPRService.mPaymentRequestOptions * onQueryForQuotaCreated has taken passed-in payment options from PRService. * Saved PaymentOptions in PaymentRequestSpec. Bug: 1025619 Change-Id: Ifafd0e4d0e1b5ac8815c63fe75eb3e779196c6a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538110 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
-
Bartek Nowierski authored
Amendment to crrev.com/c/2529150 to avoid a call to SetLastError in a typical case. Bug: 998048 Change-Id: Id39f072da22017e10882d57fa32c61882265478a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537741Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#827795}
-
Camillo Bruni authored
Bug: v8:11165, v8:8124 Change-Id: I7d86d7b2c6127490a15c20d6d230efd31b24aad7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540467 Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#827794}
-
Dave Tapuska authored
Make the implementation common for both frame widgets. For OOPIFs the visual viewport transformation will be 1:1 so this code is the same. No behavioral changes intended. BUG=1097816 Change-Id: I5be86c5b9f5be377b8e0d8f7efda4258ffebdb7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538010Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#827793}
-
Jérôme Lebel authored
Remove DCHECK in -[AddAccountSigninCoordinator start]. It overtriggers when the user wants to sign-in back with the primary account after being removed from the phone by another app. This DCHECK has been introduced with: crrev.com/c/2464274 Fixed: 1147837 Change-Id: I4d2199e66ad2e7a825e26e973dc4b1ddd2e518ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536446 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#827792}
-
Brian Salomon authored
New versions don't have Done procs, allow null for release procs, and the YUVA variation internally figures out the texture channels from higher level inputs (formats + planar configuration). Bug: skia:10632 Change-Id: Ifb49bcb2fce4edc88b0c4425f9031be37113fd81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537878Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Brian Salomon <bsalomon@google.com> Cr-Commit-Position: refs/heads/master@{#827791}
-
David Tseng authored
The intent of this change is to prevent unintended dependencies from chrome/browser -> content/public/browser/...*tts*. Achieve this by subtracting content/public/browser/tts_controller.h from chrome/browser/DEPS; this header is the central interface for tts services. Audit existing usages. Every such dependency should go through review from a tts owner if possible, but at least have some owner approve. R=dmazzoni@chromium.org Bug: 1148093 Change-Id: I25ce026ccb8b3fbc87e7d3a12237c7eb22c36f20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534694 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
-
Christoph Schwering authored
This reverts commit 170f7981. The CL crrev.com/c/2527060 broke ~63 captured-site tests: https://ci.chromium.org/p/chrome/builders/ci/linux-autofill-captured-sites-rel?limit=200 Bug: 1111809 Change-Id: I6eb1f225d1e965fe8bcf85000912ae669722712a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537685Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#827789}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2dbcdc10..cfb8bc49 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If2126d1b39ceebca8c4fdba5b70e6bd44946ca6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538125Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827788}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1605506334-ef94e462f1073999e0940c25684c1ff8aa83ac59.profdata to chrome-win64-master-1605516929-4169c4fef8b75b908f60a07df9383038ad3b6191.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I6372146610744334f74c9130519868aa7f9bab9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540229Reviewed-by:
-
Rune Lillesveen authored
Bug: 988125 Change-Id: Iaec7cd80f39849da0a476c1653655b68cef1452e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529103 Auto-Submit: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#827786}
-
Sylvain Defresne authored
The new Widget requires Xcode 12.0 or higher to build, so assert that the version of Xcode used for the build is recent enough. Update the documentation to recommend the same version of Xcode as enforced by the code, and add tips on steps recommended to perform when updating Xcode. Bug: none Change-Id: I8b8fbf3d53ef2ab98c2407e28e46ce4321cd72f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527175 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Guillaume Jenkins <gujen@google.com> Cr-Commit-Position: refs/heads/master@{#827785}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1c231bde8eaa..f9474249e20d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC lgrey@google.com,hkamila@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1104817 Tbr: lgrey@google.com,hkamila@google.com Change-Id: Id7a993d832b83aeb21fb9d32268ded91771102f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540235Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 62972354. With Chromium commits locally applied on WPT: e5ccea4e "[LayoutNG] Carry over incoming inline break token when no new lines." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: guidou@chromium.org, armax@chromium.org: external/wpt/mediacapture-streams NOAUTOREVERT=true TBR=smcgruer@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: I856a68377255f0ef01779bfaa263ed57d083c5ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540366Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827783}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/97868bd80a1f..dc4637c1a983 2020-11-16 tvanderlippe@chromium.org Update escodegen and recast 2020-11-16 jacktfranklin@chromium.org [DataGrid] fix stretching of table rows 2020-11-16 kimanh@chromium.org [e2e] Temporarily skip flaky shortcuts test 2020-11-16 kimanh@chromium.org [e2e] Temporarily skip flaky browser tests 2020-11-16 tvanderlippe@chromium.org Use TypeScript-authored files in network/ 2020-11-16 kimanh@chromium.org [LMI] Fix resizing issues in CSS 2020-11-16 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-11-16 kimanh@chromium.org [LMI] Add ls for localization and fix ValueInterpreterDisplay view 2020-11-16 tvanderlippe@chromium.org Fix ESLint tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1110202,chromium:1125968,chromium:1149334,chromium:1149346 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia1aae48d5221498a23779298cf197cccce724721 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540234Reviewed-by:
-
