- 27 Jul, 2020 40 commits
-
-
Tim Song authored
BUG=1088588 Change-Id: Iee1d1d8ad46ffb73c4d511007e812cdb7f8bfb89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320067Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#792071}
-
Mehran Mahmoudi authored
This fixes the bug where the player would stick around after navigating to a new page from the omnibox. Bug: 1110020 Change-Id: I1c18993a518c5f936cfc842dd191958d9a07f3bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321288 Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#792070}
-
David Grogan authored
Bug: 1109229 Change-Id: I9652fde744c1dc1b3eb147cff6af741384a3c7b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321236Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#792069}
-
Anastasia Helfinstein authored
An auto-scan speed of 0.5s leads to the focus moving before Switch Access successfully processes the user's selection. Remove it as an option. AX-Relnotes: n/a. Bug: 1108965 Change-Id: I71730ca2efbf9cf3017945fbeb5e32fd21d84260 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318785 Commit-Queue: James Cook <jamescook@chromium.org> Auto-Submit: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#792068}
-
Mike Dougherty authored
Bots rolled with the following script: git grep -l '12a6163b' | xargs sed -i '' -e 's/12a6163b/12a8169fg/g' to update: infra/config/lib/builders.star infra/config/subprojects/chromium/master-only/ci.star infra/config/subprojects/chromium/master-only/try.star testing/buildbot/mixins.pyl testing/buildbot/waterfalls.pyl then configs were generated with: ./infra/config/main.star ./testing/buildbot/generate_buildbot_json.py CIPD packages: infra_internal/ios/xcode/mac 12a8169fg infra_internal/ios/xcode/ios 12a8169fg Bug: 1108576 Change-Id: I0edaaf6d945e0f1e061d930d16194f01b17fd851 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315436Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#792067}
-
John Z Wu authored
This would allow this class to be created outside of its delegate's initializer, which in turns allows it to be mocked or faked. Change-Id: I9d68d32556fb858b36d25a3f302945a48a5a5cde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315924 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#792066}
-
Guillaume Jenkins authored
Move ReportScheduler from chrome/browser/enterprise to components/enterprise so that it can be reused by iOS code. Bug: 1092432 Change-Id: I41794282881f5dbc477b793e935234b3ff3882c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304094 Commit-Queue: Guillaume Jenkins <gujen@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#792065}
-
Richard Knoll authored
This renders a device's icon. For now it only looks at the device type but in future this will show an image if the remote device has one defined. Used in the nearby-device component on the discovery page and in the nearby-progress component on the confirmation page. Bug: 1103190 Change-Id: I9e02048706406ee174c71c869af15938888c5bb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315688 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#792064}
-
Ben Joyce authored
Cannot update with git hash, so using tag/ref per ehmaldonado@, "bot_update is not fetching tags on the mirror by default. There are a few options that could work: 1) Modify the chromium recipe to pass with_tags to bot_update. 2) Set the revision to 'refs/tags/v2.23.0' instead of the git hash. " Bug: 1100286 Change-Id: I700365ddd6515422ba3f75ad4bfe784d12216413 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274921Reviewed-by:
Haiyang Pan <hypan@google.com> Commit-Queue: benjamin joyce <bjoyce@chromium.org> Cr-Commit-Position: refs/heads/master@{#792063}
-
Eric Willigers authored
If a shortcut app is not usually configured to open in a window, but the user promotes a tab to an app window, the app window now shows minimal-ui controls. We previously only checked for GetAppEffectiveDisplayMode returning kMinimalUi, and did not consider the possibility of the method returning kBrowser. TBR=bsep@chromium.org Bug: 1109520 Change-Id: I475b0bae2e979a8e1581bb74d225c08145c66432 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319466Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#792062}
-
Richard Knoll authored
This is a reland of 706a5c51 The original CL got reverted because of a bug in the code that is now used with the CL. Fix landed here: crrev.com/c/2320174. No changes were required for this CL. Original change's description: > [Nearby] Start discovery on discovery page > > This calls the DiscoveryManager interface from JS and listens for > discovered and lost devices to update the device list. The selected > device is then passed through to the confirmation-page. > > Bug: 1103190 > Change-Id: I9296e5449533eb869fd9f20fe442d4ac1bc05a42 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315862 > Commit-Queue: Richard Knoll <knollr@chromium.org> > Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#791591} TBR=mvanouwerkerk@chromium.org Bug: 1103190 Change-Id: I2abe1135599fa190d29a42f64ef0a7ed206f4281 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320871 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#792061}
-
Tobin Ehlis authored
This is a flaky test that needs to be split up so skipping as a start. Bug: 1109977 Tbr: ynovikov@chromium.org Change-Id: I9bc214903a90d55870e07361c6c478752ae90e76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321334Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Tobin Ehlis <tobine@google.com> Cr-Commit-Position: refs/heads/master@{#792060}
-
Yi Gu authored
Bug: None Change-Id: I3dcd551fcc2412e728c600235b3bb4af44af561f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321398Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#792059}
-
Joshua Pawlicki authored
Bug: 1092503 Change-Id: Ia4fffa66a320904b2ac6985d82416cbba5483a19 Fixed: 1092503 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316668 Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#792058}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I02fee8bdd872573845b1929aa6cbddb4ba2f59b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321217Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792057}
-
Keith Lee authored
The GetAutocorrectCharacterBounds function returns the location of the autocorrect word as a gfx::Rect object. Change-Id: I214e8eb506b9456114496b71be87dd0a61bf38e0 Bug: 1108170 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251638Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Keith Lee <keithlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#792056}
-
Xiaoling Bao authored
Change-Id: Id7ded4c40ff61ac61d767f45544f5a9677e788ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317992 Commit-Queue: Xiaoling Bao <xiaolingbao@chromium.org> Auto-Submit: Xiaoling Bao <xiaolingbao@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#792055}
-
mhasank authored
This will show a different error message for different CloudDPC errors along with error code. BUG=b:62613791 TEST=deploy to dut, disable playstore, re-enable playstore, successfully finish the authorization flow Change-Id: Ibb116416b0e98d90430938ed51b5e3fe44df8cf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305670Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Muhammad Hasan Khan <mhasank@chromium.org> Cr-Commit-Position: refs/heads/master@{#792054}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: Ifbcb060d1ef730287c6b5ef796eb77d76d5b8f18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320769Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792053}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/0606ae6f9a56..d292e89bd75a 2020-07-27 cduvall@chromium.org Add option to compile APK when running perf tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC zhanliang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1105096 Tbr: zhanliang@google.com Change-Id: I0aef28ce03604cd85ddf78bd9f345322806a39ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321294Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792052}
-
Regan Hsu authored
Removed out of privacy concerns that DLCs are visible to all users on a device. All removals in one CL so that reversion is easy if it is decided that the DLC subpage should be brought back. Fixed: 1108093 Change-Id: I858c686c6036619cd8a4c6b93200dce730c34a1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315921 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#792051}
-
Joel Hockey authored
TBR=antrim@chromium.org TBR=nancylingwang@chromium.org Change-Id: Ib567140b0027238631acafde9a5f9a78cb476278 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318945 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
David Munro <davidmunro@google.com> Cr-Commit-Position: refs/heads/master@{#792050}
-
Alex Chau authored
- Start Sharing process at start discovery/adveritisng - Changed NearbyProcessManager::GetInstance to return pointer for easy injection in testing Bug: 1076008 Change-Id: I33f8d5147b30c4f9e22e778991c17b2c2c3be49d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308149Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#792049}
-
Brian Sheedy authored
Locks the GPU Mac Intel stable OS version to 10.15.5 since the requested machines have been upgraded. Also stops testing on the experimental Mac Intel builder, as the experimental and stable OS versions are currently identical. Submitted with no-try due to crbug.com/1109790. Bug: 1078489 No-Try: true Change-Id: I268f89b8d8208ae1e54c16f95ffbc97ce36fa804 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316809 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#792048}
-
Patrick Noland authored
Bug: 1108189 Change-Id: I7e4b8194dcfe0fdb5d815590438ba5a7f60080c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315538Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#792047}
-
Andrew Grieve authored
Not really a good fix, but better than crashing for now. Bug: 1099819 Change-Id: I50616008ba19a168ad9b1976552dc8e47991dcbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315351 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#792046}
-
Sunny Sachanandani authored
Refactor the SetEnableDCLayers calls out of DirectRenderer into OverlayProcessorWin. Having the logic in the overlay processor is needed for deferring overlay promotion to subsequent frames when partial quad aggregation is enabled and full damage wasn't aggregated. As a result move the plumbing of SetEnableDCLayers from DirectRenderer to OutputSurface since the former isn't meant to be used by the overlay processor. Bug: 1077210 Change-Id: I191ba9ea591084d8f054d56958d6056ce1507a57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302742Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
weiliangc <weiliangc@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#792045}
-
Kyle Milka authored
Bug: 1108469 Change-Id: I4f13331c38cf836134072ed533d9e821e2af6f84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321219Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#792044}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/d5a4775cfc77..1f16229c9be9 2020-07-27 bryan.bernhart@intel.com Disable MultisampledRenderingTests on NV/D3D12. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I0803ade1d6b568d9f53fac77be4614d2ace03b57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321252Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792043}
-
Swapnil authored
We want to improve the installation time for force installed extensions. For this, we need to first gather the statistics regarding which installation stages are time consuming. We collect the UMA statistics for the time taken to download CRX successfully. Following histogram is added: Extensions.ForceInstalledTime.ManifestDownloadCompleteTo. CRXDownloadComplete Bug: 1102369 Change-Id: Id73ebc3add187507113d788f13e868e042f366e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282750Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Cr-Commit-Position: refs/heads/master@{#792042}
-
Ken Buchanan authored
ProfileListDesktopBrowserTest.Signout was flakily crashing when the task for recording the IsUVPAA metric was executing during browser shut down. This is a speculative fix to abort the task if the browser process is unavailable, and also re-enable the test. Bug: 1109768 Change-Id: I15597948850d40773c563029a8ea247f1557ef90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321290Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#792041}
-
Deepanjan Roy authored
On bots where --experimental-tbmv3-metric is not enabled, this metric does nothing. That flag is only enabled on FYI bots at the moment, and we want to run system health benchmark with both TBMv2 and v3 metrics enabled there to monitor for stability. Bug: 1012687 Change-Id: I38ab894ab5ba6a3ca40689d6f3710c6d72c5ed6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316331Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Deep Roy <dproy@chromium.org> Cr-Commit-Position: refs/heads/master@{#792040}
-
Leonard Grey authored
Currently, if no max width is specified, we use 1.5 * min_width as the max which can be insufficient especially in longer languages (but this also affects English: for example, on my machine "GPU memory" nor "Keepalive count" can fit the name in the header). This change leaves the max width unset if it's not specified. It also changes the autoresizing style to "Sequential" which prioritizes in leading to trailing order, to ensure "Task" is prioritized for resizes. Bug: 1109129 Change-Id: I238942541af72b4baea4d61b98e5cfcaa795ff98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317837Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#792039}
-
Ilia Samsonov authored
Baselines were generated in the following build: https://ci.chromium.org/p/chromium/builders/try/linux-blink-optional-highdpi-rel/5 Bug: 1068400 Change-Id: Ib968dee91dff397c094f56849fc4ffeb29642b76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293112Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#792038}
-
Katie D authored
Bug: 1109932, 1109931 Change-Id: I1779f4b7c4a78aef7d6addaaa5161d84dc169843 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320083 Auto-Submit: Katie Dektar <katie@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#792037}
-
Rakib M. Hasan authored
If the 'test' key is in the definition for a basic test suite, then that value overrides the mixed compound test suites name. The name for the suite should be the test suites name plus the identifier field set in a variants list entry. Bug: 1041619 Bug: 1109967 Change-Id: I8a44b23d2511d2a5e85c0d06e3047c1d50abf011 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318305 Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#792036}
-
Hongchan Choi authored
Fixes a potential data race of |source_number_of_channels_|. In the worst scenario, the rendering may fail with a crash when the output channel count does not match. - SetFormat() is peeking/writing the value. (mostly from main thread) - Process() is reading the value. (rendering thread) Bug: 1108477 Change-Id: I4b64eab94b66e1998a456915d4eaa391791dc44f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316404 Commit-Queue: Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#792035}
-
wutao authored
Bug: b/162140949 Test: manual Change-Id: Ib162aa253ac6f47c519a8e0100f1d369bc9c1d01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319146Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#792034}
-
James Long authored
A convex hull is now created around nodes within the same buildtarget, expanded outwards slightly, and rendered on the visualization. Each buildtarget is a different color, and nodes are colored according to their buildtarget. This feature can be turned off with a radio button UI element. To support this feature, the original node colorings have been changed to outline colors. Bug: 1106121 Change-Id: Idbb89a5010fa56bc6ac083c65e98d77930796127 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316790Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: James Long <yjlong@google.com> Cr-Commit-Position: refs/heads/master@{#792033}
-
Andrew Comminos authored
When a pointer lock is active for an element, all pointer events are dispatched to the element holding the lock in PointerEventManager::HandlePointerEvent. Incorporate this logic in LocalFrame::CanAccessEvent to ensure isInputPending works with pointer locks. Bug: 1092617, 910421 Change-Id: Ie1089322e81731c832d78bf016be91cefedd63ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318650Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Andrew Comminos <acomminos@fb.com> Cr-Commit-Position: refs/heads/master@{#792032}
-