- 31 Aug, 2019 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/42de94b9e1df..af2ec2f11e57 Created with: gclient setdep -r src-internal@af2ec2f11e57 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I9505e9a1e7cf34cfd4367d6a1a1a981063afe436 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779600Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#692360}
-
Xianzhu Wang authored
For the remaining LayerTreeHostCommon* tests that used impl-side PropertyTreeBuilder, convert them to create layer tree and property tree at the main side, and commit to impl-side pending tree and activate active tree (if needed) and then test the impl-side results. Bug: 994361 Change-Id: I27ee2dd71ff067505e85579185555e528a34a436 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779018Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#692359}
-
Guohui Deng authored
When running in GPU process, OzonePlatformCast should initialize |overlay_manager_|. Bug: 999245 Test: 1. With CL 1739931 and CL 1749480, Chromecast no longer crashes and boot normally. 2. Internal CQ. Change-Id: If1938a7d2604cd543b05a6febf5ed9076d4f8e39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777074 Commit-Queue: Guohui Deng <guohuideng@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#692358}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c2ec9bfe1bb5..6e637472ebf3 git log c2ec9bfe1bb5..6e637472ebf3 --date=short --no-merges --format='%ad %ae %s' 2019-08-31 reed@google.com remove legacy flag SK_SUPPORT_LEGACY_RECT_PARAMS Created with: gclient setdep -r src/third_party/skia@6e637472ebf3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@google.com Bug: None Change-Id: Idfc518d978b3c617fb7b9cd2e94b1cf1ac0e5ca8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779594Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#692357}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/83cf73376ecb..42de94b9e1df Created with: gclient setdep -r src-internal@42de94b9e1df If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I80327a10485c8996bb459a5bb670c7032d43abb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779593Reviewed-by:
-
Miguel Casas authored
Change-Id: Ie80c68ac5b4da0297f6dfe18c8a7f83da9cc8ddf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779071Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Kuang-che Wu <kcwu@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Auto-Submit: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#692355}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/18c9ac497117..cd8d6f24c054 git log 18c9ac497117..cd8d6f24c054 --date=short --no-merges --format='%ad %ae %s' 2019-08-31 bclayton@google.com Update SPIRV-Tools to 65e362b7 Created with: gclient setdep -r src/third_party/swiftshader@cd8d6f24c054 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/123642959 Change-Id: Ieafaf56160eb305cfe80eca7aef69af6f9af067d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779674Reviewed-by:
-
Antonio Gomes authored
After [1], the factory method CreateRTCVideoDecoderAdapter() declared in [2] is not needed anymore: [3] can refer to RTCVideoDecoderAdapter ctor directly. CL removes [2] altogether. [1] https://crrev.com/c/1778665 [2] //third_party/blink/public/platform/modules/peerconnection/web_rtc_video_frame_adapter_factory.h [3] //third_party/blink/renderer/platform/peerconnection/rtc_video_decoder_factory.cc BUG=787254 R=guidou@chromium.org, haraken@chromium.org Change-Id: I223b97999f49ea5c84a7ebc2d0c6aab87dd911be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779268 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#692353}
-
Antonio Gomes authored
This is phase 2.2 on the design document [1]. [1] https://docs.google.com/document/d/1AJKVA5U4nDkyDB9p4ROrggWXadCxyy-grKaE9KS5vOU/ BUG=787254 R=guidou@chromium.org, haraken@chromium.org Change-Id: I643f8ca0d6b81d3c26c9f7973b4d6b0a15dfde71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778665Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0a86cef17cd4..83cf73376ecb Created with: gclient setdep -r src-internal@83cf73376ecb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I64946e666bbc87c8061d172838e198f91b370c82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779672Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9d6c6df3..aa3fccf4 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3ea7dbbdb25bc989497622250914b9251fcdf3d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779862Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#692350}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I0d1c33e7152ee321c7c31116ea596a9111106853 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779673Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bcb7add1f488..0a86cef17cd4 Created with: gclient setdep -r src-internal@0a86cef17cd4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: Ia9069bb6a20bf533921aa72d9558695735e271b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778654Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a7cf9c5c..9d6c6df3 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9f0b01e5f5687591918e6d41fad320d0f1b97bde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779861Reviewed-by:
-
Ryan Hamilton authored
[Reland https://chromium-review.googlesource.com/c/chromium/src/+/1778965] Change-Id: I31e34d907725fd497c967156859b2ead02467282 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779669 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Auto-Submit: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#692346}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f46c8268bf2b..c2ec9bfe1bb5 git log f46c8268bf2b..c2ec9bfe1bb5 --date=short --no-merges --format='%ad %ae %s' 2019-08-31 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps Created with: gclient setdep -r src/third_party/skia@c2ec9bfe1bb5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@google.com Bug: None Change-Id: I1e67056f43c06958835bc520e4b998fda8e774dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778655Reviewed-by:
-
Peter Kotwicz authored
This CL: - Introduces WebappIntentDataProvider and WebApkIntentDataProvider which extend BrowserServicesIntentDataProvider - Refactors WebappInfo and WebApkInfo to be backed by WebappIntentDataProvider/WebApkIntentDataProvider - Adds more JUnit tests for WebAPK updates now that WebApkInfo is backed by a much more complex object BUG=993651 Change-Id: I1ddd6a7c2e96d06639aa6d398d481d0581c6de07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1770001 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#692344}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/58e68e0665ba..824424fa351b git log 58e68e0665ba..824424fa351b --date=short --no-merges --format='%ad %ae %s' 2019-08-30 bryan.bernhart@intel.com Fix MSVC build error due to sign mismatch. Created with: gclient setdep -r src/third_party/dawn@824424fa351b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: I65e41fedeba452159cc71a20310d576af8afcda6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779653Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ed2fc50eb12d..ce6a0c8fb3f3 git log ed2fc50eb12d..ce6a0c8fb3f3 --date=short --no-merges --format='%ad %ae %s' 2019-08-31 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 54ad211b..a42eacf1 (692182:692288) Created with: gclient setdep -r src/third_party/webrtc@ce6a0c8fb3f3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: Ib3c73e60cfbfe5fb1f3649c3ea45158cff5fabe2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779648Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f0640bc3c1dc..c3f57231124b git log f0640bc3c1dc..c3f57231124b --date=short --no-merges --format='%ad %ae %s' 2019-08-31 syoussefi@chromium.org Vulkan: revamp present semaphore management Created with: gclient setdep -r src/third_party/angle@c3f57231124b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Bug: None Change-Id: Ib6455ccd2b590b2c26f58ae5cc634a5c36663481 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779651Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/5aeddeb96eb9..355e97e300e8 git log 5aeddeb96eb9..355e97e300e8 --date=short --no-merges --format='%ad %ae %s' 2019-08-31 tandrii@google.com OWNERS: add tandrii@google.com. Created with: gclient setdep -r src/third_party/depot_tools@355e97e300e8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: None Change-Id: Ie404354171fdbcf2294b93f1911c29e5571e1d05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779646Reviewed-by:
-
James Darpinian authored
https://crrev.com/c/1767366 breaks this test, but we want to submit it anyway. We'll fix the breakage afterward. Vulkan is not a shipping configuration yet so this is OK for now. Bug: angleproject:3563 Bug: angleproject:3883 Change-Id: If5e26e098228c9f97839d1a492c66353ce8db436 TBR: kbr@chromium.org,syoussefi@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779540Reviewed-by:
James Darpinian <jdarpinian@chromium.org> Commit-Queue: James Darpinian <jdarpinian@chromium.org> Cr-Commit-Position: refs/heads/master@{#692339}
-
Ting Shao authored
When ServiceWorkerImportedScriptUpdateCheck is enabled, service worker update check creates browser initiated scripts requests. And it doesn't call ContentBrowserClient::WillCreateLoaderFactory() when creating the loader factory. Thus extension WebRequestAPI is not aware of the script requests during update check. This change calls ContentBrowserClient::WillCreateLoaderFactory() and makes it support browser initiated service worker update check script requests. Bug: 995763 Change-Id: I64ff3aae18b03a3a2000da5b815915465432862d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769854 Commit-Queue: Ting Shao <ting.shao@intel.com> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#692338}
-
Renjie Tang authored
https://quiche.googlesource.com/quiche.git/+log/28315b77c94c..45f8f861073d $ git log 28315b77c..45f8f8610 --date=short --no-merges --format='%ad %ae %s' 2019-08-30 bnc Make QuicSendControlStream send actual value for SETTINGS_QPACK_MAX_TABLE_CAPACITY. 2019-08-30 rch gfe-relnote: use QUIC_foo instead of ABSL_foo for mutex annotations in QUIC. Not flag protected. No behavior change. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: I4c06014396d2e8fb6bc02d8c82ff57ed25ec1e25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779528Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#692337}
-
Yannic Bonenberger authored
*** Note: There is no behavior change from this patch. *** This CL replaces calls to base::{Bind,BindRepeating} with calls to base::BindOnce, and removes calls to base::AdaptCallbackForRepeating when the returned base::RepeatingCallback is immediately converted to a base::OnceCallback. This CL was uploaded by git cl split. R=pwnall@chromium.org Bug: 714018 Change-Id: I65d9dd97238e1f1db116183e6a4909a5e8d54015 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778775Reviewed-by:Victor Costan <pwnall@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Auto-Submit: Yannic Bonenberger <contact@yannic-bonenberger.com> Cr-Commit-Position: refs/heads/master@{#692336}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/354c81aceebe..9f64c5cb4902 git log 354c81aceebe..9f64c5cb4902 --date=short --no-merges --format='%ad %ae %s' 2019-08-30 bpastene@chromium.org devil: Add a yaml definition that builds a CIPD package Created with: gclient setdep -r src/third_party/catapult@9f64c5cb4902 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=skyostil@google.com Bug: None Change-Id: Iddffa84fb7f215ccfdea2719c2155f393a4d0a6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779449Reviewed-by:
-
Ryan Hamilton authored
Change-Id: I67f7388eb33ae55ff527f31d9c0eb73dd4f2eb19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778965 Auto-Submit: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Brad Lassey <lassey@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#692334}
-
Emily Stark authored
This extends SecurityStatePageLoadMetricsObserver to record Safety Tip metrics for page end reason (navigated away, reloaded, etc.) and time on page. These tests revealed an issue (bug? feature?) that the reputation check callback was not being called unless the page was actually flagged. For ease of testing, I've made ReputationService guarantee that the callback will be called even when the page isn't flagged (with a safety tip status of kNone). Bug: 987754 Change-Id: I5dc5d9fb221d4b8171faaeb7a970907f18927ee1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776841 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#692333}
-
Fergus Dall authored
ARC++ has fixed the issue that was blocking this, so we can now properly support plain text drag and drop Bug: 927324 Change-Id: I6e5b2e0589e27001f94118806bcbf38faf4014cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775656Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Daichi Hirono <hirono@chromium.org> Commit-Queue: Fergus Dall <sidereal@google.com> Auto-Submit: Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#692332}
-
Yannic Bonenberger authored
*** Note: There is no behavior change from this patch. *** This CL replaces calls to base::{Bind,BindRepeating} with calls to base::BindOnce, and removes calls to base::AdaptCallbackForRepeating when the returned base::RepeatingCallback is immediately converted to a base::OnceCallback. This CL was uploaded by git cl split. R=chlily@chromium.org Bug: 714018 Change-Id: I6356d90dc7d1f414f26f96f4f06a473cca2a01b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778547Reviewed-by:Lily Chen <chlily@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Auto-Submit: Yannic Bonenberger <contact@yannic-bonenberger.com> Cr-Commit-Position: refs/heads/master@{#692331}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I2a747db127a33ef0596028a09ab363587edb867a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779647Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: Ic57b70cea298e07e84b097d8d85e36758df0e58e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778990Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#692329}
-
Miyoung Shin authored
This CL converts SmsReceiverPtr and SmsReceiverRequest in content and blink to the new Mojo types. Bug: 955171, 978694 Change-Id: Ic10fe668c66bfc908e377a99b578f6f48e07c683 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775941Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#692328}
-
Daniel Rubery authored
This CL observes WebContents and cancels the PasswordProtectionRequest if the WebContents is destroyed. The destruction of WebContents is responsible for at least this ZoomController bug, since I was manually able to reproduce the callstack. The other bugs are added speculatively, since they involve dereferencing the WebContents as well. Bug: 999030, 998218, 927884 Change-Id: I18fcd2ce8b8b6190bc8fed849813cca01b03d3f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779579 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#692327}
-
Luciano Pacheco authored
Convert to ES6 classes the following files: - ui/file_manager/externs/background/media_import_handler.js - ui/file_manager/file_manager/background/js/media_import_handler.js - ui/file_manager/file_manager/background/js/media_import_handler_unittest.js - ui/file_manager/file_manager/background/js/task_queue.js - ui/file_manager/file_manager/background/js/task_queue_unittest.js - ui/file_manager/externs/background/import_runner.js Converting these to ES6 revealed a set of entangled dependencies between the Background (BG) and Foreground (FG) page implementations. We do not want FG and BG implementations depending on each other. For Closure type checking, externs can be used to declare their @interface, allowing the FG and BG implementations to only depend on their @interface. Fix BG progress_center.js depending on FG progress_center_panel.js by declaring a new extern progress_center_panel.js. media_import_handler.js extern was a cluster of its externs and its own dependencies. This CL splits parts of it into task_queue.js and duplicate_finder.js, so their implementations don't have to depend on the media_import_handler.js. Moved importer.TaskQueue.UpdateType enum to /common/ to be shared between FG and BG: enums can't be on externs because externs aren't loaded in our unittests or production code. Bug: 778674 Change-Id: I05cb122df95581d1c966d64cb7388d1591c322fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772792Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#692326}
-
Findit authored
This reverts commit 2519fd76. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 692312 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzI1MTlmZDc2ZTBmMDQ2OWE2N2U3YmIwN2Y3OWNkOTg5ZTUwNDQyYzEM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/Cast%20Audio%20Linux/51766 Sample Failed Step: net_unittests Original change's description: > Support IETF-style QUIC Alt-Svc advertisements. > > Change-Id: If9c443341119cdd82d4f162b702abd7a15ed10d6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773884 > Commit-Queue: Ryan Hamilton <rch@chromium.org> > Reviewed-by: Zhongyi Shi <zhongyi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#692312} Change-Id: I5a1dc0ac31f7594f16808b25abbdff9e586df377 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779385 Cr-Commit-Position: refs/heads/master@{#692325}
-
Sophie Chang authored
These were loading URLs that had foo.jpg and bar.jpg requests and that was conflicting with the actual asserts from the test Bug: 996665 Change-Id: Ieafd295fbbaed218ddd700f73519622f296904af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779539 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Auto-Submit: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#692324}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8ef18d359b26..f46c8268bf2b git log 8ef18d359b26..f46c8268bf2b --date=short --no-merges --format='%ad %ae %s' 2019-08-30 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-08-30 fmalita@chromium.org [skottie] Discard unneeded static text animators Created with: gclient setdep -r src/third_party/skia@f46c8268bf2b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@google.com Bug: None Change-Id: Ia034307736b89b5e7be0bb332dd863fd231cf9c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779367Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/2c5d48a6f0e4..f0640bc3c1dc git log 2c5d48a6f0e4..f0640bc3c1dc --date=short --no-merges --format='%ad %ae %s' 2019-08-30 lujc@google.com Use SemaphoreID in place of GLuint handle 2019-08-30 jmadill@chromium.org Update docs on enum names. 2019-08-30 jmadill@chromium.org Vulkan: Generalize ICD decision for loader. 2019-08-30 syoussefi@chromium.org Vulkan: Make vk::ImageView pointers const 2019-08-30 jmadill@chromium.org Vulkan: Move loader defines into BUILD.gn. Created with: gclient setdep -r src/third_party/angle@f0640bc3c1dc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Bug: None Change-Id: Ica8705de6f9572ee22ac62c6d22d5be48900775b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779366Reviewed-by:
-
Yannic Bonenberger authored
*** Note: There is no behavior change from this patch. *** This CL replaces calls to base::{Bind,BindRepeating} with calls to base::BindOnce, and removes calls to base::AdaptCallbackForRepeating when the returned base::RepeatingCallback is immediately converted to a base::OnceCallback. This CL was uploaded by git cl split. R=mattm@chromium.org Bug: 714018 Change-Id: I555437179dc4b607c77ac84e91117a4ef36bb15e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778778 Auto-Submit: Yannic Bonenberger <contact@yannic-bonenberger.com> Reviewed-by:Matt Mueller <mattm@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#692321}
-
