GitLab

Also move the autocomplete sync tests to their own file.

Bug: 869526
Change-Id: I49d75e522c41bce8aca8179c8adbdc475354dd58
Reviewed-on: https://chromium-review.googlesource.com/1157184
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580263}

Bug: 755840
Change-Id: Ia43352a67cb170ffa8d8177de0ba00ff8dbd6c68
Reviewed-on: https://chromium-review.googlesource.com/1158967
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Reviewed-by: Robert Kaplow (slow) <rkaplow@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580262}

This change removes the WebUSBOnSharedWorker flag and the Blink IDL
changes made to expose WebUSB in the SharedWorkerGlobalScope, since the
feature will not be implemented anytime soon.

Bug: 837414
Change-Id: I0bf49b8bb7fc9ded42d43732ed1c01c0b6831ffc
Reviewed-on: https://chromium-review.googlesource.com/1153222
Commit-Queue: Ovidio Henriquez <odejesush@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Chong Zhang <chongz@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580261}

This matches the behavior of Cocoa textfields, and also makes it possible to
right-click paste at the end of a textfield.

Bug: 856609
Change-Id: Ic609b2bb78737d379e7e0a57ab3f4c7f16a3cec9
Reviewed-on: https://chromium-review.googlesource.com/1160768
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580260}

This change creates an Origin Trial for the Shape Detection API.

Intent to Experiment:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/eJnB-5Sg-mQ/uvdWnO2OBQAJ

Bug: 646035
Change-Id: Ib7b18f8544c0f9d7d4bb8730102800d63cc54c9f
Reviewed-on: https://chromium-review.googlesource.com/1159684Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580259}

Current iteration:
1. Autocomplete queries will only autocomplete if it is confident in a
   url or text query (no apps or answer cards).
2. Autocomplete is based off of the first result view in the
   SearchResultPageView.
3. Up/Down/Left/Right/Tab keys all trigger autocomplete.

Bug: 865543
Change-Id: I579a6f1fb4cdc2af5e7a43577a73a843663e5e8c
Reviewed-on: https://chromium-review.googlesource.com/1161014Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Daniel Zhang <oxyflush@google.com>
Cr-Commit-Position: refs/heads/master@{#580258}

TBR=dcheng@chromium.org

Bug: 865063
Change-Id: Ieca1efe67cbc9b0340f4bc9f1e0e5af9a0a0391d
Reviewed-on: https://chromium-review.googlesource.com/1160442
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580257}

This improves link time of binaries.

Bug: 794423, 702625
Change-Id: Ib82cd52851339936881c989282bb41a349e769bc
Reviewed-on: https://chromium-review.googlesource.com/1154771
Commit-Queue: agrieve <agrieve@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580256}

This patch adds one-time IPH for the bottom toolbar for the first time
that it is enabled. The help bubble appears under the bottom toolbar
and states that the icons have moved to the bottom of the screen.

Bug: 862611
Change-Id: I597401a1030cc9f0c4ea3537bcf9a597b8d28275
Reviewed-on: https://chromium-review.googlesource.com/1138729
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Robert Kaplow (slow) <rkaplow@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580255}

This relands commit e63be647.

This originally got reverted because it broke generate_build_files
on chromium.perf/Win Builder.

Bug: 830892

Original change's description:
> Add logging and chrome_utils directories
>
> Bug: 830892
> Change-Id: I8c121dff724dea526a7cc7ce198da51cc1b8d045
> Reviewed-on: https://chromium-review.googlesource.com/1158719
> Reviewed-by: Joe Mason <joenotcharles@chromium.org>
> Reviewed-by: Peter Kasting <pkasting@chromium.org>
> Reviewed-by: Christian Dullweber <dullweber@chromium.org>
> Commit-Queue: Oliver Li <olivierli@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#580163}

TBR=pkasting@chromium.org,joenotcharles@chromium.org,dullweber@chromium.org

Change-Id: I526ff309c639ef26c8a8f2e98722aa730cc3e911
Reviewed-on: https://chromium-review.googlesource.com/1160776Reviewed-by: Joe Mason <joenotcharles@chromium.org>
Commit-Queue: Oliver Li <olivierli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580254}

In https://chromium-review.googlesource.com/c/chromium/src/+/1151715
I missed one of the tests. Enable it now.

Bug: 767926
Change-Id: I6c8aaa9c6e5a955be747df4fba1f8a3e95166ca7
Reviewed-on: https://chromium-review.googlesource.com/1159348Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Fredrik Hubinette <hubbe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580253}

Doesn't seem to break anything.

Bug: 647842
Change-Id: I5151602cc62a6c14bff5ac1398cd7f8cd01d1555
Reviewed-on: https://chromium-review.googlesource.com/1159354Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Fredrik Hubinette <hubbe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580252}

Fixes small conflict after crrev.com/c/1036524.

Bug: None
Test: cast_media_unittests
Change-Id: Ib0a83c0074c6f9f7b9532cefe10c7331ec11e645
Reviewed-on: https://chromium-review.googlesource.com/1160932
Commit-Queue: Aidan Wolter <awolter@chromium.org>
Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580251}

Excluding ios12-sdk-xcode-clang
Uploaded xcode10 beta 5 10L221o to cipd along with
runtimes iOS 10.3.simruntime and iOS 11.4.simruntime.

  infra_internal/ios/xcode/mac  10l221o
  infra_internal/ios/xcode/ios  10l221o

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: If598b51a86f261c2fdcaa0b0ec0e2ec4d15db3ac
Reviewed-on: https://chromium-review.googlesource.com/1158608
Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org>
Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580250}

Removed using SelectableItemView in download home. Instead properties for
selected and selectionModeActive will be set into the ListItem from the mediator.

Bug: 850600, 868205
Change-Id: I36d98b4f7cfde8d6c8a93adae091cd8024b14e3c
Reviewed-on: https://chromium-review.googlesource.com/1150810Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580249}

Normally we set focus on mousedown and touchstart.
But if the page doesn't have any touch handlers we
filter out all the touch events and so the view
will not get the focus. So when a gesture tap comes
to generate mouse events and etc page doesn't have
focus. This CL also adds the foucs on gesture tap
to make sure the appropriate view is focused. If
the view is already focus due to previous touch start
or mouse down this does nothing.

Bug: 861998
Change-Id: Icf10910533d694111fe6c106fbb41b48f57165d5
Reviewed-on: https://chromium-review.googlesource.com/1158714
Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org>
Reviewed-by: Lucas Gadani <lfg@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580248}

This CL has a few tiny cleanups:
- Uses {} in conditionals if either the body or the condition
 is >1 line.
- base::ContainsValue() for ease of reading.
- Uses early return.

No logical changes intended.

Bug: 869161
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I1085ba8084982c2e78aa57052c4b8d05b3f72dc7
Reviewed-on: https://chromium-review.googlesource.com/1160763Reviewed-by: ccameron <ccameron@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580247}

There's only one field, for the enabled_ state. I made
an InnerEnable private function so we don't need a seperate
boolean to distinguish any more.

Change-Id: I65cc41c775d0c01ea10ce54c261b36d1e92dc7fe
Reviewed-on: https://chromium-review.googlesource.com/1159687Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Johannes Henkel <johannes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580246}

There's no need to define _LAST enumerators, since Mojo provides these
automatically.

Bug: 742517
Change-Id: Ibafea09dd000cf14db4033790bef6a860b5030e6
Reviewed-on: https://chromium-review.googlesource.com/1159263Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580245}

ET_SCROLL_FLING_START/CANCEL are represented as GestureEvents if
EF_FROM_TOUCH is set, otherwise ScrollEvents. The deserializer always
treated them as ScrollEvents.

BUG=867035
TEST=covered by test

Change-Id: I2540ccc8766fbf59eafa0c3beadd8dd2e4ec4ade
Reviewed-on: https://chromium-review.googlesource.com/1159621
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580244}

This mode can be used in QuicStreamFactoryTest to simulate cases where connection
migraiton is triggered while crypto handshake is not completed.

Bug: 790547
Change-Id: I3c32f156d503318b9a9b203c772d3ec4ed41d9f8
Reviewed-on: https://chromium-review.googlesource.com/1157439
Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580243}

Because the dialog must be displayed before the Profile initalization as
the process might load the extensions which might open browser windows.

TEST=Set up a invalid token by setting any non-empty string in policy.
     MachineLevelUserCloudPolicyEnrollmentToken.
     a) Login mac.
     b) Create com.google.Chrome.plist (org.chromium.Chromium.plist for chromium) for the
        following content:
         <?xml version="1.0" encoding="UTF-8"?>
         <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
         <plist version="1.0">
         <dict>
            <key>MachineLevelUserCloudPolicyEnrollmentToken</key>
            <string>invalid-token</string>
         </dict>
         </plist>
     (More details in https://support.google.com/chrome/a/answer/7550274?hl=en)
     Launch Chrome. Instead of the chrome window, there should be an error dialog indicates
     that launching is blocked.
     1) The error dialog could be hidden/shown, lose or gain focus without any issue.
     2) Clicking any option in the menu bar or dock menu shouldn't open any browser window.

Bug: 860540
Change-Id: Ibf4b7c2794a8ad78b9fedb2da67512508d3d7621
Reviewed-on: https://chromium-review.googlesource.com/1145862
Commit-Queue: Owen Min <zmin@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580242}

We are having issues where starting a GPU process consistently fails on
some systems. Currently OOP-D runs the display compositor in the GPU
process always. This includes when both hardware acceleration and
SwiftShader are disabled. If we can't start the GPU process, we can't
run the display compositor and Chrome crashes.

This CL changes where the VizCompositorThread runs if the GPU access is
disabled on Windows. We start the thread after giving up on the GPU
process and create FrameSinkManagerImpl + dependencies on it.

Also fix chrome://gpu page so that OOP-D and surface sync features are
still correct if |gpu_access_blocked| is true.

There is a lot of peripheral cleanup and code reuse possible as a follow
up to this CL. It's not attempted here to make this easier to merge back
to M69.

Bug: 849639
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: Ica6a3ec5b0e7951cb6807b135df4b4cfe410e394
Reviewed-on: https://chromium-review.googlesource.com/1158723Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580241}

This CL introduces a bare content feature to allow landing experimental
work and future CLs on MimeHandlerView using cross process frames. The
feature will be disabled by default.

MimeHandlerViewContainer is currently the last remaining GuestView
which still relies on BrowserPlugin. Eventually and starting with this
CL, the new implementation of MimeHandlerView will be based on
cross-process frames that no longer requires a BrowserPlugin.

Bug: 659750, 330264
Change-Id: I52a8eba4e9f2446ae0d899cd3a639f418bc01d12
Reviewed-on: https://chromium-review.googlesource.com/1073923
Commit-Queue: Ehsan Karamad <ekaramad@chromium.org>
Reviewed-by: James MacLean <wjmaclean@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580240}

This isn't needed anymore as we're now using LLD.

Bug: 804926, 821764
Change-Id: I3c6e4ce0793997823b89978cf7eda5b3a26399b8
Reviewed-on: https://chromium-review.googlesource.com/1108185Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580239}

When accessibility mode is enabled, show a preference in accessibility
settings that allows uers to disable the accessibility tab switcher.

We make a best effort guess as to when we should show the accessibility
tab switcher. Some users would prefer to use the regular tab switcher,
however.

BUG=859401

Change-Id: Ie8a8cf317a216b4343188e1a6d6cc037d31aae64
Reviewed-on: https://chromium-review.googlesource.com/1125323
Commit-Queue: Theresa <twellington@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580238}

This change updates the close button to be a fixed size regardless of
the window size.

Bug: 870186
Change-Id: Ib9de9508cef6f1faea272be7a223a15e86d7ac87
Reviewed-on: https://chromium-review.googlesource.com/1159987Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: apacible <apacible@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580237}

This CL adds a simple test case for exercising the Linux specific video capture
code for capturing video from a V4L2 device in singe-plane mode.

It fills in enough implementation in FakeV4L2Impl to make the test case work.

This CL is part of a series, see Design Doc at
https://docs.google.com/document/d/1ihGDZloUGdDpZ5XfmiI3AcqsSxOP9kOe5GxXOTqpHW4/edit?usp=sharing

Change-Id: I6def56fb99d662b5fc9683ed19671af4c219ee40
Reviewed-on: https://chromium-review.googlesource.com/1128272
Commit-Queue: Christian Fremerey <chfremer@chromium.org>
Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580236}

I thought it was nice to name everything Clear, but when I tried
to use it in one of the pending PRs it felt too much like action
from a distance to clear the agent state which causes the fields
to be cleared. So the more explicit name (like you suggested it)
is better. Sorry about the churn.

Change-Id: I33ab0b02a714dd93c2375ec28327a5eb58748135
Reviewed-on: https://chromium-review.googlesource.com/1159996Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Johannes Henkel <johannes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580235}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/7b323896..d1de8d3d

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ib25a70f5a74e8fdfe74e0f053a3861e50f455476
Reviewed-on: https://chromium-review.googlesource.com/1160868Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#580234}

This updates the icon to use the custom drawn icon supplied by UX. This
icon is only used in the toolbar indicator.

Bug: 870118
Change-Id: Idd3ee8767e372c855d149cd7debb0ec6d6b4aa90
Reviewed-on: https://chromium-review.googlesource.com/1159993Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: apacible <apacible@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580233}

The setup complete event it was gated on is deprecated. Now we should
just update device locale on start.

Bug: None
Test: locally build and run, watch the locale updated
Change-Id: Ieaaa6bd1926ab6c6a64da5f74d2b26ca9925de51
Reviewed-on: https://chromium-review.googlesource.com/1159734Reviewed-by: Tao Wu <wutao@chromium.org>
Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580232}

The tab switch button isn't ever truly focused, since focus remains with
the Omnibox. Thus, it never gets an accessibility event. This change
causes an accessibility event to be generated when we trigger a
simulated focus of the button.

Bug: 853929
Change-Id: I7db6a8bd906a1785f047dc62b2beb03f14e22114
Reviewed-on: https://chromium-review.googlesource.com/1157071
Commit-Queue: Kevin Bailey <krb@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580231}

Change-Id: I6863a2999525ac07cf942c26da5d6f8cf97eafa1
Reviewed-on: https://chromium-review.googlesource.com/1159352Reviewed-by: Bence Béky <bnc@chromium.org>
Commit-Queue: Nick Harper <nharper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580230}

This re-lands commit 1edc413f.

Original change is ps1, fix is in latest patchset.

Original change's description:
> OopAsh: port/enable some more browser tests.
>
> Bug: 854704
> Change-Id: Ic3dcef42f108beb02a398302f3ecd70dd72c0f2d
> Reviewed-on: https://chromium-review.googlesource.com/1153777
> Commit-Queue: Evan Stade <estade@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#579476}

Bug: 854704
Change-Id: I0a264093a2d90b00bcdc5a0e2e71a9d391336fea
Reviewed-on: https://chromium-review.googlesource.com/1159086
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580229}

These errors are causing all of the Settings tests to fail on CrOS. Fixing
those in preparation of adding webui_polymer2_browser_tests test suite.

Bug: 862472
Change-Id: Ica46f1fbef0f119c554d9003734544606c095c3c
Reviewed-on: https://chromium-review.googlesource.com/1160864Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580228}

This CL introduces impression and click metrics for all actions and
suggestions and the accessory sheet in general.

Bug: 853766
Change-Id: I47376dae669b99ae0e8701fb2e04efa292e8f673
Reviewed-on: https://chromium-review.googlesource.com/1157005Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Robert Kaplow (slow) <rkaplow@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Friedrich Horschig <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580227}

The capture state lives in ash, where ChromeVox sets the state (extension -> browser -> ash).

This state gets delivered (ash -> browser) to the SpokenFeedbackEventRewriterDelegate.

At that point, we should always allow the event to continue onto ChromeVox, and only re-inject if the key is captured.

The previous logic was put into place when this code always sent the delegate all keys.

Bug: 868573
Change-Id: I6bde8b021d093c52d4450682c4d037a7ef4938a0
Reviewed-on: https://chromium-review.googlesource.com/1159176Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580226}

Adds a sleep (ew) after entering presentation in VR tests for testing
that the Daydream controller's app buton exits presentation. This works
around a VrCore issue when skipping the DON flow that causes the
controller to briefly disconnect and reconnect when entering VR, eating
any controller input that's sent during that time.

Bug: 870031
Change-Id: Id888826907c9548120d36b0dde67e30271d4bc85
Reviewed-on: https://chromium-review.googlesource.com/1159398Reviewed-by: Amirhossein Simjour <asimjour@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580225}

ZipFile does not implement Closeable interface prior to api19:
https://developer.android.com/sdk/api_diff/19/changes/java.util.zip.ZipFile
It was introduced as a fix for failed library extraction here:
https://chromium-review.googlesource.com/c/chromium/src/+/930332
So, this code gets executed quite rare, but I can see some
"java.lang.IncompatibleClassChangeError: interface not implemented" errors
on our radars at Yandex, mostly Huawei 4.1.2, 4.2.* and 4.3.*. Since
non-googlers don't have access to crash tickets, I can't check if Chrome
has same issues, but I believe that you have.

This CL adds a custom closeQuietly method for ZipFile, and rewrites a
try-with-resources statement with it. Docs say that ZipFile.close() also
closes all the streams, so I removed InputStream from try as well:
https://developer.android.com/reference/java/util/zip/ZipFile.html#close().

R=agrieve@chromium.org,ranj@chromium.org

Change-Id: I6b626bf87f01f5598ab61be3ac88759b4c7076e2
Reviewed-on: https://chromium-review.googlesource.com/1156397Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580224}