GitLab

Several //ipc headers will depend on a generated buildflag header and
we have to guarantee the existence of this header before the build of
these source sets.

BUG=711302

Review-Url: https://codereview.chromium.org/2852273002
Cr-Commit-Position: refs/heads/master@{#469232}

Two problems here:
. timeout is in seconds, not minutes.
. hard_timeout needs to be inside the swarming block, otherwise it's
  not used at all.

BUG=none
TEST=none
R=rockot@chromium.org
TBR=rockot@chromium.org

Review-Url: https://codereview.chromium.org/2856183002
Cr-Commit-Position: refs/heads/master@{#469231}

Currently when a checkbox is the extra view, the checkbox tends to cause
the other buttons in a dialog to get bigger. This is because Checkbox
extends LabelButton, so the check using AsCustomButton() will classify
it the same way.

To fix, explicitly filter out Checkboxes from the equal-sizing logic in
DialogClientView.

BUG=671820

Review-Url: https://codereview.chromium.org/2855623004
Cr-Commit-Position: refs/heads/master@{#469230}

The implementation is now part of a class private to network_connection_handler.cc.

This is in preparation for using a test double for NetworkConnectionHandler.

BUG=672263

Review-Url: https://codereview.chromium.org/2861883002
Cr-Commit-Position: refs/heads/master@{#469229}

BUG=
TBR=palmer@chromium.org

Review-Url: https://codereview.chromium.org/2859983002 .
Cr-Commit-Position: refs/heads/master@{#469228}

BUG=none
TBR=junov@chromium.org

Review-Url: https://codereview.chromium.org/2856223005
Cr-Commit-Position: refs/heads/master@{#469227}

BUG=705331

Review-Url: https://codereview.chromium.org/2850533003
Cr-Commit-Position: refs/heads/master@{#469226}

See https://html.spec.whatwg.org/multipage/infrastructure.html#safe-passing-of-structured-data

And the web platform test here:
https://github.com/w3c/web-platform-tests/blob/master/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/serialization-via-notifications-api.any.js

BUG=chromium:718192

Review-Url: https://codereview.chromium.org/2860873002
Cr-Commit-Position: refs/heads/master@{#469225}

They're intermittently running out of memory. Seems difficult to
guarantee that resources will be reclaimed promptly enough for large
allocations to succeed all the time.

BUG=717023
TBR=zmo@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2857583006
Cr-Commit-Position: refs/heads/master@{#469224}

BUG=717417

Review-Url: https://codereview.chromium.org/2863523003
Cr-Commit-Position: refs/heads/master@{#469223}

BUG=713829
TBR=zmo@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2855323002
Cr-Commit-Position: refs/heads/master@{#469222}

method and instead explicitly track the state in QuicChromiumClientStream.

BUG=716563

Review-Url: https://codereview.chromium.org/2861583004
Cr-Commit-Position: refs/heads/master@{#469221}

Produce a WebRTC log message when:
* starting to use gpu jpeg decoder
* received first decoded frame from gpu jpeg decoder
* gpu jpeg decoder fails
* first frame received at VideoCaptureController

BUG=717772

Review-Url: https://codereview.chromium.org/2860573008
Cr-Commit-Position: refs/heads/master@{#469220}

Adding support for "removed on cache reset" pages to the query interface.
Also Adding a new interface on OfflinePageModel to delete pages matching
a specific query.

BUG=716142

Review-Url: https://codereview.chromium.org/2858803002
Cr-Commit-Position: refs/heads/master@{#469219}

There are no flags to be updated

deprecate FLAGS_quic_reloadable_flag_quic_bbr_keep_sending_at_recent_rate in disabled state.

It achieved results that were in general comparable to "measuring
aggregation" approach, but it had worse rtx rate, and worse QoE, and did
not actually seem to be better in other regards.

Merge internal change: 154601526

https://codereview.chromium.org/2859913003/

fix packet conservation to remove packets from recovery window when they are lost.  Protected by FLAGS_quic_reloadable_flag_quic_bbr_fix_conservation2.

This causes a dramatic reduction in losses compared to the previous patch.

The transfer time is approximately the same.

Merge internal change: 154590929

https://codereview.chromium.org/2857243002/

Fix typo in comments.

Merge internal change: 154539040

https://codereview.chromium.org/2854823004/

QUIC - refactor stream creation. Guarded by --quic_reloadable_flag_quic_refactor_stream_creation.

This CL is in preparation for HTTP stream pairs changes.  A prototype
of the entire HTTP stream pairs work is in progress.  This CL is one
subset of that (2nd in the series).

[ HTTP stream pairs builds upon this, by having new QuicSpdySession
overrides that implicitly create headers streams, and abstracting
stream accounting as needed. ]

Add a new factory like method QuicSession::CreateStream(), that
unconditionally creates a new stream.  It's virtual so subclasses of
QuicSession can create streams that are appropriately specialized from
QuicStream.  There are new versions of Create*DynamicStream() called
MaybeCreate*DynamicStream(), and ShouldCreate*DynamicStream() called
ShouldCreate*DynamicStream2().

Separating this out means that fewer overrides of Create*DynamicStream()
and ShouldCreate*DynamicStream() will necessary, because many of those
were actually only needed to specialize the steam types.  Those will go
away when FLAGS_quic_reloadable_flag_quic_refactor_stream_creation is
deprecated.

Merge internal changes: 154351257, 154373998.

https://codereview.chromium.org/2861673004/

QUIC - stream id refactor for tests.

// AKA - http stream pairs bikeshed #1.

This CL is in preparation for HTTP stream pairs changes.  A prototype
of the entire HTTP stream pairs work is in progress.  This CL is one
subset of that.

Rework QUIC tests so that they do not hard code the assumption that
all headers are on stream 3.  Also, prepare to calculate stream ids
according to whether stream pairs are enabled, i.e. whether they
increment by 2 or 4.

Merge internal change: 150949425

https://codereview.chromium.org/2854833005/

R=rch@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2862563003
Cr-Commit-Position: refs/heads/master@{#469218}

If the get buffer is destroyed say in SetAggressivelyFreeResources, the
next OrderingBarrier call after recreating the get buffer will see the
old value for last_barrier_put_offset_. CommandBufferProxyImpl uses this
to set the put_offset_changed parameter for OrderingBarrier. If the new
put_offset_ matches last_barrier_put_offset_ exactly the OrderingBarrier
becomes a nop. That can cause contexts to run out of order causing
all sorts of rendering glitches.

R=jbauman
BUG=715997

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ie1e511e22a3e2f3b0e71ea872bbd690925725be9
Reviewed-on: https://chromium-review.googlesource.com/495369Reviewed-by: John Bauman <jbauman@chromium.org>
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#469217}

The chrome://extensions page uses different urls for a few things,
primarily to highlight a given extension or to display the extension's
options. In the MD version, we have separate pages for these, which
makes these more like navigations.

Add basic page and history manipulation to the chrome://extensions page.
Navigating to a subpage updates the location and pushes a new state to
the history stack, so that clicking back will return you to the previous
page. Dialogs are contained within a page, and do not push a new
history state.

Examples:
- Navigating from the main view to the details view updates the
  location, and 'back' would return to the main view.
- Opening the options dialog from the details view does not push new state
  (since otherwise 'back' would just close the dialog).

Add tests for the same.

BUG=529395
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2811993004
Cr-Commit-Position: refs/heads/master@{#469216}

In this CL:
* Always show IP config section for remembered or connected networks.
* Fix editing IP config when switching from automatic to static.

BUG=717262
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2856023002
Cr-Commit-Position: refs/heads/master@{#469215}

BUG=672263

Review-Url: https://codereview.chromium.org/2861583002
Cr-Commit-Position: refs/heads/master@{#469214}

The NaCl build (used by //remoting) doesn't actually process
certificates, so we can switch them easily. (They configure
SSLClientSocket to allow only a single certificate and run some other
authenticator over the channel.)

Sadly, this doesn't buy the binary size wins yet. It looks like this is
because they pull in WebRTC. But it means that once this and the Android
switch sticks, we can tidy up USE_OPENSSL_CERTS.

BUG=671420

Review-Url: https://codereview.chromium.org/2861813002
Cr-Commit-Position: refs/heads/master@{#469213}

Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/86a6787..075011d

$ git log 86a6787..075011d --date=short --no-merges --format=%ad %ae %s
2017-05-03 ehmaldonado@webrtc.org Revert of Move CoreVideoFrameBuffer from webrtc/common_video/ to webrtc/sdk/objc/ (patchset #2 id:60001 of https://codereview.webrtc.org/2851563003/ )
2017-05-03 glaznev@webrtc.org Initial implementation of Android audio playback error handling.
2017-05-03 mbonadei@webrtc.org fixing braces around initialization of subobject
2017-05-03 deadbeef@webrtc.org Fixing DCHECK in turnport.cc that was broken by refactoring.
2017-05-03 henrika@webrtc.org Resolves race between Channel::ProcessAndEncodeAudio() and Channel::StopSend()
2017-05-03 magjed@webrtc.org Move CoreVideoFrameBuffer from webrtc/common_video/ to webrtc/sdk/objc/
2017-05-03 peah@webrtc.org Reland of Added ARM Neon SIMD optimizations for AEC3 (patchset #1 id:1 of https://codereview.webrtc.org/2856113003/ )
2017-05-03 mbonadei@webrtc.org Revert of Extract iOS SDK helpers to separate target. (patchset #1 id:1 of https://codereview.webrtc.org/2852323003/ )
2017-05-03 peah@webrtc.org Revert of Added ARM Neon SIMD optimizations for AEC3 (patchset #2 id:970001 of https://codereview.webrtc.org/2834073005/ )
2017-05-03 peah@webrtc.org Added ARM Neon optimizations for AEC3
2017-05-03 mbonadei@webrtc.org Reland of Extract iOS SDK helpers to separate target. (patchset #1 id:1 of https://codereview.webrtc.org/2853273002/ )
2017-05-03 peah@webrtc.org Corrected the behavior in AEC3 during buffer overruns and underruns
2017-05-03 kjellander@webrtc.org Remove config.h from //webrtc:webrtc target.
2017-05-03 mbonadei@webrtc.org Adding virtualsocketserver to rtc_base sources
2017-05-03 brandtr@webrtc.org Reland of Don't reinit encoder when rotation changes. (patchset #1 id:1 of https://codereview.webrtc.org/2861633003/ )
2017-05-03 brandtr@webrtc.org Revert of Don't reinit encoder when rotation changes. (patchset #3 id:40001 of https://codereview.webrtc.org/2853463004/ )
2017-05-03 sakal@webrtc.org Address tkchin's comments on RTCCameraVideoCapturer.
2017-05-03 brandtr@webrtc.org Don't reinit encoder when rotation changes.
2017-05-03 brandtr@webrtc.org Don't re-randomize picture_id/tl0_pic_idx when re-initializing internal encoders.
2017-05-03 bpostelnicu@mozilla.com Make sure the resulted operation is calculated on float basis.
2017-05-03 sakal@webrtc.org Fix lint issues on Android.

TBR=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
BUG=

Review-Url: https://codereview.chromium.org/2855303002
Cr-Commit-Position: refs/heads/master@{#469212}

https://skia.googlesource.com/skia.git/+log/ab244f045a07..6d4b65e9dad9

$ git log ab244f045..6d4b65e9d --date=short --no-merges --format='%ad %ae %s'
2017-05-03 bsalomon Revert "Revert "Add a new non-AA rect op that does not inherit from GrLegacyMeshDrawOp.""
2017-05-03 mtklein treat SkPMColor as sRGB in SkPM4f::FromPMColor()
2017-05-03 bsalomon Revert "Add a new non-AA rect op that does not inherit from GrLegacyMeshDrawOp."
2017-05-03 bsalomon Add a new non-AA rect op that does not inherit from GrLegacyMeshDrawOp.
2017-05-03 mtklein fix G3 opt android_arm build?
2017-05-03 mtklein disable test_diagonal on 565
2017-05-03 fmalita Validate SkSpecialSurface raster info
2017-04-05 halcanary headers: fix
2017-05-03 fmalita Add a GM to exercise some complex gradient constructs

Created with:
  roll-dep src/third_party/skia
BUG=716311


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=scroggo@chromium.org

Change-Id: I0ef3efa6313f3f0815315cf662a0c94729c34b58
Reviewed-on: https://chromium-review.googlesource.com/494969Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#469211}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/5c834a1ca845..0d00147b4f72

$ git log 5c834a1ca..0d00147b4 --date=short --no-merges --format='%ad %ae %s'
2017-05-03 dtu [pinpoint] Make handlers consistent.

Created with:
  roll-dep src/third_party/catapult


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I4e11ce037a3018a7efd8e915de5d0f248dbab419
Reviewed-on: https://chromium-review.googlesource.com/495387
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#469210}

This is a minimal fix for issues with getUniformBlockIndex and
getTransformFeedbackVarying. Also removes unused Shader::GetMappedName.

This corrects the behavior of GetOriginalNameFromHashedName.
Previously, uniform block names were unmapped using "name_map", but
name_map was not restored upon load. Now, instead of name_map, the five
info maps (attrib, uniform, varying, interface block, output variable)
are queried serially in GetOriginalNameFromHashedName.

Unused code around name_map will be removed in a subsequent CL.

BUG=716018
TEST=https://github.com/KhronosGroup/WebGL/pull/2388
TEST=https://github.com/KhronosGroup/WebGL/pull/2389
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2857083002
Cr-Commit-Position: refs/heads/master@{#469209}

Accessing content URI can throw more exceptions than expected.
This CL catch all possible exceptions so we don't crash.

BUG=706299

Review-Url: https://codereview.chromium.org/2861583008
Cr-Commit-Position: refs/heads/master@{#469208}

This is the first step of deprecating Native App Launcher.
This puts the functionality behind an experimental flag
experimental_flags::IsNativeAppLauncherEnabled().
There will be lots of dead code and unused classes/methods left after
this step and they will be removed after experiment is removed.

Default for experiment is Native App Launcher *disabled*.

BUG=711511
TEST=Tools > Settings > Google Apps should not be there. Visits to Maps or YouTube sites will not show infobar. Tapping on Maps or YouTube links may still launch Maps and YouTube app because of Universal Links.

Review-Url: https://codereview.chromium.org/2860573003
Cr-Commit-Position: refs/heads/master@{#469207}

Revert of DevTools: support resolving a UILocation to multiple raw script locations (patchset #3 id:60001 of https://codereview.chromium.org/2857453002/ )

Reason for revert:
We decided that we don't need that.

Original issue's description:
> DevTools: support resolving a UILocation to multiple raw script locations
>
> This turns uiLocationToRawLocation into uiLocationToRawLocations and makes it return an array
>
> BUG=717694
>
> Review-Url: https://codereview.chromium.org/2857453002
> Cr-Commit-Position: refs/heads/master@{#468825}
> Committed: https://chromium.googlesource.com/chromium/src/+/421b9c4b9736e52c903123994d977b4ed406cf72

TBR=dgozman@chromium.org,lushnikov@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=717694

Review-Url: https://codereview.chromium.org/2859073002
Cr-Commit-Position: refs/heads/master@{#469206}

Previously we have used the pre-release code names for checking whether
the current platform Chrome runs on is Android O. This CL updates this
to instead check against the Build.VERSION.SDK_INT when running on
release builds of the OS.

This CL also updates the the check for whether Chrome is currently
targeting Android O, which now also uses the Build.VERSION.SDK_INT for
release builds, but still checks against CUR_DEVELOPMENT for
pre-releases for Android O.

BUG=685808

Change-Id: I7f17fd5bc8f6489586435818b224b080c391295c
Reviewed-on: https://chromium-review.googlesource.com/495266
Commit-Queue: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Theresa Wellington <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#469205}

In order to better understand Chrome usage, add metrics that help us
figure out if Chrome is the default browser on the system or not.

BUG=704223

Review-Url: https://codereview.chromium.org/2843693002
Cr-Commit-Position: refs/heads/master@{#469204}

NGLayoutInputNode::ShowNodeTree will be used for debugging or
demonstration purposes(ex. show how the changes in LayoutObject tree will
look like in LayoutNG)

BUG=636993

Review-Url: https://codereview.chromium.org/2854993002
Cr-Commit-Position: refs/heads/master@{#469203}

The crash occurs because chrome --mash doesn't have a
chromeos::UIProxyConfigService. For classic ash this is usually
created by chrome browser during startup. This object is using in
ash to display a "your connection may be monitored" warning when
using a network proxy. It has dependencies on the user profile
pref service and the local state prefs, so we can't create one
for mash yet.

As a temporary measure, add a check for mash and skip the warning. This
can be fixed properly when the mojo prefs service supports local state.

Also add tests for TrayNetwork. This requires making it optional to
initialize chromeos::NetworkHandler and DBusThreadManager in
mash_unittests.

BUG=717645,718072
TEST=ash_unittests, also chrome --mash doesn't crash when opening
system tray networking menu

Review-Url: https://codereview.chromium.org/2861773003
Cr-Commit-Position: refs/heads/master@{#469202}

The CastContentWindowAndroid object would only get destroyed
after the WebContents, but the Java handler for the former's
destructor requires WebContents to still be around. Destroy
the window_ in CastWebView before resetting the web_contents_.

BUG=Internal b/37791255
TEST=Cast Play Movies to Android TV, tear down app, no crash.

Change-Id: I496b19fdd97734bb00cfa3663c5d5a3f95a16d5d
Reviewed-on: https://chromium-review.googlesource.com/494098Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Simeon Anfinrud <sanfin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#469201}

BUG=718183, 718194
TBR=zmo@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2858123002
Cr-Commit-Position: refs/heads/master@{#469200}

Occasionally ChromeDriver may fail to delete temporary directories
while exiting, causing wasted disk space. This change adds retry
logic while cleaning up these directories.

BUG=chromedriver:644

Review-Url: https://codereview.chromium.org/2853953002
Cr-Commit-Position: refs/heads/master@{#469199}

BUG=491778

Review-Url: https://codereview.chromium.org/2854303004
Cr-Commit-Position: refs/heads/master@{#469198}

BUG=718150

Review-Url: https://codereview.chromium.org/2861823002
Cr-Commit-Position: refs/heads/master@{#469197}

Adds a bunch of missing nullchecks.

Not sure why crash frequency has increased recently. Perhaps changes in
RenderFrameObserver lifecycle:
https://codereview.chromium.org/2034153002

BUG=717886

Review-Url: https://codereview.chromium.org/2860783002
Cr-Commit-Position: refs/heads/master@{#469196}

BUG=690901

Review-Url: https://codereview.chromium.org/2862703002
Cr-Commit-Position: refs/heads/master@{#469195}

This CL removes the following files from bindings/core/v8 and updates
all include sites to use their platform/bindings version:

- ToV8.h
- TraceWrapperMember.h
- TraceWrapperV8Reference.h
- ScriptWrappableVisitorVerifier.h
- SharedPersistent.h
- StringResource.h
- ScriptWrappableVisitor.h

BUG=682322
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2856653003
Cr-Commit-Position: refs/heads/master@{#469194}

If a StreamReader is found that it can no longer write any data, we should
clear its callback.
Otherwise, the StreamReader can  still report an error and interrupt the download.

BUG=717719

If the data has already been written

Review-Url: https://codereview.chromium.org/2861443005
Cr-Commit-Position: refs/heads/master@{#469193}