GitLab

This CL:
- Generates monochrome_python_tests.pydeps using --gn-paths flag
- Adds run_isolated_script_test.py data deps to
  monochrome_public_apk_checker.py
- Adds //testing:run_isolated_script_test target to collect the data
deps for monochrome_public_apk_checker.py

BUG=1138758

Change-Id: Ifffa033368980923e2587e52ff50d35eeae2f271
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483664Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818597}

This removes the remaining DictionaryValue usage from shill client and
fake client classes.

For minor apitest.cc change to c/b/e/api/vpn_provider:
TBR=emaxx@chromium.org

Bug: 1137487
Change-Id: Id3a84f1392f0d1586342b4441ad200f0a41110e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466931
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Azeem Arshad <azeemarshad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818596}

action-link no longer exists on the NTP.

Bug: none
Change-Id: I4df61932f6b1885bd98a56f4963aead4dafe352c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480889Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818595}

Change AppShimManager::AppState::ShouldDeleteAppState to return true
if the app is not installed for any profiles. Previously, the app
would continue running even after it had been deleted, resulting in
all sorts of cool behaviors. This winds up being hit in two paths.

First path is the AppShimManager::OnAppDeactivated call that is made
when a profile closes its last app window. This fixes crbug.com/1139254
where an app kept running even after it was uninstalled.

Second path is AppShimManager::OnProfileMarkedForPermanentDeletion,
for when a profile is deleted. This is for crbug.com/1132223 and is
a bit more involved.
* Listening for chrome::NOTIFICATION_PROFILE_CREATED/DESTROYED has
  been deprecated for a half-decade, so change AppShimManager to be
  a ProfileManagerObserver instead.
* Inline AppShimManager::CloseShimsForProfile to be a lambda inside
  of OnProfileMarkedForPermanentDeletion.
* Of note about ProfileManagerObserver is that closing app shims
  inside OnProfileMarkedForPermanentDeletion can cause crashes
  because it is not expected that Browser instances will be closed
  inside that call. For that reason, post a task to do the work.

Update tests (because now they're affected by the AppShimRegistry)
and add tests for both paths (shim installed vs uninstalled).

Since AppShimManager is now a ProfileManagerObserver we have to
make sure that the AppShimManager stops observing the ProfileManager
before the ProfileManager is destroyed. To do this, a new call,
BrowserProcessPlatformPart::BeginStartTearDown, which happens at
the beginning of BrowserProcessPlatformPart::StartTearDown.

Bug: 1139254,1132223
Change-Id: I19990f6ae5ff8d8727e1fb0ecf46d1142b543764
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481790Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818594}

This reverts commit 78b97c89.

Reason for revert: causes TSAN failures in:
RenderViewBrowserTest.ConfirmCacheInformationPlumbed
DomSerializerTests.SerializeHTMLDOMWithEmptyHead
DomSerializerTests.SerializeHTMLDOMWithoutDocType

Manual revert to due (small) merge conflicts

Originally reviewed on:
https://chromium-review.googlesource.com/c/chromium/src/+/2378763

TBR=bungeman@chromium.org

Bug: 1126992
Change-Id: Id3c1460de179d333710d4438fd81563548eed4b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485557Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Ian Prest <iapres@microsoft.com>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818593}

Change-Id: Id23ebabc4f86c5b2a2bc6b88d69877aad9c8bcf9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425030
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818592}

Change the cursor type based on capture mode state and cursor location
in screen.

Test: manual, added test
Bug: 1135700
Change-Id: I57af8b672bf6f0e04a422ed5be4fe40468fcc3ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454838
Commit-Queue: Richard Chui <richui@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818591}

Users have reported a subtle flash during the overview animation. This
is because the current cross fade animation fades out the old layer
while fading in the new layer. This will cause the combined opacities
of the two layers to be 1 at the endpoints, but less than 1 in
between, resulting in the middle of the animation being slightly dimmer.

Discussed with UX in the bug, and make the only the old layer fade out.
This will result in the combined opacity always being 1.

Test: manual
Change-Id: Iacc7adcbc424f59656d7876bfecf32e3cb048b2d
Fixed: 1124947
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481002
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818590}

Currently existence of non passive wheel event handler is
tracked on a frame level on cc. This requires main thread to process
all wheel events before scroll may begin on cc thread regardless
if the scroll was performed outside of a wheel region.

This change computes blocking wheel handler regions on main thread
and passes this information to cc, thus enabling starting composited
scrolls, when outside the blocking handler region, without querying
the main thread

Changes made:
- The feature is implemented behind cc feature flag, WheelEventRegions.
- Track if a given LayoutObject has a non-passive wheel event handler on
  itself or an ancestor that the wheel event could bubble to.
  To implement this tracking, we update a bit on the LayoutObject,
  InsideBlockingWheelEventHandler, during the PrePaint walk. This bit
  will be used during invalidation and painting to update hit-testing
  information on the generated paint chunks later in the pipeline.
  Additionally, support for this bit is added to the display locking
  code to keep wheel event handler updates from updating content in
  locked sections of the dom until the unlock occurs.
- Blocking wheel event regions are generated in the same manner as touch
  action regions. First, paint adds blocking wheel event rects
  to the HitTestData's wheel_event_rects associated with the relevant
  PaintChunks. Later, these PaintChunks are iterated through in
  PaintArtifactCompositor::UpdateWheelEventRects to create a region
  that is passed to the Layer.
- Blocking wheel event regions are passed from cc::Layer to cc::LayerImpl
  as part of PushPropertiesTo mechanism. This allows cc's wheel event
  routing to avoid sending wheel events through the renderer's main
  thread when they do not intersect with a rect that has a wheel event
  listener present, leading to improved latency.

See design doc:
https://docs.google.com/document/d/1ar4WhVnLA-fmw6atgP-23iq-ys_NfFoGb3LA5AgaylA/edit#heading=h.4wyzpk30wixv

Bug: 841364
Change-Id: If9291332fcb49127d6defd4c7d324568597931c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419718
Commit-Queue: Olga Gerchikov <gerchiko@microsoft.com>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Sam Fortiner <samfort@microsoft.com>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818589}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
Tbr: cr-fuchsia+bot@chromium.org
Change-Id: I24e743ef969cc30668d8be7a550b10e88c3d1170
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486051Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#818588}

https://screenshot.googleplex.com/5ywKyKorL3QKeCj

Bug:1125150
Test: browser_tests --gtest_filter=DiagnosticsApp*

Change-Id: I9c8641b7ddfeebefede0984fdeb0248d7bcec8c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477660Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Joon Ahn <joonbug@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818587}

I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/Wodp9dSSdL8/m/OZo2vJqTAwAJ
Fixed: 568705, 808904, 1127343, 1127347
Change-Id: Ib81bf8243cc57124ac5e781e5d6da5d4b09d7edf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484600Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818586}

This reverts commit 7002dd78.

Reason for revert: Causes test flakiness: crbug.com/1139549. Unintended behavior change.

Original change's description:
> Log tab switch latency histograms through RecordHistogram
>
> Remove JNI calls that do only that and record through the Java API.
>
> Bug: 1139081
> Change-Id: I6f22bca96f8e3bd2de125d6e302d12eadb5e4301
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473042
> Reviewed-by: David Trainor <dtrainor@chromium.org>
> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#818043}

TBR=dtrainor@chromium.org,hnakashima@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1139081, 1139549
Change-Id: I7239091d6f7bb2fefd959b120625b834921d1881
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485637Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818585}

This fix is a result of an investigation to find out why KeyboardLock
stops working after approving the microphone permission on another
website (even after it has been navigated away from or the tab closed).

I tracked the issue down to this class as it registers a RawInputDevice
to listen for keyboard input but failed to unregister it properly when
the monitor was stopped.

Per MSDN, the HWND param should be NULL when unregistering the device:
https://docs.microsoft.com/en-us/windows/win32/api/winuser/nf-winuser-registerrawinputdevices

Change-Id: Icf54f3ac61fe5020b00472e6680e4e533b1fd256
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482044Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Joe Downing <joedow@google.com>
Cr-Commit-Position: refs/heads/master@{#818584}

As khorimoto@ pointed out on crrev.com/c/2471900, each assertion (or
expectation) looking at `offsetHeight` directly is rather hard to read,
and doesn't make it clear what's actually being tested. This CL changes
all visibility assertions and expectations to use the same `isVisible`
method.

Bug: none
Test: check the tests pass, and fail if `hidden` is added to an element
Change-Id: I21dacaca741324c20b671748cea71e4c885b9d7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484931Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Harry Cutts <hcutts@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818583}

Bug: 1139118
Change-Id: I93ac21edbeb2317f677770b32dfe482715e44c18
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481355Reviewed-by: Jonathan Ross <jonross@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Jonathan Backer <backer@chromium.org>
Commit-Queue: Brian Salomon <bsalomon@google.com>
Cr-Commit-Position: refs/heads/master@{#818582}

TBR=rsleevi@chromium.org

Change-Id: Iad5b936d495d48cae46e6c119a542c1d650d592d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485136Reviewed-by: Nick Harper <nharper@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Commit-Queue: Nick Harper <nharper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818581}

This removes logic for obtaining a pinUvAuthToken in
MakeCredentialRequestHandler in favor of using AuthTokenRequester.

There should be no behavior changes as to whether PIN or internal UV is
requested for a given makeCredential request. (And existing
PIN/UV-related test cases in authenticator_impl_unittest.cc provide
decent coverage to ensure that this is indeed the case.)

There is a small change in handling authenticator removal mid-request:
This would previously only abort the request if the handler was waiting
for a PIN. It now generally aborts the request as long as an
authenticator has been chosen, but the request hasn't finished (e.g.
because a it is waiting to enroll a biometric template).

Also changes VirtualCtap2Device to return CTAP2_ERR_UV_BLOCKED if a
failed UV attempt locks the authenticator, as the spec prescribes.

Bug: 1139111
Change-Id: I4c07b16294ffba4a15ea813e182ad669645bf703
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469445
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: Nina Satragno <nsatragno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818580}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e6d60bea7801..46e1bcace932

2020-10-19 tvanderlippe@chromium.org Remove pre_generates_legacy from module.json files
2020-10-19 tvanderlippe@chromium.org Unconditionally use object notation for dispatchers
2020-10-19 tvanderlippe@chromium.org Remove rollup_module from build_release_applications
2020-10-19 tvanderlippe@chromium.org Remove Dispatcher protocol types
2020-10-19 karntino.c.areros@gmail.com enable CTRL key operation on value widget/decoration
2020-10-19 sigurds@chromium.org Add API section to frame details view
2020-10-19 pfaffe@chromium.org Fix two minor issues in node.py
2020-10-19 aerotwist@chromium.org TypeScriptify AnimationTimeline.js
2020-10-19 alexrudenko@chromium.org Fix grid labels rendering
2020-10-19 sigurds@chromium.org Add more information to error reporting on connection close

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1011811,chromium:1090846,chromium:1131500,chromium:1138492,chromium:1139897,chromium:1139899
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I32f6e230e96465f5eff9f6614a2039392410582e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485600Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#818579}

https://chromium.googlesource.com/angle/angle.git/+log/6883db53569f..6d3d381e7251

2020-10-19 geofflang@chromium.org GL: Update BufferGL to use ANGLE_GL_TRY.
2020-10-19 jmadill@chromium.org Test Runner: Disable watchdog when debugger attached.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC jonahr@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: jonahr@google.com
Change-Id: I0588d2df0313d197d59fa74ac9be23f4fb9a8357
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485601Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#818578}

TBR=jdonnelly@chromium.org

Bug: 11401539
Change-Id: Ia9963196b784a1e1b923d488af722df2bff000de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485440Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818577}

This change adds support for the prefers-contrast media query and adds
PreferredContrast to settings. The logic for updating PreferredContrast
from its default state based on the OS will be implemented in a
follow-up change.

Spec:
https://drafts.csswg.org/mediaqueries-5/#prefers-contrast

Intent to prototype:
https://groups.google.com/a/chromium.org/g/blink-dev/c/I0e2_nAwW7E

Bug: 1107431
Change-Id: Ie09df9069c979caf944d8af1d5f6bde80f40e8ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410646
Commit-Queue: Alison Maher <almaher@microsoft.com>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818576}

https://skia.googlesource.com/skia.git/+log/abdfd39bb64e..bcd1fc030a2b

2020-10-19 johnstiles@google.com Avoid changing built-in symbol tables during lookup.
2020-10-19 kylechar@chromium.org Add context option to disable mipmap support
2020-10-19 johnstiles@google.com Add builtin flag to SymbolTable.
2020-10-19 mtklein@google.com fix forward/backward jump logic

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC egdaniel@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: chromium:1138979
Tbr: egdaniel@google.com
Change-Id: Ieace4fcdc667f15bf303181cc235039a3d0752b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485611Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#818575}

Uncomments per-file owner now that alexmt@ is a committer

Change-Id: I501de30a9afde3c7a758c8957a6923dd3149829a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481703Reviewed-by: Ravi Mistry <rmistry@chromium.org>
Commit-Queue: Ravi Mistry <rmistry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818574}

BUG=1138236

Change-Id: Ice5140053b6216c6a2f9300a9da71f6d079f4550
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482182
Auto-Submit: Theresa  <twellington@chromium.org>
Commit-Queue: Brian White <bcwhite@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818573}

TBR=govind@chromium.org

Change-Id: I6ce4cd4c98d1c689d1526d5877d803cab31ac5f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485638Reviewed-by: Ben Mason <benmason@chromium.org>
Commit-Queue: Ben Mason <benmason@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818572}

The extension request will be uploaded to DM server right after user
request it. This may significantly increases the DM server traffic. Put
this functions behind feature flag so that we could turn it off just in
case.

Bug: 1137964
Change-Id: Ia056ddd356d068680c63d1e7650b4f1ea3a923be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472459
Commit-Queue: Owen Min <zmin@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818571}

This fixes an issue I introduced in m85 here:
https://chromium-review.googlesource.com/c/chromium/src/+/2181827
during our migration of all "bookmark apps" off of the extensions system
and onto the WebAppProvider system.

Making YouTube no longer a 'bookmark app' (and back to a hosted app)
had the side effect of making its storage protected, because apparently
all hosted apps have their storage protected.

This change marks all potential default hosted apps as no longer
receiving protected storage.

The long term fix for this issue is to have the WebAppProvider system
support default apps, and migrate these old hosted apps (which is a
double-deprecated system) onto the WebApp platform:
https://bugs.chromium.org/p/chromium/issues/detail?id=1140122

R=cmp@chromium.org

Bug: 1139902
Change-Id: I0d09eed3bf232407192fd07e621b82bcac4263f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485436Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Chase Phillips <cmp@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818570}

Roll ChromeOS Atom AFDO profile from 88-4277.0-1602497703-benchmark-88.0.4294.0-r1 to 88-4280.20-1603104419-benchmark-88.0.4296.0-r1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-atom-chromium
Please CC c-compiler-chrome@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: c-compiler-chrome@google.com
Change-Id: Ifa6b3c76d5c0c9f481fe4664cf5fbdd2837f5d7d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485605Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#818569}

Mixed content autoupgrades are currently completely disabled for
webview, this makes them controllable with a webview specific
variations flag. Flag is also exposed in AW devtools.

Bug: 1139424
Change-Id: I9095cdd98eef0136106d087af3f1f104784d3dd6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480817Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Carlos IL <carlosil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818568}

This reverts commit ed41365b.

Reason for revert: Newly added tests failing consistently on android-pie-x86-rel

Original change's description:
> Introduce LayoutStateObserver to notify the state for all Layouts
>
> This CL introduces a generic LayoutStateObserver for getting
> notifications from the Layout system about every supported layouts
> show/hide state changes. This LayoutStateObserver is added to the Layout
> system via the LayoutStateProvider.
>
> Additionally, this CL merges the SceneChangeObserver interface into
> LayoutStateObserver:
>   * SceneChangeObserver#onTabSelectionHinted ->
>       LayoutStateObserver#onTabSelectionHinted
>   * SceneChangeObserver#onSceneChange ->
>       LayoutStateObserver#onStartedShowing
>
> Note:
> 1. This CL breaks from crrev.com/c/2353875.
> 2. This new notification system has been integrated to production
> code with zero callers.
>
> Change-Id: I23bd2b5b1b674a6df554a2edd1ffbfb32da5d6b1
> Bug: 1108496
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463850
> Commit-Queue: Mei Liang <meiliang@chromium.org>
> Reviewed-by: Matthew Jones <mdjones@chromium.org>
> Reviewed-by: Theresa  <twellington@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#818290}

TBR=twellington@chromium.org,mdjones@chromium.org,meiliang@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1108496
Bug: 1139943
Change-Id: I05c7b7d97d389e7498bfc58d6a073c68ec08e5bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485636Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818567}

https://dawn.googlesource.com/dawn.git/+log/875091308b04..aff4c0366314

2020-10-19 enga@chromium.org Fix unused variable warnings on ChromeOS
2020-10-19 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from c9a3e4739678 to 7156d3e3140b (1 revision)
2020-10-19 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 89042538376b to c9a3e4739678 (1 revision)
2020-10-19 enga@chromium.org Add missing include in SwapChainVk
2020-10-19 dsinclair@chromium.org Fixup cmake file
2020-10-19 enga@chromium.org Reland "Replace the wire serializer with a no-op impl on disconnect"
2020-10-19 jiawei.shao@intel.com Add the entry point of CreateReadyComputePipeline
2020-10-17 cwallez@chromium.org Initial new swapchains on Vulkan.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC dsinclair@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: chromium:951558
Tbr: dsinclair@google.com
Change-Id: Ib016997050dc5ce881fc8bd21de57971687bec0e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485598Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#818566}

Usage of this option is deprecated and was dropped in
https://github.com/web-platform-tests/wpt/pull/26118

Bug: 1139500
Change-Id: I55ba3accd355eb61fd865007294517a8e8aaac4c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485011Reviewed-by: Robert Ma <robertma@chromium.org>
Reviewed-by: Rakib Hasan <rmhasan@google.com>
Commit-Queue: Luke Z <lpz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818565}

initialized. FuchsiaAudioRenderer was not handling this correctly.
It was trying to call AudioConsumer.BindVolumeControl before the
AudioConsumer is connected. As result it was logging an error
message about disconnected VolumeControl without setting the volume.
Updated SetVolume() implementation to persist the volume value and
send it as soon as AudioConsumer is connected.

AudioRenderer: :SetVolume() may be called before the renderer is
Change-Id: Ic5418c2c002c1181da01e8a278b0b53845baee47
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481958
Auto-Submit: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818564}

If a notification does not need the Settings button and only has one
action button we don't need the overflow menu as it would only have a
single entry. Instead just show the action as the second button in the
notification.

Before: https://imgur.com/SUvMXlW
After: https://imgur.com/QRijUhf

Bug: 1139892
Change-Id: Ia8b95aeffcea95345a9d483d065f818d03584939
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485153
Commit-Queue: Richard Knoll <knollr@chromium.org>
Reviewed-by: Rayan Kanso <rayankans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818563}

No behavioral changes, the code is moved as is, the SyncService and
SyncClient's public API are  temporarily extended to avoid behavioral
changes.

Change-Id: I150423896d413dafdba61e891f55d4164be89440
Bug: 1137346
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476273Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Auto-Submit: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818562}

This assertion can fail because this path is now also accessible if
PAINT_PREVIEW_SHOW_ON_STARTUP flag is enabled.
It was added here: crrev.com/c/2472432

Bug: 1134752
Change-Id: I20d8937b24de77c366a8bf552a68ff787d488959
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485395
Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818561}

For browser settings add the "Subpage button" role description to
<cr-link-row>'s to clarify the button's action to the user.

Fixed: 1012105
Change-Id: Ic5836c656adf119ea3da0ae3d1319ee7e2cafe8f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485036Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Gavin Williams <gavinwill@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818560}

- CustomViewStyleable
- DefaultLocale
- DrawAllocation
- EllipsizeMaxLines
- ExportedContentProvider
- ExportedService
- HandlerLeak
- IconColors
- IconLauncherFormat
- IconLauncherShape
- Instantiatable
- InconsistentLayout
- InflateParams (Permanently skipped)
- InlinedApi (Permanently skipped)
- JobSchedulerService

Bug: 1116130,1081240
Fixed: 1081240
Change-Id: I37dfb048198cbbed198408f74ecce1d0876d6dfc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429808
Commit-Queue: Peter Wen <wnwen@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Natalie Chouinard <chouinard@chromium.org>
Reviewed-by: Eric Orth <ericorth@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Auto-Submit: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818559}

Bug: 1133482
Change-Id: I30d0131ca1eba153d8f2b1ac725dccf4fe7072d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476625Reviewed-by: Filip Gorski <fgorski@chromium.org>
Reviewed-by: Patrick Noland <pnoland@chromium.org>
Commit-Queue: who/bttk <bttk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818558}