- 30 Jul, 2020 40 commits
-
-
Matt Jones authored
tabStateInitialized is another method in the SceneOverlay interface that is only used a single time. Since this method is also easily replaced by an observer, the interface method has been removed in favor of that. Bug: 1100332, 882508 Change-Id: Ifb088320dac2ed2143a67fc46d59a30a8aa7c4b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2326012Reviewed-by:
Mei Liang <meiliang@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#793159}
-
Ewann authored
- Adds a new Context Menu with a "Copy" action for tabs item. - Adds a new empty Context Menu for section header. - Wraps the old implementation with a feature flag check. - Adds metrics for the new context menu and its action. Bug: 1093302 Change-Id: I53d698f5480e201423cf5f28add4c16c2b35b9c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325730Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Cr-Commit-Position: refs/heads/master@{#793158}
-
Avi Drissman authored
Bug: 1105907 Change-Id: I2b7ab8c7671cbd492394d453a14fb47517dbc4d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328340 Auto-Submit: Avi Drissman <avi@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#793157}
-
Ali Juma authored
This CL adds a factory for creating RealTimeLookupService instances on iOS, and uses a RealTimeLookupService with SafeBrowsingUrlCheckerImpl when the kRealTimeLookupEnabled feature is enabled. This means that when this feature is enabled, real-time lookups work on iOS. Change-Id: I7126a4224a20bd9fb45360ba2dc46f5d032f4a10 Bug: 1103220 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317850 Commit-Queue: Ali Juma <ajuma@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#793156}
-
Bence Béky authored
https://quiche.googlesource.com/quiche.git/+log/e5c11c069f53..d782fd9e320e $ git log e5c11c069..d782fd9e3 --date=short --no-merges --format='%ad %ae %s' 2020-07-30 vasilvv Fix a typo in CertificateView that prevented P-256 from working. 2020-07-29 dschinazi Cleanup uses of QUIC version 2020-07-29 renjietang Replace gfe2_reloadable_flag_quic_enable_zero_rtt_for_tls with gfe2_restart_flag_quic_enable_zero_rtt_for_tls_v2 2020-07-29 vasilvv Add support for legacy ECDSA private keys to certificate_view.h 2020-07-29 fayang QUIC client do not send new request if now is close to idle timeout. Only affecting client, not protected. 2020-07-29 fayang In QUIC, add a copt to enable overshooting detection. Protected by gfe2_reloadable_flag_quic_enable_overshooting_detection. 2020-07-29 fayang Make sure MaybeCoalescePacketOfHigherSpace is not re-entrant to avoid infinite loop. Protected by gfe2_reloadable_flag_quic_coalesced_packet_of_higher_space2 which replaces gfe2_reloadable_flag_quic_coalesced_packet_of_higher_space. 2020-07-29 fayang In quic, respect enable_half_rtt_tail_loss_probe_ when using pto. protected by gfe2_reloadable_flag_quic_use_half_rtt_as_first_pto. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: I2e4ce8ba9b1fc158528ae44d2cdf52b9560a57ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329246 Commit-Queue: Renjie Tang <renjietang@chromium.org> Reviewed-by:
Renjie Tang <renjietang@chromium.org> Cr-Commit-Position: refs/heads/master@{#793155}
-
Bailey Berro authored
Currently changes to menuOptions via array mutations do not cause shouldDisableMenu_() to be called again. In particular, this causes and issue with the resolution dropdown for CrOS Display Settings since we rebuild the list of resolutions by assigning an empty array and then calling the 'push' array mutation. Fixed: 1105149 Change-Id: I9e275454254af56ea3aab5f83176a51cd447d0c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327790 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Auto-Submit: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#793154}
-
Bence Béky authored
When moving HTTP2_SESSION_SEND_DATA from SpdySession to SpdyStream at https://crrev.com/c/2309350, I incorrectly changed the event source. This CL fixes it, so that HTTP2_SESSION_SEND_DATA will show up in the HTTP2_SESSION together with HTTP2_SESSION_SEND_HEADERS and HTTP2_SESSION_SEND_GREASED_FRAME. Bug: 1106652 Change-Id: I1ae2776326ac0f680dc4162cea509d779cb09b33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327184 Commit-Queue: Renjie Tang <renjietang@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5ba6534884d9..e393c61a1563 2020-07-30 senorblanco@chromium.org Dawn: update for API changes (Buffer). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: borenet@google.com Change-Id: Id9709806cdb8daac046f355b1243e65fc7493f29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328760Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793152}
-
Balazs Engedy authored
The following test is flaky: FallbackCoordinatorTestCase/testOpeningIncognitoTabsDoNotLeak. Bug: 1111258 Change-Id: I510731574950001de8f6c39440fdd586e94bfc80 TBR: javierrobles@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329590Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#793151}
-
Caitlin Fischer authored
No clickjacking histograms were being logged. Bug: 1110301, b/162309838 Change-Id: I5a63af6068f589375da13c134e5c173adfa757f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323130Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#793150}
-
Mikel Astiz authored
OnPassphraseAccepted() indicates the completion of the asynchronous operation initiated by SetEncryptionPassphrase(), so it's cleanest to notify it last. This is expected to introduce no noticeable behavioral difference but simplifies writing tests. Change-Id: I261c19bcc1b1386234ca878233f34954046297f7 Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328966 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#793149}
-
Dale Curtis authored
This was set to expire soon and per relevant OWNERS is unused. Fixed: 1109828 Change-Id: Id88bb92b7222d19928f4c53a66c9262ec044c5f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324891 Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
-
Matt Jones authored
The only user of the onTitleChanged event was the tablet tab strip which already had access to the TabModelSelector. This patch removes the SceneOverlay method in favor of handling title change events in the feature code. Bug: 1100332, 882508 Change-Id: I022609157f2dd89983f6f9d15ad631783297a949 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324665Reviewed-by:
-
Varun Khaneja authored
Bug: 1089439 Change-Id: Ia5126efe68d3bca2495dd8126536e0693b431ff1 Fixed: 1037227,1109954 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327454 Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Auto-Submit: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#793146}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I34954e8b4b46193f1117ce7833f7547833e3b06d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328757Reviewed-by:
-
Jonathan Ross authored
This reverts commit 4a52a132. Reason for revert: Crashing the GPU process between pixel_tests, about 40% of the runs. crbug.com/1111312 Original change's description: > viz: RGBA_TEXTURE copy requests in SkiaRenderer > > Currently, SkiaRenderer does not support RGBA_TEXTURE > CopyOutputRequests which are used in Chrome OS for screen rotation > animations [1] (among other things). As part of a larger effort to > enable SkiaRenderer on Chrome OS, this CL implements RGBA_TEXTURE > support in SkiaOutputSurfaceImplOnGpu::CopyOutput: > > 1. Refactor SharedImageFactory ownership out of > DirectContextProviderDelegateImpl (used only for the > use_gl_renderer_copier bypass) and directly into > SkiaOutputSurfaceImplOnGpu. > 2. Create a SharedImage and its Skia representation in CopyOutput and > blit the request rect from the source into the output SkSurface. > 3. Send the SharedImage's mailbox back through the CopyOutputResult > with a release callback that destroys the SharedImage. > 4. Enable SKIA_GL tests in cc_unittests. > > [1] https://source.chromium.org/chromium/chromium/src/+/master:ash/rotator/screen_rotation_animator.cc;l=214;drc=b15cb5fd43aff2d181355401d99e47e2e44aa61f?originalUrl=https:%2F%2Fcs.chromium.org%2F > > Bug: 1046788, 971257, 1098435 > Change-Id: I62d41390828ed0c79a1dc29c508efc748924ce06 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302733 > Reviewed-by: Khushal <khushalsagar@chromium.org> > Reviewed-by: Jonathan Backer <backer@chromium.org> > Commit-Queue: Brian Ho <hob@chromium.org> > Cr-Commit-Position: refs/heads/master@{#792971} TBR=backer@chromium.org,dcastagna@chromium.org,khushalsagar@chromium.org,hob@chromium.org Change-Id: I67bc898f661319f387453696cda55076f8b114b6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1046788 Bug: 971257 Bug: 1098435 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329730Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#793144}
-
Mikhail Khokhlov authored
Bug: b/161112814 Change-Id: I45ab822baa0ba5c8f9f52129ece60e337383624e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328968Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Cr-Commit-Position: refs/heads/master@{#793143}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d9705a3ee367..f2d177ab9e84 2020-07-30 janscheffler@chromium.org Migrate `front_end/event_listeners` to `devtools_entrypoint` 2020-07-30 janscheffler@chromium.org Disable flaky e2e test 2020-07-30 janscheffler@chromium.org Disable flaky e2e test 2020-07-30 szuend@chromium.org [cleanup] Re-write 'FrameManager' unit tests using some helper functions If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1101738,chromium:1111255,chromium:1111256 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I5153c4e0dcca9bb00b03dbd477898a43104c6ae7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328756Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I3df2f9ebfae0407eb22b364cd60582b2afcb86c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329046Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a45f583aecc0..d755ba27aab7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I294ae50c2b15e1f58c900c76bdb90c7e7ba12b8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329049Reviewed-by:
-
Balazs Engedy authored
This reverts commit 5528fce5. Reason for revert: Compile failure on: https://ci.chromium.org/p/chromium/builders/ci/win-archive-rel/16199? Original change's description: > Read attachments from introduction > > Reads text and file attachments from introduction frame and appends > them to the share target. > > Bug: 1085068 > Change-Id: I0198a9edcfa5d8c7691514072c50577ff3d72428 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320599 > Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> > Reviewed-by: Alex Chau <alexchau@chromium.org> > Cr-Commit-Position: refs/heads/master@{#793136} TBR=alexchau@chromium.org,himanshujaju@chromium.org Change-Id: I4fbdac65b9e62653068572eaade6b920d949b9df No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1085068 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329591Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/d755ba27aab7..bcdec7d7076c 2020-07-30 treehugger-gerrit@google.com Merge "Diff test for flow event version 2 improved" 2020-07-30 hjd@google.com Merge "ui: Enforce bucket size is at least 1ns" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Idcbdfb4537515dd74a49e416783e96e29fe5094b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328755Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a307488e3859..a45f583aecc0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: If14dd049765d36afc9a298ca171bbb474e85692f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329047Reviewed-by:
-
Himanshu Jaju authored
Reads text and file attachments from introduction frame and appends them to the share target. Bug: 1085068 Change-Id: I0198a9edcfa5d8c7691514072c50577ff3d72428 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320599 Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#793136}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1596095888-824adbe180e90d0db36c843038b46bf769e7f7bb.profdata to chrome-win32-master-1596103202-ae37a5b5255471047baf735b75fad8695ae7df62.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com Change-Id: I1d727b1be204b653f7ba079e0676c00ca71d5642 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328754Reviewed-by:
-
Victor Hugo Vianna Silva authored
The OWNERS file lists tangltom@, who hasn't worked in Chromium for a while. PeopleHandler is mostly used for interacting with Sync through Settings. The CL makes the file co-owned by a member of the Sync team and one of the Sign-in team. Bug: None Change-Id: I5280bf0b85db7950b5e2ba4f336b60580234678b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307231Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
-
Nohemi Fernandez authored
These utilities already exist in Sign-in and should be kept within the codebase owned by the Sign-in team. Bug: 1103274 Change-Id: Idaa5827ca06bbb0b2edcfe603a8d83545de18087 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325174Reviewed-by:
-
Rushan Suleymanov authored
This CL introduces a factory for SyncInvalidationsService and wires it to ProfileSyncService to add listener. The invalidations service is added behind a feature toggle which is disabled by default. Bug: 1082122 Change-Id: I94249979ae4fc17132670fba2d49a7ba50a56bc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220029 Commit-Queue: Rushan Suleymanov <rushans@google.com> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 846c5c16. With Chromium commits locally applied on WPT: 3bd086b0 "Make CSP default-src without 'unsafe-eval' block eval in iframes" 6d63b58a "Split iceGatheringState tests into separate files & update expectations" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Change-Id: I35817b1a541678ae32d7289ade32f4a06f45603c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329244Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793131}
-
Balazs Engedy authored
The file contained redundant entries for virtual/* tests, remove those. Bug: None Change-Id: I2f6ea4a70bfc3d01dae66da251e4b39b0d3ffbab No-Try: True No-Presubmit: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329570Reviewed-by:
-
Mark Brand authored
This change removes the need for the separate response handling in MojoLPM fuzzer targets, instead handling responses to methods called on fuzzer-hosted receivers in the same way as calls to browser-hosted remotes. This also allows more significant reordering of responses on the fuzzer side, hopefully improving fuzzer performance. Bug: 1076336 Change-Id: I6faceedae2bef31ced28c415f84e7e6ca009f458 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302749 Commit-Queue: Mark Brand <markbrand@google.com> Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#793129}
-
Kenichi Ishibashi authored
This became flaky with crrev.com/c/2269982 Bug: 1111240,1091141 Change-Id: Ia79803d740d776022095b881e0ba66f608838103 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328568 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#793128}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/369fe23b..9b215da6 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iddf9e1c766e2f11a0fcd80fb0617327386966318 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329284Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793127}
-
Avi Drissman authored
Bug: 1105907 Change-Id: I32836d2d1bfa0854f32930f0af7f98b1d46118f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328332 Auto-Submit: Avi Drissman <avi@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#793126}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2d37958b2d44..5ba6534884d9 2020-07-30 borenet@google.com Change some instances of whitelist/blacklist If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1101491 Tbr: borenet@google.com Change-Id: I31a59c9b7fb4055dea0c1856677e531da15e4d4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328752Reviewed-by:
-
Balazs Engedy authored
This reverts commit 6549ee05. Reason for revert: Likely culprit for crash/timeout on: MultiDeviceSetupScreenTest.Accepted MultiDeviceSetupScreenTest.Declined MultiDeviceSetupScreenTest.Skipped https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/7383 Original change's description: > MultiDeviceSetupScreen: Skip screen properly. > > Use new MaybeSkip method for skipping screen. Add tests for UMA stats. > > Bug: 1064561, 1095062 > Change-Id: I9ba91dd8b132367a160b975f724b5e1692987832 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166263 > Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org> > Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> > Cr-Commit-Position: refs/heads/master@{#793103} TBR=rsorokin@chromium.org,raleksandrov@google.com Change-Id: Ic190563d2e266731d1fab4684b23adae5f487163 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1064561 Bug: 1095062 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329424Reviewed-by:
-
Balazs Engedy authored
Bug: 1111287 Change-Id: Ia3678f2914e133d0676077ff96bd31de0131907b No-Presubmit: True No-Try: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328972Reviewed-by:
-
Travis Skare authored
Change-Id: Ifce678205ca39d7c53d364f150f92e8332e3b1e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327140 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
-
Antonio Gomes authored
LaCrOS/Chromium project allows one to launch Chromium/Wayland (Ozone) on top of ChromeOS/Exo, with the following commands: chromeos/chrome $ <out-cros>/chrome --enable-logging=stderr \ --user-data-dir=/tmp/chr_cros \ --ozone-platform=x11 --enable-wayland-server \ --wayland-server-socket=wayland-exo chromium/wayland $ WAYLAND_DISPLAY=wayland-exo <out-wayland>/chrome \ --ozone-platform=wayland \ --user-data-dir=~/tmp-- LaCrOS/chromium, then, should be able to open nested 3-dot menu instances, eg -> 3-dot -> More Tools -> Extensions However, today, ChromeOS/Chrome fails a DCHECK when opening a nested submenu (in the example above accomplished by hovering over "More Tools" menu and opening the respective submenu). The DCHECK fails because GetTargetSurfaceForLocatedEvent() - components/exo/shell_surface_util.cc - assumes the outter aura::Window window that originates the event is the same that has the event capture. In case of Exo, each windows (the 3-dot menu window itself and the nested submenu window) are a different top Exo windows: 3-dot menu window hierarchy (it originates the hover event): ExoShellSurface-7<-1> bounds=428,76 348x492 ExoShellSurfaceHost-7<-1> bounds=0,0 348x492 ExoSurface-11<-1> bounds=0,0 348x492 Submenu window hierarchy (it captures mouse events once created): ExoShellSurface-8<-1> bounds=104,168 328x111 ExoShellSurfaceHost-8<-1> bounds=0,0 328x111 ExoSurface-12<-1> bounds=0,0 328x111 The CL removes the DCHECK altogether, given that it does not reflect anymore the world where LaCrOS/Chromium can be launched on top of Exo within ChromeOS/Chrome. BUG=1110881 R=dcastagna@chromium.org Change-Id: I85629514dfcf3db8617d7b29d93d9f73c347efe9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2326870 Commit-Queue: Antonio Gomes (GMT-4) <tonikitoo@igalia.com> Reviewed-by:Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#793121}
-
Sami Kyostila authored
This patch extends the Android battery drain metric to record a parallel discharge rate which is only reported for time intervals where Chrome was the only foreground app. This avoids accidentally attributing power draw from other apps that were running before the user switched to Chrome. We also add a metric to track the time durations between successive detected battery capacity drops to get a better idea of what the granularity of this data is. Bug: b/161693081 Change-Id: Ic5e71799333c4db188ab43a1f23200e84a027884 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2322986 Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
-
