- 28 May, 2020 9 commits
-
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: If0eb3cf6c9a7c659b00269b77edf93116aa29990 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219230Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#772478}
-
Kurt Catti-Schmidt authored
Per https://chromium-review.googlesource.com/c/chromium/src/+/2163429, this change moves GridNG files to their own directory. This will help organize subsequent changes where we will be introducing classes specific to GridNG. There should be no behavioral changes associated with this PR. Bug: 1045599 Change-Id: I50c2c98a7903904bf80663801a80ed1874bb0f1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218616 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#772477}
-
Zach Trudo authored
Bug: b/157188195 Change-Id: I70b45ca1dc44f48d08638b9f23a4eaaae73052b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212796 Commit-Queue: Satoru Takabayashi <satorux@chromium.org> Auto-Submit: Zach Trudo <zatrudo@google.com> Reviewed-by:
Satoru Takabayashi <satorux@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#772476}
-
Xianzhu Wang authored
I changed the filter in crrev.com/c/2202974 to treat results like [ Failure Crash ] as unexpected flaky if the expectation is like [ Failure Timeout ], but it had a bug that containsAll couldn't deal with the differences of the failure keys in actual and expected result (e.g. actual TEXT vs expected FAILURE). Change-Id: Iacd547a242277ad8b39645a2c2130c1d8670bf72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218530Reviewed-by:
Aleks Totic <atotic@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#772475}
-
Yuichiro Hanada authored
This CL lets InputMethodEngine choose the InputMethodKeyboardController instance. It allows us to use different InputMethodKeyboardControllers for ARC IMEs and Chrome OS IMEs. Bug: 1060272 Change-Id: I5677a58429ef2ced5343b8cb3c34dca929f276a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214733Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#772474}
-
Haoyue Wang authored
https://quiche.googlesource.com/quiche.git/+log/517beaa4782d..05c3b7867dfb $ git log 517beaa47..05c3b7867 --date=short --no-merges --format='%ad %ae %s' 2020-05-27 wub Update quicunorderedmap to quichashmap in quicdispatcher, transportparameters, quicspdysession and qpackblockingmanager. no behavior change. 2020-05-26 renjietang Remove ALL_UNACKED_RETRANSMISSION from TransmissionType because it's not used anymore. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: Ic854b26c758919f06dfa9312be523686ceab724e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219090Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Haoyue Wang <haoyuewang@chromium.org> Auto-Submit: Haoyue Wang <haoyuewang@chromium.org> Cr-Commit-Position: refs/heads/master@{#772473}
-
Sharon Yang authored
Change-Id: I3fd006f9e87c8bdfb8007d9c06d2778b0edce539 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155183 Commit-Queue: Sharon Yang <yangsharon@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#772472}
-
Chris Harrelson authored
The use counters removed in this CL are deprecated since issue 785212 was fixed. Bug: 785212 Change-Id: I52f41cac65e7e5edb171237c4a683fbe78920bd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202788Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#772471}
-
Alexey Baskakov authored
Multiple test fixtures set the TestAppRegistrar explicitly via TestWebAppProvider::SetRegistrar() and TestAppRegistrar is a type unrelated to WebAppRegistrar. Later we will get rid of TestAppRegistrar everywhere: that is a third type of registry (in addition to BookmarkApps and WebApps). Replacing it with TestWebAppRegistryController is a separate follow up task. Bug: 1082881 Change-Id: I7d59f10360f766fccbc888b8c461aefe27b0cdde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215078 Auto-Submit: Alexey Baskakov <loyso@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#772470}
-
- 27 May, 2020 31 commits
-
-
Gabriel Charette authored
Same as in ScheduleWork() (reset the state on unexpected failure). R=fdoray@chromium.org Bug: 1074019 Change-Id: Ia4e04126d1cc879b369638b93f63b7397bc1e14b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216033Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#772469}
-
Peter Kotwicz authored
This CL: - Modifies CustomTabAppMenuPropertiesDelegateto enable adding site to homescreen when WebAPK is out of scope - Introduces EmptyVerifier and uses it for custom tabs - Deletes ExternalIntentsPolicyProviderin favour of accessing verifier directly - Moves trustedwebactivityui.controller.Verifier ot ui.controller.Verifier BUG=1083256 Change-Id: Ic0c1c98ccb3ccef2b71019b3da544c34488477b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2205519 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Glenn Hartmann <hartmanng@chromium.org> Cr-Commit-Position: refs/heads/master@{#772468}
-
Becca Hughes authored
We want to check the feed URL against Safe Search (which is in MediaFeedsService) on discovery so first we need to move discovery to MediaFeedsService. BUG=1085095 Change-Id: I12511d9cb8ce3afb095abea50a50c59a1773fdbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211046 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#772467}
-
Christian Biesinger authored
As requested in https://crrev.com/c/2212984 Bug: 1083020 Change-Id: I989fd01823a6fdb01e60f4f5d6d3ef0d85f3f693 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218797Reviewed-by:
-
Kyle Horimoto authored
This class adds metadata regarding whether the section contains only a link to a subpage. Additionally, this CL moves section result generation to a public function on this class. Bug: 1082249, 1071700 Change-Id: Ib191d6a2636adf102d0cd4fde5c1fd298a220e17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219154Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#772465}
-
Ben Kelly authored
Bug: 1018920 Change-Id: Ia4d148502279e768756eb07a9aad2384c190f50e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218671Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#772464}
-
Ramin Halavati authored
Profile API is being updated (issue 1033903) and the usage of GetOffTheRecordProfile and HasOffTheRecordProfile without argument is getting deprecated. Use cases of this call that ONLY refer to incognito or guest mode can use [Get/Has]PrimaryOTRProfile() instead. c/b/net tests are updated to use the new API, and a test is expanded to cover non-primary OTRs. Bug: 1060940 Change-Id: I7962466b337c053c912a617e827af8008639fb69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211345 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
-
Peter Kotwicz authored
This CL restores recording SOURCE_EXTERNAL_INTENT_FROM_CHROME enum value in in the Launch.HomeScreenSource UMA metric by propagating the android.provider.Browser intent extra from WebappLauncherActivity to WebappActivity. This fixes a regression caused by https://chromium-review.googlesource.com/c/chromium/src/+/2180856 BUG=1086846 Change-Id: I0e2817536565442d910626a8f032c4a4caf2c66c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217378Reviewed-by:
-
James Cook authored
UserImageManagerTest.SaveUserImageFromProfileImage was using signin::SetRefreshTokenForPrimaryAccount(), which assumes there is a "sync consented" primary account. SplitSettingsSync does not set a sync-consented account until the user goes through the sync consent screen. This test doesn't care about sync consent, so change it to use SetRefreshTokenForAccount(). This avoids a DCHECK failure when SplitSettingsSync is enabled. Bug: 1060289 Change-Id: I7c2b262707ea04c7a23f374680bcffa1eb876104 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218804 Commit-Queue: James Cook <jamescook@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#772461}
-
Carlos Frias authored
This is part 1 of 3 of the prototype to configure PWAS to run on OS login. Updates for the prototype include: - Added feature flag "Desktop PWAs run on OS login", disabled by default. - Added Startup folder to Windows base paths and shell util. - Added "in_startup" entry to Web App Shortcut locations. - If feature flag is enabled, show a checkbox in the PWA install dialog. - If checked, PWA install task creates an additional shortcut in Windows Startup folder by setting "in_startup" location to true. Additional parts for the feature to come in next CLs. Explainer: https://github.com/MicrosoftEdge/MSEdgeExplainers/blob/master/RunOnLogin/Explainer.md I2P: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/T6d2zqF_jpw/76TP7Bc2DwAJ Bug: 897302 Change-Id: I0870e5a26e94e8e60001b78c95e53da134388f0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026256 Commit-Queue: Carlos Frias <carlos.frias@microsoft.com> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#772460}
-
Mike Wittman authored
Frames in the Chrome module must be unwound exclusively by ChromeUnwinderAndroid because the module doesn't provide native unwind information. Pass the module base address to NativeUnwinderAndroid to support this. Bug: 1004855 Change-Id: Idd089a7e7ad4989923448fb3d5c1b21bf6fd9b84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209246 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#772459}
-
Gabriel Charette authored
Note to QA: This CL is purely mechanical and shouldn't be blamed for future regressions on touched files. This is a follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/2211138 which already removed all usage using content::BrowserThread. Hence this script now matches unqualified BrowserThread:: without risking having "content::" be selected as "traits_before" by the regex (ran on same revision as step #1). content:: is now always added if outside namespace content {} (deleting unused using content::BrowserThread; decls) Script @ https://crbug.com/1026641#c92 (will TBR fdoray@ post-review for mechanical change) TBR=fdoray@hchromium.org AX-Relnotes: n/a. Bug: 1026641 Change-Id: I51ae2f83eb17d19b54563fd9b4fc040d2aa0c948 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212469 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
-
Clark DuVall authored
The autofill popup was not taking the top bar into account when positioning near target input. This change creates a new view that will be offset by the current top bar height, and uses that view as the autofill container. Bug: 1085294 Change-Id: I6bc8ce5dbeae2a00f16a9c01d39c5a8bee7e8d2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218704Reviewed-by:
-
Peter Kotwicz authored
This CL changes the "Can't connect to site" splash screen WebAPK dialog to show for only the net errors which trigger the dino game interstitial: 1) ERR_NAME_NOT_RESOLVED (the net error which precedes DNS_PROBE_FINISHED_NO_INTERNET) 2) ERR_INTERNET_DISCONNECTED BUG=1086785 Change-Id: Ia8de9fd4a69f9fb254b2a085e5100981f7af4d29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217200Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3c1f483205d2..aefd51fe93a8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC lgrey@google.com,dbertoni@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1044639,chromium:1047629,chromium:1069077,chromium:1069094,chromium:1073377,chromium:1083498 Tbr: lgrey@google.com,dbertoni@google.com Change-Id: I54c47807a59f6f903b2b3512cb89d30861ebe5e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218649Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#772455}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7135239769de..4348097fd4be 2020-05-27 reed@google.com tell gms when they are being run in viewer 2020-05-27 csmartdalton@google.com Bump default GrResourceCache size to 256MB 2020-05-27 ethannicholas@google.com Revert "Store float value for SkSL settings" 2020-05-27 ethannicholas@google.com Reland "Revert "SkSL function inlining"" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC westont@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: westont@google.com Change-Id: Ia24e35c360adca61dc5de4ea1dccbb6fbf168270 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218895Reviewed-by:
-
Gabriel Charette authored
R=rockot@google.com Bug: 1026641 Change-Id: Id9e75f1959687ff9cae1fe92e2923f7f38eff8ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219152 Commit-Queue: Gabriel Charette <gab@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#772453}
-
Jinsuk Kim authored
This CL temporarily suppresses contextual search while any BottomSheet feature is open. RootUiCoordinator looks over ContextualSearchManager and BottomSheetController to coordinate the suppression. Bug: 1083396, 1077042 Change-Id: I5fa385a12105fb510a1a59d07148a6b1c5ef71fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206562Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#772452}
-
Christian Biesinger authored
This is for legacy as well as NG. Bug: 1083009 Change-Id: I8c11aca1d5dc03932d437f60c0d56960c28709eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208010 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
-
Hitoshi Yoshida authored
This CL replaces some foo() and hasFoo() with fooNonNull() and hasFooNonNull(), where it will be compile failure on IDL compiler migration. Bug: 839389 Change-Id: I4b51fe335af0c2555c702b03f0609d71d231b296 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213655 Auto-Submit: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#772450}
-
François Degros authored
There is no valid implementation yet that can zip files if we don't have NaCl. BUG=912236 TEST=browser_tests --gtest_filter="ZipFiles/*" Change-Id: I560dbc85982f8768c22580155eed8d08e2353809 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215384Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: François Degros <fdegros@chromium.org> Cr-Commit-Position: refs/heads/master@{#772449}
-
cfredric authored
This cl computes digests of the underlying bytes of canvas images when HTMLCanvasElement.toBlob, HTMLCanvasElement.ToDataURL, or HTMLCanvasElement.convertToBlob are called. OffscreenCanvas.convertToBlob is not recorded yet, since we do not yet have a UKM source or Recorder in that context. CanvasRenderingContext2D.getImageData and WebGLRenderingContext.readPixels are also not recorded yet. Bug: 973801 Change-Id: Ic2de567b16c98b613c945afa823a078a4740a7a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207979 Commit-Queue: Chris Fredrickson <cfredric@google.com> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#772448}
-
Alex Gough authored
Adds service_sandbox_type.h header for components to consume and uses it to supply sandbox type for PaintPreviewCompositorCollection. Prelude to removal of WithSandboxType API. See linked bug for rationale. Does not change behavior. Tests: browser_tests PaintPreviewCompositorBrowserTest.* Bug: 1065087 Change-Id: Ie7e13e884df5c59edc850b3546d6d9b655102f79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202663Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Matthew Denton <mpdenton@chromium.org> Cr-Commit-Position: refs/heads/master@{#772447}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/ca092f016532..f5dace0f1e57 2020-05-27 timvp@google.com Vulkan: Increase GLES support to 3.1 2020-05-27 jonahr@google.com GL: Support GL_OES_texture_cube_map_array in shader translator 2020-05-27 jonahr@google.com GL: Support GL_OES_texture_cube_map_array in frontend/GL backend 2020-05-27 ianelliott@google.com Vulkan: Rotate gl_FragCoord for Android pre-rotation 2020-05-27 nguyenmh@google.com Store non-string, non-enum data in binary file. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Test: Test: CQ Change-Id: I0f8d63f1d74d282923105e07439a18177a48a11a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218741Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0c7d654c7474..cdaf0be1f4ce 2020-05-27 zhin@chromium.org Add git completion helper to cl upload If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I9fc6a7eda3673488fe8f01e6411c52b8776b2679 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218952Reviewed-by:
-
Robert Kroeger authored
On Mac Asan, conformance2/textures/webgl_canvas/tex-3d-rgb8ui-rgb_integer-unsigned_byte.html started failing. Suppress the test. TBR=kbr@chromium.org Bug: 1087083 Change-Id: I0ece6b3d187199308e3c486f7bf927b07c59cdbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219030Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Robert Kroeger <rjkroege@chromium.org> Auto-Submit: Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#772444}
-
Dominic Mazzoni authored
In response to an accessibility action to change the value of a slider, we fire a DOM event. However, firing that DOM event can result in arbitrary user code being called, which can mean detaching the current AXObject, leading to a crash/UAF. Fix this by checking after firing a DOM event. Bug: 1079445 Change-Id: Ic16b9a5312a14e57bc56a9c8124ffe64d1b69f65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211930 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Meredith Lane <meredithl@chromium.org> Cr-Commit-Position: refs/heads/master@{#772443}
-
Rahul Singh authored
In the initial CL for Shortcuts Menu (https://crrev.com/c/2146212), we used the WebAppIconManager::WriteData method to write both app icon and shortcut icon data to disk. App icons are for the web app as a whole. Shortcut icons on the other hand, are specified for a shortcut in the web app manifest's shortcuts member array. So, in the interest of code readability and debuggability we should write these to disk separately. With this in mind, I left a TODO in the initial CL to create separate methods for writing these 2 different kinds of icon data to disk. This CL addresses that TODO. It adds a separate WebAppIconManager::WriteShortcutIconsData method. It also reverts WebAppIconManager::WriteData to only write app icon specific data. Additionally, it updates existing unittests to work with the refactored code and adds new tests for reading and writing shortcut icon data. Finally, it renames occurrences of *ShortcutIcon*/*shortcut_icon* to *ShortcutsMenuIcon*/*shortcuts_menu_icon*. Bug: 1069308 Change-Id: I530b3af75277f1d6c5f2b0ed6a67ce469bba7fed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204972 Commit-Queue: Rahul Singh <rahsin@microsoft.com> Reviewed-by:
-
Rahul Singh authored
the app's launch url This CL fixes an issue where clicking an item in a PWA's shortcuts menu always navigates to the PWA's start_url. To fix this, it adds a new command line switch. When registering the shortcuts menu with the OS, it uses this switch to pass the shortcut url as a command line argument. In WebAppLaunchManager, when kDesktopPWAsAppIconShortcutsMenu is enabled, it sets AppLaunchParams' override_url member to the switch's value i.e. the shortcut url. Note: The shortcut url that the switch is set to in the shortcuts menu registration code has the same origin as the app's start_url. This is validated as part of web app manifest parsing. I verified that this fix works with Extensions based as well as WebApp based PWAs. Bug: 955497 Change-Id: Ib6360b16fe976e7e498bd783cf44911fe8c75b7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213344 Commit-Queue: Rahul Singh <rahsin@microsoft.com> Reviewed-by:
David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
-
Abhijeet Singh authored
QuickAnswersView never gets added as a pre-target handler, so call to RemovePreTargetHandler in ~QuickAnswersView() is extraneous and is thus removed. Bug: b:150475423 Test: Tested on Chrome OS VM. Change-Id: Id1246e27d626daa4a6da5bb32d9b1c471c410c1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216531 Commit-Queue: Abhijeet Singh <siabhijeet@google.com> Reviewed-by:
David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#772440}
-
Alex Chau authored
- Adding missing = 0 to NearbyConnectionsManager abstract methods Bug: 1087054 Change-Id: Id7386ea9c8a4f3d77cac2111142990e15592deeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218054 Commit-Queue: Alex Chau <alexchau@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Auto-Submit: Alex Chau <alexchau@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#772439}
-
