- 08 Jan, 2021 5 commits
-
-
John Abd-El-Malek authored
Match Chrome by using metrics::GetVersionString() as the version string which includes an identifier when it's 64 bit, which is what the server looks for. Bug: 1145272 Change-Id: Ifbbe227fc8e0713d467de9f65a0f7c098ca8c98a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606662 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#841263}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5ff758df67da..070ef598892a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Id82cc3d5294d2b44ee96568ae6ed032f0f2987a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615926Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841262}
-
David Bienvenu authored
Change-Id: Ieef05cd0f51ed2d3db650cdd3b82e029495bf7a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615983 Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
Jesse McKenna <jessemckenna@google.com> Cr-Commit-Position: refs/heads/master@{#841261}
-
Sebastien Marchand authored
This function is only used from some code behind a similar ifdef, so it results in some unused function warnings if we don't also ifdef this function. See https://ci.chromium.org/ui/p/chrome/builders/official/win-clang/2092/overview for an example of how this fails: ../../base/allocator/allocator_shim_default_dispatch_to_partition_alloc.cc(120,6): error: unused function 'IsRunning32bitEmulatedOnArm64' [-Werror,-Wunused-function] bool IsRunning32bitEmulatedOnArm64() { ^ Bug: 1121427 Change-Id: I14ff07fce431fd4aa52fd197c59d70df0237ad20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615327Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#841260}
-
Meredith Lane authored
This patch has no functional difference, it is just a refactor. AX-Relnotes: N/A Bug: 1068668 Change-Id: Iedaefa7d8b06ac80d7155739e134978bdb674d29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577389 Commit-Queue: Meredith Lane <meredithl@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#841259}
-
- 07 Jan, 2021 35 commits
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d60c919fc866..57e353f840ef 2021-01-07 brianosman@google.com Remove error reporter from SkSLVMGenerator 2021-01-07 mtklein@google.com back to exactCompare, fixed 2021-01-07 jlavrova@google.com RTL run broken by text styles crashes SkParagraph 2021-01-07 johnstiles@google.com Add unit test for invalid tokens in input stream. 2021-01-07 johnstiles@google.com Constant-propagate the ! prefix onto constant boolean expressions. 2021-01-07 jsimmons@google.com Cache ICU break iterators in SkUnicode_icu 2021-01-07 mtklein@google.com support generalized HLG 2021-01-07 mtklein@google.com add operator/= for skvm::F32 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC johnstiles@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1144260 Tbr: johnstiles@google.com Change-Id: I496c7129d9167d704f057708bf01218514cfec01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616438Reviewed-by:
-
dpapad authored
These made sense in a pre-JS module world. Now that PDF viewer uses JS modules, they can simply be defined within the scope of the module to become truly private, as opposed to only be private from Closure Compiler's perspective. Bug: None Change-Id: If3073e38263890e04e6d6e7937ba68959c396d8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615671 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#841257}
-
Yuke Liao authored
This CL supports running lacros tast tests in build/chromeos/test_runner.py, and the main motivation is to run lacros tast tests on Chromium CI. Bug: 1158590 Change-Id: I8c63c57b95aee5b4c75a4e4561d4afda9d9f3432 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605239 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#841256}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/071cf0cff810..937395c1ed5d 2021-01-07 caramelli.devel@gmail.com Add Direct-to-Display support using KMS/DRM If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I8777ec997e3e1652cc300b9ea492b5f98d5e46d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616244Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7a13b94a1d4c..a0e863bd2219 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC cmumford@google.com,tmartino@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1041619,chromium:1099017,chromium:1150547,chromium:1150968 Tbr: cmumford@google.com,tmartino@google.com Change-Id: I01f4e41c117cd089c00449a74f8222a7ca339d46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616439Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841254}
-
Callistus authored
This is required so that we can record the time taken to initialize the search index within the app. Bug: b/170162419 Change-Id: Ie629239bcdd8490d60f1a788b93224af4e7ab112 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612312Reviewed-by:
dstockwell <dstockwell@google.com> Commit-Queue: Callistus Tan <callistus@google.com> Cr-Commit-Position: refs/heads/master@{#841253}
-
Nicholas Verne authored
Bug: 1160805 Change-Id: Ic2a83036bf8aa29f01f500c488008ddc78e03c15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612232 Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Auto-Submit: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#841252}
-
Mike Taylor authored
For the history books, here's a mapping between the old ported tests and the new tests, where test=N roughly corresponds to a string name or value: in wpt/cookies/name/name.html name0001 through name0016, name0019, name0020 => the for of block with the description "`Name is set as expected for ${name}=test`" name0017 => test=2 name0018 => test=3 name0021 => test=5 name0022 => test=4 name0023 => test=6 name0024 => test=7 name0025 => test=2b name0026. Not ported. This is covered already. A lot. name0028 => test2c name0029 => test with name "Ignore cookie with empty name and empty value" name0030 => test=8 name0031 => test=9 name0032 => "test\"10 name0033 => test=11 in wpt/cookies/value/value.html name0027 => test=15 value0001 => test=16 value0002 => test=17 value0003 => test=18 value0004 => test=19 value0005 => test="20=20" value0006 => test=21 Bug: 1159861 Change-Id: Ica8879a906f13b1464661af8bf1c5f5271a8f54f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615668 Commit-Queue: Mike Taylor <miketaylr@chromium.org> Auto-Submit: Mike Taylor <miketaylr@chromium.org> Reviewed-by:Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#841251}
-
Victor Vasiliev authored
https://quiche.googlesource.com/quiche.git/+log/528c36b3cfd0..63bdfe586f8c $ git log 528c36b3c..63bdfe586 --date=short --no-merges --format='%ad %ae %s' 2020-12-30 quiche-dev Project import generated by Copybara. 2020-12-29 quiche-dev Project import generated by Copybara. Created with: roll-dep src/net/third_party/quiche/src Change-Id: Ic1f5018507595da795dbf8c0cc94fafdf1ea0c9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602891Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Cr-Commit-Position: refs/heads/master@{#841250}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1610009713-66490881217dda72de1fa905fa3f863deeda7cfb.profdata to chrome-win32-master-1610042255-6162d74e2be35377f4b6bbd9ca05127a363b0c50.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I3e4c71929a0065f48de2ba4cf3baa10b6157f46e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616358Reviewed-by:
-
Greg Guterman authored
This CL implements gn based unittest filtering. The files in the rts_exclude_file are manually selected for this example, but will later be populated using the smart logic in rts-chromium. These two cases (source_set and test template) cover most of the test files. I haven't seen any other templates with unittests, but even if there are some this would be a great start. This also doesn't cover webtests, but I think there's enough exclusion power here to save a lot of compute. This also adds a linux-rts builder to the mb config to prepare the experimental builder. Bug: 1145216 Change-Id: I7343249f3df0739e39cfe351e5714d7978059d86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551276 Commit-Queue: Gregory Guterman <guterman@google.com> Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Cr-Commit-Position: refs/heads/master@{#841248}
-
David Tseng authored
Besides the mechanical changes: - moved all STS unit tests to extension browser tests. ES6 module support is unavailable in v8_unittests.cc; after a non-trivial investigation time, it is not easily done. d8 shell and Blink have divergent complex implementations for static/dynamic imports as V8 embedders. - fixed some issues with SentenceUtilsUnittests, which surprisingly passed with bad test data. - converted all unit tests to use SYNC_TEST_F (required to mix in sync tests with the async runner). R=dmazzoni@chromium.org Test: existing tests Change-Id: Idf493f605959331518b88949c8141b521e9100c3 AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613726Reviewed-by:
Josiah Krutz <josiahk@google.com> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#841247}
-
John Abd-El-Malek authored
Add Navigation.disableNetworkErrorAutoReload so that embedders can disable auto reload for user initiated navigations like back/forward. Bug: 1163455 Change-Id: I9ff1b6199493d53457d9fc0be6e9200e60974567 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613353Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#841246}
-
Gordon Seto authored
Update cellular_networks_list to install pending eSIM profiles when their install button is clicked. Screenshot: https://screenshot.googleplex.com/72v5bZue5QTqeoA.png Bug: 1093185 Change-Id: I36f9f51c66bdfde369060a3ea33d3c35416bc51d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605399Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Commit-Queue: Gordon Seto <gordonseto@google.com> Cr-Commit-Position: refs/heads/master@{#841245}
-
Yuri Wiitala authored
This clarifies, and better documents the side effects of using the WebContents capture notification APIs. This is a follow-up task from a recent post-mortem discussion. Bug: 1144868 Change-Id: I1a55025df42e85578b7d6200e1b38a151157ab6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611912 Commit-Queue: Yuri Wiitala <miu@chromium.org> Reviewed-by:
Collin Baker <collinbaker@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Auto-Submit: Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#841244}
-
Basia Zimirska authored
Bug: 1099438 Change-Id: I30fe2f19eb721b7de1eba4ce17d8c2d0c7e52bf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605416 Commit-Queue: Basia Zimirska <basiaz@google.com> Reviewed-by:
Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#841243}
-
chrome://crashesIan Barkley-Yeung authored
Ensure that JavaScript error reports are added to chrome://crashes when running on Linux. NOTE: This only works on Breakpad at the moment. The Crashpad database doesn't allow Chrome to add entries to the database. BUG=chromium:1162356,chromium:1121816 Change-Id: If89f56526b0b1f6c2c33c399b37d4c14cf1d0756 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613927Reviewed-by:
Miriam Zimmerman <mutexlox@chromium.org> Commit-Queue: Ian Barkley-Yeung <iby@chromium.org> Cr-Commit-Position: refs/heads/master@{#841242}
-
Scott Lee authored
https://crrev.com/c/2570155 added the experiment flag for launching local gtests with ResultDB. This CL sets the flag to enable ResultDB on FYI at 30%. Bug: 1084332 Change-Id: I530ce7f74599f2dce5b52ff381778a11d35da368 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582809 Commit-Queue: Scott Lee <ddoman@chromium.org> Reviewed-by:
Chan Li <chanli@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#841241}
-
Sean Kau authored
The bug for which this was created, crbug.com/987869 has long since been resolved and the data is no longer needed. Bug: 1097842 Change-Id: Ide732ce6bcd412a8fc77672b9194c8052252edc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587549 Auto-Submit: Sean Kau <skau@chromium.org> Commit-Queue: Luum Habtemariam <luum@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Luum Habtemariam <luum@chromium.org> Cr-Commit-Position: refs/heads/master@{#841240}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5ff758df67da..070ef598892a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I16938a18c0de79dada64233b9a4572f8e47cfe6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615312Reviewed-by:
-
Lucas Berthou authored
Change expiration date of histograms: Media.VAJDA.ResponseToClient Change-Id: I8d0194bb5988012e4d7027509c2a3e83a03ed2f5 Fixed: 1050661 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613824 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
-
Daniel Libby authored
crrev.com/c/2567866 changed the coordinate system of of HitTestResult's LocalPoint so that it is container, not content. LayoutText::PositionForPoint needs to take this into account as well. This didn't show up as an issue until crrev.com/c/2584855 landed since NGPhysicalBoxFragment::PositionForPoint already takes this into account. Given that LayoutNGFullPositionForPointEnabled may not be enabled for M89, we'll need a fix for current behavior on ToT. Bug: 1162596 Change-Id: I401ab0dc7dea075e346ecac5f7aa81b705b1cecb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607679 Commit-Queue: Daniel Libby <dlibby@microsoft.com> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#841237}
-
David Benjamin authored
I don't have a machine to run the benchmarks on, but for comparison, on a Pixel 2, the assembly improves AES-128-GCM performance from 35 MB/s to 1072.5 MB/s. (AES is obnoxious. It's really hard to implement in constant-time in software, but if you use dedicated AES instructions, you get dedicated silicon for it.) Apple's ARM64 calling conventions are the same between macOS and iOS, so we should be able to use the same files. For reviewer: To test, confirm on an ARM Mac that boringssl_crypto_tests and boringssl_ssl_tests pass. You can also run crypto_unittests and net_unittests if you feel like it. To confirm the perf improvement, patch in https://chromium-review.googlesource.com/c/chromium/src/+/2595253 (if it hasn't landed yet), build boringssl_tool and compare speeds for various operations. Benchmarks to try, largely in decreasing expected benefit. # This will switch from a fairly slow software implementation # to dedicated CPU instructions and should see a dramatic # improvement. boringssl_tool speed -filter AES-128-GCM # These will pick up dedicated CPU instructions. boringssl_tool speed -filter SHA-1 boringssl_tool speed -filter SHA-256 # This will pick up some SIMD optimizations. boringssl_tool speed -filter ChaCha20-Poly1305 boringssl_tool speed -filter SHA-512 # This will pick up some optimized assembly for Montgomery reduction. boringssl_tool speed -filter RSA See CL for benchmarks from thakis. Some highlights: Before: Did 8591 AES-128-GCM (16384 bytes) seal operations in 1040540us (8256.3 ops/sec): 135.3 MB/s Did 58000 SHA-1 (16384 bytes) operations in 1001711us (57900.9 ops/sec): 948.6 MB/s Did 21000 SHA-256 (16384 bytes) operations in 1008911us (20814.5 ops/sec): 341.0 MB/s Did 35000 SHA-512 (16384 bytes) operations in 1024153us (34174.6 ops/sec): 559.9 MB/s Did 29000 ChaCha20-Poly1305 (16384 bytes) seal operations in 1015541us (28556.2 ops/sec): 467.9 MB/s Did 902 RSA 2048 signing operations in 1010769us (892.4 ops/sec) Did 41000 RSA 2048 verify (same key) operations in 1017036us (40313.2 ops/sec) Did 31000 RSA 2048 verify (fresh key) operations in 1000641us (30980.1 ops/sec) After: Did 194000 AES-128-GCM (16384 bytes) seal operations in 1002938us (193431.7 ops/sec): 3169.2 MB/s Did 147000 SHA-1 (16384 bytes) operations in 1004933us (146278.4 ops/sec): 2396.6 MB/s Did 149000 SHA-256 (16384 bytes) operations in 1001852us (148724.6 ops/sec): 2436.7 MB/s Did 38000 SHA-512 (16384 bytes) operations in 1017680us (37339.8 ops/sec): 611.8 MB/s Did 62000 ChaCha20-Poly1305 (16384 bytes) seal operations in 1003024us (61813.1 ops/sec): 1012.7 MB/s Did 1632 RSA 2048 signing operations in 1012696us (1611.5 ops/sec) Did 79000 RSA 2048 verify (same key) operations in 1011790us (78079.4 ops/sec) Did 50000 RSA 2048 verify (fresh key) operations in 1018441us (49094.6 ops/sec) Bug: none Change-Id: Id4eea23c0babd1a3d361497a7f4110cc342d0af2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595350 Commit-Queue: David Benjamin <davidben@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#841236}
-
Eugene But authored
These histograms are useful for monitoring user-visible renderer crashes on iOS. Might be useful on other platforms as well. Bug: 1089568, 1089567 Change-Id: I40d38b162fccc356d3373f2e16d491e6bf29725f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615719 Auto-Submit: Eugene But <eugenebut@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#841235}
-
Tommy Li authored
This reverts commit ecae40df. Reason for revert: Seems to break some user's Default Search Engines who have (or have had) extensions that have changed the Default Search Engine in the past. See thread on Omnibox Team. Original change's description: > [search_engines] Reset keywords of replaceable "example.com_" engines > > This CL collapses entries that with previously uniquified keywords, i.e. > "example.com_" and resets their keywords from their URL, which should > be regenerated as "example.com". > > All safe_for_autoreplace() engines are either prepopulated or generated > as the user browses, so they should all have keywords of the form > "example.com" (they should all look like hostnames). > > If they end in an underscore, it's because we tried to uniquify it in > the past, and it's leftover in the database. > > Engines that the user manually edited would no longer be marked as > safe_for_autoreplace(), so we are only talking about prepopulated or > autogenerated engines. > > By resetting the keyword from the URL, we will set it up to be > eligible for automatic de-duplication with other "example.com" > replaceable engines. > > The full design is in: > go/chrome-search-engines-2020-improvements > > Bug: 1022775 > Change-Id: I2763b6d7371aa266c1d8d720725876bf3107b6a3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598005 > Commit-Queue: Tommy Li <tommycli@chromium.org> > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Cr-Commit-Position: refs/heads/master@{#840267} TBR=pkasting@chromium.org,tommycli@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1022775, 1164024, 1163453 Change-Id: Idfd2b976de8a34fb47b5fbf91a83e2d7532abc23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615925Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Orin Jaworski <orinj@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#841234}
-
Ken Rockot authored
Straightforward migration of HID web tests from old to new Mojo JS bindings using ES6 modules. Bug: 1004256 Change-Id: I50111b23a3c9187dacfcf40887e5db72457b2719 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611338 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#841233}
-
Etienne Bergeron authored
This CL is delaying the WM_TIMECHANGE notifications to ensure it's running while the computer is fully resumed from power suspend. It is also batching multiple concurrent notifications if they subsequent notifications occurred before the completion of the initial one. note: The thread controller already handle delayed tasks and power management by not posting delayed task while computer is in power suspended state. Jank stackframe: tzset_nolock tzset icu_68::TimeZone::detectHostTimeZone() device::TimeZoneMonitor::DetectHostTimeZoneFromIcu() device::TimeZoneMonitorWin::OnWndProc(HWND__ *,unsigned int,unsigned __int64,__int64) gfx::SingletonHwnd::ProcessWindowMessage(HWND__ *,unsigned int,unsigned __int64,__int64,__int64 &,unsigned long) gfx::WindowImpl::OnWndProc(unsigned int,unsigned __int64,__int64) gfx::WindowImpl::WndProc(HWND__ *,unsigned int,unsigned __int64,__int64) base::win::WrappedWindowProc<&gfx::WindowImpl::WndProc(HWND__ *,unsigned int,unsigned __int64,__int64)>(HWND__ *,unsigned int,unsigned __int64,__int64) UserCallWinProcCheckWow DispatchMessageWorker base::MessagePumpForUI::ProcessMessageHelper(tagMSG const &) base::MessagePumpForUI::ProcessNextWindowsMessage() base::MessagePumpForUI::DoRunLoop() base::MessagePumpWin::Run(base::MessagePump::Delegate *) base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run(bool,base::TimeDelta) base::RunLoop::Run() R=gab@chromium.org,fdoray@chromium.org Bug: 1074036 Change-Id: I5b5d5fd945205a3d2eaacbbde274e9f8caf5136e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582549 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#841232}
-
Gordon Seto authored
Add skeleton code for the confirmation code page in eSIM setup flow. Bug: 1093185 Change-Id: I5929a3bda2ea5bf8999fdc7f6182d8d1a79174d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612376 Commit-Queue: Gordon Seto <gordonseto@google.com> Reviewed-by:
-
Zach Trudo authored
Bug: b:176508994 Change-Id: Ic6137310e012b53ebd209f6c8b7d58b579ed7021 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610983 Commit-Queue: Zach Trudo <zatrudo@google.com> Reviewed-by:
Leonid Baraz <lbaraz@chromium.org> Cr-Commit-Position: refs/heads/master@{#841230}
-
Xianzhu Wang authored
Previously if a setting needed to invalidate multiple things, we needed to define a new type of invalidation and add code in page.cc to handle the invalidation. Change-Id: I8d5d89795a43e0aed58c59d20404f8d2ab4cf0f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613714 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#841229}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d0a38010a14c..a7158eb524dd 2021-01-07 syoussefi@chromium.org Vulkan: Fix image leak in staged updates in ImageHelper 2021-01-07 syoussefi@chromium.org Build compiler_tests only if GLSL or ESSL build is enabled 2021-01-07 penghuang@chromium.org Remove the checking before accessing to function pointers If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1146516,chromium:1161513,chromium:1163354 Tbr: ianelliott@google.com Change-Id: I5b275a7e53c2d20f92a7952cd0a04947e178eb16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615740Reviewed-by:
-
Andre Le authored
- Add a flag for the scalable status area feature. - Add enum and helper function in SystemTrayModel to capture system tray size. - Add date to system tray when the screen is large. Bug: 1161557 Change-Id: Id85a6bee9a30684c65b2253862ba30ab78583525 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600912Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Andre Le <leandre@chromium.org> Cr-Commit-Position: refs/heads/master@{#841227}
-
Jeroen Dhollander authored
The main goal is to ensure we can create |AudioInputHost| independently of |PlatformApiImpl|. This CL also makes |AudioInputHost| virtual so it can be faked during the unittests of |AssistantManagerServiceImpl|. Bug: b/171748795 Test: chromeos_unittests --gtest_filter="Assistant*:Audio*" Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Change-Id: Ic41ff343b28dae801b0c5f4c8c6417267270d8a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610047 Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#841226}
-
chromium-autoroll authored
https://chromium.googlesource.com/vulkan-deps.git/+log/725a542f7776..ffb3b84133b0 2021-01-07 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from ad77ed7a8d52 to f3ccb633dfd7 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-chromium-autoroll Please CC ianelliott@google.com,enga@google.com,radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ianelliott@google.com,enga@google.com,radial-bots+chrome-roll@google.com Change-Id: Ib3fa09252315df34bd8533d293788d1a89dab4d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615952Reviewed-by:
-
Elly Fong-Jones authored
This change lays out the overall architecture of a ScreenTime integration for Chrome on macOS. Specifically, this change adds: * screentime::TabHelper, which manages the state of ScreenTime for a single WebContents * screentime::WebpageController, an interface used to wrap the real STWebpageController object (which relies on systemwide state and is only available on 11.0+) * screentime::WebpageControllerImpl, an implementation of the above interface backed by STWebpageController * screentime::FakeWebpageController, an implementation of the above interface backed by lies This change does not add: * Any test coverage * Most of the useful integration we would need to do This change also has not yet been tried on a real 11.0 machine! Change-Id: I233d63239cc61d934a9d76b0f5fab60d5da059c1 Bug: 1154287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585655 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#841224}
-
