- 10 Jun, 2020 20 commits
-
-
Hitoshi Yoshida authored
Bindings team is going to update IDL dictionaries to be strict about their members' existence. After the update, accessing a getter on a missing dictionary member will crash. This CL fixes such potential crash issues in OscillatorNode Bug: 839389 Change-Id: I00b82cb290bfe2bc89b7354ff4e19aea80b3b10b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237025Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#776784}
-
Rakib M. Hasan authored
TBR: robertma@chromium.org Bug: 1050760, 1050754 Change-Id: I266dde105e6faaba75fd23881dd942d6b3baab8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238365 Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#776783}
-
Kunihiko Sakamoto authored
This reverts commit 84c360e5. Reason for revert: Suspect this CL causes OOPBrowserTest.Basic failure on linux-trusty-rel https://ci.chromium.org/p/chromium/builders/ci/linux-trusty-rel/12426 Original change's description: > Ignore CanvasResourceProvider::Clear in OOPR Mode > > In OOPR Canvas2D we no longer have access to Skia in the client process. > We need to update CanvasResourceProvider::Clear to not access SkCanvas > in the case of OOPR. A more ideal fix is tracked in > https://crbug.com/1090081 but simply ignoring it is fine for now as > OOPR automatically handles clearing the canvas during initialization. > > Bug: 1090083 > Change-Id: I5fb75e4fac312ec00b8e5215d3756219672461ee > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236193 > Commit-Queue: Nathan Zabriskie <nazabris@microsoft.com> > Reviewed-by: Khushal <khushalsagar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#776618} TBR=khushalsagar@chromium.org,nazabris@microsoft.com Change-Id: Ib906f07089a6b48eaf3e4b1f13fcfeae9d9b0896 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1090083 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237572Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#776782}
-
Sadrul Habib Chowdhury authored
A few related changes in this CL: . Improve trace-events, so that there's one FrameSequenceTracker trace-event corresponding to each UMA report. This is done by making sure merged FrameSequenceMetrics instances continue to report to the same trace-event, rather than creating a new one. . Update |frame_trackers_| to be tracked by both the sequence-type as well as the associated thread-type. This only affects scrolls, since the 'thread type' can change only for scrolls. BUG=1087630, 1092119 Change-Id: Ifa9e316899ce2dcf2d22e813985a62cab7e94558 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236635 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#776781}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I40aeb1db6b53ee5b5ffc0a9f4145658ed195d334 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238895Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#776780}
-
Keith Lee authored
Complete the TODO to send the suggestion via this API to the chrome extensions listening for it. BUG=1042084 Change-Id: Ia8877a700d5f5a53b22b5c34df76d502c81cb611 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208774 Commit-Queue: Keith Lee <keithlee@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
Jing Wang <jiwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#776779}
-
Joel Hockey authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/70439a4af4be..9d2399ea2761 $ git log 70439a4af..9d2399ea2 --date=short --no-merges --format='%ad %ae %s' 2020-06-07 joelhockey system_api: Add seneschal share type ARCHIVE 2020-06-03 clarkchung system_api: add technology field in battery fields 2020-05-28 briannorris system_api, shill: add WPA3 security option 2020-05-24 ahassani dlcservice: Deprecate DlcModuleList 2020-05-21 ahassani dlcservice: Deprecate OnInstallStatus signal Created with: roll-dep src/third_party/cros_system_api Bug: 1091611 Change-Id: Ieb00db563f488102fa4a42731e1e029fee5e5c2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237287 Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#776778}
-
David Bertoni authored
The SearchId and SearchIdAndFilename tests were disabled on MSAN for flakiness. Testing 3000 iterations of each one resulted in no flaky failures on the MSAN bots. Bug: 508949 Change-Id: I98a3f9077aff3218e94c2de8b506125175182761 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229154Reviewed-by:
Archana Simha <archanasimha@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#776777}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I435286712428d3ce5f9ae170e9b4e52f1df788a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238623Reviewed-by:
-
Rakina Zata Amni authored
When we do a back navigation that gets served from the back-forward cache, we should preserve the preview state/UI that we previously used when we originally navigated to that page before (so that we will show preview UI if and only if we showed it when we originally navigated to that page). Currently that information is deleted after the original navigation finished, but this CL is adding PreviewsUserData::DocumentDataHolderHolder that will save the information and use it when needed. Bug: 1014148 Change-Id: If70cba0d65ed0f8119eb9c245c1c8ae7104a8876 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220415Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Sreeja Kamishetty <sreejakshetty@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#776775}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I6db44eab83a6231837551a8e90da04b2e01073c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238362Reviewed-by:
-
Fergus Dall authored
https://chromium.googlesource.com/external/anongit.freedesktop.org/git/wayland/wayland-protocols.git/+log/630fb089103a..684cd23ae31f $ git log 630fb0891..684cd23ae --date=short --no-merges --format='%ad %ae %s' 2020-04-07 contact xdg-shell: explain how clients need to perform an initial commit 2020-04-07 contact xdg-shell: describe how to re-map an unmapped toplevel 2020-02-29 jadahl configure.ac: Bump version to 1.20 2020-02-29 jadahl Makefile.am: Also distribute README.md, GOVERNANCE.md and MEMBERS.md 2020-02-29 jadahl configure.ac: Bump version to 1.19 2020-01-13 jadahl xdg-shell: Add support for explicit popup repositioning 2020-01-13 jadahl xdg-shell: Add support for implicit popup repositioning 2020-01-13 jadahl xdg-shell: Remove left-over paragraph from pre positioner versions 2020-02-25 johanhelsing Update point-of-contact for Qt 2020-01-22 yalterz xdg-shell: add missing enum attribute to resize 2019-11-21 contact Convert plaintext documents to Markdown 2019-11-21 contact Add .gitlab-ci.yml 2019-11-20 contact readme: changes should be submitted via GitLab 2019-11-20 contact Add .editorconfig 2019-11-15 contact Add governance document 2019-08-19 yalterz presentation-time: add missing bitfield marker Created with: roll-dep src/third_party/wayland-protocols/src Bug: 1022716 Change-Id: Ic0daf595d72b170122ea562e435de10c7dfcc39b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237427Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#776773}
-
Kunihiko Sakamoto authored
This reverts commit 25044074. Reason for revert: ChromeURLDataManagerTestWithWebUIReportOnlyTrustedTypesEnabled.NoTrustedTypesViolationInWebUIGroupC is crashing on linux-chromeos-rel bot https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/38685 Original change's description: > Group tests of Trusted Types for WebUI > > This change groups tests of Trusted Types for WebUI into 20 WebUI pages > per test to minimize the size of the file. > > Bug: 41905 > Change-Id: I036b7ffd4d992606c008880fe4a9bddb43159a7f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2234997 > Reviewed-by: dpapad <dpapad@chromium.org> > Commit-Queue: Jun Kokatsu <Jun.Kokatsu@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#776654} TBR=dpapad@chromium.org,Jun.Kokatsu@microsoft.com Change-Id: Ia6bc3bdb566610dc14e68cc407b6077a312e09d7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 41905 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237534Reviewed-by:
-
sczs authored
Finch is not being used since the metrics team doesn't think its an appropriate use of Finch (Which is more aimed at A/B testing) and not a release tool. Metrics on NonStable Channels are good since the top crashes are barely occurring. We hope that this will help catch any of these elusive crashes (Hopefully with breadcrumbs) before the Stable release. Bug: 1065385 Change-Id: I49707077afd577b612d739ade4c9b3edaa9b5ecd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238377 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#776771}
-
Jinsuk Kim authored
On Tablet that can switch tab models without tab switcher, there are times |ActivityTabTabObserver#onObservingDifferentTab| is not fired as expected when the current tab model closes its last tab or we switch to one with no tab. This CL handles those cases to make sure the observers can see the event with nulled tab parameter. Bug: 1092390 Change-Id: I45f1ee1bfab6cccdb75e7e0a4e92bd85ea67b815 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237012Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#776770}
-
Nigel Tao authored
Bug: 1086733 Change-Id: If8d409f663ef3f572cec7d4707d288663b85ebc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235218Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#776769}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/86d91fc0ded9..2e14d9f0c8d0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC dimich@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1070324 Tbr: dimich@google.com Change-Id: I1449a8ac02761bca0297948f1740347ab488114c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238966Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#776768}
-
Adam Rice authored
When third_party/pywebsocket/src was removed from DEPS, the parent directory was accidentally left in place. Remove it. Change-Id: Idb2a5c6cfcd6da9bbacd6cf55dd583d3a3538ddd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237487Reviewed-by:
-
James Cook authored
The profile-keyed service AppService can call into LacrosLoader early during login. Move LacrosLoader singleton construction earlier, into PreProfileInit, to support this case. LacrosLoader should not check the LacrosSupport flag until the session starts, to ensure it doesn't run the flag-off cleanup code when the flag will actually be on. Make LacrosLoader a SessionStateObserver and check the flag after session start. Bug: 1093036 Change-Id: I60cfca700ace90e3f8e3b9dc8eb4b3d5fe63d5d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238874Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#776766}
-
Nigel Tao authored
Bug: 1070409 Change-Id: Icd1a307c827d9676508da76bb753c0e1f60437dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228593Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#776765}
-
- 09 Jun, 2020 20 commits
-
-
Scott Lee authored
TestResultSink provides interface for interacting with ResultSink. It detects whether ResultSink section from LUCI_CONTEXT, and initiates a communication channel, if prsent. R=nodir@chromium.org,robertma@chromium.org CC=chanli@chromium.org,iannucci@chromium.org Bug: 1084459 Change-Id: I7c09b5c5fcbde02be0d76b2d0dacb43cfb035ccf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2234713Reviewed-by:
Chan Li <chanli@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Commit-Queue: Scott Lee <ddoman@chromium.org> Cr-Commit-Position: refs/heads/master@{#776764}
-
Hazem Ashmawy authored
Although MetricsBridgeService has a sync AIDL interface where all its calls block till they finish, recordMetrics does it job asynchronously behind the scenes where it posts the actual recording task to a background TaskRunner. This may result in some rare cases that the service may be killed by the system (because all clients had unbound the service) while still having some writing tasks in the background that haven't finished yet. To solve this: - Make SequencedTaskRunner static so that all service instances created by the system will share the same task runner avoiding, possible race conditions writing to file. - Make the service both start and bound service. The service will start itself with the first client binding and it will manage its own lifecycle to ensure that it stays running until it has finished its writing tasks. Service will not be destroyed by the system until all clients unbind and the service calls stopSelf() See https://developer.android.com/guide/components/bound-services. There is no evidence that this actually happens and there is no reliable way to reproduce this in tests but this is still a potential bug that should be fixed. Fixed: 1082572 Test: /bin/run_webview_instrumentation_test_apk -f "*MetricsBridgeServiceTest*" Change-Id: I5e8e9226379f4b2b38f8b720405f78603ae2b3c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235597 Commit-Queue: Hazem Ashmawy <hazems@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#776763}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1591286362-90b15f0dd76efe68d630c81484c2fae8f33c92a6.profdata to chrome-win32-master-1591732735-0015e64d5031c088448e4bf6bbe4dc15e4f90ad0.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Id6aa31331bacbbcac5c413ef3c3c53d4fa8fb989 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238696Reviewed-by:
-
John Lee authored
Bug: 1082344 Change-Id: I6a5bb49bf60e40030a3c22ef5b02b78cdeef8bcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236244 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#776761}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d3927e40f1de..990a04ecd5e8 2020-06-09 herb@google.com remove unused and unimplemented calls 2020-06-09 herb@google.com move the bulk of GrTextContext to GrRenderTargetContext 2020-06-09 brianosman@google.com Remove SkValidatingReadBuffer.h 2020-06-09 jmbetancourt@google.com remove arcore from apps project directory 2020-06-09 adlai@google.com Don't fill last render task map with nullptrs 2020-06-09 egdaniel@google.com Disable support for sample locations in vulkan. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: bungeman@google.com Change-Id: Ibe189f5746fba54a524b791c3ea32f774298605b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238688Reviewed-by:
-
Becca Hughes authored
The media feeds spec has a number of sample test feeds. This adds them to Chromium. BUG=1053599 Change-Id: Ib4127e3f2def42bc600fc308c83f040b59cfbe73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233721 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#776759}
-
Carlos IL authored
neterror.html no longer depends on any code from interstitial_common.js, so it should no longer include it. Bug: 1087282 Change-Id: I5951041bb15fc2ca742a7e99e9a4d25f19922a89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219599Reviewed-by:
Edward Jung (EMEA) <edwardjung@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#776758}
-
Rakib M. Hasan authored
Bug: 1050760, 1050754, 986447 Change-Id: Ib9af3b1b7994f312eb683fd66e60c67d4ef12aea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2193663 Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
-
Sergey Ulanov authored
Previously buffer format and usage were not passed when registering a sysmem buffer collection using SharedImageInterface::RegisterSysmemBufferCollection(). The values were hardcoded in the implementation. Pass them explicitly so the clients can use different values when necessary. Bug: 1090447 Change-Id: Id3aacdb642e09b245a496954ea122f6fc5054587 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236607Reviewed-by:
Peng Huang <penghuang@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#776756}
-
Wei-Yin Chen (陳威尹) authored
There are two MVC properties, StartSurfaceToolbarProperties#INCOGNITO_SWITCHER_VISIBLE and IncognitoSwitchProperties#IS_VISIBLE, controlling the visibility of the incognito switch. When one set to true first and the other set to false, setting the first one to true again wouldn't make it visible since the value of the property doesn't change. This CL is a workaround, by making the property skipEquality = true. Bug: 1081733 Change-Id: I2b595e955b9a08ef38bc38697c87ec0d934ca9a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236212 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Auto-Submit: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/82ca62d3e155..2911cba7a7a2 2020-06-09 taylori@google.com Merge "perfetto-ui: Add go to dest button for binder slices" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I390fa247c31feed2abbdd7d173393a9388269cd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238698Reviewed-by:
-
Aaron Leventhal authored
R=dmazzoni Bug: 1039422 Change-Id: I443859ce61d6ab73967b226b85a90b14f07e2a1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236457 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#776753}
-
Ella Ge authored
The |IsInstalledWebappDelegateGeolocation| is added in previous CL crrev.com/c/2210487 but forgot to add the feature flag to guard it. TBR=yfriedman@chromium.org Bug: 1069506 Change-Id: Ia3ea420a40da979f7b830cdbc2e2816c1217f9ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238593Reviewed-by:
Ella Ge <eirage@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#776752}
-
Haiyang Pan authored
Bug: 954217 Change-Id: I493798fb9e901c68455cc2f1b2772b956fd240ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238422 Auto-Submit: Haiyang Pan <hypan@google.com> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#776751}
-
Stefan Zager authored
They aren't needed, and they introduce flakiness. BUG=1059044 Change-Id: I988866c0da79adafb493c9ba1d263c19ecf8c033 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2191735 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#776750}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ic822fa19561666ffa635b3f084a04356ad3f3268 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238762Reviewed-by:
-
Erik Chen authored
This config change is necessary to successfully compile lacros. This CL also comments out an inappropriately failing assert. Change-Id: Ibe3a18f9cdcebcb0864bb744c918d540177952b4 Bug: 1093038 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238380 Commit-Queue: Erik Chen <erikchen@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#776748}
-
Taylor Bergquist authored
Many rough edges, which I'll document somewhere and fix. Crashes unless the #scroll-unification flag is enabled. Bug: 951078 Change-Id: If8570648b62fe435b9ca9c03b483e7a503012362 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236237Reviewed-by:
Collin Baker <collinbaker@chromium.org> Reviewed-by:
Connie Wan <connily@chromium.org> Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#776747}
-
Matt Jones authored
Bug: 1002277 Change-Id: I70219c5eef14630f8fd1584d2af085c4a9c3ae21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236503 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I88261059ebbadd939908e8f152e729056f14194f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238888Reviewed-by:
-
