- 29 Dec, 2019 11 commits
-
-
Koji Ishii authored
Following bot results are included. 740 741 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 770 774 26 lines were removed and 7 lines were deflaked by consecutive results since 735. TBR=yosin@chromium.org NOTRY=true Bug: 982194 Change-Id: I66d840119ff698ef156ab60500ee7dc70deae94b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982332Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#727708}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/35c4ffd0223c..b4fa840c62df Created with: gclient setdep -r src-internal@b4fa840c62df If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ib1842c99b6e6535f1a136fe959b349b0d9894f06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983924Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727707}
-
Yuki Shiino authored
Improves the check of whether a given symbol is already defined or not. Turns naive recursive calls into loop code so that it scales more. Bug: 839389 Change-Id: I3e0062527fda23a15dafe83630c6e3f7b699f379 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969419Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#727706}
-
Yuki Shiino authored
Compiles Mako template objects and cache them. This patch improves code generation speed (Navigator: 26s => 13s, Window: 109s => 39s). Bug: 839389 Change-Id: Ib936f19441e7896a086f81a630032d23f10bd43c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983679Reviewed-by:
-
Yuki Shiino authored
Bug: 839389 Change-Id: I39a0ee0fb59c223e3beeb6d47c045dfbe823505b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981513Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1e988aa93067..35c4ffd0223c Created with: gclient setdep -r src-internal@35c4ffd0223c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I34a2ea90dc393b35ad386cd6b468912636d1de49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983858Reviewed-by:
-
Regan Hsu authored
Currently, ctrl+0 (zoom to normal) is ignored while the Screen lock pin keyboard dialog is onscreen. This CL ensures that when the user hits '0' with ctrl on, zoom in and zoom out occurs. Fixed: 1038008 Change-Id: I8f05e469ad72d5602410dca5ccfbe73ab84c265e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982769 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#727702}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c22c4eeb5cd2..1e988aa93067 Created with: gclient setdep -r src-internal@1e988aa93067 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I6c29247039173ff260cabe25c18dcb99f824d1e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983840Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: Ibd94fa0d2432f3f136767baaab66dab8cb365559 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981858Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727700}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/971153f87c66..c22c4eeb5cd2 Created with: gclient setdep -r src-internal@c22c4eeb5cd2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ie2c18ac757bcd68bb566d72b6255e80d8cddf082 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983817Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1828e341d62e..971153f87c66 Created with: gclient setdep -r src-internal@971153f87c66 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ib2325028412d0d7ad30764cc18ef1b842a0d79d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983473Reviewed-by:
-
- 28 Dec, 2019 29 commits
-
-
chromium-autoroll authored
Roll silvermont AFDO profile from 81-3987.0-1577099071-benchmark-81.0.4005.0-r1 to 81-3987.0-1577099071-benchmark-81.0.4009.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ic35eaf2814e6c561622c5942f42aaddd39e4ac3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983469Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727697}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: Idaed872ef97b73ffb6fd59b1bcf2e745f85149e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983465Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#727696}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cd6aac8e583e..1828e341d62e Created with: gclient setdep -r src-internal@1828e341d62e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Iab01b25f231d7d29b1ce9885db6628eb1284a9f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983468Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/96541cfed199..cd6aac8e583e Created with: gclient setdep -r src-internal@cd6aac8e583e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I612225a81e1903c8e41e027e631bea3cbde88ebf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983428Reviewed-by:
-
Philip Rogers authored
Bug: 853360 Change-Id: I7c8704f052306dd9a71f51e423e4ddf9a86b5255 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982590 Auto-Submit: Philip Rogers <pdr@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#727693}
-
Caleb Rouleau authored
Hotfix for https://chromium-review.googlesource.com/c/chromium/src/+/1983326 Failure example: https://chrome-swarming.appspot.com/task?id=49652cd3c145fd10 TBR=johnchen@chromium.org Bug: 921353 Change-Id: Ia8eef9bc53fbe293a2028a8b228f78a73926ded7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983464Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#727692}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/50f4cb0b8906..96541cfed199 Created with: gclient setdep -r src-internal@96541cfed199 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I2f92ad61cd2eb6fedc8ba85626be607c5cf1c8dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983426Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1ab62bfd380f..50f4cb0b8906 Created with: gclient setdep -r src-internal@50f4cb0b8906 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I153f68572bdc236dc84454be413016d085b9773d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983424Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ac7143bd19e4..1ab62bfd380f Created with: gclient setdep -r src-internal@1ab62bfd380f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I439c899ae78ab15e00428475285f8636dc7d1e0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983423Reviewed-by:
-
chromium-autoroll authored
Roll broadwell AFDO profile from 81-3945.86-1577097374-benchmark-81.0.4008.0-r1 to 81-3945.86-1577097374-benchmark-81.0.4009.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I5d69816c3cf84ef88f5523c39dac62f863b14b5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983422Reviewed-by:
-
chromium-autoroll authored
Roll airmont AFDO profile from 81-3987.0-1577100150-benchmark-81.0.4008.0-r1 to 81-3987.0-1577100150-benchmark-81.0.4009.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I72b3e13b6facfc5ecd6e6286a88207d984c297e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983421Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6ee4206ee994..ac7143bd19e4 Created with: gclient setdep -r src-internal@ac7143bd19e4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ia46e672a8b3826f188c3667b3e4f27d975cbb3d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983608Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5bce433bdae6..6ee4206ee994 Created with: gclient setdep -r src-internal@6ee4206ee994 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I3876986aca3895b560a9370b88f2dd6cdbe86c52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983581Reviewed-by:
-
Etienne Bergeron authored
Add unittests for getCursorBounds to avoid breaking it with coming code refactorings. R=pkasting@chromium.org Bug: 1025561 Change-Id: I358623e9be67627b104ca6729b3b688a4e221a38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981854 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#727684}
-
Dan Beam authored
Screenshot: https://bugs.chromium.org/p/chromium/issues/detail?id=1034836#c2 R=rbpotter@chromium.org Fixed: 1034836 Change-Id: Ica1e595263de2e5b34499352435d4d99ff866133 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983551 Commit-Queue: Dan Beam <dbeam@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#727683}
-
Dan Beam authored
R=rbpotter@chromium.org BUG=355446 Change-Id: I58db2de0c366c427bfa86595004bc3815576be5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983548 Commit-Queue: Dan Beam <dbeam@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b015b7d12040..139deb3609b0 git log b015b7d12040..139deb3609b0 --date=short --first-parent --format='%ad %ae %s' 2019-12-28 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update Devtools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@139deb3609b0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I970b6d4a4bf484bba698f128cb930a3adabee301 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983505Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: I2dfffc7094d4a5d2eb105aef876ce8ab7ede3a5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981855Reviewed-by:
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: Ic245e3f8cdb39de63301e98b206e928d000f7d66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983507Reviewed-by:
-
Caleb Rouleau authored
All Telemetry tests are currently run as part of One Buildbot Step (OBBS): performance_test_suite. However, gtest perf tests are run separately. This causes problems since these tests have to finish before we can start the Telemetry tests. So even thought these tests are fast, they block a bunch of other tests. This changelist adds these test to the shard maps so that they can be run alongside the Telemetry tests as part of the same shards. This allows us to distribute load across all the shards evenly. As a first test, this changelist only does the switch for Nexus 5. If this works, I will follow it up with changes for all the other builders. Please note that this changelist should not be cleanly reverted because it changes which shard the various telemetry tests run on. This change can cause false-positive improvements and regressions as a result of the bot that the stories are running on changing. If this change is reverted, then that will cause another set of these false positives as the stories change back to running on an earlier bot. Bug: 921353 Change-Id: I0dabb053ba21b05cc9e97f540e23e59829e3e44c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983326Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#727678}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ab693fffbdba..5bce433bdae6 Created with: gclient setdep -r src-internal@5bce433bdae6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I0788d434c83efbd20d741b43e2f42246d0f1a86c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983503Reviewed-by:
-
Etienne Bergeron authored
The lifted function is similar to the ExpandRangeToWordBoundary(...). It allows to get the enclosing range at grapheme boundaries. R=pkasting@chromium.org Bug: 1025561 Change-Id: I4f439b81ac0c1c7e540f67b98c9e3e7f9757b36b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982714 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
-
rbpotter authored
- Delete code paths from browser settings people pagethat are behind showOSSettings = true - Move sections of UI that are always hidden when showOSSettings = false to chromeos/os_people_page. Bug: 990132 Change-Id: I162bef622cda7e60254b301106aa3628b20de3c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978254 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
rbpotter authored
Moving CUPS printers files from c/b/r/settings/printing_page to c/b/r/settings/chromeos/os_printing_page, and deleting CUPS printers link row from browser settings printing page, since it is only shown when showing the OS settings. Also fixing the getEulaUrlGetsCalledOnModelChange test, as it always fails for optimize_webui=false before this CL. This appears to have never been detected due to https://crbug.com/1003483, which disabled all OS settings browser tests on debug builds. Bug: 990132 Change-Id: Iba9d153c69accd53396132d21046e055e6e3556c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982669 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
rbpotter authored
The test was only flaky for Linux CFI and Mac 10.10 but was disabled on all platforms. Re-enable it for builds that aren't Linux CFI or Mac. Bug: 1008122 Change-Id: I5e442736fa80a3b1e8afc727696c3964f0dd205f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983457Reviewed-by:
-
Matt Reynolds authored
Microsoft released an updated "Series 2" version of the Xbox Elite Wireless Controller in 2019. The updated version uses Bluetooth for wireless connectivity instead of the proprietary wireless protocol used by earlier Xbox One gamepads. This CL adds mappings for Xbox Elite Series 2 on Linux when connected over USB and Bluetooth, and on macOS when connected over Bluetooth. The device does not provide inputs on macOS when connected over USB. BUG=1022220 Change-Id: Id323c0536ed01645030c5f73287add3b8c28e780 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983354 Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Vincent Scheib <scheib@chromium.org> Cr-Commit-Position: refs/heads/master@{#727672}
-
Regan Hsu authored
Currently, there is an unnecessary blink of enabled 'Backspace' button. This regression occured because a transition time was introduced in https://chromium-review.googlesource.com/c/chromium/src/+/1898479 to iron-icon, causing a momentary blink. This CL removes the transition time to the fill so there is no blink in the beginning on the backspace button. Doing so does not cause any blatant changes to other actions applied on backspace button (i.e deleting a pin number when the button is enabled). Fixed: 1036266 Change-Id: I539ec8b2f775c868d560f8fa2df76299bf8a7a89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983344 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/726986fab08b..f77838c9ed9f git log 726986fab08b..f77838c9ed9f --date=short --first-parent --format='%ad %ae %s' 2019-12-28 hypan@google.com Add reference binaries for android app bundles Created with: gclient setdep -r src/third_party/catapult@f77838c9ed9f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:986990 Tbr: skyostil@google.com Change-Id: I536a8a085c5cb69acfbcff3cf0e5621c2bda1c8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983500Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I62a36fc558389e61047f263d02477a71a74b70ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982935Reviewed-by:
-
