GitLab

That way, we can keep around the old paint fragment while we wait for
a final new one.

This patch fixes a dcheck failure when enabling fragment caching.

R=kojii@chromium.org,eae@chromium.org

Bug: 635619
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I763446ab3411c828a636317421fd398f500be67f
Reviewed-on: https://chromium-review.googlesource.com/1012499Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551335}

This is part of migration from username check to Gaia id check.
Desktop policies are validated in UserCloudPolicyStore, that will now
receive AccountId with Gaia id where it's possible to populate it
from AccountInfo.

BUG=780792
TEST=Unit/browser tests updated.

Change-Id: I7f7620e4ff6c1630975e8f6b7d808c629d90716a
Reviewed-on: https://chromium-review.googlesource.com/1005348Reviewed-by: Roger Tawa <rogerta@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Commit-Queue: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551334}

https://webrtc.googlesource.com/src.git/+log/365381fdf1cd..6dfc8d6ef3b2

$ git log 365381fdf..6dfc8d6ef --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc
BUG=chromium:827917,chromium:None,chromium:590625,chromium:None,chromium:None,chromium:none,chromium:none,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:none


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Icc418e420f561e22812bf43676d3ed5425a42659
Reviewed-on: https://chromium-review.googlesource.com/1014943
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#551333}

This patch simply moves the location where the compressed
locale .pak files are stored within the final Chrome and
Monochrome APKs, from assets/<locale>.pak to
assets/locales/<locale>.pak

The reason to do this is to allow language-dependent
splits in the future, which will require apkbuilder.py
to support an option to place the files under a
directory like assets/locales#<lang>/<locale>.pak,
where <lang> is the language code of each corresponding
locale.

Note that these files are never accessed directly from
Chromium, instead they are extracted at startup time
if needed to the application's private data directory,
and the uncompressed file there is what Chrome will
later memory-map from native code.

In detail:

- Modify chrome/android/BUILD.gn to ensure that the
  compressed locale pak files are placed under
  assets/locales/

- Modify write_build_config.py to not use the directory
  of locale pak files when generating the Java locale
  lists for COMPRESSED_LOCALES and UNCOMPRESSED_LOCALES.

- Modify ResourceBundle.java to deal with the new list
  format when looking for uncompressed locales.

- Modify ResourceExtractor.java to deal with the new
  list format and the new locations.

BUG=820459
R=agrieve@chromium.org,dtrainor@chromium.org,tedchoc@chromium.org

Change-Id: Ia0caef3514a1ccfa72fe0ab1ff6fc1bf418377a6
Reviewed-on: https://chromium-review.googlesource.com/1010352
Commit-Queue: David Turner <digit@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551332}

TBR=fukino@chromium.org

Bug: 833049, 832192, 833752, 832799, 832798
Change-Id: I7d3316f2deae4f0e415e41a95211ee1f105cdf32
Reviewed-on: https://chromium-review.googlesource.com/1015003Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551331}

Original cl reviewed on https://chromium-review.googlesource.com/727464

Reason for revert: The original cl causes the following regression and
with browser side fling and async wheel events it's not needed anymore.

Regression: Touchpad scrolling disables wheel scrolling since GSU events
generated from wheel scrolling get filtered here:
https://cs.chromium.org/chromium/src/content/browser/renderer_host/input/gesture_event_queue.cc?q=Gesture_Event_queue&dr=C&l=130

fling_in_progress_ gets reset on GFC which is received when the user
puts their fingers on touchpad, so if the user scrolls with touchpad
first and then starts a subsequent wheel scrolling no GFC will be
received after the GFS and fling_in_progress_ will be still true while
GSU events from wheel scrolling are arriving.

Bug: 817479, 717205
Change-Id: I3997f756430df432aab37e5af77e1409dc8e0225
Reviewed-on: https://chromium-review.googlesource.com/1014415Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551330}

This reverts commit 82d9545a.

Reason for revert: compile failures on ios-simulator-xcode-clang and ios-device-xcode-clang builders:
 * https://uberchromegw.corp.google.com/i/chromium.mac/builders/ios-simulator-xcode-clang/builds/46343
 * https://uberchromegw.corp.google.com/i/chromium.mac/builders/ios-device-xcode-clang/builds/57515

Original change's description:
> [base] Add missing methods to base::span
> 
> This change implements constructors for base::span that allow the
> construction from a pair of pointers, std::arrays and containers
> supporting base::data and base::size, e.g. std::initializer_list.
> In addition, this change adds operator().
> 
> Bug: 788913
> Change-Id: Ibc280eef1c7e47a5a27e92503dda3614ef5513a4
> Reviewed-on: https://chromium-review.googlesource.com/981139
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#551313}

TBR=dcheng@chromium.org,jdoerrie@chromium.org

Change-Id: Ia967227caa3a24a10df2ab4c5fa4ee03dddf0f29
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 788913
Reviewed-on: https://chromium-review.googlesource.com/1014761Reviewed-by: Mohsen Izadi <mohsen@chromium.org>
Commit-Queue: Mohsen Izadi <mohsen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551329}

Removed src/components/ButtonBar/src/private/MDCButtonBarButton+Private.h

Bug: 833726
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I141ee872a3255039f35a5bb9bf0aecd77277b435
Reviewed-on: https://chromium-review.googlesource.com/1014499Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Peter Lee <pkl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551328}

- Use uniform initialization syntax when calling ExpectGetAccounts,
  rather than manually building an std::vector.
- Use range-based for.

Bug: none
Change-Id: I5e31970086c806791baf588ca9f382a91d0be6af
Reviewed-on: https://chromium-review.googlesource.com/1013584Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551327}

Makes the omnibox popup presenter use autolayout to display the
popup view controller. The correct height of the popup is then
communicated by means of intrinsicContentSize of the popup table view.

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I521adfbff62c3c42e7120fb7bb5f7f5b09bfd2b3
Bug: 821817
Reviewed-on: https://chromium-review.googlesource.com/978177Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551326}

This CL update the hidden property of the toolbar buttons based on the
current size class each time the button checks if it should be
displayed in the current size class, even if the result is the same as
the current hidden property.

Bug: 828767
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Iec39f2bb5ca80c78d7a04e0225a9f048c09d0f28
Reviewed-on: https://chromium-review.googlesource.com/1013527Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551325}

This change:
1) Draws exterior borders on menus, even if MenuConfig says not to use them,
   if the NativeTheme is in high contrast mode;
2) Draws separators in black instead of grey in high contrast mode on Mac;
3) Draws a heavy (2pt) border around the selected item in high contrast mode
   on Mac

Screenshots are attached to the bug as comment #10.

Bug: 829347
Change-Id: I8ffd7adbae5b35751c18b77a9e8b6564926f7012
Reviewed-on: https://chromium-review.googlesource.com/1010245
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551324}

Migrate MessageLoop::ScopedNestableTaskAllower to RunLoop::Type::kNestableTasksAllowed in /content/browser/site_per_process_browsertest.cc

This is another scripted pass done by a slightly modified version of
https://bugs.chromium.org/p/chromium/issues/detail?id=781352#c1 which
has a better notion of "scope".

The script should have replaced a MessageLoop::ScopedNestableTaskAllower
in the same scope as a RunLoop with a RunLoop of
Type::kNestableTasksAllowed.

Includes should have been stripped if that was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=kenrb@chromium.org

Bug: 781352
Change-Id: Ie0c1d1908812adc327f0777d552c7e4c97433d80
Reviewed-on: https://chromium-review.googlesource.com/1014781
Commit-Queue: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551323}

When Chrome uploads |ACCOUNT_CREATION_PASSWORD| vote, the uploaded form data should
belong to the saved credential(i.e. |PasswordFormManager::pending_credentials|), but
not to |submitted_form_| or |observed_form_|. This CL fixes it.

The CL also changes how |password_element| is set in |CreatePendingCredentials|. If
|pending_credentials_| is an already saved credential, then |password_element| should
be from the saved credential, but not from the submitted form.

Bug: 552420
Change-Id: I84dec939e097f0356d3ad7af8cdf3dc9ec97e2a5
Reviewed-on: https://chromium-review.googlesource.com/1014105Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551322}

This flag has defaulted on for more than one release, and is no longer
needed.

BUG=
R=ymalik

Change-Id: I93f8aadb1e2cb78a558a7bdc5030fdf30d1dcff9
Reviewed-on: https://chromium-review.googlesource.com/1014350Reviewed-by: Yash Malik <ymalik@chromium.org>
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551321}

This reverts commit 80e335a5.

Bug: 826632
Change-Id: I159ce3037f96af582b6095dca69d4d1cd4318843
Reviewed-on: https://chromium-review.googlesource.com/1014363
Commit-Queue: Sidney San Martín <sdy@chromium.org>
Reviewed-by: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551320}

TBR=dcheng@chromium.org

Bug: 832392
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: If944b3af9f4bd4e6534f5fcaff06219caa1d9d30
Reviewed-on: https://chromium-review.googlesource.com/1012322
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Yuki Awano <yawano@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551319}

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I0b55438e39025fdfa9db24ee74ecc5a635c4ae2b
Reviewed-on: https://chromium-review.googlesource.com/1014662Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551318}

Fix various paging isssues in RTL with the Tab Grid.

- Tapping the page control, or otherwise setting |currentPage| on the
  TabGridViewController will set the correct offset for the scroll view.

- Scrolling the view will set the correct page.

- Scrolling the view moves the page control correctly.

Bug: 822328
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ic8f53c894fd4388b97d82093ac35ad675caa87a5
Reviewed-on: https://chromium-review.googlesource.com/1013927Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551317}

This includes exposing some of trigger manager's rejection reasons.
Also more unit tests for suspicious site trigger.

Bug: 817377
Change-Id: I45644c441f9d8df992766e501d489ff6bb1f83ba
Reviewed-on: https://chromium-review.googlesource.com/1010408Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Commit-Queue: Luke Z <lpz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551316}

Adds a share button in steady state location view. The button is only
shown in compact environments; in regular it would duplicate the one in
the toolbar so it's not shown.

Temporarily uses the icon from the similar toolbar button.

Bug: 821810
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I2fcfa9673b80851fe63fb0a8e040450b5bb8e0c0
Reviewed-on: https://chromium-review.googlesource.com/1012064
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551315}

Currently, errors from the platform (e.g. device disconnected), are sent directly to the renderer
(AudioOutputStreamClient). When moving to the audio service, this becomes suboptimal. It is tricky
to signal an error occurring before the ClientPtr is set up, and sometimes we may not want it
torn down due to a platform error (in case we want to try some sort of recovery operation such as
restarting the audio service). This CL instead signals the error to the browser
(AudioOutputStreamObserver), which signals it to the client through the new
AudioOutputStreamProviderClient interface. That interface also gets the "stream created" callback
as a method rather than a mojo response, so that we will be able to call it multiple times in the
future.

Bug: 787806,830493
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I0fca093e2676d96f0f397c0fb59dd6c31eae1384
Reviewed-on: https://chromium-review.googlesource.com/973367
Commit-Queue: Max Morin <maxmorin@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551314}

This change implements constructors for base::span that allow the
construction from a pair of pointers, std::arrays and containers
supporting base::data and base::size, e.g. std::initializer_list.
In addition, this change adds operator().

Bug: 788913
Change-Id: Ibc280eef1c7e47a5a27e92503dda3614ef5513a4
Reviewed-on: https://chromium-review.googlesource.com/981139Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551313}

This flaky expectation for "too-small-buffers" was not sufficient
to prevent try jobs from failing. Upgrade it to "Fail" so it will
prevent flaky retries.

Examples:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20FYI%20Release%20%28NVIDIA%29/182
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20FYI%20Release%20%28NVIDIA%29/181

Bug: 832238
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I646cb3815d93c11f3cb39d1e919f7db2283e4ba5
Tbr: kbr@chromium.org
No-Try: True
Reviewed-on: https://chromium-review.googlesource.com/1014734Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551312}

These files were added after uploading
https://chromium-review.googlesource.com/1006740 .

TBR=hayato@chromium.org

Bug: 829695
Change-Id: Iabad9ca87ba67e65e8183280e193f15ee8263cb0
Reviewed-on: https://chromium-review.googlesource.com/1013770Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551311}

Serialize border-image inline style by implementing the serializing
logic for it in StylePropertySerializer::GetPropertyValue.

Bug: 825568

Change-Id: Ibaa18dadc41bb7aa735ab5e1384615b5d2270a2c
Reviewed-on: https://chromium-review.googlesource.com/990721
Commit-Queue: Rob Buis <rob.buis@samsung.com>
Reviewed-by: Timothy Loh <timloh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551310}

Moved calling to D-Bus service out of EnrollmentScreenHandler into
EnrollmentScreen. Needed because EnrollmentScreen implements
ActiveDirectoryJoinDelegate. Future CL will use that to provide dm token
to D-Bus service and to use configuration seed coming from DM server.

BUG=chromium:829361,chromium:809914

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I606d974e3461c802b37ff88ec0658f910a3953f5
Reviewed-on: https://chromium-review.googlesource.com/1004954
Commit-Queue: Roman Sorokin <rsorokin@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551309}

The previous DCHECK was comparing the pointer values, not the strings.

Bug: 833807
Change-Id: I0e63eda10838de481c51630f8932b41537a76847
Reviewed-on: https://chromium-review.googlesource.com/1013525
Commit-Queue: Hans Wennborg <hans@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551308}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/778a1cdf05f1..888a7065b4ba

$ git log 778a1cdf0..888a7065b --date=short --no-merges --format='%ad %ae %s'
2018-04-16 ihf chromeos_config: reorganize caroline CQ/PFQ.

Created with:
  roll-dep src/third_party/chromite


The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: Ife1a4d5087a457c3c19d3a9f7d29c0c8696f3ee1
Reviewed-on: https://chromium-review.googlesource.com/1014940Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#551307}

TBR=fukino@chromium.org

Bug: 833795
Change-Id: I105312fb6b0de0e2db8fad25b4463109e747e9e5
Reviewed-on: https://chromium-review.googlesource.com/1013942Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551306}

from the Display status and make it informational only (not
abort the call).

Bug: 734095
Change-Id: Id55c2c32a077d27ae06b11ee36241df5ee5a8318
Reviewed-on: https://chromium-review.googlesource.com/1007278
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551305}

This reverts commit dbd17728.

Reason for revert: Broke supersize

Original change's description:
> Supersize: Tweak variable name (no behavior change)
> 
> Addressing review comments from TBR'ed:
> dd5d5a01
> 
> Change-Id: Ic181c0da49f82031bf842ce69a05d14144dd92f8
> Reviewed-on: https://chromium-review.googlesource.com/1014293
> Reviewed-by: Samuel Huang <huangs@chromium.org>
> Commit-Queue: Samuel Huang <huangs@chromium.org>
> Commit-Queue: agrieve <agrieve@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#551073}

TBR=huangs@chromium.org,agrieve@chromium.org

Change-Id: I52a434cad48f795075eaab834e9c039294e988d5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/1014976Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551304}

When we update parts of the key of existing credentials, we need the
pre-update data. We take this data from the password store, as found in
|best_matches|. Sometimes, the updated credential is not in the matches.
This CL fixes a crash from
https://chromium-review.googlesource.com/c/chromium/src/+/941522 where
we presumed that the credentials are always in the matches.

Bug: 833171, 817750
Change-Id: Id2aae19b307d65c3527cdf9a6c80703dc6bfeb34
Reviewed-on: https://chromium-review.googlesource.com/1012848
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551303}

This CL removes the unseen state (in the tools menu button in the
toolbar) when the UI Refresh flag is enabled.

Bug: 828367, 831134
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I4446d5b4f2565f256e4fedb829a77e93295b0d00
Reviewed-on: https://chromium-review.googlesource.com/1014092Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551302}

The Origin is now looked up in the browser, so passing the origin is
unnecessary. This is a followup to
https://chromium-review.googlesource.com/c/chromium/src/+/1010424.

Also fix some lint.

Bug: 653871,721732
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I681dd754d71e1fe87e94f514428e1b3bea7aa736
Reviewed-on: https://chromium-review.googlesource.com/1012114
Commit-Queue: Max Morin <maxmorin@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551301}

https://skia.googlesource.com/skia.git/+log/b460320a96df..eedecc6046b2

$ git log b460320a9..eedecc604 --date=short --no-merges --format='%ad %ae %s'
2018-04-17 angle-skia-autoroll Roll third_party/externals/angle2/ a4fa9c278..08b9e046c (6 commits)

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=scroggo@chromium.org

Change-Id: I24a36d8cf7a95a7f8b3db51444be07e19e601b3c
Reviewed-on: https://chromium-review.googlesource.com/1014542Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#551300}

This change fixes a bug in U2fSign, where under certain circumstances an
end iterator was dereferenced.

Bug: 833398
Change-Id: I9194a966b01fbe9da6e51e50645f7f301e0d59e5
Reviewed-on: https://chromium-review.googlesource.com/1013484
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551299}

Tests are added to compare outputs of traffic_annotation_auditor using
different parameters.

Bug: 690323
Change-Id: I69bc0234310020e2e92ecdd25c90f543f9b99459
Reviewed-on: https://chromium-review.googlesource.com/960143
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551298}

This is needed to return error codes to the Blink layer.

Bug: 589455
Change-Id: I698325ae7960121174af1b345f438e716fd0d099
Reviewed-on: https://chromium-review.googlesource.com/1013521Reviewed-by: Henrik Boström <hbos@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551297}

Bug: 833214
Change-Id: I5552bdca37a2e3e20a039b9a0ca316f4480b1217
Reviewed-on: https://chromium-review.googlesource.com/1010055
Commit-Queue: Shuo Weng <shuow@google.com>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551296}