- 26 Mar, 2019 40 commits
-
-
Livvie Lin authored
Chromium screenshot: https://drive.google.com/file/d/1uNLiVaDEFTHzU5_NFkzzVffwyr-x2FCq/view?usp=sharing Bug: 931812 Change-Id: Ie5b821530bd15efeb7e9b30389fec8e74fdbfc0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530115Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Livvie Lin <livvielin@chromium.org> Cr-Commit-Position: refs/heads/master@{#644461}
-
Sahel Sharify authored
TBR=tangltom@chromium.org,pkasting@chromium.org,droger@chromium.org Bug: 945848 Change-Id: I9045c04fb7f0875f4c0a1225502a65d9581445ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540083Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#644460}
-
Mehran Mahmoudi authored
This changes the trigger for key functions IPH from onPageLoadFinished to onPageLoadStarted. Related discussion: https://docs.google.com/a/google.com/presentation/d/1c-aVSZ_zsBuzCwQ4CrBJppmRQjiupa6PXmlC2OS-F-Q/edit?disco=AAAACv_xdz8 Bug: 924748 Change-Id: Ie0e0e20a9b2a92b32db3cd2ea240133dcac4f2cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539867Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#644459}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=cmasso@chromium.org Change-Id: Idadee32e58e1b25e999a143dd94b757fc2c59d93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540094Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#644458}
-
Robert Liao authored
/showIncludes causes clang-tidy to output a lot of unnecessary text to the console. BUG=944686 Change-Id: I9e8b2e0912d47c70aef9fae8919ab492a310fb29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538645 Auto-Submit: Robert Liao <robliao@chromium.org> Reviewed-by:
Reid Kleckner <rnk@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#644457}
-
A Olsen authored
install_attributes compilation unit is in chromeos/tpm. stub_install_attributes compilation was still in old location: chrome/browser/chromeos/settings. This moves the test stub to the same place as the code it stubs. The kDemoModeDomain constant is moved from demo_setup_controller to the cloud_policy_constants, since the install_attributes component cannot depend on demo_setup_controller. Apart from these two moves, nothing is changed. Bug: 836857 Change-Id: I36d56f108cc8a940af02b044f7f24d7582779801 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538417Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: A Olsen <olsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#644456}
-
Raul Tambre authored
The former non-overloaded variants are deprecated. This is a mechanical change; there is no intended behavior change. Bug: 929827 Change-Id: If447171aabcc7e9e53fd889d3f41e68f02f7065b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1456745Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Raul Tambre <raul@tambre.ee> Cr-Commit-Position: refs/heads/master@{#644455}
-
Ted Choc authored
This is causing the test to flake when ChromePublicTest is somehow getting set as the default. TBR=beverloo@chromium.org BUG=945961 Change-Id: I4ebcb88c98fce2d2f422e8e411cc5b0fbc05064f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539818Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#644454}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/b53068f358da..71c6104a1739 git log b53068f358da..71c6104a1739 --date=short --no-merges --format='%ad %ae %s' 2019-03-26 perezju@chromium.org [tracing] Delete some dead code in trace_data Created with: gclient setdep -r src/third_party/catapult@71c6104a1739 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:928278 TBR=sadrul@chromium.org Change-Id: Ic4d27c7397a919008b5220e066715366a69d2a98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539200Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#644453}
-
jdoerrie authored
This change implements FormFetcher::GetBlacklistedMatches() and modifies FormFetcher::GetNonFederatedMatches() to not return blacklisted entries anymore. Furthermore, it changes FormFetcher::Consumer's interface to simply notify consumers when the FormFetcher is done waiting. Bug: 945295 Change-Id: Ie353233339c9ae496bbe52a1ad0312d4973d60d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538400Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#644452}
-
Xing Liu authored
This CL fixed an issue that all downloads on Q with content URI are recognized as downloads on external SD card. Bug: 945615 Change-Id: I3ddfb3305359e05e8a38ed17a1d413f8ebb8a529 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539181Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#644451}
-
Mike Wittman authored
The result status is not currently used but will be required in order to integrate with the custom v8 unwinder, to distinguish between potentially-v8-unwindable state and non-unwindable state. Bug: 909957 Change-Id: I3a66202ece42579da60d506b4956cf2aafa5c1d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532995 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by:
Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#644450}
-
Kevin Bailey authored
We disabled the recording of the new keyword metrics fields in https://chromium-review.googlesource.com/c/1481732 due to the triggering of strange crashes and exceptions. We believe that this was caused by an uninitialized field - bool from_keyword - which has now been remedied. Bug: 837395 934316 Change-Id: I6a3a9fc9582bb1df5c2c4e4b0f72dca324b3c9b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539856Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#644449}
-
Mike Wittman authored
Refactors the cross-platform parts of the stack sampling into the new StackSamplerImpl implementation of the StackSampler interface. Platform-specific aspects of stack sampling are refactored into the ThreadDelegate/ThreadDelegateWin interface/implementation. Refactoring the Mac sampler to make use of StackSamplerImpl will be addressed in the next change. Bug: 931418 Change-Id: I204257fec31b23fc20c7beceddb81b3a38a9466d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530009 Auto-Submit: Mike Wittman <wittman@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
-
Peter Boström authored
git cl upload failed to upload these changes to the last CL, so my +2 landed the wrong patchset. By the time I noticed the change was already merged. Bug: chromium:943702 Change-Id: I8cd74c33f1e1e36e86188af9872f3a0e85039262 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534874 Commit-Queue: Peter Boström <pbos@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#644447}
-
Jan Wilken Dörrie authored
TBR=vasilii@chromium.org Bug: 914765 Change-Id: Id318bd708fd718ebbec0bcd3fad245155eec5e5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539999Reviewed-by:
-
Andrew Xu authored
AppListView's bounds are stored as the property called kVirtualKeyboardRestoreBoundsKey when the search box is activated in clamshell mode. When the tablet mode is turned on, this property is still kept in AppListView's native window. As a result, when closing the virtual keyboard in tablet mode, the native window's bounds are restored. It explains why we can see that AppListView is moved downward when dismissing the virtual keyboard. In tablet mode, AppListView should not be moved because of the virtual keyboard visibility. So in this CL, clear that property when tablet mode is turned on. Test: ash_unittests Bug: 944133 Change-Id: I714ebd50448a995f77bae759f6282efc8adc6df1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538983 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#644445}
-
Tom Anderson authored
BUG=None R=thakis Change-Id: Ia532f234cd5ae3017a17350c1f4738ebef62fbef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538573 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#644444}
-
Peter Kasting authored
This reverts commit 250c950a. Reason for revert: Timing out on all bots: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=external/wpt/event-timing/event-timing-onloadthenobserve.html&testType=webkit_layout_tests Original change's description: > Fix external/wpt/event-timing/event-timing-onloadobserve.html to be more deterministic > > This test passes as some events like click or mousedown for the first > click are missed at the second PerformanceObserver in startObserver. > This CL makes sure that the first PerformanceObserver does not proceed > until the first click event happens. > > Actually we found the test failed when we use a different task runner is > used for WidgetInputHandler (https://chromium-review.googlesource.com/c/chromium/src/+/1530492/4). > > Bug: 872081 > Change-Id: I8d8fe187b8053140f40ae9cf08737fcf7b64233c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538136 > Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> > Reviewed-by: Nicolás Peña Moreno <npm@chromium.org> > Reviewed-by: Alexander Timin <altimin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#644321} TBR=hajimehoshi@chromium.org,altimin@chromium.org,npm@chromium.org Change-Id: Ibb4e463906f5b8040e96c7e008e999c638630e79 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 872081 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540085Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#644443}
-
Alex Cooper authored
The logic for getting input was already pretty long, and it was only going to get longer with the switch to event based press events. So in preparation for that, this creates a helper class for input on WMR. Bug: 941772 Change-Id: I86641bbff105dfe43fbd087255dc6b040ba1126a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539100 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#644442}
-
James Cook authored
Per UI discussion in the bug, "Remove" is the suggested string. Use a new string in the .grd file for localization (in case there's a language that uses a different conjugation of "Remove" for "user" vs. other nouns). Bug: 766967 Test: manual, on device Change-Id: I99295e77d3df26b2c25dbdc4c8a0c4298817f078 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538597 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#644441}
-
Peter Kasting authored
This reverts commit 640f197a. Reason for revert: Broke compile: https://ci.chromium.org/p/chromium/builders/ci/Linux%20Builder%20%28dbg%29/150629 Original change's description: > Reland: Various refactoring in TabStripModel tests. > > This patch refactors tab_strip_model_unittest.cc and some associated > files in several ways: > * Removes ChromeRenderViewHostTestHarness as a superclass of > TabStripModelTest, which includes some heavyweight dependencies that > are unused. This speeds up the suite by about 20% (~6500 ms runtime > vs. ~8000ms before this patch). > * Changes TestTabStripModelDelegate::RunUnloadListenerBeforeClosing to > return false, and deletes subclasses that exist solely to override > that method (all of them, except TabStripDummyDelegate, which is > renamed to UnloadListenerTabStripModelDelegate). > * Moved several helper classes to be defined immediately before the > test that uses them. > * Deletes member variables from MockTabStripModelObserver, which are > unused. > * Fixes lint errors and cleans up unused includes. > > Change-Id: Ibb93ff41a21aab4c0b9b9f075df315381959c35c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538575 > Reviewed-by: François Doray <fdoray@chromium.org> > Reviewed-by: Erik Chen <erikchen@chromium.org> > Commit-Queue: Bret Sepulveda <bsep@chromium.org> > Cr-Commit-Position: refs/heads/master@{#644437} TBR=fdoray@chromium.org,erikchen@chromium.org,bsep@chromium.org Change-Id: I03d06c86649b56a22783189566a8797fd33464b2 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540067Reviewed-by:
-
Bret Sepulveda authored
Same idea as crrev.com/c/1529912, but we should probably have it for the other test class too. Change-Id: I1793f7b35dc31f81f4af52bd147f44f176d4fc6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539116Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#644439}
-
Gang Wu authored
******************************Resource Sizes Diff****************************** Specifics: +65,568 bytes main lib size +54,672 bytes main dex size +634,012 bytes secondary dex size +1,075,540 bytes normalized apk size InstallSize: +389,817 bytes APK size +1,195,577 bytes Estimated installed size (Android Go) +3,172,100 bytes Estimated installed size InstallBreakdown (+3,171,308 bytes): +4,018 bytes Native resources (no l10n) size +2,706 bytes unwind_cfi (dev and canary only) size +2,152 bytes Non-compiled Android resources size +65,568 bytes Native code size +625 bytes Package metadata size +3,079,199 bytes Java code size +17,040 bytes Compiled Android resources size Dex: +4,586 entries fields +6,760 entries methods +1,951 entries types +4,875 entries strings Binary-Size: Increase is due to library growth. Change-Id: I746bf136f82ef2c0a4269345008cfc7fc1c7c7c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536648Reviewed-by:Sky Malice <skym@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#644438}
-
Bret Sepulveda authored
This patch refactors tab_strip_model_unittest.cc and some associated files in several ways: * Removes ChromeRenderViewHostTestHarness as a superclass of TabStripModelTest, which includes some heavyweight dependencies that are unused. This speeds up the suite by about 20% (~6500 ms runtime vs. ~8000ms before this patch). * Changes TestTabStripModelDelegate::RunUnloadListenerBeforeClosing to return false, and deletes subclasses that exist solely to override that method (all of them, except TabStripDummyDelegate, which is renamed to UnloadListenerTabStripModelDelegate). * Moved several helper classes to be defined immediately before the test that uses them. * Deletes member variables from MockTabStripModelObserver, which are unused. * Fixes lint errors and cleans up unused includes. Change-Id: Ibb93ff41a21aab4c0b9b9f075df315381959c35c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538575Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#644437}
-
Reilly Grant authored
This change displays serial port permissions the user has granted to sites in chrome://settings/content/serialPorts. Bug: 908836 Change-Id: I49570dc785d6de395160ffbb4541e7203cda9357 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1453363 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#644436}
-
Kush Sinha authored
If SecondaryGoogleAccountSigninAllowed policy is set to false, it sets the kSecondaryGoogleAccountSigninAllowed preference to false. This should result in any existing Secondary Accounts in Chrome OS Account Manager being removed. Please check https://crbug.com/934492#c6 for a Design Document. Bug: 934492 Test: browser_tests --gtest_filter="*AccountManagerPolicyControllerTest*" Change-Id: Ib620a8347b9859dae0245957a0e240490d450545 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538185 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#644435}
-
Randy Rossi authored
Adding an AccessibilityStateChanged method to CastService so the browser process can notify any out-of-process (non chrome renderers) that need to know of that state change. Base implementation does nothing. ChromecastService will override this in a subsequent CL. Bug: None Change-Id: I4c85d7ec529906d11b9a469bda25d4fadc0ec5f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539790 Commit-Queue: Randy Rossi <rmrossi@chromium.org> Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Cr-Commit-Position: refs/heads/master@{#644434}
-
Niels Möller authored
Bug: webrtc:5876 Change-Id: I25baa7538e859b4e7e249fdb12ac07ee54767d1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539663 Auto-Submit: Niels Möller <nisse@chromium.org> Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Cr-Commit-Position: refs/heads/master@{#644433}
-
Eric Aleshire authored
Testing to see if the builder will work with the unit test target. Bug: 943883 Change-Id: Ia2f99adbaf515adfb3039a425a5b99878f976e40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538447Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: ericale <ericale@chromium.org> Cr-Commit-Position: refs/heads/master@{#644432}
-
Koji Ishii authored
The use here is for memory alloc performance, but since it has inline capacity of 64, it won't help when |size()| is O(n). Bug: 945671 Change-Id: I166e6615bcae5a814116ee1b6aaf0349405a67ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535507 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#644431}
-
Pedro Amaral authored
Disable apative toolbar when the grid tab switcher is enabled. Also don't enable adaptive toolbar if the bottom toolbar is not enabled. Bug: 944653 Change-Id: I0c6e7319dc130def60103286452f3fccd5e6ac48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536297Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Pedro Amaral <amaralp@chromium.org> Cr-Commit-Position: refs/heads/master@{#644430}
-
Edwin Joe authored
In MacOS, tab switch follows a different path than in Windows/Linux. It calls DelegatedFrameHost::WasShown when we are inside the call stack of NativeViewHostMac::AttachNativeView. This results in the check whether we have saved frames or not inside RWHVMac::WasUnOccluded to always return true since we have called DelegatedFrameHost::WasShown previously. This CL saves the saved frame condition before we call the first DelegatedFrameHost::WasShown in MacOS, and use this value to determine whether we have saved frames or not at a tab switch. Note that this might cause an upward spike in the MPArch.RWH_TabSwitchPaintDuration UMA metric since previously, it always record time as if we have saved frames, i.e. the presentation time for the delegated frame host. This CL will change that behavior to record time properly based on whether we have saved frames or not, which leads to a possible spike in the metric. Bug: 921120 Change-Id: If196665bb287a8b3e27ce24f4151ff88ae5f841f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538560 Commit-Queue: Edwin Joe <ejoe@google.com> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#644429}
-
Elly Fong-Jones authored
Bug: None Change-Id: I56ef7a820528dfe0ebdcd55eea2c5d59ad09a1ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538614 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Jared Saul <jsaul@google.com> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#644428}
-
John Rummell authored
Changes MediaDrmOriginIdManager so that if option kMediaDrmPreprovisioningAtStartup is enabled, it will attempt to pre-provision origin IDs after a 1 minute delay. This also registers MediaDrmOriginIdManagerFactory properly so that it is called during profile creation. BUG=942731 TEST=MediaDrmOriginIdManagerTest unit_tests pass Change-Id: Iad162b69a2bffecc52c02a352a55e1865eb2fd89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529854 Commit-Queue: John Rummell <jrummell@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
-
Eugene But authored
Commit placeholder navigation item if one is available. This CL fixes NativeContentVirtualURL if StorePendingItemInContext is enabled for slim-nav. Bug: 899827 Change-Id: I4f563d67bea1a5aa89e69d6cc3b2bff9415d254e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538555 Auto-Submit: Eugene But <eugenebut@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#644426}
-
Sunny Sachanandani authored
GPU.DirectComposition.DecodeSwapChainUsed UMA histogram was added a few days ago. We're seeing only ~8% of frames using decode swap chain, but we can't say if that's a good proportion of hardware decoded frames since we don't distinguish between software decoded frames which are always uploaded and blitted and hardware decoded frames which may or may not use a decode swap chain. We want to verify that a good proportion of hardware decoded frames use decode swap chain. Bug: 848093 Change-Id: I8ec443035f92f374bf5d7a24ea5e1a2cba0ff515 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534475 Auto-Submit: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#644425}
-
Daniel Bratell authored
MailboxHolder uses and exposes gpu/ipc/common/mailbox_holder_struct_traits.h so it needs to be a public dependency (as it already is in mailbox_holder_for_blink.typemap). One example of many resulting dependency errors: ERROR at //out/Default/gen/device/vr/public/mojom/isolated_xr_service.mojom-test-utils.cc:29:11: Can't include this header from here. ^-------------------------------------------- The target: //device/vr/public/mojom:mojom is including a file from the target: //gpu/ipc/common:struct_traits It's usually best to depend directly on the destination target. In some cases, the destination target is considered a subcomponent of an intermediate target. In this case, the intermediate target should depend publicly on the destination to forward the ability to include headers. Dependency chain (there may also be others): //device/vr/public/mojom:mojom --> //gpu/ipc/common:interfaces --[private]--> //gpu/ipc/common:struct_traits Bug: 938893 Change-Id: I598db331d43cff5212d7d739da96e0648552b7a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535859Reviewed-by:Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#644424}
-
Maksym Onufriienko authored
Do the same logging as test_runnner: - show flaky/failed tests in bot summary - display stacktrace for each failure and each attempt - removed xcodebuild command from bot summary - changed print -> logging For non_started_tests case add `Message` from ErrorSummaries The examples of log: https://ci.chromium.org/p/chromium/builders/try/ios12-sdk-simulator/241 https://ci.chromium.org/p/chromium/builders/try/ios12-sdk-simulator/249 Bug: 912323 Change-Id: Ie48cf020db31ff2229a1e5a5be05f1ed651a1c0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1495440Reviewed-by:
-
Victor Vasiliev authored
R=davidben@chromium.org Change-Id: I3355397b8742d159e8835e867f4c9b62f9e7abb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525000Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Cr-Commit-Position: refs/heads/master@{#644422}
-
