- 16 Sep, 2014 6 commits
-
-
isherman authored
BUG=412882 TEST=components_unittests R=tengs@chromium.org Review URL: https://codereview.chromium.org/562763004 Cr-Commit-Position: refs/heads/master@{#294939}
-
michaelpg authored
Metrics already exist but were never added to the inputs. R=stevenjb@chromium.org Review URL: https://codereview.chromium.org/571233002 Cr-Commit-Position: refs/heads/master@{#294938}
-
zmo authored
We figured out which part caused the problom, so these logs are no longer needed. BUG=393331 TEST=bots TBR=kbr@chromium.org Review URL: https://codereview.chromium.org/551803006 Cr-Commit-Position: refs/heads/master@{#294937}
-
semenzato authored
Program the NIC to wake-on-packet for packets arriving from the GCM server. Chrome notifies the connection manager (shill) by calling D-Bus methods. The return status indicates if the operation succeeded or not (depending on hardware support and the type of connection). Keywords: wowlan, wake-on-lan, wake-on-wlan BUG=360295 TEST=verified dbus methods are called, and packets are sent on the TEST=connection passed to the methods. Also verified that shill TEST=programs the NIC correctly, and packets wake up the device. Review URL: https://codereview.chromium.org/409883006 Cr-Commit-Position: refs/heads/master@{#294936}
-
gunsch authored
R=asvitkine@chromium.org,isherman@chromium.org BUG=404791 Review URL: https://codereview.chromium.org/523273003 Cr-Commit-Position: refs/heads/master@{#294935}
-
rockot authored
Revert of ash: Add checks for supervised users. (patchset #5 id:80001 of https://codereview.chromium.org/561713002/) Reason for revert: This is breaking NotificationApiTest.TestUserGesture, which assumes it starts with an empty notification list. Somehow this is causing the browser test to be in a state where there is already a notification in the list regarding a supervised user. Original issue's description: > ash: Add checks for supervised users. > > Propagate the user's supervised state to the ash system > so that it becomes available for views > > https://chromereviews.googleplex.com/79527013/ > > BUG=394417 > > Committed: https://crrev.com/8616ac4cf7bd77f53dc001eb9d8d61c6c975eaaa > Cr-Commit-Position: refs/heads/master@{#294821} TBR=antrim@chromium.org,derat@chromium.org,jennyz@chromium.org,bauerb@chromium.org,treib@chromium.org,merkulova@chromium.org NOTREECHECKS=true NOTRY=true BUG=394417 Review URL: https://codereview.chromium.org/575653002 Cr-Commit-Position: refs/heads/master@{#294934}
-
- 15 Sep, 2014 34 commits
-
-
Ken Rockot authored
This reverts commit f51d7453. The UI is breaking with certain extensions and users have no ability to work around this. Putting back behind a flag and trunk-only restriction. BUG=414497,474476 CC=jleichtling@chromium.org,amineer@chromium.org TBR=kalman@chromium.org,fsamuel@chromium.org Review URL: https://codereview.chromium.org/571213003 Cr-Commit-Position: refs/heads/master@{#294933}
-
Alpha Lam authored
* Changes the include order of YASM Default includes need to be put to the end for YASM. In particular there are several versions of x86inc.asm in the tree and libvpx requires its own version. This change in order allows libvpx to include its own version. * Roll libvpx to include BUILD.gn. libvpx now builds on x86 posix. R=brettw@chromium.org, scherkus@chromium.org, tomfinegan@chromium.org Review URL: https://codereview.chromium.org/535613002 Cr-Commit-Position: refs/heads/master@{#294932}
-
tapted authored
Otherwise keyed services see different profiles in unit_tests at different times since the incognito->GetOriginalProfile() changes. This is causing release code to pick up unnecessary workarounds to keep unit_tests green in try runs. The fix is achieved by adding `TestingProfile::Builder::BuildIncognito`, which differs from `Build` by requiring an |original_profile| argument, which will own the incognito profile (so no need to return scoped_ptr). This simplifies a lot of call sites, since they no longer need to do a scoped_ptr dance of their own. BUG=277296 Review URL: https://codereview.chromium.org/556173002 Cr-Commit-Position: refs/heads/master@{#294931}
-
dcheng authored
This patch was generated by running the rewrite_scoped_refptr clang tool on a ChromeOS build. BUG=110610 Review URL: https://codereview.chromium.org/568413004 Cr-Commit-Position: refs/heads/master@{#294930}
-
vmpstr authored
This patch adds a bit more information into traces in the activation path. BUG=414292 R=reveman@chromium.org Review URL: https://codereview.chromium.org/569413002 Cr-Commit-Position: refs/heads/master@{#294929}
-
miu authored
Removes the spammy warning message, and replaces it with a sanity- check that the queue has not grown past 10 seconds' worth of packets. If the sanity-check trips, a process crash dump will be sent to make us aware, via crash reports, that this is a problem in-the-wild. Review URL: https://codereview.chromium.org/539323002 Cr-Commit-Position: refs/heads/master@{#294928}
-
mohsen authored
Currently, when a scroll starts touch selection handles are hidden and then re-shown after scroll ends. But, if scroll ends in a fling, handles are not re-shown, because there hadn't been a way to determine end of the fling. Now that there is an IPC message notifying end of flings, we can re-show handles after a fling. BUG=413927 Review URL: https://codereview.chromium.org/569863003 Cr-Commit-Position: refs/heads/master@{#294927}
-
dnicoara authored
Related changes: - Created a DriWindowManager to keep track of the platform windows. These are then used to perform the bounds clipping for the cursor. - Moved delegate manager to DriWindowDelegateManager. In a follow-up CL the delegate manager in the browser process will be removed in favor of holing on to the DriWindowDelegates on the DriWindow. BUG=none NOTRY=true Review URL: https://codereview.chromium.org/556073003 Cr-Commit-Position: refs/heads/master@{#294926}
-
nduca authored
BUG=414162 TBR=dsinclair Review URL: https://codereview.chromium.org/577493002 Cr-Commit-Position: refs/heads/master@{#294925}
-
hansmuller authored
Replaced the test for validation of requests and responses with one that relies on the Connection et al classes to set up the validators and deliver messages. BUG=413303 Review URL: https://codereview.chromium.org/551293004 Cr-Commit-Position: refs/heads/master@{#294924}
-
dhnishi authored
Review URL: https://codereview.chromium.org/566863005 Cr-Commit-Position: refs/heads/master@{#294923}
-
dtseng authored
Modifications from upstream: - renamed class as it doesn't make much sense to test an "abstract" class. - made this into an E2E test so we can test against the real ChromeVox message strings and not have to fake out a lot of objects. Review URL: https://codereview.chromium.org/571643004 Cr-Commit-Position: refs/heads/master@{#294922}
-
dtu authored
Also catch 401 errors. BUG=None. TEST=None. Review URL: https://codereview.chromium.org/556003002 Cr-Commit-Position: refs/heads/master@{#294921}
-
wolenetz authored
This change adds frame processor tests to cover the behavior recently landed from bad1c509 that changed "segments" appendMode's partial front trimming logic. BUG=408216 R=dalecurtis@chromium.org TEST=new segments test fails before and passes after bad1c509, new sequence test passes before and after Review URL: https://codereview.chromium.org/567403004 Cr-Commit-Position: refs/heads/master@{#294920}
-
dcheng authored
This patch was generated by running the rewrite_scoped_refptr clang tool on a ChromeOS build. BUG=110610 Review URL: https://codereview.chromium.org/555253005 Cr-Commit-Position: refs/heads/master@{#294919}
-
jdduke authored
Tab.getWebContents() was using JNI to fetch the WebContents object. This is undesirable for several reasons, including performance impact and thread access consistency. Remove this and prefer redirecting the query to ContentViewcore.getWebContents() instead. This fix is a temporary workaround until all downstream test sites can be patched. BUG=398263,414445 TBR=tedchoc@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/571813003 Cr-Commit-Position: refs/heads/master@{#294918}
-
xzhang authored
NPEvent::lParam is defined as uintptr_t which has same width with ULONG on Win32, but they are of different sizes on WIN64. uintptr_t is 8-byte long, while ULONG is still 4-byte long, so it corrupts a 64-bit pointer if casting it to a 32-bit type. BUG=413535 TEST=square.html (attached in the bug), http://pbskids.org/video (it uses wmode="opaque") R=ananta@chromium.org, bauerb@chromium.org Review URL: https://codereview.chromium.org/571583002 Cr-Commit-Position: refs/heads/master@{#294917}
-
chirantan authored
If RendererFreezer::SuspendImminent was called multiple times before it had a chance to report readiness, it would post multiple tasks to do so on the current message loop. However the callback to report readiness would be cleared after the first task ran and would cause a crash when the next task tried to run it. Fix this by not posting new tasks while a callback is pending and just update the callback instead. BUG=414396 Signed-off-by:
Chirantan Ekbote <chirantan@chromium.org> Review URL: https://codereview.chromium.org/550093004 Cr-Commit-Position: refs/heads/master@{#294916}
-
dtu authored
With the current sharding strategy (random), having smaller suites will reduce cycle time. The Android bots will automatically pick up this config change. If we want to do the desktop bots too, that'd require a master restart. BUG=396001 TEST=None. R=tonyg Review URL: https://codereview.chromium.org/566773003 Cr-Commit-Position: refs/heads/master@{#294915}
-
scottmg authored
R=jam@chromium.org BUG=406457 Review URL: https://codereview.chromium.org/571133003 Cr-Commit-Position: refs/heads/master@{#294914}
-
mseaborn authored
This pulls in the following Native Client changes: r13747: (dschuff) Fix toolchain build and sandboxed translation tests on FYI bots r13748: (thakis) Pass -std=gnu++0x in build_nexe.py. BUG=none TEST=browser_tests and nacl_integration CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_rel_precise32,linux_arm_cross_compile,linux_nacl_sdk,linux_chromium_dbg Review URL: https://codereview.chromium.org/571053004 Cr-Commit-Position: refs/heads/master@{#294913}
-
guoweis authored
which prevent grouping mechanism in MergeNetworkList from working. The end result is that each Network after MergeNetworkList contains only 1 ip address. With this change, the grouping will happen correctly. WebRTC has logic to only retrieve single IP from each network for connectivity check already. This CL is a dup of https://codereview.chromium.org/536133003/ which was created under the wrong identity. BUG= Review URL: https://codereview.chromium.org/565773003 Cr-Commit-Position: refs/heads/master@{#294912}
-
mef authored
Remove stale ChromiumAsyncUrlRequest.java as it is replaced by CronetUrlRequest.java as of https://codereview.chromium.org/520093002/. BUG=409926 TBR=mmenke@chromium.org Review URL: https://codereview.chromium.org/569713003 Cr-Commit-Position: refs/heads/master@{#294911}
-
mtklein authored
CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg BUG= Review URL: https://codereview.chromium.org/575493002 Cr-Commit-Position: refs/heads/master@{#294910}
-
dcheng authored
This patch was generated by running the rewrite_scoped_refptr clang tool on a ChromeOS build. BUG=110610 Review URL: https://codereview.chromium.org/567763003 Cr-Commit-Position: refs/heads/master@{#294909}
-
miletus authored
When changing from software mirroring mode to sinlge display mode, it is possible there is no need to update |displays_| and we early out UpdateDisplays(). But we still want to run the PostDisplayConfigurationChange() cause there are some clients need to act on this, e.g. TouchTransformerController needs to adjust the TouchTransformer when switching from dual displays to single display. BUG=chrome-os-partner:31868 TEST=tested on Big, after existing software mirroring mode, the touch location transformation is still correct. TBR=oshima@chromium.org Review URL: https://codereview.chromium.org/551073005 Cr-Commit-Position: refs/heads/master@{#294908}
-
abarth authored
Previously, mojo_variables.gypi hard-coded a DEPTH of 1, which meant that only GYP files that were directly in folders in the root could use it. After this CL, GYP files at any depth of the tree can use it. R=jamesr@chromium.org Review URL: https://codereview.chromium.org/561233004 Cr-Commit-Position: refs/heads/master@{#294907}
-
blink-deps-roller authored
https://chromium.googlesource.com/chromium/blink/+log/01025b523bac1a59fa91a10d5d49f969ed24000d..1d4eb25ceba65e3e78786bce1251dc248d20af19 TBR=loislo@chromium.org,dpranke@chromium.org Review URL: https://codereview.chromium.org/573883002 Cr-Commit-Position: refs/heads/master@{#294906}
-
skia-deps-roller authored
https://skia.googlesource.com/skia/+log/595aa05efcb504e85358b8d328ac4a9fa1c46e2e..f0ddf33f1954489d45e4f2d9c8712eac60539c65 CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg TBR=stephana@google.com Review URL: https://codereview.chromium.org/571193003 Cr-Commit-Position: refs/heads/master@{#294905}
-
dcheng authored
This patch was generated by running the rewrite_scoped_refptr clang tool on a ChromeOS build. BUG=110610 Review URL: https://codereview.chromium.org/564043004 Cr-Commit-Position: refs/heads/master@{#294904}
-
dcheng authored
This patch was generated by running the rewrite_scoped_refptr clang tool on a ChromeOS build. BUG=110610 Review URL: https://codereview.chromium.org/573863002 Cr-Commit-Position: refs/heads/master@{#294903}
-
danakj authored
This parameter is not used with impl-side painting, and blink is the only embedder of blink that sets this value. Since blink is always impl-side painting now, we can just remove it. R=nduca, vmpstr BUG=413479 Review URL: https://codereview.chromium.org/565043002 Cr-Commit-Position: refs/heads/master@{#294902}
-
xiyuan authored
- Add code to add/remove/get cryptohome keys for Easy sign-in; - Add an EasyUnlockKeyManager to wrap the operations and provide an API; - Re-create crypthome keys with pairing data in user prefs on user sign-in; BUG=394640,394641 Review URL: https://codereview.chromium.org/554043003 Cr-Commit-Position: refs/heads/master@{#294901}
-
Steven Bennetts authored
Updates https://codereview.chromium.org/543493002 for latest version if internet_detail.js BUG=393873 R=vitalyp@chromium.org Review URL: https://codereview.chromium.org/568413003 Cr-Commit-Position: refs/heads/master@{#294900}
-