- 22 Jan, 2020 40 commits
-
-
Benoît Lizé authored
On Windows, the exception record can contain extra data. This is already used to record the size of the failed allocation for some allocators in a way which is easily accessible in crash reports, but PartitionAlloc does not make use of it. This CL adds support in PartitionAlloc for this feature, and unifies OOM handling somewhat. For instance, we no longer have 2 distinct ways to crash, one which records the size, and one which doesn't. Also a few cosmetic changes: - gOomHandlingFunction -> g_oom_handling_function - Fix a few "git cl lint" warnings. - A typo Bug: 983348 Change-Id: I0e13b2d6a6c41d8be6a57c81d969d8476ef256ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988349 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Cr-Commit-Position: refs/heads/master@{#733968}
-
Bence Béky authored
Add four header files that are included from files already in BUILD.gn. After this change, every *.h, *.cc, and *.inc in QUICHE is listed in BUILD.gn other than common_cert_set_[23][ab].inc, quic_interval_deque_test.cc, and the entire quic/qbone subdirectory. Change-Id: Ic90e50a88f69a3be0e59b350915abd99017ac64a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011061 Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#733967}
-
chrome://killFergal Daly authored
https://crrev.com/c/2006890 will reland a CL that broke this. This test "correctly" fails when patched onto f4c4a4aa however it passes when patched onto the reland. Manual testing of the reland also does not trigger the bug, so I guess something changed but having an automated regression test seems wise. Bug: 981339, 993701 Change-Id: I048868e3181f9c3b0c856ce8553226fe29acc696 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011585 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#733966}
-
vitaliii authored
This way it can be later extended easier (e.g. tag number space is separate from outer SharingMessageSpecifics) and also passed as an argument in C++ code. This is the first step to start building SharingMessageSpecifics in the bridge instead of doing this in Sharing code. Changing tag numbers in the proto is fine, because a) it is not used anywhere yet b) it is not persisted anywhere anyway. Bug: 1044537 Change-Id: I4201680cfd8149888efbc35da6fbb5a7969f436a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013246 Auto-Submit: vitaliii <vitaliii@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#733965}
-
Emily Stark authored
https://chromium-review.googlesource.com/c/chromium/src/+/2006473/ introduced new tests for redirects that lead to error pages. These tests used custom request handlers to serve the redirects, since I didn't know that there were default EmbeddedTestServer handlers for 307 redirects. This CL simplifies the tests to use the default handlers instead. Bug: 1041597 Change-Id: I8377bd25d5890bf6c8c77ce2ca06e9b1a999935f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013342 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
-
Peter Marshall authored
When a worker is stuck in JS when we call AttachDevToolsSession, the the call won't go through until JS execution finishes as there is no interrupting mechanism (equivalent to io_session) at the Agent level. This CL adds different behaviour to DevToolsAgent for the worker and non-worker cases. Non-workers now use the IO thread to dispatch calls from the browser over the DevToolsAgent mojo interface. This is similar to how IOSession works and achieves the same results. We also send all protocol messages on IOSession for workers. We can't do this for non-workers as they need to have an ordering guarantee with page navigation. This is done through using associated mojo channels for Session, Agent and FrameNavigationControl. We don't associate the mojo channel for workers though. Bug: 1010534 Change-Id: Id6b3d2ee0cf86f1a0b046b4e59ec1851ca07d7eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951003Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#733963}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/564dcf4c071b..13f30b96a857 git log 564dcf4c071b..13f30b96a857 --date=short --first-parent --format='%ad %ae %s' 2020-01-22 sigurds@chromium.org [coverage] Use timestamps provided by the back-end for coverage 2020-01-22 aerotwist@chromium.org Revert "Fix typescript compilation with ts_library" 2020-01-22 mjackson@microsoft.com Fix NodeJS Logo URI reference 2020-01-22 mjackson@microsoft.com Fix broken Node Connection Panel. 2020-01-22 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@13f30b96a857 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1011811,chromium:1022031,chromium:1042927 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I4c10c8879f7f51a877c39a5fdbd7837960972914 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013837Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#733962}
-
Anatoliy Potapchuk authored
Function calls in OnStart{Web|Arc}Kiosk are identical to OnStartAppLaunch. Let's remove them. Bug: 1043663 Change-Id: I9f748f4d32374eb9cc622dd6ca80e8375c29c745 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011838 Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#733961}
-
Anatoliy Potapchuk authored
Here we remove redundant ArcKioskSplashScreen, which had the same functionality as AppLaunchSplashScreen, which ArcKioskController is now using. Also, now the splash screen of the arc kiosk properly displays the data about the app. Also, this CL fixes a bug about not properly caching the title and the icon of the arc kiosk app. Bug: 1043663 Change-Id: I81c6a30021097041bd55a3a7182943fe9f93f3e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007824 Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#733960}
-
Johannes Kron authored
Bug: chromium:1011581 Change-Id: I12cc31309f896f6a00802adb5cb1991f8db9b342 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007209 Commit-Queue: Johannes Kron <kron@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#733959}
-
Tim van der Lippe authored
In https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2011080 the `detectColorFormat` is moved onto Common.Settings instead. Bug: 1011811 Change-Id: Ib43aa4774793c307f897f7992ac46273f949b694 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013042 Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Paul Lewis <aerotwist@chromium.org> Reviewed-by:
Paul Lewis <aerotwist@chromium.org> Cr-Commit-Position: refs/heads/master@{#733958}
-
Isabella Scalzi authored
Bug: 1038799 Change-Id: Ic1254bd4b91d3d801f7021cfe157fd1e581d9d9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014219 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#733957}
-
Stepan Khapugin authored
Removes pre-HL popup classes. Bug: 943521 Change-Id: Ife98510b8d0142df487d7aef0fab08494ab2cdf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007569 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#733956}
-
Oriol Brufau authored
The test used to only check for the Firefox behavior, but the spec also allows the Chromium one. So I fixed it in https://bugzil.la/1605349, now it also passes in Chromium. BUG=457718 Change-Id: I5d2378de7cf370db8087558b7f76e4c28f354ba1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012942 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Auto-Submit: Oriol Brufau <obrufau@igalia.com> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#733955}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/49d180876100..52524c03db2f Created with: gclient setdep -r src-internal@52524c03db2f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I6345025ad0c601550a01f657cb30e7b51b797f8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013836Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#733954}
-
Yuki Tsuchiya authored
This commit enables to support MPEG-H 3D Audio bitstream pass-through via ffmpeg for Cast products. To build this code, it is required to merge latest ffmpeg code which contains following commits. https://git.ffmpeg.org/gitweb/ffmpeg.git/commit/610473b9679bfd3aff56c6889927447da860beb1 https://git.ffmpeg.org/gitweb/ffmpeg.git/commit/30047b6a571daa0fbdfa4eb4d907e510ab56ca3f https://git.ffmpeg.org/gitweb/ffmpeg.git/commit/632b8298b70969f6ab43509fd276b33295d9e336 MPEG-H 3D Audio pass-through with MSE was supported in https://chromium-review.googlesource.com/c/chromium/src/+/1011291 Change-Id: I43bf1cb1d73dc90be7e40dc2f0d1f5c49263cb15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930369Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Yuki Tsuchiya <yuki.tsuchiya@sony.com> Cr-Commit-Position: refs/heads/master@{#733953}
-
Varun Varada authored
This commit allows a Blink web test to pass that is dependent on some DevTools code that is changed by this CL: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1983391 Bug: chromium:1983391 Change-Id: I3cfb51b34335a28db49d14cb723398b18df44002 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987200 Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#733952}
-
Bence Béky authored
https://quiche.googlesource.com/quiche.git/+log/57425e34e9f5..dfabdfb6884b $ git log 57425e34e..dfabdfb68 --date=short --no-merges --format='%ad %ae %s' 2020-01-17 bnc Add HTTP/3 error codes, use them in HttpDecoder and for unexpected frames in QuicSpdyStream and QuicReceiveControlStream. 2020-01-17 dschinazi Bring back the ParsedQuicVersionIsValid DCHECK 2020-01-17 wub gfe-relnote: (n/a) For test BbrSenderTest.SimpleTransfer2RTTAggregationBytes, relax the expectation on sender-measured min_rtt. Test only. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Also update flag values and remove deprecated flags. Change-Id: Idff4cc42eef7af45d338e5272a02751b5e2f1a7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010929 Auto-Submit: Bence Béky <bnc@chromium.org> Reviewed-by:
-
Hitoshi Yoshida authored
Bug: 839389 Change-Id: If742316b3acfca5e36268ff0ceeb6eeee6aa5d83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012376Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#733950}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/06df1e1c4655..402379f1f35c git log 06df1e1c4655..402379f1f35c --date=short --first-parent --format='%ad %ae %s' 2020-01-22 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 3f2a66df..c565cfe6 (733758:733868) 2020-01-21 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 9a18a2d9..3f2a66df (733613:733758) Created with: gclient setdep -r src/third_party/webrtc@402379f1f35c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I8a74d44d8e342b0af696f5c074c718f1261555f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014307Reviewed-by:
-
Ewann authored
user actions: -Adds MobileDownloadFolderUIShownFromDownloadManager -Adds MobileDownloadFolderUIShownFromToolsMenu Bug: 1013572 Change-Id: Iee1697a330b37c0ca5501928f01a25ca17062140 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970993Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Cr-Commit-Position: refs/heads/master@{#733948}
-
Hitoshi Yoshida authored
Bug: 839389 Change-Id: I916e7fa8ec6e39a3637090aaef3a24b4c45dcf57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012361Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/323a81fc5e30..ab7ac60f14ae git log 323a81fc5e30..ab7ac60f14ae --date=short --first-parent --format='%ad %ae %s' 2020-01-21 afdx@google.com spirv-fuzz: Refactoring and type-related fixes (#3144) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@ab7ac60f14ae If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Bug: None Tbr: radial-bots+chrome-roll@google.com,timvp@google.com Change-Id: Iaf7af4793353a44c9d771844c31799f373637206 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013831Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/8c396a9cc4a8..1eb0ddb4d0c3 git log 8c396a9cc4a8..1eb0ddb4d0c3 --date=short --first-parent --format='%ad %ae %s' 2020-01-22 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/spirv-tools/src 323a81fc5e30..ab7ac60f14ae (1 commits) Created with: gclient setdep -r src/third_party/angle@1eb0ddb4d0c3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: timvp@google.com Change-Id: I8c101c4cfe45debc0a55a33e11b6c91785732eaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013832Reviewed-by:
-
henrika authored
We would really like to keep this histogram since it is used on a regular basis when tracking down audio issues in WebRTC-based real-time clients. Bug: 1037591 Change-Id: I9b2ca5a9f5c3eeda972d11bc1e1e2c8c7b47ddad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010990Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Henrik Andreasson <henrika@chromium.org> Cr-Commit-Position: refs/heads/master@{#733944}
-
Mike West authored
After https://chromium-review.googlesource.com/c/chromium/src/+/1982549, we treat cookies with neither names nor values as invalid. This patch adjusts `ParsedCookie::SetName()` and `ParsedCookie::SetValue()` to ensure that a `ParsedCookie` can't be modified into an invalid cookie. It also applies the rule to `CanonicalCookie::CreateSanitizedCookie` to ensure that code path has the same restrictions. Bug: 1040296 Change-Id: I1e57c3ee8a4f6dc222c35d6e9844928c1ba7fb06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993962 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#733943}
-
Kinuko Yasuda authored
This was moved from services/network but fixing namespace was put off for a follow-up (and forgotten) Bug: 934009 Change-Id: I33ebbf2c4b38a1ee43dd33b25f24784b2fc6e794 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012372Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#733942}
-
Himanshu Jaju authored
Integrates network traversal API to fetch stun and turn servers for webrtc p2p connection. Handles API failure by returning a list of public Google stun servers as a fallback. Bug: 1031156 Change-Id: I60b5d6ccdb749ce9375bcb3333dc2cbdab62aa18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994295 Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#733941}
-
Tomasz Dobrowolski authored
Set SSO credential error as general error instead of credential error, which displays error under username/password and is invisible in SSO. Reset error state after changing authentication method. Bug: 1038896 Change-Id: I27fcd9b3eb4e045f2e37de9c76ae932a59b7305c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978687 Commit-Queue: Tomasz Dobrowolski <tomdobro@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Anand Mistry <amistry@chromium.org> Auto-Submit: Tomasz Dobrowolski <tomdobro@chromium.org> Cr-Commit-Position: refs/heads/master@{#733940}
-
Yoshifumi Inoue authored
This patch changes |NGFragmentItem::DebugName()| to return as |NGPaintFragment::DebugName()| to get identical output for paint invalidation test (|internals.layerTreeAsText()|) for ease of managing flag specific test expectations, e.g. reducing rebaseline. Following 9 tests are passed: * paint/invalidation/selection/invalidation-rect-includes-newline-for-rtl.html * paint/invalidation/selection/invalidation-rect-includes-newline-for-vertical-lr.html * paint/invalidation/selection/invalidation-rect-includes-newline-for-vertical-rl.html * paint/invalidation/selection/invalidation-rect-includes-newline.html * paint/invalidation/selection/japanese-rl-selection-clear.html * paint/invalidation/selection/selection-partial-invalidation-between-blocks.html * paint/invalidation/selection/selection-rl.html * paint/invalidation/selection/selection-within-composited-scroller.html * paint/invalidation/selection/text-selection-rect-in-overflow.html Bug: 982194 Change-Id: Ib35d1e6e8f944209a5752a5f7c7ded5151bdf752 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014353 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#733939}
-
Anqing Zhao authored
The DeviceStatusReportRequest need be extended to include additional information about crash reports. Bug: 1040078 Change-Id: Id02c768805e23477a8ee7f05c15acd790855f723 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991483 Commit-Queue: Anqing Zhao <anqing@google.com> Reviewed-by:
-
Tobias Sargeant authored
This has the combined effect of breaking out the core uploading code in MinidumpUploadCallable into MinidumpUploader, which can be used separately. Management of file renaming still remains split over multiple classes. MinidumpUploadCallable tests are split to reflect the new code organization. Bug: 1029724 Test: run_chrome_public_test_apk \ Test: -f 'org.chromium.components.minidump_uploader.*#*' Test: run_chrome_public_test_apk \ Test: -f 'org.chromium.chrome.browser.crash.*#*' Test: run_webview_instrumentation_test_apk \ Test: -f 'org.chromium.android_webview.test.services.MinidumpUploadJobTest#*' Change-Id: I0a8d7f8ad330d0127f7ce8559bd8090da6d44abe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975918Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/heads/master@{#733937}
-
Clemens Backes authored
IndexedDB support for WebAssembly is removed since a long time, but there are still flags and helpers related to that. This CL removes them. R=haraken@chromium.org Bug: v8:10146 Change-Id: I4a6f2f0896ba370af3807a6225b25c6b11c7e12b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013046Reviewed-by:
-
Fredrik Söderquist authored
For the cases where an Image has already been extracted from the ImageResourceContent, call Image::Size(...) directly rather than calling ImageResourceContent::IntrinsicSize since the latter only adds a null- check. De-duplicate ImageElementBase::DefaultDestinationSize() since it is identical to ImageElementBase::ElementSize(). In ImageResourceContent::GetCompressionFormat(), there's no need to use the Image::Size overload that takes a RespectImageOrientationEnum since we only need to compute the area of the image - which is the same regardless of orientation. Bug: 773272 Change-Id: I9395ce9304827917d97d6e3cab209f09b4645b2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010776Reviewed-by:
-
Eriko Kurimoto authored
This CL only changes the comment. script_type_ is not used for fetching the top-level worker script. Only credentials_mode_ parameter is used for it. Bug: n/a TBR: falken@ Change-Id: Iefa3f09496ceb88d36a6a209e90203bbd653222d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012374 Commit-Queue: Eriko Kurimoto <elkurin@google.com> Reviewed-by:
-
Pâris MEULEMAN authored
[1] was flaky given sporadic timeouts occurring on Win7. This test is slow as it needs to reach the call stack size limit and then execute some code in each call frame. This marks the test as Slow which should give the test enough time to always complete. Bug: 937546 Change-Id: I450003c435c1a6856c0461c11995ff63f9988de9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012946 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 57093a57. With Chromium commits locally applied on WPT: 0f8fd66b "[WPT/common/security-features] Support sub projects and split referrer-policy 4K tests" 1d0a2056 "Remove error.message in SharedWorker WPT" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: mkwst@chromium.org: external/wpt/cookies NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: I1f18b5d7902c45956bcdba23ea7dbe6de042fa75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014460Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#733932}
-
Anatoliy Potapchuk authored
During profile initialization, we have do a early exit for all kiosk types. Every kiosk separately inits CrOS prefs and keyboardcontroller, but ArcKiosk. This CL fixes that. Bug: 1040742, 1040744 Change-Id: Ic140d76fd12182dccd6decc239787e812abd1686 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011100Reviewed-by:
-
Sylvain Defresne authored
Instead of forward declaring ChromeBrowserState in the ios namespace, use a header. This will allow moving the class to the global namespace without having to change all the forward declaration at the same time. This CL was uploaded by git cl split. R=jianli@chromium.org Bug: 1042208 Change-Id: Iacbce9f831abd0f470636ce16fd153e8e669f5c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007584 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Jian Li <jianli@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#733930}
-
Mario Sanchez Prada authored
Add a new method to blink::mojom::LocalFrameHost interface, to be implemented right from RFHI, which will allow us to remove the WebLocalFrameClient::DispatchLoad() API plus the related bits under //content/renderer. Bug: 1008432 Change-Id: I047cc905c52d9f6a91414190b91c61a83bb48d4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000708Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
-
