- 20 Nov, 2020 40 commits
-
-
Martin Kreichgauer authored
This is a reland of ee2f8113 Changes: - renamed virtualAuthenticatorTest to virtualAuthenticatorPromiseTest - made virtualAuthenticatorPromise test return |testCb()| which fixes the race that caused the original change to be reverted. Original change's description: > webauthn: move create credential tests for residentKey/credProps to WPT > > Bug: 1117630 > Change-Id: I2fa4d73b7a4cfe5e7f19fd835cb32e1bb4926d2f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508878 > Reviewed-by: Nina Satragno <nsatragno@chromium.org> > Commit-Queue: Martin Kreichgauer <martinkr@google.com> > Cr-Commit-Position: refs/heads/master@{#825930} Bug: 1117630 Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel Change-Id: I08cb469ab937a704c23da30b7120374d31ecbff5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548299 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#829793}
-
Ryan Sturm authored
JS is a key factor in understanding when the page loads, so clietns who do not allow JS to run (overall or on the DSE) should not get prefetch behavior at all. Bug: 1151134 Change-Id: I51005f5453d9bb14bd54fe0885c446b0e97581e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551625 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#829792}
-
Patrick Monette authored
This class submits a USER_VISIBLE vote when a frame is visible. This class will first be used in in https://chromium-review.googlesource.com/c/chromium/src/+/2538310. Bug: 971272 Change-Id: I4462efab6c105e2ecd7f4cfbf479f3627ac9aa56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537143 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#829791}
-
rajendrant authored
The LitePages robots rules fetcher sends the origin in "u" request parameter. Instead the full robots.txt URL should be sent in that parameter. Bug: 1147565 Change-Id: I0df86b28d1c4a8ee7d9053b2040f3941d894b9be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552577Reviewed-by:
-
Ryan Sturm authored
This checks that the search prefetch can only be served to main frame navigations. Bug: 1148512 Change-Id: Idd26f0fc3b81bf9114990e60f53eb532dbeb4a0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551746 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
-
David Van Cleve authored
This comment-only change removes a duplicated 'ERR_' from a comment in URLLoaderCompletionStatus. R=mmenke Bug: None Change-Id: Ibd2a315ddf9a0a08a3c4ea99ce134c23a0435ad6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552573 Commit-Queue: David Van Cleve <davidvc@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Auto-Submit: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#829788}
-
Rob Buis authored
Only accept operators with inline children since ::first-letter selector could add a non-inline child, in that case fall back to block layout algorithm. Bug: 1146872 Change-Id: I848ab24089a98a26f881c4f2c3f396932a62506a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539966Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Frédéric Wang <fwang@igalia.com> Commit-Queue: Rob Buis <rbuis@igalia.com> Cr-Commit-Position: refs/heads/master@{#829787}
-
Ian Kilpatrick authored
This reverts commit 8ebfa3e7. Reason for revert: Caused https://bugs.chromium.org/p/chromium/issues/detail?id=1150774 This has subsequently been fixed by moving the layout overflow calculations into NG, however if we need to disable this new pass I'd prefer to not break any content in M89/M88. Original change's description: > [LayoutNG] Avoid computing overflow for positioned elements twice > > In LayoutNG the overflow of positioned elements is already computed in > LayoutNGBlockFlowMixin<Base>::AddLayoutOverflowFromChildren(), > so we don't need to compute it again in the legacy code. > > Specifically positioned elements are already considered in > NGPhysicalBoxFragment::ScrollableOverflowFromChildren(). > > BUG=1098231 > > Change-Id: I8e527617ae31ef564eeea57eb823ca93465cf62b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391256 > Commit-Queue: Manuel Rego <rego@igalia.com> > Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#809272} TBR=rego@igalia.com,ikilpatrick@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1098231, 1150774 Change-Id: I7d1345cdc12c63dd122e3daab929b9398702cdfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552296Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#829786}
-
adoneria authored
Bug: 1151436 Change-Id: I6e5836927a2367f2220093bda579ee436417bd49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552882Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Anjali Doneria <adoneria@google.com> Cr-Commit-Position: refs/heads/master@{#829785}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/8dae1eb937cb..a63f1abf172a 2020-11-20 miu@chromium.org Implement a more-specific AppAgent::IsConnectionAllowed() policy. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I3a873d3bdf619d8b927cba713b88320060d96b35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552823Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#829784}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/94b2c943..8a682e08 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I087edc79426e22548a7c7d7527591ff255a5d760 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552743Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#829783}
-
Frank Liberato authored
Due to what appears to be framework bugs, android sometimes calls back on the UI thread when tearing down Dialog-based video overlays. Since they should run on a separate thread, this causes the framework to issue strict mode violations / other bad things. This CL moves overlays to the browser UI thread, so this no longer is a problem. As part of this, it introduces a sync call on the browser UI thread when the Dialog is lost after we have provided a Surface to the client, since we must (by Android API) quit using the Surface once surfaceDestroyed is sent by the framework. Bug: 1148995 Change-Id: I96237a7c5852837f2d9cb7f5e57908f267de7b25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545773Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#829782}
-
Chris Sharp authored
Change-Id: Ic02543fcb182325269bacc00cb79e389471a0215 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551489Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#829781}
-
Kyle Milka authored
Make 3P app icons larger. Rework the padding for all share sheet items so the tap target takes up the entire height. https://screenshot.googleplex.com/DwKgdDxahoETPCz.png Bug: 1148914 Change-Id: I78524a78aa0350552860404082616cbf3891e228 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542728Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#829780}
-
Omar Morsi authored
Add a special case for public_slot==system_slot in GetKeyLocations. After the system slot is ready, SystemTokenCertDbInitializer creates an NSSCertDatabase instance to be used as a wrapper for the system slot. SystemTokenCertDbInitializer initializes the public slot of the created NSSCertDatabase to be the same as the system slot just as a dummy value because NSSCertDatabase expects public_slot to not be nullptr. This introduced a problem while trying to retrieve key locations on login screen, because on login screen, the NSSCertDatabase instance initialized by SystemTokenCertDbInitializer is used in PlatformKeysService. Bug: 1150973 Change-Id: I58a7f968bd688ad118eb58431dad6c74a2cf4513 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550643 Commit-Queue: Omar Morsi <omorsi@google.com> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#829779}
-
John Abd-El-Malek authored
Bug: 1147533 Change-Id: I47353963624662f5b09c3be7db314effb0aa75c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545368Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#829778}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: Ib54db2306b8e91457f029254a63482fd3365373a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552239Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#829777}
-
Tanya Gupta authored
Finished logic to call PaintPreviewBaseService to generate bitmap and added support for deletion of all long screenshot files. Bug: 1142520 Change-Id: Ic188e5b2b5bcdb11e188a997d9de67972d6e0dd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550177Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Kyle Milka <kmilka@chromium.org> Commit-Queue: Tanya Gupta <tgupta@chromium.org> Cr-Commit-Position: refs/heads/master@{#829776}
-
Ehimare Okoyomon authored
Screenshot: crbug.com/1140475#c3 Bug: 1140475, 1077766 Change-Id: I126df572f323fc1f763de0b5806355a4766892c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550794 Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#829775}
-
Joe Downing authored
This CL adds a new string and host message which will be used to log host output to the Windows event log as part of our work to increase debugability. Since this new message has no localizable components, I'm adding a tag to skip the screenshot requirement. Note that adding a new message requires updating a number of static files in third_party. Bug: 1144185 Change-Id: I9d940b94ba0bb3bef32602cec97fdf1c57911184 Skip-Translation-Screenshots-Check: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542547Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#829774}
-
Wenbin Zhang authored
This CL allow perf_benchmark to check for available possible_browser before it tries to find one. This is the second step of the fix for crbug/1149275#c6 Bug: chromium:1149275 Change-Id: Ifb771363ba73d4d5cb83e58ba1e8e1f703ed182a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550180 Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#829773}
-
Alison Maher authored
Forced colors should now happen at used value time. This change adds an internal property to store the forced colors value of background-color. This internal value is then applied to the visited /unvisited background-color at used value time when appropriate. The other forced color properties will be moved in follow up changes. Bug: 970285 Change-Id: I96f00e7ab1a595c4aed6c859dcba78bea476fb9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509029Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#829772}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1605873573-9397db153d32d8ff4c4f46949924e1cd67fa6977.profdata to chrome-linux-master-1605895128-ea3f86e674d4361d5284b25de8910e19181b674b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Id26fe3ba831edd31cb69c75c8db295d1f7ab109a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552669Reviewed-by:
-
Ben Joyce authored
This basically removes: https://chromium-review.googlesource.com/c/chromium/src/+/2493822 Bug: 1138506 Change-Id: I17eeea4d7e54cb867529f89afdd45f0f7fe60a0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530349Reviewed-by:
Haiyang Pan <hypan@google.com> Commit-Queue: benjamin joyce <bjoyce@chromium.org> Cr-Commit-Position: refs/heads/master@{#829770}
-
Mirko Bonadei authored
These bots have been switched to the hermetic mac toolchain by https://chromium-review.googlesource.com/c/chromium/tools/build/+/2550659. Bug: webrtc:12212 Change-Id: I03c935e625611cfb9e5f3abbb110d6b3eca7cd16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552585Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#829769}
-
Xinghui Lu authored
Bug: 1150713 Change-Id: Ibffa010d24ff74fae1640e2c8becfbcf58e47acf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552237Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#829768}
-
Azeem Arshad authored
+ Fixed issue with pending profile check in Enable and Disable methods. + Moved TestObserver to separate file. + Moved common test setup and teardown into ESimTestBase class. + Moved common utility functions to esim_test_utils.cc. + Added tests for Euicc and ESimProfile classes. These tests were mostly copied from previous esim_manager test with minor changes. Bug: 1093185 Change-Id: I669fb613f567c53837104778f3714c3e5a591344 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545687 Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#829767}
-
Mingjing Zhang authored
The test virtual/android/fullscreen/video-scrolled-iframe.html is already marked Slow but still has flaky timeout failures on Linux SkiaRenderer Vulkan. Mark as Timeout Pass to suppress. Bug: 1150545 Change-Id: Ic77f90db8fb8a9078c9f308a58c26583d162ab20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551848 Commit-Queue: Mingjing Zhang <mjzhang@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Auto-Submit: Mingjing Zhang <mjzhang@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#829766}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/16973d613fed..2f47910c9ce3 2020-11-20 treehugger-gerrit@google.com Merge "Slightly improve performance of ScopedSpinlock." 2020-11-20 fmayer@google.com Merge "Reuse existing build id strings." 2020-11-19 treehugger-gerrit@google.com Merge "Do not include header when test isn't run." 2020-11-19 treehugger-gerrit@google.com Merge "[docs] Add docs on debug slices" 2020-11-19 treehugger-gerrit@google.com Merge "consumer sdk: Handle tracing sessions without matching data sources" 2020-11-19 treehugger-gerrit@google.com Merge "service: Fix ALL_DATA_SOURCES_STARTED event without instances" 2020-11-19 treehugger-gerrit@google.com Merge "Do not run POSIX watchdog when watchdog is compiled out." 2020-11-19 hjd@google.com Merge "traced_probes: Parse printk formats ftrace fields" 2020-11-19 treehugger-gerrit@google.com Merge "Add unittest for ParseProcInfo." 2020-11-19 treehugger-gerrit@google.com Merge "metrics: Remove trace-categories from chrome_event_metadata" 2020-11-19 fmayer@google.com Merge "Do not churn AllocRecords." 2020-11-19 lalitm@google.com Merge "Add all platform files to symbolizer build" 2020-11-19 treehugger-gerrit@google.com Merge "Fix missing "AS" in metrics docs' query example" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ife14e26373c1187307de14c906cff8351ec82550 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552236Reviewed-by:
-
Sorin Jianu authored
This renaming affects the updater COM server for Windows. Roughly, the following renamings were done: UpdaterControl -> UpdaterInternal updater_control -> updater_internal Bug: 1151106 Change-Id: I28dc034d5bda2b40e52701d5da9172a5f361fe77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552801Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#829764}
-
Dale Curtis authored
Surprisingly the ImageDecoder may be collected during async function execution without this. R=eugene Bug: 1148159 Change-Id: Id9ca591c79f848425548d5e4c97686fc1cc1ec94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551639 Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Reviewed-by:
Eugene Zemtsov <eugene@chromium.org> Cr-Commit-Position: refs/heads/master@{#829763}
-
Toni Barzic authored
When the number of pages in the model associated with the app list page switcher view changed, the page switcher would update it's layout by calling Layout() - this would not update the parent layout so buttons for added pages may get shown outside the visible page switcher bounds. This changes layout to PreferredSizeChanged(), which will invalidate the view layout and update the "ancestor" layouts in addition to the page switcher layout. BUG=1101969 Change-Id: I1c978a6a5c3279c8807defc4cb513712a19499ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552625 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#829762}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d99bf143c616..fd3678a79ddd 2020-11-20 bmeurer@chromium.org [ux] Optimize sidebar order in the Sources panel. 2020-11-20 brgoddar@microsoft.com Screenshot: disable screenshot command in PWA 2020-11-20 alexrudenko@chromium.org Implement APCA contrast in inspector overlay 2020-11-20 patrick.brosset@microsoft.com [Flex] Draw empty space in persistent overlay and on-hover of styles pane 2020-11-20 tvanderlippe@chromium.org Use TypeScript-authored files in emulation/ 2020-11-20 alexrudenko@chromium.org Enable TypeScript for TextEditorAutocompleteController 2020-11-20 tvanderlippe@chromium.org Use TypeScript-authored files in cookie_table/ 2020-11-20 jacktfranklin@chromium.org Update NodeText to apply classes for multiple descriptors 2020-11-20 sigurds@chromium.org Replace field on HTMLElement with WeakMap If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1121900,chromium:1122511,chromium:1150832,chromium:1151059 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I77b426127db0ad260d26571e95ec868ab17d31d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552567Reviewed-by:
-
Kramer Ge authored
This CL unilaterally disables sync page flip testing on Chrome OS boards that still use the legacy video decoder (e.g. rk3399 and Broadwell). Disable logic shall be removed when CrOSVideoDecoder is fully enabled. Change-Id: I38a377a4ff9a31ce4db325015439e8bdff62aebb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529197 Commit-Queue: Kramer Ge <fangzhoug@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#829760}
-
Alex Turner authored
What: navigated_frames_ now contains FrameTreeNode IDs instead of RenderFrameHost pointers. Accordingly, elements are removed on FrameDeleted() instead of RenderFrameDeleted(). Also clarifies an existing comment. Why: This should have no effect on the current throttle manager behavior as cross-process navigations should be committed. However, this will allow for a future cl (crrev.com/c/2419372) to distinguish between a frame's initial navigation and a cross-process navigation. Bug: 1147282 Change-Id: I2684404dc3fc49a9e758e740cd3e3197d8d6cd93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527348 Commit-Queue: Alex Turner <alexmt@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#829759}
-
Robbie McElrath authored
This reverts commit 5c26c215. Reason for revert: Dependency CL was relanded with fix. Original change's description: > Revert "[WebLayer] Create FragmentHostingRemoteFragmentImpl" > > This reverts commit d5f58580. > > Reason for revert: A CL this depends on got reverted > > Original change's description: > > [WebLayer] Create FragmentHostingRemoteFragmentImpl > > > > This CL removes the fake FragmentActivity from SiteSettingsFragmentImpl > > and MediaRouteDialogFragmentImpl, replacing them with a Context that > > hosts the fragments instead. This is possible now that we've landed > > the bytecode rewriting that changes the return type of > > Fragment.getActivity() from FragmentActivity to Activity. > > > > Bug: 1123216 > > Change-Id: I98c2c07eb348d6833ca2e5d976110f7f29b5359e > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523751 > > Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> > > Reviewed-by: Evan Stade <estade@chromium.org> > > Reviewed-by: Scott Violet <sky@chromium.org> > > Reviewed-by: Finnur Thorarinsson <finnur@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#828649} > > TBR=sky@chromium.org,finnur@chromium.org,estade@chromium.org,rmcelrath@chromium.org > > Change-Id: I2b83becfef2a92bd878bf32ae3aa5b750853a752 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1123216 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547783 > Reviewed-by: Robbie McElrath <rmcelrath@chromium.org> > Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> > Cr-Commit-Position: refs/heads/master@{#828839} TBR=sky@chromium.org,finnur@chromium.org,estade@chromium.org,rmcelrath@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1123216 Change-Id: If09c3da193ba75a240ddaf24ac2d82e8137f0cab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547945Reviewed-by:
Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#829758}
-
Sky Malice authored
Bug: 1142979 Change-Id: I6920bbb13b8ce95ab18067ccc8409614e640cb5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551618Reviewed-by:
Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
-
Cody Northrop authored
Fixes downstream ANGLE build using MSVC. Bug: 584575 Bug: 1151327 Change-Id: Idc0176ada20822929f8074e4c388f767bd262fc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552542Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com> Cr-Commit-Position: refs/heads/master@{#829756}
-
Ben Pastene authored
crrev.com/i/3419350 allocates the machines for this switch. Bug: 1140727 Change-Id: I008b3755f3bdee1ccc3b72ddd3d3f238ef7a2ff4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551592Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#829755}
-
Jeroen Dhollander authored
The AssistantTimersBrowserTest.ShouldTickNotificationsAtRegularIntervals is meant to test that each update to a timer notification comes around 1 second after the previous update. However, that is not correct, as the time between showing the notification and the first update can be much less than a second. This is because the notification is shown as soon as the timer is created, but updates are only ticked on full seconds. This started failing for me locally when regenerating the test data. Bug: b/170170824 Test: This is the test :) Change-Id: Ia0d0bdafc4ca975c49243511a54ac0c0ab6b5ac2 Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551077 Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org> Reviewed-by:
David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#829754}
-
