Commits · 3cd0223ff786d951ea08fa5e31933bd34f00dd43 · eriksson monteiro / tangled

11 Sep, 2020 40 commits

chromium-autoroll authored Sep 11, 2020

Roll Chrome Mac PGO profile from chrome-mac-master-1599825590-2ec297440160ee45d77cb43d7acba877f19de7a0.profdata to chrome-mac-master-1599847371-1259e0f875e6a0f41f2ed4be7cfee7084b9f6f04.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium
Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com
Change-Id: Ieec24de5575adebe50dd2e06e1e612290cf87a93
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405786
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#806337}

3cd0223f

Web test crash with CSSSystemColorComputeToSelf enabled · d480483d

Alison Maher authored Sep 11, 2020

virtual/forced-high-contrast-colors/fast/css/forced-colors-mode/forced-colors-mode-13.html
was crashing with CSSSystemColorComputeToSelf enabled. The reason
being that CSSColorInterpolationType::CreateInterpolableColor() didn't
properly handle system colors with the flag enabled.

Bug: 1081945,970285
Change-Id: I83b742ef2675addf9129187eb9cfa7c5faaa8aee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404109Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Alison Maher <almaher@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#806336}

d480483d

Force all OSes to use '/' as the separator · 8f298807

Weilun Shi authored Sep 11, 2020

Replace os.sep to '/' in histogram_paths.py to make sure that any
OS should output the same histogram index file.

Bug: 1126500
Change-Id: I5362321237723abda63cc8b2b3d30d0327a9b8a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402761
Auto-Submit: Weilun Shi <sweilun@chromium.org>
Commit-Queue: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806335}

8f298807

Use AutomationRichEditableText to handle <textarea> · fe56db93

David Tseng authored Sep 11, 2020

R=akihiroota@chromium.org

AX-Relnotes: ChromeVox will handle <textarea> in the same way it does a contenteditable.
Fixed: 1061659
Change-Id: I265dee8fe611c8f1cc2f49a1748054fead4b530d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402106
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Akihiro Ota <akihiroota@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806334}

fe56db93

[WebLayer] Limit site settings dialog fix to <N · a6c0db86

Robbie McElrath authored Sep 11, 2020

This CL limits the changes from crrev.com/c/2402188 to apply only to
Android <N. I originally hooked up the fix to all Android versions, even
though it wasn't needed past N, to increase the chances of us catching
a regression with that code given that most of our testing/usage
happens on newer versions. Limiting it to only the versions that need
it will help with performance on >=N, and once we have manual testers
covering the site settings ui, regressions should get caught through
that.

Bug: 1126647
Change-Id: I96919bd0faf6220029e0397a23593e3ff5c8bbed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406694Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806333}

a6c0db86

Revert "Roll src-internal from 7214110d995d to 4bb03bb4b22d (2 revisions)" · 407e6843

Wenbin Zhang authored Sep 11, 2020

This reverts commit c8b2d7b0.

Reason for revert: Android builders on perf waterfall started failing from this CL.

Original change's description:
> Roll src-internal from 7214110d995d to 4bb03bb4b22d (2 revisions)
> 
> https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7214110d995d..4bb03bb4b22d
> 
> If this roll has caused a breakage, revert this CL and stop the roller
> using the controls here:
> https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
> Please CC rakina@google.com on the revert to ensure that a human
> is aware of the problem.
> 
> To report a problem with the AutoRoller itself, please file a bug:
> https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
> 
> Documentation for the AutoRoller is here:
> https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
> 
> Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
> Bug: chromium:816629
> Tbr: rakina@google.com
> Change-Id: I39fc271d42e249d7084a884043433b66ee355278
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404674
> Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/master@{#806087}

TBR=rakina@google.com,chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com

Change-Id: Icb635758b167278d7bf04255d693f1de619d3f84
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:816629
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405946Reviewed-by: Wenbin Zhang <wenbinzhang@google.com>
Commit-Queue: Wenbin Zhang <wenbinzhang@google.com>
Auto-Submit: Wenbin Zhang <wenbinzhang@google.com>
Cr-Commit-Position: refs/heads/master@{#806332}

407e6843

Use assigned machines for ToTiOS{,Device}. · d6be0487

Garrett Beaty authored Sep 11, 2020

These builders were assigned machines in https://crrev.com/i/3264546.

Bug: 1126929
Change-Id: Ida6f75fa6d562aa4c71533eb36f41480688efcfe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406519
Auto-Submit: Garrett Beaty <gbeaty@chromium.org>
Reviewed-by: Michael Moss <mmoss@chromium.org>
Commit-Queue: Michael Moss <mmoss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806331}

d6be0487

Improve QUIC 0-RTT histograms · b4bdfdc2

Nick Harper authored Sep 11, 2020

This change fixes a bug in the Net.QuicSession.ZeroRttState histogram
where no entries would get recorded for 0-RTT not attempted in Google
QUIC. This also adds a new histogram that provides more detail on why
0-RTT gets rejected.

Change-Id: Ia15485827e16698a5e3a3be48f52b669b16f52ad
Bug: b/168020146
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405943Reviewed-by: Renjie Tang <renjietang@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Nick Harper <nharper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806330}

b4bdfdc2

Revert "Roll src-internal from 4bb03bb4b22d to 44c9ca6a2c0e (1 revision)" · 8668ae66

Wenbin Zhang authored Sep 11, 2020

This reverts commit 608a0e43.

Reason for revert: Android builders on perf waterfall start failing since https://chromium-review.googlesource.com/c/chromium/src/+/2404674. Reverting the CLs after that.

Original change's description:
> Roll src-internal from 4bb03bb4b22d to 44c9ca6a2c0e (1 revision)
> 
> https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4bb03bb4b22d..44c9ca6a2c0e
> 
> If this roll has caused a breakage, revert this CL and stop the roller
> using the controls here:
> https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
> Please CC orphis@google.com on the revert to ensure that a human
> is aware of the problem.
> 
> To report a problem with the AutoRoller itself, please file a bug:
> https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
> 
> Documentation for the AutoRoller is here:
> https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
> 
> Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
> Bug: chromium:1040645
> Tbr: orphis@google.com
> Change-Id: I586d0a124bb943405b379d527767540d5730141e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405975
> Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/master@{#806112}

TBR=orphis@google.com,chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com

Change-Id: I55721462acc6cdeb5da2584ae493d1e119072c3c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:1040645
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406521Reviewed-by: Wenbin Zhang <wenbinzhang@google.com>
Commit-Queue: Wenbin Zhang <wenbinzhang@google.com>
Auto-Submit: Wenbin Zhang <wenbinzhang@google.com>
Cr-Commit-Position: refs/heads/master@{#806329}

8668ae66

[web tests] results detail sizing fix · bcdccedf

Aleks Totic authored Sep 11, 2020

Image detail canvases sizes were different.
This forces all flex items to the same size.

Change-Id: I4db361c5b1a1746a882ea903dc142d3614cba02d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401805Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806328}

bcdccedf

Revert "Roll src-internal from 44c9ca6a2c0e to d9ddf43a38c7 (2 revisions)" · d8708177

Wenbin Zhang authored Sep 11, 2020

This reverts commit 0be23048.

Reason for revert: Android builders on perf waterfall start failing since https://chromium-review.googlesource.com/c/chromium/src/+/2404674. Reverting the CLs after that.

Original change's description:
> Roll src-internal from 44c9ca6a2c0e to d9ddf43a38c7 (2 revisions)
> 
> https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/44c9ca6a2c0e..d9ddf43a38c7
> 
> If this roll has caused a breakage, revert this CL and stop the roller
> using the controls here:
> https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
> Please CC orphis@google.com on the revert to ensure that a human
> is aware of the problem.
> 
> To report a problem with the AutoRoller itself, please file a bug:
> https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
> 
> Documentation for the AutoRoller is here:
> https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
> 
> Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
> Bug: None
> Tbr: orphis@google.com
> Change-Id: I014e334ab708e71f06627a5cff15316aa8483222
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406094
> Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/master@{#806141}

TBR=orphis@google.com,chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com

Change-Id: Ie21369e9364abb57374acc106ce34f33917f86b6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: None
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406587Reviewed-by: Wenbin Zhang <wenbinzhang@google.com>
Commit-Queue: Wenbin Zhang <wenbinzhang@google.com>
Auto-Submit: Wenbin Zhang <wenbinzhang@google.com>
Cr-Commit-Position: refs/heads/master@{#806327}

d8708177

Roll Skia from 30d3022f727a to 83ba93022571 (4 revisions) · 977187cf

chromium-autoroll authored Sep 11, 2020

https://skia.googlesource.com/skia.git/+log/30d3022f727a..83ba93022571

2020-09-11 brianosman@google.com Support dangling type references in the IR generator's inliner
2020-09-11 bsalomon@google.com Always make atlas texture index varying a float
2020-09-11 jlavrova@google.com Reland "Removing ICU dependencies from skparagraph BUILD.gn file"
2020-09-11 jzern@google.com DEPS: update libwebp to v1.1.0-28-g55a080e5

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC reed@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: reed@google.com
Change-Id: I28d86901db1aa9b478fbe5a5107634b18a85ccc9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406516Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#806326}

977187cf

Revert "Roll src-internal from d9ddf43a38c7 to 0112b94ac90e (1 revision)" · 3dd15b35

Wenbin Zhang authored Sep 11, 2020

This reverts commit 5cc6a1ae.

Reason for revert: Android builders on perf waterfall start failing since https://chromium-review.googlesource.com/c/chromium/src/+/2404674. Reverting the CLs after that.

Original change's description:
> Roll src-internal from d9ddf43a38c7 to 0112b94ac90e (1 revision)
> 
> https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d9ddf43a38c7..0112b94ac90e
> 
> If this roll has caused a breakage, revert this CL and stop the roller
> using the controls here:
> https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
> Please CC orphis@google.com on the revert to ensure that a human
> is aware of the problem.
> 
> To report a problem with the AutoRoller itself, please file a bug:
> https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
> 
> Documentation for the AutoRoller is here:
> https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
> 
> Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
> Bug: None
> Tbr: orphis@google.com
> Change-Id: I62f197e6d5c64a57903baca3fb8166edfcf214e4
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406140
> Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/master@{#806177}

TBR=orphis@google.com,chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com

Change-Id: I828d06841241b9f09425e50b4d7335705a45d0a2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: None
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406699Reviewed-by: Wenbin Zhang <wenbinzhang@google.com>
Commit-Queue: Wenbin Zhang <wenbinzhang@google.com>
Auto-Submit: Wenbin Zhang <wenbinzhang@google.com>
Cr-Commit-Position: refs/heads/master@{#806325}

3dd15b35

Revert "Roll src-internal from 0112b94ac90e to 2ec1f5c76dcd (5 revisions)" · d01f5fa7

Wenbin Zhang authored Sep 11, 2020

This reverts commit 68b7ac65.

Reason for revert: Android builders on perf waterfall start failing since https://chromium-review.googlesource.com/c/chromium/src/+/2404674. Reverting the CLs after that.

Original change's description:
> Roll src-internal from 0112b94ac90e to 2ec1f5c76dcd (5 revisions)
> 
> https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0112b94ac90e..2ec1f5c76dcd
> 
> If this roll has caused a breakage, revert this CL and stop the roller
> using the controls here:
> https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
> Please CC sebsg@google.com,orphis@google.com on the revert to ensure that a human
> is aware of the problem.
> 
> To report a problem with the AutoRoller itself, please file a bug:
> https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
> 
> Documentation for the AutoRoller is here:
> https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
> 
> Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
> Bug: chromium:1103401,chromium:1124063,chromium:1126022,chromium:903249
> Tbr: sebsg@google.com,orphis@google.com
> Change-Id: Ice046ba66d8ef5ba3e3a2cc57b6d0c1dde6b400f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406252
> Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/master@{#806204}

TBR=sebsg@google.com,orphis@google.com,chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com

Change-Id: Ia6931517e083808129e422a488609f12c568ce82
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:1103401
Bug: chromium:1124063
Bug: chromium:1126022
Bug: chromium:903249
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406520Reviewed-by: Wenbin Zhang <wenbinzhang@google.com>
Commit-Queue: Wenbin Zhang <wenbinzhang@google.com>
Auto-Submit: Wenbin Zhang <wenbinzhang@google.com>
Cr-Commit-Position: refs/heads/master@{#806324}

d01f5fa7

Revert "Roll src-internal from 2ec1f5c76dcd to 409a8e40330a (3 revisions)" · 3c171374

Wenbin Zhang authored Sep 11, 2020

This reverts commit 4555891d.

Reason for revert: Android builders on perf waterfall start failing since https://chromium-review.googlesource.com/c/chromium/src/+/2404674. Reverting the CLs after that.

Original change's description:
> Roll src-internal from 2ec1f5c76dcd to 409a8e40330a (3 revisions)
> 
> https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2ec1f5c76dcd..409a8e40330a
> 
> If this roll has caused a breakage, revert this CL and stop the roller
> using the controls here:
> https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
> Please CC chanli@google.com,sebsg@google.com on the revert to ensure that a human
> is aware of the problem.
> 
> To report a problem with the AutoRoller itself, please file a bug:
> https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
> 
> Documentation for the AutoRoller is here:
> https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
> 
> Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
> Bug: chromium:1039881,chromium:1040645
> Tbr: chanli@google.com,sebsg@google.com
> Change-Id: Iaeecf2709aab0a23ea5cdf3dffce8f39ad926098
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406373
> Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/master@{#806249}

TBR=sebsg@google.com,chanli@chromium.org,chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com

Change-Id: Iadbd707c0f0f91c5a85b4f92236ea9d7cf6fb4a9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:1039881
Bug: chromium:1040645
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406687Reviewed-by: Wenbin Zhang <wenbinzhang@google.com>
Commit-Queue: Wenbin Zhang <wenbinzhang@google.com>
Auto-Submit: Wenbin Zhang <wenbinzhang@google.com>
Cr-Commit-Position: refs/heads/master@{#806323}

3c171374

Avoid crashing on empty RenderPassList. · 5b224537

kylechar authored Sep 11, 2020

SurfaceAggregator::Aggregate() could attempt to use the last entry in
|dest_pass_list_| without verifying there was anything in it and crash.
There is an early exit for an empty list, but it's after the code uses
the last entry in the list.

The way that member variables are used during Aggregate() is a bit
awkward, many of them are used only for the duration of Aggregate() to
avoid passing variables around and need to be reset, while others need
to persist after Aggregate(). While it would be best if the temporary
state needed during Aggregate() was refactored out, this CL adds a
member function to reset variables needed only during Aggregate(). This
allows moving the early exit before using |dest_pass_list_|.

Bug: 1126897
Change-Id: Ie6979a637ba1f3f301394171ca74064fccc5c4f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404473Reviewed-by: weiliangc <weiliangc@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806322}

5b224537

CrOS GMC: Populate Zenith dialog. · f0d66f2e

Jazz Xu authored Sep 11, 2020

This CL create a bubble for MediaTray and display
MediaNotificationListView which got from MediaNotificationProviderImpl.

Bug: 1122419
Change-Id: I7cb9a999f6629b63f896e9919e1692a57d168713
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376982Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Tim Song <tengs@chromium.org>
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Commit-Queue: Jazz Xu <jazzhsu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806321}

f0d66f2e

Roll ANGLE from a1ecebbc8338 to 7870cf3f0a34 (4 revisions) · 14b94d04

chromium-autoroll authored Sep 11, 2020

https://chromium.googlesource.com/angle/angle.git/+log/a1ecebbc8338..7870cf3f0a34

2020-09-11 syoussefi@chromium.org Vulkan: Fix RAW hazard with storage images
2020-09-11 geofflang@google.com Flush less frequently in QueryGL.
2020-09-11 courtneygo@google.com Vulkan: Use current commandBuffer pointer
2020-09-11 courtneygo@google.com Enable precision qualifiers.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC ianelliott@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: chromium:1078754
Tbr: ianelliott@google.com
Change-Id: I369e397e2d5f3ded08991272e302918c6f4a6c33
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404618Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#806320}

14b94d04

Add third_party/soda to .gitignore · c2fa912b

evliu authored Sep 11, 2020

This CL adds the //third_party/soda/ path to .gitignore. This
third-party repo will be imported from src-internal/DEPS and contain
the files required to test the Speech On-Device API(SODA).

Bug: 1122784
Change-Id: I0513a157a83f72781e0db444acb7d5e6f0f43318
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386459Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Evan Liu <evliu@google.com>
Cr-Commit-Position: refs/heads/master@{#806319}

c2fa912b

[CrOS PhoneHub] Fix issue which causes crash on Linux build · 3105519d

Kyle Horimoto authored Sep 11, 2020

This CL changes FeatureStatusProviderImpl logic to check whether
DeviceSyncClient is ready before continuing. In real-world usage, this
will always be the case, but on the Linux emulator this condition is not
true, causing a crash.

Bug: 1106937
Change-Id: Ie99d4085697867b730b81e52f28b0afdbb7a46f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405901
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Auto-Submit: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Regan Hsu <hsuregan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806318}

3105519d

Disable AllPasswordsBottomSheetViewTest#testCredentialsChangedByModel. · 1e328810

Xi Han authored Sep 11, 2020

Bug: 1127433
TBR: fhorschig@chromium.org
Change-Id: I5d41b285bbd7c02e87d05e3623b828c6d2de22b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404889Reviewed-by: Xi Han <hanxi@chromium.org>
Commit-Queue: Xi Han <hanxi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806317}

1e328810

Update mojo documentation to describe sequence-affinity of callbacks. · 94936efa

Erik Chen authored Sep 11, 2020

Change-Id: I34d76c9d3de95f66610bbd0124b476d7d35f875c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406598
Commit-Queue: Erik Chen <erikchen@chromium.org>
Commit-Queue: Ken Rockot <rockot@google.com>
Auto-Submit: Erik Chen <erikchen@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#806316}

94936efa

[tools/perf] Reenable speedometer2-future unittest · 83d52b3a

John Chen authored Sep 11, 2020

The test has been disabled for almost a year, and all crash dumps are gone.
Reenable test to see if it is still flaky, and collect new dumps if needed.

Bug: 1003776
Change-Id: Iccd4bd23b102e1e3c6d1346c04443c4d2e540096
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363360
Commit-Queue: Wenbin Zhang <wenbinzhang@google.com>
Auto-Submit: John Chen <johnchen@chromium.org>
Reviewed-by: Wenbin Zhang <wenbinzhang@google.com>
Cr-Commit-Position: refs/heads/master@{#806315}

83d52b3a

[Nearby] Use local device data manager in settings mojo implementation · 32660f04

Josh Nohle authored Sep 11, 2020

Instead of accessing the device name pref directly in the settings mojo
implementation, use the local device data manager to get and set the
device name in addition to observing for device name changes.

Fixed: b/168138411
Change-Id: I610d653b640a36a5128ff66bb9e3c99b5aa7e538
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404715
Commit-Queue: Josh Nohle <nohle@chromium.org>
Reviewed-by: James Vecore <vecore@google.com>
Cr-Commit-Position: refs/heads/master@{#806314}

32660f04

Merge URLRequestJobFactoryImpl into URLRequestJobFactory. · a9606a0e

Matt Menke authored Sep 11, 2020

There are only four URLRequestJobFactory implementations, and all but
URLRequestJobFactoryImpl are test-only. This CL removes one of them,
one is for FTP, which is deprecated. The last is for Cronet, which may
take some effort to unwrangle.

Ideally we'll eventually remove URLRequestJobFactory as well, but until
then, this simplifies things a bit.

Bug: 354158
Change-Id: I7e644ce6690692adc1231cf3a1464743ced073fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2394155Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806313}

a9606a0e

Roll WebRTC from dd680639768f to aeac9f88598d (1 revision) · b5e1940f

chromium-autoroll authored Sep 11, 2020

https://webrtc.googlesource.com/src.git/+log/dd680639768f..aeac9f88598d

2020-09-11 philipp.hancke@googlemail.com build: move rtc_prefer_fixed_point

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: Idf443654be4b2a67c950d9a8e35d5aece6b66159
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406318Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#806312}

b5e1940f

Simplify PostAsyncResultsTests · bf2d8f3b

Hoch Hochkeppel authored Sep 11, 2020

Re-working the tests for PostAsyncResults to by 2 typed tests run on 3
types, rather than 6 stand-alone tests. This reduces the code
duplication without reducing the readability of the tests, and sets up
well for adding additional methods to post_async_results that should be
tested over the same set of types.

For examples of the kinds of additional functions anticipated, see
these abandoned crs:
https://crrev.com/c/1981255
https://crrev.com/c/2386099

Adding said additional functions will be pursued as an independent
change.

Change-Id: I92c46760de15d6876eb73f7f3b49135b1d1570c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406492
Commit-Queue: Hoch Hochkeppel <mhochk@microsoft.com>
Reviewed-by: Will Harris <wfh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806311}

bf2d8f3b

ContentCapture: Fix the wrong TaskDelayTimeInMs · bdd4720d

Michael Bai authored Sep 11, 2020

Starts recording when the task is actually scheduled.

Currently the recording is reset for every change, it caused
the task delay time is shorter than it should to be.

Test: passing existing test.
Bug: 112742
Change-Id: I5c31a286b483d4f68ee892b9aa850aadaf62dc49
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404799Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Tao Bai <michaelbai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806310}

bdd4720d

[Android] Add flag for detailed language settings feature · 990a1c6d

Trevor Perrier authored Sep 11, 2020

This CL adds the DetailedLanguageSettings feature to chrome://flags
on Android.

Bug: 1068667
Change-Id: I6b4bc7aeb0fe00741ea553e89459713834f79e9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405942Reviewed-by: Megan Jablonski <megjablon@chromium.org>
Commit-Queue: Trevor  Perrier <perrier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806309}

990a1c6d

Automated Commit: LKGM 13463.0.0 for chromeos. · 7df1c7ae

3su6n15k.default@developer.gserviceaccount.com authored Sep 11, 2020

CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome
TBR=chrome-os-gardeners@google.com

Change-Id: Ib31bd7df9b8002235c55b6192461efde35d322d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406176Reviewed-by: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Reviewed-by: Mitsuru Oshima (Slow: gardener) <oshima@chromium.org>
Commit-Queue: Mitsuru Oshima (Slow: gardener) <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806308}

7df1c7ae

cr_components/network: Convert NetworkSelect to Polymer 3. · 3677ecbf

James Hawkins authored Sep 11, 2020

R=khorimoto@chromium.org

Bug: 1045266
Test: NetworkComponentsNetworkSelectTest*
Change-Id: I7b10ffe2e7080941bddc5adeee3bb65e18fb0463
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404071
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806307}

3677ecbf

[omnibox] [entity] Remove the local entity feature & flag. · feb68996

manukh authored Sep 11, 2020

Local entities has launched through GWS. The chromium feature & flag are
defunct.

Bug: 1115108
Change-Id: I9d1f8094fea51e9a40413a60e6bf7faa7700bc5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405707Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806306}

feb68996

Add missing WebsiteSettings histograms · 6a4146b8

Christian Dullweber authored Sep 11, 2020

A couple of WebsiteSettings are missing from histograms.xml. Add the
missing ones.

Bug: 1095078
Change-Id: Ie4b3b93355a4622626d087395556801b2840bb3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404443Reviewed-by: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806305}

6a4146b8

[WebLayer] Add more Site Settings tests · 70210e45

Robbie McElrath authored Sep 11, 2020

This CL adds tests for most Site Settings UI surfaces, including each
Fragment type, popup type, and links to system settings activities.

Bug: 1122705
Change-Id: I3232d490a8798adf9553629f4d5634221e83e100
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382483Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806304}

70210e45

[omnibox] Reset line state to normal for non-keyword-mode clicks · b112e866

Orin Jaworski authored Sep 11, 2020

This CL fixes a bug where clicking the omnibox would reset the line
state to normal but not clear keyword mode. The expected behavior
when clicking with keyword mode active is to not reset line state.

Bug: 1127291
Change-Id: I4c081add27ead2058189a89940b980f8281841e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406352Reviewed-by: Angela Yoeurng <yoangela@chromium.org>
Commit-Queue: Orin Jaworski <orinj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806303}

b112e866

Modernize content/public/test/browser_test_utils.cc. · 018fbce3

Lei Zhang authored Sep 11, 2020

- Use auto, = default, and std::make_unique().
- Remove content:: in namespace content.
- Fix a few nits along the way.

Change-Id: I55912384dcb5dff2d9a16b14706dca687b65aa75
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404955Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806302}

018fbce3

workaround: disable CFG longjmp protection for Windows on Arm · c6261851

Richard Townsend authored Sep 11, 2020

LLD has a known code-generation defect around setjmp/longjmp on this
platform. Temporarily workaround by passing /guard:cf,nolongjmp which
should stop the crashing until LLD's fixed.

Bug: 1126549
Change-Id: I26871b23428bcbeaff7cda7cd136cdd3414eaa54
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405755
Commit-Queue: Richard Townsend <richard.townsend@arm.com>
Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806301}

c6261851

[OsSettingsDeepLinking] Add deep link to enable SIM lock · db40bb5e

Daniel Classon authored Sep 11, 2020

Adds deep link to the enable SIM lock toggle on the Internet Detail
subpage.

Bug: 1115732, 1084154
Change-Id: Id3a7c85990e247d7238ba112e0b3e9f13b3c7836
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353535
Commit-Queue: Daniel Classon <dclasson@google.com>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806300}

db40bb5e

Extend metrics expiration milestone · 31dfef92

Gang Wu authored Sep 11, 2020

Switch to tab is not fully enabled on Android yet, so those metrics
still needed.

Change-Id: Ib95b879c65f2ed1dc8298710d515ccd5eef449bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405895Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Kevin Bailey <krb@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Gang Wu <gangwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806299}

31dfef92

Reland "Rename wrapper_scripts for generated_script tests in MB." · 1ff449c9

Dirk Pranke authored Sep 11, 2020

This reverts commit 56428611.

Reason for revert: Relanding now that the internal failure has been fixed.

Original change's description:
> Revert "Rename wrapper_scripts for generated_script tests in MB."
>
> This reverts commit 8700df8a.
>
> Reason for revert:
>
> Android builders started failing since this commit:
> https://ci.chromium.org/p/chrome/builders/ci/android-builder-perf/217957
>
> Traceback (most recent call last):
>   File "/b/s/w/ir/cache/builder/src/tools/mb/mb.py", line 105, in Main
>     ret = self.args.func()
>   File "/b/s/w/ir/cache/builder/src/tools/mb/mb.py", line 378, in CmdGen
>     return self.RunGNGen(vals)
>   File "/b/s/w/ir/cache/builder/src/tools/mb/mb.py", line 961, in RunGNGen
>     ret = self.GenerateIsolates(vals, isolate_targets, isolate_map, build_dir)
>   File "/b/s/w/ir/cache/builder/src/tools/mb/mb.py", line 1075, in GenerateIsolates
>     command, extra_files = self.GetIsolateCommand(target, vals)
>   File "/b/s/w/ir/cache/builder/src/tools/mb/mb.py", line 1392, in GetIsolateCommand
>     'generated_scripts can no longer customize the script path')
> AssertionError: generated_scripts can no longer customize the script path
>
>
> Original change's description:
> > Rename wrapper_scripts for generated_script tests in MB.
> >
> > A few tests (some Android resource_sizes tests, and one Perfetto
> > test), were using generated_script tests that were generating
> > wrappers that weren't named 'bin/run_$target_name'.
> >
> > We want all generated_script tests to be using consistent names, so
> > this CL changes those targets.
> >
> > Bug: 816629
> > Change-Id: If447fbee6b33637de4c9711e87379128272285af
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380672
> > Commit-Queue: Dirk Pranke <dpranke@google.com>
> > Reviewed-by: John Chen <johnchen@chromium.org>
> > Reviewed-by: Andrew Grieve <agrieve@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#802694}
>
> TBR=dpranke@google.com,agrieve@chromium.org,johnchen@chromium.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: 816629
> Change-Id: I11ec06405105860f01f3b7752df2024615f7badc
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384069
> Reviewed-by: Wenbin Zhang <wenbinzhang@google.com>
> Commit-Queue: John Chen <johnchen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#802984}

TBR=dpranke@google.com,agrieve@chromium.org,johnchen@chromium.org,wenbinzhang@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.


Bug: 816629
Change-Id: I44017e48dc94a1af692a66e00bbd3a127b32b382
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405793
Commit-Queue: Dirk Pranke <dpranke@google.com>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Cr-Commit-Position: refs/heads/master@{#806298}

1ff449c9