GitLab

https://www.chromium.org/developers/coding-style/cpp-dos-and-donts#TOC-Forward-declare-classes-instead-of-including-headers.

Review URL: https://codereview.chromium.org/1135793006

Cr-Commit-Position: refs/heads/master@{#330708}

Currently HWNDMessageHandler::OnSetFocus happens before WM_ACTIVATE is handled in HWNDMessageHandler::OnWndProc().
Root cause: when WM_ACTIVATE comes, in HWNDMessageHandler::OnWndProc(), it will call DefWindowProc() first, which may result in generating WM_SETFOCUS message and call OnWndProc() recursively and therefore OnSetFocus() is called.
After the recursive OnWndProc() returns, PostProcessActivateMessage() is called to handle WM_ACTIVATE.

So DWTHW::HandleNativeFocus() happens before DNWA::HandleActivationChanged().
Therefore, IMB::OnFocus() will get NULL for host_->GetTextInputClient(), which will result in the IMB instance set to the host InputMethod as the focused TextInputClient (which should be the RWHVA).

It would be risky to fix that order in HWNDMessageHandler.
Instead, we can remove the IMB::OnFocus call in DWTHW::HandleNativeFocus() which seems to be redundant, because DNWA::OnWindowFocused() can do the thing, which happens after the top window is activated.

TBR=ananta@chromium.org,sky@chromium.org
BUG=486604
TEST=Verified on local win build.

Review URL: https://codereview.chromium.org/1139623003

Cr-Commit-Position: refs/heads/master@{#330707}

Cr-Commit-Position: refs/heads/master@{#330706}

Disable AutoclickTest.DISABLED_SynthesizedMouseMovesIgnored test on official build since it has been failing for several days.

BUG=489896

Review URL: https://codereview.chromium.org/1124113006

Cr-Commit-Position: refs/heads/master@{#330705}

They should take up the entire screen, and the fullscreen button must
be enabled to allow the user to leave.

This also factors out NSWindowFullscreenNotificationWaiter.

BUG=459877

Review URL: https://codereview.chromium.org/1109493002

Cr-Commit-Position: refs/heads/master@{#330704}

updateAccount() is always called on startup with the signed in account,
so the removePeriodicSync() call will be hit even for already signed in
users when the app restarts.

This change was previously submitted as http://crrev.com/1148613002 but
got reverted due to a bad merge caused by http://crrev.com/1138013008.

BUG=480688

Review URL: https://codereview.chromium.org/1144993002

Cr-Commit-Position: refs/heads/master@{#330703}

BUG=489219,267773

Review URL: https://codereview.chromium.org/1123263005

Cr-Commit-Position: refs/heads/master@{#330702}

BUG=489264
TEST=build/gyp_chromium -Duse_ozone=1

Review URL: https://codereview.chromium.org/1139973005

Cr-Commit-Position: refs/heads/master@{#330701}

Both 'chrome:' and 'chrome-devtools:' are content-level schemes; we
should do their various renderer-side scheme registrations in content
(RenderThreadImpl::RegisterSchemes) rather than in chrome
(ChromeContentRendererClient::RenderThreadStarted).

Patch 1: https://codereview.chromium.org/1143593006
Patch 2: [This patch]
Patch 3: https://codereview.chromium.org/1139053004/

This is a re-land of https://codereview.chromium.org/1137103003/,
which was reverted due to trivial layout test changes.

TBR=jochen@chromium.org,philipj@opera.com,sofbjornf@opera.com,hiroshige@chromium.org
BUG=489672

Review URL: https://codereview.chromium.org/1134303009

Cr-Commit-Position: refs/heads/master@{#330700}

BUG=489751

Review URL: https://codereview.chromium.org/1148703002

Cr-Commit-Position: refs/heads/master@{#330699}

BUG=489751

Review URL: https://codereview.chromium.org/1143013002

Cr-Commit-Position: refs/heads/master@{#330698}

Not supporting file watchers is not an error. It's expected from eg. file
systems exposed via File System Provider API, especially those which are
read only.

TEST=Tested manually that watchers work and there is no spam in the log.
BUG=461735

Review URL: https://codereview.chromium.org/1150473002

Cr-Commit-Position: refs/heads/master@{#330697}

This patch removes the testing IPC from BluetoothDispatcher and
BluetoothDispatcherHost.

This patch also changes the way the mock BluetoothAdapter was set in
BluetoothDispatcherHost. Instead of receiving an IPC to set the adapter,
BluetoothDispatcherHost exposes a function to directly set the adapter.
This function is used by LayoutTestSupport to set the adapter.

Mock adapter flow before:
BlinkTestRunner -> LayoutTestSupport -> BluetoothDispatcher --IPC-->
BluetoothDispatcherHost (Mock constructed here)

After:
BlinkTestRunner --IPC--> LayoutTestMessages(Mock constructed here) ->
LayoutTestSupport -> BluetoothDispatcherHost

This is the first of two patches to remove testing from BluetoothDispatcher
and BluetoothDispatcherHost:

 [1] This patch.
 [2] http://crrev.com/1132943002

BUG=436284

Committed: https://crrev.com/3f7142d0acf5e930743cbe5d754084c464ac3c85
Cr-Commit-Position: refs/heads/master@{#330647}

Review URL: https://codereview.chromium.org/1125133005

Cr-Commit-Position: refs/heads/master@{#330696}

This reverts commit 587bef69.

BUG=485323

Review URL: https://codereview.chromium.org/1143763002

Cr-Commit-Position: refs/heads/master@{#330695}

Target of texStorage2D should be one of GL_TEXTURE_2D, or
GL_TEXTURE_CUBE_MAP.

BUG=429053

Review URL: https://codereview.chromium.org/1146633002

Cr-Commit-Position: refs/heads/master@{#330694}

As any includes present in the related header do not need to be included again in the related cc (i.e., foo.cc can rely on foo.h's includes).

A trivial way to fix these is by removing such an include from the .cc file. So this CL removes all includes from $X.cc files where the $X.h has the same include to confirm to the style guide.

BUG=460988

Review URL: https://codereview.chromium.org/1139323003

Cr-Commit-Position: refs/heads/master@{#330693}

As a result, removes the
NOTIFICATION_RENDERER_V8_HEAP_STATS_COMPUTED notification.

BUG=268984, 487927

Review URL: https://codereview.chromium.org/1081323003

Cr-Commit-Position: refs/heads/master@{#330692}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/cda0078..da030f3

TBR=hiroshige@chromium.org,szager@chromium.org,leviw@chromium.org

Review URL: https://codereview.chromium.org/1148683002

Cr-Commit-Position: refs/heads/master@{#330691}

Some of these files were forked in the initial Mandoline landing. After we forked the application code, we now had two implementations of some of these files. We only need one.

Review URL: https://codereview.chromium.org/1142323003

Cr-Commit-Position: refs/heads/master@{#330690}

The common file prevents duplication of the same @font-face definitions,
and allows additional font weights and character sets added by one
project to be automatically available for all other Roboto users.

This CL also updates the Roboto font files from Google Fonts and removes
the .woff file, since Chrome has complete support for woff2.

BUG=439114
TEST=Locally tested chrome://md-settings, chrome://proximity-auth and a
  PDF file on desktop, and chrome://contextual-search-promo/promo.html
  on Android.

Review URL: https://codereview.chromium.org/1142893002

Cr-Commit-Position: refs/heads/master@{#330689}

Open the learn more page about downloading malicious file, when user clicks a notification of suspicious download.

BUG=488109
TEST=none

Review URL: https://codereview.chromium.org/1126343006

Cr-Commit-Position: refs/heads/master@{#330688}

Includes this change:
 - Start proguarding google play services.

BUG=484934

Review URL: https://codereview.chromium.org/1143003002

Cr-Commit-Position: refs/heads/master@{#330687}

Cr-Commit-Position: refs/heads/master@{#330686}

Review URL: https://codereview.chromium.org/1127993006

Cr-Commit-Position: refs/heads/master@{#330685}

During destruction, pdfium may call back into the instance and access members.
It would be better if this didn't happen but it isn't strictly wrong and may
be necessary as it appears pdfium can run scripts at shutdown.

BUG=485855
R=thestig@chromium.org

Review URL: https://codereview.chromium.org/1144923002

Cr-Commit-Position: refs/heads/master@{#330684}

When a navigation occurs and the omnibox is focused and fully selected,
the replacement URL should also be fully selected. OmnboxViewMac
currently does not do this.

Use the same logic from void OmniboxViewViews::Update().

This makes Mac consistent with other platforms. Adds a cross-platform
test to verify.

BUG=471635

Review URL: https://codereview.chromium.org/1144853003

Cr-Commit-Position: refs/heads/master@{#330683}

Copies over the previous OWNER of this code, from before the code moved into
net/extras/sqlite.

BUG=None
TEST=None

Review URL: https://codereview.chromium.org/1143593007

Cr-Commit-Position: refs/heads/master@{#330682}

blink was updated some time ago to use the new method, so this
is simply a cleanup on unused code.

TEST=compiles
BUG=

Review URL: https://codereview.chromium.org/1148523006

Cr-Commit-Position: refs/heads/master@{#330681}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/a65358c..8debd89

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=bungeman@google.com

Review URL: https://codereview.chromium.org/1144933002

Cr-Commit-Position: refs/heads/master@{#330680}

Layer::GetTargetColor currently always checks the LayerAnimator for a target
color.

When the layer is not animating, the animator's defaults do not necessarily
reflect the current state of the layer. This change updates
Layer::GetTargetColor to return the current color if not animating.

TEST=LayerOwnerTest, RecreateLayerSolidColorWithChangedCCLayerHonorsTargets,
ran compositor_unittests, ash_unittests, views_unittests
BUG=chrome-os-partner:40118

Review URL: https://codereview.chromium.org/1125283015

Cr-Commit-Position: refs/heads/master@{#330679}

BubbleFrameView: Replaced GetCloseButtonBounds with
GetCloseButtonMirroredBounds. Now returns the RTL-mirrored bounds, which
is necessary for the App Info dialog's FullSizeBubbleFrameView to
correctly target events to the close button in RTL mode.

BUG=474559
TEST=Change language to Arabic. Go to chrome://extensions; click
"Details" on any extension. Click X button. Should close dialog.

Review URL: https://codereview.chromium.org/1144853002

Cr-Commit-Position: refs/heads/master@{#330678}

BUG=chrome-os-partner:39397
R=marcheu@chromium.org

Review URL: https://codereview.chromium.org/1146793002

Cr-Commit-Position: refs/heads/master@{#330677}

BUG=406483

Review URL: https://codereview.chromium.org/1146453003

Cr-Commit-Position: refs/heads/master@{#330676}

Check for potential overflows in PDFResource::SearchString().

Review URL: https://codereview.chromium.org/1147883002

Cr-Commit-Position: refs/heads/master@{#330675}

This CL shows remaing space at the mount time in file manager.
A CL to make file manager show latest remaing space will come as another CL.

BUG=486396

Review URL: https://codereview.chromium.org/1140583005

Cr-Commit-Position: refs/heads/master@{#330674}

BUG=462238

Review URL: https://codereview.chromium.org/1116353004

Cr-Commit-Position: refs/heads/master@{#330673}

Move NativeViewport service into view_manager. This is a file move only. Further merging will happen subsequent to this CL.

TBR=sky@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1131523007

Cr-Commit-Position: refs/heads/master@{#330672}

WebGL render to texture is broken (random visual artifacts) on Chromecast.
Disabling this extension appears to fix the problem.

BUG= 489871

Review URL: https://codereview.chromium.org/1142273003

Cr-Commit-Position: refs/heads/master@{#330671}

BUG=467832

Review URL: https://codereview.chromium.org/972083002

Cr-Commit-Position: refs/heads/master@{#330670}

If we're not aggressive about expiring a retro frame (e.g. MISSED
frames) then it's possible to enter a high latency mode often.

PixelTestOutputSurface is used by the ui compositor in tests and we
should not subtract the default estimated parent draw time from the
deadline in that case. Doing so will cause MISSED frames to always
expire in tests.

BUG=469953

Review URL: https://codereview.chromium.org/1055113004

Cr-Commit-Position: refs/heads/master@{#330669}